Re: CVS commit: src/sys/external/bsd/drm2/dist/drm

2019-02-18 Thread Christos Zoulas
In article <27327.1550539...@splode.eterna.com.au>, matthew green wrote: >"Christos Zoulas" writes: >> Module Name: src >> Committed By:christos >> Date:Tue Feb 19 00:30:16 UTC 2019 >> >> Modified Files: >> src/sys/external/bsd/drm2/dist/drm/i915: intel_ddi.c intel_d

Re: CVS commit: src/sys/arch/mac68k/mac68k

2019-02-18 Thread Christos Zoulas
In article <21181.1550538...@splode.eterna.com.au>, matthew green wrote: >Christos Zoulas writes: >> In article <20190219003451.093b2f...@cvs.netbsd.org>, >> matthew green wrote: >> >-=-=-=-=-=- >> >> >+ memcpy(intrnames, inames, MAX_INAME_LENGTH); >> >> That should be: >> memcpy(intrna

re: CVS commit: src/sys/external/bsd/drm2/dist/drm

2019-02-18 Thread matthew green
"Christos Zoulas" writes: > Module Name: src > Committed By: christos > Date: Tue Feb 19 00:30:16 UTC 2019 > > Modified Files: > src/sys/external/bsd/drm2/dist/drm/i915: intel_ddi.c intel_display.c > intel_sdvo.c > src/sys/external/bsd/drm2/dist/drm/nouveau: nouveau_

re: CVS commit: src/sys/arch/mac68k/mac68k

2019-02-18 Thread matthew green
Christos Zoulas writes: > In article <20190219003451.093b2f...@cvs.netbsd.org>, > matthew green wrote: > >-=-=-=-=-=- > > >+memcpy(intrnames, inames, MAX_INAME_LENGTH); > > That should be: > memcpy(intrnames, inames, sizeof(intrnames)); well. maybe. but it's not really any better.

Re: CVS commit: src/sys/arch/mac68k/mac68k

2019-02-18 Thread Christos Zoulas
In article <20190219003451.093b2f...@cvs.netbsd.org>, matthew green wrote: >-=-=-=-=-=- >+ memcpy(intrnames, inames, MAX_INAME_LENGTH); That should be: memcpy(intrnames, inames, sizeof(intrnames)); christos

re: CVS commit: src/sys/net

2019-02-18 Thread matthew green
"Christos Zoulas" writes: > Module Name: src > Committed By: christos > Date: Mon Feb 18 23:13:14 UTC 2019 > > Modified Files: > src/sys/net: zlib.c > > Log Message: > add fallthrough's i specific avoided changing upstream code where possible by adding the relevant cflags. where