Re: CVS commit: src/sys/dev/pci

2019-03-22 Thread Michael
Hello,

On Fri, 22 Mar 2019 17:07:10 +
m...@netbsd.org wrote:

> On Fri, Mar 22, 2019 at 07:41:41AM +, Martin Husemann wrote:
> > @@ -1402,6 +1402,9 @@ radeonfb_loadbios(struct radeonfb_softc 
> > pci_find_rom(pa, romt, romh, romsz, PCI_ROM_CODE_TYPE_X86, &biosh,
> > &sc->sc_biossz);
> >  
> > +   if (sc->sc_biossz == 0 || sc->sc_bios == NULL)
> > +   return;
> > +
> >  foundit:
> > if (sc->sc_biossz > 0) {  
>   ^^^ Now the else branch isn't possible?

...and we also need to re-enable video DMA and output, so this is
wrong, and I committed a fix earlier anyway.

have fun
Michael


Re: CVS commit: src/sys/dev/pci

2019-03-22 Thread maya
On Fri, Mar 22, 2019 at 07:41:41AM +, Martin Husemann wrote:
> @@ -1402,6 +1402,9 @@ radeonfb_loadbios(struct radeonfb_softc 
>   pci_find_rom(pa, romt, romh, romsz, PCI_ROM_CODE_TYPE_X86, &biosh,
>   &sc->sc_biossz);
>  
> + if (sc->sc_biossz == 0 || sc->sc_bios == NULL)
> + return;
> +
>  foundit:
>   if (sc->sc_biossz > 0) {
^^^ Now the else branch isn't possible?