Re: CVS commit: src/sys/kern

2019-12-07 Thread Kamil Rytarowski
On 08.12.2019 00:35, matthew green wrote:
>> Module Name: src
>> Committed By:kamil
>> Date:Sat Dec  7 19:50:34 UTC 2019
>>
>> Modified Files:
>>  src/sys/kern: subr_kcov.c
>>
>> Log Message:
>> Revert the in_interrupt() change to use again the x86 specific code
>>
>> This is prerequisite for kMSan and upcoming kernel changes.
>>
>> Discussed with 
> 
> why is this?  what is the problem?
> 
> we shouldn't be putting back MD code into sys/kern files.
> the existing interface to check this *is* cpu_intr_p(),
> which should resolve to the same basic thing as the x86
> specific version.
> 
> 
> .mrg.
> 

I will let Maxime to answer.



signature.asc
Description: OpenPGP digital signature


re: CVS commit: src/sys/kern

2019-12-07 Thread matthew green
> Module Name:  src
> Committed By: kamil
> Date: Sat Dec  7 19:50:34 UTC 2019
> 
> Modified Files:
>   src/sys/kern: subr_kcov.c
> 
> Log Message:
> Revert the in_interrupt() change to use again the x86 specific code
> 
> This is prerequisite for kMSan and upcoming kernel changes.
> 
> Discussed with 

why is this?  what is the problem?

we shouldn't be putting back MD code into sys/kern files.
the existing interface to check this *is* cpu_intr_p(),
which should resolve to the same basic thing as the x86
specific version.


.mrg.


Re: CVS commit: src/share/man/man9

2019-12-07 Thread Valery Ushakov
On Sat, Dec 07, 2019 at 12:22:19 +, Thomas Klausner wrote:

> Modified Files:
>   src/share/man/man9: atomic_loadstore.9
> 
> Log Message:
> Simplify macro usage.
> 
> 
> To generate a diff of this commit:
> cvs rdiff -u -r1.3 -r1.4 src/share/man/man9/atomic_loadstore.9

This breaks formatting, adding spaces between function names and the
opening parens - though, please, don't fix that, the original markup
is way overcomplicated anyway, I'll work with riastradh@ on
improvments.

-uwe