Re: CVS commit: src/tests/lib/libarchive
On Tue, 16 Jun 2020, Martin Husemann wrote: On Tue, Jun 16, 2020 at 09:12:40AM -0700, Paul Goyette wrote: It might be better to run the test in a rump-kernel rather than in a "live" environment The test this is about is a plain userland test: it extracts/compresses/decompresses various archive formats and compares results. Only thing "special" is that it is in big parts cpu bound, and multi-threaded. If NetBSD can not gracefully deal with that, something is very wrong (which since about a month it is). This PR is on the "must be fixed before branching netbsd-10" list, and I hope it will be fixed quickly. Ah, my bad. I thought it was the watch-dog that was being tested. I certainly agree that it needs to fixed ASAP. ++--+---+ | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | (Retired) | FA29 0E3B 35AF E8AE 6651 | p...@whooppee.com | | Software Developer | 0786 F758 55DE 53BA 7731 | pgoye...@netbsd.org | ++--+---+
Re: CVS commit: src/tests/lib/libarchive
On Tue, Jun 16, 2020 at 09:12:40AM -0700, Paul Goyette wrote: > It might be better to run the test in a rump-kernel rather than in a > "live" environment The test this is about is a plain userland test: it extracts/compresses/decompresses various archive formats and compares results. Only thing "special" is that it is in big parts cpu bound, and multi-threaded. If NetBSD can not gracefully deal with that, something is very wrong (which since about a month it is). This PR is on the "must be fixed before branching netbsd-10" list, and I hope it will be fixed quickly. Martin
Re: CVS commit: src/tests/lib/libarchive
On Tue, 16 Jun 2020, Greg Troxel wrote: Jason Thorpe writes: On Jun 16, 2020, at 8:43 AM, Martin Husemann wrote: No, that is definitively not OK, which is what the PR is about. It is not OK for a regular atf run to cause a reboot of the test machine though, so this is a temporary hack around the issue (and admitedly a very ugly hack). At the very least, the user-land watchdog tickler should wire itself down. My impression of the point is that it be normal, so that the system reboots if normal processes cannot be run.It seems like once whatever bug exists is fixed, wiring is probably not necessary anyway. It might be better to run the test in a rump-kernel rather than in a "live" environment ++--+---+ | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | (Retired) | FA29 0E3B 35AF E8AE 6651 | p...@whooppee.com | | Software Developer | 0786 F758 55DE 53BA 7731 | pgoye...@netbsd.org | ++--+---+
Re: CVS commit: src/tests/lib/libarchive
Jason Thorpe writes: >> On Jun 16, 2020, at 8:43 AM, Martin Husemann wrote: >> >> No, that is definitively not OK, which is what the PR is about. >> >> It is not OK for a regular atf run to cause a reboot of the test machine >> though, so this is a temporary hack around the issue (and admitedly a very >> ugly hack). > > At the very least, the user-land watchdog tickler should wire itself down. My impression of the point is that it be normal, so that the system reboots if normal processes cannot be run.It seems like once whatever bug exists is fixed, wiring is probably not necessary anyway.
Re: CVS commit: src/tests/lib/libarchive
> On Jun 16, 2020, at 8:43 AM, Martin Husemann wrote: > > No, that is definitively not OK, which is what the PR is about. > > It is not OK for a regular atf run to cause a reboot of the test machine > though, so this is a temporary hack around the issue (and admitedly a very > ugly hack). At the very least, the user-land watchdog tickler should wire itself down. -- thorpej
Re: CVS commit: src/tests/lib/libarchive
On Tue, Jun 16, 2020 at 03:38:26PM -, Christos Zoulas wrote: > So we are saying that it is ok for process running with regular priority, > to be able to starve another process at the same priority from getting > any runtime for 21 seconds in a uniprocessor kernel, and this does not > indicate any problem with the scheduler implementation? This would mean > that for a HZ=100 kernel in 2100 rescheduling opportunities, the watchdog > thread was never selected to run? No, that is definitively not OK, which is what the PR is about. It is not OK for a regular atf run to cause a reboot of the test machine though, so this is a temporary hack around the issue (and admitedly a very ugly hack). Martin
Re: CVS commit: src/tests/lib/libarchive
In article <20200616075907.ecafcf...@cvs.netbsd.org>, Martin Husemann wrote: >-=-=-=-=-=- > >Module Name: src >Committed By: martin >Date: Tue Jun 16 07:59:07 UTC 2020 > >Modified Files: > src/tests/lib/libarchive: t_libarchive.sh > >Log Message: >PR kern/55272: skip this test on uniprocessor machines, it is too dangerous >and can kill the host kernel if a userland watchdog is running So we are saying that it is ok for process running with regular priority, to be able to starve another process at the same priority from getting any runtime for 21 seconds in a uniprocessor kernel, and this does not indicate any problem with the scheduler implementation? This would mean that for a HZ=100 kernel in 2100 rescheduling opportunities, the watchdog thread was never selected to run? christos
Re: CVS commit: src/sys/rump/include/rump
On 16.06.2020 12:25, J. Hannken-Illjes wrote: >> On 15. Jun 2020, at 01:38, Kamil Rytarowski wrote: >> >> Module Name: src >> Committed By:kamil >> Date:Sun Jun 14 23:38:25 UTC 2020 >> >> Modified Files: >> src/sys/rump/include/rump: rump.h >> >> Log Message: >> Remove old compat include of rump_syscallshotgun.h >> >> It was separated in 2016 and is no longer needed. >> >> >> To generate a diff of this commit: >> cvs rdiff -u -r1.71 -r1.72 src/sys/rump/include/rump/rump.h >> >> Please note that diffs are not public domain; they are subject to the >> copyright notices on the relevant files. > > This broke most or all NFS tests on ATF (see attached list). > > Please revert or investigate. > > -- > J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany) > I'm looking into it. signature.asc Description: OpenPGP digital signature
Re: CVS commit: src/sys/rump/include/rump
> On 15. Jun 2020, at 01:38, Kamil Rytarowski wrote: > > Module Name: src > Committed By: kamil > Date: Sun Jun 14 23:38:25 UTC 2020 > > Modified Files: > src/sys/rump/include/rump: rump.h > > Log Message: > Remove old compat include of rump_syscallshotgun.h > > It was separated in 2016 and is no longer needed. > > > To generate a diff of this commit: > cvs rdiff -u -r1.71 -r1.72 src/sys/rump/include/rump/rump.h > > Please note that diffs are not public domain; they are subject to the > copyright notices on the relevant files. This broke most or all NFS tests on ATF (see attached list). Please revert or investigate. -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany) fs/nfs/t_mountd::mountdhup fs/vfs/t_full::nfs_fillfs fs/vfs/t_io::nfs_extendfile fs/vfs/t_io::nfs_extendfile_append fs/vfs/t_io::nfs_holywrite fs/vfs/t_io::nfs_overwrite512 fs/vfs/t_io::nfs_overwrite64k fs/vfs/t_io::nfs_overwrite_trunc fs/vfs/t_io::nfs_read_after_unlink fs/vfs/t_io::nfs_read_fault fs/vfs/t_io::nfs_shrinkfile fs/vfs/t_io::nfs_wrrd_after_unlink fs/vfs/t_mtime_otrunc::nfs_otrunc_mtime_update fs/vfs/t_mtime_write::nfs_mtime_update_on_write fs/vfs/t_renamerace::nfs_renamerace fs/vfs/t_renamerace::nfs_renamerace_dirs fs/vfs/t_rmdirrace::nfs_race fs/vfs/t_ro::nfs_attrs fs/vfs/t_ro::nfs_create fs/vfs/t_ro::nfs_createdir fs/vfs/t_ro::nfs_createfifo fs/vfs/t_ro::nfs_createlink fs/vfs/t_ro::nfs_createsymlink fs/vfs/t_ro::nfs_fileio fs/vfs/t_ro::nfs_rmfile fs/vfs/t_ro::nfsro_attrs fs/vfs/t_ro::nfsro_create fs/vfs/t_ro::nfsro_createdir fs/vfs/t_ro::nfsro_createfifo fs/vfs/t_ro::nfsro_createlink fs/vfs/t_ro::nfsro_createsymlink fs/vfs/t_ro::nfsro_fileio fs/vfs/t_ro::nfsro_rmfile fs/vfs/t_rwtoro::nfs_layer_noneopen fs/vfs/t_rwtoro::nfs_layer_read_unlinked fs/vfs/t_rwtoro::nfs_layer_readopen fs/vfs/t_rwtoro::nfs_layer_writeopen fs/vfs/t_rwtoro::nfs_noneopen fs/vfs/t_rwtoro::nfs_read_unlinked fs/vfs/t_rwtoro::nfs_readopen fs/vfs/t_rwtoro::nfs_writeopen fs/vfs/t_union::nfs_basic fs/vfs/t_union::nfs_whiteout fs/vfs/t_unpriv::nfs_dirperms fs/vfs/t_unpriv::nfs_flags fs/vfs/t_unpriv::nfs_owner fs/vfs/t_unpriv::nfs_times fs/vfs/t_vfsops::nfs_tfhinval fs/vfs/t_vfsops::nfs_tfhremove fs/vfs/t_vfsops::nfs_tfilehandle fs/vfs/t_vfsops::nfs_tmount fs/vfs/t_vfsops::nfs_tstatvfs fs/vfs/t_vfsops::nfs_tsync fs/vfs/t_vnops::nfs_access_simple fs/vfs/t_vnops::nfs_attrs fs/vfs/t_vnops::nfs_create_exist fs/vfs/t_vnops::nfs_create_many fs/vfs/t_vnops::nfs_create_nametoolong fs/vfs/t_vnops::nfs_create_nonalphanum fs/vfs/t_vnops::nfs_dir_notempty fs/vfs/t_vnops::nfs_dir_rmdirdotdot fs/vfs/t_vnops::nfs_dir_simple fs/vfs/t_vnops::nfs_fcntl_getlock_pids fs/vfs/t_vnops::nfs_fcntl_lock fs/vfs/t_vnops::nfs_lookup_complex fs/vfs/t_vnops::nfs_lookup_simple fs/vfs/t_vnops::nfs_lstat_symlink fs/vfs/t_vnops::nfs_read_directory fs/vfs/t_vnops::nfs_rename_dir fs/vfs/t_vnops::nfs_rename_dotdot fs/vfs/t_vnops::nfs_rename_nametoolong fs/vfs/t_vnops::nfs_rename_reg_nodir fs/vfs/t_vnops::nfs_symlink_long fs/vfs/t_vnops::nfs_symlink_root fs/vfs/t_vnops::nfs_symlink_zerolen signature.asc Description: Message signed with OpenPGP
