Re: CVS commit: src/sys/dev/ic
In article <18083.1593053...@splode.eterna.com.au>, matthew green wrote: >"Jaromir Dolecek" writes: >> Module Name: src >> Committed By:jdolecek >> Date:Wed Jun 24 19:55:25 UTC 2020 >> >> Modified Files: >> src/sys/dev/ic: ibm561.c >> >> Log Message: >> avoid allocating almost 5k struct ibm561data on stack in ibm561_cninit(); >> it's too early for kmem_alloc(), so use static variable in BSS > >this seems particularly wasteful for a driver that won't >be useful for most systems. > >seems like a candidate for allow-listing instead, and as >it seems to only be relevant for alpha systems, that have >a fairly large stack (16K), and this will be called with >a fairly short call stack. I agree; the BSS kludge is ugly in general and should only be used sparingly. christos
re: CVS commit: src/external/cddl/dtracetoolkit/dist/Man/man1m
> > The best way should be automatically converting them by some script > > when building. But if it is too difficult, we can install these files > > as is with minimum adjustments for our system; mandoc still works for > > them, although output is not very beautiful. > > I shouldn't have made the changes here for another reason, as the > manuals are in man1m/$name.1m, it doesn't fit in easily with the > mechanism we have in src/share/mk for installing manuals which assumes > $name.[1-9]. the manual in the tree might be called "foo.1m" by upstream, however, we should just install those into man8/foo.8. be nice to have a generic 1m -> 8 rule here, since i doubt that upstream will change from svr4/solaris naming. .mrg.
Re: CVS commit: src/external/cddl/dtracetoolkit/dist/Man/man1m
On 2020/06/25 17:39, Sevan Janiyan wrote: On 25/06/2020 08:48, Rin Okuyama wrote: > Thank you for working on this, but this makes sync with upstream > very difficult... I will be upstreaming these changes. upstream: github.com/opendtrace/toolkit Just need to find a better way for presenting the columns for field descriptions, before I raise the pull request. Thank you! > The best way should be automatically converting them by some script > when building. But if it is too difficult, we can install these files > as is with minimum adjustments for our system; mandoc still works for > them, although output is not very beautiful. I shouldn't have made the changes here for another reason, as the manuals are in man1m/$name.1m, it doesn't fit in easily with the mechanism we have in src/share/mk for installing manuals which assumes $name.[1-9]. Hmm, no idea at the moment... Thanks, rin
Re: CVS commit: src/external/cddl/dtracetoolkit/dist/Man/man1m
Hello, On 25/06/2020 08:48, Rin Okuyama wrote: > Thank you for working on this, but this makes sync with upstream > very difficult... I will be upstreaming these changes. upstream: github.com/opendtrace/toolkit Just need to find a better way for presenting the columns for field descriptions, before I raise the pull request. > The best way should be automatically converting them by some script > when building. But if it is too difficult, we can install these files > as is with minimum adjustments for our system; mandoc still works for > them, although output is not very beautiful. I shouldn't have made the changes here for another reason, as the manuals are in man1m/$name.1m, it doesn't fit in easily with the mechanism we have in src/share/mk for installing manuals which assumes $name.[1-9]. Sevan
Re: CVS commit: src/external/cddl/dtracetoolkit/dist/Man/man1m
Hi, On 2020/06/25 3:06, Sevan Janiyan wrote: Module Name:src Committed By: sevan Date: Wed Jun 24 18:06:01 UTC 2020 Modified Files: src/external/cddl/dtracetoolkit/dist/Man/man1m: opensnoop.1m Log Message: mdocify Thank you for working on this, but this makes sync with upstream very difficult... The best way should be automatically converting them by some script when building. But if it is too difficult, we can install these files as is with minimum adjustments for our system; mandoc still works for them, although output is not very beautiful. Thanks, rin
