Re: [statfs12] CVS commit: src
Le 27/06/2020 à 17:50, Christos Zoulas a écrit : Please revert all of this change. First, there was a clear vulnerability in this change, which I fixed in: https://mail-index.netbsd.org/source-changes/2020/06/27/msg118731.html Then, as I said in the change, there are additional problems: 137 static __inline int 138 statvfs_to_statfs12_copy(const void *vs, void *vs12, size_t l) 139 { 140 struct statfs12 *s12 = STATVFSBUF_GET(); 141 int error; 142 143 statvfs_to_statfs12(vs, s12); 144 error = copyout(s12, vs12, l); 145 STATVFSBUF_PUT(s12); 146 147 return error; 148 } STATVFSBUF_GET() allocates struct statvfs, but here we're using struct statfs12. How can this be expected to be correct? It is larger than needed, so it works. Why insist on using the wrong structure, when you could just as easily use the correct structure? I don't get the point. Maxime
Re: CVS commit: src/external/bsd/kyua-cli
In article <20200702140653.gf12...@mewburn.net>, Luke Mewburn wrote: >On 20-06-21 18:23, Christos Zoulas wrote: > | In article <20200621142616.60471f...@cvs.netbsd.org>, > | Luke Mewburn wrote: > | >-=-=-=-=-=- > | > > | >Module Name: src > | >Committed By: lukem > | >Date: Sun Jun 21 14:26:16 UTC 2020 > | > > | >Modified Files: > | > src/external/bsd/kyua-cli: Makefile.inc > | > > | >Log Message: > | >kyua-cli: avoid warning about deprecated auto_ptr > | > | Can you sed -ie s/auto_ptr/unique_ptr/g instead? > | You'll need to do this for c++-17 anyway. > >Done. Needed a little bit more than that because kyua-cli >was passing auto_ptrs around as function arguments or assigning >to globals; both fixed with std::move(). Cool, thanks! christos
Re: CVS commit: src/sys/arch/aarch64/aarch64
I think this will have issues on some big.LITTLE configurations like Rockchip RK3399. In the RK3399 case cpu[0-3] is VIPT I$ and cpu[4-5] is PIPT I$. Boot order of secondaries is not guaranteed so it is possible to get different values of aarch64_cache_vindexsize from one boot to the next. Jared On Thu, 2 Jul 2020, Rin Okuyama wrote: Module Name:src Committed By: rin Date: Thu Jul 2 12:59:31 UTC 2020 Modified Files: src/sys/arch/aarch64/aarch64: pmap.c Log Message: Set uvmexp.ncolors appropriately, which is required for some CPU models with VIPT icache. Otherwise, alias in virtual address results in inconsistent results, at least for applications that rewrite text of other process, e.g., GDB for arm32. Also, this hopefully fixes other unexpected failures due to alias. Confirmed that there's no observable regression in performance; difference in ``time make -j8'' for GENERIC64 kernel on BCM2837 with and without setting uvmexp.ncolors is within 0.1%. Thanks to ryo@ for discussion. To generate a diff of this commit: cvs rdiff -u -r1.80 -r1.81 src/sys/arch/aarch64/aarch64/pmap.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
Re: CVS commit: src/sys/arch/ia64/stand/ia64/efi
Martin Husemann writes: > > That build pre-dates Luke's fix. > Ahh, you are correct and it built fine for me, apologies. Thanks
Re: CVS commit: src/sys/arch/ia64/stand/ia64/efi
On Thu, Jul 02, 2020 at 08:03:09AM -0700, scole_mail wrote: > That change didn't work: > > http://releng.netbsd.org/builds/HEAD/202007020210Z/ia64.build.failed > ... > nbmake[10]: nbmake[10]: don't know how to make loader.efi.c. Stop That build pre-dates Luke's fix. Martin
Re: CVS commit: src/sys/arch/ia64/stand/ia64/efi
"Luke Mewburn" writes: > Module Name: src > Committed By: lukem > Date: Thu Jul 2 09:07:25 UTC 2020 > > Modified Files: > src/sys/arch/ia64/stand/ia64/efi: Makefile > > Log Message: > loader.efi doesn't have source > > (Untested fix) > > > To generate a diff of this commit: > cvs rdiff -u -r1.6 -r1.7 src/sys/arch/ia64/stand/ia64/efi/Makefile > > Please note that diffs are not public domain; they are subject to the > copyright notices on the relevant files. That change didn't work: http://releng.netbsd.org/builds/HEAD/202007020210Z/ia64.build.failed ... nbmake[10]: nbmake[10]: don't know how to make loader.efi.c. Stop
Re: CVS commit: src/external/bsd/kyua-cli
On 20-06-21 18:23, Christos Zoulas wrote: | In article <20200621142616.60471f...@cvs.netbsd.org>, | Luke Mewburn wrote: | >-=-=-=-=-=- | > | >Module Name: src | >Committed By: lukem | >Date: Sun Jun 21 14:26:16 UTC 2020 | > | >Modified Files: | > src/external/bsd/kyua-cli: Makefile.inc | > | >Log Message: | >kyua-cli: avoid warning about deprecated auto_ptr | | Can you sed -ie s/auto_ptr/unique_ptr/g instead? | You'll need to do this for c++-17 anyway. Done. Needed a little bit more than that because kyua-cli was passing auto_ptrs around as function arguments or assigning to globals; both fixed with std::move().