Re: CVS commit: othersrc/usr.bin/tnftp

[Christos Zoulas]

In article <20200707023354.gv12...@mewburn.net>,
Luke Mewburn   wrote:
>On 20-07-05 22:06, Christos Zoulas wrote:
>  | In article <20200705105511.91226f...@cvs.netbsd.org>,
>  | Luke Mewburn  wrote:
>  | >-=-=-=-=-=-
>  | >
>  | >Module Name:  othersrc
>  | >Committed By: lukem
>  | >Date: Sun Jul  5 10:55:11 UTC 2020
>  | >
>  | >Modified Files:
>  | >  othersrc/usr.bin/tnftp: ChangeLog NEWS configure.ac
>  | >
>  | >Log Message:
>  | >Only replace glob if GLOB_BRACE and GLOB_TILDE aren't available.
>  | 
>  | More importantly for ftp GLOB_LIMIT.
>
>usr.bin/tnftp (from ftp) does not use GLOB_LIMIT, so I don't need to
>check if the system glob() supports it.
>
>libexec/tnftpd (from ftpd) does use GLOB_LIMIT, but that build hasn't
>yet been modified to check if the system glob() is sufficient. I'll do
>that sometime, but I will ensure that configure check also checks for
>GLOB_LIMIT.

Thanks, I confused tnftp and tnftpd.

christos

Re: CVS commit: othersrc/usr.bin/tnftp

[Christos Zoulas]

In article <20200707021514.gu12...@mewburn.net>,
Luke Mewburn   wrote:
>On 20-07-05 22:07, Christos Zoulas wrote:
>  | In article <20200705105548.f0265f...@cvs.netbsd.org>,
>  | Luke Mewburn  wrote:
>  | >-=-=-=-=-=-
>  | >
>  | >Module Name:  othersrc
>  | >Committed By: lukem
>  | >Date: Sun Jul  5 10:55:48 UTC 2020
>  | >
>  | >Modified Files:
>  | >  othersrc/usr.bin/tnftp: configure tnftp_config.h.in
>  | 
>  | And GLOB_NOCHECK.
>
>AFAICT, GLOB_NOCHECK is "standard POSIX" and not a BSD/GNU extension,
>so I figured I didn't need to check for it.
>Do you know of systems that provide  and glob() but
>don't support GLOB_NOCHECK() ?

No, I don't but it is simple enough to |GLOB_NOCHECK in the test.
I just listed all the flags tnftp uses I think.

christos