Re: CVS commit: src/sys/arch/arm/arm

2020-11-11 Thread Rin Okuyama

On 2020/11/12 6:52, matthew green wrote:

"Rin Okuyama" writes:

Module Name:src
Committed By:   rin
Date:   Tue Nov 10 21:40:07 UTC 2020

Modified Files:
src/sys/arch/arm/arm: cpu_exec.c

Log Message:
Test (epp->ep_esch->es_emul != _netbsd) instead of


nice, this is a step forward.

an optimisation on it could be to remove this test entirely
if neither MODULAR or COMAPT_NETBSD32 are set, as it will
always be false there.


Ah, yes. I will commit after some test. Thanks!

rin


re: CVS commit: src/sys/arch/arm/arm

2020-11-11 Thread matthew green
"Rin Okuyama" writes:
> Module Name:  src
> Committed By: rin
> Date: Tue Nov 10 21:40:07 UTC 2020
>
> Modified Files:
>   src/sys/arch/arm/arm: cpu_exec.c
>
> Log Message:
> Test (epp->ep_esch->es_emul != _netbsd) instead of

nice, this is a step forward.

an optimisation on it could be to remove this test entirely
if neither MODULAR or COMAPT_NETBSD32 are set, as it will
always be false there.

thanks.


.mrg.


Re: please put back cat man pages, and what's the deal with warp?

2020-11-11 Thread Kamil Rytarowski
On 11.11.2020 11:05, nia wrote:
> https://github.com/NetBSD/src/blob/8dacd60b50e3047dcbb2645d41df02cd16fd2072/games/warp/warp.c#L10
> 
> this doesn't read like a netbsd-compatible software license.
> 

Fixed. It was an leftover. If there is anything else, please let me know.

> it's using libcompat. should new programs in base really be relying on
> ancient bsd compat?
> 

No, but on the other hand it was exposed that software using old tty is
not buildable after this commit:

https://github.com/NetBSD/src/commit/573acd495de4cf3c5dbe2c50ec5071a25f8027e6

Symbols such as ECHO are missing. Can we either drop ioctl_compat.h or
reintroduce the symbols? Missing old and new tty headers didn't work
when I tried it (at least before more renovation in warp(6) from christos@).


Re: please put back cat man pages, and what's the deal with warp?

2020-11-11 Thread nia
https://github.com/NetBSD/src/blob/8dacd60b50e3047dcbb2645d41df02cd16fd2072/games/warp/warp.c#L10

this doesn't read like a netbsd-compatible software license.

it's using libcompat. should new programs in base really be relying on
ancient bsd compat?