Re: CVS commit: othersrc/usr.bin/sleepto

2021-02-25 Thread Simon Burge
Christos Zoulas wrote:

> In article <20210225070357.a0c7bf...@cvs.netbsd.org>,
> Simon Burge  wrote:
> >-=-=-=-=-=-
> >
> >Module Name: othersrc
> >Committed By:simonb
> >Date:Thu Feb 25 07:03:57 UTC 2021
> >
> >Added Files:
> > othersrc/usr.bin/sleepto: Makefile parsetime.c parsetime.h sleepto.c
> > tzfile.h
> >
> >Log Message:
> >Jared's sleepto command from Dec 2007 - sleep to an at(1) style time
> >specification.
>
> We do have parsedate(3) in libutil which seems to do a lot more.

Cool, I will have a look at that.  Thinking about adding this to our
existing sleep(1), so anything in existing libraries that makes this
(much!) easier is welcome.

And will look at %jd and intmax_t too (ta).

Cheers,
Simon.


Re: CVS commit: src/external/bsd/nvi/usr.bin/nvi

2021-02-25 Thread Christos Zoulas
Too bad, looks like they just made a copy of the FreeBSD changes. I will revert.

christos

> On Feb 25, 2021, at 6:47 PM, Rin Okuyama  wrote:
> 
> Hi,
> 
> This does not work since nvi requires non-standard wregex API, whose
> ``char *'' arguments are replaced by ``wchar_t *'' ones:
> 
> https://mail-index.netbsd.org/tech-userlevel/2008/08/06/msg000960.html
> https://mail-index.netbsd.org/tech-userlevel/2008/08/06/msg000967.html
> 
> In principle, we can rewrite nvi to use standard regex API, but this
> causes wide to multibyte char conversion *every time* for text search
> (internal encoding of nvi is wide char). I'm not sure whether this is
> acceptable for users of slow machines, who merely want to edit ASCII
> texts.
> 
> Thanks,
> rin
> 
> On 2021/02/26 6:56, Christos Zoulas wrote:
>> Module Name: src
>> Committed By:christos
>> Date:Thu Feb 25 21:56:35 UTC 2021
>> Modified Files:
>>  src/external/bsd/nvi/usr.bin/nvi: Makefile
>> Log Message:
>> we don't need the extra copy wide-regex anymore.
>> To generate a diff of this commit:
>> cvs rdiff -u -r1.22 -r1.23 src/external/bsd/nvi/usr.bin/nvi/Makefile
>> Please note that diffs are not public domain; they are subject to the
>> copyright notices on the relevant files.



signature.asc
Description: Message signed with OpenPGP


Re: CVS commit: src/external/bsd/nvi/usr.bin/nvi

2021-02-25 Thread Rin Okuyama

Hi,

This does not work since nvi requires non-standard wregex API, whose
``char *'' arguments are replaced by ``wchar_t *'' ones:

https://mail-index.netbsd.org/tech-userlevel/2008/08/06/msg000960.html
https://mail-index.netbsd.org/tech-userlevel/2008/08/06/msg000967.html

In principle, we can rewrite nvi to use standard regex API, but this
causes wide to multibyte char conversion *every time* for text search
(internal encoding of nvi is wide char). I'm not sure whether this is
acceptable for users of slow machines, who merely want to edit ASCII
texts.

Thanks,
rin

On 2021/02/26 6:56, Christos Zoulas wrote:

Module Name:src
Committed By:   christos
Date:   Thu Feb 25 21:56:35 UTC 2021

Modified Files:
src/external/bsd/nvi/usr.bin/nvi: Makefile

Log Message:
we don't need the extra copy wide-regex anymore.


To generate a diff of this commit:
cvs rdiff -u -r1.22 -r1.23 src/external/bsd/nvi/usr.bin/nvi/Makefile

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.


Re: CVS commit: othersrc/usr.bin/sleepto

2021-02-25 Thread Christos Zoulas
In article <20210225070357.a0c7bf...@cvs.netbsd.org>,
Simon Burge  wrote:
>-=-=-=-=-=-
>
>Module Name:   othersrc
>Committed By:  simonb
>Date:  Thu Feb 25 07:03:57 UTC 2021
>
>Added Files:
>   othersrc/usr.bin/sleepto: Makefile parsetime.c parsetime.h sleepto.c
>   tzfile.h
>
>Log Message:
>Jared's sleepto command from Dec 2007 - sleep to an at(1) style time
>specification.

We do have parsedate(3) in libutil which seems to do a lot more.

christos



Re: CVS commit: othersrc/usr.bin/sleepto

2021-02-25 Thread Christos Zoulas
In article <20210225101838.bc47cf...@cvs.netbsd.org>,
Simon Burge  wrote:
>-=-=-=-=-=-
>
>Module Name:   othersrc
>Committed By:  simonb
>Date:  Thu Feb 25 10:18:38 UTC 2021
>
>Modified Files:
>   othersrc/usr.bin/sleepto: sleepto.c
>
>Log Message:
>Use %lld and cast to "long long" for any time_t's.

Better %jd and (intmax_t)

christos



Re: CVS commit: src/lib/libc/regex

2021-02-25 Thread Christos Zoulas
In article <5c9e716-7ec1-9c7d-a7cb-21f08946...@invisible.ca>,
Jared McNeill   wrote:
>Building tools on macOS:
>
>/Users/jmcneill/netbsd/git-src/tools/compat/../../lib/libc/regex/regcomp.c:1585:8:
> 
>error: implicit declaration of function 'reallocarray' is invalid
>   in C99 [-Werror,-Wimplicit-function-declaration]
> ncs = reallocarray(p->g->sets, p->g->ncsets + 1, sizeof(*ncs));
>   ^
>/Users/jmcneill/netbsd/git-src/tools/compat/../../lib/libc/regex/regcomp.c:1585:8:
> 
>note: did you mean 'reallocarr'?
>/Users/jmcneill/netbsd/git-src/tools/compat/compat_defs.h:556:5: note: 
>'reallocarr' declared here
>int reallocarr(void *, size_t, size_t);
> ^

Fixed, thanks!

christos



Re: CVS commit: src/lib/libc/regex

2021-02-25 Thread Jared McNeill

Building tools on macOS:

/Users/jmcneill/netbsd/git-src/tools/compat/../../lib/libc/regex/regcomp.c:1585:8: 
error: implicit declaration of function 'reallocarray' is invalid

  in C99 [-Werror,-Wimplicit-function-declaration]
ncs = reallocarray(p->g->sets, p->g->ncsets + 1, sizeof(*ncs));
  ^
/Users/jmcneill/netbsd/git-src/tools/compat/../../lib/libc/regex/regcomp.c:1585:8: 
note: did you mean 'reallocarr'?
/Users/jmcneill/netbsd/git-src/tools/compat/compat_defs.h:556:5: note: 
'reallocarr' declared here

int reallocarr(void *, size_t, size_t);
^


On Tue, 23 Feb 2021, Christos Zoulas wrote:


Module Name:src
Committed By:   christos
Date:   Tue Feb 23 22:14:59 UTC 2021

Modified Files:
src/lib/libc/regex: cname.h engine.c re_format.7 regcomp.c regerror.c
regex.3 regex2.h regexec.c regfree.c utils.h
Removed Files:
src/lib/libc/regex: cclass.h

Log Message:
sync with FreeBSD:
   - NLS support
   - GNU extensions
   - bug fixes


To generate a diff of this commit:
cvs rdiff -u -r1.7 -r0 src/lib/libc/regex/cclass.h
cvs rdiff -u -r1.7 -r1.8 src/lib/libc/regex/cname.h
cvs rdiff -u -r1.24 -r1.25 src/lib/libc/regex/engine.c
cvs rdiff -u -r1.12 -r1.13 src/lib/libc/regex/re_format.7
cvs rdiff -u -r1.38 -r1.39 src/lib/libc/regex/regcomp.c
cvs rdiff -u -r1.23 -r1.24 src/lib/libc/regex/regerror.c
cvs rdiff -u -r1.26 -r1.27 src/lib/libc/regex/regex.3
cvs rdiff -u -r1.13 -r1.14 src/lib/libc/regex/regex2.h
cvs rdiff -u -r1.22 -r1.23 src/lib/libc/regex/regexec.c
cvs rdiff -u -r1.15 -r1.16 src/lib/libc/regex/regfree.c
cvs rdiff -u -r1.6 -r1.7 src/lib/libc/regex/utils.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.