.
--apb (Alan Barrett)
On Fri, 24 Apr 2015, Taylor R Campbell wrote:
Modified Files:
src/share/misc: acronyms acronyms-o.real
Log Message:
Per discussion with board@, remove inappropriate, hostile acronyms.
Thank you.
--apb (Alan Barrett)
was controversial.
Continuing without discussion is not appropriate.
I think that NetBSD's acronyms file should be for acronyms that
ordinary people are likely to encounter in ordinary situations;
not for acronyms used in some small subculture.
--apb (Alan Barrett)
a test that uses nm|awk to check that all
externally visible symbols have some desired prefix.
--apb (Alan Barrett)
is distinct from %Z) already accepts GMT
and UT. If we are going to accept UTC as well, which I think
is a good idea, then please allow both %z and %Z to accept all
three of UT, UTC, and GMT.
--apb (Alan Barrett)
name
contains a space. Whether or not it's supported is separate from
whether or not the service(8) script does strange things when it
happens.
--apb (Alan Barrett)
it was made u_int to match previous art by FreeBSD. Can you please
explain why it needs compat32 handling?
Sorry, it doesn't need compat32 handling, because all existing
NetBSD platforms have 32-bit int, and all exiting NetBSD platforms
have 64-bit off_t.
--apb (Alan Barrett)
On Mon, 29 Dec 2014, Michael van Elst wrote:
Log Message:
Implement DIOCGMEDIASIZE and DIOCGSECTORSIZE from FreeBSD.
This needs compat32 handling, at least for the u_int arg to
DIOCGSECTORSIZE.
Why not make it a fixed size, like uint32_t, so compat32 handling will
not be needed?
--apb (Alan
On Mon, 17 Nov 2014, Masao Uebayashi wrote:
How about adding a new make variable CONFIGOPTS, which is passed to config(1)?
This name is similar to COPTS and works similarly too.
Yes, that could work.
--apb (Alan Barrett)
or in the kernel configuration?
Was this discussed anywhere?
--apb (Alan Barrett)
as though it would do what I want.
--apb (Alan Barrett)
it back.
In the cases that I care about, the options and no options
lines will be in different files, referenced via include
directives.
--apb (Alan Barrett)
fix it in NetBSD's bsd.own.mk then, which was where I took
the definition above from.
It probably works because .OBJDIR is magic, and is unlikely to need
recursive expansion.
--apb (Alan Barrett)
'${.OBJDIR}' to
get the recursively-expanded value of .OBJDIR. ${MAKE} -V .OBJDIR
would print the unexpanded value.
--apb (Alan Barrett)
to wait a few
days. Meanwhile, backing out the problematic revision should be
fine.
--apb (Alan Barrett)
), and if that fails then try
open(O_SPECIAL).
--apb (Alan Barrett)
; } while (0)
a week or two ago. (That change was not pulled up to netbsd-7,
although other changes made around the same time were pulled up.)
Do we need to support any compilers that don't support __VA_ARGS__ ?
Even microsoft's compiler almost supports it.
I don't know.
--apb (Alan Barrett)
-modern toolchain I can think of without C99 support is MSVC and we
don't support that anyway.
Perhaps it does make sense to allow C99 in tools, but I think we
have tried to avoid it until now.
--apb (Alan Barrett)
.)
Can you say that again, please?
I think he means: Please add links from
http://www.netbsd.org/developers/releng/pullups.html
to https://releng.netbsd.org/index-7.html,
https://releng.netbsd.org/index-6.html, and
https://releng.netbsd.org/index-5.html.
--apb (Alan Barrett)
by the don't
encode this list.
--apb (Alan Barrett)
it.
unvis is not intended to reverse shell-style escapes. You can use
the shell's eval command for that.
--apb (Alan Barrett)
from the section
about things that may be removed in the future. Please also add
rtsol to the section about things that have been removed.
--apb (Alan Barrett)
restricted list of interface names.
--apb (Alan Barrett)
to pull
up the ifconfig -w change and the rc.d/network changes to other
branches.
--apb (Alan Barrett)
to do
with changing defaults. Also, it probably needs a man page update.
--apb (Alan Barrett)
, but are not.
INITIALIZE(ktime);
+ ktime = 0; /* XXX: gcc */
The #define GNUC_or_lint and #ifdef GNUC_or_lint in time/private.h
should have made it so INITIALIZE(ktime) was enough.
--apb (Alan Barrett)
().
- Make ptyfs_used_get() private to ptyfs_subr.c
- Stop copying device attributes from traditional ptys on first allocation.
- Remove unneeded argument lwp from ptyfs_allocvp() and ptyfs_free_get().
Please could you update the mount_ptyfs(8) man page to explain the
new behaviour.
--apb (Alan Barrett)
them as obsolete
instead,
} #unless otherwise stated below.
^
Heh, thanks for the reminder. I'll fix it.
--apb (Alan Barrett)
) but to round down (and to return 0 for
very small inputs) when hz 100. Once the desired behaviour is
clarified, you could implement it by making adjustments to the
value before or after calling tvtohz.
--apb (Alan Barrett)
these ioctls in any compat code.
--apb (Alan Barrett)
reverted for being rushed, then
please import it on a vendor branch as per the usual practice.
Did you mean moving it from -current to a specific branch?
No, I mean using cvs import the way we usually do it. I'll explain
in more detail in a private message.
--apb (Alan Barrett)
different output streams from the same initial seed or
state.
--apb (Alan Barrett)
, please just write __RCSID(...);
without any #if/#endif wrapper.
--apb (Alan Barrett)
- net.inet6.multicast_kludge for temporarily removed multicast groups
Please document these in sysctl(7).
--apb (Alan Barrett)
On Sat, 24 May 2014, Masao Uebayashi wrote:
Log Message:
Unbreak syspkg by escaping '[' by vis(1) to match the new mtree(8) format.
I'd prefer to escape using TOOL_SED so we don't need to add a new
TOOL_VIS.
--apb (Alan Barrett)
On Sat, 17 May 2014, Christos Zoulas wrote:
Add tzdata2netbsd, a script to help import new versions of tzdata.
Why all the || exit $? instead of set -e
set -e would probably be better.
--apb (Alan Barrett)
for restricted namespaces...
src/tools/compat/compat_defs.h goes to a lot of trouble to ensure
that _NETBSD_SOURCE does not get defined. I don't understand why
that is done.
--apb (Alan Barrett)
.
and 7.21.2.1 The memcpy function does not give any explicit
permission for use of null pointers.
I don't object if the implementation wants to allow null pointers
with zero size as an extension, but it should be clear that this
is non-standard.
--apb (Alan Barrett)
to match
the description in hier(7) perfectly.
--apb (Alan Barrett)
(__HEADER_NAME_TOKEN)
# define __tmp_z2 __HEADER_NAME_TOKEN
# else
# define __tmp_z2 /* Empty */
# endif
# define __CTASSERT(x) _CTASSERT0(x, __ctassert, __tmp_z1, __tmp_z2, __LINE__)
# undef __tmp_z1
# undef __tmp_z2
#endif
--apb (Alan Barrett)
that meets all reasonable requirements for compatibility.
--apb (Alan Barrett)
.
--apb (Alan Barrett)
) CTL_CREATE idiom?
--apb (Alan Barrett)
deleting them.
--apb (Alan Barrett)
. type
f -print, but I'd like the options to be compatible with other
operating systems.
--apb (Alan Barrett)
replacements), and
what are the replacements?
I see no mention of deprecation in the man page for a version of
atf-run from November 2013.
--apb (Alan Barrett)
On Wed, 29 Jan 2014, Matt Thomas wrote:
Modified Files:
src/sys/arch/arm/include: int_fmtio.h int_mwgwtypes.h
Log Message:
Make {,u}int{8,16,32} be of type int.
I think you mean:
Make {,u}int_fast{8,16,32} be of type int.
--apb (Alan Barrett)
.
Will this make malloc fail 0.5GB earlier than before? The data
size limits on i386 are already annoyingly small, and I would
prefer not to make them smaller. Please could you find a way to
penalise only a.out programs.
--apb (Alan Barrett)
.
--apb (Alan Barrett)
, then please adjust bsd.README to say so.
Currently, they are documented as being independent (but there
seem to be some accidental yes/no inversions in the documentation).
--apb (Alan Barrett)
/dirname/destination/destination
ln -sfh is not portable, so we can't use that.
--apb (Alan Barrett)
with
#ifndef __dead
#define __dead /* nothing */
#endif
--apb (Alan Barrett)
of the variable
definitions from bsd.sys.mk can be moved to bsd.own.mk, or a file
that's included by bsd.own.mk.
Also, if you think that Makefiles should not include bsd.sys.mk,
then please edit share/mk/bsd.README to document how things should
be done.
--apb (Alan Barrett)
On Mon, 06 Jan 2014, Alan Barrett wrote:
On Mon, 06 Jan 2014, Erik Fair wrote:
Unless I misunderstand NTP configuration semantics, your additional
restrict statements for the NTP pool names will do the wrong
thing, in that each reference to a given netbsd.pool.ntp.org name
returns multiple IP
nopeer noquery (the uncommented
line in my commit), then time service will still work, but the
configured servers will be denied query permission.
If you use restrict default ignore, then time service does not
work.
--apb (Alan Barrett)
usable by the kernel.
* change lua_Number to int64_t for the kernel Lua implementation.
I would have preferred to see two separate commits. Even with only
one commit, the log message should have described both changes.
--apb (Alan Barrett)
that without booting a different kernel for
every test.
- rmind has said he'll address this eventually,
OK.
--apb (Alan Barrett)
Message:
implement AT_RANDOM.
random() returns a predictable value based on a seed. Given the
supposed use of AT_RANDOM for security, I think that it would be more
appropriate to use a stronger source, such as cprng_strong32().
--apb (Alan Barrett)
On Thu, 31 Oct 2013, Marc Balmer wrote:
Modified Files:
src/sys/modules/lua: Makefile
Log Message:
fix build on arm
Please describe the actual change, not just the reason for it.
Fopr example:
Move -include ${.CURDIR}/luaconf.h from CPPFLAGS to CFLAGS.
--apb (Alan Barrett)
On Mon, 28 Oct 2013, Marc Balmer wrote:
Modified Files:
src/distrib/sets/lists/modules: mi
src/sys/modules: Makefile
Log Message:
linke pmf(9l) to the build
Messages like this would be more useful if they said 9lua instyead
of 9l.
--apb (Alan Barrett)
tried to collect some of these to attribute(3), which might be worth
updating (or not).
Thank you! I didn't know about attribute(3).
--apb (Alan Barrett)
it's fine.
--apb (Alan Barrett)
On Fri, 18 Oct 2013, Christos Zoulas wrote:
The result from strlen() has type size_t, so print it with %zd format.
%zu is correct.
Fixed, thanks.
this. Please don't steamroll over public discussions like
this.
Just for the record, yes, I got core's approval.
Could you tell us approximately when you got that approval? It
wasn't in the past two years while I have been a member of core.
--apb (Alan Barrett)
,
while ask means ask the user (the first time). If the DNS
answer was not secured by DNSSEC, then both yes and ask end up
asking the user.
By the way, I think that's a bug in ssh that the Host patterns are
case sensitive.
--apb (Alan Barrett)
to this
import, will not be obvious to future users of cvs log.
If the ChangeLog is small, then pasting it into the commit log is
useful. If the ChangeLog is large, then please extract only the
highlights.
--apb (Alan Barrett)
On Mon, 02 Sep 2013, Simon J. Gerraty wrote:
Modified Files:
src/usr.bin/make: compat.c
Log Message:
Do not apply shellErrFlag unless errCheck is true.
To generate a diff of this commit:
cvs rdiff -u -r1.92 -r1.93 src/usr.bin/make/compat.c
Will this fix PR 45356?
--apb (Alan
be inclined to say
Coverity CID instead of just CID in these log
messages.
--apb (Alan Barrett)
?
If time_t is a floating point type, then round to the nearest
second. If time_t is an integral type, then do nothing. There
really should be a comment to explain that.
--apb (Alan Barrett)
); (_x _y ? _x : _y); })
--apb (Alan Barrett)
for the hostname.
-I Display each IP address on all interfaces.
-i Display the IP address(es) for the hostname.
Not to go all Rob Pike on you (cf. cat -v considered harmful),
but what the heck is all this for?
And also: Where was this change discussed?
--apb (Alan Barrett)
(Alan Barrett)
On Sun, 07 Jul 2013, Erik Fair wrote:
Pullup request to netbsd-6 and netbsd-5?
Yes, I always request such pullups. I like to wait a day or two, but
it's occasionally taken me much longer than that.
--apb (Alan Barrett)
).
By the way, I have an implementation of consttime_memcmp()
at ftp://ftp.netbsd.org/pub/NetBSD/misc/apb/consttime_memcmp.c.
--apb (Alan Barrett)
On Mon, 24 Jun 2013, Taylor R Campbell wrote:
Discuss on tech-userlevel?
Yes please.
--apb (Alan Barrett)
polluting the namespace, and then use
__intptr_t.
--apb (Alan Barrett)
for the
${TOOL_GROFF} command there, feel free to edit the Makefile.
--apb (Alan Barrett)
On Sat, 11 May 2013, Blue Rats wrote:
.Fn iconv_close ,
and
.Fn iconv
-conform to
+conforms to
.St -p1003.1-2001 .
conform was correct, and conforms is wrong. Please reinstate the
correct wording.
--apb (Alan Barrett)
phase. I am not sure why it's not
good enough for host-mkdep, but two ideas spring to mind: perhaps
host-mkdep is run before the dummy include file is created, or
perhaps host-mkdep is run without the -I flags that would allow it
to find the dummy include file.
--apb (Alan Barrett)
the underlying problem without adding a new special target,
such as using the newish meta mode. Also, a better name than
.STALE might have been suggested.
--apb (Alan Barrett)
about characters,
that's because it was written at a time when vis did not attempt
to deal with multibyte characters. I think that we should revert
to the original semantics of lengths being measured in bytes, and
adjust both the man pages and callers appropriately.
--apb (Alan Barrett)
I and II, 2 for
UltraSPARC-III and up
Does this need to use #define CPU_VIS, or could it use a new-style
dynamic MIB entry, passing CTL_CREATE to sysctl_createv(9)?
--apb (Alan Barrett)
of bar.
--apb (Alan Barrett)
kind
of overflow. I'd expect an error like EINVAL rather than an error like
ENOMEM for this case.
--apb (Alan Barrett)
tappit-hen as an example.
Good idea.
--apb (Alan Barrett)
_GCC_CRTN!= ${CC} --print-file-name=crtn.o
.for v in _GCC_CRTBEGINS _GCC_CRTENDS _GCC_CRTI _GCC_CRTN
# If the value does not contain '/' then replace it with the empty string
${v} := ${${v}:C,^[^/]*$,,}
.endfor
--apb (Alan Barrett)
this?
__COUNTER__ is used by the definition of __CTASSERT in sys/cdefs.h.
If __COUNTER__ is not available, it falls back to using __LINE__,
but that's not necessarily unique.
--apb (Alan Barrett)
On Fri, 09 Nov 2012, David Holland wrote:
On Fri, Nov 09, 2012 at 07:00:22AM +, Alan Barrett wrote:
Log Message:
printf format fix: cast to (long) when printing with %lX format.
You mean (unsigned long), right? :-)
Thanks, fixed.
--apb (Alan Barrett)
' was intended, i.e., a single
assignment semantic? I've probably mistyped that myself several times.
The variable is assigned only once, so that would work,
but it's in a small block where I don't think it would add any clarity.
--apb (Alan Barrett)
, I'd prefer that
to a cast. If you do need a cast, then I think you should cast
dayoff to zic_t.
--apb (Alan Barrett)
(Alan Barrett)
platform with a larger uintmax_t could appear one
day.
--apb (Alan Barrett)
On Thu, 27 Sep 2012, Alan Barrett wrote:
Module Name:src
Committed By: apb
Date: Thu Sep 27 15:51:48 UTC 2012
Update of /cvsroot/src/share/zoneinfo
In directory ivanova.netbsd.org:/tmp/cvs-serv19934
Log Message:
Import tzdata2012f from
http://www.iana.org/time-zones/repository
On Sat, 15 Sep 2012, Martin Husemann wrote:
On Sat, Sep 15, 2012 at 12:35:26PM +0200, Alan Barrett wrote:
Under what circumstances is it useful for MAKEDEV to mount
ptyfs? Why can't we rely on other code to mount it later?
We can - this is just a very central place to catch them all
easily
small letter c with
cedilla in an unspecified encoding?
--apb (Alan Barrett)
)) ))
Are \\s really not needed here?
$() and $(()) constructs nest correctly without needing any backslashes.
$opts will be a problem if it contains -m PATH_TO_MKNOD and
PATH_TO_MKNOD contains spaces or other special characters,
but backslashes here won't fix that.
--apb (Alan Barrett)
defining them in a
compiler-dependent way, or using #ifndef to pick up any definition
provided by the host system.
--apb (Alan Barrett)
++;
+ }
+
+ ATF_REQUIRE(j != n);
+}
n=4 would probably be enough iterations, and I'd suggest checking
whether all values are the same as each other, rather than
checking whether all values are zero.
--apb (Alan Barrett)
From: Alan Barrett a...@cequrux.com
To: source-changes-d@NetBSD.org
Cc:
Bcc
object to this. If ipf fails its tests, then the fact should be
made clear in the test reports, not hidden by disabling the tests.
I don't know whether the bugs are in ipf or in the tests, but
either way, removing or disabling the tests seems to me to be
counter-productive.
--apb (Alan Barrett)
that are not really nbecessary, if
they improve the readability or portability of the code. The cast
here does not do that, and I think it should not be added.
--apb (Alan Barrett)
1 - 100 of 183 matches
Mail list logo
