On Fri, Aug 10, 2012 at 04:34:23PM +, Joerg Sonnenberger wrote:
> Modified Files:
> src/share/mk: bsd.kmodule.mk
>
> Log Message:
> Remove effectively tautological condition.
I object to this sort of change. There are a number of other compilers
we might want to try sometime; all yo
On Fri, Aug 10, 2012 at 10:18:09PM +0400, Valeriy E. Ushakov wrote:
> Linking against libstdc++ wastes space and time at runtime.
>
> [...]
>
> I guess you are working on clang support, so leaking libsupc++ into
> the build gets in your way. Please, instead of always linking
> libstdc++ mak
On Sun, Aug 12, 2012 at 12:59:52PM +, Martin Husemann wrote:
> Log Message:
> Pull up following revision(s) (requested by manu in ticket #484):
> sys/fs/nilfs/nilfs_vnops.c: revision 1.18
> sys/ufs/ufs/ufs_lookup.c: revision 1.117
> sys/nfs/nfs_vnops.c: revision 1.295
>
On Tue, Jul 31, 2012 at 11:16:44AM +0100, David Laight wrote:
> If the intent of adding -fno-common is to remove issues with common
> data, then it is really doing the wrong thing.
> You really need to error 'common' data items, not convert them to bss.
>
> That might need a check later on th
On Sat, Jul 28, 2012 at 10:22:46PM -0700, Matt Thomas wrote:
> >> Modified Files:
> >> src/sys/dev/i2c: g760a.c
> >>
> >> Log Message:
> >> Use (void *) instead of (type **) which gcc complains about.
> >
> > At least one of these casts is discarding const and writing to the
> > const o
On Sat, Jul 28, 2012 at 11:03:47PM +, Matt Thomas wrote:
> Modified Files:
> src/sys/dev/i2c: g760a.c
>
> Log Message:
> Use (void *) instead of (type **) which gcc complains about.
At least one of these casts is discarding const and writing to the
const object returned by sysctl_cr
On Tue, Jul 24, 2012 at 07:13:34AM +0200, Emmanuel Dreyfus wrote:
> > OTOH for netbsd-6 maybe a better patch would be to change cache_enter
> > to return instead of asserting for long filenames.
>
> If nobody opposes, I can do that.
Best to ask on tech-kern, but it seems unlikely to be contro
On Mon, Jul 23, 2012 at 10:07:06PM +, Martin Husemann wrote:
> > > This is wrong; you're reverting rmind's cleanup.
> >
> > I backed out the change. Will someone pullup the change to netbsd-6?
Can you prepare a patch that applies before rmind's cleanup? (Or just
one that applies on netbsd-
On Mon, Jul 23, 2012 at 12:15:31PM +, Emmanuel Dreyfus wrote:
> Module Name: src
> Committed By:manu
> Date:Mon Jul 23 12:15:31 UTC 2012
>
> Modified Files:
> src/sys/fs/puffs: puffs_node.c puffs_vnops.c
>
> Log Message:
> Di not call cache_enter with pat
On Sun, Jul 22, 2012 at 05:50:16PM +, David Holland wrote:
> On Sun, Jul 22, 2012 at 12:53:23AM +, Mindaugas Rasiukevicius wrote:
> > Log Message:
> > Move some the test for MAKEENTRY into the cache_enter(9). Make some
> > variables in vfs_cache.c stati
On Sun, Jul 22, 2012 at 12:53:23AM +, Mindaugas Rasiukevicius wrote:
> Log Message:
> Move some the test for MAKEENTRY into the cache_enter(9). Make some
> variables in vfs_cache.c static, __read_mostly, etc.
>
> No objection on tech-kern@.
thank you.
--
David A. Holland
dholl...@netb
On Sun, Jul 15, 2012 at 12:05:51AM +, David Brownlee wrote:
> Modified Files:
> src/external/bsd/atf/lib/libatf-c++: Makefile
>
> Log Message:
> Check for ${HAVE_GCC} and pick the right path to stdc++
Shouldn't these paths be provided by bsd.lib.mk, as the installed ones
are by bsd.
On Wed, Jul 04, 2012 at 09:45:58PM +0300, Andreas Gustafsson wrote:
> I don't know. To help narrow down the possible differences, the
> autobuild system is running 5.1_STABLE, and invokes build.sh like
> this, in a freshly checked out source tree (from a date-based
> CVS checkout from anoncvs)
On Wed, Jul 04, 2012 at 01:45:08AM +0900, Izumi Tsutsui wrote:
> > getdisksize() is not complicated; it tries DIOCGPART and then
> > DIOCGWEDGEINFO and that's about it.
>
> Yes, but it is not implementation issue but design issue.
>
> > I think it's wrong for either of those to be returning
On Tue, Jul 03, 2012 at 08:01:21PM +0900, Izumi Tsutsui wrote:
> > } Add a sanity check if secsize returned from getdisksize() isn't bogus.
> > } This prevent possible panic "panic: buf mem pool index 23" later in
> > } vfs_bio.c:buf_mempoolidx().
> > } (I'm not sure if it's okay for getdisksiz
On Wed, Jun 27, 2012 at 10:04:02PM +, Taylor R Campbell wrote:
> Modified Files:
> src/share/misc: style
>
> Log Message:
> Elaborate and clarify rules about #include order.
>
> ok christos
erm... sys/types.h is supposed to be first.
and, as sys/param.h includes sys/types.h, nor
On Sat, Jun 23, 2012 at 07:14:35PM +, David Brownlee wrote:
> Modified Files:
> src/share/man/man4: cd.4
>
> Log Message:
> Document DIOCTUR (test unit ready)
So, if your CD's unwell, what do you do? Call the DIOCTUR!
--
David A. Holland
dholl...@netbsd.org
On Wed, Jun 13, 2012 at 06:51:37PM +, Martin Husemann wrote:
> Modified Files:
> src/distrib/sets/lists/xbase: mi
> src/external/mit/xorg/bin/xdm/config: Makefile
> Added Files:
> src/external/mit/xorg/bin/xdm/config: NetBSD-flag.png NetBSD-flag1.xpm
> NetBSD-flag2
On Sun, Jun 03, 2012 at 04:29:41AM +, Simon J. Gerraty wrote:
> Module Name: src
> Committed By:sjg
> Date:Sun Jun 3 04:29:40 UTC 2012
>
> Modified Files:
> src/usr.bin/make: for.c
>
> Log Message:
> Handle "quoted strings" as items in a .for list
Was t
On Mon, Apr 23, 2012 at 06:26:25PM -0400, Christos Zoulas wrote:
> | Yeah but is it going to turn out to e.g. be signed if building on some
> | random broken host OS?
>
> I don't think it will work at all if it is not a 64 bit quantity, will it?
I guess the qeustion is: does the tools build g
On Mon, Apr 23, 2012 at 05:04:45PM -0400, Christos Zoulas wrote:
> | I was wondering if maybe ino_t isn't reliable for tools...
>
> Looks like it is there on:
> /usr/src/usr.sbin/makefs/ffs/ufs_inode.h: ino_t i_number;
>/* The identity of the inode. */
>
> so it sho
On Fri, Apr 20, 2012 at 01:23:29PM +, Christos Zoulas wrote:
> >Module Name:src
> >Committed By: dholland
> >Date: Thu Apr 19 19:48:15 UTC 2012
> >
> >Modified Files:
> >src/usr.sbin/makefs/ffs: mkfs.c
> >
> >Log Message:
> >Fix build failure reported by
On Fri, Apr 20, 2012 at 09:52:42AM +0200, Manuel Bouyer wrote:
> > (Furthermore, scsipi is itself wrong. It is a core component; it
> > should be MPSAFE.)
>
> I also agree. So should be ata, if_ethersubr, etc ...
> that's a lot of work.
Yup. Anyone want to make a list of such entities so we
On Fri, Apr 20, 2012 at 09:37:00AM +0200, Manuel Bouyer wrote:
> > we've never had autoconfig run with the kernel lock AFAICT, so this
> > assumption has never been true.
>
> So this is a bug. The contract was really that spl-locked drivers would
> continue to work as is when fine-grained loc
On Sun, Mar 18, 2012 at 05:08:44PM +0200, Jukka Ruohonen wrote:
> All good; exited without nothing printed to stderr and the status is zero.
> But this:
>
> atf_check -o ignore \
> -s exit:0 -x "find /etc -type f -exit"
>
> yields
>
> tc-so:Executing command [ /bi
On Fri, Mar 09, 2012 at 10:38:03AM -0500, Christos Zoulas wrote:
> Modified Files:
> src/sys/sys: gmon.h
>
> Log Message:
> use explicit cast for RHS of shift operator since semantics change from
> traditional c to ansi.
>
> To generate a diff of this commit:
> cvs rdiff -u -r1.9 -r
On Sun, Mar 04, 2012 at 10:31:01PM +, David Laight wrote:
> > > That could be used as a compile-time substitute when the buffer
> > > size is known - ie when 'sizeof buffer != sizeof (char *)'
> >
> > I don't think that makes too much sense. If you want to read a full
> > line, use getlin
On Thu, Mar 01, 2012 at 11:14:16AM -0700, Warner Losh wrote:
> Maybe somebody can look at a full pkgsrc build to see how many
> instances of gets are in it?
Given the way bulk builds work, and various logistical reasons that is
unlikely to change, the only practical way to check this is to remov
On Mon, Feb 13, 2012 at 01:01:39PM +, Nicolas Joly wrote:
> Modified Files:
> src/share/man/man9: vfsops.9
>
> Log Message:
> Fix copyin/copyout sections in xrefs.
Ugh, sorry about that. Should definitely not have let that get through...
--
David A. Holland
dholl...@netbsd.org
On Sat, Feb 11, 2012 at 11:58:14PM +0200, Alan Barrett wrote:
> >>Regardless of whether or not you got approval from releng, I
> >>think it's inappropriate to make major or controversial changes
> >>without public discussion.
> >
> >As far as I can tell from reading the PR you were the only
>
On Sun, Jan 29, 2012 at 08:49:02AM +, Izumi Tsutsui wrote:
> Modified Files:
> src/sys/ufs/ufs: ufs_vfsops.c
>
> Log Message:
> Fix errors in !defined(QUOTA) && !defined(QUOTA2) case.
Whoops, sorry...
--
David A. Holland
dholl...@netbsd.org
On Sat, Jan 28, 2012 at 03:10:24PM +, Paul Goyette wrote:
> Modified Files:
> src/distrib/sets/lists/base: mi
>
> Log Message:
> Add new directories for trousers to sets lists. The directories get
> created even if they're not populated.
>
> Hello again, christos!
howsabout we
On Sat, Jan 28, 2012 at 01:59:31PM +, Alexander Nasonov wrote:
> > IIRC something in the standard requires the result to be a compile time
> > constant
>
> You're right: "... which expands to an integer constant expression that
> has type size_t, the value of which is the offset in bytes
On Tue, Jan 24, 2012 at 09:07:47PM +0100, Frank Wille wrote:
> >> > > A detach function for the onboard flash probably makes no sense,
> >> > > so remove it.
> >> >
> >> > Sure it makes sense.
> >>
> >> Hmm... how do you detach it? With drvctl(8)? Why should you do that?
> >
> > Power con
On Tue, Jan 24, 2012 at 12:10:07PM +0100, Frank Wille wrote:
> > > A detach function for the onboard flash probably makes no sense, so
> > > remove it.
> >
> > Sure it makes sense.
>
> Hmm... how do you detach it? With drvctl(8)? Why should you do that?
Power consumption comes to mind...
On Sun, Jan 15, 2012 at 04:48:31PM +, Cherry G. Mathew wrote:
> Module Name: src
> Committed By:cherry
> Date:Sun Jan 15 16:48:31 UTC 2012
>
> Modified Files:
> src/sys/arch/amd64/include: pmap.h
>
> Log Message:
> for xen on amd64 PDP_BASE points to the
On Sat, Jan 07, 2012 at 12:36:32PM +0100, Manuel Bouyer wrote:
> > the problem is that now the code performs different operations
> > based upon DIAGNOSTIC or not. it's not about whether it's wrong
> > or right, but that it's different. DIAGNOSTIC shouldn't do more
> > or different things, ju
On Fri, Jan 06, 2012 at 03:15:28PM +, Cherry G. Mathew wrote:
> Modified Files:
> src/sys/arch/x86/x86: pmap.c
> src/sys/arch/xen/x86: cpu.c
>
> Log Message:
> Address those pesky DIAGNOSTIC messages. \n
> Take a performance hit at fork() for not DTRT. \n
> Note: Only applica
On Thu, Jan 05, 2012 at 02:27:36PM -0500, Christos Zoulas wrote:
> Module Name: xsrc
> Committed By:christos
> Date:Thu Jan 5 19:27:36 UTC 2012
>
> Modified Files:
> xsrc/external/mit/xorg-cf-files/dist: NetBSD.cf
>
> Log Message:
> Do as the comment says: a
On Wed, Dec 21, 2011 at 04:47:49PM +0100, Reinoud Zandijk wrote:
> Hi folks,
>
> i am not subscribed to this mailing list so i only found this
> discussion when someone pointed it out to me.
Realistically, you should always be subscribed to either
source-changes or source-changes-full, or sou
On Wed, Dec 21, 2011 at 12:13:50AM +0400, Valeriy E. Ushakov wrote:
> > On which mailling list was this change discussed?
>
> I guess this is for the usermode kernel, which design has also never
> been discussed.
Sure, but changes to fundamental APIs are supposed to not only be
discussed to d
On Thu, Dec 15, 2011 at 12:05:18AM +, Jared D. McNeill wrote:
> Modified Files:
> src/sys/kern: kern_lwp.c
>
> Log Message:
> In lwp_create, copy l_sigstk from the template. Previously
> sigaltstack wasn't inherited across fork (but SA_ONSTACK handlers
> was), causing the child pro
On Thu, Dec 01, 2011 at 05:45:25PM +, David Laight wrote:
> > > Anyway, here is a first cut on an "explicit_bzero" function
> > > which doesn't get optimized away. I've put it to src/common
> > > because the same thing makes sense in the kernel too.
> > > Comments?
> >
> > Just make it a
On Mon, Dec 05, 2011 at 11:12:11AM +, Juergen Hannken-Illjes wrote:
> Modified Files:
> src/sys/fs/union: union_vfsops.c
>
> Log Message:
> The union file system is as stable as other layered file systems so
> no longer print a warning to the console.
Erm... I'm not sure I'd say th
On Sun, Dec 04, 2011 at 11:22:54AM +0100, Bernd Ernesti wrote:
> > Modified Files:
> >src/sys/kern: kern_exec.c
> >
> > Log Message:
> > fix incomplete statement.
>
> Hmm, why did you change two '#ifdef notyet' to '#ifndef notyet'?
By mistake, I assume, probably because he's been runn
On Thu, Dec 01, 2011 at 05:50:14PM +, David Laight wrote:
> I'd rather the .c file wasn't polluted with #ifdefs.
> Probably better to #define fss_compat_ioctl(...) EINVAL somewhere.
>
> We ought to sort out a way of making the compat code loadable
> - in which case this would need to be a
On Wed, Nov 30, 2011 at 07:38:17PM +0100, Manuel Bouyer wrote:
> > Keeping the compat code in compat/?
>
> No, because the code is not in the header ...
The struct is...
--
David A. Holland
dholl...@netbsd.org
On Wed, Nov 30, 2011 at 12:13:43PM +0100, Manuel Bouyer wrote:
> > Should the header portion move to compat/dev/?
>
> This is not going to be used outside of fss.c so I'm not sure what
> this would give us ...
Keeping the compat code in compat/?
--
David A. Holland
dholl...@netbsd.org
On Tue, Nov 29, 2011 at 07:14:38PM +0100, Matthias Drochner wrote:
> > the memset() is likely to get optimized away by the compiler anyway.
> > It's a dead store after all.
>
> It might be by luck, but a disassembly of MD5Final() on i386
> shows that the final zeroing is present in the binary
On Sun, Nov 27, 2011 at 12:38:12AM +, Izumi Tsutsui wrote:
> Log Message:
> Revert "stopcap fix" for rump by christos, which causes build failure on
> most non-x86 ports and seems unnecessary. (caused by wrong rump_namei.h?)
Probably not; rump_namei.h only actually contains the namei flags,
On Fri, Nov 25, 2011 at 05:40:51PM +0100, Joerg Sonnenberger wrote:
> > And why should the/any static analyzer have to figure that out when
> > coding it right makes it a nonissue?
>
> Because that's what is making warnings useful. To not complain about
> non-issues.
Like this?
const cha
On Fri, Nov 25, 2011 at 02:48:30PM +0100, Joerg Sonnenberger wrote:
> > > > > > Sure it does. You should just have written the code using
> > > > > > (size_t)1,
> > > > > > or even just 1UL, instead of 1ULL. There is no port where size_t is
> > > > > > unsigned long long.
> > > > > >
> > >
On Fri, Nov 25, 2011 at 02:29:12PM +0100, Joerg Sonnenberger wrote:
> > > > Sure it does. You should just have written the code using (size_t)1,
> > > > or even just 1UL, instead of 1ULL. There is no port where size_t is
> > > > unsigned long long.
> > > >
> > > > ... Unless what you meant wa
On Fri, Nov 25, 2011 at 02:15:12PM +0100, Joerg Sonnenberger wrote:
> > Sure it does. You should just have written the code using (size_t)1,
> > or even just 1UL, instead of 1ULL. There is no port where size_t is
> > unsigned long long.
> >
> > ... Unless what you meant was "get rid of all 32
On Fri, Nov 25, 2011 at 01:01:34PM +0100, Joerg Sonnenberger wrote:
> > Log Message:
> > Add explicit casts to make lint happy and fix the NetBSD/i386 build.
>
> Can we please just get rid of this PoS? This doesn't even qualify as bad
> signal to noise ratio.
Sure it does. You should just ha
On Tue, Nov 22, 2011 at 01:17:43AM +, YAMAMOTO Takashi wrote:
> hi,
>
> do you have any plan on fs/unionfs? eg. remove it
My vote would be to remove it; it doesn't work and the only reason it
was ever brought in had to do with alleged locking improvements.
--
David A. Holland
dholl...@n
On Sun, Nov 13, 2011 at 03:57:58PM +, Izumi Tsutsui wrote:
> Modified Files:
> src/sys/arch/mips/mips: locore.S
>
> Log Message:
> Read-modify-write instead of read-modify-read. (not sure if this was fatal)
Probably not, but it's good to fix regardless...
--
David A. Holland
dhol
On Wed, Oct 19, 2011 at 09:59:38PM +, David Young wrote:
> Module Name: src
> Committed By:dyoung
> Date:Wed Oct 19 21:59:38 UTC 2011
>
> Modified Files:
> src/sys/net: if_gre.c
>
> Log Message:
> Get rid of gre's deadlock-prone, one-off ifioctl locking.
On Wed, Oct 19, 2011 at 08:53:48AM -0400, Greg Troxel wrote:
> > Please restore EDITOR=vi, otherwise the following message is going to
> > haunt me for the rest of time:
> >
> > $ svn commit
> > svn: Commit failed (details follow):
> > svn: Could not use external editor to fetch log message;
On Sun, Oct 16, 2011 at 07:31:51PM +0200, Alistair Crooks wrote:
> > Log Message:
> > Build with -DSQLITE_ENABLE_FTS3_PARENTHESIS
>
> pkgsrc sqlite3 also has an option for rtree - it would be nice to
> build that into the version in src by default. I'm not sure about the
> pkgsrc icu option
On Thu, Oct 13, 2011 at 07:47:30AM +, Nicolas Joly wrote:
> Modified Files:
> src/distrib/sets/lists/tests: mi
>
> Log Message:
> Do not delete nul.in line, but tag it as obsolete.
Sorry, my fault, evidently not thinking.
--
David A. Holland
dholl...@netbsd.org
On Wed, Oct 12, 2011 at 12:39:48PM -0400, Christos Zoulas wrote:
> Modified Files:
> src/external/bsd/cron/dist: cron.8 database.c pathnames.h
>
> Log Message:
> process files in /etc/cron.d/
For the record, I object to this change. I think keeping /etc small
and simple, and having one
On Sun, Oct 09, 2011 at 09:15:34PM +, Chuck Silvers wrote:
> Modified Files:
> src/sys/ufs/ufs: extattr.h
>
> Log Message:
> add forward declarations for the VOP args structures
> so that fstat can include this file.
Do we really want fstat using fs-specific headers and interfaces?
On Sun, Sep 11, 2011 at 07:37:06AM +, Jukka Ruohonen wrote:
> Modified Files:
> src/lib/libc/stdio: funopen.3
>
> Log Message:
> It is not just funopen(3) that is a BSDism.
While that's true, those functions aren't specific to .Nx; AFAIK they
were in 4.4.
--
David A. Holland
dholl
On Tue, Aug 30, 2011 at 07:44:17PM +0300, Jukka Ruohonen wrote:
> > And why should GENERIC *not* support hardware that is available, works,
> > and is of use to someone? If GENERIC is to support only the idea of
> > what an OS should look for some developers, why do we ship GENERIC at
> > all
On Tue, Sep 06, 2011 at 02:53:58PM +0400, Valeriy E. Ushakov wrote:
> Are you saying you are going to add a special case for each foo.o file
> each time an accidental non-objdir build left foo.o in src? (and no,
> that's not a rhetoric question).
The fundamental problem is that the make library
On Tue, Sep 06, 2011 at 11:59:50PM +0400, Valeriy E. Ushakov wrote:
> > Please commit changes like the following together instead of spamming
> > the source-changes list.
>
> I don't think that "spamming" source-changes is a very high priority
> consideration. OTOH, I know that per-directory
On Thu, Aug 25, 2011 at 12:18:29PM -0400, Christos Zoulas wrote:
> Modified Files:
> src/games/sail: pl_7.c
>
> Log Message:
> add printf attributes.
please use __printflike() instead of __attribute__(__format__)...
--
David A. Holland
dholl...@netbsd.org
On Tue, Aug 23, 2011 at 05:25:08PM +1000, matthew green wrote:
> > > the minor number should be bumped any time a symbol is added to a
> > > library.
> > >
> > > the major number should be bumped any time a symbols is removed
> > > from or an ABI changed in a library.
> > >
> > >
> > > t
On Tue, Aug 23, 2011 at 06:20:34AM +0200, Emmanuel Dreyfus wrote:
> In another change set, I am about moving extended attribute functions
> from libc to libutil. Should libc major be bumped?
Uh. Bumping libc's major version is a Very Big Deal. So, no. Please
bring this up on tech-userlevel to ma
On Mon, Aug 22, 2011 at 12:48:22PM +0200, Joerg Sonnenberger wrote:
> > > > > > Requires stdint.h.
> > > > >
> > > > > No?
> > > >
> > > > uh what?
> > >
> > > It doesn't. The prototypes in strings.h already ensure that
> > > uint32_t/uint64_t are present and that's the only thing it
On Mon, Aug 22, 2011 at 03:13:29AM +0200, Joerg Sonnenberger wrote:
> On Sun, Aug 21, 2011 at 11:37:08PM +0000, David Holland wrote:
> > On Mon, Aug 22, 2011 at 01:31:31AM +0200, Joerg Sonnenberger wrote:
> > > > Modified Files:
> > > > src/com
On Mon, Aug 22, 2011 at 01:31:31AM +0200, Joerg Sonnenberger wrote:
> > Modified Files:
> >src/common/lib/libc/string: popcount32.c popcount64.c
> >
> > Log Message:
> > Requires stdint.h.
>
> No?
uh what?
--
David A. Holland
dholl...@netbsd.org
On Thu, Aug 18, 2011 at 09:51:50PM +, Taylor R Campbell wrote:
> Forgot to add that this also fixes a space leak in tmpfs_rename,
> introduced a couple months ago, which nobody reported as far as I
> know. The leak sometimes caused tmpfs_renamerace_dirs to fail with
> ENOSPC. The problem
On Thu, Aug 18, 2011 at 01:51:33PM -0500, David Young wrote:
> > Rather than sweeping the issue under the rug, wouldn't it be better to
> > actually fix the problem?
> >
> > See attached diff which replaces the "variable" format with a
> > literal #define string ...
>
> I think we should m
On Wed, Aug 17, 2011 at 08:31:27AM +, Martin Husemann wrote:
> Modified Files:
> src/sys/kern: vfs_syscalls.c
>
> Log Message:
> add missing prototype
shouldn't that be in a header file somewhere?
--
David A. Holland
dholl...@netbsd.org
On Wed, Aug 10, 2011 at 07:22:06AM +, YAMAMOTO Takashi wrote:
> > > why is this necessary? can't we just let VOP_LOOKUP fail?
> >
> > Not to fix PR 44658.
>
> it's better to fix the vn_isunder check instead of avoiding running it.
> IMO vn_isunder should return acutal error code (eg. E
On Wed, Aug 10, 2011 at 03:10:13AM +, YAMAMOTO Takashi wrote:
> > Log Message:
> > Fail namei immediately if searchdir is unlinked / has been rmdir'd.
> > Do this by checking if v_size == 0. Should fix PR 44658 (and PR 32661).
>
> why is this necessary? can't we just let VOP_LOOKUP fail?
On Fri, Jul 22, 2011 at 08:38:43AM +, Thomas Klausner wrote:
> Remove Xr to nonexisting intro(4),
Shouldn't we have an intro(4)? I didn't realize it was missing...
--
David A. Holland
dholl...@netbsd.org
On Wed, Jul 20, 2011 at 12:49:34PM +0300, Jukka Ruohonen wrote:
> A lot of empty talk here.
>
> What is exactly your problem?
You asked, I tried to explain, you describe it as "empty talk". What
are you expecting, a gigantic patch?
Anyway, I guess this about sums it up: the real problem is ap
On Wed, Jun 29, 2011 at 03:05:09PM +0100, Julio Merino wrote:
>>> Perhaps if atf were less intrusive...?
>>
>> What do you mean? I think it needs to be quite intrusive
>> (sandboxing, etc.). Unquestionably the old /regress-style is not
>> the way to go. Even if you dislike some parts of the
On Tue, Jul 05, 2011 at 03:13:02PM +0200, Joerg Sonnenberger wrote:
> > Log Message:
> > The manipulation macros for struct dirent are also used by the ufs/ffs
> > code to manipulate the similar but not identical struct direct. For
> > this reason they must remain type-polymorphic. Rev 1.25 bro
On Sun, Jul 17, 2011 at 10:02:27PM +, David A. Holland wrote:
> Modified Files:
> src/sys/ufs/ufs: ufs_vnops.c
>
> Log Message:
> At the end of ufs_rmdir, don't use a dangling vnode pointer to call
> fstrans_done. Ok hannken@
Well, for the record it turns out I misread his mail and
On Sat, Jul 16, 2011 at 04:51:41PM +0100, David Laight wrote:
> > Modified Files:
> >src/lib/libc/sys: dup.2
> >
> > Log Message:
> > Note that dup2(2) and dup3(2) may not fail with EMFILE; from PR lib/45148.
>
> What happens if the 'new' file number is above RLIMIT_NOFILES?
dunno.
On Wed, Jul 06, 2011 at 01:22:58PM -0500, David Young wrote:
> > > Modified Files:
> > > src/distrib/sets/lists/comp: mi
> > > src/sys/sys: Makefile
> > >
> > > Log Message:
> > > Install /usr/include/sys/bus.h for oddball ports whose userland somehow
> > > #includes it.
> >
> > uh...
On Wed, Jul 06, 2011 at 06:18:09PM +, David Young wrote:
> Modified Files:
> src/distrib/sets/lists/comp: mi
> src/sys/sys: Makefile
>
> Log Message:
> Install /usr/include/sys/bus.h for oddball ports whose userland somehow
> #includes it.
uh... wouldn't it be better to track
On Mon, Jul 04, 2011 at 03:05:20PM +0200, Christoph Egger wrote:
> >-. if defined(HAVE_GCC) || defined(HAVE_PCC)
> >+.if defined(HAVE_GCC) || defined(HAVE_PCC)
>
> Please revert this part.
uh why?
--
David A. Holland
dholl...@netbsd.org
On Sun, Jul 03, 2011 at 08:22:51PM +, Jukka Ruohonen wrote:
> Modified Files:
> src/tests/syscall: t_mknod.c
>
> Log Message:
> Remove wrong check.
>
> XXX: Why does this fail on tmpfs but not ffs?
That *should* fail. Probably ffs is failing to check.
--
David A. Holland
dholl.
On Tue, Jun 28, 2011 at 09:25:32AM +0300, Jukka Ruohonen wrote:
> But I think this entails a wider discussion about how the tests
> shipped with third-party software could be integrated to atf(7). In
> case of netpgp(1) this is easy; a relatively small code base for
> which both in-house tests
On Sun, Jun 26, 2011 at 12:55:33AM +0200, Jean-Yves Migeon wrote:
> > Don't give out information about processes we can't control.
>
> Thanks to Aleksey and you for fixing the procfs leak.
>
> I wonder whether pmap's code is the right place to check for
> "information" access control. It's
On Thu, Jun 23, 2011 at 07:55:49PM +, Christos Zoulas wrote:
> >...as opposed to, say, running /usr/bin/pmap?
> >
> >(I've long thought that should be restricted to root, or at least only
> >to one's own non-setugid processes.)
>
> I am in the process of fixing that too, stay tuned.
Yay
On Thu, Jun 23, 2011 at 01:06:38PM -0400, Christos Zoulas wrote:
> Modified Files:
> src/sys/miscfs/procfs: procfs_vnops.c
>
> Log Message:
> From Aleksey Cheusov: Don't make it easy for compromised systems to bypass
> ASLR protections by providing the mapping addresses of programs to e
On Thu, Jun 23, 2011 at 09:00:37PM +1000, matthew green wrote:
> > > Switch to using the common
> >
> > Erm, do we really want to use "src/sys/common" for this, given that
> > the prior art for "common" (src/common) means something entirely
> > different?
> >
> > (also, there's been some
On Thu, Jun 23, 2011 at 01:27:21AM +, Matt Thomas wrote:
> Modified Files:
> src/sys/arch/evbppc/mpc85xx: machdep.c
> src/sys/arch/powerpc/booke: booke_stubs.c e500_tlb.c
> src/sys/arch/powerpc/include: types.h
> src/sys/arch/powerpc/include/booke: cpuvar.h pte.h
>
On Thu, Jun 02, 2011 at 09:21:11PM +0100, David Laight wrote:
> Actually I've thought about this some more.
> While, on the face of it, removing the 'struct lwp *' parameter to
> all system calls might seem an optimisation, I suspect that,
> especially on systems where arguments are passed in r
On Wed, May 25, 2011 at 04:33:38PM +, Masao Uebayashi wrote:
> Modified Files:
> src/sys/dev/bluetooth: bcsp.c bthub.c btuart.c
> src/sys/dev/ieee1394: fwdev.c fwmem.c fwohci.c
>
> Log Message:
> Declare cfdrivers using extern rather than including ioconf.h.
This is wrong. Ple
On Tue, May 24, 2011 at 04:35:26PM +, Joerg Sonnenberger wrote:
> Modified Files:
> src/sys/dev/scsipi: atapi_wdc.c
>
> Log Message:
> Fix obvious condition snafu
While that's clearly wrong I wonder what the consequences of fixing it
are...
...also the same code appears in mvsata.c
On Tue, May 17, 2011 at 09:56:52PM +, David Laight wrote:
> cvs rdiff -u -r1.51 -r1.52 src/usr.bin/make/Makefile
uh, did you mean to commit that?
--
David A. Holland
dholl...@netbsd.org
On Tue, May 03, 2011 at 06:28:46PM +, David Young wrote:
> Module Name: src
> Committed By:dyoung
> Date:Tue May 3 18:28:46 UTC 2011
>
> Modified Files:
> src/distrib/sets/lists/comp: mi
> src/sys/dist/pf/net: pf.c
> src/sys/netinet: Makefile fil
On Sat, May 14, 2011 at 12:07:20PM -0400, Christos Zoulas wrote:
> If we are going to be compiling the kernel in c99 mode, then I
> suggest that we do the same for userland instead of turning it on
> for userland piecemeal.
+1
is there anything we expect to break?
--
David A. Holland
dholl..
201 - 300 of 548 matches
Mail list logo
