Re: CVS commit: src/sys

2009-04-20 Thread Elad Efrat
On Tue, Apr 21, 2009 at 3:34 AM, YAMAMOTO Takashi wrote: > anyway, i don't like the "check KAUTH_GENERIC_ISSUSER first" style > because it makes logging useless.  ie. i prefer: > >        foo() >        { >                : >                : >                : >        out: >                /*

Re: CVS commit: src/sys/kern

2009-04-22 Thread Elad Efrat
Andrew Doran wrote: On Mon, Apr 20, 2009 at 10:09:55PM +, Elad Efrat wrote: Module Name:src Committed By: elad Date: Mon Apr 20 22:09:55 UTC 2009 Modified Files: src/sys/kern: kern_verifiedexec.c Log Message: PR/41251: YAMAMOTO Takashi: veriexec locking seems

Re: CVS commit: src/sys

2009-04-25 Thread Elad Efrat
Elad Efrat wrote: Module Name:src Committed By: elad Date: Sat Apr 25 18:53:45 UTC 2009 [...] cvs rdiff -u -r1.374 -r1.375 src/sys/kern/vfs_subr.c This change was committed on accident (NULL check to a KASSERT()). Please let me know if you want me to back it out or if it's

Re: CVS commit: src/sys

2009-04-25 Thread Elad Efrat
On Sat, Apr 25, 2009 at 11:38 PM, Andrew Doran wrote: > On Sat, Apr 25, 2009 at 09:58:21PM +0300, Elad Efrat wrote: > >> Elad Efrat wrote: >> >Module Name: src >> >Committed By:        elad >> >Date:                Sat Apr 25 18:53:45 UTC 2009 >> &g

Re: CVS commit: src/sys

2009-05-03 Thread Elad Efrat
On Mon, May 4, 2009 at 3:38 AM, Alistair Crooks wrote: > On Sun, May 03, 2009 at 09:25:45PM +0000, Elad Efrat wrote: >> Module Name:  src >> Committed By: elad >> Date:         Sun May  3 21:25:45 UTC 2009 >> >> Modified Files: >>       src/sys/conf: pa

Re: CVS commit: src/sys/netinet6

2009-05-08 Thread Elad Efrat
On Fri, May 8, 2009 at 2:18 AM, YAMAMOTO Takashi wrote: > hi, > > have you checked callers and ensure that the change from EACCES to EPERM > won't be a problem? Only ipsec_set_policy() returns EPERM instead of EACCES now, and I don't think it should be a problem. As for calling context -- I did

Re: CVS commit: src/sys/ufs/ufs

2009-05-08 Thread Elad Efrat
Mindaugas Rasiukevicius wrote: Log Message: ufs_setattr: fix previous - return in error path does not finish the transaction (hi elad). I just wanted you to replace a return with a goto. ;) Good catch & thanks for fixing! -e.

Re: CVS commit: src/sys/netinet6

2009-05-10 Thread Elad Efrat
On Sun, May 10, 2009 at 8:44 AM, YAMAMOTO Takashi wrote: >>> have you checked callers and ensure that the change from EACCES to EPERM >>> won't be a problem? >> >> Only ipsec_set_policy() returns EPERM instead of EACCES now, and I >> don't think it should be a problem. > > "don't think"?  why not

Re: CVS commit: src/sys

2009-05-10 Thread Elad Efrat
On Sun, May 10, 2009 at 1:16 PM, YAMAMOTO Takashi wrote: > isn't KAUTH_REQ_NETWORK_SOCKET_RAWSOCK being deprecated in favor of _OPEN? I'm still trying to decide, that's why I used this one (so removing it causes errors). On one hand, it would be nice to centralize everything like we planned. On

Re: CVS commit: src/sys/netinet6

2009-05-10 Thread Elad Efrat
On Sun, May 10, 2009 at 1:12 PM, YAMAMOTO Takashi wrote: >> That said, where we now return EPERM is where in the future we'll >> return the error value returned by kauth(9), like many many other >> places in the kernel. Other parts of the networking stacks (say, >> opening a raw socket) now retur

Re: CVS commit: src/crypto/external/bsd/netpgp/dist

2009-05-10 Thread Elad Efrat
Simon Burge wrote: "Perry E. Metzger" wrote: [ ... ] Encrypted swap should be the default -- either using cgd or by simply encrypting the blocks as they go in and out without using the cgd layer. You've benchmarked the effect of this, especially on older hardware? Let's first have it as an

Re: CVS commit: src/sys/dist/ipf/netinet

2009-05-10 Thread Elad Efrat
Mihai Chelaru wrote: Module Name:src Committed By: kefren Date: Fri May 8 05:18:34 UTC 2009 Modified Files: src/sys/dist/ipf/netinet: ip_fil_netbsd.c Log Message: Don't call callout_stop() without callout_init() Fixes PR/41364 To generate a diff of this commit: cvs rd

Re: CVS commit: src/sys/netinet

2009-05-12 Thread Elad Efrat
Quentin Garnier wrote: On Tue, May 12, 2009 at 09:48:42PM +, Elad Efrat wrote: Module Name:src Committed By: elad Date: Tue May 12 21:48:42 UTC 2009 Modified Files: src/sys/netinet: ip_carp.c Log Message: Fix inverted permissions check. - if ((l

Re: CVS commit: src/sys/net

2009-05-17 Thread Elad Efrat
On Sun, May 17, 2009 at 4:59 PM, Quentin Garnier wrote: > On Tue, May 12, 2009 at 11:03:25PM +0000, Elad Efrat wrote: >> Module Name:  src >> Committed By: elad >> Date:         Tue May 12 23:03:25 UTC 2009 >> >> Modified Files: >>       src/sys/net: if_brid

Re: CVS commit: src/sys/net

2009-05-17 Thread Elad Efrat
On Sun, May 17, 2009 at 6:24 PM, Quentin Garnier wrote: > On Sun, May 17, 2009 at 05:40:44PM +0300, Elad Efrat wrote: > [...] >> > 3.  When (publicly, even) told about an obvious bug, you still go >> >    ahead and commit it. >> >> False, the bug you're r

Re: CVS commit: src/sys

2009-06-23 Thread Elad Efrat
Hey Andrew, Andrew Doran wrote: On Tue, Jun 23, 2009 at 07:36:41PM +, Elad Efrat wrote: Log Message: Move the implementation of vaccess() to genfs_can_access(), in line with the other routines of the same spirit. ... No objections on tech-kern@: http://mail-index.netbsd.org

Re: CVS commit: src/sys/fs/udf

2009-07-03 Thread Elad Efrat
Hey, > [fixes of commit issues] Sorry about these -- I usually run a build of i386/ALL but apparently I forgot this time. Thanks for quickly noticing and fixing the problems! :) -e.

Re: CVS commit: src/sys/dev/pci

2009-07-30 Thread Elad Efrat
Michael wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello, On Jul 30, 2009, at 12:38 AM, Michael Lorenz wrote: Module Name:src Committed By:macallan Date:Thu Jul 30 04:38:25 UTC 2009 Modified Files: src/sys/dev/pci: pci_usrreq.c Log Message: do as elad suggested

Re: CVS commit: src/sys/arch/i386/conf

2009-08-25 Thread Elad Efrat
David Holland wrote: On Wed, Aug 26, 2009 at 03:39:16AM +, Elad Efrat wrote: > Log Message: > Build NiLFS(2). (2)? :-p That's how it's written in the configuration file... -e.

Re: CVS commit: src

2009-08-25 Thread Elad Efrat
Unrelated to the topic of the thread, but kmem(9) says: SECURITY CONSIDERATION As the memory allocated by kmem_alloc() is uninitialized, it can contain security-sensitive data left by its previous user. It is the caller's responsibility not to expose it to the world. Shouldn't it

Re: CVS commit: src

2009-08-26 Thread Elad Efrat
On Wed, Aug 26, 2009 at 4:07 PM, David Holland wrote: > All recycled kernel memory, including stack frames, is considered > security-sensitive and not supposed to be exposed to the world. (Given > that you're working on the security system, you ought to know this.) > It is a matter of proper copyo

Re: CVS commit: src

2009-08-26 Thread Elad Efrat
On Wed, Aug 26, 2009 at 5:05 PM, David Holland wrote: > Entities that share the same memory space inherently have the same > trust level. At that point it becomes a nonissue, except for e.g. > cryptographic keys that should already be getting handled properly. > > I'm not clear what you have in mi

Re: CVS commit: src/sys

2009-12-25 Thread Elad Efrat
On Fri, Dec 25, 2009 at 3:20 AM, Alan Barrett wrote: > On Thu, 24 Dec 2009, Elad Efrat wrote: >> Modified Files: >>       src/sys/secmodel/suser: secmodel_suser.c >>       src/sys/sys: kauth.h >> >> Log Message: >> Rename KAUTH_GENERIC_CANSEE to KAUTH_

Re: CVS commit: src/etc/rc.d

2009-12-29 Thread Elad Efrat
Marc Balmer wrote: -osecurelevel=$(sysctl -n kern.securelevel) +osecurelevel=$(sysctl -n kern.securelevel 2>&-) +if [ $? != 0 ]; then +echo "Can't set securelevel. (kern.securelevel sysctl not present.)" the error message should probably read Can't set securelevel. (kern.

Re: CVS commit: src/etc/rc.d

2009-12-29 Thread Elad Efrat
Elad Efrat wrote: Marc Balmer wrote: -osecurelevel=$(sysctl -n kern.securelevel) +osecurelevel=$(sysctl -n kern.securelevel 2>&-) +if [ $? != 0 ]; then +echo "Can't set securelevel. (kern.securelevel sysctl not present.)" the error message should pr

CVS commit: src/sys/kern

2009-12-29 Thread Elad Efrat
Module Name:src Committed By: elad Date: Wed Dec 30 06:58:51 UTC 2009 Modified Files: src/sys/kern: uipc_socket.c Log Message: Use credentials from the socket. To generate a diff of this commit: cvs rdiff -u -r1.198 -r1.199 src/sys/kern/uipc_socket.c Please note that di

CVS commit: src/sys/netinet

2009-12-29 Thread Elad Efrat
Module Name:src Committed By: elad Date: Wed Dec 30 06:59:32 UTC 2009 Modified Files: src/sys/netinet: tcp_usrreq.c Log Message: Get the uid from the socket's credentials. To generate a diff of this commit: cvs rdiff -u -r1.157 -r1.158 src/sys/netinet/tcp_usrreq.c Pleas

CVS commit: src/sys/dist/pf/net

2009-12-29 Thread Elad Efrat
Module Name:src Committed By: elad Date: Wed Dec 30 07:00:01 UTC 2009 Modified Files: src/sys/dist/pf/net: pf.c Log Message: Get uid/gid from the socket's credentials. To generate a diff of this commit: cvs rdiff -u -r1.57 -r1.58 src/sys/dist/pf/net/pf.c Please note tha

CVS commit: src/sys/dist/pf/net

2009-12-30 Thread Elad Efrat
Module Name:src Committed By: elad Date: Wed Dec 30 16:49:03 UTC 2009 Modified Files: src/sys/dist/pf/net: pf.c Log Message: Use the right member to store gid in the non-NetBSD case. Pointed out by uebayasi@ and cegger@, thanks! To generate a diff of this commit: cvs rd

CVS commit: src/sys/kern

2009-12-30 Thread Elad Efrat
Module Name:src Committed By: elad Date: Wed Dec 30 18:33:53 UTC 2009 Modified Files: src/sys/kern: uipc_socket2.c Log Message: Always use resource limits from the process, as proposed in http://mail-index.netbsd.org/tech-kern/2009/12/30/msg006756.html okay chris

CVS commit: src/sys

2009-12-30 Thread Elad Efrat
Module Name:src Committed By: elad Date: Wed Dec 30 18:57:17 UTC 2009 Modified Files: src/sys/kern: subr_pool.c src/sys/sys: pool.h Log Message: Turn PA_INITIALIZED to a reference count for the pool allocator, and once it drops to zero destroy the mutex we initiali

CVS commit: src/sys/dist/pf/net

2009-12-30 Thread Elad Efrat
Module Name:src Committed By: elad Date: Wed Dec 30 19:47:15 UTC 2009 Modified Files: src/sys/dist/pf/net: pf.c Log Message: Replace uidinfo.h with kauth.h, should fix problems observed by t...@. To generate a diff of this commit: cvs rdiff -u -r1.59 -r1.60 src/sys/dist/

CVS commit: src/sys/kern

2009-12-30 Thread Elad Efrat
Module Name:src Committed By: elad Date: Wed Dec 30 22:12:12 UTC 2009 Modified Files: src/sys/kern: uipc_socket.c uipc_socket2.c Log Message: Don't bother caching egid. It'll be removed soon. To generate a diff of this commit: cvs rdiff -u -r1.199 -r1.200 src/sys/kern/ui

CVS commit: src/sys/netinet6

2009-12-30 Thread Elad Efrat
Module Name:src Committed By: elad Date: Wed Dec 30 23:23:58 UTC 2009 Modified Files: src/sys/netinet6: ipsec.c Log Message: Collapse identical switch cases. To generate a diff of this commit: cvs rdiff -u -r1.142 -r1.143 src/sys/netinet6/ipsec.c Please note that diffs

CVS commit: src/sys/kern

2009-12-30 Thread Elad Efrat
Module Name:src Committed By: elad Date: Thu Dec 31 02:20:37 UTC 2009 Modified Files: src/sys/kern: kern_auth.c Log Message: Tiny cosmetics... To generate a diff of this commit: cvs rdiff -u -r1.64 -r1.65 src/sys/kern/kern_auth.c Please note that diffs are not public do

Re: CVS commit: src/sys/uvm

2010-02-18 Thread Elad Efrat
Matthias Drochner wrote: Module Name:src Committed By: drochner Date: Thu Feb 18 14:57:01 UTC 2010 Modified Files: src/sys/uvm: files.uvm uvm_map.c Log Message: Disable mapping of virtual address 0 by user programs per default. This blocks an easy exploit of kernel bugs

Re: CVS commit: src/sys/uvm

2010-02-19 Thread Elad Efrat
Hi, On Fri, Feb 19, 2010 at 6:37 AM, Matthias Drochner wrote: > > e...@netbsd.org said: >> > (cannot be cleared at securelevel>0) >> I was wondering how you achieved that without modifying any of the >> secmodel code itself > > Well, that's the problem with kauth: If it needs code changes > for e