Re: CVS commit: src/sys/net

2011-10-19 Thread Joerg Sonnenberger
On Wed, Oct 19, 2011 at 01:34:37AM +, David Young wrote: Module Name: src Committed By: dyoung Date: Wed Oct 19 01:34:37 UTC 2011 Modified Files: src/sys/net: if.c if.h Log Message: Start to untangle the ifnet ioctls mess. This broke src/external/bsd/am-utils. Please

Re: CVS commit: src/share/mk

2011-10-17 Thread Joerg Sonnenberger
On Mon, Oct 17, 2011 at 07:07:08PM +0100, Iain Hibbert wrote: Regarding this (which I have discussed with Marc off-list previously), I think a Lua module should always depend on liblua.so as there will be calls to functions from there, though I guess Marc is correct that the binary loading the

Re: CVS commit: src/external/public-domain/sqlite

2011-10-16 Thread Joerg Sonnenberger
On Sun, Oct 16, 2011 at 07:31:51PM +0200, Alistair Crooks wrote: On Sun, Oct 16, 2011 at 05:24:50PM +, Joerg Sonnenberger wrote: Module Name:src Committed By: joerg Date: Sun Oct 16 17:24:50 UTC 2011 Modified Files: src/external/public-domain

Re: curses and terminfo changes

2011-10-04 Thread Joerg Sonnenberger
On Tue, Oct 04, 2011 at 02:25:48PM +0200, Alan Barrett wrote: On Tue, 04 Oct 2011, Roy Marples wrote: Log Message: Move longname(3) from curses to terminfo, pre-cursor to fix PR/43386. You have made a lot of changes recently. What are you doing about compatibility for programs linked

Re: CVS commit: src/common/lib/libc/string

2011-09-24 Thread Joerg Sonnenberger
20110822104822.gb15...@britannica.bec.de, Joerg Sonnenberger jo...@britannica.bec.de wrote: On Mon, Aug 22, 2011 at 01:26:24AM +, David Holland wrote: On Mon, Aug 22, 2011 at 03:13:29AM +0200, Joerg Sonnenberger wrote: On Sun, Aug 21, 2011 at 11:37:08PM +, David Holland wrote

Re: CVS commit: src/external/bsd/libevent/dist

2011-09-17 Thread Joerg Sonnenberger
On Sat, Sep 17, 2011 at 11:17:51AM +1000, Simon Burge wrote: Joerg Sonnenberger wrote: Module Name:src Committed By: joerg Date: Fri Sep 16 16:09:03 UTC 2011 Modified Files: src/external/bsd/libevent/dist: log.h Log Message: Use __dead

Re: CVS commit: src/lib/libm/man

2011-09-12 Thread Joerg Sonnenberger
On Mon, Sep 12, 2011 at 02:44:27PM +, Jukka Ruohonen wrote: Module Name: src Committed By: jruoho Date: Mon Sep 12 14:44:27 UTC 2011 Modified Files: src/lib/libm/man: ldexp.3 Log Message: Update and improve, and note that the long double variant is not supported. Can

Re: CVS commit: src/share/man/man4

2011-09-07 Thread Joerg Sonnenberger
On Wed, Sep 07, 2011 at 01:05:18PM +0300, Jukka Ruohonen wrote: The fact that Linux has always done this wrong is not a reason to go chasing after them and reinventing their mistakes. As usual, you managed to marvellously miss the point. The reason Linux does this (right) is the amount of

Re: CVS commit: src/etc/mtree

2011-09-05 Thread Joerg Sonnenberger
On Mon, Sep 05, 2011 at 09:57:02AM +, Alan Barrett wrote: Module Name: src Committed By: apb Date: Mon Sep 5 09:57:02 UTC 2011 Modified Files: src/etc/mtree: Makefile Log Message: Use ${.OBJDIR}/NetBSD.dist.tmp instead of just NetBSD.dist.tmp. This fixes a problem

Re: CVS commit: src/sys/arch/usermode/usermode

2011-08-27 Thread Joerg Sonnenberger
On Sat, Aug 27, 2011 at 08:13:28PM +0200, Jean-Yves Migeon wrote: On 27.08.2011 19:57, Reinoud Zandijk wrote: Fix copystring routines to NOT just copy all since not all space might be writable. This can be fixed by implementing/importing strnlen(3) in the kernel Any reason no to? If

Re: CVS commit: src

2011-08-23 Thread Joerg Sonnenberger
On Tue, Aug 23, 2011 at 07:29:36AM +, David Holland wrote: On Tue, Aug 23, 2011 at 05:25:08PM +1000, matthew green wrote: the minor number should be bumped any time a symbol is added to a library. the major number should be bumped any time a symbols is removed from

Re: CVS commit: src/common/lib/libc/string

2011-08-22 Thread Joerg Sonnenberger
On Mon, Aug 22, 2011 at 01:26:24AM +, David Holland wrote: On Mon, Aug 22, 2011 at 03:13:29AM +0200, Joerg Sonnenberger wrote: On Sun, Aug 21, 2011 at 11:37:08PM +, David Holland wrote: On Mon, Aug 22, 2011 at 01:31:31AM +0200, Joerg Sonnenberger wrote: Modified Files

Re: CVS commit: src/common/lib/libc/string

2011-08-22 Thread Joerg Sonnenberger
On Mon, Aug 22, 2011 at 04:48:02PM +0400, Valeriy E. Ushakov wrote: It doesn't. The prototypes in strings.h already ensure that uint32_t/uint64_t are present and that's the only thing it could ever need from stdint.h. Yes it does. strings.h is included by string.h and is

Re: CVS commit: src/common/lib/libc/string

2011-08-21 Thread Joerg Sonnenberger
On Sun, Aug 21, 2011 at 09:25:04PM +, David A. Holland wrote: Module Name: src Committed By: dholland Date: Sun Aug 21 21:25:04 UTC 2011 Modified Files: src/common/lib/libc/string: popcount32.c popcount64.c Log Message: Requires stdint.h. To generate a diff of

Re: CVS commit: src/common/lib/libc/string

2011-08-21 Thread Joerg Sonnenberger
On Sun, Aug 21, 2011 at 11:37:08PM +, David Holland wrote: On Mon, Aug 22, 2011 at 01:31:31AM +0200, Joerg Sonnenberger wrote: Modified Files: src/common/lib/libc/string: popcount32.c popcount64.c Log Message: Requires stdint.h. No? uh what? It doesn't

Re: CVS commit: src/external/bsd/mdocml

2011-08-19 Thread Joerg Sonnenberger
On Fri, Aug 19, 2011 at 09:19:46AM -0400, Jim Wise wrote: As long as I remember, we've had a strict policy of submitting changes upstream where possible, but of _not_ gating fixes on this process -- particularly fixes which are security or correctness related (the latter includes fixes without

Re: CVS commit: src/external/bsd/mdocml

2011-08-19 Thread Joerg Sonnenberger
On Fri, Aug 19, 2011 at 10:57:53AM -0400, Jim Wise wrote: And the project has a long history of making sure all (these days: most) code in the base distribution builds with -Wall -Werror. This isn't because every GCC warning is right, of course -- it's because when you turn off warnings for a

Re: CVS commit: src/external/bsd/mdocml

2011-08-18 Thread Joerg Sonnenberger
On Thu, Aug 18, 2011 at 01:47:19AM +, Christos Zoulas wrote: In article 20110817212805.gb16...@britannica.bec.de, Joerg Sonnenberger jo...@britannica.bec.de wrote: Could you please stop randomly changing 3rd party code without contacting the maintainer? Unless the rules have changed

Re: CVS commit: src/external/bsd/mdocml

2011-08-17 Thread Joerg Sonnenberger
Could you please stop randomly changing 3rd party code without contacting the maintainer? Joerg On Wed, Aug 17, 2011 at 05:30:14AM -0400, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Wed Aug 17 09:30:14 UTC 2011 Modified Files:

Re: CVS commit: src/usr.bin/unzip

2011-08-17 Thread Joerg Sonnenberger
Did you test this change for breaking compatibility with 3rd party scripts that parse the output of unzip? Joerg On Wed, Aug 17, 2011 at 09:37:40AM -0400, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Wed Aug 17 13:37:40 UTC 2011 Modified Files:

Re: CVS commit: [ipsec-tools-0_8-branch] src/crypto/dist/ipsec-tools/src/racoon

2011-08-13 Thread Joerg Sonnenberger
On Sat, Aug 13, 2011 at 09:21:43AM +, Christos Zoulas wrote: In article 20110812054606.71cef17...@cvs.netbsd.org, Timo Teräs source-changes-d@NetBSD.org wrote: +static int +privsep_do_exit(void *ctx, int fd) +{ +kill(getpid(), SIGTERM); +return 0; +} + Why not call

Re: CVS commit: src/external/public-domain/xz/bin

2011-08-04 Thread Joerg Sonnenberger
On Thu, Aug 04, 2011 at 03:38:06AM +, Matt Thomas wrote: Module Name: src Committed By: matt Date: Thu Aug 4 03:38:06 UTC 2011 Modified Files: src/external/public-domain/xz/bin: Makefile Added Files: src/external/public-domain/xz/bin: Makefile.inc

Re: CVS commit: src/sys

2011-07-31 Thread Joerg Sonnenberger
On Sat, Jul 30, 2011 at 10:16:30PM +0100, David Laight wrote: On Sat, Jul 30, 2011 at 11:04:24PM +0200, Joerg Sonnenberger wrote: ... Note that for a uncontested resource, the overhead of a mutex for a single operation tends to be comparable, if store fences have a similar price than bus

Re: CVS commit: src/lib/libedit

2011-07-31 Thread Joerg Sonnenberger
Can we please stop abusing the notation of GCC is available to mean GCC is used? If you want a GCC-specific warning flag, at least put it into CWARNFLAGS.gcc. I'm actually in favour of dropping this unconditionally -- GCC 4.1 is just behaving way too lax for this option to make sense. Joerg On

Re: CVS commit: src/sys

2011-07-30 Thread Joerg Sonnenberger
On Sat, Jul 30, 2011 at 07:23:51PM +0200, Jean-Yves Migeon wrote: I remember reading articles mentioning how wonderful lockless algorithms are, except in situation where the additional bus locking/atomic ops involved did not really improve the situation in highly concurrent systems (and could

Re: CVS commit: src/sys/arch/alpha/alpha

2011-07-26 Thread Joerg Sonnenberger
On Tue, Jul 26, 2011 at 02:59:04PM +, Nicolas Joly wrote: Module Name: src Committed By: njoly Date: Tue Jul 26 14:59:03 UTC 2011 Modified Files: src/sys/arch/alpha/alpha: autoconf.c Log Message: Make atoi func static, and constify Shouldn't this use strtol to

Re: CVS commit: src/sys/arch/alpha/alpha

2011-07-26 Thread Joerg Sonnenberger
On Tue, Jul 26, 2011 at 06:19:21PM +0200, Nicolas Joly wrote: On Tue, Jul 26, 2011 at 05:27:38PM +0200, Joerg Sonnenberger wrote: On Tue, Jul 26, 2011 at 02:59:04PM +, Nicolas Joly wrote: Module Name: src Committed By: njoly Date: Tue Jul 26 14:59:03 UTC 2011

Re: CVS commit: src/sys/arch/alpha/alpha

2011-07-26 Thread Joerg Sonnenberger
On Wed, Jul 27, 2011 at 02:33:24AM +0900, Izumi Tsutsui wrote: Looking how many atoi() copies we have in tree, does it make sense to add the following at the end of libkern.h Please don't use it for #ifdef _STANDALONE ones. libc's strtoll() is larger than dumb atoi()s. ...if strtoll isn't

Re: CVS commit: src/crypto/external/bsd/openssl/lib/libcrypto/arch

2011-07-25 Thread Joerg Sonnenberger
On Fri, Jul 22, 2011 at 10:50:56PM +, Jean-Yves Migeon wrote: Module Name: src Committed By: jym Date: Fri Jul 22 22:50:56 UTC 2011 Modified Files: src/crypto/external/bsd/openssl/lib/libcrypto/arch/i386: aesni-586.S aesni-x86.S

Re: CVS commit: src/crypto/external/bsd/openssl/lib/libcrypto/arch

2011-07-25 Thread Joerg Sonnenberger
On Mon, Jul 25, 2011 at 07:24:57PM +0100, David Laight wrote: On Mon, Jul 25, 2011 at 11:52:52AM +0200, Joerg Sonnenberger wrote: Much better. One thing remains. It would be nice to replace .byte 0xf3,0xc3 with either a simple ret or a ret $0, depending on whether it has a label

Re: CVS commit: src/sys/sys

2011-07-05 Thread Joerg Sonnenberger
On Tue, Jul 05, 2011 at 07:32:34AM +, David A. Holland wrote: Log Message: The manipulation macros for struct dirent are also used by the ufs/ffs code to manipulate the similar but not identical struct direct. For this reason they must remain type-polymorphic. Rev 1.25 broke that

Re: CVS commit: src

2011-07-04 Thread Joerg Sonnenberger
On Mon, Jul 04, 2011 at 03:26:47PM +0200, Emmanuel Dreyfus wrote: matthew green m...@eterna.com.au wrote: /usr/src3/lib/libc/rpc/xdr_sizeof.c:112:12: error: cast from pointer to integer of different size /usr/src3/lib/libc/rpc/xdr_sizeof.c:124:18: error: cast to pointer from

Re: CVS commit: src

2011-07-04 Thread Joerg Sonnenberger
On Mon, Jul 04, 2011 at 10:38:00PM +, Joerg Sonnenberger wrote: Module Name: src Committed By: joerg Date: Mon Jul 4 22:37:59 UTC 2011 Modified Files: src/external/bsd/llvm/bin/clang: Makefile src/external/bsd/llvm/bin/llc: Makefile src/external/bsd/llvm

Re: CVS commit: src

2011-07-04 Thread Joerg Sonnenberger
On Tue, Jul 05, 2011 at 12:45:01AM +0200, Joerg Sonnenberger wrote: (1) f register constraint doesn't work / is not supported. This part has resolved itself in the mean time. Joerg

Re: CVS commit: src/lib/libc/db/recno

2011-06-26 Thread Joerg Sonnenberger
On Sun, Jun 26, 2011 at 06:16:47PM -0400, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Sun Jun 26 22:16:46 UTC 2011 Modified Files: src/lib/libc/db/recno: rec_open.c Log Message: use O_CLOEXEC To generate a diff of this commit: cvs rdiff -u

Re: CVS commit: src/lib/libm/arch/i387

2011-06-20 Thread Joerg Sonnenberger
On Mon, Jun 20, 2011 at 11:25:34AM +0900, tsugutomo.en...@jp.sony.com wrote: Joerg Sonnenberger jo...@netbsd.org writes: Log Message: Switch to SSE code, since our gas supports it now. To generate a diff of this commit: cvs rdiff -u -r1.6 -r1.7 src/lib/libm/arch/i387/s_copysign.S

Re: CVS commit: src/sys/kern

2011-06-05 Thread Joerg Sonnenberger
On Sat, Jun 04, 2011 at 02:47:53PM +0100, David Laight wrote: IIRC the arm ABI defines standard uses for a lot of the registers, one must be for thread data - so could be used in the kernel for curlwp. Only for newer ARM generations. The old one have no native TLS register. Joerg

Re: CVS commit: src/sys/kern

2011-06-05 Thread Joerg Sonnenberger
On Sun, Jun 05, 2011 at 10:42:30AM +0200, Martin Husemann wrote: On Sun, Jun 05, 2011 at 10:15:45AM +0200, Joerg Sonnenberger wrote: Only for newer ARM generations. The old one have no native TLS register. Should we have a userland build option to make use of that? It might be useful

Re: CVS commit: src/external/bsd/tmux/dist/compat

2011-05-30 Thread Joerg Sonnenberger
On Mon, May 30, 2011 at 06:10:36PM +, Christos Zoulas wrote: In article 20110530162059.1a6d217...@cvs.netbsd.org, Joerg Sonnenberger source-changes-d@NetBSD.org wrote: -=-=-=-=-=- +#ifdef __clang__ +charbuf[128]; +#else charbuf

Re: CVS commit: src/sys/dev

2011-05-26 Thread Joerg Sonnenberger
On Thu, May 26, 2011 at 07:12:57AM +, David Holland wrote: On Wed, May 25, 2011 at 04:33:38PM +, Masao Uebayashi wrote: Modified Files: src/sys/dev/bluetooth: bcsp.c bthub.c btuart.c src/sys/dev/ieee1394: fwdev.c fwmem.c fwohci.c Log Message: Declare cfdrivers

Re: CVS commit: src/sys/arch/i386/stand

2011-05-21 Thread Joerg Sonnenberger
On Sat, May 21, 2011 at 01:01:52PM +0100, David Laight wrote: On Fri, May 20, 2011 at 10:29:56PM +, Joerg Sonnenberger wrote: Log Message: Disable integrated assembler for files that use .code16 or .code32 for now Would it have been better to do this with a level

Re: CVS commit: src/share/mk

2011-05-18 Thread Joerg Sonnenberger
Please back this out. I have a proper patch for this on tech-toolchain. Joerg On Wed, May 18, 2011 at 01:08:15PM +, Adam Ciarcinski wrote: Module Name: src Committed By: adam Date: Wed May 18 13:08:14 UTC 2011 Modified Files: src/share/mk: bsd.own.mk Log Message:

Re: CVS commit: src/tests/fs/tmpfs

2011-04-21 Thread Joerg Sonnenberger
On Fri, Apr 22, 2011 at 01:54:21AM +, Christos Zoulas wrote: I would write a regression test for jot instead! It's not a bug in jot, it's a bug in qemu. Joerg

Re: CVS commit: src/share/mk

2011-04-17 Thread Joerg Sonnenberger
On Sat, Apr 16, 2011 at 05:41:25PM -0400, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Sat Apr 16 21:41:25 UTC 2011 Modified Files: src/share/mk: bsd.own.mk Log Message: Simplify and correct (previous did not work for !defined(DESTDIR) You are

Re: CVS commit: src/usr.bin/mkdep

2011-04-17 Thread Joerg Sonnenberger
On Sun, Apr 17, 2011 at 06:35:22PM -0400, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Sun Apr 17 22:35:22 UTC 2011 Modified Files: src/usr.bin/mkdep: mkdep.c Log Message: Recognize --sysroot but don't document it or do anything about it for now.

Re: CVS commit: src/share/mk

2011-04-17 Thread Joerg Sonnenberger
On Sat, Apr 16, 2011 at 06:45:23PM -0400, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Sat Apr 16 22:45:23 UTC 2011 Modified Files: src/share/mk: bsd.own.mk Log Message: Need --sysroot=/ otherwise ld does not find crt0.o and friends. What exactly

Re: CVS commit: src

2011-04-12 Thread Joerg Sonnenberger
On Tue, Apr 12, 2011 at 11:22:17PM +0300, Jukka Ruohonen wrote: And to use mktime(3), you must know the tm structure. No, you don't have to. That's the point Klaus is trying to make. You need to know that certain fields exist, maybe also which type they have. But you don't need to know the

Re: CVS commit: src/usr.bin/make

2011-04-06 Thread Joerg Sonnenberger
On Thu, Apr 07, 2011 at 02:49:31AM +0100, Mindaugas Rasiukevicius wrote: Joerg Sonnenberger jo...@netbsd.org wrote: Module Name:src Committed By: joerg Date: Thu Apr 7 01:40:02 UTC 2011 Modified Files: src/usr.bin/make: make.1 var.c src/usr.bin

Re: CVS commit: src

2011-03-25 Thread Joerg Sonnenberger
Forgot to add: This material is based upon work partially supported by The NetBSD Foundation under a contract with Joerg Sonnenberger. Sorry, about that. On Fri, Mar 25, 2011 at 06:07:08PM +, Joerg Sonnenberger wrote: Module Name: src Committed By: joerg Date: Fri Mar 25 18:07:07

Re: CVS commit: src/lib/libc/gdtoa

2011-03-20 Thread Joerg Sonnenberger
i386 build is still broken with lint issues in dtoa.c, gdtoa.c and strtod.c at least. Joerg On Sun, Mar 20, 2011 at 07:15:36PM -0400, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Sun Mar 20 23:15:35 UTC 2011 Modified Files: src/lib/libc/gdtoa: dtoa.c

Re: CVS commit: src/lib/libc/gen

2011-03-15 Thread Joerg Sonnenberger
On Tue, Mar 15, 2011 at 03:47:04AM +, Eric Haszlakiewicz wrote: Module Name: src Committed By: erh Date: Tue Mar 15 03:47:04 UTC 2011 Modified Files: src/lib/libc/gen: Makefile.inc Added Files: src/lib/libc/gen: commaize_number.3 commaize_number.c Log Message:

Re: CVS commit: src

2011-03-09 Thread Joerg Sonnenberger
On Thu, Mar 10, 2011 at 02:16:36AM +0200, Adam Hamsik wrote: On Mar,Thursday 10 2011, at 1:10 AM, Joerg Sonnenberger wrote: Module Name:src Committed By: joerg Date: Wed Mar 9 23:10:09 UTC 2011 Modified Files: src/distrib/sets/lists/comp: mi

Re: CVS commit: src/sys/arch/amd64/include

2011-03-04 Thread Joerg Sonnenberger
On Fri, Mar 04, 2011 at 04:33:17AM +, Christos Zoulas wrote: In article 20110304033425.0e01017...@cvs.netbsd.org, Joerg Sonnenberger source-changes-d@NetBSD.org wrote: -=-=-=-=-=- Module Name: src Committed By:joerg Date:Fri Mar 4 03:34:24 UTC 2011 Modified

Re: CVS commit: src/sys/arch/amd64/include

2011-03-04 Thread Joerg Sonnenberger
On Fri, Mar 04, 2011 at 01:24:19PM +0200, Antti Kantee wrote: On Fri Mar 04 2011 at 11:42:10 +0100, Joerg Sonnenberger wrote: On Fri, Mar 04, 2011 at 04:33:17AM +, Christos Zoulas wrote: In article 20110304033425.0e01017...@cvs.netbsd.org, Joerg Sonnenberger source-changes-d

Re: CVS commit: src

2011-02-25 Thread Joerg Sonnenberger
On Fri, Feb 25, 2011 at 04:38:54PM +0200, Antti Kantee wrote: On Fri Feb 25 2011 at 15:19:30 +0100, Joerg Sonnenberger wrote: I get time outs for stress_long and stress_short (rump/rumpkern/t_sp). Those are because of, from what I could tell, this: 0xbbbd45c5 fcntl+21: mov%gs:0x0

Re: CVS commit: src

2011-02-24 Thread Joerg Sonnenberger
On Thu, Feb 24, 2011 at 05:23:12PM +0200, Antti Kantee wrote: On Thu Feb 24 2011 at 04:28:50 +, Joerg Sonnenberger wrote: Log Message: Allow storing and receiving the LWP private pointer via ucontext_t on all platforms except VAX and IA64. Add fast access via register for AMD64, i386

Re: CVS commit: src/lib/librumphijack

2011-02-19 Thread Joerg Sonnenberger
On Sat, Feb 19, 2011 at 01:10:36PM +, Antti Kantee wrote: Module Name: src Committed By: pooka Date: Sat Feb 19 13:10:35 UTC 2011 Modified Files: src/lib/librumphijack: hijack.c Log Message: hijack __getcwd() Why? Joerg

Re: CVS commit: src/lib/librumphijack

2011-02-19 Thread Joerg Sonnenberger
On Sat, Feb 19, 2011 at 07:54:25PM +0200, Antti Kantee wrote: On Sat Feb 19 2011 at 14:58:45 +0100, Joerg Sonnenberger wrote: On Sat, Feb 19, 2011 at 01:10:36PM +, Antti Kantee wrote: Module Name: src Committed By: pooka Date: Sat Feb 19 13:10:35 UTC 2011

Re: CVS commit: src/include

2011-02-16 Thread Joerg Sonnenberger
On Wed, Feb 16, 2011 at 02:29:36PM -0500, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Wed Feb 16 19:29:35 UTC 2011 Modified Files: src/include: rmt.h Log Message: handle ssp To generate a diff of this commit: cvs rdiff -u -r1.6 -r1.7

Re: CVS commit: src/usr.bin/grep

2011-02-16 Thread Joerg Sonnenberger
On Thu, Feb 17, 2011 at 12:06:30PM +0900, enami tsugutomo wrote: Joerg Sonnenberger jo...@netbsd.org writes: Module Name:src Committed By: joerg Date: Wed Feb 16 01:31:34 UTC 2011 Modified Files: src/usr.bin/grep: Makefile file.c grep.1 grep.c grep.h

Re: CVS commit: src/lib/librumphijack

2011-02-09 Thread Joerg Sonnenberger
On Wed, Feb 09, 2011 at 02:30:38AM +, Christos Zoulas wrote: To get the layering correct, we could make the fortification code define another prototype and use double rename, e.g. ssize_t __real_read(int __fd, ...) __RENAME(read); __ssp_inline ssize_t read(int __fd, ...)

Re: CVS commit: src/lib/librumphijack

2011-02-08 Thread Joerg Sonnenberger
On Tue, Feb 08, 2011 at 03:34:54PM -0500, Christos Zoulas wrote: Still the problem remains, how do we stack the calls to insert the ssp check at the top level, without resorting to rtld tricks? Let me try to summarize the situation to make sure I get it right: The fortification code wants to

Re: CVS commit: src/lib/librumphijack

2011-02-08 Thread Joerg Sonnenberger
On Tue, Feb 08, 2011 at 11:22:44PM +0200, Antti Kantee wrote: On Tue Feb 08 2011 at 22:00:49 +0100, Joerg Sonnenberger wrote: On Tue, Feb 08, 2011 at 03:34:54PM -0500, Christos Zoulas wrote: Still the problem remains, how do we stack the calls to insert the ssp check at the top level

Re: CVS commit: src/lib/csu

2011-01-31 Thread Joerg Sonnenberger
On Mon, Jan 31, 2011 at 07:32:50PM +0100, Matthias Drochner wrote: m.droch...@fz-juelich.de said: $ make -V .OBJDIR [...]/src/lib/csu/obj.zelz27 And as a data point, to show what's going wrong: $ make -V COMMON_DIR ./common That should be ../common, or better an absolute path. $

Re: CVS commit: src/lib/csu

2011-01-31 Thread Joerg Sonnenberger
On Mon, Jan 31, 2011 at 08:42:59PM +0100, Matthias Drochner wrote: jo...@britannica.bec.de said: $ ~/work/NetBSD/obj/clang-base/tools/bin/nbmake-amd64 -V .OBJDIR /home/joerg/work/NetBSD/obj/clang-base/amd64/lib/csu This shows that you are not using an .OBJDIR, in the sense that it is

Re: CVS commit: src/lib/csu

2011-01-31 Thread Joerg Sonnenberger
On Mon, Jan 31, 2011 at 09:54:03PM +0100, Joerg Sonnenberger wrote: On Mon, Jan 31, 2011 at 08:42:59PM +0100, Matthias Drochner wrote: jo...@britannica.bec.de said: $ ~/work/NetBSD/obj/clang-base/tools/bin/nbmake-amd64 -V .OBJDIR /home/joerg/work/NetBSD/obj/clang-base/amd64/lib/csu

Re: CVS commit: src/lib/csu

2011-01-31 Thread Joerg Sonnenberger
On Mon, Jan 31, 2011 at 04:07:43PM -0800, Simon J. Gerraty wrote: I didn't follow the conversation, how is this patch relevant to BUILDID? Some of the redefinition magic involved with BUILDID results in .PARSEDIR as ., not a full path. This only happens if none of the usual MAKEOBJDIR* variables

Re: CVS commit: src/tests/lib/libc/ssp

2010-12-29 Thread Joerg Sonnenberger
On Wed, Dec 29, 2010 at 10:57:27AM +0200, Alan Barrett wrote: On Tue, 28 Dec 2010, Christos Zoulas wrote: Modified Files: src/tests/lib/libc/ssp: h_vsnprintf.c h_vsprintf.c -static void -wrap(char *str, size_t len, const char *fmt, ...) +void +wrap(size_t len, const char *fmt,

Re: CVS commit: src/lib/libc/gen

2010-12-12 Thread Joerg Sonnenberger
On Sun, Dec 12, 2010 at 08:34:25AM +, David Holland wrote: On Thu, Dec 09, 2010 at 09:27:32PM +, Joerg Sonnenberger wrote: Log Message: Wrap sys_errlist constants in a macro to make it easier to extract the strings reliably with sed/awk. Why two layers of parentheses? In case

Re: CVS commit: src/games/boggle/boggle

2010-12-04 Thread Joerg Sonnenberger
On Sun, Dec 05, 2010 at 04:11:52AM +, Paul Goyette wrote: Module Name: src Committed By: pgoyette Date: Sun Dec 5 04:11:52 UTC 2010 Modified Files: src/games/boggle/boggle: bog.c Log Message: Since this game is installed as 'boggle', fix the usage() text to match.

Re: CVS commit: src/bin/cp

2010-10-25 Thread Joerg Sonnenberger
On Mon, Oct 25, 2010 at 11:17:22AM +0200, Juergen Hannken-Illjes wrote: On Sun, Oct 24, 2010 at 05:21:06AM +, David Holland wrote: On Fri, Oct 22, 2010 at 05:56:06PM +, Antti Kantee wrote: Disable mmap path. With the current vnode locking scheme it has a very annoying property:

Re: CVS commit: src/bin/cp

2010-10-25 Thread Joerg Sonnenberger
On Mon, Oct 25, 2010 at 06:41:11PM +0200, Juergen Hannken-Illjes wrote: Do we implement MADV_WILLNEED? According to the man page This WILL NOT fault pages in from backing store. The version of the man page I have says It might or might not fault pages in from backing store. Joerg

Re: CVS commit: src

2010-09-30 Thread Joerg Sonnenberger
For the record, I objected this alternative to my earlier patch because it once again buries the Alpha madness deeply inside MD headers. This is just asking to recreate the problem the next time someone wants to deal with the symbol table hash and there is still no real indication of Alpha being

Re: CVS commit: src

2010-09-13 Thread Joerg Sonnenberger
On Sun, Sep 12, 2010 at 02:50:17AM +0200, Joerg Sonnenberger wrote: At the moment the following binaries change: nlist_elf64.o from libc ld.elf_so savecore ldd librump and librumpuser + t_modautoload from the rump test cases boot, netboot and ustarboot in mdec lockstat paxctl

Re: CVS commit: src

2010-09-11 Thread Joerg Sonnenberger
On Tue, Aug 31, 2010 at 09:57:27PM +0200, Joerg Sonnenberger wrote: /* * Alpha ELF uses different (non-standard) definitions of Elf64_Sword * and Elf64_Word. */ typedef int64_t Elf64_Sword; #define ELF64_FSZ_SWORD 8 typedef uint64_tElf64_Word; #define

Re: CVS commit: src/sys/kern

2010-09-02 Thread Joerg Sonnenberger
On Wed, Sep 01, 2010 at 05:27:29PM -0700, Chuck Silvers wrote: this change breaks some executables on some platforms (eg. tcsh on sparc64). here's what objdump -p shows for this file: LOAD off0x vaddr 0x0010 paddr 0x0010 align 2**20

Re: CVS commit: src

2010-08-31 Thread Joerg Sonnenberger
On Tue, Aug 31, 2010 at 08:43:33PM +0400, Valeriy E. Ushakov wrote: On Tue, Aug 31, 2010 at 16:24:40 +, Tom Spindler wrote: src/sys/sys: exec_elf.h Log Message: Replace the current usage of Elf64_Half with Elf64_Word and rename NetBSD specific Elf64_Quarter to Elf64_Half.

Re: CVS commit: src/crypto/external/bsd/netpgp/dist/src/lib

2010-06-25 Thread Joerg Sonnenberger
On Fri, Jun 25, 2010 at 11:54:32PM +0200, Alistair Crooks wrote: Even in C99, the %lu method will work unless size_t is bigger than unsigned long *and* the value being printed exceeds ULONG_MAX, which is unlikely to happen in practice. Actually, it doesn't. This method breaks

Re: CVS commit: src/usr.bin/make

2010-06-09 Thread Joerg Sonnenberger
On Wed, Jun 09, 2010 at 12:58:23PM -0400, Christos Zoulas wrote: Log Message: Explain variable expansion better. Requested by Aleksey Cheusov This is wrong. Loop variables are not exapnded on each loop iteration. Each loop iteration effectively creates a new variable. The rest of his confusion

Re: CVS commit: src/games/factor

2010-05-16 Thread Joerg Sonnenberger
On Sun, May 16, 2010 at 02:10:35PM +0400, Aleksej Saushev wrote: Following the logic Joerg uses, one should reject all arguments to sqrt, asin, acos, atan, clog, casinh, cacosh, and other inverse functions just because they have more than one branch. In fundamental theory of mathematics be it

Re: CVS commit: src/games/factor

2010-05-16 Thread Joerg Sonnenberger
On Sun, May 16, 2010 at 11:03:42AM +0400, Aleksej Saushev wrote: Yes and it was quite interesting. I don't like your single-handed decision, referring to wiz or kristaps doesn't make honour to any of them (did Thomas present any arguments in public at all?). Essentially, you're using force

Re: CVS commit: src/games/factor

2010-05-16 Thread Joerg Sonnenberger
On Sun, May 16, 2010 at 08:12:57PM +0400, Aleksej Saushev wrote: I have spent several years studying math and I say that this approach is wrong both in mathematical and procedural sense. It is perfectly valid to count 0, +1 and -1 as prime numbers and thus factor any finite ones, it just

Re: CVS commit: src/games/factor

2010-05-16 Thread Joerg Sonnenberger
On Mon, May 17, 2010 at 12:47:53AM +0400, Aleksej Saushev wrote: Joerg Sonnenberger jo...@britannica.bec.de writes: On Sun, May 16, 2010 at 08:12:57PM +0400, Aleksej Saushev wrote: I have spent several years studying math and I say that this approach is wrong both in mathematical

Re: CVS commit: src/games/factor

2010-05-15 Thread Joerg Sonnenberger
On Sat, May 15, 2010 at 09:44:34PM +, David Holland wrote: On Sat, May 15, 2010 at 09:22:39PM +, Joerg Sonnenberger wrote: Modified Files: src/games/factor: factor.6 factor.c Log Message: Follow the Fundamental Theory of Algebra. Disallow factorising of numbers less

Re: CVS commit: src/distrib/notes/common

2010-05-09 Thread Joerg Sonnenberger
On Sun, May 09, 2010 at 07:26:53AM +, David Holland wrote: If DNS won't go, any IP addresses you need that you failed to write down before you started the install are a show-stopper; you need to abort the install, boot something else, and look them up, and hopefully the old OS still boots.

Re: CVS commit: src/distrib/notes/common

2010-05-07 Thread Joerg Sonnenberger
On Fri, May 07, 2010 at 06:02:18AM +, David Holland wrote: On Mon, May 03, 2010 at 03:14:24PM +, Izumi Tsutsui wrote: Update IP addresses (both IPv4 and IPv6) of current ftp.NetBSD.org. XXX: is it still worth to note those numbers in INSTALL docs nowadays? It's not uncommon

Re: CVS commit: src/lib/libc/stdio

2010-05-06 Thread Joerg Sonnenberger
On Thu, May 06, 2010 at 08:51:29AM +, David Holland wrote: On Thu, May 06, 2010 at 08:14:08AM +, Jukka Ruohonen wrote: Correct the discussion about return values: fileno() may fail and return -1. Note that in such cases the NetBSD implementation does not set errno to EBADF,

Re: CVS commit: src/lib/libc/stdio

2010-05-06 Thread Joerg Sonnenberger
On Thu, May 06, 2010 at 06:00:45PM +0300, Jukka Ruohonen wrote: On Thu, May 06, 2010 at 02:48:32PM +0200, Joerg Sonnenberger wrote: On Thu, May 06, 2010 at 08:51:29AM +, David Holland wrote: On Thu, May 06, 2010 at 08:14:08AM +, Jukka Ruohonen wrote: Correct the discussion about

Re: CVS commit: src/lib/libc/stdio

2010-05-05 Thread Joerg Sonnenberger
On Wed, May 05, 2010 at 06:53:06AM +0300, Jukka Ruohonen wrote: Please revert this change. I will rever it. Can you change it to use .Xr please? That makes proper cross-references in HTML output possible. Joerg

Re: CVS commit: src/lib/libc/stdio

2010-05-04 Thread Joerg Sonnenberger
On Tue, May 04, 2010 at 04:39:16PM +0300, Jukka Ruohonen wrote: In my manual page: The functions fgets() and gets() conform to ANSI X3.159-1989 (``ANSI C89'') and IEEE Std 1003.1-2001 (``POSIX.1''). The IEEE Std 1003.1-2008 (``POSIX.1'') revision marked gets() as obsolescent,

Re: CVS commit: src/sys/kern

2010-05-04 Thread Joerg Sonnenberger
On Tue, May 04, 2010 at 07:23:56PM +, Frank Kardel wrote: Module Name: src Committed By: kardel Date: Tue May 4 19:23:56 UTC 2010 Modified Files: src/sys/kern: kern_uuid.c Log Message: switch to nanotime() for 100ns resolution Why not bintime()? Joerg

Re: CVS commit: src/usr.bin/make

2010-04-29 Thread Joerg Sonnenberger
On Thu, Apr 29, 2010 at 11:12:21PM +, Simon J. Gerraty wrote: Module Name: src Committed By: sjg Date: Thu Apr 29 23:12:21 UTC 2010 Modified Files: src/usr.bin/make: main.c parse.c Log Message: fflush stdout, before writing to stderr. In which situation does it

Re: CVS commit: src/lib/libc/string

2010-04-19 Thread Joerg Sonnenberger
On Mon, Apr 19, 2010 at 03:02:05AM +, Christos Zoulas wrote: In article 20100419021334.ga8...@britannica.bec.de, Joerg Sonnenberger jo...@britannica.bec.de wrote: On Sun, Apr 18, 2010 at 10:51:35AM +, Alan Barrett wrote: Log Message: Bitwise operations on signed types are well

Re: CVS commit: src/lib/libc/string

2010-04-18 Thread Joerg Sonnenberger
On Sun, Apr 18, 2010 at 10:51:35AM +, Alan Barrett wrote: Log Message: Bitwise operations on signed types are well-defined if the values happen to be positive, and indeed the values here were guaranteed to be positive, but some compilers complained anyway, so convert the bitwise

Re: CVS commit: src/share/man/man3

2010-04-14 Thread Joerg Sonnenberger
On Wed, Apr 14, 2010 at 08:26:42AM +, Jukka Ruohonen wrote: Log Message: EXAMPLE - EXAMPLES, GCC - gcc(1), and minor markup changes. I disagree with the second part. This is not about the frontend. It doesn't matter if it is used for C or C++. Joerg

Re: CVS commit: src

2010-03-25 Thread Joerg Sonnenberger
On Thu, Mar 25, 2010 at 02:59:38PM +, Jukka Ruohonen wrote: Log Message: In addition to 'hz', document also 'tick', 'tickadj', 'stathz', and 'profhz'. tick ok, the other: please don't. tickadj is an implementation detail of the clock discipline code. stathz and profhz are not of any use to

Re: CVS commit: src

2010-03-25 Thread Joerg Sonnenberger
On Thu, Mar 25, 2010 at 05:46:27PM +0200, Jukka Ruohonen wrote: Well wouldn't it then be better to document that they are not of any use to the general kernel? From a quick look around, I see also quite a few instances of stathz and profhz being used/defined. Sure, because each platform has a

Re: CVS commit: src/sys/sys

2010-03-20 Thread Joerg Sonnenberger
On Sat, Mar 20, 2010 at 10:43:50AM -0400, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Sat Mar 20 14:43:50 UTC 2010 Modified Files: src/sys/sys: bitops.h Log Message: /*LINTED*/ is too wide a brush. At least the second cast is a bug in lint and

CVS commit: src/usr.bin/passwd

2010-03-09 Thread Joerg Sonnenberger
Module Name:src Committed By: joerg Date: Tue Mar 9 16:14:08 UTC 2010 Modified Files: src/usr.bin/passwd: pam_passwd.c Log Message: Do not call pam_end with an invalid handle if pam_start failed. From Richard Hansen. To generate a diff of this commit: cvs rdiff -u

Re: CVS commit: src/external/bsd/openldap/dist/include

2010-03-08 Thread Joerg Sonnenberger
On Mon, Mar 08, 2010 at 05:07:16AM +, Luke Mewburn wrote: Module Name: src Committed By: lukem Date: Mon Mar 8 05:07:16 UTC 2010 Modified Files: src/external/bsd/openldap/dist/include: portable.hin Log Message: Disable HAVE_TLS here; we'll conditionally enable it in

<    2   3   4   5   6   7   8   >