Re: CVS commit: src/share/man/man4

2011-08-30 Thread Jukka Ruohonen
On Tue, Aug 30, 2011 at 10:10:05AM -0500, David Young wrote: The driver should be converted, however, I don't think that there is a case for bluntly removing bktr(4), Yes, I was corrected already (the conversion should go towards video(4)). But as always, it is about picking the good

Re: CVS commit: src/share/man/man4

2011-08-30 Thread Jukka Ruohonen
On Tue, Aug 30, 2011 at 06:33:18PM +0200, Marc Balmer wrote: Am 30.08.11 18:22, schrieb Jukka Ruohonen: And why should GENERIC *not* support hardware that is available, works, and is of use to someone? If GENERIC is to support only the idea of what an OS should look for some developers, why

Re: CVS commit: src/share/man/man4

2011-08-30 Thread Jukka Ruohonen
On Tue, Aug 30, 2011 at 06:51:09PM +0200, Marc Balmer wrote: To address this issue, I think we are slowly moving towards modularized kernels. So what I said is about drivers and kernel subsystem, that are not yet available as modules. But modules are still WIP, and I think there are still a

Re: CVS commit: src/sys/kern

2011-08-29 Thread Jukka Ruohonen
On Mon, Aug 29, 2011 at 08:47:51AM +0200, J. Hannken-Illjes wrote: On Aug 29, 2011, at 2:39 AM, Mindaugas Rasiukevicius wrote: Module Name:src Committed By: rmind Date: Mon Aug 29 00:39:16 UTC 2011 Modified Files: src/sys/kern: sys_select.c

Re: CVS commit: src/share/man/man4

2011-08-29 Thread Jukka Ruohonen
: Jukka Ruohonen Sent: Monday, August 29, 2011 6:41 AM Newsgroups: gmane.os.netbsd.devel.cvs.full To: source-changes-full-qavaossjccednm+yrof...@public.gmane.org Subject: CVS commit: src/share/man/man4 Module Name: src Committed By: jruoho Date: Mon Aug 29 10:41:10 UTC 2011 Modified Files

Re: CVS commit: src/sys/arch/i386/conf

2011-08-29 Thread Jukka Ruohonen
On Mon, Aug 29, 2011 at 02:48:52PM +0200, Marc Balmer wrote: Am 29.08.11 11:38, schrieb Jukka Ruohonen: On Sat, Aug 27, 2011 at 09:28:56AM +, Marc Balmer wrote: Module Name: src Committed By: mbalmer Date: Sat Aug 27 09:28:56 UTC 2011 Modified Files

Re: CVS commit: src/sys/arch/i386/conf

2011-08-29 Thread Jukka Ruohonen
On Mon, Aug 29, 2011 at 02:58:32PM +0200, Marc Balmer wrote: Am 29.08.11 14:53, schrieb Jukka Ruohonen: On Mon, Aug 29, 2011 at 02:48:52PM +0200, Marc Balmer wrote: Am 29.08.11 11:38, schrieb Jukka Ruohonen: On Sat, Aug 27, 2011 at 09:28:56AM +, Marc Balmer wrote: Module Name: src

Re: CVS commit: src/sys/arch/i386/conf

2011-08-09 Thread Jukka Ruohonen
On Tue, Aug 09, 2011 at 09:44:09AM +0200, Alan Barrett wrote: Whether or not available as a module is a good reason for removing something from GENERIC is a separate topic which I will not consider in this message. Fortunately, people can vote with their own work; henceforth all drivers I

Re: CVS commit: src/sys/arch/i386/conf

2011-08-09 Thread Jukka Ruohonen
On Tue, Aug 09, 2011 at 10:18:29AM +0200, Manuel Bouyer wrote: Sorry, but this is just plain stupid. I could as well make so my work won't work in a modular kernel, and we'll have incompatible features. Of course it will work in non-modular kernels, but you just have to add it there manually.

Re: CVS commit: src/sys/uvm

2011-08-09 Thread Jukka Ruohonen
On Sat, Aug 06, 2011 at 05:25:04PM +, Mindaugas Rasiukevicius wrote: Module Name: src Committed By: rmind Date: Sat Aug 6 17:25:04 UTC 2011 Modified Files: src/sys/uvm: uvm_amap.c uvm_anon.c uvm_anon.h uvm_fault.c uvm_loan.c uvm_map.c Log Message: - Rework

Re: CVS commit: src/sys/arch/x86/x86

2011-08-08 Thread Jukka Ruohonen
On Mon, Aug 08, 2011 at 11:18:35AM +, Jared D. McNeill wrote: Module Name: src Committed By: jmcneill Date: Mon Aug 8 11:18:34 UTC 2011 Modified Files: src/sys/arch/x86/x86: tsc.c Log Message: If the USE_PLATFORM_CLOCK flag is set in the FADT, it indicates that OSPM

Re: CVS commit: src/sys/arch/x86/x86

2011-08-08 Thread Jukka Ruohonen
On Mon, Aug 08, 2011 at 07:40:45AM -0400, Jared McNeill wrote: On Mon, 8 Aug 2011, Jukka Ruohonen wrote: We should not really trust ACPI/FADT here. See acpicpu(4) how this is Why? Because we (the operating system) know this better than the BIOS writer. And because this flag is not reliable

Re: CVS commit: src/sys/arch/x86/x86

2011-08-08 Thread Jukka Ruohonen
On Mon, Aug 08, 2011 at 07:49:42AM -0400, Jared McNeill wrote: On Mon, 8 Aug 2011, Jukka Ruohonen wrote: Why? Because we (the operating system) know this better than the BIOS writer. And because this flag is not reliable; numerous systems where tsc(9) is broken miss this flag in my ACPI

Re: CVS commit: src/sys/arch/x86/x86

2011-08-08 Thread Jukka Ruohonen
On Mon, Aug 08, 2011 at 08:16:43AM -0400, Jared McNeill wrote: Newer systems with invariant TSC shouldn't set the USE_PLATFORM_CLOCK flag. But the do, unfortunately. Again, I have several examples from the field. - Jukka.

Re: CVS commit: src/sys/dev/acpi

2011-08-06 Thread Jukka Ruohonen
On Fri, Aug 05, 2011 at 06:27:48PM +, Jonathan A. Kollasch wrote: Module Name: src Committed By: jakllsch Date: Fri Aug 5 18:27:48 UTC 2011 Modified Files: src/sys/dev/acpi: acpi.c Log Message: As we add a handler for the ACPI fixed feature button events, ensure

Re: CVS commit: src/sys/dev/acpi

2011-08-06 Thread Jukka Ruohonen
On Sat, Aug 06, 2011 at 12:02:52PM +, Jonathan A. Kollasch wrote: The current version does what I needed. But what is that? - Jukka.

Re: CVS commit: src/sys/arch/i386/conf

2011-08-05 Thread Jukka Ruohonen
On Thu, Aug 04, 2011 at 02:45:54PM +, Jonathan A. Kollasch wrote: Module Name: src Committed By: jakllsch Date: Thu Aug 4 14:45:54 UTC 2011 Modified Files: src/sys/arch/i386/conf: ALL Log Message: Add coram(4). Can we get manual pages for these? - Jukka.

Re: CVS commit: src/crypto/external/bsd/netpgp/dist

2011-07-20 Thread Jukka Ruohonen
On Wed, Jul 20, 2011 at 08:03:59AM +, David Holland wrote: In just about every other test suite I've used (which includes some very large ones with turing complete/scripted test harness programs and other fancy stuff) there are test programs and test driver scripts, but all the pieces have

Re: CVS commit: src/lib/libc/sys

2011-07-19 Thread Jukka Ruohonen
On Sat, Jul 16, 2011 at 04:51:41PM +0100, David Laight wrote: Log Message: Note that dup2(2) and dup3(2) may not fail with EMFILE; from PR lib/45148. What happens if the 'new' file number is above RLIMIT_NOFILES? It fails with EBADF. - Jukka.

Re: CVS commit: src/tests/crypto/libcrypto

2011-07-07 Thread Jukka Ruohonen
On Tue, Jul 05, 2011 at 10:03:10AM +, S.P.Zeidler wrote: Module Name: src Committed By: spz Date: Tue Jul 5 10:03:10 UTC 2011 Modified Files: src/tests/crypto/libcrypto/idea: Makefile src/tests/crypto/libcrypto/mdc2: Makefile src/tests/crypto/libcrypto/rc5:

Re: CVS commit: src

2011-07-07 Thread Jukka Ruohonen
On Thu, Jul 07, 2011 at 07:36:15PM +0100, Matthias Scheler wrote: Merge 't_environment' and 't_environment_pth'. Please undo that change. The point of two different tests was in particular that one binary is linked with libpthread and the other one isn't. Why? I don't see any point in

Re: CVS commit: src/tests/crypto/libcrypto

2011-07-07 Thread Jukka Ruohonen
On Thu, Jul 07, 2011 at 08:34:41PM +0200, S.P.Zeidler wrote: These tests are not new [...] Sorry, I misinterpreted. - Jukka.

Re: CVS commit: src

2011-07-04 Thread Jukka Ruohonen
On Mon, Jul 04, 2011 at 07:54:38AM +, Emmanuel Dreyfus wrote: Module Name: src Committed By: manu Date: Mon Jul 4 07:54:38 UTC 2011 Modified Files: src/include/rpc: xdr.h src/lib/libc/include: namespace.h src/lib/libc/rpc: Makefile.inc Added Files:

Re: CVS commit: src/tests/syscall

2011-07-03 Thread Jukka Ruohonen
On Sun, Jul 03, 2011 at 11:45:24PM +, David Holland wrote: On Sun, Jul 03, 2011 at 08:22:51PM +, Jukka Ruohonen wrote: Modified Files: src/tests/syscall: t_mknod.c Log Message: Remove wrong check. XXX: Why does this fail on tmpfs but not ffs? That *should

Re: CVS commit: src/crypto/external/bsd/netpgp/dist

2011-06-29 Thread Jukka Ruohonen
On Tue, Jun 28, 2011 at 06:50:50AM +, David Holland wrote: Perhaps if atf were less intrusive...? What do you mean? I think it needs to be quite intrusive (sandboxing, etc.). Unquestionably the old /regress-style is not the way to go. Even if you dislike some parts of the API, already the

Re: CVS commit: src/crypto/external/bsd/netpgp/dist

2011-06-28 Thread Jukka Ruohonen
On Tue, Jun 28, 2011 at 08:12:26AM +0200, Alistair Crooks wrote: 3. they are candidates for modifying to work under atf, I have yet to get the time to do that 4. luke kindly made some gnu autotests for them a while ago [...] and if someone was to offer to convert these tests to atf

Re: CVS commit: src/sys/arch/mips/rmi

2011-06-28 Thread Jukka Ruohonen
On Tue, Jun 28, 2011 at 07:17:31AM +, Adam Hoka wrote: Module Name: src Committed By: ahoka Date: Tue Jun 28 07:17:31 UTC 2011 Modified Files: src/sys/arch/mips/rmi: rmixl_nand.c Log Message: follow nand api changes Some of these changes broke the build. - Jukka.

Re: CVS commit: [cherry-xenmp] src/sys/arch/xen

2011-06-26 Thread Jukka Ruohonen
On Sun, Jun 26, 2011 at 12:56:33PM +, Cherry G. Mathew wrote: Module Name: src Committed By: cherry Date: Sun Jun 26 12:56:33 UTC 2011 Modified Files: src/sys/arch/xen/include [cherry-xenmp]: intr.h src/sys/arch/xen/xen [cherry-xenmp]: hypervisor.c Log Message:

Re: CVS commit: src/sys

2011-06-14 Thread Jukka Ruohonen
On Sun, Jun 12, 2011 at 10:11:53AM +, Jukka Ruohonen wrote: Log Message: Move the evaluation of the _PDC control method out from the acpicpu(4) driver to the main acpi(4) stack. Follow Linux and evaluate it early. Should fix PR port-amd64/42895, possibly also PR kern/42583, and many other

Re: CVS commit: src

2011-06-13 Thread Jukka Ruohonen
On Sun, Jun 12, 2011 at 09:12:46PM +, Iain Hibbert wrote: Module Name: src Committed By: plunky Date: Sun Jun 12 21:12:46 UTC 2011 Modified Files: src/distrib/sets/lists/tests: mi src/tests/lib/libc/ssp: Makefile t_ssp.sh Added Files:

Re: CVS commit: src/tests

2011-06-13 Thread Jukka Ruohonen
On Sat, Jun 11, 2011 at 02:03:20PM -0400, Christos Zoulas wrote: Log Message: Turn warns on for all tests and fix all the bugs. Thanks for the cleanup. Now the wscrl-test (lib/libcurses/t_curses) however fails: http://www.whooppee.com/~paul/amd64-results/1985_atf.html#failed-tcs-summary

Re: CVS commit: src/usr.bin/make

2011-06-10 Thread Jukka Ruohonen
On Fri, Jun 10, 2011 at 11:57:39PM +, Simon J. Gerraty wrote: Module Name: src Committed By: sjg Date: Fri Jun 10 23:57:39 UTC 2011 Modified Files: src/usr.bin/make: meta.c Log Message: size_t on amd64 doesn't like %u, use a cast. %zu? - Jukka.

Re: CVS commit: src/sys/dev/sysmon

2011-06-04 Thread Jukka Ruohonen
On Sat, Jun 04, 2011 at 01:24:33PM +, Paul Goyette wrote: Since nothing actually records or maintains an average sensor value, remove value_avg from the prop_dict. We can't completely remove it because there's one driver that uses this field for its own private purposes, so for now we

Re: CVS commit: src/tests/lib/libc/stdlib

2011-06-04 Thread Jukka Ruohonen
On Sat, Jun 04, 2011 at 10:49:49PM +, Adam Hamsik wrote: Module Name: src Committed By: haad Date: Sat Jun 4 22:49:49 UTC 2011 Modified Files: src/tests/lib/libc/stdlib: t_strtol.c Log Message: Fix problem with overflowing constant definition t_strtol.c:95:

Re: CVS commit: src

2011-05-31 Thread Jukka Ruohonen
On Tue, May 24, 2011 at 06:07:12PM +, S.P.Zeidler wrote: - introduce a limit for the routes accepted via IPv6 Router Advertisement: a common 2 interface client will have 6, the default limit is 100 and can be adjusted via sysctl As usual, can we have these noted in sysctl(7)? - Jukka.

Re: CVS commit: src/tests/kernel

2011-05-31 Thread Jukka Ruohonen
On Sat, May 28, 2011 at 04:53:21PM +0100, Julio Merino wrote: One thing is reorganizing the tests to match the tree structure, but the other is to move the tests right next to the source I don't quite understand the latter part. Why is this a bad thing? I always thought that having a single

Re: CVS commit: src/tests/lib/libc/stdlib

2011-05-10 Thread Jukka Ruohonen
On Tue, May 10, 2011 at 11:37:16AM -0700, Cliff Neighbors wrote: In file included from /home/cliff/netbsd/NetBSD-current/usr/src/tests/lib/libc/s tdlib/t_strtod.c:38: /home/cliff/netbsd/NetBSD-current/build/evbmips64-eb-20110510/dest/usr/include/f env.h:29:2: error: #error fenv.h is

Re: CVS commit: src/sys/fs/tmpfs

2011-05-09 Thread Jukka Ruohonen
On Mon, May 09, 2011 at 06:50:08PM +0200, Adam Hoka wrote: So can we use for (int i = 0; ... ? :p Hopefully not... - Jukka.

Re: CVS commit: src/distrib/sets/lists

2011-05-09 Thread Jukka Ruohonen
On Mon, May 09, 2011 at 07:57:46PM +0200, Adam Hamsik wrote: Hmm I have already added MKPERFUSE so please revert mine commits or yours :). Please also document these MKVOODOOS. I have a gut feeling that half of these won't even build... - Jukka.

Re: CVS commit: src/tests/usr.bin/pr

2011-05-05 Thread Jukka Ruohonen
On Fri, May 06, 2011 at 01:31:11AM +, David Holland wrote: The stuff in util/ predates the decision to use a matching directory structure. It hasn't been renamed because of inertia, I guess, Ok. That was kind of my supposition too. combined with cvs issues and perhaps the faint hope we

Re: CVS commit: src

2011-05-04 Thread Jukka Ruohonen
On Tue, May 03, 2011 at 06:28:46PM +, David Young wrote: Reduces the resources demanded by TCP sessions in TIME_WAIT-state using methods called Vestigial Time-Wait (VTW) and Maximum Segment Lifetime Truncation (MSLT). Can we have the new sysctl nodes documented? - Jukka.

Re: CVS commit: src/tests/usr.bin/pr

2011-05-03 Thread Jukka Ruohonen
On Tue, May 03, 2011 at 07:44:57AM -0700, Paul Goyette wrote: I think it actually does, but only at run-time. It will end up counting as a bogus test program. Another question: was a conclusion ever reached about the preferred directory structure for the tests? I've been now following the

Re: CVS commit: src/distrib/sets/lists/tests

2011-05-02 Thread Jukka Ruohonen
On Mon, May 02, 2011 at 08:32:21AM +, Paul Goyette wrote: Log Message: Also add the Atffile to the sets list Thanks for fixing this. Too bad we can not test PR bin/43394... ;-). - Jukka.

Re: CVS commit: src/distrib/sets/lists/tests

2011-05-02 Thread Jukka Ruohonen
On Mon, May 02, 2011 at 01:40:01AM -0700, Paul Goyette wrote: True, although bin/43394 really describes a wider problem. There is simply too much magic/voodoo required to keep the build system happy. Indeed, and AFAIR none of this is really documented, at least in one place. Trial and error,

Re: CVS commit: src

2011-05-01 Thread Jukka Ruohonen
On Sun, May 01, 2011 at 02:50:55PM +, Christos Zoulas wrote: I am not sure this is valid. It could return ENOTTY too for this case or even EINVAL. The opengroup manual page is not clear. Do you have a more authoritative source of what it should return in this case? Indeed I think the

Re: CVS commit: src/sys/kern

2011-04-16 Thread Jukka Ruohonen
On Sat, Apr 16, 2011 at 08:39:19PM +, Mindaugas Rasiukevicius wrote: Module Name: src Committed By: rmind Date: Sat Apr 16 20:39:18 UTC 2011 Modified Files: src/sys/kern: uipc_sem.c Log Message: - Add nsems_total and track the use of all semaphores (not only named

Re: CVS commit: src/sys

2011-04-16 Thread Jukka Ruohonen
On Sun, Apr 17, 2011 at 05:16:29AM +, matthew green wrote: Module Name: src Committed By: mrg Date: Sun Apr 17 05:16:29 UTC 2011 Modified Files: src/sys/kern: kern_module.c src/sys/sys: module.h Log Message: add a module_machine, that defaults to machine.

Re: CVS commit: src

2011-04-12 Thread Jukka Ruohonen
On Tue, Apr 12, 2011 at 08:05:13PM +0200, Klaus Klein wrote: This exhibits something particularly well that's been bugging me for quite a while about such documentation changes: I think documenting the implementation's structure layouts in section 3 is wrong, at least when supposedly portable

Re: CVS commit: src

2011-04-12 Thread Jukka Ruohonen
On Tue, Apr 12, 2011 at 09:24:00PM +0300, Jukka Ruohonen wrote: On Tue, Apr 12, 2011 at 08:05:13PM +0200, Klaus Klein wrote: by being that specific, such documentation creates the obligation to keep the redundant definition in sync. PS. If you look what I've written in, say, stdlib(3

Re: CVS commit: src

2011-04-12 Thread Jukka Ruohonen
On Tue, Apr 12, 2011 at 09:56:27PM +0200, Klaus Klein wrote: Just to make it clear again, it's really just the structure definitions being documented verbatim I'm taking issue with. I agree with this and Iain's earlier comment about using a wording such as [...] has at least the following

Re: CVS commit: src

2011-04-12 Thread Jukka Ruohonen
On Tue, Apr 12, 2011 at 10:26:40PM +0200, Joerg Sonnenberger wrote: On Tue, Apr 12, 2011 at 11:22:17PM +0300, Jukka Ruohonen wrote: And to use mktime(3), you must know the tm structure. No, you don't have to. That's the point Klaus is trying to make. You need to know that certain fields

Re: CVS commit: src

2011-04-10 Thread Jukka Ruohonen
On Sat, Apr 09, 2011 at 05:45:25PM +, Paul Goyette wrote: Module Name: src Committed By: pgoyette Date: Sat Apr 9 17:45:25 UTC 2011 Modified Files: src/distrib/sets/lists/tests: mi src/etc/mtree: NetBSD.dist.tests src/tests/lib/libc: Makefile Added Files:

Re: CVS commit: src/tests/syscall

2011-04-04 Thread Jukka Ruohonen
On Mon, Apr 04, 2011 at 09:05:19AM +0200, Nicolas Joly wrote: Adding the following to the testcase header should do the trick: atf_tc_set_md_var(tc,require.user,unprivileged); In that case, if run as root, it will lower its privileges to the unprivileged user _atf before running the

Re: CVS commit: src/tests/syscall

2011-04-04 Thread Jukka Ruohonen
On Mon, Apr 04, 2011 at 09:05:19AM +0200, Nicolas Joly wrote: Adding the following to the testcase header should do the trick: atf_tc_set_md_var(tc,require.user,unprivileged); In that case, if run as root, it will lower its privileges to the unprivileged user _atf before running the

Re: CVS commit: src/tests

2011-03-25 Thread Jukka Ruohonen
On Fri, Mar 25, 2011 at 11:09:26AM +0100, Nicolas Joly wrote: Skipping them is not the right solution IMO. I have no strong opinion about this. But to me it seems that these bugs/tests are really testing an emulator instead of NetBSD itself. - Jukka.

Re: CVS commit: [rmind-uvmplock] src/sys/arch

2011-03-17 Thread Jukka Ruohonen
On Thu, Mar 17, 2011 at 04:46:30AM +, Mindaugas Rasiukevicius wrote: - cpu_attach: remove assignment to cpus_running, as primary CPU might not be attached first, which causes reset (and thus missed secondary CPUs). Can you explain this a little more? - Jukka.

Re: CVS commit: src/sys/arch/x86/x86

2011-03-03 Thread Jukka Ruohonen
On Fri, Mar 04, 2011 at 04:04:53PM +1100, matthew green wrote: Raise the return value of the match-function of est(4) and powernow(4). The assigned priorities are now: 10 for acpicpu(4), 5 for est(4) and powernow(4), and 1 for odcm(4). These are used to pick the preferred driver. to the

Re: CVS commit: src/sys

2011-03-01 Thread Jukka Ruohonen
On Tue, Mar 01, 2011 at 09:53:24AM +, Andrew Doran wrote: You must not call these interfaces or any kind of MI synchronization interface, spin mutexes included, with interrupts switched off at the machine level! Yes, of course. It was a bug in a code that is not yet used. Already fixed,

Re: CVS commit: src/sys

2011-02-28 Thread Jukka Ruohonen
On Mon, Feb 28, 2011 at 04:48:43PM +, Mindaugas Rasiukevicius wrote: Why interrupts are disabled here? Calling xc_wait() with interrupts disabled is, at minimum, very expensive, and I would say it is wrong. Note that xc_wait(9) does not necessary spin - it can block. Because interrupts

Re: CVS commit: src

2011-02-25 Thread Jukka Ruohonen
On Thu, Feb 24, 2011 at 04:45:30PM +0100, Joerg Sonnenberger wrote: pretty much unchanged. Feel free to perform benchmarks if you want. There are also changes to EST in that time window... This must be a bad joke. The things I did were just simple refactoring. As you should be well aware of,

Re: CVS commit: src/sys/dev/acpi

2011-02-25 Thread Jukka Ruohonen
On Fri, Feb 25, 2011 at 07:55:07PM +, Jukka Ruohonen wrote: Log Message: Start to derive the percpu(9) (or per-domain) state coordination mechanisms by parsing the _CSD, _PSD, and _TSD objects by default. This is quite interesting development affecting the whole x86; the sleep

Re: CVS commit: src/sys/arch

2011-02-24 Thread Jukka Ruohonen
On Thu, Feb 24, 2011 at 10:56:04AM +, Jukka Ruohonen wrote: Log Message: Move PowerNow! to the cpufeaturebus. I tried to be very careful, but please test for any fall over. - Jukka.

Re: CVS commit: src/sys/arch

2011-02-23 Thread Jukka Ruohonen
On Wed, Feb 23, 2011 at 11:43:24AM +, Jukka Ruohonen wrote: Module Name: src Committed By: jruoho Date: Wed Feb 23 11:43:23 UTC 2011 Modified Files: src/sys/arch/amd64/conf: GENERIC XEN3_DOM0 src/sys/arch/i386/conf: ALL GENERIC src/sys/arch/x86/conf

Re: CVS commit: src/sys/dev/acpi

2011-02-22 Thread Jukka Ruohonen
On Tue, Feb 22, 2011 at 09:34:13AM +, Jukka Ruohonen wrote: in acpicpu_cstate_fadt(). Note that this violates the specification, given: PBlockAddress provides the system I/O address for the processors register block. Each processor can supply a different such address

Re: CVS commit: src/sys/arch/amd64/conf

2011-02-20 Thread Jukka Ruohonen
On Mon, Feb 21, 2011 at 01:45:01AM +1100, matthew green wrote: well, i dunno about others but i've found that the old modules lying around tends to fill up space pretty quickly, but ignoring that problem and looking at recent i386 builds, i see that the MONOLITHIC kernel set is only 440kb

Re: CVS commit: src/sys/arch/amd64/conf

2011-02-20 Thread Jukka Ruohonen
On Sun, Feb 20, 2011 at 07:19:03AM -0800, Paul Goyette wrote: ...ignoring [the old modules] problem ... A _single_ instance of modules on amd64 occupies 11MB # du -sk dest/amd64/stand/amd64/5.99.46/ 11404 dest/amd64/stand/amd64/5.99.46/ # That's nearly as much as

Re: CVS commit: src/sys/arch/amd64/conf

2011-02-20 Thread Jukka Ruohonen
On Sun, Feb 20, 2011 at 09:58:44PM +, David Holland wrote: years without being solved. In fact, in general all such discussions have been shouted down by module advocates insisting without evidence that no such problems exist -- this is why these problems remain unsolved and have been

Re: CVS commit: src/sys/arch/amd64/conf

2011-02-19 Thread Jukka Ruohonen
On Sat, Feb 19, 2011 at 05:13:58PM +0100, Matthias Drochner wrote: 2. I don't want tons of modules which I'll never need installed into my root file system. As it was common in good old times (tm), my root filesystems are as small as possible. Now, with modules being added to the

Re: CVS commit: src/sys/sys

2011-02-18 Thread Jukka Ruohonen
On Sat, Feb 19, 2011 at 02:01:46AM +, Matt Thomas wrote: Module Name: src Committed By: matt Date: Sat Feb 19 02:01:46 UTC 2011 Modified Files: src/sys/sys: cdefs.h Log Message: Add __CTASSERT(x) Why can't there be just a single CTASSERT(x)? Alternatively, a

Re: CVS commit: src/sys/dev/acpi

2011-02-17 Thread Jukka Ruohonen
The so-called wakedev code might be broken for a short while. The reasons are listed below. - Jukka. On Thu, Feb 17, 2011 at 10:49:30AM +, Jukka Ruohonen wrote: Module Name: src Committed By: jruoho Date: Thu Feb 17 10:49:30 UTC 2011 Modified Files: src/sys/dev/acpi

Re: CVS commit: src/sys/dev/acpi

2011-02-17 Thread Jukka Ruohonen
On Thu, Feb 17, 2011 at 07:36:49PM +, Jukka Ruohonen wrote: Log Message: As explained in the new ACPICA documentation, as of ACPICA 20101207, the _PRW methods are no longer automatically executed as part of the ACPICA initialization. Refactor and rewrite the wake-device code to account

Re: CVS commit: src/share/man/man9

2011-01-25 Thread Jukka Ruohonen
On Tue, Jan 25, 2011 at 11:46:48PM +, YAMAMOTO Takashi wrote: - add some random notes Basically, KASSERT() should be used for light-weight checks and KDASSERT() should be used for heavier ones. Callers should not rely on the side effects of expression because,

Re: Changes made with too little discussion

2011-01-19 Thread Jukka Ruohonen
On Wed, Jan 19, 2011 at 11:31:27AM +0200, Alan Barrett wrote: I don't care much about /usr/share/misc/operator, but I do care about people making changes without discussion, or making changes with too little discussion, or making changes that go against the consensus of the discussion. For

Re: Changes made with too little discussion

2011-01-19 Thread Jukka Ruohonen
On Wed, Jan 19, 2011 at 08:16:41PM +, David Holland wrote: The most important lesson to learn in software is that it's ok to be wrong and that when you are wrong, the sooner someone notices the better. We all make mistakes; we all make lots of mistakes, all the time. (Writing this post was

Re: CVS commit: src

2011-01-18 Thread Jukka Ruohonen
On Tue, Jan 18, 2011 at 09:15:27AM +, David Holland wrote: It's perfectly possible to propose things on tech-userlevel and get them agreed on. It just requires doing a little more planning up front to make sure the proposal has clear motivations and benefits and addresses likely concerns.

Re: CVS commit: src

2011-01-17 Thread Jukka Ruohonen
On Tue, Jan 18, 2011 at 11:34:23AM +1100, Simon Burge wrote: Why was this removed when there was an active discussion about removing it where no concensus was reached? This sort of thing where commis occur before a discussion is finished seems to be occurring more and more often. Maybe

Re: CVS commit: src

2011-01-13 Thread Jukka Ruohonen
On Tue, Jan 11, 2011 at 12:45:05AM +, Jean-Yves Migeon wrote: Log Message: Add man pages for Xen devices: pciback.4 xbd.4 xbdback.4 xenbus.4 xennet.4 xpci.4 xvif.4 Presumably these should have gone to man4.x86. But I guess it is too late now. - Jukka.

Re: CVS commit: src/sys/kern

2011-01-09 Thread Jukka Ruohonen
On Sat, Jan 08, 2011 at 03:37:05PM -0500, Christos Zoulas wrote: Log Message: Add two sysctls one that does verbose transaction logging and a second one that disables flushing the disk cache (which is fast but dangerous for data integrity). From simon a long while back. Can we also have

Re: CVS commit: src/sys/dev/acpi

2011-01-04 Thread Jukka Ruohonen
On Tue, Jan 04, 2011 at 12:52:57PM +, Mindaugas Rasiukevicius wrote: 1) There is a use-after-free. Hint: TAILQ_FOREACH_SAFE(). 2) It is not safe; while lock is dropped, the 'next' entry may also be removed and freed. Hint: have a local list and avoid relocking. Hmm. 2) implies that the

Re: CVS commit: src/sys/dev/acpi

2011-01-03 Thread Jukka Ruohonen
On Tue, Jan 04, 2011 at 05:48:49AM +, Jukka Ruohonen wrote: Do not queue functions via sysmon_taskq(9) in the pmf(9) resume hooks. There is a small and unlikely race when the drivers are loaded as modules; suspend, resume, queue a function, and immediately unload the module

Re: CVS commit: src/etc/powerd/scripts

2011-01-01 Thread Jukka Ruohonen
On Fri, Dec 31, 2010 at 12:51:24PM -0600, David Young wrote: IMO, we should put the system to sleep by sending a power-saving/wakeup-latency goal and a set of waking events (e.g., keystroke, mouse movement, LAN activity) to the root device_t using drvctl. To put any smaller set of devices to

Re: CVS commit: src/etc/powerd/scripts

2010-12-31 Thread Jukka Ruohonen
On Fri, Dec 31, 2010 at 11:29:23AM +0100, Jean-Yves Migeon wrote: Seems reasonable to me. We could have a more featureful binary later, and just alias zzz(8) to it. We have ready ioctl-facilities in sysmon's sysmon_power.c. I believe it was originally intended by the author that MD code should

Re: CVS commit: src/etc/powerd/scripts

2010-12-31 Thread Jukka Ruohonen
On Fri, Dec 31, 2010 at 04:54:47AM -0800, Paul Goyette wrote: However, the current implementation is simply a text string with no defined semantics. A back-end is able to set the value, and it can be retrieved via the POWER_IOC_GET_TYPE ioctl, but otherwise nothing uses the value. Sure, I

Re: CVS commit: src

2010-12-25 Thread Jukka Ruohonen
On Sat, Dec 25, 2010 at 04:42:30AM +, David Holland wrote: On Fri, Dec 17, 2010 at 10:38:21PM +0200, Jukka Ruohonen wrote: A related note: should we provide typeof(3) in the restricted namespace instead, i.e. as __typeof(3)? People are more likely to find the page if it's installed

Re: CVS commit: src/usr.bin/xargs

2010-12-21 Thread Jukka Ruohonen
On Tue, Dec 21, 2010 at 03:30:13PM -0500, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Tue Dec 21 20:30:13 UTC 2010 Modified Files: src/usr.bin/xargs: xargs.1 Log Message: PR/44259: Aleksey Cheusov: xargs: -r option is supported but not documented

Re: CVS commit: src/lib/libc/time

2010-12-18 Thread Jukka Ruohonen
On Fri Dec 17 2010 at 18:11:57 -0500, Christos Zoulas wrote: Module Name:src Committed By: christos Date: Fri Dec 17 23:11:57 UTC 2010 Modified Files: src/lib/libc/time: localtime.c Log Message: PR/44248: Antti Kantee: Fix multi-threaded

Re: CVS commit: src/lib/libc

2010-12-17 Thread Jukka Ruohonen
On Thu, Dec 16, 2010 at 01:38:07PM -0500, Christos Zoulas wrote: Log Message: Provide a re-entrant and thread-safe set of timezone API's that don't require locking and can operate on user-specified timezones as opposed to having to alter the environment to change a timezone. This work was

Re: CVS commit: src

2010-12-17 Thread Jukka Ruohonen
On Fri, Dec 17, 2010 at 12:14:05PM +, Jukka Ruohonen wrote: Log Message: There is no harm to add a manual page for the GNU typeof()-construct, given that it has already crawled into the source tree. A related note: should we provide typeof(3) in the restricted namespace instead, i.e

Re: CVS commit: src/share/man/man7

2010-12-14 Thread Jukka Ruohonen
On Tue, Dec 14, 2010 at 12:16:36AM -0800, John Nemeth wrote: Silly question, but why would it go in section 4? Section 4 is for devices. module(4) doesn't represent any kind of device. Seems to me that section 7 would be the best place. Well I guess it went to section 4 as the old

Re: CVS commit: src

2010-12-13 Thread Jukka Ruohonen
On Sat, Dec 11, 2010 at 04:13:03AM +, Paul Goyette wrote: Module Name: src Committed By: pgoyette Date: Sat Dec 11 04:13:03 UTC 2010 Modified Files: src/share/man/man4: swsensor.4 src/sys/dev/sysmon: swsensor.c Log Message: Enhance the swsensor(4)

Re: CVS commit: src/share/man/man7

2010-12-11 Thread Jukka Ruohonen
On Sun, Dec 12, 2010 at 05:07:05AM +0900, Izumi Tsutsui wrote: Log Message: Point to module(9) instead of modctl(8). We really need module(4) (not 9) like lkm(4)... Agreed. Another question is the ever so terrible sysctl(7). (I think it should be split, but I don't have a clear plan on how

Re: CVS commit: src/share/man/man7

2010-12-11 Thread Jukka Ruohonen
On Sat, Dec 11, 2010 at 06:43:34PM -0800, Paul Goyette wrote: Other than the rather generic description that existed in the older lkm(4) man page, I'm not sure what we could add. I'm not even totally convinced that we need to add anything... In addition to the generic information in the old

Re: CVS commit: src/share/misc

2010-12-02 Thread Jukka Ruohonen
On Thu, Dec 02, 2010 at 08:31:43AM +, David Holland wrote: On Tue, Nov 30, 2010 at 07:07:15PM +, Jukka Ruohonen wrote: Add numerous entries from Roland Kammerer. Some of these are not acronyms: 1337, FSCK, and NOOB are the most obvious, but perhaps also things like W8 for wait

Re: CVS commit: src/lib/libc/stdio

2010-10-23 Thread Jukka Ruohonen
On Fri, Oct 22, 2010 at 05:29:46PM -0400, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Fri Oct 22 21:29:46 UTC 2010 Modified Files: src/lib/libc/stdio: ftell.c local.h Log Message: implement EOVERFLOW To generate a diff of this commit: cvs

Re: CVS commit: src

2010-08-29 Thread Jukka Ruohonen
On Fri, Aug 27, 2010 at 04:03:20PM +1000, matthew green wrote: not sure exactly what that means here... but maybe acpicpu should default to blacklisting P4's? for when it becomes a normal driver that is enabled by default.. Blacklisting based on processor type sounds reasonable, but somewhat

Re: CVS commit: src/sys/netinet

2010-08-11 Thread Jukka Ruohonen
On Wed, Aug 11, 2010 at 09:36:45AM +, Antti Kantee wrote: Module Name: src Committed By: pooka Date: Wed Aug 11 09:36:45 UTC 2010 Modified Files: src/sys/netinet: ip_carp.c Log Message: Use kpause() instead of DELAY() and sleep a minimum of 1 tick. This is possible

Re: CVS commit: src/sys

2010-08-08 Thread Jukka Ruohonen
On Sun, Aug 08, 2010 at 04:58:42PM +, Jukka Ruohonen wrote: Merge P-state support for acpicpu(4). Hi. I'll post this note about conclusions from various informal discussions regarding acpicpu(4) and CPU power management generally. In my opinion, it is increasingly evident that we will need

Re: CVS commit: src/sys/dev/acpi

2010-08-08 Thread Jukka Ruohonen
On Mon, Aug 09, 2010 at 07:30:52AM +0200, Christoph Egger wrote: Log Message: Downgrade the currently supported maximum C-state to C1. There appears to be timer-related interrupt issues also in C2. With C1 it is guaranteed that acpicpu(4) will not cause any slowdowns due stalled local APIC

Re: CVS commit: src/sys/dev/acpi

2010-07-30 Thread Jukka Ruohonen
On Sun, Jul 18, 2010 at 08:59:33PM -0400, Christos Zoulas wrote: 1. ACPI seems to define cpuids 1..n; we define 0..n-1. Adjust for that 2. My laptop is dual core, but ACPI reports 4 cpu nodes. Instead of attaching the unmatched ones, make the match fail. Do we want to attach and do

Re: CVS commit: src/sys/dev/acpi

2010-07-24 Thread Jukka Ruohonen
On Mon, Jul 19, 2010 at 12:39:08PM +, Quentin Garnier wrote: When the platform uses the APIC interrupt model, OSPM associates processors declared in the namespace with entries in the MADT. Prior to ACPI 3.0, this was accomplished using the processor object's ProcessorID and the ACPI

<    1   2   3   4   >