Module Name:src
Committed By: uebayasi
Date: Mon Feb 1 05:48:19 UTC 2010
Modified Files:
src/sys/uvm: uvm_fault.c
Log Message:
ERESTART is already negative. Give up negating error values to not override
the original values. Pointed out by rmind@, thanks.
In the lower f
Module Name:src
Committed By: uebayasi
Date: Sun Jan 31 17:13:38 UTC 2010
Modified Files:
src/sys/uvm: uvm_fault.c
Log Message:
Ax uvm_fault_internal() & break it into functions. "Upper" fault and "lower"
fault routines are separated now.
To generate a diff of this comm
Module Name:src
Committed By: uebayasi
Date: Sun Jan 31 09:20:31 UTC 2010
Modified Files:
src/sys/uvm: uvm_fault.c
Log Message:
uvm_fault_internal:
Move local variables around to isolate contexts. Note that remaining variables
are global in that function, and some hold s
Module Name:src
Committed By: uebayasi
Date: Sun Jan 31 07:47:29 UTC 2010
Modified Files:
src/sys/uvm: uvm_fault.c
Log Message:
Indent.
To generate a diff of this commit:
cvs rdiff -u -r1.135 -r1.136 src/sys/uvm/uvm_fault.c
Please note that diffs are not public domain;
Module Name:src
Committed By: uebayasi
Date: Sun Jan 31 07:46:03 UTC 2010
Modified Files:
src/sys/uvm: uvm_fault.c
Log Message:
uvm_fault_internal: In lower fault handling case, put another goto to clarify
that we don't care lower neighboring pages for the zero-fill object
Module Name:src
Committed By: uebayasi
Date: Sun Jan 31 07:37:24 UTC 2010
Modified Files:
src/sys/uvm: uvm_fault.c
Log Message:
uvm_fault_internal: Skip another long code segment (lower "neighbor" fault)
by a goto.
To generate a diff of this commit:
cvs rdiff -u -r1.133
Module Name:src
Committed By: uebayasi
Date: Sun Jan 31 07:32:35 UTC 2010
Modified Files:
src/sys/uvm: uvm_fault.c
Log Message:
uvm_fault_internal: Put a goto label "Case1" as well as "Case2". Clarify
that if the faulting page is shadowed, we don't care the lower layer at
> It is highly unobvious what happens now in the case where startva is
> modified after your calculation.
You're correct. I broke MADV_SEQUENTIAL case.
What I was really wrong is I made a const var (eoff) from !const var
(startva)...
Masao
Module Name:src
Committed By: uebayasi
Date: Sun Jan 31 01:40:13 UTC 2010
Modified Files:
src/sys/uvm: uvm_fault.c
Log Message:
Correct previous; fix a miscalculation of offset-into-entry in MADV_SEQUENTIAL
case. Pointed out by po...@.
To generate a diff of this commit:
Module Name:src
Committed By: uebayasi
Date: Sat Jan 30 15:13:25 UTC 2010
Modified Files:
src/sys/uvm: uvm_fault.c
Log Message:
Calculate the offset from vm_map_entry's start to vm_page array's start once.
To generate a diff of this commit:
cvs rdiff -u -r1.130 -r1.131 s
Module Name:src
Committed By: uebayasi
Date: Sat Jan 30 12:06:20 UTC 2010
Modified Files:
src/sys/miscfs/genfs: genfs_io.c
Log Message:
Reduce the diff between genfs_getpages() and genfs_do_io(). These should be
merged eventually.
To generate a diff of this commit:
cvs
Module Name:src
Committed By: uebayasi
Date: Sat Jan 30 05:19:20 UTC 2010
Modified Files:
src/sys/miscfs/genfs: genfs_io.c
Log Message:
Slightly more descriptive local variable names.
To generate a diff of this commit:
cvs rdiff -u -r1.34 -r1.35 src/sys/miscfs/genfs/genf
Module Name:src
Committed By: uebayasi
Date: Fri Jan 29 04:36:20 UTC 2010
Modified Files:
src/sys/miscfs/genfs: genfs_io.c
Log Message:
genfs_getpages: Narrow & clarify the context where I/O happens & vmobjlock is
dropped.
To generate a diff of this commit:
cvs rdiff -u
Module Name:src
Committed By: uebayasi
Date: Fri Jan 29 04:33:37 UTC 2010
Modified Files:
src/sys/miscfs/genfs: genfs_io.c
Log Message:
genfs_getpages: Redo previous with a better goto label.
To generate a diff of this commit:
cvs rdiff -u -r1.32 -r1.33 src/sys/miscfs/ge
rw_exit(&gp->g_glock);
314 if (pgs != pgs_onstack)
315 kmem_free(pgs, pgs_size);
316 goto startover;
317 }
Masao
--
Masao Uebayashi / Tombi Inc. / Tel: +81-90-9141-4635
Module Name:src
Committed By: uebayasi
Date: Thu Jan 28 14:25:17 UTC 2010
Modified Files:
src/sys/miscfs/genfs: genfs_io.c
Log Message:
Revert part which variable initializations within interleaved gotos.
again: if (...) goto err;
void *ptr = alloc();
if
Module Name:src
Committed By: uebayasi
Date: Thu Jan 28 13:43:53 UTC 2010
Modified Files:
src/sys/miscfs/genfs: genfs_io.c
Log Message:
genfs_getpages: More constification & localization.
To generate a diff of this commit:
cvs rdiff -u -r1.30 -r1.31 src/sys/miscfs/genfs/
Module Name:src
Committed By: uebayasi
Date: Thu Jan 28 08:20:00 UTC 2010
Modified Files:
src/sys/miscfs/genfs: genfs_io.c
Log Message:
genfs_getpages: Constify 2 variables, move one. No functional changes.
To generate a diff of this commit:
cvs rdiff -u -r1.29 -r1.30 s
Module Name:src
Committed By: uebayasi
Date: Thu Jan 28 08:02:12 UTC 2010
Modified Files:
src/sys/miscfs/genfs: genfs_io.c
Log Message:
genfs_getpages: Constify orignpages. Don't override its meaning by the value
re-calucated from GOP_SIZE(GOP_SIZE_MEM), but assign anothe
Module Name:src
Committed By: uebayasi
Date: Thu Jan 28 07:49:08 UTC 2010
Modified Files:
src/sys/miscfs/genfs: genfs_io.c
Log Message:
Unbreak modules build.
To generate a diff of this commit:
cvs rdiff -u -r1.27 -r1.28 src/sys/miscfs/genfs/genfs_io.c
Please note that
Module Name:src
Committed By: uebayasi
Date: Thu Jan 28 07:44:54 UTC 2010
Modified Files:
src/sys/miscfs/genfs: genfs_io.c
Log Message:
genfs_getpages: Constify & localize more variables.
To generate a diff of this commit:
cvs rdiff -u -r1.26 -r1.27 src/sys/miscfs/genfs/
Module Name:src
Committed By: uebayasi
Date: Thu Jan 28 07:38:32 UTC 2010
Modified Files:
src/sys/miscfs/genfs: genfs_io.c
Log Message:
genfs_getpages: Move local variable declarations that are used only for I/O
to where they're used. This helps to track what's going in t
Module Name:src
Committed By: uebayasi
Date: Thu Jan 28 07:26:25 UTC 2010
Modified Files:
src/sys/miscfs/genfs: genfs_io.c
Log Message:
genfs_getpages: Localize a few more variables.
To generate a diff of this commit:
cvs rdiff -u -r1.24 -r1.25 src/sys/miscfs/genfs/genfs
Module Name:src
Committed By: uebayasi
Date: Thu Jan 28 07:24:56 UTC 2010
Modified Files:
src/sys/miscfs/genfs: genfs_io.c
Log Message:
genfs_putpages: Localize a few variables. No functional changes.
To generate a diff of this commit:
cvs rdiff -u -r1.23 -r1.24 src/sys
Module Name:src
Committed By: uebayasi
Date: Wed Jan 27 15:53:06 UTC 2010
Modified Files:
src/sys/miscfs/genfs: genfs_io.c
Log Message:
Use genfs_node_*lock().
To generate a diff of this commit:
cvs rdiff -u -r1.22 -r1.23 src/sys/miscfs/genfs/genfs_io.c
Please note that
Module Name:src
Committed By: uebayasi
Date: Wed Jan 27 15:52:31 UTC 2010
Modified Files:
src/sys/miscfs/genfs: genfs_node.h genfs_vnops.c
Log Message:
Don't forget to tell the result of rw_tryenter().
To generate a diff of this commit:
cvs rdiff -u -r1.18 -r1.19 src/sys
Module Name:src
Committed By: uebayasi
Date: Wed Jan 27 15:34:08 UTC 2010
Modified Files:
src/sys/sys: vnode.h
Log Message:
Typo in comment.
To generate a diff of this commit:
cvs rdiff -u -r1.212 -r1.213 src/sys/sys/vnode.h
Please note that diffs are not public domain;
Module Name:src
Committed By: uebayasi
Date: Wed Jan 27 15:24:54 UTC 2010
Modified Files:
src/sys/miscfs/genfs: genfs_io.c
Log Message:
Constify some pointers in genfs_getpages() and genfs_do_putpages().
To generate a diff of this commit:
cvs rdiff -u -r1.21 -r1.22 src/s
Module Name:src
Committed By: uebayasi
Date: Wed Jan 27 15:18:40 UTC 2010
Modified Files:
src/sys/miscfs/genfs: genfs_node.h genfs_vnops.c
Log Message:
Add genfs_node_rdtrylock().
To generate a diff of this commit:
cvs rdiff -u -r1.17 -r1.18 src/sys/miscfs/genfs/genfs_no
Module Name:src
Committed By: uebayasi
Date: Wed Jan 27 03:56:33 UTC 2010
Modified Files:
src/sys/uvm: uvm_page.c
Log Message:
uvm_pageinsert, uvm_pageremove: Pass the uboj, to/from which a pg is
inserted/removed, as an argument, because looking up a back-reference from
pg
Module Name:src
Committed By: uebayasi
Date: Sun Jan 24 15:03:02 UTC 2010
Modified Files:
src/sys/uvm: uvm_fault.c
Log Message:
Clean up an internal flag usage. No functional changes.
To generate a diff of this commit:
cvs rdiff -u -r1.129 -r1.130 src/sys/uvm/uvm_fault.
Module Name:src
Committed By: uebayasi
Date: Wed Jan 20 13:50:27 UTC 2010
Modified Files:
src/usr.sbin/mtree: mtree.8
Log Message:
Document -t (modify mtime). Bump date.
To generate a diff of this commit:
cvs rdiff -u -r1.51 -r1.52 src/usr.sbin/mtree/mtree.8
Please not
]) != NULL && dv->dv_del_gen != 0)
> dv = NULL;
> config_alldevs_unlock(s);
> + config_dump_garbage(&garbage);
>
> return dv;
> }
I wonder why this part was needed.
Masao
--
Masao Uebayashi / Tombi Inc. / Tel: +81-90-9141-4635
Module Name:src
Committed By: uebayasi
Date: Tue Jan 12 08:41:16 UTC 2010
Modified Files:
src/sys/dev/sdmmc: sdhc.c
Log Message:
According to SD Host Controller Simplified Specification Version 2.00, 2.2.10.
Host Control Register (Offset 028h), the "Data Transfer Width" bi
You can also conditionalize code by using CSHLIBFLAGS. FYI.
Masao
--
Masao Uebayashi / Tombi Inc. / Tel: +81-90-9141-4635
Module Name:src
Committed By: uebayasi
Date: Mon Jan 4 16:01:43 UTC 2010
Modified Files:
src/sys/kern: subr_kmem.c
Log Message:
Use CTASSERT() for constant only assertions.
To generate a diff of this commit:
cvs rdiff -u -r1.30 -r1.31 src/sys/kern/subr_kmem.c
Please no
Module Name:src
Committed By: uebayasi
Date: Sun Jan 3 04:25:16 UTC 2010
Modified Files:
src/sys/arch/arm/arm: cpufunc_asm_arm10.S cpufunc_asm_arm11.S
cpufunc_asm_arm67.S cpufunc_asm_arm7tdmi.S cpufunc_asm_arm8.S
cpufunc_asm_arm9.S cpufunc_asm_sa1.S
Module Name:src
Committed By: uebayasi
Date: Fri Jan 1 02:32:29 UTC 2010
Modified Files:
src/sys/arch/arm/arm32: pmap.c
Log Message:
Sprinkle assertions after calling pmap_get_l2_bucket().
To generate a diff of this commit:
cvs rdiff -u -r1.209 -r1.210 src/sys/arch/arm/
Module Name:src
Committed By: uebayasi
Date: Thu Dec 31 18:34:56 UTC 2009
Modified Files:
src/sys/arch/arm/arm32: pmap.c
Log Message:
Use pmap_is_current() where appropriate. No functional changes.
To generate a diff of this commit:
cvs rdiff -u -r1.208 -r1.209 src/sys/
Module Name:src
Committed By: uebayasi
Date: Thu Dec 31 16:00:53 UTC 2009
Modified Files:
src/sys/arch/arm/arm32: pmap.c
Log Message:
pmap_page_remove(): remove an unused local variable; no functional changes.
To generate a diff of this commit:
cvs rdiff -u -r1.207 -r1.2
Module Name:src
Committed By: uebayasi
Date: Thu Dec 31 02:36:14 UTC 2009
Modified Files:
src/sys/arch/arm/arm32: pmap.c
Log Message:
Correct assertions for PMAP_CACHE_VIPT code; if page coloring is disabled
(arm_cache_prefer_mask == 0), pvh_attrs has never PVF_COLORED, so
I should have done this. Thanks.
uebay...@iphone
On 2009/12/16, at 15:24, Matt Thomas wrote:
Module Name:src
Committed By:matt
Date:Wed Dec 16 06:24:33 UTC 2009
Modified Files:
src/gnu/dist/gdb6/sim/mips [matt-nb5-mips64]: Makefile.in
Log Message:
wrap cd ../igen && ${M
ls/gdb/Makefile 15 Dec 2009 08:55:04 -
@@ -11,7 +11,6 @@
MAKE_ARGS= MACHINE= MAKEINFO=${TOOL_MAKEINFO:Q}
-.NOTPARALLEL: # XXX otherwise fails with itable.c / interp.c build
ALL_TARGET=all-gdb
INSTALL_TARGET=install-gdb
--
Masao Uebayashi / Tombi Inc. / Tel: +81-90-9141-4635
cvsroot/src/tools/gdb/Makefile,v
retrieving revision 1.13
diff -u -r1.13 Makefile
--- tools/gdb/Makefile 14 Dec 2009 14:13:16 - 1.13
+++ tools/gdb/Makefile 15 Dec 2009 07:33:37 -
@@ -11,7 +11,6 @@
MAKE_ARGS= MACHINE= MAKEINFO=${TOOL_MAKEINFO:Q}
-.NOTPARALLEL: # XXX otherwi
GEN_INSN) $(IGEN_DC) ../igen/igen $(IGEN_INCLUDE)
> - cd ../igen && $(MAKE)
> + (cd ../igen && $(MAKE))
> ../igen/igen \
> $(IGEN_TRACE) \
> -I $(srcdir) \
This works!
Masao
--
Masao Uebayashi / Tombi Inc. / Tel: +81-90-9141-4635
arch path to gnu/dist/gdb6/gdb/f-exp.c is missing
Masao
--
Masao Uebayashi / Tombi Inc. / Tel: +81-90-9141-4635
rp.c build
> ALL_TARGET= all-gdb
> INSTALL_TARGET= install-gdb
Thanks, but .NOTPARALEL doesn't seem to work for me. See attachment 1.
I made it work using Makefile.gmakehost too. I don't know what those
NetBSD_DISABLED_* mean.
Masao
--
Masao Uebayashi / Tombi Inc. / Te
1
--
Masao Uebayashi / Tombi Inc. / Tel: +81-90-9141-4635
> > Log Message:
> > We don't declare variables in for () statement.
>
> The kernel is a C99 environment which makes that legal. Limiting the scope
> of variables is always a good thing.
I agree that it's a good thing. Its build failed in modules.
Masao
--
Mas
> Log Message:
> NetBSD/mips64e[bl] userland is default to N32 ABI. It needs /usr/lib/o32
> for O32 ABI and /usr/lib/64 for N32 ABI.
^^^
Of course I meant N64.
Masao
--
Masao Uebayashi / Tombi Inc. / Tel: +81-90-9141-4635
Yes:
% find * -name Makefile | xargs grep -l GENCMD
usr.bin/ktruss/Makefile
% find * -name '*.mk' | xargs grep -l GENCMD
share/mk/bsd.own.mk
Masao
--
Masao Uebayashi / Tombi Inc. / Tel: +81-90-9141-4635
ten to look an idiom,
like:
# multiple outputs
.ORDER: nodes.h nodes.c
nodes.c nodes.h: mknodes.sh nodetypes nodes.c.pat
${_MKTARGET_CREATE}
${SCRIPT_ENV} ${HOST_SH} ${.ALLSRC} ${.OBJDIR}
So that the code fragment will propagate together.
n makefile. I don't think it's really complex.
It's just redundant. :)
> correcting the scripts that generate files to use unique filenames.
Actually I like this more.
Masao
--
Masao Uebayashi / Tombi Inc. / Tel: +81-90-9141-4635
You'll realize what $GENCMD does is a solution, not a work-around.
Masao
--
Masao Uebayashi / Tombi Inc. / Tel: +81-90-9141-4635
% nbmake-XXX
Masao
--
Masao Uebayashi / Tombi Inc. / Tel: +81-90-9141-4635
just before linked) is kind of a static library.
Masao
--
Masao Uebayashi / Tombi Inc. / Tel: +81-90-9141-4635
The extra quotes here look wrong. ${VAR:Q} should do the correct
> amount of quoting. If you need two levels of quoting for some
> reason that I don't see, then use ${VAR:Q:Q}, not "${VAR:Q}".
:Q:Q seems to work, thanks. The reason is ${GENCMD} uses eval. Unlike
${MAKEDIRTAR
BTW, creating those in ${.OBJDIR} is a little mess because those scripts
are called from within phony targets where ${.OBJDIR} is not set.
Masao
--
Masao Uebayashi / Tombi Inc. / Tel: +81-90-9141-4635
g000805.html
Reading people's opinions, I changed my mind & looked closer to those rules.
Masao
--
Masao Uebayashi / Tombi Inc. / Tel: +81-90-9141-4635
ve make configuration variables in ${DESTDIR} so that you can
reproducible the resulting ${DESTDIR} from the recorded configuration. This
is analogue to kernel config embedded in kernel itself. How do you think?
Masao
--
Masao Uebayashi / Tombi Inc. / Tel: +81-90-9141-4635
; }
ie having no real dependency against arith.c
I showd my idea to make commands to generate only one output. I got no
response. I took that as no one has interest about this. GENCMD is just
one way to achieve that. You can do it in $YOUR_OWN_WAY but the idea is
that.
Masao
--
Masao
;t need to use at all. it also uses "cp"
> instead of "mv".
Could you give me a test case this fails? I'm all for better solution.
Masao
--
Masao Uebayashi / Tombi Inc. / Tel: +81-90-9141-4635
entry from the
> "mi" to the "module.mi" file set.
>
> Fixes the build for evbppc.
Thanks again.
> Index: src/etc/Makefile
Anothor source of heada^Wpleasure!
Masao
--
Masao Uebayashi / Tombi Inc. / Tel: +81-90-9141-4635
> Log Message:
> Prefix mkvars.mk with ${rundir}/, so that the scripts from this
> dir using sets.subr can be run from another directory, as is done
> e.g. during "make release" via the mksums script.
Thanks!
Masao
s.
Masao
--
Masao Uebayashi / Tombi Inc. / Tel: +81-90-9141-4635
rith_h.h:
tmp_arith_h.h: tmp_arith_h.y
tmp_arith_h.y: arith.y
cp arith.y tmp_arith_h.y
I can think of no problem of this. At the cost of redundancy (run command
twice + some tmp files) you get accurate dependency tree.
Masao
--
Masao Uebayashi / Tombi Inc. / Tel: +81-90-9141-4635
> Log Message:
> Switch to new style only if is explicitly set.
^^
I meant to mention ${MKNATIVE_LIBGCC_NEW} here.
Masao
--
Masao Uebayashi / Tombi Inc. / Tel: +81-90-9141-4635
e _ prefix ones are
only used internally in bsd.{prog,lib}.mk. I'll fix the cvs log. Thanks.
Masao
--
Masao Uebayashi / Tombi Inc. / Tel: +81-90-9141-4635
o bar
SRCS.foo=foo.c common.c
SRCS.bar=bar.c common.c
CPPFLAGS.foo=-Dfoo
CPPFLAGS.bar=-Dbar
Think how common.o will be built...
Masao
--
Masao Uebayashi / Tombi Inc. / Tel: +81-90-9141-4635
handle them.
> For example, Bash 3.1, ksh88, pdksh 5.2.14, and Zsh 4.2.6 all
> mishandle the following valid command:
>
> echo $(case x in x) echo hello;; esac)
Thanks. I've never known this.
I wonder why we don't have ${TOOL_SH}.
Masao
--
Masao Uebayashi / Tombi Inc. / Tel: +81-90-9141-4635
Is my version incompatible to POSIX? Or do we go to "write really
portable shell script" load like Autoconf, not POSIX shell? [1]
Masao
[1] http://www.gnu.org/software/hello/manual/autoconf/Portable-Shell.html
--
Masao Uebayashi / Tombi Inc. / Tel: +81-90-9141-4635
ext)lists="${lists} ${extlists}" ;;
> + esac
> + done
> + IFS="${save_IFS}"
> ;;
> # backward compat
> b)
Thanks, this looks better.
Could you elaborate how the old version failed on Mac OS X?
Masao
--
Masao Uebayashi / Tombi Inc. / Tel: +81-90-9141-4635
ZFS}
Am I missing anything else?
Masao
--
Masao Uebayashi / Tombi Inc. / Tel: +81-90-9141-4635
.
-#
-.if ${MACHINE} == "amd64" || ${MACHINE} == "i386"
-MKZFS?=yes
-_MKVARS.yes+= MKZFS
-.else
-MKZFS?=no
-_MKVARS.no+= MKZFS
-.endif
-
-#
# Force some options off if their dependencies are off.
#
--
Masao Uebayashi / Tombi Inc. / Tel: +81-90-9141-4635
I spoke too early. I still see problems. I'll post this to port-arm@ after
sorting out things.
Masao
--
Masao Uebayashi / Tombi Inc. / Tel: +81-90-9141-4635
tt-armv6 merge.
This seems to fix odd assertion failures seen on i.MX3x I have been seeing.
I'll test more with this and report later.
Huge thanks go for all of you involved!!
Masao
--
Masao Uebayashi / Tombi Inc. / Tel: +81-90-9141-4635
> Because the current PF sources (=version 4.2) is (still) in those
> directories as far as I can tell. The only reason for this import is to
> make upgrades easier, see my mail to current-users@ yesterday.
I think doing repo-copy (from dist/ to external/) would help here?
Masao
m68000 for the sticky, mask, and round settings.
Could you consider to improve the quality of commit messages & always explain
the reason of the changes? :)
Masao
--
Masao Uebayashi / Tombi Inc. / Tel: +81-90-9141-4635
ermined when cgd_ioctl_set()
is called. cgd_ioctl_set() should be thread-context.
Masao
--
Masao Uebayashi / Tombi Inc. / Tel: +81-90-9141-4635
> Log Message:
> In pmf(9), improve the implementation of device self-suspension
> and make suspension by self, by drvctl(8), and by ACPI system sleep
> play nice together. Start solidifying some temporary API changes.
:
Don't you need kernel version bump for this?
Masao
> Log Message:
> CP0 ECC and CACHE_ERR "not implemented" on RMI XLS, so avoid accessing them
> @@ -508,8 +508,10 @@
>
> if (MIPS_HAS_LLSC) {
> if (CPUISMIPS64) {
> +#if !defined(MIPS64_XLS) /* CP0 reg #17
> "reserved" */
>
> O64 kernel? why should we worry about O64?
For "completeness". :)
Masao
> @@ -876,10 +876,17 @@
> moves2, t2 # stash most of temporary regs
> REG_S t3, FRAME_T3(k1)# syscall saved gp for fork
> mfc0a1, MIPS_COP_0_STATUS # 2nd arg is STATUS
> +#if defined(__mips_n32) || defined(__mips_n64)
>
Late reply. :)
I just read if_vlan.c and found that part. My complaint was that readers
can't know the intention of (IFCAP_CSUM_IPv4_Tx | IFCAP_CSUM_IPv4_Rx |
IFCAP_CSUM_TCPv4_Tx | IFCAP_CSUM_TCPv4_Rx | IFCAP_CSUM_UDPv4_Tx |
IFCAP_CSUM_UDPv4_Rx | IFCAP_CSUM_TCPv6_Tx | IFCAP_CSUM_TCPv6_Rx |
IFCAP_
> I don't like such useless intermediate functions. It doesn't make code
> easier to read.
It is a useful intermediate function. Code flow becomes clearer. Or do you
think longer function is easier to read, like tcp_output()? :)
Masao
I was reviewing this change. :)
On Sat, Apr 04, 2009 at 10:00:23AM +, Manuel Bouyer wrote:
> Module Name: src
> Committed By: bouyer
> Date: Sat Apr 4 10:00:23 UTC 2009
>
> Modified Files:
> src/sys/net: if_bridge.c if_bridgevar.h
>
> Log Message:
> Fix for if_start() and pfi
Sorry for delayed review.
> @@ -410,6 +419,10 @@
> /* Tear down the routing table. */
> bridge_rtable_fini(sc);
>
> +
> +
> + softint_disestablish(sc->sc_softintr);
> +
> free(sc, M_DEVBUF);
>
> return (0);
Please trim these blank lines.
> @@ -1305,124 +1318,139 @
> Log Message:
> Also inherit the parent's TCP segmentation offload capability.
> Note the vlan interface does not see updates to the parents capabilities
> so if, for example, TSO is on in both, then turned off in the parent it
> will remain on in the vlan interface.
And now, why not IFCAP_TSOv6?
301 - 388 of 388 matches
Mail list logo
