Re: CVS commit: src

2014-04-21 Thread Maxime Villard
Le 21/04/2014 01:46, Taylor R Campbell a écrit : From: Maxime Villard m...@netbsd.org Date: Wed, 16 Apr 2014 18:55:20 + An (un)privileged user can easily make the kernel dereference a NULL pointer. The kernel allows 'data' to be NULL; it's the fs's responsibility

Re: CVS commit: src

2014-04-21 Thread Maxime Villard
Le 21/04/2014 16:29, Taylor R Campbell a écrit : Date: Mon, 21 Apr 2014 08:20:22 +0200 From: Maxime Villard m...@m00nbsd.net Le 21/04/2014 01:46, Taylor R Campbell a écrit : In most cases of the changes you made, there is already a test for the length of the data buffer

Re: CVS commit: src/sys/kern

2014-07-03 Thread Maxime Villard
Maxime Villard m...@netbsd.org wrote: |Module Name: src |Committed By: maxv |Date: Tue Jun 24 07:28:23 UTC 2014 | |Modified Files: | src/sys/kern: subr_kmem.c | |Log Message: |KMEM_REDZONE+KMEM_POISON is supposed to detect buffer overflows. But it only |poisons memory

Re: CVS commit: src/sys/kern

2014-07-03 Thread Maxime Villard
Le 03/07/2014 16:47, Steffen Nurpmeso a écrit : Maxime Villard m...@m00nbsd.net wrote: |Le 03/07/2014 15:59, Steffen Nurpmeso a écrit : | | Maxime Villard m...@m00nbsd.net wrote: ||That was in my TODO list, it's fixed in r1.59. | | Oh please, did you hear me complain

Re: CVS commit: src/sys/kern

2014-07-25 Thread Maxime Villard
Le 25/07/2014 10:25, David A. Holland a écrit : Module Name: src Committed By: dholland Date: Fri Jul 25 08:25:47 UTC 2014 Modified Files: src/sys/kern: syscalls.master vfs_syscalls.c Log Message: Add fdiscard and posix_fallocate syscalls. To generate a diff of

Re: CVS commit: src/sys/kern

2014-07-25 Thread Maxime Villard
Le 25/07/2014 16:47, David Holland a écrit : On Fri, Jul 25, 2014 at 11:21:47AM +0200, Maxime Villard wrote: Log Message: Add fdiscard and posix_fallocate syscalls. I think 'error' instead of 'result' is better; it makes clear that it's an error code, and it's consistent

Re: CVS commit: src/sys/dev/dm

2014-08-19 Thread Maxime Villard
Le 18/08/2014 19:16, Alistair G. Crooks a écrit : Module Name: src Committed By: agc Date: Mon Aug 18 17:16:42 UTC 2014 Modified Files: src/sys/dev/dm: dm_target_stripe.c Log Message: Avoid a memory leak - from maxv To generate a diff of this commit: cvs rdiff -u

Re: CVS commit: src/sys/dev/dm

2014-08-19 Thread Maxime Villard
Le 19/08/2014 10:31, John Nemeth a écrit : On Aug 19, 6:50am, Maxime Villard wrote: } Le 18/08/2014 19:16, Alistair G. Crooks a écrit : } } Module Name: src } Committed By: agc } Date: Mon Aug 18 17:16:42 UTC 2014 } } Modified Files: }src/sys/dev/dm

Re: CVS commit: src/sys/arch/xen/xen

2014-09-27 Thread Maxime Villard
Le 21/09/2014 20:22, Christos Zoulas a écrit : On Sep 21, 7:57pm, m...@m00nbsd.net (Maxime Villard) wrote: -- Subject: Re: CVS commit: src/sys/arch/xen/xen | Did you test this change? Verily I'm not sure it's a proper bug, but I | kept it in my list so that someone (bouyer@?) could investigate

Re: CVS commit: src/sys/dev/pci

2014-09-27 Thread Maxime Villard
Module Name:src Committed By: christos Date: Sun Sep 21 17:11:07 UTC 2014 Modified Files: src/sys/dev/pci: twa.c Log Message: fix memset size inconsistency This fix is wrong. - memset(p, sizeof(struct twa_param_9k *), 10); + memset(p, 0, sizeof(*p)); p

Re: CVS commit: src/sys/arch/xen/xen

2014-10-03 Thread Maxime Villard
Le 27/09/2014 17:51, Christos Zoulas a écrit : On Sep 27, 8:36am, m...@m00nbsd.net (Maxime Villard) wrote: -- Subject: Re: CVS commit: src/sys/arch/xen/xen | One however returns an error without freeing: | | if (newstart != start) { | printf(uvm_map didn't give us back our

Re: CVS commit: src/sys/arch/xen/xen

2014-10-10 Thread Maxime Villard
Le 03/10/2014 22:56, Christos Zoulas a écrit : Module Name:src Committed By: christos Date: Fri Oct 3 20:56:24 UTC 2014 Modified Files: src/sys/arch/xen/xen: privcmd.c Log Message: correct error paths; still need to verify that the didn't give us back... case is

Re: CVS commit: src/sys/arch/xen/xen

2014-10-17 Thread Maxime Villard
Le 10/10/2014 18:42, Maxime Villard a écrit : Le 03/10/2014 22:56, Christos Zoulas a écrit : Module Name:src Committed By:christos Date:Fri Oct 3 20:56:24 UTC 2014 Modified Files: src/sys/arch/xen/xen: privcmd.c Log Message: correct error paths; still need to verify

Re: CVS commit: src/sys/fs/udf

2014-11-10 Thread Maxime Villard
Le 10/11/2014 20:44, Jeff Rizzo a écrit : Module Name: src Committed By: riz Date: Mon Nov 10 19:44:08 UTC 2014 Modified Files: src/sys/fs/udf: udf_rename.c Log Message: Revert previous, it is actually needed. (builds are failing) Arf yes, UDF is not enabled on amd64,

Re: CVS commit: src/sys/ufs/ffs

2015-02-15 Thread Maxime Villard
Le 14/02/2015 20:21, David Holland a écrit : On Sat, Feb 14, 2015 at 08:07:39AM +, Maxime Villard wrote: Modified Files: src/sys/ufs/ffs: ffs_appleufs.c Log Message: ffs_appleufs_validate(): - remove superfluous printfs - ensure ul_namelen!=0, otherwise the kernel

Re: CVS commit: src/sys/ufs/ext2fs

2015-02-23 Thread Maxime Villard
Le 23/02/2015 14:51, Ryota Ozaki a écrit : Hi, On Sun, Feb 22, 2015 at 11:55 PM, Maxime Villard m...@netbsd.org wrote: Module Name:src Committed By: maxv Date: Sun Feb 22 14:55:23 UTC 2015 Modified Files: src/sys/ufs/ext2fs: ext2fs_vfsops.c Log Message: Merge

Re: CVS commit: src/sys/dev/bluetooth

2015-04-30 Thread Maxime Villard
What about the M_PREPEND()? Le 29/04/2015 23:07, Iain Hibbert a écrit : On Wed, 29 Apr 2015, Christos Zoulas wrote: On Apr 29, 4:27pm, m...@m00nbsd.net (Maxime Villard) wrote: -- Subject: Re: CVS commit: src/sys/dev/bluetooth | You didn't test this change, nor did you test the five other

Re: CVS commit: src/sys/dev/bluetooth

2015-04-29 Thread Maxime Villard
Le 27/04/2015 19:36, Christos Zoulas a écrit : Module Name: src Committed By: christos Date: Mon Apr 27 17:36:41 UTC 2015 Modified Files: src/sys/dev/bluetooth: bcsp.c Log Message: free mbuf on failure (Brainy) To generate a diff of this commit: cvs rdiff -u -r1.25

Re: CVS commit: src/sys/dev/bluetooth

2015-05-01 Thread Maxime Villard
Le 30/04/2015 16:07, Christos Zoulas a écrit : On Apr 30, 8:57am, m...@m00nbsd.net (Maxime Villard) wrote: -- Subject: Re: CVS commit: src/sys/dev/bluetooth How about helping investigate what's wrong with: /* Check the size of cylinder groups */ fs_cgsize = ffs_fragroundup

Re: CVS commit: src/sys/dev/bluetooth

2015-05-08 Thread Maxime Villard
Le 30/04/2015 18:01, Christos Zoulas a écrit : Module Name: src Committed By: christos Date: Thu Apr 30 16:01:52 UTC 2015 Modified Files: src/sys/dev/bluetooth: bcsp.c Log Message: Fix more memory leaks by changing the transmit routines to always free the mbuf to send.

Re: CVS commit: src/sys

2015-08-02 Thread Maxime Villard
Le 31/07/2015 20:24, Martin Husemann a écrit : On Fri, Jul 31, 2015 at 01:09:37PM +0200, Maxime Villard wrote: I don't know how to do that, but you need to fix it this way: - remove the security.pax.mprotect.global instruction in paxinit() Why is that? Because changing

Re: CVS commit: src/sys

2015-07-31 Thread Maxime Villard
Le 31/07/2015 12:32, Ryota Ozaki a écrit : On Fri, Jul 31, 2015 at 12:28 AM, Maxime Villard m...@netbsd.org wrote: Module Name:src Committed By: maxv Date: Thu Jul 30 15:28:18 UTC 2015 Modified Files: src/sys/kern: exec_elf.c kern_pax.c src/sys/sys

Re: CVS commit: src/sys/kern

2015-08-07 Thread Maxime Villard
Le 07/08/2015 11:38, Christos Zoulas a écrit : In article 21928.1438883...@splode.eterna.com.au, matthew green m...@eterna.com.au wrote: ya - this might actually break some linux binary packages, where there is a well-defined interface to executing a library. i think this part should be

Re: CVS commit: src/sys

2015-07-27 Thread Maxime Villard
Le 27/07/2015 20:28, matthew green a écrit : Maxime Villard writes: Module Name: src Committed By:maxv Date:Mon Jul 27 09:24:28 UTC 2015 Modified Files: src/sys/kern: subr_kmem.c src/sys/uvm: files.uvm Removed Files: src/sys/uvm: uvm_kmguard.c

Re: CVS commit: src/sys/arch/amd64/amd64

2016-05-29 Thread Maxime Villard
Le 29/05/2016 à 11:04, Maxime Villard a écrit : Module Name:src Committed By: maxv Date: Sun May 29 09:04:20 UTC 2016 Modified Files: src/sys/arch/amd64/amd64: locore.S Log Message: Revert rev1.94. It apparently raises a page fault from SMEP. I need to investigate

Re: CVS commit: src/sys/arch

2016-05-13 Thread Maxime Villard
Le 13/05/2016 13:18, Martin Husemann a écrit : On Fri, May 13, 2016 at 07:50:20AM +0200, Maxime Villard wrote: It's all explained in the commit messages that came afterwards. Sorry, but it is still completely unclear to me what the overall benefit is. I've explained it on tech-kern a hour

Re: CVS commit: src/sys/arch

2016-05-13 Thread Maxime Villard
Le 12/05/2016 15:31, Joerg Sonnenberger a écrit : On Thu, May 12, 2016 at 06:45:17AM +, Maxime Villard wrote: Module Name:src Committed By: maxv Date: Thu May 12 06:45:16 UTC 2016 Modified Files: src/sys/arch/amd64/amd64: locore.S machdep.c src/sys/arch

Re: CVS commit: src/sys/arch/amd64/amd64

2016-05-08 Thread Maxime Villard
Le 07/05/2016 23:13, matthew green a écrit : Joerg Sonnenberger writes: On Sat, May 07, 2016 at 11:49:21AM +, Maxime Villard wrote: Module Name:src Committed By: maxv Date: Sat May 7 11:49:21 UTC 2016 Modified Files: src/sys/arch/amd64/amd64: locore.S Log Message

Re: CVS commit: src/sys/uvm

2016-07-21 Thread Maxime Villard
Le 20/07/2016 à 20:07, matthew green a écrit : "Maxime Villard" writes: Module Name:src Committed By: maxv Date: Wed Jul 20 12:38:44 UTC 2016 Modified Files: src/sys/uvm: uvm_extern.h uvm_km.c Log Message: Introduce uvm_km_protect. can you bring this up on

Re: CVS commit: src/sys/arch/x86/x86

2016-07-21 Thread Maxime Villard
Le 20/07/2016 à 07:07, Takashi YAMAMOTO a écrit : On Wed, Jul 20, 2016 at 3:54 AM, Maxime Villard <m...@netbsd.org <mailto:m...@netbsd.org>> wrote: Module Name:src Committed By: maxv Date: Tue Jul 19 18:54:45 UTC 2016 Modified Files:

Re: CVS commit: src/sys/arch

2016-08-05 Thread Maxime Villard
Le 04/08/2016 à 21:09, Joerg Sonnenberger a écrit : On Sun, Jul 24, 2016 at 02:09:22PM +, Maxime Villard wrote: Fix this by properly saving and restoring the EFER MSR. It's a little tricky since the wakeup code uses %edx, but rdmsr overwrites it. We just save it in %esi. Use push/pop

Re: CVS commit: src/sys

2016-08-07 Thread Maxime Villard
Le 06/08/2016 à 17:13, Maxime Villard a écrit : Module Name:src Committed By: maxv Date: Sat Aug 6 15:13:14 UTC 2016 Modified Files: src/sys/compat/linux32/common: linux32_exec_elf32.c src/sys/compat/netbsd32: netbsd32_exec_aout.c netbsd32_exec_elf32.c

Re: CVS commit: src/sys/arch/xen/x86

2016-08-09 Thread Maxime Villard
Le 08/08/2016 à 04:27, Cherry G. Mathew a écrit : On 2 August 2016 at 19:51, Maxime Villard <m...@netbsd.org <mailto:m...@netbsd.org>> wrote: Module Name:src Committed By: maxv Date: Tue Aug 2 14:21:53 UTC 2016 Modified Files: src/sys/

Re: CVS commit: src/sys/arch/x86/x86

2016-07-02 Thread Maxime Villard
Le 01/07/2016 à 16:24, matthew green a écrit : Log Message: Surprisingly enough, the kernel expects the CPU to support large pages when creating the direct map on amd64. Therefore, the amd64 CPUs that do not support large pages basically don't work on NetBSD. It looks like it has always been

Re: CVS commit: src/sys/arch/x86/x86

2016-07-02 Thread Maxime Villard
Le 01/07/2016 à 16:22, matthew green a écrit : We use only one L4 slot for the direct map, which means that we cannot map more than 512GB. Panic properly if this limit is reached. thanks for making the failure mode clear. it would be nice to remove this limitation, and support upto at least

Re: CVS commit: src/sys/kern

2016-09-23 Thread Maxime Villard
Le 21/09/2016 à 07:58, matthew green a écrit : "Maxime Villard" writes: Module Name:src Committed By: maxv Date: Sat Sep 17 12:00:35 UTC 2016 Modified Files: src/sys/kern: kern_proc.c Log Message: Use VM_MAXUSER_ADDRESS for proc0, not VM_MAX_ADDRESS. It nor

Re: CVS commit: src/sys/arch

2016-11-25 Thread Maxime Villard
Le 24/11/2016 à 14:28, Masanobu SAITOH a écrit : Hi! On 2016/11/19 18:22, Maxime Villard wrote: Module Name:src Committed By: maxv Date: Sat Nov 19 09:22:04 UTC 2016 Modified Files: src/sys/arch/amd64/include: vmparam.h src/sys/arch/i386/include: vmparam.h Log

Re: CVS commit: src/sys/arch

2016-11-27 Thread Maxime Villard
Le 26/11/2016 à 07:43, David Holland a écrit : On Thu, Nov 24, 2016 at 10:28:56PM +0900, Masanobu SAITOH wrote: > > Put a one-page redzone between userland and the PTE space on amd64 and > > i386. > > > > The PTE space is a critical region that maps the page tree, and bugs have > > been

Re: CVS commit: src/sys/arch

2016-11-27 Thread Maxime Villard
Le 27/11/2016 à 15:22, Joerg Sonnenberger a écrit : On Sun, Nov 27, 2016 at 12:21:48PM +0100, Maxime Villard wrote: Le 26/11/2016 à 07:43, David Holland a écrit : On Thu, Nov 24, 2016 at 10:28:56PM +0900, Masanobu SAITOH wrote: > > Put a one-page redzone between userland and the PTE

Re: CVS commit: src/sys/arch

2016-12-11 Thread Maxime Villard
Le 11/12/2016 à 17:08, Maxime Villard a écrit : > Le 11/12/2016 à 16:37, Martin Husemann a écrit : >> On Sun, Dec 11, 2016 at 08:31:53AM +0000, Maxime Villard wrote: >>> Module Name:src >>> Committed By:maxv >>> Date:Sun Dec 11 08:31:53 UTC 2016

Re: CVS commit: src/sys/arch

2016-12-20 Thread Maxime Villard
Le 20/12/2016 à 15:03, Maxime Villard a écrit : > Module Name: src > Committed By: maxv > Date: Tue Dec 20 14:03:15 UTC 2016 > > Modified Files: > src/sys/arch/amd64/amd64: machdep.c > src/sys/arch/i386/i386: machdep.c > src/sys/arch/x86/x

Re: CVS commit: src/sys/arch/amd64/amd64

2017-03-25 Thread Maxime Villard
e 24/03/2017 à 21:32, co...@sdf.org a écrit : cool! I see in arch/i386/i386/locore.S that there is another call gate and there's: 1246 IDTVEC(osyscall) 1247 #ifndef XEN 1248 /* XXX we are in trouble! interrupts be off here. */ 1249 cli /* must be first

Re: CVS commit: src

2017-03-11 Thread Maxime Villard
Le 10/03/2017 à 19:01, Valery Ushakov a écrit : On Fri, Mar 10, 2017 at 13:09:11 +, Maxime Villard wrote: Module Name:src Committed By: maxv Date: Fri Mar 10 13:09:11 UTC 2017 Modified Files: src/sys/arch/i386/i386: pmc.c src/sys/arch/x86/include: sysarch.h

Re: CVS commit: src/sys/arch/amd64/conf

2017-08-04 Thread Maxime Villard
Le 03/08/2017 à 23:32, co...@sdf.org a écrit : On Fri, Jul 28, 2017 at 04:10:29PM +, Maxime Villard wrote: Module Name:src Committed By: maxv Date: Fri Jul 28 16:10:29 UTC 2017 Modified Files: src/sys/arch/amd64/conf: GENERIC XEN3_DOM0 XEN3_DOMU Log Message: After

Re: CVS commit: src/sys/arch

2017-08-04 Thread Maxime Villard
Le 03/08/2017 à 22:38, Joerg Sonnenberger a écrit : On Thu, Aug 03, 2017 at 04:20:45PM +0200, Maxime Villard wrote: I was more thinking in terms of a single page in kernel VA, not in user VA. That would side step most of the issues with dynamic LDT or having to patch up the default LDT

Re: CVS commit: src/sys/arch/amd64/conf

2017-08-04 Thread Maxime Villard
Le 04/08/2017 à 10:00, matthew green a écrit : Maxime Villard writes: Yes, I saw that too a few days later when moving the compat_freebsd files and trying to do a modload. I went "what the hell is this", but didn't do anything. What I could see, is that many of our compat options a

Re: CVS commit: src/sys/arch

2017-08-03 Thread Maxime Villard
Le 03/08/2017 à 13:06, Joerg Sonnenberger a écrit : On Sat, Jul 01, 2017 at 10:44:43AM +, Maxime Villard wrote: Module Name:src Committed By: maxv Date: Sat Jul 1 10:44:43 UTC 2017 Modified Files: src/sys/arch/amd64/amd64: locore.S src/sys/arch/i386/i386

Re: CVS commit: src/sys/arch/amd64/conf

2017-08-15 Thread Maxime Villard
Le 15/08/2017 à 14:50, Martin Husemann a écrit : On Tue, Aug 15, 2017 at 02:48:39PM +0200, Maxime Villard wrote: Why is it a bad idea re-implement the few compat_xx functions used in compat_linux? This would eliminate the dependency, and a single modload would suffice. Move them into a common

Re: CVS commit: src/sys/arch/amd64/conf

2017-08-15 Thread Maxime Villard
Le 04/08/2017 à 10:00, matthew green a écrit : the setup comes from before modules and it allows code sharing because the old 43 version matches other systems. so there's a single implementation of this code for a large number of consumers, and the name of it describes where it comes from. this

Re: CVS commit: src/lib/libarch/i386

2017-08-12 Thread Maxime Villard
Le 12/08/2017 à 23:07, matthew green a écrit : "Maxime Villard" writes: Module Name:src Committed By: maxv Date: Sat Aug 12 19:48:28 UTC 2017 Modified Files: src/lib/libarch/i386: shlib_version Log Message: Bump - removal of i386_vm86 and i386_pmc. i di

Re: CVS commit: src/distrib/sets/lists

2017-08-13 Thread Maxime Villard
Le 12/08/2017 à 23:46, Robert Elz a écrit : Module Name:src Committed By: kre Date: Sat Aug 12 21:46:01 UTC 2017 Modified Files: src/distrib/sets/lists/base: md.amd64 md.i386 src/distrib/sets/lists/debug: md.amd64 md.i386 Log Message: For libi386 major bump.

Re: CVS commit: src/sys/netinet

2017-07-29 Thread Maxime Villard
Le 29/07/2017 à 01:59, Robert Elz a écrit : Date:Fri, 28 Jul 2017 19:16:41 + From:"Maxime Villard" <m...@netbsd.org> Message-ID: <20170728191641.cf10cf...@cvs.netbsd.org> | Remove TCP_COMPAT_42. This feature is a workaround for a bug

Re: CVS commit: src/sys/arch/x86/x86

2017-08-07 Thread Maxime Villard
+0xd4 ozaki-r@n.o bisects and finds the following commit causes this panic. On 2017/08/01 3:54, Maxime Villard wrote: Module Name:src Committed By: maxv Date: Mon Jul 31 18:54:40 UTC 2017 Modified Files: src/sys/arch/x86/x86: intr.c Log

Re: CVS commit: src/sys/arch

2017-08-18 Thread Maxime Villard
Le 18/08/2017 à 20:52, matthew green a écrit : "Maxime Villard" writes: Module Name:src Committed By: maxv Date: Fri Aug 18 10:28:53 UTC 2017 Modified Files: src/sys/arch/amd64/conf: kern.ldscript src/sys/arch/i386/conf: kern.ldscript kern.ldscrip

Re: CVS commit: src/sys/arch

2017-08-18 Thread Maxime Villard
Le 18/08/2017 à 13:19, co...@sdf.org a écrit : On Fri, Aug 18, 2017 at 10:02:37AM +, Maxime Villard wrote: Remove unused and broken code. On amd64 we won't want int3 from kernel mode to be valid. - /* -* DTrace Function Boundary Trace (fbt) probes are triggered

Re: CVS commit: src/sys/arch

2017-08-18 Thread Maxime Villard
Le 18/08/2017 à 14:08, Maxime Villard a écrit : Le 18/08/2017 à 13:19, co...@sdf.org a écrit : On Fri, Aug 18, 2017 at 10:02:37AM +, Maxime Villard wrote: Remove unused and broken code. On amd64 we won't want int3 from kernel mode to be valid. - /* -* DTrace Function Boundary

Re: CVS commit: src/sys/arch

2017-08-18 Thread Maxime Villard
Le 18/08/2017 à 13:19, co...@sdf.org a écrit : On Fri, Aug 18, 2017 at 10:02:37AM +, Maxime Villard wrote: Remove unused and broken code. On amd64 we won't want int3 from kernel mode to be valid. - /* -* DTrace Function Boundary Trace (fbt) probes are triggered

Re: CVS commit: src/sys/arch

2017-06-14 Thread Maxime Villard
Le 14/06/2017 à 15:34, Joerg Sonnenberger a écrit : On Wed, Jun 14, 2017 at 12:27:24PM +, Maxime Villard wrote: Module Name:src Committed By: maxv Date: Wed Jun 14 12:27:24 UTC 2017 Modified Files: src/sys/arch/amd64/include: param.h src/sys/arch/i386

Re: CVS commit: src/sys

2017-06-15 Thread Maxime Villard
Le 14/06/2017 à 20:07, Manuel Bouyer a écrit : On Wed, Jun 14, 2017 at 05:48:41PM +, Maxime Villard wrote: Module Name:src Committed By: maxv Date: Wed Jun 14 17:48:41 UTC 2017 Modified Files: src/sys/arch/x86/x86: pmc.c src/sys/secmodel/suser

Re: CVS commit: src/sys

2017-06-15 Thread Maxime Villard
Le 15/06/2017 à 10:28, Manuel Bouyer a écrit : On Thu, Jun 15, 2017 at 10:11:21AM +0200, Maxime Villard wrote: There were several strong objections to our change in this thread: http://mail-index.netbsd.org/tech-kern/2017/03/28/msg021705.html Man, that's another thread. My commit is about

Re: CVS commit: src/sys

2017-06-15 Thread Maxime Villard
Le 15/06/2017 à 12:01, Manuel Bouyer a écrit : On Thu, Jun 15, 2017 at 11:14:27AM +0200, Maxime Villard wrote: I can't see how this improves the security. AFAIK on linux PMCs can be used without root. We don't do application tracking, contrary to linux. That is, we don't save/restore

Re: CVS commit: src/sys/arch

2017-06-15 Thread Maxime Villard
Le 15/06/2017 à 14:15, Joerg Sonnenberger a écrit : On Thu, Jun 15, 2017 at 07:29:22AM +0200, Maxime Villard wrote: Le 14/06/2017 à 15:34, Joerg Sonnenberger a écrit : On Wed, Jun 14, 2017 at 12:27:24PM +, Maxime Villard wrote: Module Name:src Committed By: maxv Date: Wed

Re: CVS commit: src/sys/arch/x86/x86

2017-10-03 Thread Maxime Villard
Le 03/10/2017 à 21:14, Joerg Sonnenberger a écrit : I'm not responding to this nonsensical thread anymore, everything got told months ago. The option is here, people don't need to give a damn about it unless they explicitly want to - which is still legitimate in some cases, including for kaslr,

Re: CVS commit: src/sys/arch

2017-09-10 Thread Maxime Villard
Le 06/09/2017 à 14:39, Manuel Bouyer a écrit : Module Name:src Committed By: bouyer Date: Wed Sep 6 12:39:18 UTC 2017 Modified Files: src/sys/arch/amd64/amd64: gdt.c src/sys/arch/i386/i386: gdt.c Log Message: The last GDT slots are reserved for Xen, so use

Re: CVS commit: src/sys/arch

2017-09-10 Thread Maxime Villard
Le 10/09/2017 à 13:30, Manuel Bouyer a écrit : On Sun, Sep 10, 2017 at 01:18:07PM +0200, Maxime Villard wrote: Le 06/09/2017 à 14:39, Manuel Bouyer a écrit : Module Name:src Committed By: bouyer Date: Wed Sep 6 12:39:18 UTC 2017 Modified Files: src/sys/arch/amd64

Re: CVS commit: src/sys

2017-10-01 Thread Maxime Villard
Le 30/09/2017 à 21:39, matthew green a écrit : "Maxime Villard" writes: Module Name:src Committed By: maxv Date: Fri Sep 29 17:08:00 UTC 2017 Modified Files: src/sys/compat/linux/common: linux_mod.c linux_sysctl.c linux_sysctl.h src/sys/kern: kern_e

Re: CVS commit: src/sys

2017-10-02 Thread Maxime Villard
Le 01/10/2017 à 13:38, Manuel Bouyer a écrit : On Sun, Oct 01, 2017 at 09:38:32AM +0200, Maxime Villard wrote: No. It is clear that none of the proposals in the recent threads has brought unanimous consensus, but this sysctl appears to be the least problematic solution. You can speculate

Re: CVS commit: src/sys

2017-10-02 Thread Maxime Villard
Le 02/10/2017 à 15:36, Martin Husemann a écrit : On Mon, Oct 02, 2017 at 03:16:14PM +0200, Maxime Villard wrote: Le 02/10/2017 à 14:47, Manuel Bouyer a écrit : On Mon, Oct 02, 2017 at 02:39:47PM +0200, Maxime Villard wrote: Actually I did suggest to make the default dependant on MODULAR

Re: CVS commit: src/sys

2017-10-02 Thread Maxime Villard
Le 02/10/2017 à 18:51, Manuel Bouyer a écrit : On Mon, Oct 02, 2017 at 06:11:57PM +0200, Maxime Villard wrote: so we remove COMPAT_LINUX from all architectures that do not support kernel modules? this doesn't make compat_linux "nearby" or "easy to use" anymore which arc

Re: CVS commit: src/sys

2017-10-02 Thread Maxime Villard
Le 02/10/2017 à 19:12, Manuel Bouyer a écrit : On Mon, Oct 02, 2017 at 07:05:20PM +0200, Maxime Villard wrote: Le 02/10/2017 à 18:51, Manuel Bouyer a écrit : On Mon, Oct 02, 2017 at 06:11:57PM +0200, Maxime Villard wrote: so we remove COMPAT_LINUX from all architectures that do not support

Re: CVS commit: src/sys/arch/x86/include

2017-09-29 Thread Maxime Villard
Le 29/09/2017 à 05:17, Ryota Ozaki a écrit : Module Name:src Committed By: ozaki-r Date: Fri Sep 29 03:17:18 UTC 2017 Modified Files: src/sys/arch/x86/include: pmap.h Log Message: Fix build sys/arch/x86/x86/cpu.c:920:20: error: 'pmap_largepages' undeclared (first use

Re: CVS commit: src/sys

2017-10-03 Thread Maxime Villard
Le 03/10/2017 à 15:52, Kamil Rytarowski a écrit : On 03.10.2017 15:35, Greg Troxel wrote: Then, I think the debate reduces to "should the checked-in GENERIC enable the emulation sysctl". I don't see a better answer to this question: yes, no or depends on the flavor of the kernel. My personal

Re: CVS commit: src/sys/arch/x86/x86

2017-10-03 Thread Maxime Villard
Le 03/10/2017 à 13:26, Joerg Sonnenberger a écrit : At the same time, it has interesting interactions with power management and the instruction queue. The queue is flushed by a serializing instruction executed right before, which is the recommended use case; the interaction with power

Re: CVS commit: src/sys

2017-10-03 Thread Maxime Villard
Le 03/10/2017 à 18:53, Christos Zoulas a écrit : In article <20171003162103.ga25...@britannica.bec.de>, Joerg Sonnenberger <jo...@bec.de> wrote: On Tue, Oct 03, 2017 at 04:03:49PM +0200, Maxime Villard wrote: Le 03/10/2017 à 15:52, Kamil Rytarowski a écrit : On 03.10.2017 15:35,

Re: CVS commit: src/sys/arch/x86/x86

2017-10-03 Thread Maxime Villard
Le 03/10/2017 à 22:47, Alexander Nasonov a écrit : Maxime Villard wrote: In case you didn't notice, this sysctl results directly from the answers I got, and is not my original plan (about which I changed my mind as a consequence of the conversation). So now tell me exactly which point I didn't

Re: CVS commit: src/sys/compat

2017-12-02 Thread Maxime Villard
Le 02/12/2017 à 02:27, Joerg Sonnenberger a écrit : On Fri, Dec 01, 2017 at 11:32:08PM +0100, Maxime Villard wrote: Le 01/12/2017 à 23:14, Joerg Sonnenberger a écrit : Module Name:src Committed By: joerg Date: Fri Dec 1 22:14:52 UTC 2017 Modified Files: src/sys/compat

Re: CVS commit: src/sys/arch

2017-12-04 Thread Maxime Villard
Le 03/12/2017 à 16:55, David Holland a écrit : On Sun, Dec 03, 2017 at 10:05:08AM +0100, Maxime Villard wrote: > Good, and apparently no one has noticed that some options don't compile. Are you saying Christos is lying about it working after reverting your commits? Why don't you r

Re: CVS commit: src/sys/arch

2017-12-04 Thread Maxime Villard
Le 04/12/2017 à 20:17, Christos Zoulas a écrit : In article <f6366cc7-4011-0b65-42bd-6814a9f31...@m00nbsd.net>, Maxime Villard <m...@m00nbsd.net> wrote: Le 03/12/2017 à 16:55, David Holland a écrit : On Sun, Dec 03, 2017 at 10:05:08AM +0100, Maxime Villard wrote: > Good,

Re: CVS commit: src/sys/compat/common

2017-12-16 Thread Maxime Villard
Le 16/12/2017 à 09:36, Paul Goyette a écrit : Sounds to me like this could/should be its own module compat_lib and other modules which require its functions can put compat_lib in their required-modules list so it can be auto-loaded. Yes, it should be something like that. Right now however I'm

Re: CVS commit: src/sys/compat/common

2017-12-17 Thread Maxime Villard
Le 17/12/2017 à 09:58, matthew green a écrit : "Maxime Villard" writes: Module Name:src Committed By: maxv Date: Sat Dec 16 08:31:36 UTC 2017 Modified Files: src/sys/compat/common: Makefile.inc Log Message: Build libcompat as an object, not as a library. W

Re: CVS commit: src/sys/arch

2017-11-14 Thread Maxime Villard
Le 14/11/2017 à 15:49, Maxime Villard a écrit : Le 14/11/2017 à 15:15, Joerg Sonnenberger a écrit : On Tue, Nov 14, 2017 at 03:06:00PM +0100, Maxime Villard wrote: Le 11/11/2017 à 10:10, Manuel Bouyer a écrit : Module Name:src Committed By:bouyer Date:Sat Nov 11 09:10:19 UTC

Re: CVS commit: src/sys/arch

2017-11-14 Thread Maxime Villard
Le 11/11/2017 à 10:10, Manuel Bouyer a écrit : Module Name:src Committed By: bouyer Date: Sat Nov 11 09:10:19 UTC 2017 Modified Files: src/sys/arch/x86/x86: cpu.c fpu.c identcpu.c src/sys/arch/xen/x86: cpu.c Log Message: Revert

Re: CVS commit: src/sys/arch

2017-11-14 Thread Maxime Villard
Le 14/11/2017 à 15:15, Joerg Sonnenberger a écrit : On Tue, Nov 14, 2017 at 03:06:00PM +0100, Maxime Villard wrote: Le 11/11/2017 à 10:10, Manuel Bouyer a écrit : Module Name:src Committed By: bouyer Date: Sat Nov 11 09:10:19 UTC 2017 Modified Files: src/sys/arch/x86

Re: CVS commit: src/sys/arch/amd64

2017-12-08 Thread Maxime Villard
Le 08/12/2017 à 00:11, Christos Zoulas a écrit : Module Name:src Committed By: christos Date: Thu Dec 7 23:11:50 UTC 2017 Modified Files: src/sys/arch/amd64/amd64: netbsd32_machdep.c src/sys/arch/amd64/conf: files.amd64 Added Files:

Re: CVS commit: src/sys/compat

2017-12-08 Thread Maxime Villard
Le 08/12/2017 à 16:31, Robert Elz a écrit : Module Name:src Committed By: kre Date: Fri Dec 8 15:31:13 UTC 2017 Modified Files: src/sys/compat/linux/common: linux_mod.c src/sys/compat/linux32/common: linux32_mod.c Log Message: Finish the previous change - as

Re: CVS commit: src/sys/arch

2017-12-02 Thread Maxime Villard
Le 02/12/2017 à 14:22, Kamil Rytarowski a écrit : There are still users of NetBSD/i386 0.9 executables (like myself - of Franz Lisp). And? compat_09 is available on i386. It's reasonable to drop compat for pre-ELF (approximately < 2.0) ... Yes, amd64 needs to start from compat_20. But

Re: CVS commit: src/sys/arch

2017-12-02 Thread Maxime Villard
Le 02/12/2017 à 17:33, Kamil Rytarowski a écrit : OK, I will prompt about it myself. Just to clarify. The < compat_20 options *will* be dropped on amd64. If you meant to drop everything below compat_20 in all our supported architectures in general, then ask if you want.

Re: CVS commit: src/sys/arch

2017-12-02 Thread Maxime Villard
On Sat, Dec 02, 2017 at 01:03:15PM +, Maxime Villard wrote: > Modified Files: > src/sys/arch/amd64/conf: GENERIC files.amd64 > src/sys/arch/xen/conf: files.xen > Removed Files: > src/sys/arch/amd64/amd64: compat_13_machdep.c > > Log Message: >

Re: CVS commit: src/sys/arch

2017-12-02 Thread Maxime Villard
Le 02/12/2017 à 21:26, Jonathan A. Kollasch a écrit : On Sat, Dec 02, 2017 at 05:45:08PM +0100, Maxime Villard wrote: Le 02/12/2017 à 17:33, Kamil Rytarowski a écrit : OK, I will prompt about it myself. Just to clarify. The < compat_20 options *will* be dropped on amd64. What authority

Re: CVS commit: src/sys/arch

2017-12-03 Thread Maxime Villard
Le 02/12/2017 à 22:23, David Holland a écrit : On Sat, Dec 02, 2017 at 10:04:26PM +0100, Maxime Villard wrote: > > Revert this. Compat on amd64 must be available all the way back to > > 0.9, same as i386. > > > > Also, please stop unilaterally breaking the world.

Re: CVS commit: src/sys/arch

2017-12-09 Thread Maxime Villard
Le 04/12/2017 à 23:13, Maxime Villard a écrit : Le 04/12/2017 à 20:17, Christos Zoulas a écrit : In article <f6366cc7-4011-0b65-42bd-6814a9f31...@m00nbsd.net>, Maxime Villard <m...@m00nbsd.net> wrote: Le 03/12/2017 à 16:55, David Holland a écrit : On Sun, Dec 03, 2017 at 10:0

Re: CVS commit: src/sys/compat

2017-12-01 Thread Maxime Villard
Le 01/12/2017 à 23:14, Joerg Sonnenberger a écrit : Module Name:src Committed By: joerg Date: Fri Dec 1 22:14:52 UTC 2017 Modified Files: src/sys/compat/linux/common: linux_mod.c src/sys/compat/linux32/common: linux32_mod.c Log Message: Unbreak Linux emulation

Re: CVS commit: src/sys/compat

2017-12-08 Thread Maxime Villard
Le 08/12/2017 à 20:54, Robert Elz a écrit : Date:Fri, 8 Dec 2017 16:54:24 +0100 From:Maxime Villard <m...@m00nbsd.net> Message-ID: <96c690fd-8577-0e4d-dcbb-84c51aed0...@m00nbsd.net> | No, it wasn't barbaric, it made perfect sense: It was, and m

Re: CVS commit: src/sys/netipsec

2018-05-14 Thread Maxime Villard
Le 14/05/2018 à 04:16, Ryota Ozaki a écrit : Module Name:src Committed By: ozaki-r Date: Mon May 14 02:16:30 UTC 2018 Modified Files: src/sys/netipsec: xform_tcp.c Log Message: Restore TCP header inclusions for TCP_SIGNATURE To generate a diff of this commit: cvs

Re: CVS commit: src/sys/compat/svr4

2018-05-31 Thread Maxime Villard
Le 31/05/2018 à 17:41, Maxime Villard a écrit : Module Name:src Committed By: maxv Date: Thu May 31 15:41:11 UTC 2018 Modified Files: src/sys/compat/svr4: svr4_stream.c Log Message: Add XXX for NULL deref. Not sure how to fix it, not sure we care either... To generate

Re: CVS commit: src/sys/arch

2018-06-20 Thread Maxime Villard
Le 20/06/2018 à 16:31, Jaromír Doleček a écrit : The function is ever called only with x86_fpu_save >= FPU_SAVE_FXSAVE, so there should be no change in functionality AFAICS. There is a change in functionality, you added an xsave check in a function that is fxsave-specific. xsave != fxsave.

Re: CVS commit: src/sys/netinet

2018-04-29 Thread Maxime Villard
Le 29/04/2018 à 16:24, Christos Zoulas a écrit : In article <20180429121242.6ca71f...@cvs.netbsd.org>, Maxime Villard <source-changes-d@NetBSD.org> wrote: -=-=-=-=-=- Module Name:src Committed By: maxv Date: Sun Apr 29 12:12:42 UTC 2018 Modified Files: src

Re: CVS commit: src/external/bsd/ipf/dist/ipsend

2018-04-29 Thread Maxime Villard
Le 29/04/2018 à 17:59, Christos Zoulas a écrit : Module Name:src Committed By: christos Date: Sun Apr 29 15:59:07 UTC 2018 Modified Files: src/external/bsd/ipf/dist/ipsend: ipsend.h Log Message: fix the build: tcpiphdr is now defined in tcp_var.h and tcp_var.h needs

Re: CVS commit: src/sys/arch

2018-01-10 Thread Maxime Villard
Le 04/01/2018 à 15:50, Valery Ushakov a écrit : On Thu, Jan 04, 2018 at 13:36:30 +, Maxime Villard wrote: Module Name:src Committed By: maxv Date: Thu Jan 4 13:36:30 UTC 2018 Modified Files: src/sys/arch/amd64/amd64: genassym.cf locore.S machdep.c src/sys

Re: CVS commit: src/sys/net

2018-01-19 Thread Maxime Villard
Le 19/01/2018 à 13:31, Takeshi Nakayama a écrit : Module Name:src Committed By: nakayama Date: Fri Jan 19 12:31:28 UTC 2018 Modified Files: src/sys/net: if_ethersubr.c Log Message: Fix inverted logic. To generate a diff of this commit: cvs rdiff -u -r1.256 -r1.257

  1   2   3   4   5   6   7   8   >