Re: CVS commit: src/sys [freeze on boot]
On Tue, Jan 21, 2020 at 03:48:27PM +0900, Masanobu SAITOH wrote:
> I suspect the location of your panic is after the following message
> (because of ixgbe_allocate_msix()'s failure):
>
> > aprint_normal(" ETrackID %08x\n", ((uint32_t)high << 16) | low);
Exactly right:
ixg0 at pci8 dev 0 function 0: Intel(R) PRO/10GbE PCI-Express Network Driver,
Version - 4.0.1-k
ixg0: device 82599EB
ixg0: ETrackID 81a5
ixg0: autoconfiguration error: failed to allocate MSI-X interrupt
> If so, could you try the following diff?
That fixed it, thanks! (with ad@'s rwlock fix and your patch all permutations
work)
Cheers,
Patrick
Re: CVS commit: src/sys [freeze on boot]
On Mon, Jan 20, 2020 at 04:12:45PM +, Patrick Welche wrote:
> On Mon, Jan 20, 2020 at 12:51:00PM +, Andrew Doran wrote:
> > This also happened the last time I touched rw_downgrade(), and I backed out
> > the change then, but both times I don't see the bug. I have some questions:
> >
> > - Are you running DIAGNOSTIC and/or LOCKDEBUG? I would be very interested
> > to see what happens with a LOCKDEBUG kernel here.
>
> One worked with the addition of LOCKDEBUG. The other didn't, but it seems
> to be unrelated:
>
> db{0}> show panic
> Panic string: mutex_vector_enter,510: uninitialized lock
> (lock=0xbd012366609
> 0, from=8033dc9d)
> bt
> breakpoint() at netbsd:breakpoint+0x5
> vpanic() at netbsd:vpanic+0x178
> snprintf() at netbsd:snprintf
> lockdebug_wantlock() at netbsd:lockdebug_wantlock+0x166
> mutex_enter() at netbsd:mutex_enter+0x37c
> ixgbe_getext() at netbsd:ixgbe_getext+0x1d
ixgbe_getext does mutex_enter(>eh_mtx) but...
> ixgbe_jcl_freeall.isra.0() at netbsd:ixgbe_jcl_freeall.isra.0+0xd6
> ixgbe_jcl_destroy() at netbsd:ixgbe_jcl_destroy+0x14
... ixgbe_jc_destroy does mutex_destroy(>eh_mtx)
Re: CVS commit: src/sys [freeze on boot]
On Mon, Jan 20, 2020 at 12:51:00PM +, Andrew Doran wrote: > This also happened the last time I touched rw_downgrade(), and I backed out > the change then, but both times I don't see the bug. I have some questions: > > - Are you running DIAGNOSTIC and/or LOCKDEBUG? I would be very interested > to see what happens with a LOCKDEBUG kernel here. I think that's basically it! - custom without any of DIAGNOSTIC / DEBUG / LOCKDEBUG fails - standard GENERIC with DIAGNOSTIC fails - custom with all of DIAGNOSTIC / DEBUG / LOCKDEBUG boots! > - Do you have an ATI Radeon graphics chip? (of the two failing one with and one without) > - Are you using ZFS? no I'll try addking LOCKDEBUG to the other one and see if that allows it to boot too... Cheers, Patrick
Re: CVS commit: src/sys [freeze on boot]
On Mon, Jan 20, 2020 at 12:51:00PM +, Andrew Doran wrote:
> This also happened the last time I touched rw_downgrade(), and I backed out
> the change then, but both times I don't see the bug. I have some questions:
>
> - Are you running DIAGNOSTIC and/or LOCKDEBUG? I would be very interested
> to see what happens with a LOCKDEBUG kernel here.
One worked with the addition of LOCKDEBUG. The other didn't, but it seems
to be unrelated:
db{0}> show panic
Panic string: mutex_vector_enter,510: uninitialized lock (lock=0xbd012366609
0, from=8033dc9d)
bt
breakpoint() at netbsd:breakpoint+0x5
vpanic() at netbsd:vpanic+0x178
snprintf() at netbsd:snprintf
lockdebug_wantlock() at netbsd:lockdebug_wantlock+0x166
mutex_enter() at netbsd:mutex_enter+0x37c
ixgbe_getext() at netbsd:ixgbe_getext+0x1d
ixgbe_jcl_freeall.isra.0() at netbsd:ixgbe_jcl_freeall.isra.0+0xd6
ixgbe_jcl_destroy() at netbsd:ixgbe_jcl_destroy+0x14
ixgbe_free_receive_structures() at netbsd:ixgbe_free_receive_structures+0x11b
ixgbe_attach() at netbsd:ixgbe_attach+0x2b0a
config_attach_loc() at netbsd:config_attach_loc+0x1a8
config_found_sm_loc() at netbsd:config_found_sm_loc+0x4d
pci_probe_device() at netbsd:pci_probe_device+0x586
pci_enumerate_bus() at netbsd:pci_enumerate_bus+0x1b7
pcirescan() at netbsd:pcirescan+0x4e
pciattach() at netbsd:pciattach+0x186
config_attach_loc() at netbsd:config_attach_loc+0x1a8
config_found_sm_loc() at netbsd:config_found_sm_loc+0x4d
ppbattach() at netbsd:ppbattach+0x1c5
config_attach_loc() at netbsd:config_attach_loc+0x1a8
config_found_sm_loc() at netbsd:config_found_sm_loc+0x4d
pci_probe_device() at netbsd:pci_probe_device+0x586
pci_enumerate_bus() at netbsd:pci_enumerate_bus+0x1b7
pcirescan() at netbsd:pcirescan+0x4e
pciattach() at netbsd:pciattach+0x186
config_attach_loc() at netbsd:config_attach_loc+0x1a8
config_found_sm_loc() at netbsd:config_found_sm_loc+0x4d
ppbattach() at netbsd:ppbattach+0x1c5
config_attach_loc() at netbsd:config_attach_loc+0x1a8
config_found_sm_loc() at netbsd:config_found_sm_loc+0x4d
pci_probe_device() at netbsd:pci_probe_device+0x586
pci_enumerate_bus() at netbsd:pci_enumerate_bus+0x1b7
pcirescan() at netbsd:pcirescan+0x4e
pciattach() at netbsd:pciattach+0x186
config_attach_loc() at netbsd:config_attach_loc+0x1a8
config_found_sm_loc() at netbsd:config_found_sm_loc+0x4d
ppbattach() at netbsd:ppbattach+0x1c5
config_attach_loc() at netbsd:config_attach_loc+0x1a8
config_found_sm_loc() at netbsd:config_found_sm_loc+0x4d
pci_probe_device() at netbsd:pci_probe_device+0x586
pci_enumerate_bus() at netbsd:pci_enumerate_bus+0x1b7
pcirescan() at netbsd:pcirescan+0x4e
pciattach() at netbsd:pciattach+0x186
config_attach_loc() at netbsd:config_attach_loc+0x1a8
config_found_sm_loc() at netbsd:config_found_sm_loc+0x4d
mp_pci_scan() at netbsd:mp_pci_scan+0xa4
amd64_mainbus_attach() at netbsd:amd64_mainbus_attach+0x237
mainbus_attach() at netbsd:mainbus_attach+0x70
config_attach_loc() at netbsd:config_attach_loc+0x1a8
cpu_configure() at netbsd:cpu_configure+0x2b
main() at netbsd:main+0x311
Cheers,
Patrick
Re: CVS commit: src/sys [freeze on boot]
On Mon, Jan 20, 2020 at 12:51:00PM +, Andrew Doran wrote: > This also happened the last time I touched rw_downgrade(), and I backed out > the change then, but both times I don't see the bug. I have some questions: 2 amd64 boxes, let's call them a) and b) > - Are you running DIAGNOSTIC and/or LOCKDEBUG? I would be very interested a) standard GENERIC kernel, so just DIAGNOSTIC b) neither(!) > to see what happens with a LOCKDEBUG kernel here. I'll try on b) in a minute > - Do you have an ATI Radeon graphics chip? a) no: genfb0 at pci10 dev 3 function 0: Matrox MGA G200eW b) yes: vga0 at pci3 dev 0 function 0: ATI Technologies Radeon X300 (RV370) > - Are you using ZFS? no (a nor b) Cheers, Patrick
CVS commit: src/sys/dev/ic
Module Name:src
Committed By: prlw1
Date: Mon Nov 4 15:12:10 UTC 2019
Modified Files:
src/sys/dev/ic: wdc.c
Log Message:
Fix locking bug seen when using WDCNDELAY_DEBUG in PR kern/52126
(Observed
piixide0:0:0: warning: busy-wait took 200us
with no panic)
To generate a diff of this commit:
cvs rdiff -u -r1.294 -r1.295 src/sys/dev/ic/wdc.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/dev/ic/wdc.c
diff -u src/sys/dev/ic/wdc.c:1.294 src/sys/dev/ic/wdc.c:1.295
--- src/sys/dev/ic/wdc.c:1.294 Wed Oct 23 14:44:41 2019
+++ src/sys/dev/ic/wdc.c Mon Nov 4 15:12:10 2019
@@ -1,4 +1,4 @@
-/* $NetBSD: wdc.c,v 1.294 2019/10/23 14:44:41 christos Exp $ */
+/* $NetBSD: wdc.c,v 1.295 2019/11/04 15:12:10 prlw1 Exp $ */
/*
* Copyright (c) 1998, 2001, 2003 Manuel Bouyer. All rights reserved.
@@ -58,7 +58,7 @@
*/
#include
-__KERNEL_RCSID(0, "$NetBSD: wdc.c,v 1.294 2019/10/23 14:44:41 christos Exp $");
+__KERNEL_RCSID(0, "$NetBSD: wdc.c,v 1.295 2019/11/04 15:12:10 prlw1 Exp $");
#include "opt_ata.h"
#include "opt_wdc.h"
@@ -1240,7 +1240,7 @@ __wdcwait(struct ata_channel *chp, int m
if (!cold && xtime > WDCNDELAY_DEBUG) {
struct ata_xfer *xfer;
- xfer = ata_queue_get_active_xfer(chp);
+ xfer = ata_queue_get_active_xfer_locked(chp);
if (xfer == NULL)
printf("%s channel %d: warning: busy-wait took %dus\n",
device_xname(chp->ch_atac->atac_dev),
CVS commit: src/sys/dev/ic
Module Name:src Committed By: prlw1 Date: Mon Nov 4 15:12:10 UTC 2019 Modified Files: src/sys/dev/ic: wdc.c Log Message: Fix locking bug seen when using WDCNDELAY_DEBUG in PR kern/52126 (Observed piixide0:0:0: warning: busy-wait took 200us with no panic) To generate a diff of this commit: cvs rdiff -u -r1.294 -r1.295 src/sys/dev/ic/wdc.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.sbin/postinstall
Module Name:src
Committed By: prlw1
Date: Wed Oct 30 20:24:44 UTC 2019
Modified Files:
src/usr.sbin/postinstall: postinstall.in
Log Message:
Add nvmm group.
To generate a diff of this commit:
cvs rdiff -u -r1.7 -r1.8 src/usr.sbin/postinstall/postinstall.in
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/usr.sbin/postinstall/postinstall.in
diff -u src/usr.sbin/postinstall/postinstall.in:1.7 src/usr.sbin/postinstall/postinstall.in:1.8
--- src/usr.sbin/postinstall/postinstall.in:1.7 Tue Sep 24 13:27:39 2019
+++ src/usr.sbin/postinstall/postinstall.in Wed Oct 30 20:24:44 2019
@@ -1,6 +1,6 @@
#!/bin/sh
#
-# $NetBSD: postinstall.in,v 1.7 2019/09/24 13:27:39 nakayama Exp $
+# $NetBSD: postinstall.in,v 1.8 2019/10/30 20:24:44 prlw1 Exp $
#
# Copyright (c) 2002-2015 The NetBSD Foundation, Inc.
# All rights reserved.
@@ -1138,7 +1138,7 @@ do_gid()
"${SRC_DIR}/etc/group" 14 \
named ntpd sshd SKIP _pflogd _rwhod staff _proxy _timedc \
_sdpd _httpd _mdnsd _tests _tcpdump _tss _gpio _rtadvd SKIP \
- _unbound _nsd
+ _unbound _nsd nvmm
}
#
CVS commit: src/usr.sbin/postinstall
Module Name:src Committed By: prlw1 Date: Wed Oct 30 20:24:44 UTC 2019 Modified Files: src/usr.sbin/postinstall: postinstall.in Log Message: Add nvmm group. To generate a diff of this commit: cvs rdiff -u -r1.7 -r1.8 src/usr.sbin/postinstall/postinstall.in Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
Re: CVS commit: src
On Tue, Jul 30, 2013 at 08:55:41AM +0530, Cherry G. Mathew wrote: On 28 July 2013 20:25, Cherry G. Mathew cherry.g.mat...@gmail.com wrote: On 28 July 2013 17:16, Patrick Welche pr...@netbsd.org wrote: ... LICENSE.iwlwifi-6000g2b-ucode README.iwlwifi-6000g2b-ucode iwlwifi-6000g2b-6.ucode Log Message: Add support for Centrino Wireless-N 1030 and Centrino Advanced-N 6230 http://mail-index.netbsd.org/tech-net/2013/01/04/msg003802.html Thank you Patrick, I look forward to testing this. What's with the module #ifdef hack though ? I tried to make life developing the driver easier by turning it into a kernel loadable module, but failed... My N 6230 works - thank you for this! There are occasional dropoffs, but I'm not sure it's because of the driver itself yet. :-) Cheers, Patrick
