Re: CVS commit: src/etc/rc.d
It started for me on Saturday, when I updated from 5.99.8 to 5.99.11 On Tue, 21 Apr 2009, Thomas Klausner wrote: On Mon, Apr 13, 2009 at 06:48:15PM +, Adam Hamsik wrote: Module Name:src Committed By: haad Date: Mon Apr 13 18:48:15 UTC 2009 Modified Files: src/etc/rc.d: lvm Log Message: We need writable /dev to get lvm working otherwise lvm devices can't be created. I don't know when this was introduced, but I just saw this: About to run shutdown hooks... rcorder: Circular dependency on provision `root' in file `/etc/rc.d/lvm'. Thomas - | Paul Goyette | PGP DSS Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com | | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | -
Re: CVS commit: src/sys/arch/x86/x86
given that this issue is appearing on both ipmi and coretemp, and the fact that coretemp doesn't even bother with hi/low limits, it's probably something in envsys itself. On Tue, 7 Jul 2009, Matthias Drochner wrote: p...@whooppee.com said: I guess maybe the minus signs shouldn't ever happen? someone out here with a liquid nitrogen cooler? I don't think even liquid N2 would get more than 1000 degress below absolute zero... :) - | Paul Goyette | PGP DSS Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com | | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | -
Re: CVS commit: src/sys/net
On Mon, 17 Aug 2009, David Young wrote: To avoid amibiguities, I say that a digits-only name MUST match the integer name. ... Yes, I would agree with your match criterium. ... That is, this should not be allowed: sysctl_createv(NULL, 0, NULL, cnode, CTLFLAG_PERMANENT, CTLTYPE_NODE, 17, NULL, NULL, 0, NULL, 0, 12, 3, CTL_EOL); because that would create a node with the numeric path 12.3 whose string path ends in 17. So all we end up doing is easing the restriction from no leading digit to at least one non-digit in the node names. But that doesn't solve the problem which started this thread. In that example, we had a node whose entire name was 3 :) - | Paul Goyette | PGP DSS Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com | | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | -
CVS commit: src/sys/dev/sysmon
Module Name:src Committed By: pgoyette Date: Fri Jan 1 15:41:25 UTC 2010 Modified Files: src/sys/dev/sysmon: sysmon_envsys_events.c Log Message: Don't infer a sensor driver's ability to handle limit checking itself. To generate a diff of this commit: cvs rdiff -u -r1.72 -r1.73 src/sys/dev/sysmon/sysmon_envsys_events.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/dev/i2c
Module Name:src Committed By: pgoyette Date: Fri Jan 1 15:43:50 UTC 2010 Modified Files: src/sys/dev/i2c: sdtemp.c Log Message: Explicitly inform envsys that the driver is capable of doing its own limit checking at initialization time. Later on, if user specifics any unsupported limits, the driver will relinquish this task. To generate a diff of this commit: cvs rdiff -u -r1.7 -r1.8 src/sys/dev/i2c/sdtemp.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/dev/acpi
Module Name:src Committed By: pgoyette Date: Fri Jan 1 15:55:30 UTC 2010 Modified Files: src/sys/dev/acpi: acpi_tz.c Log Message: Don't set sensor state to SWARNOVER here. Doing so based only on the device's active cooling levels prevents the user from overriding these limits with his own values. XXX We should probably also change setting SCRITOVER state to SCRITICAL, XXX but right now that just confuses things. We currently don't have a XXX way for a sensor to be both SCRITICAL and SCRITOVER. To generate a diff of this commit: cvs rdiff -u -r1.52 -r1.53 src/sys/dev/acpi/acpi_tz.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/dev/sysmon
Module Name:src Committed By: pgoyette Date: Sat Jan 2 19:02:40 UTC 2010 Modified Files: src/sys/dev/sysmon: sysmon_envsys_events.c Log Message: Flags for existence of limit values need to be propagated to the event data. Otherwise, they're not processed. XXX This needs to be rethought. While fixing it this way makes things XXX work, we really shouldn't need to replicate these flags. The XXX limits and their flags should be kept as part of the sensor data, XXX and not part of the event-monitor data. I'll work on this in the XXX near future. To generate a diff of this commit: cvs rdiff -u -r1.73 -r1.74 src/sys/dev/sysmon/sysmon_envsys_events.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/dev/sysmon
Module Name:src Committed By: pgoyette Date: Mon Jan 18 21:48:15 UTC 2010 Modified Files: src/sys/dev/sysmon: sysmon_envsys_events.c Log Message: If no limits are exceeded, make sure we set state to SVALID To generate a diff of this commit: cvs rdiff -u -r1.74 -r1.75 src/sys/dev/sysmon/sysmon_envsys_events.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/kern
Module Name:src Committed By: pgoyette Date: Thu Jan 21 04:40:23 UTC 2010 Modified Files: src/sys/kern: uipc_syscalls.c Log Message: Remove unnecessary call to kauth_cred_free(). This resolves an occassional crash I'd been experiencing as reported on current-users@ Fix suggested by and OK elad@ To generate a diff of this commit: cvs rdiff -u -r1.139 -r1.140 src/sys/kern/uipc_syscalls.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
RE: CVS commit: src/share/man/man9
On Mon, 25 Jan 2010, Paul Goyette wrote: Module Name:src Committed By: jruoho Date: Mon Jan 25 16:16:34 UTC 2010 Modified Files: src/share/man/man9: Makefile Added Files: src/share/man/man9: sysmon_taskq.9 Log Message: Add a simple manual page for the simple sysmon task queue. ok wiz@ This routine is really targetted specifically for use by the sysmon_envsys(8) facility. This man page seems to imply that it's available for general-purpose use. If we're going to treat it as a general-purpose routine, we should rename and move the files (kern/kern_taskq.[ch] maybe?). Otherwise, I'd prefer to make this man page more specific to sysmon, and perhaps add an example of where it is currently used. Also, there is some semantics in the current implementation where all the tasks in the queue are run before checking the condvar; this might not necessarily be appropriate for a general-purpose taskq. /* * Run through all the tasks before we check for the exit * condition; it's probably more important to actually run * all the tasks before we exit. */ - | Paul Goyette | PGP DSS Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com | | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | -
Re: CVS commit: src/share/man/man9
Wow - I didn't realize it was so widely used! (Next time, before I comment, I'll learn to use grep!) As already pointed out, a large percentage of those references are part of the various buttons' integration with sysmon/powerd. I think that a simple mention of this intended usage would be appropriate for the man page. I also think that the run all tasks before checking for exit semantics should be mentioned. But we can forget about relocating it. :) BTW, thanks for documenting it! On Mon, 25 Jan 2010, Jukka Ruohonen wrote: On Mon, Jan 25, 2010 at 12:54:45PM -0800, Paul Goyette wrote: This routine is really targetted specifically for use by the sysmon_envsys(8) facility. This man page seems to imply that it's available for general-purpose use. Well, the sysmon-part is in the name so... :) While it is targeted for sysmon_envsys(8), the most important task for it on x86 is to schedule all ACPI notifys, including interrupts, via the AcpiOsExecute (see sys/dev/acpi/acpica/OsdSchedule.c). I would presume that this was also the reason why it was originally written. The other places where it is currently used: * sys/arch/arm/xscale/becc_button.c * sys/arch/evbarm/hdl_g/btn_obio.c * sys/arch/evbarm/nslu2/nslu2_buttons.c * sys/arch/hp700/dev/power.c * sys/arch/landisk/dev/btn_obio.c * sys/arch/landisk/dev/pwrsw_obio.c * sys/arch/mips/atheros/dev/argpio.c * sys/arch/sgimips/hpc/panel.c * sys/arch/sparc/dev/tctrl.c * sys/arch/sparc64/dev/psycho.c * sys/arch/x68k/dev/pow.c * sys/dev/adb/adb_kbd.c * sys/arch/arm/xscale/becc_button.c ... and probably others. This makes it pretty general to me. If we're going to treat it as a general-purpose routine, we should rename and move the files (kern/kern_taskq.[ch] maybe?). Otherwise, I'd prefer to make this man page more specific to sysmon, and perhaps add an example of where it is currently used. Due to the wide usage listed above, I don't think renaming is worth the cause. A word or two about the context (sysmon, power, something) wouldn't do harm though. Also, there is some semantics in the current implementation where all the tasks in the queue are run before checking the condvar; this might not necessarily be appropriate for a general-purpose taskq. /* * Run through all the tasks before we check for the exit * condition; it's probably more important to actually run * all the tasks before we exit. */ This could be mentioned sure. - Jukka. - | Paul Goyette | PGP DSS Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com | | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | -
CVS commit: src/share/man/man9
Module Name:src Committed By: pgoyette Date: Tue Jan 26 18:08:24 UTC 2010 Modified Files: src/share/man/man9: sysmon_pswitch.9 Log Message: Fix .Bl markup - s/-compat/-compact/ To generate a diff of this commit: cvs rdiff -u -r1.1 -r1.2 src/share/man/man9/sysmon_pswitch.9 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
Re: CVS commit: src/usr.sbin/powerd
The powerd(8) man page currently says
The first location is /etc/powerd/scripts/power_type, where
power_type is defined by the power management mechanism
supported by the system, e.g., ``apm'' or ``acpi''. If the
script is not found in the first location, powerd looks in
/etc/powerd/scripts.
This implies that the .../apm/... and .../acpi/... are optional. Yet
src/usr.sbin/powerd.c has not been updated for more than two years, and
it defines only a single path for locating the scripts.
#define _PATH_POWERD_SCRIPTS/etc/powerd/scripts
snip
static const char *script_paths[] = {
NULL,
_PATH_POWERD_SCRIPTS
};
On Tue, 26 Jan 2010, Jonathan A. Kollasch wrote:
On Tue, Jan 26, 2010 at 08:37:13PM +, Jukka Ruohonen wrote:
* Apparently there is only a single location for the scripts. Thus, remove
the references to /etc/powerd/scripts/apm and /etc/powerd/scripts/acpi.
When did this change? I remember fixing this in the acpi case recently.
Jonathan Kollasch
-
| Paul Goyette | PGP DSS Key fingerprint: | E-mail addresses: |
| Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com |
| Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net |
| Kernel Developer | | pgoyette at netbsd.org |
-
Re: CVS commit: src/usr.sbin/powerd
On Wed, 27 Jan 2010, Jukka Ruohonen wrote:
I can put it back. But as has been pointed out, does it need to be there to
confuse users when neither (a) the directories exist in the default install
nor (b) does support for this exist in the code?
Support does exist - you just have to look a bit deeper than the
surface. Jason has provided the relevant sources where the apm or acpi
path is created; here's where it gets used:
static void
run_script(const char *argv[])
{
char path[MAXPATHLEN+1];
size_t i, j;
for (i = 0; i __arraycount(script_paths); i++) {
(void)snprintf(path, sizeof(path), %s/%s, script_paths[i],
argv[0]);
if (access(path, R_OK|X_OK) == 0) {
...
return;
}
}
}
-
| Paul Goyette | PGP DSS Key fingerprint: | E-mail addresses: |
| Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com |
| Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net |
| Kernel Developer | | pgoyette at netbsd.org |
-
CVS commit: src/sys/dev/sysmon
Module Name:src Committed By: pgoyette Date: Sat Jan 30 02:46:53 UTC 2010 Modified Files: src/sys/dev/sysmon: sysmon_envsys.c sysmon_envsys_events.c Log Message: Validate limit-based monitoring in one place, so we can apply the constraints to both driver-requested and user-requested monitoring. While here, clean up some of the debugging DPRINTFs. To generate a diff of this commit: cvs rdiff -u -r1.90 -r1.91 src/sys/dev/sysmon/sysmon_envsys.c cvs rdiff -u -r1.76 -r1.77 src/sys/dev/sysmon/sysmon_envsys_events.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.sbin/envstat
Module Name:src Committed By: pgoyette Date: Sat Jan 30 02:56:39 UTC 2010 Modified Files: src/usr.sbin/envstat: envstat.8 envstat.c Log Message: Since we never have both a limit value and a limit %capacity value, remove the Capacity column. Reduce inter-column spacing, and display all four limits on one page, rather than using the -W command line option to switch between critical and warning limits. (The -W option is still permitted, but has no effect.) %capacity limits are displayed in the WarnMin and CritMin columns, but have a trailing % sign. To generate a diff of this commit: cvs rdiff -u -r1.51 -r1.52 src/usr.sbin/envstat/envstat.8 cvs rdiff -u -r1.72 -r1.73 src/usr.sbin/envstat/envstat.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/dev/sysmon
Module Name:src Committed By: pgoyette Date: Thu Feb 4 18:06:53 UTC 2010 Modified Files: src/sys/dev/sysmon: sysmon_envsys_events.c Log Message: If the AC adapter is flagged with SME_DISABLE_REFRESH, don't try to call its refresh() callback. Just assume that its value has been properly updated by other means. To generate a diff of this commit: cvs rdiff -u -r1.77 -r1.78 src/sys/dev/sysmon/sysmon_envsys_events.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/arch
Module Name:src Committed By: pgoyette Date: Sat Feb 6 20:12:32 UTC 2010 Modified Files: src/sys/arch/amd64/conf: GENERIC src/sys/arch/i386/conf: ALL GENERIC Log Message: Add acpismbus enries - commented out! To generate a diff of this commit: cvs rdiff -u -r1.263 -r1.264 src/sys/arch/amd64/conf/GENERIC cvs rdiff -u -r1.231 -r1.232 src/sys/arch/i386/conf/ALL cvs rdiff -u -r1.962 -r1.963 src/sys/arch/i386/conf/GENERIC Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/distrib/sets/lists/man
Module Name:src Committed By: pgoyette Date: Sat Feb 6 20:15:54 UTC 2010 Modified Files: src/distrib/sets/lists/man: mi Log Message: Add man page for acpismbus(4) To generate a diff of this commit: cvs rdiff -u -r1.1188 -r1.1189 src/distrib/sets/lists/man/mi Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/arch/i386/conf
Module Name:src Committed By: pgoyette Date: Sat Feb 6 21:27:51 UTC 2010 Modified Files: src/sys/arch/i386/conf: ALL Log Message: Enable acpismbus(4) for ALL kernel, per discussion on tech-kern To generate a diff of this commit: cvs rdiff -u -r1.232 -r1.233 src/sys/arch/i386/conf/ALL Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/dev/pci
Module Name:src Committed By: pgoyette Date: Sun Feb 7 20:55:46 UTC 2010 Modified Files: src/sys/dev/pci: amdpm.c Log Message: Recognize the i2c bus on the AMD768 PCI-ISA/LPC Bridge Resolves PR/42759 - thanks Michael Stapelberg To generate a diff of this commit: cvs rdiff -u -r1.33 -r1.34 src/sys/dev/pci/amdpm.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/dev/ic
Module Name:src Committed By: pgoyette Date: Mon Feb 8 21:42:01 UTC 2010 Modified Files: src/sys/dev/ic: nslm7x.c nslm7xvar.h Log Message: Add temp-sensor type selection (via autoconfig flags). Currently only enabled for W83627HF but easily extended to others if appropriate. Fixes PR kern-42758 To generate a diff of this commit: cvs rdiff -u -r1.49 -r1.50 src/sys/dev/ic/nslm7x.c cvs rdiff -u -r1.26 -r1.27 src/sys/dev/ic/nslm7xvar.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/share/man/man4
Module Name:src Committed By: pgoyette Date: Mon Feb 8 21:42:41 UTC 2010 Modified Files: src/share/man/man4: lm.4 Log Message: Document flags option for selecting temp sensor type To generate a diff of this commit: cvs rdiff -u -r1.26 -r1.27 src/share/man/man4/lm.4 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/arch
Module Name:src Committed By: pgoyette Date: Mon Feb 8 21:45:32 UTC 2010 Modified Files: src/sys/arch/amd64/conf: GENERIC src/sys/arch/i386/conf: ALL GENERIC XEN3_DOM0 Log Message: Add flags to all instances of lm(4), add a reference to man page To generate a diff of this commit: cvs rdiff -u -r1.264 -r1.265 src/sys/arch/amd64/conf/GENERIC cvs rdiff -u -r1.233 -r1.234 src/sys/arch/i386/conf/ALL cvs rdiff -u -r1.963 -r1.964 src/sys/arch/i386/conf/GENERIC cvs rdiff -u -r1.27 -r1.28 src/sys/arch/i386/conf/XEN3_DOM0 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src
Module Name:src Committed By: pgoyette Date: Mon Feb 8 23:10:35 UTC 2010 Modified Files: src/share/man/man4: lm.4 src/sys/dev/ic: nslm7x.c Log Message: After reviewing the datasheets, most of the supported Winbond chips can handles the new flags for selecting sensor type. Update code and man page accordingly. To generate a diff of this commit: cvs rdiff -u -r1.28 -r1.29 src/share/man/man4/lm.4 cvs rdiff -u -r1.50 -r1.51 src/sys/dev/ic/nslm7x.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/dev/ic
Module Name:src Committed By: pgoyette Date: Tue Feb 9 13:59:01 UTC 2010 Modified Files: src/sys/dev/ic: nslm7x.c Log Message: Correct setting of bits in the generic thermistor mode. Cutpaste error pointed out by njoly@ To generate a diff of this commit: cvs rdiff -u -r1.51 -r1.52 src/sys/dev/ic/nslm7x.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/dev/sysmon
Module Name:src Committed By: pgoyette Date: Sat Feb 13 19:34:14 UTC 2010 Modified Files: src/sys/dev/sysmon: sysmon_envsys_events.c Log Message: When checking current sensor value vs limits, check the correct set of flags to determine which limits are present. To generate a diff of this commit: cvs rdiff -u -r1.79 -r1.80 src/sys/dev/sysmon/sysmon_envsys_events.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/dev/sysmon
Module Name:src Committed By: pgoyette Date: Sun Feb 14 16:22:09 UTC 2010 Modified Files: src/sys/dev/sysmon: sysmon_envsys_events.c Log Message: Correct one more instance of checking flags in the wrong place. To generate a diff of this commit: cvs rdiff -u -r1.80 -r1.81 src/sys/dev/sysmon/sysmon_envsys_events.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys
Module Name:src Committed By: pgoyette Date: Sun Feb 14 23:06:02 UTC 2010 Modified Files: src/sys/dev/sysmon: sysmon_envsys.c sysmon_envsys_events.c sysmon_envsysvar.h sysmonvar.h src/sys/sys: envsys.h Log Message: Remove the flags member of the limits structure. Its value was only meaningful for a few limited function calls; all persitent storage of limit-present flags is maintained in the edata-upropset member. To generate a diff of this commit: cvs rdiff -u -r1.94 -r1.95 src/sys/dev/sysmon/sysmon_envsys.c cvs rdiff -u -r1.81 -r1.82 src/sys/dev/sysmon/sysmon_envsys_events.c cvs rdiff -u -r1.30 -r1.31 src/sys/dev/sysmon/sysmon_envsysvar.h \ src/sys/dev/sysmon/sysmonvar.h cvs rdiff -u -r1.28 -r1.29 src/sys/sys/envsys.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/dev/i2c
Module Name:src Committed By: pgoyette Date: Sun Feb 14 23:07:22 UTC 2010 Modified Files: src/sys/dev/i2c: sdtemp.c Log Message: Adapt to changes in sysmon's limit structure To generate a diff of this commit: cvs rdiff -u -r1.9 -r1.10 src/sys/dev/i2c/sdtemp.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/arch/x86/x86
Module Name:src Committed By: pgoyette Date: Sun Feb 14 23:07:59 UTC 2010 Modified Files: src/sys/arch/x86/x86: ipmi.c Log Message: Adapt to changes in sysmon's limit structure. To generate a diff of this commit: cvs rdiff -u -r1.42 -r1.43 src/sys/arch/x86/x86/ipmi.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/dev/sysmon
Module Name:src Committed By: pgoyette Date: Sun Feb 14 23:30:52 UTC 2010 Modified Files: src/sys/dev/sysmon: sysmon_envsys_events.c Log Message: Replace large amount of replicated code with a macro to improve readability. To generate a diff of this commit: cvs rdiff -u -r1.82 -r1.83 src/sys/dev/sysmon/sysmon_envsys_events.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys
Module Name:src Committed By: pgoyette Date: Mon Feb 15 22:32:04 UTC 2010 Modified Files: src/sys/dev/sysmon: sysmon_envsys.c sysmon_envsys_events.c sysmon_power.c src/sys/sys: envsys.h power.h Log Message: For symmetry, allow warning and critical upper-limits for capacity sensors. To generate a diff of this commit: cvs rdiff -u -r1.95 -r1.96 src/sys/dev/sysmon/sysmon_envsys.c cvs rdiff -u -r1.83 -r1.84 src/sys/dev/sysmon/sysmon_envsys_events.c cvs rdiff -u -r1.42 -r1.43 src/sys/dev/sysmon/sysmon_power.c cvs rdiff -u -r1.29 -r1.30 src/sys/sys/envsys.h cvs rdiff -u -r1.14 -r1.15 src/sys/sys/power.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.sbin/envstat
Module Name:src
Committed By: pgoyette
Date: Mon Feb 15 22:37:14 UTC 2010
Modified Files:
src/usr.sbin/envstat: config.c config_lex.l envstat.c
Log Message:
Update userland envstat(8) to handle new {high,maximum}-capacity limits.
To generate a diff of this commit:
cvs rdiff -u -r1.8 -r1.9 src/usr.sbin/envstat/config.c
cvs rdiff -u -r1.6 -r1.7 src/usr.sbin/envstat/config_lex.l
cvs rdiff -u -r1.76 -r1.77 src/usr.sbin/envstat/envstat.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
CVS commit: src/sys/dev/acpi
Module Name:src Committed By: pgoyette Date: Thu Feb 18 13:52:33 UTC 2010 Modified Files: src/sys/dev/acpi: aiboost.c Log Message: Enhance DPRINTF to use AcpiFormatException as suggested in PR kern/40130 To generate a diff of this commit: cvs rdiff -u -r1.27 -r1.28 src/sys/dev/acpi/aiboost.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.bin/tic
Module Name:src Committed By: pgoyette Date: Sat Feb 20 06:08:01 UTC 2010 Modified Files: src/usr.bin/tic: tic.c Log Message: Since tic is a host tool, we need to include host system header to get definitions of le16dec() and le16enc(). Solves PR bin/42747 from Henning Petersen To generate a diff of this commit: cvs rdiff -u -r1.6 -r1.7 src/usr.bin/tic/tic.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.bin/tic
Module Name:src Committed By: pgoyette Date: Sat Feb 20 06:15:06 UTC 2010 Modified Files: src/usr.bin/tic: tic.c Log Message: Wrap the include of sys/endian.h in #ifdef HAVE_SYS_ENDIAN_H to avoid build issues on systems that don't have a sys/endian.h Pointed out by joerg@ To generate a diff of this commit: cvs rdiff -u -r1.7 -r1.8 src/usr.bin/tic/tic.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.bin/tic
Module Name:src Committed By: pgoyette Date: Sat Feb 20 06:20:46 UTC 2010 Modified Files: src/usr.bin/tic: tic.c Log Message: One more time - do this correctly. Thanks, joerg. To generate a diff of this commit: cvs rdiff -u -r1.8 -r1.9 src/usr.bin/tic/tic.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/dev/i2c
Module Name:src
Committed By: pgoyette
Date: Mon Feb 22 03:50:56 UTC 2010
Modified Files:
src/sys/dev/i2c: files.i2c
Added Files:
src/sys/dev/i2c: smscmon.c smscmonvar.h
Log Message:
Import smcsmon(4) driver for SMSC LPC47M192 hardware monitor
From Takahiro HAYASHI in PR kern/40420
To generate a diff of this commit:
cvs rdiff -u -r1.25 -r1.26 src/sys/dev/i2c/files.i2c
cvs rdiff -u -r0 -r1.1 src/sys/dev/i2c/smscmon.c src/sys/dev/i2c/smscmonvar.h
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/dev/i2c/files.i2c
diff -u src/sys/dev/i2c/files.i2c:1.25 src/sys/dev/i2c/files.i2c:1.26
--- src/sys/dev/i2c/files.i2c:1.25 Thu May 14 13:22:26 2009
+++ src/sys/dev/i2c/files.i2c Mon Feb 22 03:50:56 2010
@@ -1,4 +1,4 @@
-# $NetBSD: files.i2c,v 1.25 2009/05/14 13:22:26 pgoyette Exp $
+# $NetBSD: files.i2c,v 1.26 2010/02/22 03:50:56 pgoyette Exp $
defflag opt_i2cbus.hI2C_SCAN
define i2cbus { }
@@ -115,3 +115,8 @@
device admtemp: sysmon_envsys
attach admtemp at iic
file dev/i2c/adm1021.c admtemp
+
+# SMSC LPC47M192 hardware monitor
+device smscmon: sysmon_envsys
+attach smscmon at iic
+file dev/i2c/smscmon.c smscmon
Added files:
Index: src/sys/dev/i2c/smscmon.c
diff -u /dev/null src/sys/dev/i2c/smscmon.c:1.1
--- /dev/null Mon Feb 22 03:50:56 2010
+++ src/sys/dev/i2c/smscmon.c Mon Feb 22 03:50:56 2010
@@ -0,0 +1,331 @@
+/* $NetBSD: smscmon.c,v 1.1 2010/02/22 03:50:56 pgoyette Exp $ */
+
+/*
+ * Copyright (c) 2009 Takahiro Hayashi
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in the
+ *documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE NETBSD FOUNDATION, INC. AND CONTRIBUTORS
+ * ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
+ * TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE FOUNDATION OR CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include sys/cdefs.h
+__KERNEL_RCSID(0, $NetBSD: smscmon.c,v 1.1 2010/02/22 03:50:56 pgoyette Exp $);
+
+#include sys/param.h
+#include sys/systm.h
+#include sys/device.h
+
+#include dev/i2c/i2cvar.h
+#include dev/sysmon/sysmonvar.h
+#include dev/i2c/smscmonvar.h
+
+/*
+ * A driver for SMSC LPC47M192 hardware monitor at SMBus.
+ * This driver supports 8 Voltage and 3 Temperature sensors.
+ * Fan RPM monitoring is not supported in this driver because
+ * they are seen on ISA bus.
+ *
+ * Datasheet available (as of Feb. 20, 2010) at
+ * http://pdf1.alldatasheet.com/datasheet-pdf/view/109752/SMSC/LPC47M192-NC.html
+ */
+
+static int smscmon_match(device_t, cfdata_t, void *);
+static void smscmon_attach(device_t, device_t, void *);
+static uint8_t smscmon_readreg(struct smscmon_sc *, int);
+static void smscmon_writereg(struct smscmon_sc *, int, int);
+static void smscmon_sensors_setup(struct smscmon_sc *, struct smscmon_sensor *);
+static void smscmon_refresh_volt(struct smscmon_sc *, envsys_data_t *);
+static void smscmon_refresh_temp(struct smscmon_sc *, envsys_data_t *);
+static void smscmon_refresh(struct sysmon_envsys *, envsys_data_t *);
+
+CFATTACH_DECL_NEW(smscmon, sizeof(struct smscmon_sc),
+smscmon_match, smscmon_attach, NULL, NULL);
+
+static struct smscmon_sensor smscmon_lpc47m192[] = {
+ {
+ .desc = +2.5V,
+ .type = ENVSYS_SVOLTS_DC,
+ .reg = 0x20,
+ .refresh = smscmon_refresh_volt,
+ .vmin = 13000,
+ .vmax = 332
+ },
+ {
+ .desc = Vccp,
+ .type = ENVSYS_SVOLTS_DC,
+ .reg = 0x21,
+ .refresh = smscmon_refresh_volt,
+ .vmin = 12000,
+ .vmax = 2988000
+ },
+ {
+ .desc = +3.3V,
+ .type = ENVSYS_SVOLTS_DC,
+ .reg = 0x22,
+ .refresh = smscmon_refresh_volt,
+ .vmin = 17000,
+ .vmax = 4383000
+ },
+ {
+ .desc = +5V,
+ .type = ENVSYS_SVOLTS_DC,
+ .reg = 0x23,
+ .refresh = smscmon_refresh_volt,
+ .vmin = 26000,
+ .vmax = 664
+ },
+ {
+ .desc = +12V,
+ .type = ENVSYS_SVOLTS_DC,
+ .reg = 0x24,
+ .refresh = smscmon_refresh_volt,
+ .vmin =62000,
+ .vmax = 15938000
+
CVS commit: src/sys/arch/i386/conf
Module Name:src Committed By: pgoyette Date: Mon Feb 22 03:52:06 UTC 2010 Modified Files: src/sys/arch/i386/conf: ALL Log Message: Add smscmon(4) To generate a diff of this commit: cvs rdiff -u -r1.239 -r1.240 src/sys/arch/i386/conf/ALL Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src
Module Name:src Committed By: pgoyette Date: Mon Feb 22 03:54:25 UTC 2010 Modified Files: src/distrib/sets/lists/man: mi Added Files: src/share/man/man4: smscmon.4 Log Message: Add man page for smscmon(4) To generate a diff of this commit: cvs rdiff -u -r1.1193 -r1.1194 src/distrib/sets/lists/man/mi cvs rdiff -u -r0 -r1.1 src/share/man/man4/smscmon.4 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/distrib/sets/lists/man/mi diff -u src/distrib/sets/lists/man/mi:1.1193 src/distrib/sets/lists/man/mi:1.1194 --- src/distrib/sets/lists/man/mi:1.1193 Sun Feb 21 05:16:29 2010 +++ src/distrib/sets/lists/man/mi Mon Feb 22 03:54:24 2010 @@ -1,4 +1,4 @@ -# $NetBSD: mi,v 1.1193 2010/02/21 05:16:29 cnst Exp $ +# $NetBSD: mi,v 1.1194 2010/02/22 03:54:24 pgoyette Exp $ # # Note: don't delete entries from here - mark them as obsolete instead. # @@ -1432,6 +1432,7 @@ ./usr/share/man/cat4/slip.0 man-sys-catman .cat ./usr/share/man/cat4/sm.0 man-sys-catman .cat ./usr/share/man/cat4/smsc.0 man-sys-catman .cat +./usr/share/man/cat4/smscmon.0 man-sys-catman .cat ./usr/share/man/cat4/smsh.0 man-sys-catman .cat ./usr/share/man/cat4/sn.0 man-sys-catman .cat ./usr/share/man/cat4/sony.0 man-sys-catman .cat @@ -4010,6 +4011,7 @@ ./usr/share/man/html4/slip.html man-sys-htmlman html ./usr/share/man/html4/sm.html man-sys-htmlman html ./usr/share/man/html4/smsc.html man-sys-htmlman html +./usr/share/man/html4/smscmon.html man-sys-htmlman html ./usr/share/man/html4/smsh.html man-sys-htmlman html ./usr/share/man/html4/sn.html man-sys-htmlman html ./usr/share/man/html4/sony.html man-sys-htmlman html @@ -6500,6 +6502,7 @@ ./usr/share/man/man4/slip.4 man-sys-man .man ./usr/share/man/man4/sm.4 man-sys-man .man ./usr/share/man/man4/smsc.4 man-sys-man .man +./usr/share/man/man4/smscmon.4 man-sys-man .man ./usr/share/man/man4/smsh.4 man-sys-man .man ./usr/share/man/man4/sn.4 man-sys-man .man ./usr/share/man/man4/sony.4 man-sys-man .man Added files: Index: src/share/man/man4/smscmon.4 diff -u /dev/null src/share/man/man4/smscmon.4:1.1 --- /dev/null Mon Feb 22 03:54:25 2010 +++ src/share/man/man4/smscmon.4 Mon Feb 22 03:54:24 2010 @@ -0,0 +1,71 @@ +.\ $NetBSD: smscmon.4,v 1.1 2010/02/22 03:54:24 pgoyette Exp $ +.\ +.\ Copyright (c) 2009 Takahiro Hayashi +.\ All rights reserved. +.\ +.\ Redistribution and use in source and binary forms, with or without +.\ modification, are permitted provided that the following conditions +.\ are met: +.\ 1. Redistributions of source code must retain the above copyright +.\notice, this list of conditions and the following disclaimer. +.\ 2. Redistributions in binary form must reproduce the above copyright +.\notice, this list of conditions and the following disclaimer in the +.\documentation and/or other materials provided with the distribution. +.\ +.\ THIS SOFTWARE IS PROVIDED BY THE NETBSD FOUNDATION, INC. AND CONTRIBUTORS +.\ ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED +.\ TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR +.\ PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE FOUNDATION OR CONTRIBUTORS +.\ BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR +.\ CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF +.\ SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS +.\ INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN +.\ CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) +.\ ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE +.\ POSSIBILITY OF SUCH DAMAGE. +.\ +.Dd February 21, 2010 +.Dt SMSCMON 4 +.Os +.Sh NAME +.Nm smscmon +.Nd Standard Microsystems Corporation LPC47M192 Super I/O +.Sh SYNOPSIS +.Cd smscmon0 at iic? addr 0x2c +.Cd smscmon0 at iic? addr 0x2d +.Sh DESCRIPTION +The +.Nm +driver provides support for the hardware monitoring portion of the +.Tn Standard Microsystems Corporation +LPC47M192 and LPC47M997 Super I/O chips to be used with the +.Xr envsys 4 +API. +.Pp +The chip supports 11 sensor inputs: +.Bl -column Sensor Units Typical -offset indent +.It Sy Sensor Ta Sy Units Ta Sy Typical Use +.It Li +2.5V Ta uV DC Ta 2.5V Supply +.It Li Vccp Ta uV DC Ta CPU Vcore +.It Li +3.3V Ta uV DC Ta 3.3V Supply +.It Li +5V Ta uV DC Ta %5 Supply +.It Li +12V Ta uV DC Ta 12V Supply +.It Li Vcc Ta uV DC Ta Chip's supply voltage +.It Li +1.5V Ta uV DC Ta 1.5V Supply +.It Li +1.8V Ta uV DC Ta 1.8V Supply +.It Li Remote Temp1 Ta uK Ta CPU temperature +.It Li Ambient Temp Ta uK Ta Local chip temperature +.It Li Remote Temp2 Ta uK +.El +.Sh SEE ALSO +.Xr envsys 4 , +.Xr envstat 8 +.Sh HISTORY +The +.Nm +device appeared in +.Nx 6.0 . +.Sh AUTHOR +The +.Nm +driver was written by Takahiro Hayashi.
Re: src/share/man/man4 vs crash(8)
Module Name:src
Committed By: wiz
Date: Mon Feb 22 08:41:10 UTC 2010
Modified Files:
src/share/man/man4: ddb.4
Log Message:
Comment out crash(8) reference, per PR 10708, until a MI one exists.
Looks to me like we already have an MI crash(8):
{325} cd src/distrib/sets/lists/
{326} find . -name mi | xargs grep crash.0
./man/mi:./usr/share/man/cat8/crash.0 man-sysutil-catman
.cat
./man/mi:./usr/share/man/cat8/hp300/crash.0 man-sys-catman
.cat
./man/mi:./usr/share/man/cat8/vax/crash.0 man-sys-catman
.cat
{327} cd ../../../..
{328} ls src/usr.sbin/crash
CVS archcrash.c unsupported.c
Makefilecrash.8 extern.h
{329}
-
| Paul Goyette | PGP DSS Key fingerprint: | E-mail addresses: |
| Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com |
| Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net |
| Kernel Developer | | pgoyette at netbsd.org |
-
CVS commit: src/sys/arch
Module Name:src Committed By: pgoyette Date: Mon Feb 22 13:42:04 UTC 2010 Modified Files: src/sys/arch/amd64/conf: GENERIC src/sys/arch/i386/conf: ALL Log Message: Correct spelling of smscmon and add (commented out) to GENERICs To generate a diff of this commit: cvs rdiff -u -r1.268 -r1.269 src/sys/arch/amd64/conf/GENERIC cvs rdiff -u -r1.241 -r1.242 src/sys/arch/i386/conf/ALL Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/arch/i386/conf
Module Name:src Committed By: pgoyette Date: Mon Feb 22 17:27:05 UTC 2010 Modified Files: src/sys/arch/i386/conf: GENERIC Log Message: Forgot to add smscmon here... To generate a diff of this commit: cvs rdiff -u -r1.970 -r1.971 src/sys/arch/i386/conf/GENERIC Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/arch/i386/conf
Module Name:src Committed By: pgoyette Date: Mon Feb 22 17:27:05 UTC 2010 Modified Files: src/sys/arch/i386/conf: GENERIC Log Message: Forgot to add smscmon here... To generate a diff of this commit: cvs rdiff -u -r1.970 -r1.971 src/sys/arch/i386/conf/GENERIC Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/sys/arch/i386/conf/GENERIC diff -u src/sys/arch/i386/conf/GENERIC:1.970 src/sys/arch/i386/conf/GENERIC:1.971 --- src/sys/arch/i386/conf/GENERIC:1.970 Mon Feb 22 05:57:10 2010 +++ src/sys/arch/i386/conf/GENERIC Mon Feb 22 17:27:04 2010 @@ -1,4 +1,4 @@ -# $NetBSD: GENERIC,v 1.970 2010/02/22 05:57:10 ahoka Exp $ +# $NetBSD: GENERIC,v 1.971 2010/02/22 17:27:04 pgoyette Exp $ # # GENERIC machine description file # @@ -22,7 +22,7 @@ options INCLUDE_CONFIG_FILE # embed config file in kernel binary -#ident GENERIC-$Revision: 1.970 $ +#ident GENERIC-$Revision: 1.971 $ maxusers 64 # estimated number of users @@ -664,6 +664,10 @@ # SMSC LPC47B397 hardware monitor functions #smsc0 at isa? port 0x02e +# SMSC LPC47M192 hardware monitor +#smscmon* at iic? addr 0x2c +#smscmon* at iic? addr 0x2d # (alternate address) + # PC87366 hardware monitor #nsclpcsio* at isa? #gpio* at nsclpcsio?
CVS commit: src/sys/dev/i2c
Module Name:src Committed By: pgoyette Date: Tue Feb 23 00:13:06 UTC 2010 Modified Files: src/sys/dev/i2c: spdmem.c Log Message: Correct calculation and display of SDR DRAM speed. From OpenBSD. Fixes PR kern/42736 To generate a diff of this commit: cvs rdiff -u -r1.15 -r1.16 src/sys/dev/i2c/spdmem.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/dev/i2c
Module Name:src
Committed By: pgoyette
Date: Tue Feb 23 00:13:06 UTC 2010
Modified Files:
src/sys/dev/i2c: spdmem.c
Log Message:
Correct calculation and display of SDR DRAM speed. From OpenBSD.
Fixes PR kern/42736
To generate a diff of this commit:
cvs rdiff -u -r1.15 -r1.16 src/sys/dev/i2c/spdmem.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/dev/i2c/spdmem.c
diff -u src/sys/dev/i2c/spdmem.c:1.15 src/sys/dev/i2c/spdmem.c:1.16
--- src/sys/dev/i2c/spdmem.c:1.15 Sat May 9 17:32:27 2009
+++ src/sys/dev/i2c/spdmem.c Tue Feb 23 00:13:06 2010
@@ -1,4 +1,4 @@
-/* $NetBSD: spdmem.c,v 1.15 2009/05/09 17:32:27 pgoyette Exp $ */
+/* $NetBSD: spdmem.c,v 1.16 2010/02/23 00:13:06 pgoyette Exp $ */
/*
* Copyright (c) 2007 Nicolas Joly
@@ -35,7 +35,7 @@
*/
#include sys/cdefs.h
-__KERNEL_RCSID(0, $NetBSD: spdmem.c,v 1.15 2009/05/09 17:32:27 pgoyette Exp $);
+__KERNEL_RCSID(0, $NetBSD: spdmem.c,v 1.16 2010/02/23 00:13:06 pgoyette Exp $);
#include sys/param.h
#include sys/device.h
@@ -56,14 +56,15 @@
/* Routines for decoding spd data */
static void decode_edofpm(const struct sysctlnode *, device_t, struct spdmem *);
static void decode_rom(const struct sysctlnode *, device_t, struct spdmem *);
-static void decode_sdram(const struct sysctlnode *, device_t, struct spdmem *);
+static void decode_sdram(const struct sysctlnode *, device_t, struct spdmem *,
+ int);
static void decode_ddr(const struct sysctlnode *, device_t, struct spdmem *);
static void decode_ddr2(const struct sysctlnode *, device_t, struct spdmem *);
static void decode_ddr3(const struct sysctlnode *, device_t, struct spdmem *);
static void decode_fbdimm(const struct sysctlnode *, device_t, struct spdmem *);
static void decode_size_speed(const struct sysctlnode *, int, int, int, int,
- bool, const char *);
+ bool, const char *, int);
static void decode_voltage_refresh(device_t, struct spdmem *);
CFATTACH_DECL_NEW(spdmem, sizeof(struct spdmem_softc),
@@ -390,7 +391,7 @@
decode_rom(node, self, s);
break;
case SPDMEM_MEMTYPE_SDRAM:
- decode_sdram(node, self, s);
+ decode_sdram(node, self, s, spd_len);
break;
case SPDMEM_MEMTYPE_DDRSDRAM:
decode_ddr(node, self, s);
@@ -437,7 +438,8 @@
static void
decode_size_speed(const struct sysctlnode *node, int dimm_size, int cycle_time,
- int d_clk, int bits, bool round, const char *ddr_type_string)
+ int d_clk, int bits, bool round, const char *ddr_type_string,
+ int speed)
{
int p_clk;
@@ -462,9 +464,14 @@
* Calculate p_clk first, since for DDR3 we need maximum significance.
* DDR3 rating is not rounded to a multiple of 100. This results in
* cycle_time of 1.5ns displayed as PC3-10666.
+ *
+ * For SDRAM, the speed is provided by the caller so we use it.
*/
d_clk *= 1000 * 1000;
- p_clk = (d_clk * bits) / 8 / cycle_time;
+ if (speed)
+ p_clk = speed;
+ else
+ p_clk = (d_clk * bits) / 8 / cycle_time;
d_clk = ((d_clk + cycle_time / 2) ) / cycle_time;
if (round) {
if ((p_clk % 100) = 50)
@@ -519,8 +526,9 @@
}
static void
-decode_sdram(const struct sysctlnode *node, device_t self, struct spdmem *s) {
- int dimm_size, cycle_time, bits, tAA, i;
+decode_sdram(const struct sysctlnode *node, device_t self, struct spdmem *s,
+ int spd_len) {
+ int dimm_size, cycle_time, bits, tAA, i, speed, freq;
aprint_normal(%s, %s, ,
(s-sm_sdr.sdr_mod_attrs SPDMEM_SDR_MASK_REG)?
@@ -536,7 +544,30 @@
bits = le16toh(s-sm_sdr.sdr_datawidth);
if (s-sm_config == 1 || s-sm_config == 2)
bits -= 8;
- decode_size_speed(node, dimm_size, cycle_time, 1, bits, TRUE, PC);
+
+ /* Calculate speed here - from OpenBSD */
+ if (spd_len = 128)
+ freq = ((uint8_t *)s)[126];
+ else
+ freq = 0;
+ switch (freq) {
+ /*
+ * Must check cycle time since some PC-133 DIMMs
+ * actually report PC-100
+ */
+ case 100:
+ case 133:
+ if (cycle_time 8000)
+ speed = 133;
+ else
+ speed = 100;
+ break;
+ case 0x66: /* Legacy DIMMs use _hex_ 66! */
+ default:
+ speed = 66;
+ }
+ decode_size_speed(node, dimm_size, cycle_time, 1, bits, FALSE, PC,
+ speed);
aprint_verbose_dev(self,
%d rows, %d cols, %d banks, %d banks/chip, %d.%dns cycle time\n,
@@ -573,7 +604,7 @@
bits = le16toh(s-sm_ddr.ddr_datawidth);
if (s-sm_config == 1 || s-sm_config == 2)
bits -= 8;
- decode_size_speed(node, dimm_size, cycle_time, 2, bits, TRUE, PC);
+ decode_size_speed(node, dimm_size, cycle_time, 2, bits, TRUE, PC, 0);
aprint_verbose_dev(self,
%d rows, %d cols, %d ranks, %d banks/chip, %d.%dns cycle time\n,
@@ -617,7 +648,7 @@
bits = s-sm_ddr2.ddr2_datawidth;
if ((s-sm_config 0x03) != 0)
bits -= 8;
- decode_size_speed(node, dimm_size, cycle_time, 2, bits, TRUE, PC2);
+ decode_size_speed(node, dimm_size, cycle_time, 2, bits, TRUE, PC2, 0);
aprint_verbose_dev(self,
%d rows, %d
CVS commit: src/sys/dev/i2c
Module Name:src Committed By: pgoyette Date: Wed Feb 24 23:37:45 UTC 2010 Modified Files: src/sys/dev/i2c: dbcool.c dbcool_var.h Log Message: Fix handling of 6bit VID register (6th bit takes place of 12VIn sensor). Move VID out of sysctl tree - make it a separate sensor of type INTEGER. Clean-up some of the chip-descriptors. To generate a diff of this commit: cvs rdiff -u -r1.15 -r1.16 src/sys/dev/i2c/dbcool.c cvs rdiff -u -r1.8 -r1.9 src/sys/dev/i2c/dbcool_var.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/share/man/man4
Module Name:src Committed By: pgoyette Date: Thu Feb 25 02:19:28 UTC 2010 Modified Files: src/share/man/man4: dbcool.4 Log Message: Update sensor list for VID sensor. XXX I don't think this is sufficiently large change to bump the date. To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.5 src/share/man/man4/dbcool.4 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/share/man/man9
Module Name:src Committed By: pgoyette Date: Thu Feb 25 03:11:25 UTC 2010 Modified Files: src/share/man/man9: sysmon_envsys.9 Log Message: Update for recent changes to data structures. To generate a diff of this commit: cvs rdiff -u -r1.31 -r1.32 src/share/man/man9/sysmon_envsys.9 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/dev/i2c
Module Name:src Committed By: pgoyette Date: Fri Feb 26 18:16:18 UTC 2010 Modified Files: src/sys/dev/i2c: dbcool.c dbcool_var.h Log Message: Disable DBCOOL_DEBUG by default, and make it compile that way. To generate a diff of this commit: cvs rdiff -u -r1.16 -r1.17 src/sys/dev/i2c/dbcool.c cvs rdiff -u -r1.9 -r1.10 src/sys/dev/i2c/dbcool_var.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/dev/i2c
Module Name:src
Committed By: pgoyette
Date: Fri Feb 26 18:16:18 UTC 2010
Modified Files:
src/sys/dev/i2c: dbcool.c dbcool_var.h
Log Message:
Disable DBCOOL_DEBUG by default, and make it compile that way.
To generate a diff of this commit:
cvs rdiff -u -r1.16 -r1.17 src/sys/dev/i2c/dbcool.c
cvs rdiff -u -r1.9 -r1.10 src/sys/dev/i2c/dbcool_var.h
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/dev/i2c/dbcool.c
diff -u src/sys/dev/i2c/dbcool.c:1.16 src/sys/dev/i2c/dbcool.c:1.17
--- src/sys/dev/i2c/dbcool.c:1.16 Wed Feb 24 23:37:45 2010
+++ src/sys/dev/i2c/dbcool.c Fri Feb 26 18:16:18 2010
@@ -1,4 +1,4 @@
-/* $NetBSD: dbcool.c,v 1.16 2010/02/24 23:37:45 pgoyette Exp $ */
+/* $NetBSD: dbcool.c,v 1.17 2010/02/26 18:16:18 pgoyette Exp $ */
/*-
* Copyright (c) 2008 The NetBSD Foundation, Inc.
@@ -49,7 +49,7 @@
*/
#include sys/cdefs.h
-__KERNEL_RCSID(0, $NetBSD: dbcool.c,v 1.16 2010/02/24 23:37:45 pgoyette Exp $);
+__KERNEL_RCSID(0, $NetBSD: dbcool.c,v 1.17 2010/02/26 18:16:18 pgoyette Exp $);
#include sys/param.h
#include sys/systm.h
@@ -1459,7 +1459,9 @@
{
struct dbcool_softc *sc = device_private(self);
const struct sysctlnode *me = NULL;
+#ifdef DBCOOL_DEBUG
struct sysctlnode *node = NULL;
+#endif
uint8_t cfg_val, cfg_reg;
int ro_flag, rw_flag, ret, error;
Index: src/sys/dev/i2c/dbcool_var.h
diff -u src/sys/dev/i2c/dbcool_var.h:1.9 src/sys/dev/i2c/dbcool_var.h:1.10
--- src/sys/dev/i2c/dbcool_var.h:1.9 Wed Feb 24 23:37:45 2010
+++ src/sys/dev/i2c/dbcool_var.h Fri Feb 26 18:16:18 2010
@@ -1,4 +1,4 @@
-/* $NetBSD: dbcool_var.h,v 1.9 2010/02/24 23:37:45 pgoyette Exp $ */
+/* $NetBSD: dbcool_var.h,v 1.10 2010/02/26 18:16:18 pgoyette Exp $ */
/*-
* Copyright (c) 2008 The NetBSD Foundation, Inc.
@@ -36,12 +36,12 @@
#ifndef DBCOOLVAR_H
#define DBCOOLVAR_H
-#define DBCOOL_DEBUG
/*
+#define DBCOOL_DEBUG
*/
#include sys/cdefs.h
-__KERNEL_RCSID(0, $NetBSD: dbcool_var.h,v 1.9 2010/02/24 23:37:45 pgoyette Exp $);
+__KERNEL_RCSID(0, $NetBSD: dbcool_var.h,v 1.10 2010/02/26 18:16:18 pgoyette Exp $);
#include dev/i2c/i2cvar.h
CVS commit: src/sys
Module Name:src Committed By: pgoyette Date: Sun Feb 28 20:04:04 UTC 2010 Modified Files: src/sys/dev/sysmon: sysmonvar.h src/sys/sys: envsys.h Log Message: Move definitions of internal data structures and flag bits to avoid exposing them to user-land. To generate a diff of this commit: cvs rdiff -u -r1.31 -r1.32 src/sys/dev/sysmon/sysmonvar.h cvs rdiff -u -r1.30 -r1.31 src/sys/sys/envsys.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/dev/i2c
Module Name:src Committed By: pgoyette Date: Mon Mar 1 03:14:49 UTC 2010 Modified Files: src/sys/dev/i2c: dbcool.c dbcool_var.h Log Message: Now that sysmon_envsys(8) has learned how to retrieve and update sensor limit values from the device driver, remove the high_limit and low_limit entries from the hw.dbcool#.sensor sysctl(8) tree. These limits are now directly accessible via envstat(8). Simplify the remaining code somewhat. No objections raised on either tech-kern@ or current-users@ XXX The fan controllers's parameters (including those that are tied to XXX temperature sensors) are still in sysctl, since there isn't any clean XXX way to implement the fan controllers in sysmon_envsys yet. It is on XXX my To-Do list... To generate a diff of this commit: cvs rdiff -u -r1.17 -r1.18 src/sys/dev/i2c/dbcool.c cvs rdiff -u -r1.10 -r1.11 src/sys/dev/i2c/dbcool_var.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/dev/i2c
Module Name:src
Committed By: pgoyette
Date: Mon Mar 1 03:14:49 UTC 2010
Modified Files:
src/sys/dev/i2c: dbcool.c dbcool_var.h
Log Message:
Now that sysmon_envsys(8) has learned how to retrieve and update sensor
limit values from the device driver, remove the high_limit and low_limit
entries from the hw.dbcool#.sensor sysctl(8) tree. These limits are
now directly accessible via envstat(8). Simplify the remaining code
somewhat.
No objections raised on either tech-kern@ or current-users@
XXX The fan controllers's parameters (including those that are tied to
XXX temperature sensors) are still in sysctl, since there isn't any clean
XXX way to implement the fan controllers in sysmon_envsys yet. It is on
XXX my To-Do list...
To generate a diff of this commit:
cvs rdiff -u -r1.17 -r1.18 src/sys/dev/i2c/dbcool.c
cvs rdiff -u -r1.10 -r1.11 src/sys/dev/i2c/dbcool_var.h
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/dev/i2c/dbcool.c
diff -u src/sys/dev/i2c/dbcool.c:1.17 src/sys/dev/i2c/dbcool.c:1.18
--- src/sys/dev/i2c/dbcool.c:1.17 Fri Feb 26 18:16:18 2010
+++ src/sys/dev/i2c/dbcool.c Mon Mar 1 03:14:49 2010
@@ -1,4 +1,4 @@
-/* $NetBSD: dbcool.c,v 1.17 2010/02/26 18:16:18 pgoyette Exp $ */
+/* $NetBSD: dbcool.c,v 1.18 2010/03/01 03:14:49 pgoyette Exp $ */
/*-
* Copyright (c) 2008 The NetBSD Foundation, Inc.
@@ -49,7 +49,7 @@
*/
#include sys/cdefs.h
-__KERNEL_RCSID(0, $NetBSD: dbcool.c,v 1.17 2010/02/26 18:16:18 pgoyette Exp $);
+__KERNEL_RCSID(0, $NetBSD: dbcool.c,v 1.18 2010/03/01 03:14:49 pgoyette Exp $);
#include sys/param.h
#include sys/systm.h
@@ -78,6 +78,25 @@
static int dbcool_read_temp(struct dbcool_softc *, uint8_t, bool);
static int dbcool_read_volt(struct dbcool_softc *, uint8_t, int, bool);
+/* Sensor get/set limit functions */
+static void dbcool_get_limits(struct sysmon_envsys *, envsys_data_t *,
+ sysmon_envsys_lim_t *, uint32_t *);
+static void dbcool_get_temp_limits(struct dbcool_softc *, int,
+ sysmon_envsys_lim_t *, uint32_t *);
+static void dbcool_get_volt_limits(struct dbcool_softc *, int,
+ sysmon_envsys_lim_t *, uint32_t *);
+static void dbcool_get_fan_limits(struct dbcool_softc *, int,
+ sysmon_envsys_lim_t *, uint32_t *);
+
+static void dbcool_set_limits(struct sysmon_envsys *, envsys_data_t *,
+ sysmon_envsys_lim_t *, uint32_t *);
+static void dbcool_set_temp_limits(struct dbcool_softc *, int,
+ sysmon_envsys_lim_t *, uint32_t *);
+static void dbcool_set_volt_limits(struct dbcool_softc *, int,
+ sysmon_envsys_lim_t *, uint32_t *);
+static void dbcool_set_fan_limits(struct dbcool_softc *, int,
+ sysmon_envsys_lim_t *, uint32_t *);
+
/* SYSCTL Helpers */
static int sysctl_dbcool_temp(SYSCTLFN_PROTO);
static int sysctl_adm1030_temp(SYSCTLFN_PROTO);
@@ -85,18 +104,14 @@
static int sysctl_dbcool_duty(SYSCTLFN_PROTO);
static int sysctl_dbcool_behavior(SYSCTLFN_PROTO);
static int sysctl_dbcool_slope(SYSCTLFN_PROTO);
-static int sysctl_dbcool_volt_limit(SYSCTLFN_PROTO);
-static int sysctl_dbcool_temp_limit(SYSCTLFN_PROTO);
-static int sysctl_dbcool_fan_limit(SYSCTLFN_PROTO);
static int sysctl_dbcool_thyst(SYSCTLFN_PROTO);
/* Set-up subroutines */
-static void dbcool_setup_controllers(struct dbcool_softc *,
- const struct sysctlnode *, int, int);
-static int dbcool_setup_sensors(struct dbcool_softc *,
- const struct sysctlnode *, int, int);
-static int dbcool_attach_sensor(struct dbcool_softc *,
- const struct sysctlnode *, int, int (*)(SYSCTLFN_PROTO));
+static void dbcool_setup_controllers(struct dbcool_softc *);
+static int dbcool_setup_sensors(struct dbcool_softc *);
+static int dbcool_attach_sensor(struct dbcool_softc *, int);
+static int dbcool_attach_temp_control(struct dbcool_softc *, int,
+ struct chip_id *);
#ifdef DBCOOL_DEBUG
static int sysctl_dbcool_reg_select(SYSCTLFN_PROTO);
@@ -1211,141 +1226,6 @@
}
static int
-sysctl_dbcool_volt_limit(SYSCTLFN_ARGS)
-{
- struct sysctlnode node;
- struct dbcool_softc *sc;
- int reg, error;
- int nom, sensor_index;
- int64_t val, newval;
- uint8_t chipreg, newreg;
-
- node = *rnode;
- sc = (struct dbcool_softc *)node.sysctl_data;
- chipreg = node.sysctl_num 0xff;
-
- /*
- * Retrieve the nominal value for the voltage sensor
- */
- sensor_index = (node.sysctl_num 8 ) 0xff;
- nom = nominal_voltages[sc-sc_dc.dc_chip-table[sensor_index].nom_volt_index];
- if (nom 0)
- nom = dbcool_supply_voltage(sc);
-
- /*
- * Use int64_t for calculation to avoid overflow
- */
- val = sc-sc_dc.dc_readreg(sc-sc_dc, chipreg);
- val *= nom;
- val /= 0xc0; /* values are scaled so 0xc0 == nominal voltage */
- reg = val;
- node.sysctl_data = reg;
- error = sysctl_lookup(SYSCTLFN_CALL(node));
-
- if (error || newp == NULL)
- return error;
-
- /*
- * We were asked to update the value, so scale it and sanity
- * check before writing
- */
- if
CVS commit: src/share/man/man4
Module Name:src Committed By: pgoyette Date: Mon Mar 1 03:15:16 UTC 2010 Modified Files: src/share/man/man4: dbcool.4 Log Message: Update for changes in sensor limit handling To generate a diff of this commit: cvs rdiff -u -r1.6 -r1.7 src/share/man/man4/dbcool.4 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/dev/acpi
Module Name:src Committed By: pgoyette Date: Thu Mar 4 13:07:01 UTC 2010 Modified Files: src/sys/dev/acpi: smbus_acpi.c Log Message: Fix this correctly. Thanks jruoho@ To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.5 src/sys/dev/acpi/smbus_acpi.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/dev/acpi
Module Name:src Committed By: pgoyette Date: Thu Mar 4 13:07:01 UTC 2010 Modified Files: src/sys/dev/acpi: smbus_acpi.c Log Message: Fix this correctly. Thanks jruoho@ To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.5 src/sys/dev/acpi/smbus_acpi.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/sys/dev/acpi/smbus_acpi.c diff -u src/sys/dev/acpi/smbus_acpi.c:1.4 src/sys/dev/acpi/smbus_acpi.c:1.5 --- src/sys/dev/acpi/smbus_acpi.c:1.4 Thu Mar 4 03:10:18 2010 +++ src/sys/dev/acpi/smbus_acpi.c Thu Mar 4 13:07:01 2010 @@ -1,4 +1,4 @@ -/* $NetBSD: smbus_acpi.c,v 1.4 2010/03/04 03:10:18 pgoyette Exp $ */ +/* $NetBSD: smbus_acpi.c,v 1.5 2010/03/04 13:07:01 pgoyette Exp $ */ /*- * Copyright (c) 2009 The NetBSD Foundation, Inc. @@ -36,7 +36,10 @@ */ #include sys/cdefs.h -__KERNEL_RCSID(0, $NetBSD: smbus_acpi.c,v 1.4 2010/03/04 03:10:18 pgoyette Exp $); +__KERNEL_RCSID(0, $NetBSD: smbus_acpi.c,v 1.5 2010/03/04 13:07:01 pgoyette Exp $); + +#define _COMPONENT ACPI_RESOURCE_COMPONENT +ACPI_MODULE_NAME (smbus_acpi) #include sys/param.h #include sys/systm.h @@ -163,7 +166,7 @@ } done: if (smi_buf.Pointer != NULL) - AcpiOsFree(smi_buf.Pointer); + ACPI_FREE(smi_buf.Pointer); return r; } @@ -212,7 +215,7 @@ } } if (smi_buf.Pointer != NULL) - AcpiOsFree(smi_buf.Pointer); + ACPI_FREE(smi_buf.Pointer); /* Install notify handler if possible */ rv = AcpiInstallNotifyHandler(sc-sc_devnode-ad_handle, @@ -419,7 +422,7 @@ } } if (smbuf.Pointer) - AcpiOsFree(smbuf.Pointer); + ACPI_FREE(smbuf.Pointer); return r; } @@ -464,7 +467,7 @@ } done: if (alert.Pointer != NULL) - AcpiOsFree(alert.Pointer); + ACPI_FREE(alert.Pointer); } while (status == 0); }
CVS commit: src/sys/dev/acpi
Module Name:src Committed By: pgoyette Date: Thu Mar 4 13:11:15 UTC 2010 Modified Files: src/sys/dev/acpi: smbus_acpi.c Log Message: This really should be ACPI_BUS_COMPONENT Maybe I should stay out the acpi stuff? :) To generate a diff of this commit: cvs rdiff -u -r1.5 -r1.6 src/sys/dev/acpi/smbus_acpi.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/dev/acpi
Module Name:src Committed By: pgoyette Date: Thu Mar 4 13:11:15 UTC 2010 Modified Files: src/sys/dev/acpi: smbus_acpi.c Log Message: This really should be ACPI_BUS_COMPONENT Maybe I should stay out the acpi stuff? :) To generate a diff of this commit: cvs rdiff -u -r1.5 -r1.6 src/sys/dev/acpi/smbus_acpi.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/sys/dev/acpi/smbus_acpi.c diff -u src/sys/dev/acpi/smbus_acpi.c:1.5 src/sys/dev/acpi/smbus_acpi.c:1.6 --- src/sys/dev/acpi/smbus_acpi.c:1.5 Thu Mar 4 13:07:01 2010 +++ src/sys/dev/acpi/smbus_acpi.c Thu Mar 4 13:11:14 2010 @@ -1,4 +1,4 @@ -/* $NetBSD: smbus_acpi.c,v 1.5 2010/03/04 13:07:01 pgoyette Exp $ */ +/* $NetBSD: smbus_acpi.c,v 1.6 2010/03/04 13:11:14 pgoyette Exp $ */ /*- * Copyright (c) 2009 The NetBSD Foundation, Inc. @@ -36,9 +36,9 @@ */ #include sys/cdefs.h -__KERNEL_RCSID(0, $NetBSD: smbus_acpi.c,v 1.5 2010/03/04 13:07:01 pgoyette Exp $); +__KERNEL_RCSID(0, $NetBSD: smbus_acpi.c,v 1.6 2010/03/04 13:11:14 pgoyette Exp $); -#define _COMPONENT ACPI_RESOURCE_COMPONENT +#define _COMPONENT ACPI_BUS_COMPONENT ACPI_MODULE_NAME (smbus_acpi) #include sys/param.h
Re: CVS commit: src/sys/dev/acpi
On Thu, 4 Mar 2010, Jukka Ruohonen wrote: Well, this is wrong in the sense that the _COMPONENT definition was incorrect to begin with, and in the sense that we have explicitly tried to recently add the _COMPONENT definitions. Also: now it does BadThings(tm) if the memory tracking of ACPICA is enabled. The right solution is to e.g. #define _COMPONENT ACPI_BUS_COMPONENT. The components that can be used are defined in dev/acpi/acpireg.h. Yes - I've just fixed this. I wan't sure if BUS or RESOURCE was the correct component to use... Thanks. - | Paul Goyette | PGP DSS Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com | | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | -
CVS commit: src/sys/dev/acpi
Module Name:src Committed By: pgoyette Date: Fri Mar 5 12:44:16 UTC 2010 Modified Files: src/sys/dev/acpi: acpi_tz.c Log Message: As pointed out by Rhialto, degrees Kelvin is redundant. So fix a couple of comments related to converstion between Kelvin and degC. To generate a diff of this commit: cvs rdiff -u -r1.59 -r1.60 src/sys/dev/acpi/acpi_tz.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/dev/acpi
Module Name:src Committed By: pgoyette Date: Fri Mar 5 12:44:16 UTC 2010 Modified Files: src/sys/dev/acpi: acpi_tz.c Log Message: As pointed out by Rhialto, degrees Kelvin is redundant. So fix a couple of comments related to converstion between Kelvin and degC. To generate a diff of this commit: cvs rdiff -u -r1.59 -r1.60 src/sys/dev/acpi/acpi_tz.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/sys/dev/acpi/acpi_tz.c diff -u src/sys/dev/acpi/acpi_tz.c:1.59 src/sys/dev/acpi/acpi_tz.c:1.60 --- src/sys/dev/acpi/acpi_tz.c:1.59 Thu Feb 18 14:10:15 2010 +++ src/sys/dev/acpi/acpi_tz.c Fri Mar 5 12:44:16 2010 @@ -1,4 +1,4 @@ -/* $NetBSD: acpi_tz.c,v 1.59 2010/02/18 14:10:15 pgoyette Exp $ */ +/* $NetBSD: acpi_tz.c,v 1.60 2010/03/05 12:44:16 pgoyette Exp $ */ /* * Copyright (c) 2003 Jared D. McNeill jmcne...@invisible.ca @@ -30,7 +30,7 @@ */ #include sys/cdefs.h -__KERNEL_RCSID(0, $NetBSD: acpi_tz.c,v 1.59 2010/02/18 14:10:15 pgoyette Exp $); +__KERNEL_RCSID(0, $NetBSD: acpi_tz.c,v 1.60 2010/03/05 12:44:16 pgoyette Exp $); #include sys/param.h #include sys/systm.h @@ -63,7 +63,7 @@ /* constants */ #define ATZ_TZP_RATE 300 /* default if no _TZP CM present (30 secs) */ #define ATZ_NLEVELS 10 /* number of cooling levels, from ACPI spec */ -#define ATZ_ZEROC 2732 /* 0C in tenths degrees Kelvin */ +#define ATZ_ZEROC 2732 /* 0C, measured in 0.1 Kelvin */ #define ATZ_TMP_INVALID 0x /* invalid temperature */ #define ATZ_ZONE_EXPIRE 9000 /* zone info refetch interval (15min) */ @@ -75,8 +75,8 @@ /* * ACPI Temperature Zone information. Note all temperatures are reported - * in tenths of degrees Kelvin, and that the ACPI specification assumes - * that K = C + 273.2 rather than the nominal 273.15 used by envsys(4). + * in 0.1 Kelvin, and that the ACPI specification assumes that + * K = C + 273.2 rather than the nominal 273.15 used by envsys(4). * So define an appropriate conversion. */
Re: CVS commit: src/sys/dev/usb
Module Name:src Committed By: enami Date: Mon Mar 15 03:27:49 UTC 2010 Modified Files: src/sys/dev/usb: uyurex.c Log Message: The monitor struct member is gone. Make this compile again. Hmmm, wonder how I missed that one. Thanks for catching. - | Paul Goyette | PGP DSS Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com | | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | -
Re: CVS commit: src/sys/dev/acpi
On Sat, 3 Apr 2010, Christoph Egger wrote: On 03.04.10 18:29, Jukka Ruohonen wrote: Module Name:src Committed By: jruoho Date: Sat Apr 3 16:29:22 UTC 2010 Modified Files: src/sys/dev/acpi: acpi_bat.c Log Message: Update the limits when a change from absent to present is detected. Does acpi_bat also detect the other way around ? I.e. when you have multiple batteries you can unplug a full charged battery and then re-plug an empty one for charging. When the battery is absent, the limit values don't make much difference! But yes, the scenario you propose will work - nothing happens when the old (full) battery is removed, but when you insert a new (empty) one, the limits will get set based on the new battery, and its state will be monitored. Christoph - | Paul Goyette | PGP DSS Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com | | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | -
Re: CVS commit: src/share/man/man9
On Tue, 4 May 2010, Izumi Tsutsui wrote: Modified Files: src/share/man/man9: byteorder.9 Log Message: Reference bswap(3). Improvements in the HISTORY section. : cvs rdiff -u -r1.4 -r1.5 src/share/man/man9/byteorder.9 -These functions were introduced to handle PCI bus master devices which assumed -host's memory used to pass integer parameters via DMA transfer was -always little endian even on big endian systems. : +The functions were originally introduced to handle +.Tn PCI +bus master devices, which assumed little endian byte order in +.Tn DMA +transfers, even on big endian systems. There are a few PCI bus master devices that are big endian aware (epic(4) for example), so I don't think it's appropriate to add commas around the which clause. I agree that the first comma should go, but the second one (before even) should remain. - | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com| | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | -
Re: CVS commit: src/sys
Yeah, in retrospect that would probably have been a simpler course to
follow.
I'd be happy to re-work this if you want, but it will probably take a
couple days - the day job needs some attention right now.
On Tue, 25 May 2010, David Young wrote:
On Mon, May 24, 2010 at 08:29:49PM +, Paul Goyette wrote:
Module Name:src
Committed By: pgoyette
Date: Mon May 24 20:29:49 UTC 2010
Modified Files:
src/sys/arch/i386/pci: gcscehci.c
src/sys/dev/cardbus: ehci_cardbus.c ohci_cardbus.c uhci_cardbus.c
src/sys/dev/pci: azalia.c cs4280.c ehci_pci.c ohci_pci.c uhci_pci.c
Log Message:
Update all callers of the pci_find{vendor,product} routines to now call
these routines through their global pointers.
It was not necessary to change all of the pci_find{vendor,product}
calls, was it? You could have tucked the call through
pci_find{vendor,product}_vec into pci_find{vendor,product}() like this:
const char *
pci_findvendor(pcireg_t id)
{
return (*pci_findvendor_vec)(id);
}
Dave
--
David Young OJC Technologies
dyo...@ojctech.com Urbana, IL * (217) 278-3933
-
| Paul Goyette | PGP Key fingerprint: | E-mail addresses: |
| Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com|
| Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net |
| Kernel Developer | | pgoyette at netbsd.org |
-
re: CVS commit: src/sys
On Tue, 25 May 2010, matthew green wrote: Yeah, in retrospect that would probably have been a simpler course to follow. I'd be happy to re-work this if you want, but it will probably take a couple days - the day job needs some attention right now. please do this when you have time. thanks! Will try for next 24 hours. (this change also should have bumped the kernel version, right, since pci_findvendor() died. but if you fix it really soon then perhaps it isn't necessary...) Hmmm, yeah. - | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com| | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | -
Re: CVS commit: src
Thanks, John, for all the help and feedback. I will go back through all of the xxxverbose modules in the next few days and make the suggested updates. Some answers to your questions: } @@ -106,7 +107,12 @@ } KASSERT(ifattr !strcmp(ifattr, pci)); } KASSERT(locators); } } + pci_verbose_ctl(true); /* Try to load the pciverbose module */ } + Does this only cover boot time, or will it also cover bus rescans (i.e. drvctl -r)? I hadn't considered 'drvtl -r'. I will investigate if this covers it. } + return; } } } -#endif } - return (NULL); } + if (--loaded == 0) } + module_unload(pciverbose); There is no need to forcibly unload the module. Let the MODULAR subsystem and/or administrator handle this. I guess I'm still not clear on what determines if the MODULAR subsystem will actually unload a module. I will go back and re-re-read the code. - | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com| | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | -
RE: CVS commit: xsrc/external/mit/libX11/dist/man
Module Name:xsrc Committed By: joerg Date: Wed Jun 2 20:38:54 UTC 2010 Modified Files: xsrc/external/mit/libX11/dist/man: XCreateGC.man Log Message: Avoid .TS H and .TH for now as it doesn't alter the output in this case and conflicts with the header check from mandoc. Having somewhat working HTML output is more useful. Unfortyunately this is still not quite working correctly. With this update I still get #format libX11/XCreateGC.html3 /build/netbsd-local/tools/x86_64/amd64/bin/nbmandoc -Thtml -Oman=../html%S/%N.html -Ostyle=../style.css XCreateGC.3 XCreateGC.html3.tmp mv XCreateGC.html3.tmp XCreateGC.html3 XCreateGC.3:144:2: argument count wrong, violates syntax: line arguments = 5 (have 6) *** [XCreateGC.html3] Error code 1 - | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com| | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | -
Re: CVS commit: src/lib/libc
Yup, this is failing on port-amd64, too: In file included from /build/netbsd-local/src/tools/mklocale/../../usr.bin/mklocale/lex.l:55: /build/netbsd-local/src/lib/libc/locale/runetype_file.h:42:28: error: sys/ctype_bits.h: No such file or directory In file included from /build/netbsd-local/src/tools/mklocale/../../usr.bin/mklocale/lex.l:55:/build/netbsd-local/src/lib/libc/locale/runetype_file.h: In function '_runetype_to_ctype': /build/netbsd-local/src/lib/libc/locale/runetype_file.h:91: error: '_U' undeclared (first use in this function) /build/netbsd-local/src/lib/libc/locale/runetype_file.h:91: error: (Each undeclared identifier is reported only once /build/netbsd-local/src/lib/libc/locale/runetype_file.h:91: error: for each function it appears in.) /build/netbsd-local/src/lib/libc/locale/runetype_file.h:93: error: '_L' undeclared (first use in this function) /build/netbsd-local/src/lib/libc/locale/runetype_file.h:95: error: '_N' undeclared (first use in this function) ... On Sat, 19 Jun 2010, Jeff Rizzo wrote: This commit seems to have broken the build. It's failing when building 'tools/mklocale'. In file included from /Users/riz/Documents/code/netbsd/src/tools/mklocale/../../usr.bin/mklocale/yacc.y:63: /Users/riz/Documents/code/netbsd/src/lib/libc/locale/runetype_file.h:42:28: error: sys/ctype_bits.h: No such file or directory I appreciate the work on locale, but it seems like it would be a good idea to run a full build before making commits to locale support, as it affects so many different things... +j On 6/19/10 6:26 AM, Takehiko NOZAKI wrote: Module Name:src Committed By: tnozaki Date: Sat Jun 19 13:26:52 UTC 2010 Modified Files: src/lib/libc/citrus: citrus_lc_ctype.c src/lib/libc/locale: Makefile.inc bsdctype.c bsdctype_local.h global_locale.c localeio.c localeio.h localeio_lc_ctype.c rune.c runetable.c runetype_file.h runetype_local.h Removed Files: src/lib/libc/locale: runeglue.c Log Message: 1. refactoring new locale-db(RuneCT10) loading method with mmap(2). 2. remove unused field from _RuneLocale. 3. localeio(CITRUS=no) can read new locale-db(RuneCT10) now. To generate a diff of this commit: cvs rdiff -u -r1.8 -r1.9 src/lib/libc/citrus/citrus_lc_ctype.c cvs rdiff -u -r1.57 -r1.58 src/lib/libc/locale/Makefile.inc cvs rdiff -u -r1.7 -r1.8 src/lib/libc/locale/bsdctype.c cvs rdiff -u -r1.1 -r1.2 src/lib/libc/locale/bsdctype_local.h \ src/lib/libc/locale/runetype_file.h cvs rdiff -u -r1.10 -r1.11 src/lib/libc/locale/global_locale.c \ src/lib/libc/locale/runetype_local.h cvs rdiff -u -r1.4 -r1.5 src/lib/libc/locale/localeio.c cvs rdiff -u -r1.3 -r1.4 src/lib/libc/locale/localeio.h cvs rdiff -u -r1.5 -r1.6 src/lib/libc/locale/localeio_lc_ctype.c cvs rdiff -u -r1.38 -r1.39 src/lib/libc/locale/rune.c cvs rdiff -u -r1.20 -r0 src/lib/libc/locale/runeglue.c cvs rdiff -u -r1.26 -r1.27 src/lib/libc/locale/runetable.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. - | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com| | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | -
Re: CVS commit: src/lib/libc
On Sun, 20 Jun 2010, Izumi Tsutsui wrote: What's your host? Probably it won't fail on -current hosts and it's too strict to test builds on multiple platforms/OSes/versions before any commits... Failing for me on a 5.99.30 amd64... When was userland updated? sys/ctype_bits.h has been added on 2010/06/01. My installed userland in from May 2nd. But isn't the whole point of building host tools to make sure that we DON'T depend on the installed userland? - | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com| | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | -
Re: CVS commit: src/sys/dev/usb
Yes - good catch. I just fixed it. Thanks for noticing! On Wed, 23 Jun 2010, Christoph Egger wrote: On 22.06.10 23:30, Paul Goyette wrote: Module Name:src Committed By: pgoyette Date: Tue Jun 22 21:30:55 UTC 2010 Modified Files: src/sys/dev/usb: if_axe.c Log Message: Make sure we unlock before exit. @@ -350,6 +350,7 @@ allmulti: rxmode |= AXE_RXCMD_ALLMULTI; axe_cmd(sc, AXE_CMD_RXCTL_WRITE, 0, rxmode, NULL); + axe_lock_mii(sc); According to your commit log, you mean axe_unlock_mii() here, don't you? return; } else rxmode = ~AXE_RXCMD_ALLMULTI; - | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com| | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | -
Re: CVS commit: src/sys
On Fri, 25 Jun 2010, Izumi Tsutsui wrote: Module Name:src Committed By: tsutsui Date: Fri Jun 25 15:10:43 UTC 2010 Modified Files: src/sys/kern: init_main.c subr_autoconf.c src/sys/sys: device.h Log Message: Add config_mountroot(9), which defers device configuration after mountroot(), like config_interrupt(9) that defers configuration after interrupts are enabled. This will be used for devices that require firmware loaded from the root file system by firmload(9) to complete device initialization (getting MAC address etc). This could also possibly help us move forward with modularizing some device drivers which might need to be loaded from the file system. - | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com| | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | -
Re: CVS commit: src/external/cddl/osnet/dist/uts/common/dtrace
On Sun, 22 Aug 2010, Christos Zoulas wrote: Module Name:src Committed By: christos Date: Sun Aug 22 18:01:02 UTC 2010 Modified Files: src/external/cddl/osnet/dist/uts/common/dtrace: dtrace.c Log Message: Adapt to new module locking regime. Is that even right? Yes, that's the correct thing to do. I wonder how I missed this one when scanning for collateral damage. Thanks for fixing. - | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com| | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | -
Re: CVS commit: src/external/bsd/atf/dist
On Thu, 26 Aug 2010, Julio Merino wrote: Module Name:src Committed By: jmmv Date: Thu Aug 26 15:28:31 UTC 2010 Modified Files: src/external/bsd/atf/dist/atf-c++: io.cpp io.hpp io_test.cpp src/external/bsd/atf/dist/atf-run: test-program.cpp Log Message: Partially pull up the following revisions that address ticket #53: 996f9c26e07a86607f373c8f0243d57329c11543 ef98529abaf16e40a2e684496bf3da8f9ff0d09c These prevent atf-run from stalling/crashing when a subprocess of a test case stays around after the test case itself exits. Reported, and verified working, by po...@. Just wondering - does this address PR bin/43802 that I just filed? - | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com| | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | -
Re: CVS commit: src/external/bsd/atf/dist
On Thu, 26 Aug 2010, Julio Merino wrote: These prevent atf-run from stalling/crashing when a subprocess of a test case stays around after the test case itself exits. Reported, and verified working, by po...@. Just wondering - does this address PR bin/43802 that I just filed? Yup, but I had no idea about this PR :-P I was filing it while you were doing your commit! Ships crossing in the night and all that! - | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com| | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | -
liblua (CVS commit: src/distrib/sets/lists)
Module Name:src Committed By: mbalmer Date: Sun Oct 31 16:31:12 UTC 2010 Modified Files: src/distrib/sets/lists/base: md.amd64 md.sparc64 src/distrib/sets/lists/comp: md.amd64 md.sparc64 Log Message: Fix file lists for amd64 and sparc64 since on these arches 32bit versions of the libraries are built as well. I notice that for libm, libmagic and others, base/md.amd64 contains only two entries lib/i386/libxxx.so.x lib/i386/libxxx.so.x.y while there are five entries in comp/md.amd64 lib/i386/libxxx.a lib/i386/libxxx.so lib/i386/libxxx_p.a lib/i386/libxxx_pic.a lib/i386/libxxx_g.a Yet, this commit places lib/i386/liblua.so in base/md.amd64 list, and there does not seem to be a lib/i386/liblua_g.a I'm not trying to complain about the current commit,but only trying to determine if we should be consistent! Is there a valid reason why lib/i386/liblua.so belongs in base/md.amd64 while lib/i386/libm.so goes in comp/md.amd64 ? - | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com| | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | -
Re: CVS commit: src/sys/dev/dmover
On Sat, 13 Nov 2010, Masao Uebayashi wrote: Module Name:src Committed By: uebayasi Date: Sat Nov 13 14:08:20 UTC 2010 Modified Files: src/sys/dev/dmover: dmover_io.c Log Message: dmover(4) really uses uvm(9). (Wasn't revealed by i386/ALL...) Shouldn't we update i386/ALL so it will reveal such dependencies in the future? Index: ALL === RCS file: /cvsroot/src/sys/arch/i386/conf/ALL,v retrieving revision 1.276 diff -u -p -r1.276 ALL --- ALL 6 Nov 2010 15:11:50 - 1.276 +++ ALL 13 Nov 2010 14:16:01 - @@ -1699,6 +1699,9 @@ pseudo-device putter # Userspace block/char drivers pseudo-device pud +# Hardware-assisted data mover interface +pseudo-device dmoverio + optionsFILEASSOC # fileassoc(9) - required for Veriexec # Veriexec - | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com| | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | -
Re: NetBSD source-changes Digest V2 #1781
On Wed, 24 Nov 2010, NetBSD source-changes Digest wrote: NetBSD source-changes Digest Wednesday, November 24 2010 Volume 02 : Number 1781 ... Hmmm, did something change recently? I used to be subscribed only to source-changes but for the last couple of days I've also been getting the digest. Is this intentional? And if so, how can I unsubscribe from digest while still getting the usual stuff? - | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com| | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | -
Re: CVS commit: src/games/boggle/boggle
I thought about that, but checked a couple other games, and they all hard-code the program name... So I just make boggle consistent with others. I'd be happy to fix boggle (and tetris and snake) to use getprogname(3) but not sure I want to sign up to check everything. :) On Sun, 5 Dec 2010, Joerg Sonnenberger wrote: On Sun, Dec 05, 2010 at 04:11:52AM +, Paul Goyette wrote: Module Name:src Committed By: pgoyette Date: Sun Dec 5 04:11:52 UTC 2010 Modified Files: src/games/boggle/boggle: bog.c Log Message: Since this game is installed as 'boggle', fix the usage() text to match. getprogname()? Joerg !DSPAM:4cfb11e82361149613028! - | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com| | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | -
re: CVS commit: src/share/man/man7
On Sun, 12 Dec 2010, matthew green wrote: Log Message: Point to module(9) instead of modctl(8). We really need module(4) (not 9) like lkm(4)... don't we need both? one for the in-kernel APIs, and one for how to the user-kern API works? Er, yes, we need both. And we actually have both! module(9) describes the in-kernel stuff modctl(2) descibes the user-kern API Other than the rather generic description that existed in the older lkm(4) man page, I'm not sure what we could add. I'm not even totally convinced that we need to add anything... - | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com| | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | -
Re: CVS commit: src
On Mon, 13 Dec 2010, Jukka Ruohonen wrote: On Sat, Dec 11, 2010 at 04:13:03AM +, Paul Goyette wrote: Module Name:src Committed By: pgoyette Date: Sat Dec 11 04:13:03 UTC 2010 Modified Files: src/share/man/man4: swsensor.4 src/sys/dev/sysmon: swsensor.c Log Message: Enhance the swsensor(4) pseudo-device's capabilities to emulate more sensor types Can you briefly note what is the purpose of this? What can be done with swsensor(4)? swsensor(4) probably not very useful in a production environment. The primary use is as a diagnostic and debugging tool. One of the first requests I received when I joined the developer ranks was to provide a mechanism for triggering sensor events in a controlled manner, without requiring specific hardware. It has been quite useful recently in tracking down a couple of obscure bugs. swsensor(4) will also become an integral part of some soon-to-be-added atf regression tests. - | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com| | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | -
RE: CVS commit: src/sys/lib/libsa
Module Name:src Committed By: christos Date: Fri Dec 24 23:12:29 UTC 2010 Modified Files: src/sys/lib/libsa: stand.h Log Message: panic takes a printf format too. This changes breaks the build on port-amd64: /build/netbsd-local/src/sys/arch/i386/stand/boot/biosboot/../../../../../lib/libsa/alloc.c:217: warning: format '%lx' expects type 'long unsigned int', but argument 2 has type 'char *' - | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com| | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | -
Re: CVS commit: src
On Mon, 27 Dec 2010, Christos Zoulas wrote: Log Message: Migrate the ssp tests from regress to atf. Of the 17 tests, 4 fail in both the regress and atf style. 3 additional tests fails in atf that did NOT fail in regress: gets, fgets, and read. I will investigate why, and update when I can, but it is still useful to get these tests into the new format where they can be exercised. All read stdin so it appears that atf does not eval the command properly so 'echo foo | test' does not work. Correct. Running each individual test case manually under /bin/sh succeeds, and each of the above test cases properly calls abort(3) and dumps core. They fail only when running under atf-sh - | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com| | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | -
Re: CVS commit: src/tests/lib/libc/ssp
On Wed, 29 Dec 2010, Alan Barrett wrote: On Wed, 29 Dec 2010, Joerg Sonnenberger wrote: I don't know where len comes from, but bad things will happen if len sizeof(b). ...which is exactly the intention here, isn't it? You are probably right. I think that there should be comments explaining that the purpose of the code is to test how buffer overflows are handled. The code is located in src/tests/lib/libc/ssp/ ^ ^^^ - | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com| | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | -
Re: CVS commit: src/etc/powerd/scripts
On Fri, 31 Dec 2010, Jukka Ruohonen wrote: On Fri, Dec 31, 2010 at 11:29:23AM +0100, Jean-Yves Migeon wrote: Seems reasonable to me. We could have a more featureful binary later, and just alias zzz(8) to it. We have ready ioctl-facilities in sysmon's sysmon_power.c. I believe it was originally intended by the author that MD code should use the sysmon_power_settype() function to register a power-backend (ACPI, APM, Xen, PowerBook, and so on). Extending this idea seems like a plausible route. Yes. However, the current implementation is simply a text string with no defined semantics. A back-end is able to set the value, and it can be retrieved via the POWER_IOC_GET_TYPE ioctl, but otherwise nothing uses the value. - | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com| | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | -
Build failure on port-amd64 - acpiverbose
Sources are up to date as of a few minutes ago. --- dependall-acpiverbose --- /build/netbsd-local/src/sys/dev/acpi/acpi_verbose.c:493: warning: assignment makes pointer from integer without a cast *** [acpi_verbose.o] Error code 1 Probably from this commit: Module Name:src Committed By: jruoho Date: Fri Dec 31 10:23:44 UTC 2010 Modified Files: src/sys/dev/acpi: acpi_pci.c acpi_pci.h acpi_verbose.c Log Message: Move the function that finds a device_t for the corresponding ACPI device node from ACPIVERBOSE to the ACPI PCI code. - | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com| | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | -
Re: CVS commit: src/sys/compat/netbsd32
On Tue, 4 Jan 2011, Matt Thomas wrote: Module Name:src Committed By: matt Date: Tue Jan 4 10:59:29 UTC 2011 Modified Files: src/sys/compat/netbsd32: files.netbsd32 netbsd32_sa.c Log Message: Make the SA support as optional as is possible. This commit appears to have broken the build, at least on port-amd64: #create compat_netbsd32/netbsd32_sa.d CC=/test-bed/tools/bin/x86_64--netbsd-gcc /test-bed/tools/bin/nbmkdep -f netbsd32_sa.d -- -I/test-bed/src/common/include -DSYSVSHM -DSYSVSEM -DSYSVMSG -DCOMPAT_NETBSD32 -DEXEC_ELF32 -DEXEC_ELF64 -DEXEC_AOUT -DP1003_1B_SEMAPHORE -DCOREDUMP -I/test-bed/src/common/include -nostdinc -I. -I/test-bed/src/sys/modules/compat_netbsd32 -isystem /test-bed/src/sys -isystem /test-bed/src/sys/arch -isystem /test-bed/src/sys/../common/include -D_KERNEL -D_LKM -D_MODULE -std=gnu99 /test-bed/src/sys/compat/netbsd32/netbsd32_sa.c /test-bed/src/sys/compat/netbsd32/netbsd32_sa.c:37:31: error: opt_compat_netbsd.h: No such file or directory /test-bed/src/sys/compat/netbsd32/netbsd32_sa.c:38:20: error: opt_sa.h: No such file or directory nbmkdep: compile failed. - | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com| | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | -
Re: CVS commit: src/sys/compat/netbsd32
The following patch seems to take care of things, at least on my amd64 machine. I'm not sure if this is the correct fix, so I will let someone else handle the commit! Index: netbsd32_sa.c === RCS file: /cvsroot/src/sys/compat/netbsd32/netbsd32_sa.c,v retrieving revision 1.12 diff -u -p -r1.12 netbsd32_sa.c --- netbsd32_sa.c 4 Jan 2011 10:59:28 - 1.12 +++ netbsd32_sa.c 4 Jan 2011 13:56:08 - @@ -34,8 +34,11 @@ #include sys/cdefs.h __KERNEL_RCSID(0, $NetBSD: netbsd32_sa.c,v 1.12 2011/01/04 10:59:28 matt Exp $); + +#if defined(_KERNEL_OPT) #include opt_compat_netbsd.h #include opt_sa.h +#endif #include sys/types.h #include sys/param.h On Tue, 4 Jan 2011, Paul Goyette wrote: On Tue, 4 Jan 2011, Matt Thomas wrote: Module Name:src Committed By: matt Date: Tue Jan 4 10:59:29 UTC 2011 Modified Files: src/sys/compat/netbsd32: files.netbsd32 netbsd32_sa.c Log Message: Make the SA support as optional as is possible. This commit appears to have broken the build, at least on port-amd64: #create compat_netbsd32/netbsd32_sa.d CC=/test-bed/tools/bin/x86_64--netbsd-gcc /test-bed/tools/bin/nbmkdep -f netbsd32_sa.d -- -I/test-bed/src/common/include -DSYSVSHM -DSYSVSEM -DSYSVMSG -DCOMPAT_NETBSD32 -DEXEC_ELF32 -DEXEC_ELF64 -DEXEC_AOUT -DP1003_1B_SEMAPHORE -DCOREDUMP -I/test-bed/src/common/include -nostdinc -I. -I/test-bed/src/sys/modules/compat_netbsd32 -isystem /test-bed/src/sys -isystem /test-bed/src/sys/arch -isystem /test-bed/src/sys/../common/include -D_KERNEL -D_LKM -D_MODULE -std=gnu99 /test-bed/src/sys/compat/netbsd32/netbsd32_sa.c /test-bed/src/sys/compat/netbsd32/netbsd32_sa.c:37:31: error: opt_compat_netbsd.h: No such file or directory /test-bed/src/sys/compat/netbsd32/netbsd32_sa.c:38:20: error: opt_sa.h: No such file or directory nbmkdep: compile failed. - | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com| | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | - - | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com| | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | -
Re: CVS commit: src
On Wed, 5 Jan 2011, Jeff Rizzo wrote: Module Name:src Committed By: riz Date: Wed Jan 5 02:25:27 UTC 2011 Modified Files: src/distrib/sets/lists/tests: mi src/tests/sbin/resize_ffs: Makefile common.sh t_grow.sh t_shrink.sh Added Files: src/tests/sbin/resize_ffs: t_grow_swapped.sh t_shrink_swapped.sh Log Message: Update resize_ffs tests for byteswapped file system support, and for UFS2 growth support. Also, reduce the number of tests run by default while still maintaining decent coverage of features and block sizes. Anyone working on resize_Ffs should run the tests with RESIZE_FFS_ALL_TESTS set in the environment, which adds a lot more testing. Jeff, I'm wondering if maybe it would be more correct to use an atf variable (ie, atf-run -v RESIZE_FFS_ALL_TESTS=true) rather than something in the environment? As an example, take a look at my recent commit for src/tests/lib/libc/string/t_popcount.c To generate a diff of this commit: cvs rdiff -u -r1.206 -r1.207 src/distrib/sets/lists/tests/mi cvs rdiff -u -r1.2 -r1.3 src/tests/sbin/resize_ffs/Makefile cvs rdiff -u -r1.5 -r1.6 src/tests/sbin/resize_ffs/common.sh cvs rdiff -u -r1.6 -r1.7 src/tests/sbin/resize_ffs/t_grow.sh \ src/tests/sbin/resize_ffs/t_shrink.sh cvs rdiff -u -r0 -r1.1 src/tests/sbin/resize_ffs/t_grow_swapped.sh \ src/tests/sbin/resize_ffs/t_shrink_swapped.sh Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. !DSPAM:4d23d69d2341473314484! - | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com| | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | -
Re: CVS commit: src/tests
On Fri, 7 Jan 2011, Paul Goyette wrote: Module Name:src Committed By: pgoyette Date: Fri Jan 7 01:07:31 UTC 2011 Modified Files: src/tests: Makefile Log Message: Avoid double-inclusion of bsd.own.mk file. This eliminates some harmless but annoying warning messages. Correction: it is the bsd.subdir.mk file which gets double-included. I will update the reporitory. - | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com| | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | -
Re: CVS commit: src/tests/lib/libc
Damn, I wish I had asked first. :( I could easily delete the files (move them to the attic) and then re-add them in the desired location. I am aware of other ways to accomplish this, but I do not know how to do a repository move. If there's some cook-book approach written down somewhere, I'm pretty good at following instructions. But otherwise it would take me some time to figure it out (and test my approach first on a dummy repository). On Tue, 11 Jan 2011, Christos Zoulas wrote: In article 2011063054.5531017...@cvs.netbsd.org, Paul Goyette source-changes-d@NetBSD.org wrote: -=-=-=-=-=- Module Name:src Committed By: pgoyette Date: Tue Jan 11 16:30:54 UTC 2011 Modified Files: src/tests/lib/libc: Makefile Added Files: src/tests/lib/libc/getaddrinfo: Makefile README basics_v4.exp basics_v4v6.exp h_gai.c no_host_v4.exp no_host_v4v6.exp no_serv_v4.exp no_serv_v4v6.exp scoped.exp sock_raw_v4.exp sock_raw_v4v6.exp spec_fam_v4.exp spec_fam_v4v6.exp t_getaddrinfo.sh unsup_fam.exp Log Message: Atf-ify the getaddrinfo test, with updated golden output files. To generate a diff of this commit: cvs rdiff -u -r1.27 -r1.28 src/tests/lib/libc/Makefile cvs rdiff -u -r0 -r1.1 src/tests/lib/libc/getaddrinfo/Makefile \ src/tests/lib/libc/getaddrinfo/README \ src/tests/lib/libc/getaddrinfo/basics_v4.exp \ src/tests/lib/libc/getaddrinfo/basics_v4v6.exp \ src/tests/lib/libc/getaddrinfo/h_gai.c \ src/tests/lib/libc/getaddrinfo/no_host_v4.exp \ src/tests/lib/libc/getaddrinfo/no_host_v4v6.exp \ src/tests/lib/libc/getaddrinfo/no_serv_v4.exp \ src/tests/lib/libc/getaddrinfo/no_serv_v4v6.exp \ src/tests/lib/libc/getaddrinfo/scoped.exp \ src/tests/lib/libc/getaddrinfo/sock_raw_v4.exp \ src/tests/lib/libc/getaddrinfo/sock_raw_v4v6.exp \ src/tests/lib/libc/getaddrinfo/spec_fam_v4.exp \ src/tests/lib/libc/getaddrinfo/spec_fam_v4v6.exp \ src/tests/lib/libc/getaddrinfo/t_getaddrinfo.sh \ src/tests/lib/libc/getaddrinfo/unsup_fam.exp Can you please move all this to src/tests/lib/libc/net/getaddrinfo to reflect the structure in libc. I know others have been abusing it, but I meant to fix all of it and adding more does not help. Thanks, christos !DSPAM:4d2ce6e62341669414842! - | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com| | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | -
Re: CVS commit: src/tests/lib/libc
On Wed, 12 Jan 2011, Masao Uebayashi wrote: On Tue, Jan 11, 2011 at 11:25:01PM +, Christos Zoulas wrote: Module Name:src Committed By: pgoyette Date: Tue Jan 11 16:30:54 UTC 2011 Modified Files: src/tests/lib/libc: Makefile Added Files: src/tests/lib/libc/getaddrinfo: Makefile README basics_v4.exp basics_v4v6.exp h_gai.c no_host_v4.exp no_host_v4v6.exp no_serv_v4.exp no_serv_v4v6.exp scoped.exp sock_raw_v4.exp sock_raw_v4v6.exp spec_fam_v4.exp spec_fam_v4v6.exp t_getaddrinfo.sh unsup_fam.exp Log Message: Atf-ify the getaddrinfo test, with updated golden output files. ... Can you please move all this to src/tests/lib/libc/net/getaddrinfo to reflect the structure in libc. I know others have been abusing it, but I meant to fix all of it and adding more does not help. Why not put unit tests in the original directories? (Like src/lib/libc/net/getaddrinfo for this.) The original test was already in the regress/... hierarchy where it wasn't getting any attention. It just seemed reasonable to me to move a regression test to our new location for regression tests. :) At Christos's suggestion, I've already moved the getaddrinfo test from: src/test/lib/libc/getaddrinfo/* to: src/test/lib/libc/net/getaddrinfo/* If there are no objections, I'll likely move the servent and protoent tests into the /net directory, too. But not tonight! :) - | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com| | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | -
Re: CVS commit: src/tests/lib/libc
On Wed, 12 Jan 2011, Christos Zoulas wrote: | If there are no objections, I'll likely move the servent and protoent | tests into the /net directory, too. But not tonight! :) Great, go for it. Done. Hopefully I got the sets-list stuff right this time. :) (There must be a better way...) - | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com| | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | -
Build break - CVS commit: src/lib/libc/time
Module Name:src Committed By: christos Date: Fri Jan 14 23:35:07 UTC 2011 Modified Files: src/lib/libc/time: Makefile localtime.c zdump.c zic.c Log Message: don't depend on integer oveflow wrapping to detect it. From Paul Eggert in the tz mailing list. This appears to have broken something... Form an up-to-date source tree building on amd64 for amd64 #create zoneinfo/posix_only mkdir -p /build/netbsd-local/obj/amd64/share/zoneinfo/builddir cd /build/netbsd-local/src/share/zoneinfo /build/netbsd-local/tools/x86_64/amd64/bin/nbzic -y /bin/sh /build/netbsd-local/src/share/zoneinfo/yearistype.sh -d /build/netbsd-local/obj/amd64/share/zoneinfo/builddir -L /dev/null africa antarctica asia australasia europe northamerica southamerica pacificnew etcetera factory backward systemv solar87 solar88 solar89 africa, line 94: time overflow *** [posix_only] Error code 1 nbmake: stopped in /build/netbsd-local/src/share/zoneinfo - | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com| | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | -
Re: CVS commit: [bouyer-quota2] src
On Thu, 20 Jan 2011, Adam Hamsik wrote: Can you test if filesystem resizing still works ? Now when riz fixed resize_ffs it would be nice to keep it working :). riz has created a good set of atf regression tests, so those would be a good place to start. - | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com| | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | -
Re: CVS commit: src/usr.bin/xlint/lint1
Module Name:src
Committed By: christos
Date: Sat Feb 5 03:09:46 UTC 2011
Modified Files:
src/usr.bin/xlint/lint1: Makefile.ops-c Makefile.ops-h
Log Message:
fix tools build. Why doesn't .PARSEDIR work?
This doesn't seem to have fixed things. It appears that ops.h is being
created in the ${SRC} directory rather than in ${OBJ}, and my automated
amd64 update-build-and-test testbed [1] fails in both tools/lint1 and
usr.bin/lint/lint1 on alternate passes. The cvs update step also
complains about finding ops.h in the source directory, as in
? tools/lint1/ops.h
or ? usr.bin/xlint/lint1/ops.h
It appears that gson's build-and-test for i386 [2] is also failing in
a similar manner.
[1] http://www.whooppee.com/~paul/amd64-results/
[2] http://www.gson.org/netbsd/bugs/build/
-
| Paul Goyette | PGP Key fingerprint: | E-mail addresses: |
| Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com|
| Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net |
| Kernel Developer | | pgoyette at netbsd.org |
-
re: CVS commit: src/sys/arch/i386/conf
On Fri, 11 Feb 2011, matthew green wrote: Module Name:src Committed By: jym Date: Thu Feb 10 16:49:19 UTC 2011 Modified Files: src/sys/arch/i386/conf: INSTALL Log Message: For i386, include MONOLITHIC for INSTALL rather than GENERIC. While here, remove drm drivers, we don't need them for install. i386 GENERIC has FFS and ELF support compiled as modules, so we hit an interesting chicken-egg situation when the kernel attempts to mount a ffs ramdisk, while the module might be contained inside... the ramdisk. I'm not 100% sure it is worth having FFS and ELF support as modules in GENERIC. It may be nice that they CAN be modules, but I suspect 99.99% of systems will need them. Anyone who wants them as modules can build a kernel without them. i strongly agree with this. Me too. My totally modular kernel config file contains ... no options EXEC_ELF64 no options EXEC_SCRIPT no options COREDUMP no options AIO no options MQUEUE ... Not hard to type, not hard to maintain. - | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com| | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | -
Re: CVS commit: src/sys/arch/i386/conf
On Sun, 13 Feb 2011, Jean-Yves Migeon wrote: ... For order of preference, see module(7): The loader will look first for a built-in module with the specified name that has not been disabled (see module_unload() below). If a built-in module with that name is not found, the list of modules prepared by the boot loader is searched. If the named module is still not found, an attempt is made to locate the module within the file system. There should be one additional qualification here. Searching for modules within the file system can only occur after the root file system has been mounted by the initialization code. - | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com| | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | -
