CVS commit: src/sys/dev/usb
Module Name:src Committed By: yhardy Date: Sat Aug 10 06:30:26 UTC 2019 Modified Files: src/sys/dev/usb: ums.c Log Message: Initialize tcpalib for ums devices. In r1.3 of src/sys/dev/hid/hidms.c, tpcalib is used for any hidms device reporting absolute coordinates. So ums devices reporting absolute coordinates also need to initialize tcpalib - do it for all ums devices. An uninitialized tcpalib stops a mouse with absolute coordinates from "moving". OK: ryoon@ To generate a diff of this commit: cvs rdiff -u -r1.93 -r1.94 src/sys/dev/usb/ums.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/dev/usb
Module Name:src Committed By: yhardy Date: Sat Aug 10 06:30:26 UTC 2019 Modified Files: src/sys/dev/usb: ums.c Log Message: Initialize tcpalib for ums devices. In r1.3 of src/sys/dev/hid/hidms.c, tpcalib is used for any hidms device reporting absolute coordinates. So ums devices reporting absolute coordinates also need to initialize tcpalib - do it for all ums devices. An uninitialized tcpalib stops a mouse with absolute coordinates from "moving". OK: ryoon@ To generate a diff of this commit: cvs rdiff -u -r1.93 -r1.94 src/sys/dev/usb/ums.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/sys/dev/usb/ums.c diff -u src/sys/dev/usb/ums.c:1.93 src/sys/dev/usb/ums.c:1.94 --- src/sys/dev/usb/ums.c:1.93 Sun May 5 03:17:54 2019 +++ src/sys/dev/usb/ums.c Sat Aug 10 06:30:26 2019 @@ -1,4 +1,4 @@ -/* $NetBSD: ums.c,v 1.93 2019/05/05 03:17:54 mrg Exp $ */ +/* $NetBSD: ums.c,v 1.94 2019/08/10 06:30:26 yhardy Exp $ */ /* * Copyright (c) 1998, 2017 The NetBSD Foundation, Inc. @@ -35,7 +35,7 @@ */ #include -__KERNEL_RCSID(0, "$NetBSD: ums.c,v 1.93 2019/05/05 03:17:54 mrg Exp $"); +__KERNEL_RCSID(0, "$NetBSD: ums.c,v 1.94 2019/08/10 06:30:26 yhardy Exp $"); #ifdef _KERNEL_OPT #include "opt_usb.h" @@ -192,6 +192,7 @@ ums_attach(device_t parent, device_t sel } } + tpcalib_init(&sc->sc_ms.sc_tpcalib); hidms_attach(self, &sc->sc_ms, &ums_accessops); }
Re: CVS commit: src/sys/dev
Dear Ryo, On 2019-07-26, Ryo ONODERA wrote: > Hi, > > O.k. > I will commit your fix later. > > Thank you. Thanks! I can commit again, and I commited this change. Please let me know if I broke anything! (src/sys/dev/usb/ums.c v1.94) > Yorick Hardy writes: > > > Dear Ryo, > > > > On 2019-07-25, Ryo ONODERA wrote: > >> Hi, > >> > >> Yorick Hardy writes: > >> > >> > Dear Ryo, > >> > > >> > On 2019-07-09, Ryo ONODERA wrote: > >> >> Module Name:src > >> >> Committed By: ryoon > >> >> Date: Tue Jul 9 12:52:51 UTC 2019 > >> >> > >> >> Modified Files: > >> >> src/sys/dev/hid: hidms.c hidms.h > >> >> src/sys/dev/i2c: ims.c > >> >> > >> >> Log Message: > >> >> Add tpcalib, touch panel calibration to ims(4) > >> >> > >> >> Suggested by ryo@ at Japan NetBSD Users' Group BOF 2019-07-06. > >> >> > >> >> > >> >> To generate a diff of this commit: > >> >> cvs rdiff -u -r1.2 -r1.3 src/sys/dev/hid/hidms.c > >> >> cvs rdiff -u -r1.1 -r1.2 src/sys/dev/hid/hidms.h > >> >> cvs rdiff -u -r1.1 -r1.2 src/sys/dev/i2c/ims.c > >> >> > >> >> Please note that diffs are not public domain; they are subject to the > >> >> copyright notices on the relevant files. > >> > > >> > I think this change has the side effect that ums(4) devices which > >> > report absolute coordinates seem to stop "moving" because > >> > tcpalib_init is never called for these devices. > >> > > >> > Is the patch below okay? Or, should hidms call tcpalib_init? > >> > (I tested the patch with an ACECAD digimemo.) > >> > >> Sorry for breakage. > >> It looks good to me. > >> And I feel tpcalib_init should be called from ums.c like your patch. > >> Could you commit it? > > > > I am very sorry, but I retired my commit privilege because I was > > contributing very little to NetBSD. Otherwise I would be happy to do so! > > > >> Thank you. > >> > >> > -- > >> > Kind regards, > >> > > >> > Yorick Hardy > >> > > >> > Index: sys/dev/usb/ums.c > >> > === > >> > RCS file: /cvsroot/src/sys/dev/usb/ums.c,v > >> > retrieving revision 1.93 > >> > diff -u -r1.93 ums.c > >> > --- sys/dev/usb/ums.c5 May 2019 03:17:54 - 1.93 > >> > +++ sys/dev/usb/ums.c24 Jul 2019 21:29:35 - > >> > @@ -192,6 +192,7 @@ > >> > } > >> > } > >> > > >> > +tpcalib_init(&sc->sc_ms.sc_tpcalib); > >> > hidms_attach(self, &sc->sc_ms, &ums_accessops); > >> > } > >> > > >> > >> -- > >> Ryo ONODERA // r...@tetera.org > >> PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB FD1B F404 27FA C7D1 15F3 -- Kind regards, Yorick Hardy
Re: CVS commit: src/distrib/sets/lists
I think nicknames.5 may have an incorrect entry. Is the attached patch correct? Module Name:src Committed By: christos Date: Sun Jun 21 01:55:35 UTC 2009 Modified Files: src/distrib/sets/lists/etc: mi src/distrib/sets/lists/man: mi Log Message: add nicknames To generate a diff of this commit: cvs rdiff -u -r1.209 -r1.210 src/distrib/sets/lists/etc/mi cvs rdiff -u -r1.1140 -r1.1141 src/distrib/sets/lists/man/mi Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. -- Kind regards, Yorick Hardy Index: distrib/sets/lists/man/mi === RCS file: /cvsroot/src/distrib/sets/lists/man/mi,v retrieving revision 1.1141 diff -u -r1.1141 mi --- distrib/sets/lists/man/mi 21 Jun 2009 01:55:35 - 1.1141 +++ distrib/sets/lists/man/mi 25 Jun 2009 18:55:33 - @@ -6780,7 +6780,7 @@ ./usr/share/man/man5/netid.5 man-nis-man yp,.man ./usr/share/man/man5/networks.5man-net-man .man ./usr/share/man/man5/newsyslog.conf.5 man-sysutil-man .man -./usr/share/man/man5/nicknames.5 man-nis-catman yp,.cat +./usr/share/man/man5/nicknames.5 man-nis-man yp,.man ./usr/share/man/man5/nisplus_table.5 man-postfix-man postfix,.man ./usr/share/man/man5/nologin.5 man-sysutil-man .man ./usr/share/man/man5/nsswitch.conf.5 man-net-man .man
CVS commit: src/distrib/notes/common
Module Name:src Committed By: yhardy Date: Tue Feb 2 19:42:32 UTC 2010 Modified Files: src/distrib/notes/common: main Log Message: Add my name, as specified in the welcome message. To generate a diff of this commit: cvs rdiff -u -r1.455 -r1.456 src/distrib/notes/common/main Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
Re: CVS commit: src/sys/arch/x86/acpi
Dear Andrew, On 2020-03-14, Andrew Doran wrote: > Module Name: src > Committed By: ad > Date: Sat Mar 14 13:50:46 UTC 2020 > > Modified Files: > src/sys/arch/x86/acpi: acpi_cpu_md.c > > Log Message: > Put ACPI idle under ACPICPU_ENABLE_C3 until the wrinkles are ironed out. > This seems well written and basically all good, but currently doesn't enter > a low power state, and imposes a big performance penalty. Proposed on > port-i386 & port-amd64. > > > To generate a diff of this commit: > cvs rdiff -u -r1.81 -r1.82 src/sys/arch/x86/acpi/acpi_cpu_md.c > > Please note that diffs are not public domain; they are subject to the > copyright notices on the relevant files. This change seems to cause my machine to hang while booting. Reverting the change seems to fix the problem. Here are the details: $ cpuctl identify 0 cpu0: highest basic info 0005 cpu0: highest extended info 801b cpu0: "AMD Athlon(tm) II X3 450 Processor" cpu0: AMD Family 10h (686-class), 3200.22 MHz cpu0: family 0x10 model 0x5 stepping 0x3 (id 0x100f53) cpu0: features 0x178bfbff cpu0: features 0x178bfbff cpu0: features1 0x802009 cpu0: features2 0xefd3fbff cpu0: features2 0xefd3fbff cpu0: features3 0x37ff cpu0: features3 0x37ff cpu0: I-cache 64KB 64B/line 2-way, D-cache 64KB 64B/line 2-way cpu0: L2 cache 512KB 64B/line 16-way cpu0: ITLB 32 4KB entries fully associative, 16 2MB entries fully associative cpu0: DTLB 48 4KB entries fully associative, 48 2MB entries fully associative cpu0: L2 ITLB 512 4KB entries 4-way cpu0: L2 DTLB 512 4KB entries 4-way, 128 2MB entries 2-way cpu0: L1 1GB page DTLB 48 1GB entries fully associative cpu0: L2 1GB page DTLB 16 1GB entries 8-way cpu0: Initial APIC ID 0 cpu0: Cluster/Package ID 0 cpu0: Core ID 0 cpu0: SMT ID 0 cpu0: MONITOR/MWAIT extensions 0x3 cpu0: monitor-line size 64 cpu0: AMD Power Management features: 0x1f9 cpu0: SVM Rev. 1 cpu0: SVM NASID 64 cpu0: SVM features 0xf cpu0: UCode version: 0x1c8 $ dmesg | fgrep acpicpu [ 1.014781] acpicpu0 at cpu0: ACPI CPU [ 1.014781] acpicpu0: C1: HLT, lat 0 us, pow 0 mW [ 1.014781] acpicpu0: P0: FFH, lat 4 us, pow 34375 mW, 3200 MHz [ 1.014781] acpicpu0: P1: FFH, lat 4 us, pow 25245 mW, 2500 MHz [ 1.014781] acpicpu0: P2: FFH, lat 4 us, pow 22200 mW, 2000 MHz [ 1.014781] acpicpu0: P3: FFH, lat 4 us, pow 12095 mW, 800 MHz [ 1.014781] acpicpu0: T0: I/O, lat 1 us, pow 0 mW, 100 % [ 1.014781] acpicpu0: T1: I/O, lat 1 us, pow 0 mW, 88 % [ 1.014781] acpicpu0: T2: I/O, lat 1 us, pow 0 mW, 76 % [ 1.014781] acpicpu0: T3: I/O, lat 1 us, pow 0 mW, 64 % [ 1.014781] acpicpu0: T4: I/O, lat 1 us, pow 0 mW, 52 % [ 1.014781] acpicpu0: T5: I/O, lat 1 us, pow 0 mW, 40 % [ 1.014781] acpicpu0: T6: I/O, lat 1 us, pow 0 mW, 28 % [ 1.014781] acpicpu0: T7: I/O, lat 1 us, pow 0 mW, 16 % [ 1.014781] acpicpu1 at cpu1: ACPI CPU [ 1.014781] acpicpu2 at cpu2: ACPI CPU [ 1.017385] acpicpu0 at cpu0: ACPI CPU [ 1.017385] acpicpu0: C1: HLT, lat 0 us, pow 0 mW [ 1.017385] acpicpu0: P0: FFH, lat 4 us, pow 34375 mW, 3200 MHz [ 1.017385] acpicpu0: P1: FFH, lat 4 us, pow 25245 mW, 2500 MHz [ 1.017385] acpicpu0: P2: FFH, lat 4 us, pow 22200 mW, 2000 MHz [ 1.017385] acpicpu0: P3: FFH, lat 4 us, pow 12095 mW, 800 MHz [ 1.017385] acpicpu0: T0: I/O, lat 1 us, pow 0 mW, 100 % [ 1.017385] acpicpu0: T1: I/O, lat 1 us, pow 0 mW, 88 % [ 1.017385] acpicpu0: T2: I/O, lat 1 us, pow 0 mW, 76 % [ 1.017385] acpicpu0: T3: I/O, lat 1 us, pow 0 mW, 64 % [ 1.017385] acpicpu0: T4: I/O, lat 1 us, pow 0 mW, 52 % [ 1.017385] acpicpu0: T5: I/O, lat 1 us, pow 0 mW, 40 % [ 1.017385] acpicpu0: T6: I/O, lat 1 us, pow 0 mW, 28 % [ 1.017385] acpicpu0: T7: I/O, lat 1 us, pow 0 mW, 16 % [ 1.017385] acpicpu1 at cpu1: ACPI CPU [ 1.017385] acpicpu2 at cpu2: ACPI CPU -- Kind regards, Yorick Hardy
Re: CVS commit: src
Dear Maxime,
On 2020-04-19, Maxime Villard wrote:
> Module Name: src
> Committed By: maxv
> Date: Sun Apr 19 13:22:58 UTC 2020
>
> Modified Files:
> src/distrib/sets/lists/debug: md.amd64
> src/distrib/sets/lists/tests: md.amd64 mi
> src/etc/mtree: NetBSD.dist.tests
> src/tests/lib: Makefile
> Added Files:
> src/tests/lib/libi386: Makefile t_user_ldt.c
>
> Log Message:
> Add tests for USER_LDT.
>
>
> To generate a diff of this commit:
> cvs rdiff -u -r1.106 -r1.107 src/distrib/sets/lists/debug/md.amd64
> cvs rdiff -u -r1.7 -r1.8 src/distrib/sets/lists/tests/md.amd64
> cvs rdiff -u -r1.835 -r1.836 src/distrib/sets/lists/tests/mi
> cvs rdiff -u -r1.161 -r1.162 src/etc/mtree/NetBSD.dist.tests
> cvs rdiff -u -r1.32 -r1.33 src/tests/lib/Makefile
> cvs rdiff -u -r0 -r1.1 src/tests/lib/libi386/Makefile \
> src/tests/lib/libi386/t_user_ldt.c
>
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.
I think this test depends on MKCOMPAT=yes. Does the attached the patch
below look reasonable?
--
Kind regards,
Yorick Hardy
Index: distrib/sets/lists/debug/md.amd64
===
RCS file: /cvsroot/src/distrib/sets/lists/debug/md.amd64,v
retrieving revision 1.108
diff -u -r1.108 md.amd64
--- distrib/sets/lists/debug/md.amd64 26 Apr 2020 09:08:40 - 1.108
+++ distrib/sets/lists/debug/md.amd64 6 May 2020 22:28:04 -
@@ -25,7 +25,7 @@
./usr/libdata/debug/usr/tests/kernel/arch/x86/t_ptrace_wait6.debug
tests-obsolete obsolete
./usr/libdata/debug/usr/tests/kernel/arch/x86/t_ptrace_waitid.debug
tests-obsolete obsolete
./usr/libdata/debug/usr/tests/kernel/arch/x86/t_ptrace_waitpid.debug
tests-obsolete obsolete
-./usr/libdata/debug/usr/tests/lib/libi386/t_user_ldt.debug tests-lib-debug
debug,atf
+./usr/libdata/debug/usr/tests/lib/libi386/t_user_ldt.debug tests-lib-debug
debug,atf,compat
./usr/libdata/debug/usr/tests/lib/libnvmm/h_io_assist.debugtests-lib-debug
debug,atf
./usr/libdata/debug/usr/tests/lib/libnvmm/h_mem_assist.debug tests-lib-debug
debug,atf
./usr/libdata/debug/usr/tests/modules/t_x86_pte.debug tests-sys-debug
debug,atf
Index: distrib/sets/lists/tests/md.amd64
===
RCS file: /cvsroot/src/distrib/sets/lists/tests/md.amd64,v
retrieving revision 1.10
diff -u -r1.10 md.amd64
--- distrib/sets/lists/tests/md.amd64 28 Apr 2020 13:43:45 - 1.10
+++ distrib/sets/lists/tests/md.amd64 6 May 2020 22:28:04 -
@@ -7,7 +7,7 @@
./usr/tests/kernel/arch/x86/t_ptrace_wait6 tests-obsolete obsolete
./usr/tests/kernel/arch/x86/t_ptrace_waitidtests-obsolete obsolete
./usr/tests/kernel/arch/x86/t_ptrace_waitpid tests-obsolete obsolete
-./usr/tests/lib/libi386/t_user_ldt tests-lib-tests
compattestfile,atf
+./usr/tests/lib/libi386/t_user_ldt tests-lib-tests
compattestfile,atf,compat
./usr/tests/lib/libnvmm/h_io_assisttests-lib-tests
compattestfile,atf
./usr/tests/lib/libnvmm/t_io_assisttests-lib-tests
compattestfile,atf
./usr/tests/lib/libnvmm/h_mem_assist tests-lib-tests
compattestfile,atf
Index: tests/lib/libi386/Makefile
===
RCS file: /cvsroot/src/tests/lib/libi386/Makefile,v
retrieving revision 1.3
diff -u -r1.3 Makefile
--- tests/lib/libi386/Makefile 20 Apr 2020 12:08:08 - 1.3
+++ tests/lib/libi386/Makefile 6 May 2020 22:28:04 -
@@ -4,7 +4,7 @@
TESTSDIR= ${TESTSBASE}/lib/libi386
-.if ${MACHINE} == "amd64"
+.if ${MACHINE} == "amd64" && ${MKCOMPATTESTS} == "yes"
SHLIBINSTALLDIR= /usr/lib/i386
COPTS+=-m32
LDFLAGS+= -m32
Re: CVS commit: src
Dear Martin,
On 2020-05-07, Martin Husemann wrote:
> On Thu, May 07, 2020 at 12:31:12AM +0200, Yorick Hardy wrote:
> > I think this test depends on MKCOMPAT=yes. Does the attached the patch
> > below look reasonable?
> [..]
> > -.if ${MACHINE} == "amd64"
> > +.if ${MACHINE} == "amd64" && ${MKCOMPATTESTS} == "yes"
>
> MKCOMPATTESTS is something slightly different. It is used to build e.g. the
> "native" i386 tests (as 32bit binaries) when building an amd64 distribution.
>
> This is usually set to "no".
>
> MKCOMPAT=yes means to build i386 libraries, so you can build 32bit binaries
> on amd64 with -m32. It is usually set to "yes".
>
> Martin
Thanks! It took a while for this to sink in ...
So I think the test should only be built if MKCOMPAT=yes ?
(It does fail to build for me, because I usually have MKCOMPAT=no).
--
Kind regards,
Yorick Hardy
Re: CVS commit: src
Dear Martin,
On 2020-05-08, Martin Husemann wrote:
> On Thu, May 07, 2020 at 10:52:26PM +0200, Yorick Hardy wrote:
> > Thanks! It took a while for this to sink in ...
> >
> > So I think the test should only be built if MKCOMPAT=yes ?
> > (It does fail to build for me, because I usually have MKCOMPAT=no).
>
> Yes, either the Makefile needs a conditional, or the SUBDIR+= in the
> makefile above.
>
> Martin
I think it may be better in the Makefile, since the test for amd64 already
happens there and because the libi386 directory could conceivably
also contain i386/non-amd64 tests.
I successfully completed a build with MKCOMPAT=no, using the patch below.
Is it okay to commit?
--
Kind regards,
Yorick Hardy
Index: distrib/sets/lists/debug/md.amd64
==
--- distrib/sets/lists/debug/md.amd64
+++ distrib/sets/lists/debug/md.amd64
@@ -23,9 +23,9 @@
./usr/libdata/debug/usr/tests/kernel/arch/x86/t_ptrace_wait3.debug
tests-obsolete obsolete
./usr/libdata/debug/usr/tests/kernel/arch/x86/t_ptrace_wait4.debug
tests-obsolete obsolete
./usr/libdata/debug/usr/tests/kernel/arch/x86/t_ptrace_wait6.debug
tests-obsolete obsolete
./usr/libdata/debug/usr/tests/kernel/arch/x86/t_ptrace_waitid.debug
tests-obsolete obsolete
./usr/libdata/debug/usr/tests/kernel/arch/x86/t_ptrace_waitpid.debug
tests-obsolete obsolete
-./usr/libdata/debug/usr/tests/lib/libi386/t_user_ldt.debug tests-lib-debug
debug,atf
+./usr/libdata/debug/usr/tests/lib/libi386/t_user_ldt.debug tests-lib-debug
debug,atf,compat
./usr/libdata/debug/usr/tests/lib/libnvmm/h_io_assist.debugtests-lib-debug
debug,atf
./usr/libdata/debug/usr/tests/lib/libnvmm/h_mem_assist.debug tests-lib-debug
debug,atf
./usr/libdata/debug/usr/tests/modules/t_x86_pte.debug tests-sys-debug
debug,atf
Index: distrib/sets/lists/tests/md.amd64
==
--- distrib/sets/lists/tests/md.amd64
+++ distrib/sets/lists/tests/md.amd64
@@ -5,13 +5,13 @@
./usr/tests/kernel/arch/x86/t_ptrace_wait3 tests-obsolete obsolete
./usr/tests/kernel/arch/x86/t_ptrace_wait4 tests-obsolete obsolete
./usr/tests/kernel/arch/x86/t_ptrace_wait6 tests-obsolete obsolete
./usr/tests/kernel/arch/x86/t_ptrace_waitidtests-obsolete obsolete
./usr/tests/kernel/arch/x86/t_ptrace_waitpid tests-obsolete obsolete
-./usr/tests/lib/libi386/t_user_ldt tests-lib-tests
compattestfile,atf
+./usr/tests/lib/libi386/t_user_ldt tests-lib-tests
compattestfile,atf,compat
./usr/tests/lib/libnvmm/h_io_assisttests-lib-tests
compattestfile,atf
./usr/tests/lib/libnvmm/t_io_assisttests-lib-tests
compattestfile,atf
./usr/tests/lib/libnvmm/h_mem_assist tests-lib-tests
compattestfile,atf
./usr/tests/lib/libnvmm/t_mem_assist tests-lib-tests
compattestfile,atf
./usr/tests/modules/t_x86_pte tests-sys-tests atf,kmod
./usr/tests/modules/x86_pte_tester tests-sys-tests atf,kmod
./usr/tests/modules/x86_pte_tester/x86_pte_tester.kmod tests-sys-tests atf,kmod
Index: tests/lib/libi386/Makefile
==
--- tests/lib/libi386/Makefile
+++ tests/lib/libi386/Makefile
@@ -2,14 +2,14 @@
.include
TESTSDIR= ${TESTSBASE}/lib/libi386
-.if ${MACHINE} == "amd64"
+.if ${MACHINE} == "amd64" && ${MKCOMPAT} == "yes"
SHLIBINSTALLDIR= /usr/lib/i386
COPTS+=-m32
LDFLAGS+= -m32
LDADD+=-li386
TESTS_C+= t_user_ldt
.endif
.include
Re: CVS commit: src/external/cddl/osnet/dist/uts/common/fs/zfs
On 2020-11-28, Yorick Hardy wrote: > Module Name: src > Committed By: yhardy > Date: Sat Nov 28 22:53:06 UTC 2020 > > Modified Files: > src/external/cddl/osnet/dist/uts/common/fs/zfs: vdev_disk.c > > Log Message: > Use vn_close to release the vnodes in the error handling blocks, since > the vnodes were opened for writing. Fix proposed on current-users > and improved by hannken@. > > > To generate a diff of this commit: > cvs rdiff -u -r1.18 -r1.19 \ > src/external/cddl/osnet/dist/uts/common/fs/zfs/vdev_disk.c > > Please note that diffs are not public domain; they are subject to the > copyright notices on the relevant files. Oops, that should have been "proposed on tech-kern": http://mail-index.netbsd.org/tech-kern/2020/11/28/msg026984.html -- Kind regards, Yorick Hardy
Re: CVS commit: src/sys/dev
Dear Ryo, On 2019-07-09, Ryo ONODERA wrote: > Module Name: src > Committed By: ryoon > Date: Tue Jul 9 12:52:51 UTC 2019 > > Modified Files: > src/sys/dev/hid: hidms.c hidms.h > src/sys/dev/i2c: ims.c > > Log Message: > Add tpcalib, touch panel calibration to ims(4) > > Suggested by ryo@ at Japan NetBSD Users' Group BOF 2019-07-06. > > > To generate a diff of this commit: > cvs rdiff -u -r1.2 -r1.3 src/sys/dev/hid/hidms.c > cvs rdiff -u -r1.1 -r1.2 src/sys/dev/hid/hidms.h > cvs rdiff -u -r1.1 -r1.2 src/sys/dev/i2c/ims.c > > Please note that diffs are not public domain; they are subject to the > copyright notices on the relevant files. I think this change has the side effect that ums(4) devices which report absolute coordinates seem to stop "moving" because tcpalib_init is never called for these devices. Is the patch below okay? Or, should hidms call tcpalib_init? (I tested the patch with an ACECAD digimemo.) -- Kind regards, Yorick Hardy Index: sys/dev/usb/ums.c === RCS file: /cvsroot/src/sys/dev/usb/ums.c,v retrieving revision 1.93 diff -u -r1.93 ums.c --- sys/dev/usb/ums.c 5 May 2019 03:17:54 - 1.93 +++ sys/dev/usb/ums.c 24 Jul 2019 21:29:35 - @@ -192,6 +192,7 @@ } } + tpcalib_init(&sc->sc_ms.sc_tpcalib); hidms_attach(self, &sc->sc_ms, &ums_accessops); }
Re: CVS commit: src/sys/dev
Dear Ryo, On 2019-07-25, Ryo ONODERA wrote: > Hi, > > Yorick Hardy writes: > > > Dear Ryo, > > > > On 2019-07-09, Ryo ONODERA wrote: > >> Module Name: src > >> Committed By: ryoon > >> Date: Tue Jul 9 12:52:51 UTC 2019 > >> > >> Modified Files: > >>src/sys/dev/hid: hidms.c hidms.h > >>src/sys/dev/i2c: ims.c > >> > >> Log Message: > >> Add tpcalib, touch panel calibration to ims(4) > >> > >> Suggested by ryo@ at Japan NetBSD Users' Group BOF 2019-07-06. > >> > >> > >> To generate a diff of this commit: > >> cvs rdiff -u -r1.2 -r1.3 src/sys/dev/hid/hidms.c > >> cvs rdiff -u -r1.1 -r1.2 src/sys/dev/hid/hidms.h > >> cvs rdiff -u -r1.1 -r1.2 src/sys/dev/i2c/ims.c > >> > >> Please note that diffs are not public domain; they are subject to the > >> copyright notices on the relevant files. > > > > I think this change has the side effect that ums(4) devices which > > report absolute coordinates seem to stop "moving" because > > tcpalib_init is never called for these devices. > > > > Is the patch below okay? Or, should hidms call tcpalib_init? > > (I tested the patch with an ACECAD digimemo.) > > Sorry for breakage. > It looks good to me. > And I feel tpcalib_init should be called from ums.c like your patch. > Could you commit it? I am very sorry, but I retired my commit privilege because I was contributing very little to NetBSD. Otherwise I would be happy to do so! > Thank you. > > > -- > > Kind regards, > > > > Yorick Hardy > > > > Index: sys/dev/usb/ums.c > > === > > RCS file: /cvsroot/src/sys/dev/usb/ums.c,v > > retrieving revision 1.93 > > diff -u -r1.93 ums.c > > --- sys/dev/usb/ums.c 5 May 2019 03:17:54 - 1.93 > > +++ sys/dev/usb/ums.c 24 Jul 2019 21:29:35 - > > @@ -192,6 +192,7 @@ > > } > > } > > > > + tpcalib_init(&sc->sc_ms.sc_tpcalib); > > hidms_attach(self, &sc->sc_ms, &ums_accessops); > > } > > > > -- > Ryo ONODERA // r...@tetera.org > PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB FD1B F404 27FA C7D1 15F3 -- Kind regards, Yorick Hardy
