Re: CVS commit: src/sys/dev

2020-05-30 Thread Alexander Nasonov
Jaromir Dolecek wrote: > Index: src/sys/dev/ic/bwfmvar.h > diff -u src/sys/dev/ic/bwfmvar.h:1.9 src/sys/dev/ic/bwfmvar.h:1.10 > --- src/sys/dev/ic/bwfmvar.h:1.9 Sat May 30 13:41:58 2020 > +++ src/sys/dev/ic/bwfmvar.h Sat May 30 15:55:47 2020 > @@ -1,4 +1,4 @@ > -/* $NetBSD: bwfmvar.h,v 1.9

Re: CVS commit: src/sys/uvm

2020-05-11 Thread Alexander Nasonov
Taylor R Campbell wrote: > This sounds entirely reasonable. Would you like to draft an > implementation of that? Sure, I can look into this on the weekend. > Presumably it would require writing a sysctl callback function for > vm.swap_encrypt, and would somehow involve kauth, but I'm not sure >

Re: CVS commit: src/sys/uvm

2020-05-10 Thread Alexander Nasonov
Taylor R Campbell wrote: > Log Message: > Implement swap encryption. > > Enabled by sysctl -w vm.swap_encrypt=1. If secmodel_securelevel(9) is still a thing, locking down this sysctl at high securelevel may improve our security. Prior to this change, swap devices were readable (even if enrypted

Re: CVS commit: src/sys/dev/ata

2020-04-29 Thread Alexander Nasonov
David Brownlee wrote: > Just another data point - seeing this same panic on a T480 with the > latest kernel from nyftp Same problem on T470. -- Alex

Re: CVS commit: src/sys/sys

2019-12-22 Thread Alexander Nasonov
Roy Marples wrote: > On 22/12/2019 22:24, Andrew Doran wrote: > > NetBSD 9.99.29 - struct mount changed. > > Just curious - does our build software cope with 3 digit for the last number? https://twitter.com/needydev/status/1205585787095519234?s=20 -- Alex

Re: CVS commit: src/sys/sys

2019-12-21 Thread Alexander Nasonov
Andrew Doran wrote: > Log Message: > NetBSD 9.99.28 - cpu_data & UVM changes. Wow, you bump versions faster than I compile new releases. At this pace, we'll get to 9.99.99 in a month or two ;-) -- Alex

Re: CVS commit: src/sys/arch/x86

2019-11-27 Thread Alexander Nasonov
Maxime Villard wrote: > Module Name: src > Committed By: maxv > Date: Wed Nov 27 06:24:33 UTC 2019 > > Modified Files: > src/sys/arch/x86/include: cpu.h fpu.h > src/sys/arch/x86/x86: cpu.c fpu.c > > Log Message: > Add a small API for in-kernel FPU operations. > >

CVS commit: src/distrib/common

2019-11-21 Thread Alexander Nasonov
Module Name:src Committed By: alnsn Date: Fri Nov 22 00:27:30 UTC 2019 Modified Files: src/distrib/common: cgdroot.rc Log Message: If gpt label "cgd.conf" contains a valid /etc/cgd file system, try mounting gpt label "cgdroot" as a root filesystem first and only mount

CVS commit: src/distrib/common

2019-11-21 Thread Alexander Nasonov
Module Name:src Committed By: alnsn Date: Fri Nov 22 00:27:30 UTC 2019 Modified Files: src/distrib/common: cgdroot.rc Log Message: If gpt label "cgd.conf" contains a valid /etc/cgd file system, try mounting gpt label "cgdroot" as a root filesystem first and only mount

Re: Leak Sanitizer - how to suppress leaks

2019-09-14 Thread Alexander Nasonov
Martin Husemann wrote: > On Sat, Sep 14, 2019 at 01:45:08PM +0200, Kamil Rytarowski wrote: > > Thanks! I will go for __NO_LEAKS ifdef. > > But it is not a good idea to clutter perfectly fine sources with such > #ifdefs and unused/untested/likely broken code (even if it does not affect > the

CVS commit: src/usr.sbin/veriexecgen

2019-08-01 Thread Alexander Nasonov
Module Name:src Committed By: alnsn Date: Thu Aug 1 08:51:52 UTC 2019 Modified Files: src/usr.sbin/veriexecgen: veriexecgen.c Log Message: Move case 'f' to go right after case 'F'. To generate a diff of this commit: cvs rdiff -u -r1.20 -r1.21

CVS commit: src/usr.sbin/veriexecgen

2019-08-01 Thread Alexander Nasonov
Module Name:src Committed By: alnsn Date: Thu Aug 1 08:51:52 UTC 2019 Modified Files: src/usr.sbin/veriexecgen: veriexecgen.c Log Message: Move case 'f' to go right after case 'F'. To generate a diff of this commit: cvs rdiff -u -r1.20 -r1.21

CVS commit: src/usr.sbin/veriexecgen

2019-07-31 Thread Alexander Nasonov
Module Name:src Committed By: alnsn Date: Wed Jul 31 15:02:39 UTC 2019 Modified Files: src/usr.sbin/veriexecgen: veriexecgen.8 veriexecgen.c Log Message: Add an option to read entries from a file. To generate a diff of this commit: cvs rdiff -u -r1.20 -r1.21

CVS commit: src/usr.sbin/veriexecgen

2019-07-31 Thread Alexander Nasonov
Module Name:src Committed By: alnsn Date: Wed Jul 31 15:02:39 UTC 2019 Modified Files: src/usr.sbin/veriexecgen: veriexecgen.8 veriexecgen.c Log Message: Add an option to read entries from a file. To generate a diff of this commit: cvs rdiff -u -r1.20 -r1.21

CVS commit: src/share/misc

2019-06-23 Thread Alexander Nasonov
Module Name:src Committed By: alnsn Date: Sun Jun 23 17:17:18 UTC 2019 Modified Files: src/share/misc: acronyms.comp Log Message: Fix a typo. To generate a diff of this commit: cvs rdiff -u -r1.269 -r1.270 src/share/misc/acronyms.comp Please note that diffs are not

CVS commit: src/share/misc

2019-06-23 Thread Alexander Nasonov
Module Name:src Committed By: alnsn Date: Sun Jun 23 17:17:18 UTC 2019 Modified Files: src/share/misc: acronyms.comp Log Message: Fix a typo. To generate a diff of this commit: cvs rdiff -u -r1.269 -r1.270 src/share/misc/acronyms.comp Please note that diffs are not

CVS commit: src/share/misc

2019-06-02 Thread Alexander Nasonov
Module Name:src Committed By: alnsn Date: Sun Jun 2 20:18:23 UTC 2019 Modified Files: src/share/misc: acronyms.comp Log Message: One more CPS. To generate a diff of this commit: cvs rdiff -u -r1.254 -r1.255 src/share/misc/acronyms.comp Please note that diffs are not

CVS commit: src/sys/dev/cadence/if_cemac.c

2019-05-19 Thread Alexander Nasonov
Module Name:src Committed By: alnsn Date: Sun May 19 13:32:00 UTC 2019 Modified Files: src/sys/dev/cadence: if_cemac.c Log Message: Kill unused sc variable and fix the build. To generate a diff of this commit: cvs rdiff -u -r1.17 -r1.18 src/sys/dev/cadence/if_cemac.c

CVS commit: src/share/man/man9

2019-05-18 Thread Alexander Nasonov
Module Name:src Committed By: alnsn Date: Sat May 18 10:21:03 UTC 2019 Modified Files: src/share/man/man9: secmodel_securelevel.9 Log Message: Don't mention SVS because it can't be changed anymore. To generate a diff of this commit: cvs rdiff -u -r1.18 -r1.19

CVS commit: src/share/man/man9

2019-05-18 Thread Alexander Nasonov
Module Name:src Committed By: alnsn Date: Sat May 18 10:21:03 UTC 2019 Modified Files: src/share/man/man9: secmodel_securelevel.9 Log Message: Don't mention SVS because it can't be changed anymore. To generate a diff of this commit: cvs rdiff -u -r1.18 -r1.19

Re: CVS commit: src/distrib/common

2019-01-02 Thread Alexander Nasonov
m...@netbsd.org wrote: > On Wed, Jan 02, 2019 at 08:42:33PM +0000, Alexander Nasonov wrote: > > https://wiki.netbsd.org/projects/project/transparent-cgd/ > > > > This page describes limitations of cgdroot.kmod. > > > > In my opinion, aes-xts should be added

Re: CVS commit: src/distrib/common

2019-01-02 Thread Alexander Nasonov
Alexander Nasonov wrote: > m...@netbsd.org wrote: > > Why are we using a memory disk for full disk encryption? I am under the > > impression that it shouldn't be required. > > We use a memory disk because cgdconfig functionality isn't available in > the bootloader.

Re: CVS commit: src/distrib/common

2018-12-29 Thread Alexander Nasonov
m...@netbsd.org wrote: > Why are we using a memory disk for full disk encryption? I am under the > impression that it shouldn't be required. We use a memory disk because cgdconfig functionality isn't available in the bootloader. -- Alex

Re: CVS commit: src/distrib/common

2018-12-29 Thread Alexander Nasonov
Alexander Nasonov wrote: > Module Name: src > Committed By: alnsn > Date: Sat Dec 29 00:52:11 UTC 2018 > > Modified Files: > src/distrib/common: cgdroot.rc > > Log Message: > Don't hardcode wd0a in cgdroot.kmod, try NAME=cgd.conf and ROOT.a. >

Re: CVS commit: src/sbin/cgdconfig

2018-12-27 Thread Alexander Nasonov
Christoph Badura wrote: > Using /etc/cgd/ROOT. has the advantage that the cgd will configure > if the root device changes name, thus upholding POLA. > > E.g. moving disks from a controller that attaches sd(4)s to one that > attaches ld(4)s. I believe you can see that when dd'ing an image from >

Re: CVS import: src/external/mit/lua/dist

2018-07-29 Thread Alexander Nasonov
Alexander Nasonov wrote: > Alexander Nasonov wrote: > > Module Name:src > > Committed By: alnsn > > Date: Sun Jul 29 19:46:08 UTC 2018 > > > > Update of /cvsroot/src/external/mit/lua/dist > > In directory ivanova.netbsd.org:

Re: CVS import: src/external/mit/lua/dist

2018-07-29 Thread Alexander Nasonov
Alexander Nasonov wrote: > Module Name: src > Committed By: alnsn > Date: Sun Jul 29 19:46:08 UTC 2018 > > Update of /cvsroot/src/external/mit/lua/dist > In directory ivanova.netbsd.org:/tmp/cvs-serv15569 > > Log Message: > Import Lua 5.3.5. Hmm, it didn

Re: CVS commit: src/sbin/cgdconfig

2018-07-27 Thread Alexander Nasonov
Robert Elz wrote: > Module Name: src > Committed By: kre > Date: Sat May 5 11:28:44 UTC 2018 > > Modified Files: > src/sbin/cgdconfig: cgdconfig.c > > Log Message: > Check whether the cgd device selected is available to be > configured,that is, not already in use, before

Re: CVS commit: src/usr.sbin/tprof

2018-07-18 Thread Alexander Nasonov
Thomas Klausner wrote: > Module Name: src > Committed By: wiz > Date: Wed Jul 18 16:50:05 UTC 2018 > > Modified Files: > src/usr.sbin/tprof: tprof.8 tprof.c > > Log Message: > Various improvements to man page. Sync usage. > Does tprof work on amd64? When I tried it a couple of

Re: CVS commit: src/sbin/cgdconfig

2018-05-09 Thread Alexander Nasonov
matthew green wrote: > "Alexander Nasonov" writes: > > XXX Using memset for wiping isn't a good idea because memset is likely > > optimised away by gcc. This should be revisited. > > use explicit_memset(3)? Yes, we should change memsets of sensitive buffers to exp

Re: CVS commit: src/sbin/cgdconfig

2018-05-09 Thread Alexander Nasonov
Alexander Nasonov wrote: > (gdb) b opendisk1 > (gdb) run -p > Starting program: > /home/alnsn/netbsd-current/clean/src/sbin/cgdconfig/obj/cgdconfig -p > > Breakpoint 1, 0x7f7ff78111f6 in opendisk1 () from /lib/libutil.so.7 > (gdb) x/s $rdi > 0x0: # path=NULL

Re: CVS commit: src/sbin/cgdconfig

2018-05-09 Thread Alexander Nasonov
Robert Elz wrote: > Date:Tue, 8 May 2018 19:15:28 +0100 > From: Alexander Nasonov <al...@yandex.ru> > Message-ID: <20180508180815.GA5990@neva> > > | I think it broke the tool. If you run > | > | cgdconfig -p > | >

Re: CVS commit: src/sbin/cgdconfig

2018-05-08 Thread Alexander Nasonov
Robert Elz wrote: > Module Name: src > Committed By: kre > Date: Sat May 5 11:28:44 UTC 2018 > > Modified Files: > src/sbin/cgdconfig: cgdconfig.c > > Log Message: > Check whether the cgd device selected is available to be > configured,that is, not already in use, before

Re: Register new acronym in wtf(6) (Re: CVS commit: src/share/misc)

2018-05-05 Thread Alexander Nasonov
Kamil Rytarowski wrote: > On 05.05.2018 11:47, Geoff Wing wrote: > > VLC = Variable Length Code (or the video player I use) > > VLA = Variable Length Array > > It has been fixed... Should I move this term to acronyms.comp? Variable Length Code sounds like a good candidate for our acronyms db if

Re: CVS commit: src/sys/kern

2018-04-12 Thread Alexander Nasonov
Christos Zoulas wrote: > Module Name: src > Committed By: christos > Date: Sun Apr 1 19:29:43 UTC 2018 > > Modified Files: > src/sys/kern: subr_prf.c > > Log Message: > Add the ability to prepend a timestamp [ sec.nsec] relative to boottime > in kernel messages if KLOG_TIMESTAMP

Re: CVS commit: src/sys/netinet

2018-03-31 Thread Alexander Nasonov
Robert Elz wrote: > I totally agree with this - and it is worse when included in commit logs > wherte it will remain, visible, and actually viewed, forever (unlike even > in a mailing list, which while archived forever, somewhere, usually > falls quickly out of view.) Searching for archived email

Re: CVS commit: src/sys/netinet

2018-03-31 Thread Alexander Nasonov
Taylor R Campbell wrote: > They mean different things. > > `hi dev@' means `FYI, dev@, you broke this, so I'm fixing it'. > > `ok dev@' means `dev@ reviewed and approved this change'. I'm well aware they mean different things. > One connotation of `hi dev@' may be `dev@ is an idiot'; it can be

Re: CVS commit: src/sys/netinet

2018-03-29 Thread Alexander Nasonov
m...@netbsd.org wrote: > I seem to recall a discussion about wanting to avoid this type > of commit message (hi dev-name), as it can be seen as excessively > hostile. 'ok rmind@' would definitely be better than 'hi maxv@'. Hostile? I don't think so. I personally quite like it. -- Alex

Re: CVS commit: src/sys/dist/pf/net

2018-02-19 Thread Alexander Nasonov
Christos Zoulas wrote: > + if (so == NULL) > + return -1; > + if (so->so_cred == NULL) { > + DPFPRINTF(PF_DEBUG_URGENT, > + ("%s: so->so_cred == NULL so=%p\n", __func__, so)); > + return -1; > + } > pd->lookup.uid =

Re: CVS commit: src/sys/dist/pf/net

2018-02-19 Thread Alexander Nasonov
Christos Zoulas wrote: > On Feb 19, 10:55pm, al...@yandex.ru (Alexander Nasonov) wrote: > -- Subject: Re: CVS commit: src/sys/dist/pf/net > > | I think it's perfectly normal for an incoming packet to have no > | cred. For instance, if that packet is about to be accepted. > >

Re: CVS commit: src/sys/arch/x86/x86

2017-10-04 Thread Alexander Nasonov
Maxime Villard wrote: > In the first mail, you said that it was better to have a all-or-nothing > sysctl, which is *exactly* what I just committed. Yes, sysctl is better than giving rdtsc to root only. But "better" alone isn't strong enough to count me as a supporter. > In the second one, as a

Re: CVS commit: src/sys/arch/x86/x86

2017-10-03 Thread Alexander Nasonov
Maxime Villard wrote: > In case you didn't notice, this sysctl results directly from the answers I > got, and is not my original plan (about which I changed my mind as a > consequence of the conversation). So now tell me exactly which point I didn't > consider and which reply I ignored. The thread

Re: CVS commit: src

2016-11-07 Thread Alexander Nasonov
Joerg Sonnenberger wrote: > At least for my evbppc64 build this fails to link because it uses > mktemp and -Wl,--fatal-errors. Does it really need a random file name > and can't just use an easier to predict for debugging name in the > current directory? New change is committed. Alex

Re: CVS commit: src/tests

2016-05-24 Thread Alexander Nasonov
Juergen Hannken-Illjes wrote: > Module Name: src > Committed By: hannken > Date: Tue May 24 10:16:34 UTC 2016 > > Modified Files: > src/tests/lib/libbpfjit: Makefile > src/tests/net/bpfjit: Makefile > > Log Message: > Disable PAX mprotect to make just-in-time-compile tests

Re: CVS commit: src/sys/net

2014-11-20 Thread Alexander Nasonov
Christos Zoulas wrote: In article 20141119210214.GA8310@neva, Alexander Nasonov al...@yandex.ru wrote: I don't think SLJIT_UMOD exists. You need to emit SLJIT_SUB after SLJIT_UDIV. This should be pretty straigthforward. But I don't mind if you make a function call for these quite rare

Re: CVS commit: src/sys/net

2014-11-20 Thread Alexander Nasonov
Christos Zoulas wrote: In article 20141119210214.GA8310@neva, Alexander Nasonov al...@yandex.ru wrote: I don't think SLJIT_UMOD exists. You need to emit SLJIT_SUB after SLJIT_UDIV. This should be pretty straigthforward. But I don't mind if you make a function call for these quite rare

Re: CVS commit: src/sys/net

2014-11-19 Thread Alexander Nasonov
Christos Zoulas wrote: Module Name: src Committed By: christos Date: Wed Nov 19 19:34:43 UTC 2014 Modified Files: src/sys/net: bpfjit.c Log Message: Add BPF_MOD/BPF_XOR (untested, needs work) Changes look good. /* + * XXX: Until we support SLJIT_UMOD properly + */

Re: CVS commit: src/sys/net

2014-07-28 Thread Alexander Nasonov
Alexander Nasonov wrote: Module Name: src Committed By: alnsn Date: Mon Jul 28 07:32:46 UTC 2014 Modified Files: src/sys/net: bpf.c Log Message: Enable net.bpf.jit only if MODULAR and BPFJIT. Tweak a warning about postponed jit activation. MODULAR _or_ BPFJIT. Alex

Re: CVS commit: src/lib/librumpuser

2014-07-23 Thread Alexander Nasonov
Justin Cormack wrote: Module Name: src Committed By: justin Date: Tue Jul 22 22:41:58 UTC 2014 Modified Files: src/lib/librumpuser: Makefile rumpfiber.c rumpuser.c rumpuser_int.h rumpuser_port.h Added Files: src/lib/librumpuser: rumpuser_random.c Log

Re: CVS commit: src/sys/arch/mips/include

2014-07-22 Thread Alexander Nasonov
Matt Thomas wrote: On Jul 22, 2014, at 12:54 PM, Alexander Nasonov al...@netbsd.org wrote: Module Name:src Committed By: alnsn Date: Tue Jul 22 19:54:55 UTC 2014 Modified Files: src/sys/arch/mips/include: sljitarch.h Log Message: Define

Re: CVS commit: src/sys/arch/mips/include

2014-07-22 Thread Alexander Nasonov
Matt Thomas wrote: On Jul 22, 2014, at 2:27 PM, Alexander Nasonov al...@yandex.ru wrote: I allocate with the X flag and it seems to work: /* in sljitExecAllocator.c */ return (void *)uvm_km_alloc(module_map, size, PAGE_SIZE, UVM_KMF_WIRED | UVM_KMF_ZERO

Re: CVS commit: src/sys/arch/mips/include

2014-07-22 Thread Alexander Nasonov
Matt Thomas wrote: On Jul 22, 2014, at 2:40 PM, Alexander Nasonov al...@yandex.ru wrote: Matt Thomas wrote: On Jul 22, 2014, at 2:27 PM, Alexander Nasonov al...@yandex.ru wrote: I allocate with the X flag and it seems to work: /* in sljitExecAllocator.c */ return (void

Re: CVS commit: src/sys/arch/arm/include

2014-07-22 Thread Alexander Nasonov
Matt Thomas wrote: On Jul 22, 2014, at 1:16 PM, Alexander Nasonov al...@netbsd.org wrote: Module Name:src Committed By: alnsn Date: Tue Jul 22 20:16:39 UTC 2014 Modified Files: src/sys/arch/arm/include: sljitarch.h Log Message: Add

Re: CVS commit: src/external/mit/lua/dist/src

2014-07-19 Thread Alexander Nasonov
Lourival Pereira Vieira Neto wrote: Module Name: src Committed By: lneto Date: Sat Jul 19 17:11:53 UTC 2014 Modified Files: src/external/mit/lua/dist/src: luaconf.h Log Message: lua(4): preventing division by zero * note: we should raise an error instead of return

Re: CVS commit: src/sys/modules/lua

2014-07-19 Thread Alexander Nasonov
Lourival Pereira Vieira Neto wrote: ... Index: src/sys/modules/lua/stdlib.h diff -u src/sys/modules/lua/stdlib.h:1.1 src/sys/modules/lua/stdlib.h:1.2 --- src/sys/modules/lua/stdlib.h:1.1 Wed Oct 16 19:44:57 2013 +++ src/sys/modules/lua/stdlib.h Sat Jul 19 17:10:02 2014 @@ -1,7 +1,7 @@

Re: CVS commit: src/sys

2014-07-19 Thread Alexander Nasonov
Lourival Pereira Vieira Neto wrote: Module Name: src Committed By: lneto Date: Sat Jul 19 17:13:22 UTC 2014 Modified Files: src/sys/modules/lua: lua.c src/sys/sys: lua.h Log Message: lua(4): added support for running Lua scripts in intr context Please revert this.

Re: CVS commit: src

2014-07-19 Thread Alexander Nasonov
Lourival Pereira Vieira Neto wrote: Module Name: src Committed By: lneto Date: Sat Jul 19 18:38:35 UTC 2014 Modified Files: src/distrib/sets/lists/base: ad.arm ad.mips ad.powerpc md.amd64 md.sparc64 mi shl.mi src/distrib/sets/lists/debug: ad.arm ad.mips

Re: CVS commit: src/sys/modules/lua

2014-07-19 Thread Alexander Nasonov
Lourival Vieira Neto wrote: You can always provide a better hack. Clean someone's mess? No, thanks. I could import Lua 5.3 and rework the kernel bits but you in a hurry to import wip version. I don't think you will be satisfied with a pace of my work. Alex

Re: CVS commit: src/sys

2014-07-19 Thread Alexander Nasonov
Lourival Vieira Neto wrote: Hi Alexander, On Sat, Jul 19, 2014 at 4:39 PM, Alexander Nasonov al...@yandex.ru wrote: ... What if GC kicks-in in softintr? It will call kmem_intr_free(9). How many times? What if the code tries to load a chunk of new code in softintr? What if? Have

Re: CVS commit: src/sys

2014-07-19 Thread Alexander Nasonov
Lourival Vieira Neto wrote: On Sat, Jul 19, 2014 at 5:45 PM, Alexander Nasonov al...@yandex.ru wrote: What if GC kicks-in in softintr? It will call kmem_intr_free(9). How many times? It depends on your script. Ok, let me ask a more general question. Do you mix softintr Lua code

Re: CVS commit: src/sys

2014-07-19 Thread Alexander Nasonov
Lourival Vieira Neto wrote: ... Yes, I do. ... Yes, I am. ... Yes, I have. Good to know. Please document it. Thanks, Alex

Re: CVS commit: src/distrib/sets/lists/debug

2014-07-02 Thread Alexander Nasonov
Hisashi T Fujinaka wrote: Please put it back the way I had it unless you can prove it's broken with debug turned on. Your commit was wrong, it broke sparc, powerpc, mips and arm with MKSLJIT=yes. Alex

Re: CVS commit: src/lib/librumpuser

2014-06-17 Thread Alexander Nasonov
Alan Barrett wrote: Some historical uses of __RCSID have an unnecessary #if/#endif wrapper around them, but for new uses, please just write __RCSID(...); without any #if/#endif wrapper. I copy/pasted this block from another file from the same directory. Alex

Re: CVS commit: src/lib/librumpuser

2014-06-17 Thread Alexander Nasonov
Antti Kantee wrote: To be clear: the objection was to modifying a stable interface without coordination. The hypercall interface is implemented in multiple places outside of the NetBSD tree, including by 3rd parties. Stable interface in -current? How are you supposed to make any significant

Re: CVS commit: src/lib/librumpuser

2014-06-17 Thread Alexander Nasonov
Antti Kantee wrote: I think that will be overengineering it, but if you want to come up with a concrete proposal patch, please. I'd simply use discussion and not rushing commits to avoid issues here. The code is in the tree already. I don't need anything else for sljit. The sljit library

Re: CVS commit: src/lib/librumpuser

2014-06-17 Thread Alexander Nasonov
Antti Kantee wrote: Use RUMPCOMP_USER_SRCS, several examples under src/sys/rump Thanks for the pointer, will do. That's one more indication that sync icache is the wrong level of problem to represent at the interface level. Existence of __clear_cache is an indication of the opposite. I'm not

Re: CVS commit: src/lib/librumpuser

2014-06-17 Thread Alexander Nasonov
Antti Kantee wrote: Ok, one more try, this time with an example: * fact: interface will be used to say I have loaded code here, please arrange things so that it can be executed * fact: you want to call the interface sync icache and possess those semantics the example: Let's assume some

Re: CVS commit: src/lib/librumpuser

2014-06-17 Thread Alexander Nasonov
Valery Ushakov wrote: In that case a local rump header plays that role (either including cdefs.h or providing the necessary definition). Yes, I believe that rumpuser_port.h includes sys/cdefs.h. The conditional is a separate issue and yes it shoud be gc'ed. I agree but I wanted to be

Re: CVS commit: src/sys/arch/amd64/conf

2014-06-12 Thread Alexander Nasonov
matthew green wrote: this comment probably would be nice if it was with all instances of INET6, not just amd64 GENERIC. it certainly will help me a couple of times a year when i end up forgetting... I looked at this. There are 138 files in conf directories with both INET6 and stf in them.

Re: CVS commit: src

2013-12-04 Thread Alexander Nasonov
Lourival Vieira Neto wrote: Are you aware that we have already changed the language number type? Thus, we have already changed the language itself? If you insist, we can call that Lua', kernel Lua, or whatever you like. It's documented: http://www.lua.org/manual/5.2/manual.html#lua_Number

Re: CVS commit: src

2013-12-03 Thread Alexander Nasonov
Lourival Vieira Neto wrote: I wasn't in that thread at that time. However, I'll carefully read it. If you haven't done so yet, it's a good idea to subscribe to source-changes-d@. Anyway, I think that the missing implementation of luai_numpow() doesn't break anything. Do you have a test to

Re: CVS commit: src

2013-12-02 Thread Alexander Nasonov
Lourival Pereira Vieira Neto wrote: Module Name: src Committed By: lneto Date: Mon Dec 2 06:07:22 UTC 2013 Modified Files: src/external/mit/lua/dist/src: luaconf.h src/sys/modules/lua: Makefile Removed Files: src/sys/modules/lua: luaconf.h Log Message:

Re: CVS commit: src

2013-12-02 Thread Alexander Nasonov
Lourival Vieira Neto wrote: Yes, it isn't. But, please note, I didn't change that now. I just merged it in one single file. Though I think we need implement integer exponentiation, I think that is not a priority. IMO, it is a TODO. Well, I assume that any raised issues should be resolved

Re: CVS commit: src

2013-11-16 Thread Alexander Nasonov
+./usr/lib/librumpkern_sljit.so base-rump-shlib rump +./usr/lib/librumpkern_sljit.so.0 base-rump-shlib rump +./usr/lib/librumpkern_sljit.so.0.0 base-rump-shlib rump A similar change was sitting in my local tree for quite a

Re: CVS commit: src/sys/rump/kern

2013-11-16 Thread Alexander Nasonov
Martin Husemann wrote: Log Message: sljit is only available on very few architectures, so do not try to build it on all. We have a special MKSLJIT variable. It's enabled by default on the three arches you listed below but it can also be turned on on arm and mips. Alex To generate a diff of

Re: CVS commit: src/usr.sbin/npf/npftest

2013-11-16 Thread Alexander Nasonov
Mindaugas Rasiukevicius wrote: Module Name: src Committed By: rmind Date: Sat Nov 16 01:41:43 UTC 2013 Modified Files: src/usr.sbin/npf/npftest: Makefile src/usr.sbin/npf/npftest/libnpftest: Makefile npf_bpf_test.c Log Message: Enable bpfjit for npftest. It breaks

Re: CVS commit: src/sys/rump/kern

2013-11-16 Thread Alexander Nasonov
Martin Husemann wrote: I copied the .if from src/sys/modules/Makefile - please feel free to fix both instances. But arm is missing machine/sljitarch.h, so it would not compile. I don't think that sljit supports all arms. If you want bpfjit on arm (or mips) you should build with MKSLJIT=yes.

Re: CVS commit: src/sys/rump/kern

2013-11-16 Thread Alexander Nasonov
Martin Husemann wrote: I copied the .if from src/sys/modules/Makefile - please feel free to fix both instances. But arm is missing machine/sljitarch.h, so it would not compile. I now see where the problem is. I listed those three arches because they support modules but other sljit arches don't

Re: CVS commit: src/sys/modules/lua

2013-10-22 Thread Alexander Nasonov
Alexander Nasonov wrote: +#define exit(EXIT_FAILURE) return You only need to make a change in one place in ldo.c: @@ -105,7 +110,11 @@ void luaD_throw (lua_State *L, int errco lua_unlock(L); G(L)-panic(L); } +#if defined(_KERNEL) +panic(luaD_throw(), errcode=%d

Re: CVS commit: src/sys/modules/lua

2013-10-22 Thread Alexander Nasonov
Christoph Badura wrote: On Tue, Oct 22, 2013 at 09:25:19AM +0100, Alexander Nasonov wrote: We just need to make sure that all entry points to Lua are protected and hope that the above panic will never trigger. Actually, I would prefer if that call to panic wasn't there at all. Instead

Re: CVS commit: src/sys/modules/lua

2013-10-21 Thread Alexander Nasonov
Marc Balmer wrote: Module Name: src Committed By: mbalmer Date: Wed Oct 16 19:44:58 UTC 2013 Added Files: src/sys/modules/lua: Makefile assert.h ctype.h errno.h infinite.lua inttypes.h limits.h locale.h lua.c luaconf.h luavar.h math.h setjmp.h signal.h

Re: CVS commit: src/sys/modules/lua

2013-10-18 Thread Alexander Nasonov
Marc Balmer wrote: Module Name: src Committed By: mbalmer Date: Wed Oct 16 19:44:58 UTC 2013 Added Files: src/sys/modules/lua: Makefile assert.h ctype.h errno.h infinite.lua inttypes.h limits.h locale.h lua.c luaconf.h luavar.h math.h setjmp.h signal.h

Re: CVS commit: src/sys/modules/lua

2013-10-18 Thread Alexander Nasonov
Marc Balmer wrote: This was not an import of Lua. The Lua sources already are in the tree. When we are ready to move from Lua 5.1 to Lua 5.2, Lua 5.2 will be imported to sys/external, as I already mentioned. In this case, kernel changes should have been added to 5.1 source and later ported

Re: CVS commit: src/sys/kern

2013-07-22 Thread Alexander Nasonov
Taylor R Campbell wrote: This shouldn't be necessary: snprintf guarantees null termination. Did you observe a pool name without null termination in pool_init in the wild? I misremembered how snprintf works then. I didn't observe it in the wild but some dtrace code uses long vmem names

Re: CVS commit: src

2012-11-24 Thread Alexander Nasonov
Manuel Bouyer wrote: Why only evbmips, and not all mips platforms ? Shouldn't this be in arch/mips/include/ ? I'm now asking this exact question myself after I moved on to arm world ;-) These two platforms are very diverse. Perhaps I should have sought an advice before restricting myself to

Re: CVS commit: src/external/bsd/sljit

2012-10-04 Thread Alexander Nasonov
David Laight wrote: How long was it there? and was it ever in a build? If not built it can be deleted from the repository. Not for long and it was never hooked to the build. It can be removed but I don't know how. Alex

Re: CVS commit: src/external/bsd/sljit/dist

2012-10-02 Thread Alexander Nasonov
Joerg Sonnenberger wrote: AFAIK, zfs is module-only, e.g. it can't be compiled into the kernel. sljit and bpfjit are modules too. But this may change later, e.g. if we want to use bpfjit in a packet filter. I'll reimport sljit properly. It's a pretty bad example to start from. acpica is saner.

Re: CVS commit: src/external/bsd/sljit/dist

2012-10-01 Thread Alexander Nasonov
Joerg Sonnenberger wrote: If this is intended for kernel use, why is it in src/external? There is an interest to use it as userspace library as well. Alex

Re: CVS commit: src/external/bsd/sljit/dist

2012-10-01 Thread Alexander Nasonov
Joerg Sonnenberger wrote: The kernel should not depend on anything outside src/common and src/sys. It is acceptable for userland to access code from either place. Is it done properly for solaris/zfs? I used as an example. Alex

Re: CVS commit: src/sys

2012-08-07 Thread Alexander Nasonov
Joerg Sonnenberger wrote: I'm quite sure I saw at least either ARM or PPC at some point, but it might be on some branch or so. http://lists.freebsd.org/pipermail/svn-src-head/2009-November/011836.html I couldn't find those PR, though. Alex

Re: CVS commit: src/sys

2012-08-06 Thread Alexander Nasonov
Joerg Sonnenberger wrote: There are other platforms implemented in FreeBSD, not just x86. I see only x86 implementations in head, see below. Are you sure you're not confusing it with Linux? Alex $ svn checkout svn://svn.freebsd.org/base/head/sys ... Asys/sys/fdcio.h Asys/sys/timetc.h

Re: CVS commit: src/sys

2012-08-05 Thread Alexander Nasonov
Mindaugas Rasiukevicius wrote: Log Message: Add BPF JIT compiler, currently supporting amd64 and i386. Code obtained from FreeBSD. Also, make few BPF fixes and simplifications while here. Note that bpf_jit_enable is false for now. OK dyoung@, some feedback from matt@ Inserting bd_bfilter

Re: CVS commit: src/sys

2012-08-04 Thread Alexander Nasonov
Mindaugas Rasiukevicius wrote: Module Name: src Committed By: rmind Date: Wed Aug 1 23:24:29 UTC 2012 Modified Files: src/sys/arch/amd64/conf: files.amd64 std.amd64 src/sys/arch/i386/conf: files.i386 std.i386 src/sys/conf: files src/sys/modules/bpf:

Re: CVS commit: src/sys

2012-08-04 Thread Alexander Nasonov
Alexander Nasonov wrote: FreeBSD calls bpf_filter from bpf_mtap2 rathen than calling jit'ed function because their jit code doesn't support mbuf chain. NetBSD calls bpf_deliver from _bpf_mtap2 which in turn calls jit'ed function. I think it's wrong because JIT code in NetBSD doesn't support

Re: CVS commit: src/sys

2012-08-03 Thread Alexander Nasonov
Mindaugas Rasiukevicius wrote: Hi Alex, The code from FreeBSD is pretty small and simple. It is also mature and more widely tested. I agree with the above. But their code is only for quite powerful x86 cpus. If you want to support arm or mips, someone has to make two new implementations. If

Re: CVS commit: src/sys

2012-08-02 Thread Alexander Nasonov
Mindaugas Rasiukevicius wrote: Log Message: Add BPF JIT compiler, currently supporting amd64 and i386. Code obtained from FreeBSD. Also, make few BPF fixes and simplifications while here. Note that bpf_jit_enable is false for now. I wonder why do you want to generate code yourself while

Re: CVS commit: src/external/mit/lua/dist/src

2012-03-15 Thread Alexander Nasonov
Bernd Ernesti wrote: It would be great to have a short summary in the cvs import log what changed in the new version instead of just 'Import Lua 5.1.5'. That doesn't have to be the full changelog. I agree. I was merely following comments in bind2netbsd script. Perhaps, the comment should be

Re: CVS commit: src/external/mit/lua/dist/src

2012-03-14 Thread Alexander Nasonov
Alexander Nasonov wrote: Log Message: Don't overwrite Roberto's external $Id. This made me realise that all external $Id were changed to Id by the previous import and that there is a script that does this replacement (external/mit/lua/dist/lua2netbsd). I will use it next time. Hopefully

Re: CVS commit: src/sys/kern

2012-01-31 Thread Alexander Nasonov
David Young wrote: Yuck. The offsetof() way was much more readable. Yes, it's more readable but it's not standard C99. And it's confusing to use offsetof when you want to use sizeof. Please put it back the old way. If you have to, provide and use a runtime_offsetof() that DTRT. DTRT TWW ;-)

Re: CVS commit: src/sys/kern

2012-01-31 Thread Alexander Nasonov
Joerg Sonnenberger wrote: On Tue, Jan 31, 2012 at 07:32:52PM +, Alexander Nasonov wrote: #define sizeof_fam(s, m, n) (sizeof(s) + sizeof(((s *)NULL)-m[0]) * (n)) That's still not necessarily optimal, depending on the padding rules of the platform. You want to do offsetof(s, m[0]) + n

  1   2   >