Re: CVS commit: src/lib/libedit
Am 19.05.14 21:54, schrieb Christos Zoulas:
Module Name: src
Committed By: christos
Date: Mon May 19 19:54:12 UTC 2014
Modified Files:
src/lib/libedit: tty.c tty.h
Log Message:
more tty modes refactoring, no functional change intended.
To generate a diff of this commit:
cvs rdiff -u -r1.43 -r1.44 src/lib/libedit/tty.c
cvs rdiff -u -r1.14 -r1.15 src/lib/libedit/tty.h
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/lib/libedit/tty.c
diff -u src/lib/libedit/tty.c:1.43 src/lib/libedit/tty.c:1.44
--- src/lib/libedit/tty.c:1.43Mon May 19 13:14:41 2014
+++ src/lib/libedit/tty.c Mon May 19 15:54:12 2014
@@ -1,4 +1,4 @@
-/* $NetBSD: tty.c,v 1.43 2014/05/19 17:14:41 christos Exp $*/
+/* $NetBSD: tty.c,v 1.44 2014/05/19 19:54:12 christos Exp $*/
/*-
* Copyright (c) 1992, 1993
@@ -37,7 +37,7 @@
#if 0
static char sccsid[] = @(#)tty.c8.1 (Berkeley) 6/4/93;
#else
-__RCSID($NetBSD: tty.c,v 1.43 2014/05/19 17:14:41 christos Exp $);
+__RCSID($NetBSD: tty.c,v 1.44 2014/05/19 19:54:12 christos Exp $);
#endif
#endif /* not lint not SCCSID */
@@ -919,6 +919,58 @@ tty_bind_char(EditLine *el, int force)
}
+private tcflag_t *
private? I think you mean static, right?
+tty__get_flag(struct termios *t, int kind) {
+ switch (kind) {
+ case MD_INP:
+ return t-c_iflag;
+ case MD_OUT:
+ return t-c_oflag;
+ case MD_CTL:
+ return t-c_cflag;
+ case MD_LIN:
+ return t-c_lflag;
+ default:
+ abort();
+ /*NOTREACHED*/
+ }
+}
+
+
+private tcflag_t
dito
+tty_update_flag(EditLine *el, tcflag_t f, int mode, int kind)
+{
+ f = ~el-el_tty.t_t[mode][kind].t_clrmask;
+ f |= el-el_tty.t_t[mode][kind].t_setmask;
+ return f;
+}
+
+
+private void
dito
+tty_update_flags(EditLine *el, int kind)
+{
+ tcflag_t *tt, *ed, *ex;
+ tt = tty__get_flag(el-el_tty.t_ts, kind);
+ ed = tty__get_flag(el-el_tty.t_ed, kind);
+ ex = tty__get_flag(el-el_tty.t_ex, kind);
+
+ if (*tt != *ex (kind != MD_CTL || *tt != *ed)) {
+ *ed = tty_update_flag(el, *tt, ED_IO, kind);
+ *ex = tty_update_flag(el, *tt, EX_IO, kind);
+ }
+}
+
+
+private void
dito
+tty_update_char(EditLine *el, int mode, int c) {
+ if (!((el-el_tty.t_t[mode][MD_CHAR].t_setmask C_SH(c)))
+ (el-el_tty.t_c[TS_IO][c] != el-el_tty.t_c[EX_IO][c]))
+ el-el_tty.t_c[mode][c] = el-el_tty.t_c[TS_IO][c];
+ if (el-el_tty.t_t[mode][MD_CHAR].t_clrmask C_SH(c))
+ el-el_tty.t_c[mode][c] = el-el_tty.t_vdisable;
+}
+
+
[...]
Christoph
Re: CVS commit: src/sys/sys
Am 29.03.14 20:30, schrieb Christos Zoulas:
Module Name: src
Committed By: christos
Date: Sat Mar 29 19:30:49 UTC 2014
Modified Files:
src/sys/sys: param.h
Log Message:
sprintf removal
{pci,eisa}_intr_string signature change
To generate a diff of this commit:
cvs rdiff -u -r1.447 -r1.448 src/sys/sys/param.h
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/sys/param.h
diff -u src/sys/sys/param.h:1.447 src/sys/sys/param.h:1.448
--- src/sys/sys/param.h:1.447 Mon Mar 24 09:42:40 2014
+++ src/sys/sys/param.h Sat Mar 29 15:30:49 2014
@@ -1,4 +1,4 @@
-/* $NetBSD: param.h,v 1.447 2014/03/24 13:42:40 hannken Exp $ */
+/* $NetBSD: param.h,v 1.448 2014/03/29 19:30:49 christos Exp $ */
/*-
* Copyright (c) 1982, 1986, 1989, 1993
@@ -63,7 +63,7 @@
* 2.99.9 (299000900)
*/
-#define __NetBSD_Version__ 699003800 /* NetBSD 6.99.38 */
+#define __NetBSD_Version__ 699003800 /* NetBSD 6.99.39 */
change in comment only is not enough.
Christoph
Re: CVS commit: src/sys/arch/amd64/conf
Am 15.03.14 20:18, schrieb John Nemeth: On Mar 15, 1:50pm, Jonathan A. Kollasch wrote: } } Module Name:src } Committed By: jakllsch } Date: Sat Mar 15 13:50:01 UTC 2014 } } Modified Files: } src/sys/arch/amd64/conf: XEN3_DOMU } } Log Message: } Enable PCI support in amd64 XEN3_DOMU config to match i386 XEN3_DOMU config. PCI support in a DOMU kernel would only be useful when the DOM0 is setup with pci passthrough for some device, which isn't the norm. My answer would be to go the opposite way and disable PCI support in both kernels. Also, simply enabling PCI support without adding a whole schwak of PCI devices isn't very useful. As well, I don't think PCI passthrough is working with modern versions of Xen. PCI passthrough does work as upstream QEMU got the patches now. The actual missing part is the NetBSD adaption of the PCI access code in QEMU and in libxl. Christoph
Re: CVS commit: src/external/gpl3/gcc
On 26.02.14 11:50, matthew green wrote:
Module Name: src
Committed By: mrg
Date: Wed Feb 26 10:50:23 UTC 2014
Added Files:
src/external/gpl3/gcc: gcc2gcc.old
Log Message:
script to copy gcc to gcc.old, ready for importing.
To generate a diff of this commit:
cvs rdiff -u -r0 -r1.1 src/external/gpl3/gcc/gcc2gcc.old
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Added files:
Index: src/external/gpl3/gcc/gcc2gcc.old
diff -u /dev/null src/external/gpl3/gcc/gcc2gcc.old:1.1
--- /dev/null Wed Feb 26 10:50:23 2014
+++ src/external/gpl3/gcc/gcc2gcc.old Wed Feb 26 10:50:23 2014
@@ -0,0 +1,63 @@
+#! /bin/sh
+#
+#$NetBSD: gcc2gcc.old,v 1.1 2014/02/26 10:50:23 mrg Exp $
+
+# run it like eg:
+#
+# % ./gcc2gcc.old /usr/src/external/gpl3/gcc /home/import/gcc
+
+doit=echo
+doit=
Isn't that a nop?
+
+progname=$(basename $0)
+
+usage() {
+ echo Usage: $progname src/external/gpl3/gcc copy-to-dir 12
+ edho Note that copy-to-dir must not exist. 12
s/edho/echo/
+ exit 1
+}
+
+#set -x
+set -e
+
+srcdir=$1
+destdir=$2
+
+if [ -z $srcdir -o -z $destdir ]; then
+ usage
+fi
+
+if [ ! -d $srcdir ]; then
+ echo srcdir '$srcdir' is not a directory 12
+ usage
+fi
+if [ -e $destdir ]; then
+ echo destdir '$destdir' is something 12
+ ls -ld $destdir
+ usage
+fi
+
+# Assumes that ../gcc/. == .
+cd $srcdir/..
+if [ ! -d gcc ]; then
+ echo $srcdir/../gcc doesn't exist. 12
+ usage
+fi
+
+echo Copying files to $destdir...
+$doit pax -rwpp gcc $destdir
+
+
+# clean the copy
+echo Cleaning CVS turds and ChangeLogs
+$doit find $destdir -name .CVS -exec rm -rf {} +
+$doit find $destdir -name CVS -exec rm -rf {} +
+$doit find $destdir -name ChangeLog* -exec rm -f {} +
+$doit rm -f $destdir/gcc2netbsd $destdir/gcc2gcc.old
+
+date=$(date +%Y%m%M-%H%M)
I think, it isn't necessary to invoke a subshell.
date=`date +%Y%m%M-%H%M` is enough.
Christoph
+echo GCC copied to gcc.old. use these commands to import:
+echo cd $destdir/gcc
+echo cvs import src/external/gpl3/gcc.old NetBSD src-external-gpl3-gcc-$date
+
+exit 0
Re: CVS commit: src
Am 13.02.14 00:24, schrieb David Laight: [...] Index: src/sys/arch/amd64/amd64/cpufunc.S diff -u src/sys/arch/amd64/amd64/cpufunc.S:1.24 src/sys/arch/amd64/amd64/cpufunc.S:1.25 --- src/sys/arch/amd64/amd64/cpufunc.S:1.24 Sun Feb 9 19:42:04 2014 +++ src/sys/arch/amd64/amd64/cpufunc.SWed Feb 12 23:24:09 2014 @@ -1,4 +1,4 @@ -/* $NetBSD: cpufunc.S,v 1.24 2014/02/09 19:42:04 dsl Exp $ */ +/* $NetBSD: cpufunc.S,v 1.25 2014/02/12 23:24:09 dsl Exp $ */ /*- * Copyright (c) 1998, 2007, 2008 The NetBSD Foundation, Inc. @@ -441,6 +441,10 @@ ENTRY(fnstcw) fnstcw (%rdi) ret +ENTRY(fngetsw) + fnstsw %ax + ret + Not sure if you mean fngetsw here (copy paste) ? Christoph ENTRY(fnstsw) fnstsw (%rdi) ret @@ -480,7 +484,7 @@ ENTRY(fxrstor) ENTRY(fldummy) ffree %st(7) - flds(%rdi) + fldz ret ENTRY(xsave)
Re: CVS commit: [netbsd-6] src/usr.bin/gzip
Am 05.12.13 19:44, schrieb Manuel Bouyer:
Module Name: src
Committed By: bouyer
Date: Thu Dec 5 18:44:26 UTC 2013
Modified Files:
src/usr.bin/gzip [netbsd-6]: zmore
Log Message:
Pull up following revision(s) (requested by pettai in ticket #982):
distrib/sets/lists/base/mi: revision 1.1049
distrib/sets/lists/man/mi: revision 1.1449
usr.bin/gzip/Makefile: revision 1.17
usr.bin/gzip/Makefile: revision 1.18
usr.bin/gzip/zmore: revision 1.4
usr.bin/gzip/zmore.1: revision 1.4
Added zless(1) - comes in the lastest version of zmore(1) from OpenBSD
(OKed by tron@)
Add zfgrep that fell off from last update
To generate a diff of this commit:
cvs rdiff -u -r1.3 -r1.3.52.1 src/usr.bin/gzip/zmore
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/usr.bin/gzip/zmore
diff -u src/usr.bin/gzip/zmore:1.3 src/usr.bin/gzip/zmore:1.3.52.1
--- src/usr.bin/gzip/zmore:1.3Mon Mar 29 09:59:42 2004
+++ src/usr.bin/gzip/zmoreThu Dec 5 18:44:26 2013
@@ -1,8 +1,8 @@
#!/bin/sh -
#
-# $NetBSD: zmore,v 1.3 2004/03/29 09:59:42 wiz Exp $
+# $NetBSD: zmore,v 1.3.52.1 2013/12/05 18:44:26 bouyer Exp $
#
-# $OpenBSD: zmore,v 1.4 2003/07/29 07:42:45 otto Exp $
+# $OpenBSD: zmore,v 1.6 2008/08/20 09:22:02 mpf Exp $
#
# Copyright (c) 2003 Todd C. Miller todd.mil...@courtesan.com
#
@@ -41,6 +41,12 @@ while test $# -ne 0; do
esac
done
+if [ `basename $0` == zless ] ; then
The == is bash'ism.
Christoph
+ pager=${PAGER-less}
+else
+ pager=${PAGER-more}
+fi
+
# No files means read from stdin
if [ $# -eq 0 ]; then
gzip -cdfq 21 | ${PAGER-more} $flags
Re: CVS commit: src/sys
Am 23.11.13 17:15, schrieb Jeff Rizzo: Module Name: src Committed By: riz Date: Sat Nov 23 16:15:25 UTC 2013 Modified Files: src/sys/coda: coda_vfsops.c src/sys/compat/netbsd32: netbsd32_compat_20.c src/sys/compat/osf1: osf1_mount.c src/sys/compat/ultrix: ultrix_fs.c src/sys/gdbscripts: vchain Log Message: Since mountlist is now a TAILQ, convert some missed usages so things build again. Why don't you use the TAILQ macros? I saw christos@ already did that for coda_vfsops.c. Christoph
Re: CVS commit: src/sys/arch/x86/pci
On 12.11.13 16:08, SAITOH Masanobu wrote: Module Name: src Committed By: msaitoh Date: Tue Nov 12 15:08:01 UTC 2013 Modified Files: src/sys/arch/x86/pci: amdtemp.c Log Message: Calcurate the processor family correctly. The extended family bits should be added only when the base family is 0xf. The old code is correct as the extended family bits are 0 when base family is 0xf. Also, the amdtemp driver does not attach on such old cpus. Christoph
Re: CVS commit: src/sys/arch/x86/pci
On 12.11.13 16:38, SAITOH Masanobu wrote: (2013/11/13 0:12), Christoph Egger wrote: On 12.11.13 16:08, SAITOH Masanobu wrote: Module Name:src Committed By: msaitoh Date: Tue Nov 12 15:08:01 UTC 2013 Modified Files: src/sys/arch/x86/pci: amdtemp.c Log Message: Calcurate the processor family correctly. The extended family bits should be added only when the base family is 0xf. The old code is correct as the extended family bits are 0 when base family is 0xf. Also, the amdtemp driver does not attach on such old cpus. Christoph My change doesn't break anything, right? It's intentional. No, it does not break anything. I'm now fixing and rewriting macros for cpu family and model to avoid trivial bugs and to reduce the code duplication. Ok. Christoph
Re: CVS commit: src/external/lgpl3/gmp/dist
On 16.12.12 15:40, Christoph Egger wrote: Module Name:src Committed By: cegger Date: Sun Dec 16 14:40:08 UTC 2012 Modified Files: src/external/lgpl3/gmp/dist: gmp-h.in Log Message: Always use extern __inline__ with gcc= 4.2. Fall back to prototypes on older gcc versions. Fixes link errors (duplicate symbols) when mpfr's configure check for libgmp Forgot to mention this has been discussed on tech-toolchain. Christoph
Re: CVS commit: src/sys/dev/usb
On 07/17/12 02:56, matthew green wrote: Module Name:src Committed By: mrg Date: Sun Jul 15 21:13:31 UTC 2012 Modified Files: src/sys/dev/usb: usb_subr.c usbdi.c usbdi.h usbdivar.h Log Message: commit my workaround for PR 46648 for now, as the more involved fix is not ready yet: move the clear endpoint stall async call into the task thread, to avoid trying to call kmem_alloc() from a softint thread. XXX ideally moving callbacks into the task thread (or perhaps a different high priority task thread) would be better than this workaround, once that method is working. I get this at boot now: panic: lockdebug_lookup: uninitialized lock (lock=0x80d3fe28, from=806fd980) fatal breakpoint trap in supervisor mode trap type 1 code 0 rip 80212035 cs e030 rflags 246 cr2 0 ilevel 8 rsp a00019f0d910 curlwp 0xa13e2c00 pid 0 lid 26 lowest kstack 0xa00019f0a000 Stopped in pid 0.26 (system) at netbsd:breakpoint+0x5: leave breakpoint() at netbsd:breakpoint+0x5 vpanic() at netbsd:vpanic+0x1f2 printf_nolog() at netbsd:printf_nolog lockdebug_wantlock() at netbsd:lockdebug_wantlock+0x18f mutex_enter() at netbsd:mutex_enter+0x27b usb_rem_task() at netbsd:usb_rem_task+0x2b usbd_kill_pipe() at netbsd:usbd_kill_pipe+0x56 usbd_new_device() at netbsd:usbd_new_device+0x41b usb_doattach() at netbsd:usb_doattach+0xea config_interrupts_thread() at netbsd:config_interrupts_thread+0x30 can you show the prior messages please? what usb devices do you have? [...] ohci0 at pci0 dev 3 function 0: ServerWorks HT1000 USB (rev. 0x01) csr: 02b00017 ohci0: interrupting at ioapic0 pin 10, event channel 10 ohci0: OHCI version 1.0, legacy support usb0 at ohci0: USB revision 1.0 usb0: WARNING: power management not supported ohci1 at pci0 dev 3 function 1: ServerWorks HT1000 USB (rev. 0x01) csr: 02b00017 ohci1: interrupting at ioapic0 pin 10, event channel 10 ohci1: OHCI version 1.0, legacy support usb1 at ohci1: USB revision 1.0 usb1: WARNING: power management not supported ehci0 at pci0 dev 3 function 2: ServerWorks HT1000 USB (rev. 0x01) ehci0: interrupting at ioapic0 pin 10, event channel 10 ehci0: companion controllers, 2 ports each: ohci0 ohci1 usb2 at ehci0: USB revision 2.0 usb2: WARNING: power management not supported [...] isa0 at pcib0 com1 at isa0 port 0x2f8-0x2ff irq 3: ns16550a, working fifo Initializing SSP: bd0cbf008749bd1a 40f970fb37887ac0 90dc8e711387bd49 21a5a4e2c1c59735 1d0d45e934bd8cce ecdb4bec302d0b3 8b7214a3b549393f dbea3b25db036a83 scsibus0: waiting 2 seconds for devices to settle... svwsata0 port 0: device present, speed: 1.5Gb/s panic: lockdebug_lookup: uninitialized lock (lock=0x80d3fe28, from=806fd910) fatal breakpoint trap in supervisor mode trap type 1 code 0 rip 80212035 cs e030 rflags 246 cr2 0 ilevel 8 rsp a00019f21930 curlwp 0xa13a6800 pid 0 lid 31 lowest kstack 0xa00019f1e000 Stopped in pid 0.31 (system) at netbsd:breakpoint+0x5: leave breakpoint() at netbsd:breakpoint+0x5 vpanic() at netbsd:vpanic+0x1f2 printf_nolog() at netbsd:printf_nolog lockdebug_wantlock() at netbsd:lockdebug_wantlock+0x18f mutex_enter() at netbsd:mutex_enter+0x27b usb_rem_task() at netbsd:usb_rem_task+0x2b usbd_kill_pipe() at netbsd:usbd_kill_pipe+0x56 usbd_new_device() at netbsd:usbd_new_device+0x41b usb_doattach() at netbsd:usb_doattach+0xe1 config_interrupts_thread() at netbsd:config_interrupts_thread+0x30 Christoph
Re: CVS commit: src/sys/dev/usb
On 07/17/12 11:25, Christoph Egger wrote: On 07/17/12 02:56, matthew green wrote: Module Name: src Committed By: mrg Date: Sun Jul 15 21:13:31 UTC 2012 Modified Files: src/sys/dev/usb: usb_subr.c usbdi.c usbdi.h usbdivar.h Log Message: commit my workaround for PR 46648 for now, as the more involved fix is not ready yet: move the clear endpoint stall async call into the task thread, to avoid trying to call kmem_alloc() from a softint thread. XXX ideally moving callbacks into the task thread (or perhaps a different high priority task thread) would be better than this workaround, once that method is working. I get this at boot now: panic: lockdebug_lookup: uninitialized lock (lock=0x80d3fe28, from=806fd980) fatal breakpoint trap in supervisor mode trap type 1 code 0 rip 80212035 cs e030 rflags 246 cr2 0 ilevel 8 rsp a00019f0d910 curlwp 0xa13e2c00 pid 0 lid 26 lowest kstack 0xa00019f0a000 Stopped in pid 0.26 (system) at netbsd:breakpoint+0x5: leave breakpoint() at netbsd:breakpoint+0x5 vpanic() at netbsd:vpanic+0x1f2 printf_nolog() at netbsd:printf_nolog lockdebug_wantlock() at netbsd:lockdebug_wantlock+0x18f mutex_enter() at netbsd:mutex_enter+0x27b usb_rem_task() at netbsd:usb_rem_task+0x2b usbd_kill_pipe() at netbsd:usbd_kill_pipe+0x56 usbd_new_device() at netbsd:usbd_new_device+0x41b usb_doattach() at netbsd:usb_doattach+0xea config_interrupts_thread() at netbsd:config_interrupts_thread+0x30 Fixed in usb.c rev 1.131. Christoph
Re: CVS commit: src/sys/dev/usb
On 07/15/12 23:13, matthew green wrote: Module Name: src Committed By: mrg Date: Sun Jul 15 21:13:31 UTC 2012 Modified Files: src/sys/dev/usb: usb_subr.c usbdi.c usbdi.h usbdivar.h Log Message: commit my workaround for PR 46648 for now, as the more involved fix is not ready yet: move the clear endpoint stall async call into the task thread, to avoid trying to call kmem_alloc() from a softint thread. XXX ideally moving callbacks into the task thread (or perhaps a different high priority task thread) would be better than this workaround, once that method is working. I get this at boot now: panic: lockdebug_lookup: uninitialized lock (lock=0x80d3fe28, from=806fd980) fatal breakpoint trap in supervisor mode trap type 1 code 0 rip 80212035 cs e030 rflags 246 cr2 0 ilevel 8 rsp a00019f0d910 curlwp 0xa13e2c00 pid 0 lid 26 lowest kstack 0xa00019f0a000 Stopped in pid 0.26 (system) at netbsd:breakpoint+0x5: leave breakpoint() at netbsd:breakpoint+0x5 vpanic() at netbsd:vpanic+0x1f2 printf_nolog() at netbsd:printf_nolog lockdebug_wantlock() at netbsd:lockdebug_wantlock+0x18f mutex_enter() at netbsd:mutex_enter+0x27b usb_rem_task() at netbsd:usb_rem_task+0x2b usbd_kill_pipe() at netbsd:usbd_kill_pipe+0x56 usbd_new_device() at netbsd:usbd_new_device+0x41b usb_doattach() at netbsd:usb_doattach+0xea config_interrupts_thread() at netbsd:config_interrupts_thread+0x30 Christoph
Re: CVS commit: src/sys/arch/xen
On 24.06.12 20:31, Jean-Yves Migeon wrote: Module Name:src Committed By: jym Date: Sun Jun 24 18:31:53 UTC 2012 Modified Files: src/sys/arch/xen/include: xenpmap.h src/sys/arch/xen/x86: xen_pmap.c Log Message: Enable the map/unmap recursive mapping functions for all Xen ports for save/restore. For an unknown reason (to me) Xen refuses to update VM translations when the entry is pointing back to itself (which is precisely what our recursive VM model does). So enable the functions that take care of this, which will avoid all sort of memory corruption upon restore leading domU to trample upon itself. Please report this Xen behaviour to xen-devel. Christoph Save/restore works again for amd64. The occasional domU frontend corruption is still present, but is harmless to dom0. Now we have a working shell and ddb inside domU, that helps debugging a tiny bit. XXX pull-up to -6.
Re: CVS commit: src/tests/lib/libc/gen (address alignment)
On 21.04.12 19:38, Jean-Yves Migeon wrote: Le 21/04/12 16:31, Jean-Yves Migeon a écrit : Okay, thanks for the report. So this rules out Virtual Box, it seems to happen on native amd64 too. I am taking a look right now. This seems to be a bug in the trap handling code. The signal is caught correctly (it reaches T_ALIGNFLT|T_USER in trap()), but things blow up just after: we end signalling the process with a SIGILL (which does not come from trap()). Using 32 bits compat mode (cc -m 32) also causes the crash. So something in e_trapsignal() or userret() goes wrong. Still digging. Interesting. The uncatchable SIGILL comes from sendsig_siginfo [1] and is used in a way that the signal will force-exit the program (when the copyout fails). It's a feature I was not aware of. Anyway, upon entering trap() for this exception (trap11), it looks like the trapframe is a mess: pid 470 (malign): BUS/SEGV (107) at rip 0 addr 7f7ff7701020 rip 0x0 rsp 0x50202 rfl 0x1f rdi 0x7f7ff7701080 rsi 0x8 rdx 0xf7701078 rcx 0x0 r8 0x7 r9 0x7f7ff770178 [...] rip 0x0 and rsp 0x50202 look really abnormal to me. I'll have a look in FreeBSD, that's probably a group of exceptions that have to be handled differently. rip 0x0 often means that a function pointer has been called which is NULL. Christoph
Re: CVS commit: src/sys/arch
On 04/13/12 15:19, Paul Goyette wrote: I think you may also need to update src/sys/modules/amdtemp/amdtemp.ioconf Thanks for pointing this out. Done. Christoph On Fri, 13 Apr 2012, Christoph Egger wrote: Module Name: src Committed By: cegger Date: Fri Apr 13 13:11:17 UTC 2012 Modified Files: src/sys/arch/amd64/conf: GENERIC XEN3_DOM0 src/sys/arch/i386/conf: ALL GENERIC XEN3_DOM0 src/sys/arch/x86/pci: amdtemp.c files.pci Added Files: src/sys/arch/x86/pci: amdnb_misc.c Log Message: Replace amdtempbus with amdnb_miscbus. This allows us to have independent drivers on the same device (northbridge f3) each coming with a certain functionality/feature. This way we do not need to mess with amdtemp(4) to utilize other features.. To generate a diff of this commit: cvs rdiff -u -r1.352 -r1.353 src/sys/arch/amd64/conf/GENERIC cvs rdiff -u -r1.81 -r1.82 src/sys/arch/amd64/conf/XEN3_DOM0 cvs rdiff -u -r1.335 -r1.336 src/sys/arch/i386/conf/ALL cvs rdiff -u -r1.1070 -r1.1071 src/sys/arch/i386/conf/GENERIC cvs rdiff -u -r1.64 -r1.65 src/sys/arch/i386/conf/XEN3_DOM0 cvs rdiff -u -r0 -r1.1 src/sys/arch/x86/pci/amdnb_misc.c cvs rdiff -u -r1.14 -r1.15 src/sys/arch/x86/pci/amdtemp.c cvs rdiff -u -r1.13 -r1.14 src/sys/arch/x86/pci/files.pci Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. !DSPAM:4f8826141989530048591! - | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com | | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | -
Re: CVS commit: src/sys/arch
On 13.04.12 19:58, Nicolas Joly wrote:
On Fri, Apr 13, 2012 at 01:11:17PM +, Christoph Egger wrote:
Module Name: src
Committed By:cegger
Date:Fri Apr 13 13:11:17 UTC 2012
Modified Files:
src/sys/arch/amd64/conf: GENERIC XEN3_DOM0
src/sys/arch/i386/conf: ALL GENERIC XEN3_DOM0
src/sys/arch/x86/pci: amdtemp.c files.pci
Added Files:
src/sys/arch/x86/pci: amdnb_misc.c
Log Message:
Replace amdtempbus with amdnb_miscbus.
This allows us to have independent drivers on the same device (northbridge
f3)
each coming with a certain functionality/feature.
This way we do not need to mess with amdtemp(4) to utilize other features.
Hi Christoph,
This change seems incomplete. You removed the amdtempbus definition
from files.pci but a few uses remains :
njoly@lynche [arch/x86] pwd
/local/src/NetBSD/src/sys/arch/x86
njoly@lynche [arch/x86] grep amdtempbus **/*
pci/pchb.c:static void pchb_amdtempbus_configure(struct pchb_softc
*);
pci/pchb.c: pchb_amdtempbus_configure(sc);
pci/pchb.c: if (ifattr_match(ifattr,amdtempbus))
pci/pchb.c: pchb_amdtempbus_configure(sc);
pci/pchb.c: if (sc-sc_amdtempbus == child) {
pci/pchb.c: sc-sc_amdtempbus = NULL;
pci/pchb.c:pchb_amdtempbus_configure(struct pchb_softc *sc)
pci/pchb.c: if (sc-sc_amdtempbus != NULL)
pci/pchb.c: sc-sc_amdtempbus =
config_found_ia(sc-sc_dev,amdtempbus,sc-sc_pa,NULL);
pci/pchbvar.h: device_t sc_amdtempbus;
oh, I wasn't aware of that at all. Actually I am tempted
to revert rev 1.32 of pci/pchb.c.
But I want to test that change on monday first before
I commit that then.
And this makes my kernel panic as soon as it tries to search for
childs in pchb(4) configuration :
[...]
ipmi0 at mainbus0
pci0 at mainbus0 bus 0: configuration mode 1
pchb0 at pci0 dev 0 function 0: ATI Technologies RD890 North Bridge Dual Slot
2x16 GFX (rev. 0x02)
panic: kernel diagnostic assertion !ifattr ||
cfdriver_get_iattr(parent-dv_cfdriver,ifattr)failed: file
/local/src/NetBSD/src/sys/kern/subr_autoconf.c,line 945
fatal breakpoint trap in supervisor mode
trap type 1 code 0 rip 80254b25 cs 8 rflags 246 cr2 0 cpl 8 rsp
8133c830
Stopped in pid 0.1 (system) at netbsd:breakpoint+0x5: leave
db{0} bt
breakpoint() at netbsd:breakpoint+0x5
vpanic() at netbsd:vpanic+0x1f2
kern_assert() at netbsd:kern_assert+0x48
config_search_loc() at netbsd:config_search_loc+0x15d
config_found_sm_loc() at netbsd:config_found_sm_loc+0x2b
pchbattach() at netbsd:pchbattach+0x248
config_attach_loc() at netbsd:config_attach_loc+0x182
pci_probe_device() at netbsd:pci_probe_device+0x4a6
pci_enumerate_bus() at netbsd:pci_enumerate_bus+0x189
pcirescan() at netbsd:pcirescan+0x47
pciattach() at netbsd:pciattach+0x196
config_attach_loc() at netbsd:config_attach_loc+0x182
mp_pci_scan() at netbsd:mp_pci_scan+0xa4
mainbus_attach() at netbsd:mainbus_attach+0x35e
config_attach_loc() at netbsd:config_attach_loc+0x182
cpu_configure() at netbsd:cpu_configure+0x26
main() at netbsd:main+0x2b0
Yes, I got exactly the same panic and was wondering whether
that KASSERT is wrong or not. cfdriver_get_iattr() returns NULL.
Removing the KASSERT makes the machine boot for me and things
continue to work as expected.
Christoph
Re: CVS commit: src/sys/arch/xen/xen
On 12/08/11 04:34, Cherry G. Mathew wrote: Module Name:src Committed By: cherry Date: Thu Dec 8 03:34:48 UTC 2011 Modified Files: src/sys/arch/xen/xen: evtchn.c Log Message: kmem_free() the appropriate size. Thanks cegger@ This is still not enough: In pirq_establish() you allocate sizeof(struct pintrhand) but in event_remove_handler you free sizeof(struct intrhand). And sizeof(struct pintrhand) != sizeof(intrhand). We need a ih_size field to track the right size. Christoph
Re: amd64 direct map causing crashes at boot (Re: CVS commit: src/sys/arch)
On 08.12.11 23:17, Manuel Bouyer wrote: On Thu, Dec 08, 2011 at 11:10:41PM +0100, Nicolas Joly wrote: That was me. I do have two machines that fail to boot with this change. 1) A Dell Optiplex 740 that reboots early after loading the kernel. Includes 1 AMD Athlon(tm) 64 X2 Dual Core Processor 4800+ CPU. 2) A Supermicro H8DG6-F motherboard (only 1 socket populated) later on boot mostly when sshd start (or fc-cache is updated). Includes 1 AMD Opteron(tm) Processor 6128A CPU Do they announce 1GB pages support ? AMD CPUs family 0x10 and later announce 1GB page support. Christoph
Re: CVS commit: src
On 11/23/11 11:47, Thor Lancelot Simon wrote: Module Name:src Committed By: tls Date: Wed Nov 23 10:47:50 UTC 2011 Modified Files: src/distrib/sets/lists/etc: mi src/etc/defaults: rc.conf src/etc/rc.d: Makefile src/sbin/rndctl: rndctl.8 rndctl.c src/sys/dev: rnd.c src/sys/secmodel/securelevel: secmodel_securelevel.c src/sys/secmodel/suser: secmodel_suser.c src/sys/sys: kauth.h rnd.h Added Files: src/etc/rc.d: random_seed Log Message: Load entropy at system boot (only works at securelevel 1); save at system shutdown. Disable with random_seed=NO in rc.conf if desired. Goes to some trouble to never load or save to network filesystems. Entropy should really be loaded by the boot loader but I am still sorting out how to pass it to the kernel. How about passing it as a module similar to the multiboot technique? Christoph
Re: CVS commit: src/sys/dev/wscons
On 11.09.11 21:19, Jonathan A. Kollasch wrote:
Module Name: src
Committed By: jakllsch
Date: Sun Sep 11 19:19:19 UTC 2011
Modified Files:
src/sys/dev/wscons: wsmouse.c
Log Message:
Initialize the W axis value on open as is already done for the other axes.
To generate a diff of this commit:
cvs rdiff -u -r1.62 -r1.63 src/sys/dev/wscons/wsmouse.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/dev/wscons/wsmouse.c
diff -u src/sys/dev/wscons/wsmouse.c:1.62 src/sys/dev/wscons/wsmouse.c:1.63
--- src/sys/dev/wscons/wsmouse.c:1.62 Thu Jan 15 04:22:11 2009
+++ src/sys/dev/wscons/wsmouse.c Sun Sep 11 19:19:19 2011
@@ -1,4 +1,4 @@
-/* $NetBSD: wsmouse.c,v 1.62 2009/01/15 04:22:11 yamt Exp $ */
+/* $NetBSD: wsmouse.c,v 1.63 2011/09/11 19:19:19 jakllsch Exp $ */
/*-
* Copyright (c) 2006 The NetBSD Foundation, Inc.
@@ -104,7 +104,7 @@
*/
#include sys/cdefs.h
-__KERNEL_RCSID(0, $NetBSD: wsmouse.c,v 1.62 2009/01/15 04:22:11 yamt Exp
$);
+__KERNEL_RCSID(0, $NetBSD: wsmouse.c,v 1.63 2011/09/11 19:19:19 jakllsch
Exp $);
#include wsmouse.h
#include wsdisplay.h
@@ -143,6 +143,7 @@
#define INVALID_XINT_MAX
#define INVALID_YINT_MAX
#define INVALID_ZINT_MAX
+#define INVALID_WINT_MAX
struct wsmouse_softc {
struct wsevsrc sc_base;
@@ -621,6 +622,7 @@
sc-sc_x = INVALID_X;
sc-sc_y = INVALID_Y;
sc-sc_z = INVALID_Z;
+ sc-sc_z = INVALID_W;
You mean sc-sc_w here, right ?
Christoph
/* Stop button repeating when messing with the device. */
if (sc-sc_repeat_button != -1) {
Re: CVS commit: src/share/man/man4
On 29.08.11 06:26, Christoph Egger wrote: On 29.08.11 00:09, Jean-Yves Migeon wrote: Module Name: src Committed By:jym Date:Sun Aug 28 22:09:37 UTC 2011 Modified Files: src/share/man/man4: ddb.4 Log Message: Be more precise for Xen: + is only valid for Xen domUs. dom0 uses the same key sequences as i386/amd64. + also works for me in a dom0. I think I have to mention I am using serial console regularly. Christoph
Re: CVS commit: src/sys/conf
On 07/04/11 15:00, matthew green wrote:
Module Name:src
Committed By: mrg
Date: Mon Jul 4 13:00:19 UTC 2011
Modified Files:
src/sys/conf: Makefile.kern.inc
Log Message:
apply some -Wno-foo to 3 files that are non-trivial to solve, for GCC 4.5.
To generate a diff of this commit:
cvs rdiff -u -r1.140 -r1.141 src/sys/conf/Makefile.kern.inc
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/conf/Makefile.kern.inc
diff -u src/sys/conf/Makefile.kern.inc:1.140
src/sys/conf/Makefile.kern.inc:1.141
--- src/sys/conf/Makefile.kern.inc:1.140Mon Jun 20 06:52:38 2011
+++ src/sys/conf/Makefile.kern.inc Mon Jul 4 13:00:19 2011
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile.kern.inc,v 1.140 2011/06/20 06:52:38 mrg Exp $
+# $NetBSD: Makefile.kern.inc,v 1.141 2011/07/04 13:00:19 mrg Exp $
#
# This file contains common `MI' targets and definitions and it is included
# at the bottom of each `MD' ${MACHINE}/conf/Makefile.${MACHINE}.
@@ -510,12 +510,19 @@
uvm/uvm_pager.c dev/ic/aic7xxx.c dev/ic/aic79xx.c arch/xen/i386/gdt.c \
dev/ofw/ofw_subr.c
-. if defined(HAVE_GCC) || defined(HAVE_PCC)
+.if defined(HAVE_GCC) || defined(HAVE_PCC)
Please revert this part.
Christoph
.for __varstack in ${VARSTACK}
COPTS.${__varstack:T} += -Wno-stack-protector
.endfor
.endif
+# XXX ugly ugly to fix
+.if defined(HAVE_GCC) ${HAVE_GCC} == 45
+CWARNFLAGS.tulip.c+= -Wno-array-bounds
+CWARNFLAGS.radeonfb.c+=-Wno-cast-qual
+CWARNFLAGS.dbcool.c+= -Wno-cast-qual
+.endif
+
AFLAGS+= ${AOPTS.${.IMPSRC:T}}
CFLAGS+= ${COPTS.${.IMPSRC:T}} ${CPUFLAGS.${.IMPSRC:T}}
CPPFLAGS+=${CPPFLAGS.${.IMPSRC:T}}
Re: CVS commit: src/sys
On 30.11.10 05:31, Jukka Ruohonen wrote: Module Name: src Committed By: jruoho Date: Tue Nov 30 04:31:00 UTC 2010 Modified Files: src/sys/arch/x86/acpi: acpi_cpu_md.c src/sys/dev/acpi: acpi_cpu.h acpi_cpu_cstate.c Log Message: Add AMD C1E quirk. Tested by cegger@. (a) This should be removed once C-states are supported. (b) As there seems to be no reliable way to detect whether C1E is present, the quirk blindly assumes that C1E is used on families 10h and 11h. On family 10h there is a reliable way to detect C1E via OSVW. Anyway, thanks for doing this. Christoph
Re: CVS commit: src/share/mk
On 10.04.11 23:03, Joerg Sonnenberger wrote:
Module Name: src
Committed By: joerg
Date: Sun Apr 10 21:03:17 UTC 2011
Modified Files:
src/share/mk: bsd.own.mk
Log Message:
Use ?: operator to determine when to add --sysroot. Unbreaks clang
bootstrap.
[...]
-CPPFLAGS+= ${HOSTPROG:U${HOSTLIB:U${DESTDIR:D--sysroot=${DESTDIR
-LDFLAGS+=${HOSTPROG:U${HOSTLIB:U${DESTDIR:D--sysroot=${DESTDIR
+CPPFLAGS+= ${!defined(HOSTPROG) !defined(HOSTLIB) defined(DESTDIR)
:? --sysroot=${DESTDIR} :}
+LDFLAGS+=${!defined(HOSTPROG) !defined(HOSTLIB) defined(DESTDIR)
:? --sysroot=${DESTDIR} :}
.endif # EXTERNAL_TOOLCHAIN
# }
:? == ?: operator?
Christoph
Re: CVS commit: src/usr.sbin/rpcbind
On 03/14/11 13:03, Antti Kantee wrote: Module Name:src Committed By: pooka Date: Mon Mar 14 12:03:45 UTC 2011 Modified Files: src/usr.sbin/rpcbind: rpcbind.c Log Message: remove unnecessary superuser check -- bind will fail if bind fails the second part of this log message is irritating. What do you want to say? Christoph
Re: CVS commit: src/sys/kern
On 12.03.11 08:16, YAMAMOTO Takashi wrote: Module Name: src Committed By: yamt Date: Sat Mar 12 07:16:50 UTC 2011 Hi, nice to read/hear you're alive. Christoph
Re: CVS commit: src/lib/librumphijack
On 03/09/11 16:03, Antti Kantee wrote: Module Name:src Committed By: pooka Date: Wed Mar 9 15:03:18 UTC 2011 Modified Files: src/lib/librumphijack: hijack.c Log Message: Add a bunch of process-wide hijack calls. Among other things, it's now possible to use unmodified userspace binaries (rpcbind, mountd, nfsd) to start a rump nfs service and mount file systems from it. pain-rustique:42:~ mount rumpfs on / type rumpfs (local) 10.1.1.1:/export on /mnt type nfs Cool. Is it possible to have anita booting NetBSD in qemu with root on nfs? Christoph
Re: CVS commit: src/sys/net80211
On 02/25/11 11:45, Matthias Scheler wrote: Module Name:src Committed By: tron Date: Fri Feb 25 10:45:57 UTC 2011 Modified Files: src/sys/net80211: ieee80211_radiotap.h Log Message: Remove duplicate definitions which break the build. Thanks. I was about testing a fix but your release build finished earlier than mine. Christoph
Re: CVS commit: src/sys/arch
On 02/24/11 12:02, Jukka Ruohonen wrote: On Thu, Feb 24, 2011 at 10:56:04AM +, Jukka Ruohonen wrote: Log Message: Move PowerNow! to the cpufeaturebus. I tried to be very careful, but please test for any fall over. acpicpu(4) work on both hp laptops. powernow only tries to attach on my K8 machine where initialization fails as before = no regression. Christoph
Re: CVS commit: src/sys/net80211
On 25.02.11 17:15, David Young wrote: On Fri, Feb 25, 2011 at 08:01:50AM +, Christoph Egger wrote: Module Name: src Committed By:cegger Date:Fri Feb 25 08:01:49 UTC 2011 Modified Files: src/sys/net80211: ieee80211_radiotap.h Log Message: sync with FreeBSD rev 1.11. No binary changes. Careful: NetBSD follows the standard, http://www.radiotap.net/defined-fields, and field 18 has not been standardized. Please back out this change (and all of the subsequent changes) and send a patch for review to tech-net. Do you mean that bit field or the whole revision ? Christoph
Re: CVS commit: src/sys/external/bsd/drm/dist/bsd-core
On 18.02.11 00:21, Jonathan A. Kollasch wrote:
Module Name: src
Committed By: jakllsch
Date: Thu Feb 17 23:21:54 UTC 2011
Modified Files:
src/sys/external/bsd/drm/dist/bsd-core: drm_pciids.h
Log Message:
Add the RS880 device IDs to radeondrm(4).
To generate a diff of this commit:
cvs rdiff -u -r1.5 -r1.6 src/sys/external/bsd/drm/dist/bsd-core/drm_pciids.h
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/external/bsd/drm/dist/bsd-core/drm_pciids.h
diff -u src/sys/external/bsd/drm/dist/bsd-core/drm_pciids.h:1.5
src/sys/external/bsd/drm/dist/bsd-core/drm_pciids.h:1.6
--- src/sys/external/bsd/drm/dist/bsd-core/drm_pciids.h:1.5 Thu Jan 6
11:07:48 2011
+++ src/sys/external/bsd/drm/dist/bsd-core/drm_pciids.h Thu Feb 17
23:21:53 2011
@@ -393,7 +393,12 @@
{0x1002, 0x9552, CHIP_RV710|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP, ATI
Mobility Radeon 4300 Series}, \
{0x1002, 0x9553, CHIP_RV710|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP, ATI
Mobility Radeon 4500 Series}, \
{0x1002, 0x9555, CHIP_RV710|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP, ATI
Mobility Radeon 4500 Series}, \
- {0x1002, 0x9712,
CHIP_RV620|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP|RADEON_IS_IGP, ATI Radeon
Mobility HD 4200}, \
+ {0x1002, 0x9710, CHIP_RS880|RADEON_NEW_MEMMAP|RADEON_IS_IGP, ATI
Radeon HD 4200}, \
+ {0x1002, 0x9711, CHIP_RS880|RADEON_NEW_MEMMAP|RADEON_IS_IGP, ATI
Radeon RS880}, \
+ {0x1002, 0x9712,
CHIP_RS880|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP|RADEON_IS_IGP, ATI Radeon
Mobility HD 4200}, \
+ {0x1002, 0x9713,
CHIP_RS880|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP|RADEON_IS_IGP, ATI Radeon
Mobility RS880}, \
+ {0x1002, 0x9714, CHIP_RS880|RADEON_NEW_MEMMAP|RADEON_IS_IGP, ATI
Radeon HD 4290}, \
+ {0x1002, 0x9715, CHIP_RS880|RADEON_NEW_MEMMAP|RADEON_IS_IGP, ATI
Radeon HD 4250}, \
{0, 0, 0, NULL}
Are you sure some of them aren't actually RS780 chips ?
Christoph
#define r128_PCI_IDS \
Re: CVS commit: src/sys/external/bsd/drm/dist/bsd-core
On 18.02.11 07:00, matthew green wrote:
- {0x1002, 0x9712,
CHIP_RV620|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP|RADEON_IS_IGP, ATI Radeon
Mobility HD 4200}, \
+ {0x1002, 0x9710, CHIP_RS880|RADEON_NEW_MEMMAP|RADEON_IS_IGP, ATI
Radeon HD 4200}, \
+ {0x1002, 0x9711, CHIP_RS880|RADEON_NEW_MEMMAP|RADEON_IS_IGP, ATI
Radeon RS880}, \
+ {0x1002, 0x9712,
CHIP_RS880|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP|RADEON_IS_IGP, ATI Radeon
Mobility HD 4200}, \
+ {0x1002, 0x9713,
CHIP_RS880|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP|RADEON_IS_IGP, ATI Radeon
Mobility RS880}, \
+ {0x1002, 0x9714, CHIP_RS880|RADEON_NEW_MEMMAP|RADEON_IS_IGP, ATI
Radeon HD 4290}, \
+ {0x1002, 0x9715, CHIP_RS880|RADEON_NEW_MEMMAP|RADEON_IS_IGP, ATI
Radeon HD 4250}, \
{0, 0, 0, NULL}
Are you sure some of them aren't actually RS780 chips ?
the new code matches the linux drm driver.
ok. IIRC there is a PR with a patch that adds an entry for HD4250
which can be closed now.
Christoph
Re: CVS commit: src/sys/dev/pci
On 24.12.10 00:56, Michael wrote: Hello, On Dec 23, 2010, at 4:34 PM, Christoph Egger wrote: Module Name:src Committed By:cegger Date:Thu Dec 23 21:34:02 UTC 2010 Modified Files: src/sys/dev/pci: voyagerfb.c Log Message: read 32bits instead of 64bits and truncate the upper 32bits Please stop making unnecessary changes to drivers you can't test on actual hardware. Sorry, should have mentioned this makes the i386 ALL kernel linking. Christoph
Re: CVS commit: src/sys/dev/pci
On 24.12.10 11:07, Izumi Tsutsui wrote: Modified Files: src/sys/dev/pci: voyagerfb.c Log Message: read 32bits instead of 64bits and truncate the upper 32bits Please stop making unnecessary changes to drivers you can't test on actual hardware. Sorry, should have mentioned this makes the i386 ALL kernel linking. Adding a bogus fix to make ALL buildable is quite silly. bus_space_read_8(9) is a documented MI API and MD implementation should provide bus_space_read_8() if the machine really needs the driver in its kernel, or don't enable the device on i386. The 'reg' variable is of type 'uint32_t'. So why using bus_space_read_8() when bus_space_read_4() gives the same result? Christoph
Re: CVS commit: src/sys/dev/pci
On 24.12.10 14:11, Michael wrote: Hello, On Dec 24, 2010, at 4:13 AM, Christoph Egger wrote: On 24.12.10 00:56, Michael wrote: Hello, On Dec 23, 2010, at 4:34 PM, Christoph Egger wrote: Module Name:src Committed By:cegger Date:Thu Dec 23 21:34:02 UTC 2010 Modified Files: src/sys/dev/pci: voyagerfb.c Log Message: read 32bits instead of 64bits and truncate the upper 32bits Please stop making unnecessary changes to drivers you can't test on actual hardware. Sorry, should have mentioned this makes the i386 ALL kernel linking. Are you trying to tell me that i386 doesn't have bus_space_*_8() methods? I'd call that a bug. It is declared but not implemented. I got an 'undefined reference' linking error. Christoph
Re: CVS commit: src/tests/usr.sbin/traceroute
Module Name: src Committed By: pooka Date: Wed Dec 15 00:13:52 UTC 2010 Added Files: src/tests/usr.sbin/traceroute: Makefile t_traceroute.sh Log Message: Add simple tests for traceroute. The test bootstraps a three-node network with one router in the middle and checks traceroute from one endpoint to another with both UDP and ICMP. (i guess these test networking at least as much as traceroute itself, but then again that's not a bad thing) This breaks release build: == 2 missing files in DESTDIR Files in flist but missing from DESTDIR. File wasn't installed ? -- ./usr/tests/usr.sbin/traceroute/Atffile ./usr/tests/usr.sbin/traceroute/t_traceroute end of 2 missing files == *** [checkflist] Error code 1 Christoph
Re: CVS commit: src/tests/usr.sbin/traceroute
On Dec,Wednesday 15 2010, at 11:27 AM, Christoph Egger wrote:
Module Name: src
Committed By: pooka
Date: Wed Dec 15 00:13:52 UTC 2010
Added Files:
src/tests/usr.sbin/traceroute: Makefile t_traceroute.sh
Log Message:
Add simple tests for traceroute. The test bootstraps a three-node
network with one router in the middle and checks traceroute from
one endpoint to another with both UDP and ICMP.
(i guess these test networking at least as much as traceroute
itself, but then again that's not a bad thing)
This breaks release build:
== 2 missing files in DESTDIR
Files in flist but missing from DESTDIR.
File wasn't installed ?
--
./usr/tests/usr.sbin/traceroute/Atffile
./usr/tests/usr.sbin/traceroute/t_traceroute
end of 2 missing files ==
*** [checkflist] Error code 1
Update src/tests and re run your build should be fixed now.
Regards
Adam.
Confirmed. Thanks.
Christoph
Re: CVS commit: src
On 13.12.10 22:15, Antti Kantee wrote: Module Name: src Committed By: pooka Date: Mon Dec 13 21:15:31 UTC 2010 Modified Files: src/distrib/sets/lists/base: mi src/distrib/sets/lists/comp: mi src/usr.bin/netstat: Makefile bpf.c if.c inet.c inet6.c main.c mbuf.c show.c unix.c Added Files: src/usr.bin/netstat: netstat_hostops.c netstat_rumpops.c prog_ops.h Log Message: Add netstat rump client. For now, it always sets -X, i.e. will use only sysctl and no kvm (implementing /dev/mem for a rump kernel would probably not be hard, but still a non-zero effort). Note: since there is absolutely no network activity in a fresh rump kernel, rump.netstat usually displays exactly nothing when invoked without parameters. Arguments like -r, -bi, -p icmp etc. produce more stuff. Does that allow to remove the suid bit from netstat? Christoph
Re: CVS commit: src/sys
On 30.11.10 05:31, Jukka Ruohonen wrote: Module Name: src Committed By: jruoho Date: Tue Nov 30 04:31:00 UTC 2010 Modified Files: src/sys/arch/x86/acpi: acpi_cpu_md.c src/sys/dev/acpi: acpi_cpu.h acpi_cpu_cstate.c Log Message: Add AMD C1E quirk. Tested by ceg...@. (a) This should be removed once C-states are supported. (b) As there seems to be no reliable way to detect whether C1E is present, the quirk blindly assumes that C1E is used on families 10h and 11h. On family 10h there is a reliable way to detect C1E via OSVW. Anyway, thanks for doing this. Christoph
Re: CVS commit: src/usr.bin/make
Original-Nachricht Datum: Fri, 26 Nov 2010 13:56:22 + (UTC) Von: chris...@astron.com An: source-changes-d@NetBSD.org Betreff: Re: CVS commit: src/usr.bin/make In article 20101126105706.ga18...@homeworld.netbsd.org, Martin Husemann mar...@homeworld.netbsd.org wrote: On Thu, Nov 25, 2010 at 04:31:10PM -0500, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Thu Nov 25 21:31:09 UTC 2010 Modified Files: src/usr.bin/make: arch.c compat.c make.c make.h targ.c Log Message: Instead of keeping around the mtime of the youngest child, keep a pointer to it, so that we can print it when we do the out of date determination. This makes -current fail on amd64: --- dependall-gnu --- [1] Segmentation fault (core dumped) /usr/tools/bin/n... *** [dependall-host-libiberty] Error code 139 BTW: It works on a clean build. I must have forgotten to test for cmgn NULL somewhere; where does gdb say that it dies? Core was generated by `nbmake'. Program terminated with signal 11, Segmentation fault. #0 0x0040261b in Arch_LibOODate () (gdb) bt #0 0x0040261b in Arch_LibOODate () #1 0x0040f919 in Make_OODate () #2 0x0040fcde in MakeStartJobs () #3 0x0040ff6c in Make_Run () #4 0x0040e7b3 in main () (gdb)
Re: CVS commit: src/usr.bin/make
On Nov 26, 3:34pm, christoph_eg...@gmx.de (Christoph Egger) wrote: -- Subject: Re: CVS commit: src/usr.bin/make | BTW: It works on a clean build. | | I must have forgotten to test for cmgn NULL somewhere; where | does gdb say that it dies? | | Core was generated by `nbmake'. | Program terminated with signal 11, Segmentation fault. | #0 0x0040261b in Arch_LibOODate () | (gdb) bt | #0 0x0040261b in Arch_LibOODate () | #1 0x0040f919 in Make_OODate () | #2 0x0040fcde in MakeStartJobs () | #3 0x0040ff6c in Make_Run () | #4 0x0040e7b3 in main () | (gdb) Thanks, try now! Works for me. Tnx for fixing. Christoph
Re: CVS commit: src/sys
On 05.11.10 02:35, Mindaugas Rasiukevicius wrote: Module Name: src Committed By: rmind Date: Fri Nov 5 01:35:58 UTC 2010 Modified Files: src/sys/dist/pf/net: if_pfsync.c pf_norm.c src/sys/netinet: in_var.h ip_id.c ip_input.c Log Message: ip_randomid: make mechanism MP-safe and more modular. OK matt@ Where is ip_id_fini() called? If we don't we leak kernel memory. Christoph
Re: CVS commit: src/sys/netinet
Can you try with a LOCKDEBUG + DEBUG/DIAGNOSTIC kernel? The kernel has all three options. Hm, if you have DEBUG enabled, kern_free() might fill free'ed area with WEIRD_ADDR. Yes, this patch makes boot with root on nfs work again. Please commit. Christoph enami. Index: sys/netinet/ip_reass.c === RCS file: /cvsroot/src/sys/netinet/ip_reass.c,v retrieving revision 1.4 diff -u -r1.4 ip_reass.c --- sys/netinet/ip_reass.c3 Oct 2010 19:44:47 - 1.4 +++ sys/netinet/ip_reass.c6 Oct 2010 01:52:14 - @@ -390,7 +390,6 @@ pool_cache_put(ipfren_cache, q); m_cat(m, t); } - free(fp, M_FTABLE); /* * Create header for new packet by modifying header of first @@ -400,6 +399,7 @@ ip-ip_len = htons((ip-ip_hl 2) + next); ip-ip_src = fp-ipq_src; ip-ip_dst = fp-ipq_dst; + free(fp, M_FTABLE); m-m_len += (ip-ip_hl 2); m-m_data -= (ip-ip_hl 2);
Re: CVS commit: src/sys/netinet
Christoph Egger christoph_eg...@gmx.de wrote: Re-structure IPv4 reassembly code to make it more MP-friendly and simplify some code fragments while here. Also, use pool_cache(9) and mutex(9). IPv4 reassembly mechanism is MP-safe now. To generate a diff of this commit: cvs rdiff -u -r1.3 -r1.4 src/sys/netinet/ip_reass.c This breaks boot with root on nfs. The last boot message I see is: root file system type: nfs init: copying out path `/sbin/init' 11 then the kernel hangs forever, even with an UP kernel. Can you try with a LOCKDEBUG + DEBUG/DIAGNOSTIC kernel? The kernel has all three options. Christoph
Re: CVS commit: src/sys/dev/ieee1394
On 26.08.10 16:31, Mindaugas Rasiukevicius wrote: Module Name:src Committed By: cegger Date: Thu Aug 26 12:48:19 UTC 2010 Modified Files: src/sys/dev/ieee1394: fwdev.c Log Message: don't call tsleep() with any mutexes hold To generate a diff of this commit: cvs rdiff -u -r1.23 -r1.24 src/sys/dev/ieee1394/fwdev.c The right fix would be to use condvar(9). Generally, tsleep(9) should be replaced and removed in the longer term. Sure. Two questions hold me back from doing this: 1. Which cv_*wait* variant should be used? 2. Where should I add the corresponding cv_signal/cv_broadcast ? Is it possible to have an conversion example in the tsleep(9) manpage? Christoph
Re: CVS commit: src/sys/arch/x86/acpi
On 19.08.10 20:30, Jukka Ruohonen wrote:
Module Name: src
Committed By: jruoho
Date: Thu Aug 19 18:30:24 UTC 2010
Modified Files:
src/sys/arch/x86/acpi: acpi_cpu_md.c
Log Message:
Add native P-state support for AMD family 10h and 11h processors. Both are
supported irrespective of XPSS. Family 10h tested by jakll...@.
[...]
case CPUVENDOR_AMD:
- if ((sc-sc_flags ACPICPU_FLAG_P_XPSS) == 0)
- return EOPNOTSUPP;
+ switch (CPUID2FAMILY(ci-ci_signature)) {
This is not correct. On AMD the cpu family is computed as:
family = CPUID2FAMILY(ci-ci_signature);
if (family == 0xf)
family += CPUID2EXTFAMILY(ci-ci_signature);
+
+ case 0x10:
+ case 0x11:
+ msr.ps_control_addr = MSR_10H_CONTROL;
+ msr.ps_control_mask = __BITS(0, 2);
+
+ msr.ps_status_addr = MSR_10H_STATUS;
+ msr.ps_status_mask = __BITS(0, 2);
+ break;
+
Re: CVS commit: src/sys/arch
Hi, Why are any types other than in the pmap different between PAE and !PAE? When this was originally proposed I asked for stuff like paddr_t to be 64 bits no matter what the kernel compile settings where. Interesting to hear that from your side. When asked for this a debate about overhead started. Christoph Thanks. On Mon, Aug 16, 2010 at 10:45:10PM +0200, Jean-Yves Migeon wrote: On 16.08.2010 22:22, matthew green wrote: Module Name: src Committed By:jym Date:Mon Aug 16 19:39:06 UTC 2010 Modified Files: src/sys/arch/i386/i386: machdep.c src/sys/arch/x86/include: cpu.h Log Message: Add machdep.pae sysctl(7) for i386. Thanks to Paul and Joerg for their reviews. In kernel, it matches the 'i386_use_pae' variable (0: kernel does not use PAE, 1: kernel uses PAE). Will be used by i386 kvm(3) to know the functions that should get called for VA = PA translations. does this work for core files as well? if not, wouldn't this feature be better done use ugly kvm/nlist so that it works with the same code on dead kernels? getting a 0/1 value via kvm shouldn't really be considered any real problem. That's the purpose; I don't know of any other way. The sysctl is only there for practical purposes: cpuctl(8) can indicate that the CPU supports PAE, but there is no easy way to know if it is active or not (unless playing with config -x together with the booted kernel, not very practical...). Hence, the sysctl machdep. (why the extern in cpu.h? i doesn't seem necessary.) Yes; I wanted to place it at the same level as i386_use_fxsave. i386_use_pae may get use elsewhere eventually, so I added it to cpu.h. -- Jean-Yves Migeon jeanyves.mig...@free.fr
Re: CVS commit: src/sys/ufs/ffs
Module Name: src Committed By: pooka Date: Mon Aug 9 15:50:13 UTC 2010 Modified Files: src/sys/ufs/ffs: ffs_vfsops.c Log Message: Return error if we try to mount a file system with block size MAXBSIZE. Note: there is a billion ways to make the kernel panic by trying to mount a garbage file system and I don't imagine we'll ever get close to fixing even half of them. However, for this one failing gracefully is a bonus since Xen DomU only does 32k MAXBSIZE and the 64k MAXBSIZE file systems are out there (PR port-xen/43727). Tested by compiling sys/rump with CPPFLAGS+=-DMAXPHYS=32768 (all tests in tests/fs still pass). I don't know how we're going to translate this into an easy regression test, though. Maybe with a hacked newfs? No. What you need is dd, /dev/zero, some disk space, vnconfig, newfs, mount, umount and rm in this order to have an easy regression test. :) Christoph
Re: CVS commit: src/sys/dev/acpi
On 09.08.10 07:00, Jukka Ruohonen wrote: Module Name: src Committed By: jruoho Date: Mon Aug 9 05:00:24 UTC 2010 Modified Files: src/sys/dev/acpi: acpi_cpu_cstate.c Log Message: Downgrade the currently supported maximum C-state to C1. There appears to be timer-related interrupt issues also in C2. With C1 it is guaranteed that acpicpu(4) will not cause any slowdowns due stalled local APIC timer. Before you switch into C3-state you need to move away from using the local APIC timer. You can use any external timer such as HPET or PIT. You use local APIC timer after wakeup again. Christoph
Re: CVS commit: src/sys/arch
On 24.07.10 02:45, Jean-Yves Migeon wrote: Module Name: src Committed By: jym Date: Sat Jul 24 00:45:57 UTC 2010 Modified Files: src/sys/arch/i386/conf: GENERIC src/sys/arch/i386/i386: bioscall.S kvm86call.S locore.S machdep.c mptramp.S multiboot.c src/sys/arch/i386/include: pmap.h src/sys/arch/x86/include: cpu.h pmap.h src/sys/arch/x86/x86: cpu.c pmap.c src/sys/arch/xen/x86: cpu.c x86_xpmap.c xenfunc.c Log Message: Welcome PAE inside i386 current. Great work! [...] XXX kvm(3) will be fixed in another patch to properly handle both PAE and !PAE kernel dumps (VA = PA macros are slightly different, and need proper 64 bits PA support in kvm_i386). XXX Mixing PAE and !PAE modules may lead to unwanted/unexpected results. This cannot be solved easily, and needs lots of thinking before being declared safe (paddr_t/bus_addr_t size handling, PD/PT macros abstractions). How about making paddr_t always 64bit? That makes it much easier to deal with in libkvm. paddr_t being always 64bit wide also allows to switch PAE on and off at runtime like Solaris does. Pleaes fix the amd64 build error reported on current-us...@. The build error is related to rump. Christoph
Re: CVS commit: src/sys/dev/acpi
On 19.07.10 02:59, Christos Zoulas wrote:
Module Name: src
Committed By: christos
Date: Mon Jul 19 00:59:32 UTC 2010
Modified Files:
src/sys/dev/acpi: acpi_cpu.c acpi_cpu.h acpi_cpu_cstate.c
Log Message:
XXX: If this is not correct, revert or fix.
This makes my laptop boot instead of panic:
panic: kernel diagnostic assertion native_idle != NULL failed: file
../../../../arch/x86/acpi/acpi_cpu_md.c, line 155
fatal breakpoint trap in supervisor mode
type 1 code 0 rip 8022e4ad cs 8 rflags 246 cr2 0 cpl 0 rsp
80004c37db10
trace
breakpoint() at netbsd:breakpoint+0x5
panic() at netbsd:panic+0x2ba
kern_assert() at netbsd:kern_assert+0x2d
acpicpu_md_idle_stop() at netbsd:acpicpu_md_idle_stop+0x62
acpicpu_cstate_callback() at netbsd:acpicpu_cstate_callback+0x34
sysmon_task_queue_thread() at netbsd:sysmon_task_queue_thread+0x41
1. ACPI seems to define cpuids 1..n; we define 0..n-1. Adjust for that
2. My laptop is dual core, but ACPI reports 4 cpu nodes. Instead of
attaching the unmatched ones, make the match fail. Do we want to
attach and do nothing instead?
3. Create a flag, and only set it after we are completely initialized,
so the sysmon thread does not try to access unitialized state.
This change let's my laptop panic:
panic: kernel diagnostic assertion id != 0 failed: file
sys/dev/acpi/acpi_cpu.c, line 274
db{0} bt
breakpoint+0x5
panic+0x2ba
kern_assert+0x2d
acpicpu_id+0x69
acpicpu_match+0x5a
mapply+0x41
Re: CVS commit: src/sys/dev/acpi
Module Name: src Committed By: christos Date: Mon Jul 19 00:59:32 UTC 2010 Modified Files: src/sys/dev/acpi: acpi_cpu.c acpi_cpu.h acpi_cpu_cstate.c Log Message: XXX: If this is not correct, revert or fix. This makes my laptop boot instead of panic: panic: kernel diagnostic assertion native_idle != NULL failed: file ../../../../arch/x86/acpi/acpi_cpu_md.c, line 155 fatal breakpoint trap in supervisor mode type 1 code 0 rip 8022e4ad cs 8 rflags 246 cr2 0 cpl 0 rsp 80004c37db10 trace breakpoint() at netbsd:breakpoint+0x5 panic() at netbsd:panic+0x2ba kern_assert() at netbsd:kern_assert+0x2d acpicpu_md_idle_stop() at netbsd:acpicpu_md_idle_stop+0x62 acpicpu_cstate_callback() at netbsd:acpicpu_cstate_callback+0x34 sysmon_task_queue_thread() at netbsd:sysmon_task_queue_thread+0x41 1. ACPI seems to define cpuids 1..n; we define 0..n-1. Adjust for that No, ACPI enumerates cpus 0..n-1 by specification. 2. My laptop is dual core, but ACPI reports 4 cpu nodes. Instead of attaching the unmatched ones, make the match fail. Do we want to attach and do nothing instead? Uh, do your two cores attach on id 1 and 2 and ids 0 and 3 are unused? That sounds like your laptop vendor prepared the BIOS to deliver laptop models with a quad-core cpu. 3. Create a flag, and only set it after we are completely initialized, so the sysmon thread does not try to access unitialized state.
Re: CVS commit: src/sys
On 18.07.10 11:29, Jukka Ruohonen wrote: Module Name: src Committed By: jruoho Date: Sun Jul 18 09:29:13 UTC 2010 Modified Files: src/sys/arch/amd64/conf: GENERIC src/sys/arch/i386/conf: GENERIC src/sys/arch/x86/conf: files.x86 src/sys/arch/x86/include: machdep.h src/sys/arch/x86/x86: x86_machdep.c src/sys/dev/acpi: acpi.c files.acpi Added Files: src/sys/arch/x86/acpi: acpi_cpu_md.c src/sys/dev/acpi: acpi_cpu.c acpi_cpu.h acpi_cpu_cstate.c Log Message: Merge a driver for ACPI CPUs with basic support for processor power states, also known as C-states. The code is modular and provides an easy way to add the remaining functionality later (namely throttling and P-states). Remarks: 1. Commented out in the GENERICs; more testing exposure is needed. 2. The C3-state is disabled for the time being because it turns off timers, among them the local APIC timer. This may not be universally true on all x86 processors; define ACPICPU_ENABLE_C3 to test. 3. The algorithm used to choose a power state may need tuning. When evaluating the appropriate state, the implementation uses the previous sleep time as an indicator. Additional hints would include for example the system load. Also bus master activity is evaluated when choosing a state. The usb(4) stack is notorious for such activity even when unused. Typically it must be disabled in order to reach the C3-state, but it may also prevent the use of C2. 4. While no extensive empirical measurements have been carried out, the power savings are somewhere between 1-2 W with C1 and C2, depending on the processor, firmware, and load. With C3 even up to 4 W can be saved. The less something ticks, the more power is saved. ok jmcneill@, joerg@, and discussed with various people. Great work! Please disable C1E on AMD K8, Family10h and Family11h CPUs, because C1E disables the local APIC timer. You can enable C1E and once the local APIC timer is tickless. Hint: There are some nasty BIOSes which enable C1E after acpi cpu has been initialized. On Xen you don't need to do anything as Xen already handles this for you. Christoph
Re: CVS commit: src
On 07.07.10 02:10, Nicolas Joly wrote: Module Name: src Committed By: njoly Date: Wed Jul 7 00:10:14 UTC 2010 Modified Files: src/distrib/sets/lists/comp: md.amd64 md.i386 src/sys/arch/x86/include: Makefile Log Message: Install x86/pte.h Thanks. Christoph
Re: CVS commit: src/sys/dev/usb
On 22.06.10 23:30, Paul Goyette wrote: Module Name: src Committed By: pgoyette Date: Tue Jun 22 21:30:55 UTC 2010 Modified Files: src/sys/dev/usb: if_axe.c Log Message: Make sure we unlock before exit. @@ -350,6 +350,7 @@ allmulti: rxmode |= AXE_RXCMD_ALLMULTI; axe_cmd(sc, AXE_CMD_RXCTL_WRITE, 0, rxmode, NULL); + axe_lock_mii(sc); According to your commit log, you mean axe_unlock_mii() here, don't you? return; } else rxmode = ~AXE_RXCMD_ALLMULTI;
Re: CVS commit: src/sys
On 22.06.10 20:32, Mindaugas Rasiukevicius wrote: Module Name: src Committed By: rmind Date: Tue Jun 22 18:32:08 UTC 2010 Modified Files: src/sys/fs/tmpfs: TODO files.tmpfs tmpfs.h tmpfs_subr.c tmpfs_vfsops.c tmpfs_vnops.c src/sys/modules/tmpfs: Makefile src/sys/rump/fs/lib/libtmpfs: Makefile Added Files: src/sys/fs/tmpfs: tmpfs_mem.c Removed Files: src/sys/fs/tmpfs: tmpfs_pool.c tmpfs_pool.h Log Message: Replace tmpfs_pool custom allocator code with a simpler layer for memory accounting. Use wired memory (which can be limited) for meta-data, and kmem(9) for string allocations. Close PR/31944. Fix PR/38361 while here. OK a...@. Are these the fixes to get shm_open(3) and shm_unlink(3) in libc ? Christoph
Re: CVS commit: src
On 31.05.10 05:18, Mindaugas Rasiukevicius wrote:
Module Name: src
Committed By: rmind
Date: Mon May 31 03:18:33 UTC 2010
Modified Files:
src/bin/ps: extern.h print.c ps.c
src/external/bsd/top/dist/machine: m_netbsd.c
Log Message:
Fix ps(1) and top(1) to show reasonable CPU numbers i.e. cpu_index() provided
by the kernel, instead of CPU order number, which is generally random.
To generate a diff of this commit:
cvs rdiff -u -r1.32 -r1.33 src/bin/ps/extern.h
cvs rdiff -u -r1.112 -r1.113 src/bin/ps/print.c
cvs rdiff -u -r1.74 -r1.75 src/bin/ps/ps.c
cvs rdiff -u -r1.12 -r1.13 src/external/bsd/top/dist/machine/m_netbsd.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/bin/ps/extern.h
diff -u src/bin/ps/extern.h:1.32 src/bin/ps/extern.h:1.33
--- src/bin/ps/extern.h:1.32 Sun Feb 10 17:47:59 2008
+++ src/bin/ps/extern.h Mon May 31 03:18:33 2010
@@ -1,4 +1,4 @@
-/* $NetBSD: extern.h,v 1.32 2008/02/10 17:47:59 christos Exp $ */
+/* $NetBSD: extern.h,v 1.33 2010/05/31 03:18:33 rmind Exp $*/
/*-
* Copyright (c) 1991, 1993, 1994
@@ -83,7 +83,6 @@
void rgname(void *, VARENT *, int);
void rssize(void *, VARENT *, int);
void runame(void *, VARENT *, int);
-void setncpu(void);
void showkey(void);
void started(void *, VARENT *, int);
void state(void *, VARENT *, int);
Index: src/bin/ps/print.c
diff -u src/bin/ps/print.c:1.112 src/bin/ps/print.c:1.113
--- src/bin/ps/print.c:1.112 Wed Oct 21 21:11:57 2009
+++ src/bin/ps/print.cMon May 31 03:18:33 2010
@@ -1,4 +1,4 @@
-/* $NetBSD: print.c,v 1.112 2009/10/21 21:11:57 rmind Exp $*/
+/* $NetBSD: print.c,v 1.113 2010/05/31 03:18:33 rmind Exp $*/
/*
* Copyright (c) 2000, 2007 The NetBSD Foundation, Inc.
@@ -63,7 +63,7 @@
#if 0
static char sccsid[] = @(#)print.c 8.6 (Berkeley) 4/16/94;
#else
-__RCSID($NetBSD: print.c,v 1.112 2009/10/21 21:11:57 rmind Exp $);
+__RCSID($NetBSD: print.c,v 1.113 2010/05/31 03:18:33 rmind Exp $);
#endif
#endif /* not lint */
@@ -101,8 +101,6 @@
static void strprintorsetwidth(VAR *, const char *, int);
static time_t now;
-static int ncpu;
-static u_int64_t *cp_id;
#define min(a,b)((a) = (b) ? (a) : (b))
@@ -999,39 +997,6 @@
}
void
-setncpu(void)
-{
- int mib[2];
- size_t size;
-
- mib[0] = CTL_HW;
- mib[1] = HW_NCPU;
- size = sizeof(ncpu);
- if (sysctl(mib, 2, ncpu, size, NULL, 0) == -1) {
- ncpu = 0;
- return;
- }
- cp_id = malloc(sizeof(cp_id[0]) * ncpu);
- if (cp_id == NULL)
- err(1, NULL);
- mib[0] = CTL_KERN;
- mib[1] = KERN_CP_ID;
- size = sizeof(cp_id[0]) * ncpu;
- if (sysctl(mib, 2, cp_id, size, NULL, 0) == -1)
- ncpu = 0;
-}
-
-static int
-get_cpunum(u_int64_t id)
-{
- int i = 0;
- for (i = 0; i ncpu; i++)
- if (id == cp_id[i])
- return i;
- return -1;
-}
-
-void
cpuid(void *arg, VARENT *ve, int mode)
{
struct kinfo_lwp *l;
@@ -1039,7 +1004,7 @@
l = arg;
v = ve-var;
- intprintorsetwidth(v, get_cpunum(l-l_cpuid), mode);
+ intprintorsetwidth(v, l-l_cpuid, mode);
}
void
Index: src/bin/ps/ps.c
diff -u src/bin/ps/ps.c:1.74 src/bin/ps/ps.c:1.75
--- src/bin/ps/ps.c:1.74 Sun Mar 29 01:02:49 2009
+++ src/bin/ps/ps.c Mon May 31 03:18:33 2010
@@ -1,4 +1,4 @@
-/* $NetBSD: ps.c,v 1.74 2009/03/29 01:02:49 mrg Exp $ */
+/* $NetBSD: ps.c,v 1.75 2010/05/31 03:18:33 rmind Exp $*/
/*
* Copyright (c) 2000-2008 The NetBSD Foundation, Inc.
@@ -68,7 +68,7 @@
#if 0
static char sccsid[] = @(#)ps.c 8.4 (Berkeley) 4/2/94;
#else
-__RCSID($NetBSD: ps.c,v 1.74 2009/03/29 01:02:49 mrg Exp $);
+__RCSID($NetBSD: ps.c,v 1.75 2010/05/31 03:18:33 rmind Exp $);
#endif
#endif /* not lint */
@@ -169,8 +169,6 @@
else
termwidth = ws.ws_col - 1;
- setncpu();
-
if (argc 1)
argv[1] = kludge_oldps_options(argv[1]);
Index: src/external/bsd/top/dist/machine/m_netbsd.c
diff -u src/external/bsd/top/dist/machine/m_netbsd.c:1.12
src/external/bsd/top/dist/machine/m_netbsd.c:1.13
--- src/external/bsd/top/dist/machine/m_netbsd.c:1.12 Wed May 12 22:09:36 2010
+++ src/external/bsd/top/dist/machine/m_netbsd.c Mon May 31 03:18:33 2010
@@ -1,4 +1,4 @@
-/* $NetBSD: m_netbsd.c,v 1.12 2010/05/12 22:09:36 christos Exp $ */
+/* $NetBSD: m_netbsd.c,v 1.13 2010/05/31 03:18:33 rmind Exp $ */
/*
* top - a top users display for Unix
@@ -37,12 +37,12 @@
* Andrew Doran a...@netbsd.org
*
*
- * $Id: m_netbsd.c,v 1.12 2010/05/12 22:09:36 christos Exp $
+ * $Id: m_netbsd.c,v 1.13 2010/05/31 03:18:33 rmind Exp $
*/
Re: CVS commit: src/dist/ipf
On 17.04.10 22:46, Darren Reed wrote: Module Name: src Committed By: darrenr Date: Sat Apr 17 20:46:14 UTC 2010 Update of /cvsroot/src/dist/ipf In directory ivanova.netbsd.org:/tmp/cvs-serv26635 Log Message: Import IPFilter 4.1.34 into NetBSD Why not imported into into external/license/ ? Christoph
Re: CVS commit: src/sys/dev/acpi
On 03.04.10 18:29, Jukka Ruohonen wrote: Module Name: src Committed By: jruoho Date: Sat Apr 3 16:29:22 UTC 2010 Modified Files: src/sys/dev/acpi: acpi_bat.c Log Message: Update the limits when a change from absent to present is detected. Does acpi_bat also detect the other way around ? I.e. when you have multiple batteries you can unplug a full charged battery and then re-plug an empty one for charging. Christoph
Re: CVS commit: src/tools/compat/sys
On 26.03.10 22:34, Christos Zoulas wrote: In article 1933.1269630...@splode.eterna.com.au, matthew green m...@eterna.com.au wrote: copy paste from above url tools/ctfconvert/../../external/cddl/osnet/sys/sys/time.h:71: error: 'CLOCK_REALTIME' undeclared (first use in this function) /copy paste shouldn't this be fixed with something in nbtool_config.h? Just back the whole thing out; I fixed it in the dtrace sys/time.h where it belongs. Done. See http://mail-index.netbsd.org/source-changes/2010/03/27/msg008205.html Christoph
Re: re: CVS commit: src/tools/compat/sys
Module Name: src Committed By: cegger Date: Fri Mar 26 07:16:12 UTC 2010 Added Files: src/tools/compat/sys: time.h Log Message: toolchain buildfix on OSX with MKDTRACE=yes: The host sys/time.h doesn't provide CLOCK_REALTIME but ctf uses it. See http://mail-index.netbsd.org/current-users/2010/03/20/msg012963.html this seems bogus to me. please only define it if it isn't defined, at least. I tried the other way around before I posted the my fix to the list: #include_next sys/time.h #ifndef CLOCK_REALTIME #define CLOCK_REALTIME 0 #endif But this failed the same way: CLOCK_REALTIME undeclared. Note, ctf uses CLOCK_REALTIME in the same header where it includes sys/time.h. No comments. try posting to the right mailing list. tech-toolchain would be the right list for this sort of change. Thanks for the hint. Christoph
Re: CVS commit: src/tools/compat/sys
Original-Nachricht Datum: Sat, 27 Mar 2010 03:03:06 +1100 Von: matthew green m...@eterna.com.au An: Christoph Egger christoph_eg...@gmx.de CC: source-changes-d@NetBSD.org Betreff: re: CVS commit: src/tools/compat/sys toolchain buildfix on OSX with MKDTRACE=yes: The host sys/time.h doesn't provide CLOCK_REALTIME but ctf uses it. See http://mail-index.netbsd.org/current-users/2010/03/20/msg012963.html this seems bogus to me. please only define it if it isn't defined, at least. I tried the other way around before I posted the my fix to the list: #include_next sys/time.h #ifndef CLOCK_REALTIME #define CLOCK_REALTIME 0 #endif But this failed the same way: CLOCK_REALTIME undeclared. hmmm, could you post the error? thanks. copy paste from above url tools/ctfconvert/../../external/cddl/osnet/sys/sys/time.h:71: error: 'CLOCK_REALTIME' undeclared (first use in this function) /copy paste Note, ctf uses CLOCK_REALTIME in the same header where it includes sys/time.h. BTW, i'm not sure that using #include_next is OK (it's gcc specific) and i don't see it used elsewhere in a quick look. If you want to see that go away then ctf needs to be fixed first (which implies to wait for darran@ to be back from vacation in first place :)) See line 34 in ctf's sys/time.h (above file where error occured). Christoph
CVS commit: src/usr.sbin/cpuctl/arch
Module Name:src Committed By: cegger Date: Tue Feb 23 08:46:33 UTC 2010 Modified Files: src/usr.sbin/cpuctl/arch: i386.c Log Message: check for svm feature flags if cpuid function 0x800a is available. To generate a diff of this commit: cvs rdiff -u -r1.21 -r1.22 src/usr.sbin/cpuctl/arch/i386.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
Re: CVS commit: src/sys/conf
On 23.02.10 23:21, Darran Hunt wrote: Module Name: src Committed By: darran Date: Tue Feb 23 22:21:25 UTC 2010 Modified Files: src/sys/conf: files Log Message ? To generate a diff of this commit: cvs rdiff -u -r1.976 -r1.977 src/sys/conf/files Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
Re: CVS commit: src/sys/conf
Thanks. Christoph On 23.02.10 23:26, Darran Hunt wrote: Missed the log message, fixed with cvs admin -m. Log message now reads: DTrace: remove kern_dtrace.c, no longer used Darran. On 24/02/2010, at 11:24 AM, Christoph Egger wrote: On 23.02.10 23:21, Darran Hunt wrote: Module Name:src Committed By:darran Date:Tue Feb 23 22:21:25 UTC 2010 Modified Files: src/sys/conf: files Log Message ? To generate a diff of this commit: cvs rdiff -u -r1.976 -r1.977 src/sys/conf/files Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/arch/amd64/amd64
Module Name:src Committed By: cegger Date: Tue Feb 23 00:23:36 UTC 2010 Modified Files: src/sys/arch/amd64/amd64: vector.S Log Message: include opt_xen.h To generate a diff of this commit: cvs rdiff -u -r1.31 -r1.32 src/sys/arch/amd64/amd64/vector.S Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/sys/arch/amd64/amd64/vector.S diff -u src/sys/arch/amd64/amd64/vector.S:1.31 src/sys/arch/amd64/amd64/vector.S:1.32 --- src/sys/arch/amd64/amd64/vector.S:1.31 Thu Jul 9 21:43:16 2009 +++ src/sys/arch/amd64/amd64/vector.S Tue Feb 23 00:23:36 2010 @@ -1,4 +1,4 @@ -/* $NetBSD: vector.S,v 1.31 2009/07/09 21:43:16 rmind Exp $ */ +/* $NetBSD: vector.S,v 1.32 2010/02/23 00:23:36 cegger Exp $ */ /*- * Copyright (c) 1998, 2007, 2008 The NetBSD Foundation, Inc. @@ -68,6 +68,7 @@ #include opt_ddb.h #include opt_multiprocessor.h +#include opt_xen.h #define ALIGN_TEXT .align 16,0x90
CVS commit: src/sys/arch/amd64/amd64
Module Name:src Committed By: cegger Date: Tue Feb 23 00:23:36 UTC 2010 Modified Files: src/sys/arch/amd64/amd64: vector.S Log Message: include opt_xen.h To generate a diff of this commit: cvs rdiff -u -r1.31 -r1.32 src/sys/arch/amd64/amd64/vector.S Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/dev/scsipi
Module Name:src Committed By: cegger Date: Sat Feb 6 23:13:59 UTC 2010 Modified Files: src/sys/dev/scsipi: scsi_spc.h Log Message: scsi_sense_data: add comments taken from src/sys/dev/ieee1394/sbp.h To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.5 src/sys/dev/scsipi/scsi_spc.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/kern
Module Name:src Committed By: cegger Date: Fri Feb 5 11:06:37 UTC 2010 Modified Files: src/sys/kern: init_main.c Log Message: fix LOCKDEBUG panic 'uninitialized lock'. seminit() calls exithook_establish(). exithook_establish() uses the exec_lock. exec_lock is initialzed by exec_init(1). Call exec_init(1) before seminit(). To generate a diff of this commit: cvs rdiff -u -r1.417 -r1.418 src/sys/kern/init_main.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
Re: CVS commit: src/sys/dev/pci
On 28.01.10 04:09, SAITOH Masanobu wrote:
Module Name: src
Committed By: msaitoh
Date: Thu Jan 28 03:09:13 UTC 2010
Modified Files:
src/sys/dev/pci: if_bge.c if_bgereg.h if_bgevar.h
Log Message:
- Introduce IPMI and ASF related code from FreeBSD. It fixes some problems
which occured in netboot on sparc64 and PR#32767
- move the code of disabling host interrput in bge_stop() like linux tg3
driver.
- fix the return value of bge_eeprom_getbyte().
- remove an unused structure.
- KNF
To generate a diff of this commit:
cvs rdiff -u -r1.176 -r1.177 src/sys/dev/pci/if_bge.c
cvs rdiff -u -r1.54 -r1.55 src/sys/dev/pci/if_bgereg.h
cvs rdiff -u -r1.2 -r1.3 src/sys/dev/pci/if_bgevar.h
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
+static void
+bge_sig_pre_reset(sc, type)
+ struct bge_softc *sc;
+ int type;
+{
[...]
+static void
+bge_sig_post_reset(sc, type)
+ struct bge_softc *sc;
+ int type;
+{
[...]
+
+static void
+bge_sig_legacy(sc, type)
+ struct bge_softc *sc;
+ int type;
+{
[...]
+
+static void
+bge_stop_fw(sc)
+ struct bge_softc *sc;
+{
Please use ANSI C function definitions.
Christoph
Re: CVS commit: src/share/man/man4
Module Name: src Committed By: jruoho Date: Mon Jan 25 09:33:29 UTC 2010 Modified Files: src/share/man/man4: acpidalb.4 Log message ? Christoph To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3 src/share/man/man4/acpidalb.4 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/arch/x86/include
Module Name:src Committed By: cegger Date: Wed Jan 13 12:54:49 UTC 2010 Modified Files: src/sys/arch/x86/include: specialreg.h Log Message: recognize SVM PauseFilter To generate a diff of this commit: cvs rdiff -u -r1.37 -r1.38 src/sys/arch/x86/include/specialreg.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/arch/x86/include
Module Name:src Committed By: cegger Date: Sat Jan 9 20:50:11 UTC 2010 Modified Files: src/sys/arch/x86/include: i82489reg.h Log Message: add LAPIC_MSR_ENABLE_x2 MSR. from mur...@river-styx via port-amd64@ '...as documented in the Intel 64 and IA32 Architectures Software Developers Manual 3A, chapter 10.5.1.' To generate a diff of this commit: cvs rdiff -u -r1.8 -r1.9 src/sys/arch/x86/include/i82489reg.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/arch/x86
Module Name:src Committed By: cegger Date: Sat Jan 9 20:56:17 UTC 2010 Modified Files: src/sys/arch/x86/include: cpu.h mpconfig.h src/sys/arch/x86/x86: mpacpi.c Log Message: add x2apic support. patch presented on current-users@, port-i386@ and port-amd64@ on 2009-12-22 No comments. To generate a diff of this commit: cvs rdiff -u -r1.18 -r1.19 src/sys/arch/x86/include/cpu.h cvs rdiff -u -r1.11 -r1.12 src/sys/arch/x86/include/mpconfig.h cvs rdiff -u -r1.83 -r1.84 src/sys/arch/x86/x86/mpacpi.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/arch/x86/x86
Module Name:src Committed By: cegger Date: Sat Jan 9 22:54:00 UTC 2010 Modified Files: src/sys/arch/x86/x86: x86_machdep.c Log Message: TOPLIMIT for i386 PAE is 64GB. To generate a diff of this commit: cvs rdiff -u -r1.37 -r1.38 src/sys/arch/x86/x86/x86_machdep.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
Re: CVS commit: src/sys/dist/pf/net
On 30.12.09 08:00, Elad Efrat wrote: Module Name: src Committed By: elad Date: Wed Dec 30 07:00:01 UTC 2009 Modified Files: src/sys/dist/pf/net: pf.c Log Message: Get uid/gid from the socket's credentials. To generate a diff of this commit: cvs rdiff -u -r1.57 -r1.58 src/sys/dist/pf/net/pf.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. @@ -2824,12 +2824,13 @@ break; #endif /* INET6 */ } - pd-lookup.uid = so-so_uidinfo-ui_uid; + pd-lookup.uid = kauth_cred_geteuid(so-so_cred); + pd-lookup.gid = kauth_cred_getegid(so-so_cred); #else so = inp-inp_socket; pd-lookup.uid = so-so_euid; + pd-lookup.uid = so-so_egid; typo. should be pd-lookup.gid. #endif /* !__NetBSD__ */ - pd-lookup.gid = so-so_egid; pd-lookup.pid = so-so_cpid; return (1); }
Re: CVS commit: src/usr.sbin/acpitools/acpidump
On 22.12.09 09:44, Christoph Egger wrote: Module Name: src Committed By: cegger Date: Tue Dec 22 08:44:03 UTC 2009 Modified Files: src/usr.sbin/acpitools/acpidump: Makefile acpi.c acpi_user.c acpidump.8 acpidump.c acpidump.h Removed Files: src/usr.sbin/acpitools/acpidump: aml_dump.c asl_dump.c Log Message: msg.txt Damn. I mixed up -m with -F. Log Message should have been: Import acpidump from FreeBSD per request from jmcneill@ Changes made in the port: - adapt path to iasl from /usr/sbin/iasl to /usr/bin/iasl - fix realpath() usage to accomplish NetBSD's behaviour - use EXIT_FAILURE/EXIT_SUCCESS everywhere - fix crash on corrupt DSDT file and print proper error message - implemented additional ACPI table parsers for BERT, BOOT, CPEP, DBGP, EINJ, ERST, HEST, MSCT, SBST, SLIT, SPCR, TCPA, WAET, WDAT and WDRT
Re: CVS commit: src/usr.sbin/acpitools/acpidump
On 22.12.09 09:46, Christoph Egger wrote: On 22.12.09 09:44, Christoph Egger wrote: Module Name: src Committed By:cegger Date:Tue Dec 22 08:44:03 UTC 2009 Modified Files: src/usr.sbin/acpitools/acpidump: Makefile acpi.c acpi_user.c acpidump.8 acpidump.c acpidump.h Removed Files: src/usr.sbin/acpitools/acpidump: aml_dump.c asl_dump.c Log Message: msg.txt Damn. I mixed up -m with -F. Log Message should have been: Import acpidump from FreeBSD per request from jmcneill@ Changes made in the port: - adapt path to iasl from /usr/sbin/iasl to /usr/bin/iasl - fix realpath() usage to accomplish NetBSD's behaviour - use EXIT_FAILURE/EXIT_SUCCESS everywhere - fix crash on corrupt DSDT file and print proper error message - implemented additional ACPI table parsers for BERT, BOOT, CPEP, DBGP, EINJ, ERST, HEST, MSCT, SBST, SLIT, SPCR, TCPA, WAET, WDAT and WDRT commit message fixed in repository. Christoph
Re: CVS commit: src/sys/dev/acpi
Paul Goyette wrote: On Fri, 4 Dec 2009, Quentin Garnier wrote: IMO, very few devices should attach at acpi, but autoconfiguration should use ACPI data, when it is available, for the direct configuration of devices that we would otherwise have to probe for. Was there ever a disagreement on that? Well, one place where this might not work is for ACPI-accessible i2c busses! The acpi code might well be manipulating the bus without obeying any i2c_acquire_bus() locking mechanism implemented in the native pci-based drivers, with unpredictable results. (Consider the case where an acpitz might be using an i2c-connected sensor...) For this case, the ACPI driver gives the BIOS a chance to handle mutex access SMBus in OS runtime. The purpose of ACPI CMI is to coordinate access to the SMBus controller between OSPM and SMI. Bad things will happen if the EC tries to read the fan speed at the same time that you do, for example. Further, the ACPI PCI driver has to be linked with the native PCI driver to coordinate this i2c bus locking between the drivers. This is a point where I am not sure if the ACPI PCI devices should be attached before or after the native PCI drivers attached. I fail to see how the API that was just committed will not result in a #if NACPI 0 block every time it is used. Yeah, and that would be, ahem, ugly. Side-note: This has been changed to #if NACPICA 0 If the whole file depends on 'acpi' in files.acpi it already belongs to the acpi context and #if NACPICA 0 blocks make no sense to me. Files outside of sys/dev/acpi using ACPI code should generally have #if NACPICA 0 blocks. Further, jmcneill@ stated earlier he does not want to see any acpi code in sys/dev/pci/ Christoph - who wonder's why this discussion started after commit instead of after presenting the patch on tech-kern.
Re: CVS commit: src/sys/arch
Manuel Bouyer wrote: On Mon, Nov 23, 2009 at 08:44:10AM +1100, matthew green wrote: Module Name: src Committed By: bouyer Date: Sun Nov 22 21:41:03 UTC 2009 Modified Files: src/sys/arch/amd64/include: vmparam.h src/sys/arch/x86/x86: x86_machdep.c Log Message: For amd64, introduce a third free list distinct from the default free list for memory between 16M and 4G. On large memory machine, this avoids the 32bit-accessible memory being eaten by various kernel early allocation, causing 32bit bus_dma(9) memory allocation to fail at boot time. Tested on a system with 48GB RAM; based on netbsd-5 patch proposed on port-amd64 3 days ago. i wonder if we should do this on i386 PAE as well? We'll probably have to do it for i386 PAE when it's natively supported (just define a VM_FREELIST_FIRST4G in i386/vmparam.h for this case). it's not needed for Xen because the management of free lists like this is managed by the hypervisor. Is this also true when you assign more than 4GB RAM to the Dom0 ? Christoph
Re: CVS commit: src/sys/arch/i386/stand
David Laight wrote: Module Name: src Committed By: dsl Date: Thu Nov 19 22:10:03 UTC 2009 Modified Files: src/sys/arch/i386/stand/lib: message.S src/sys/arch/i386/stand/mbr: mbr.S Log Message: Move code for outputting directly to the serial port into message.S Allows it to be enabled for other parts of the boot sequence. Will you fix boot(8) to make xen boot again ? Christoph
Re: CVS commit: src/sys/compat/linux32/common
Joerg Sonnenberger wrote: Module Name: src Committed By: joerg Date: Mon Nov 16 08:49:32 UTC 2009 Modified Files: src/sys/compat/linux32/common: linux32_ipc.h linux32_ipccall.c Log Message: Add SYSVMSG support for linux32. To generate a diff of this commit: cvs rdiff -u -r1.1 -r1.2 src/sys/compat/linux32/common/linux32_ipc.h cvs rdiff -u -r1.4 -r1.5 src/sys/compat/linux32/common/linux32_ipccall.c Did you forgot to commit some files? This breaks the build for me when compiling amd64: In file included from /Users/cegger/devel/bsd/netbsd/src-x86/sys/compat/linux32/common/linux32_ipccall.c:50:/Users/cegger/devel/bsd/netbsd/src-x86/sys/compat/linux32/common/linux32_ipc.h:69: error: expected specifier-qualifier-list before 'netbsd32_u_short'/Users/cegger/devel/bsd/netbsd/src-x86/sys/compat/linux32/common/linux32_ipc.h:77: error: field 'l_msg_perm' has incomplete type/Users/cegger/devel/bsd/netbsd/src-x86/sys/compat/linux32/common/linux32_ipc.h:87: error: expected specifier-qualifier-list before 'netbsd32_int'/Users/cegger/devel/bsd/netbsd/src-x86/sys/compat/linux32/common/linux32_ipccall.c: In function 'linux32_to_bsd_msqid_ds':/Users/cegger/devel/bsd/netbsd/src-x86/sys/compat/linux32/common/linux32_ipccall.c:434: error: 'struct linux32_msqid_ds' has no member named 'l_msg_cbytes'/Users/cegger/devel/bsd/netbsd/src-x86/sys/compat/linux32/common/linux32_ipccall.c:435: error: 'struct linux32_msqid_ds' has no member named 'l_msg_qnum'/Users/cegger/devel/bsd/netbsd/src-x86/sys/compat/linux32/common/linux32_ipccall.c:436: error: 'struct linux32_msqid_ds' has no member named 'l_msg_qbytes'/Users/cegger/devel/bsd/netbsd/src-x86/sys/compat/linux32/common/linux32_ipccall.c:437: error: 'struct linux32_msqid_ds' has no member named 'l_msg_lspid'/Users/cegger/devel/bsd/netbsd/src-x86/sys/compat/linux32/common/linux32_ipccall.c:438: error: 'struct linux32_msqid_ds' has no member named 'l_msg_lrpid'cc1: warnings being treated as errors/Users/cegger/devel/bsd/netbsd/src-x86/sys/compat/linux32/common/linux32_ipccall.c: At top level:/Users/cegger/devel/bsd/netbsd/src-x86/sys/compat/linux32/common/linux32_ipccall.c:445: warning: 'struct linux32_msqid64_ds' declared inside parameter list/Users/cegger/devel/bsd/netbsd/src-x86/sys/compat/linux32/common/linux32_ipccall.c:445: warning: its scope is only this definition or declaration, which is probably not what you want/Users/cegger/devel/bsd/netbsd/src-x86/sys/compat/linux32/common/linux32_ipccall.c:446: warning: no previous prototype for 'linux32_to_bsd_msqid64_ds'/Users/cegger/devel/bsd/netbsd/src-x86/sys/compat/linux32/common/linux32_ipccall.c: In function 'linux32_to_bsd_msqid64_ds':/Users/cegger/devel/bsd/netbsd/src-x86/sys/compat/linux32/common/linux32_ipccall.c:449: warning: implicit declaration of function 'linux_to_bsd_ipc64_perm'/Users/cegger/devel/bsd/netbsd/src-x86/sys/compat/linux32/common/linux32_ipccall.c:449: error: dereferencing pointer to incomplete type/Users/cegger/devel/bsd/netbsd/src-x86/sys/compat/linux32/common/linux32_ipccall.c:450: error: dereferencing pointer to incomplete type/Users/cegger/devel/bsd/netbsd/src-x86/sys/compat/linux32/common/linux32_ipccall.c:451: error: dereferencing pointer to incomplete type/Users/cegger/devel/bsd/netbsd/src-x86/sys/compat/linux32/common/linux32_ipccall.c:452: error: dereferencing pointer to incomplete type /Users/cegger/devel/bsd/netbsd/src-x86/sys/compat/linux32/common/linux32_ipccall.c:453: error: dereferencing pointer to incomplete type/Users/cegger/devel/bsd/netbsd/src-x86/sys/compat/linux32/common/linux32_ipccall.c:454: error: dereferencing pointer to incomplete type/Users/cegger/devel/bsd/netbsd/src-x86/sys/compat/linux32/common/linux32_ipccall.c:455: error: dereferencing pointer to incomplete type/Users/cegger/devel/bsd/netbsd/src-x86/sys/compat/linux32/common/linux32_ipccall.c:456: error: dereferencing pointer to incomplete type/Users/cegger/devel/bsd/netbsd/src-x86/sys/compat/linux32/common/linux32_ipccall.c:457: error: dereferencing pointer to incomplete type/Users/cegger/devel/bsd/netbsd/src-x86/sys/compat/linux32/common/linux32_ipccall.c: In function 'bsd_to_linux32_msqid_ds':/Users/cegger/devel/bsd/netbsd/src-x86/sys/compat/linux32/common/linux32_ipccall.c:468: error: 'struct linux32_msqid_ds' has no member named 'l_msg_cbytes'/Users/cegger/devel/bsd/netbsd/src-x86/sys/compat/linux32/common/linux32_ipccall.c:469: error: 'struct linux32_msqid_ds' has no member named 'l_msg_qnum'/Users/cegger/devel/bsd/netbsd/src-x86/sys/compat/linux32/common/linux32_ipccall.c:470: error: 'struct linux32_msqid_ds' has no member named 'l_msg_qbytes'/Users/cegger/devel/bsd/netbsd/src-x86/sys/compat/linux32/common/linux32_ipccall.c:471: error: 'struct linux32_msqid_ds' has no member named 'l_msg_lspid'/Users/cegger/devel/bsd/netbsd/src-x86/sys/compat/linux32/common/linux32_ipccall.c:472: error: 'struct linux32_msqid_ds' has no member named
Re: CVS commit: src/sys/arch
Nick Hudson wrote: On Wednesday 11 November 2009 17:03:17 Christoph Egger wrote: Nick Hudson wrote: Module Name:src Committed By: skrll Date: Wed Nov 11 16:08:32 UTC 2009 Modified Files: src/sys/arch/hp700/hp700: mainbus.c src/sys/arch/hppa/hppa: pmap.c src/sys/arch/hppa/include: pmap.h Log Message: Use the new flags argument to pmap_kenter_pa for PMAP_NOCACHE. +/* + * MD flags that we use for pmap_kenter_pa: + */ PMAP_NOCACHE is also documented for pmap_enter(9). but hp700 / hppa doesn't use it for pmap_enter hence the comment. +#define PMAP_NOCACHE0x01 /* set the non-cacheable bit */ + Please keep the MD value within PMAP_MD_MASK (defined in sys/uvm/uvm_pmap.h) so that new MI flags won't conflict. hmm, sys/uvm/uvm_pmap.h needs an update or your change is 10% complete, or both. /* * Flags passed to pmap_enter(). Note the bottom 3 bits are VM_PROT_* * bits, used to indicate the access type that was made (to seed modified * and referenced information). * * Flags marked [PA] are for pmap_kenter_pa() only. Flags marked [BOTH] * apply to pmap_kenter_pa() and pmap_enter(). All other flags are valid * for pmap_enter() only. */ #define PMAP_WIRED 0x0010 /* wired mapping */ #define PMAP_CANFAIL0x0020 /* can fail if resource shortage */ #if defined(PMAP_ENABLE_PMAP_KMPAGE) #define PMAP_KMPAGE 0x0040 /* [PA] page used for kernel memory */ #else #define PMAP_KMPAGE 0x #endif /* PMAP_ENABLE_PMAP_KMPAGE */ #define PMAP_MD_MASK0xff00 /* Machine-dependent bits */ Shouldn't all PMAP_* flags be passed in the flags argument? Your changes didn't do any of that, afaict. Yes, they should do. But all ports need to update their pmap_enter/pmap_kenter_pa implementations along with adaptions in MI code in one go. If you update MD code and then MI code (or vice versa) the tree is in a broken state where nobody knows for how long. The comment can be updated w/o any problems. BTW: rmind already pointed out, PMAP_KMPAGE shouldn't be merged with VM_PROT_* any longer. What am I missing? You might be interested in this thread: http://mail-index.netbsd.org/tech-kern/2009/04/16/msg004836.html Christoph Nick
Re: CVS commit: src/sys/arch
Nick Hudson wrote: Module Name: src Committed By: skrll Date: Wed Nov 11 16:08:32 UTC 2009 Modified Files: src/sys/arch/hp700/hp700: mainbus.c src/sys/arch/hppa/hppa: pmap.c src/sys/arch/hppa/include: pmap.h Log Message: Use the new flags argument to pmap_kenter_pa for PMAP_NOCACHE. +/* + * MD flags that we use for pmap_kenter_pa: + */ PMAP_NOCACHE is also documented for pmap_enter(9). +#define PMAP_NOCACHE0x01 /* set the non-cacheable bit */ + Please keep the MD value within PMAP_MD_MASK (defined in sys/uvm/uvm_pmap.h) so that new MI flags won't conflict. Christoph
Re: CVS commit: src/sys/arch/ia64/stand/ia64/ski
Module Name: src Committed By: kiyohara Date: Tue Nov 10 11:14:48 UTC 2009 Modified Files: src/sys/arch/ia64/stand/ia64/ski: acpi_stub.c Log Message: Fix build failure. acpi.h moves to external/intel-public/acpica/dist/include/. Shouldn't this include dev/acpi/acpica.h instead ? Christoph
Re: CVS commit: src/sys/dev/ppbus
David Young wrote: Module Name: src Committed By: dyoung Date: Sat Nov 7 00:05:49 UTC 2009 Modified Files: src/sys/dev/ppbus: ppbus_conf.c Log Message: Don't deactivate a child before detaching it, that's not necessary. Don't take a device off of the ppbus(4)'s list of children in the detach routine, but add a child-detachment hook that does it for us. As a nice side-effect, we can probably detach ppbus(4) children with drvctl(8), now. Compile-tested, only. XXX Does anybody even use ppbus(4)? It's not even in the ALL XXX configuration for i386! At last, hans@ wrote a gpio backend for ppbus. Shouldn't ppbus replace lpt ? Christoph
Re: CVS commit: src/sys/rump/librump/rumpkern
David Laight wrote: Module Name: src Committed By: dsl Date: Sat Nov 7 12:08:35 UTC 2009 Modified Files: src/sys/rump/librump/rumpkern: pmap_stub.c Log Message: Fix stub prototype Doh! rump is not build as part of any kernel. Hence gcc didn't catch it. Thanks for fixing. Christoph
Re: CVS commit: src/sys
Mindaugas Rasiukevicius wrote: Hello, Module Name:src Committed By: cegger Date: Sat Nov 7 07:27:50 UTC 2009 ... Log Message: Add a flags argument to pmap_kenter_pa(9). Patch showed on tech-kern@ http://mail-index.netbsd.org/tech-kern/2009/11/04/msg006434.html No objections. Since we have flags argument now, I think PMAP_KMPAGE and friends should no longer be glued together with prot. Agree. Also ports which have their own PMAP_NOCACHE and glue it together with prot should implement the flags argument and switch to PMAP_NOCACHE. Christoph
Re: CVS commit: src/sys
David Young wrote: On Tue, Nov 03, 2009 at 08:02:52AM +0100, Christoph Egger wrote: David Young wrote: Module Name:src Committed By: dyoung Date: Tue Nov 3 05:23:28 UTC 2009 Modified Files: src/sys/arch/i386/conf: files.i386 src/sys/arch/i386/i386: spl.S src/sys/arch/x86/x86: patch.c src/sys/arch/xen/conf: files.xen src/sys/kern: init_main.c kern_stub.c subr_prf.c src/sys/sys: systm.h Added Files: src/sys/kern: subr_spldebug.c src/sys/sys: spldebug.h Log Message: Add a kernel configuration flag, SPLDEBUG, that activates a per-CPU log of transitions to IPL_HIGH from lower IPLs. SPLDEBUG is only available on i386 and Xen kernels, today. Does this include i386 Xen kernels or amd64 Xen kernels or both? Just i386. amd64 amd64+Xen should be covered by SPLDEBUG, but I don't have an amd64 box handy for testing. That implies nobody else has an amd64 machine ? Christoph
Re: CVS commit: src/sys
David Young wrote: Module Name: src Committed By: dyoung Date: Tue Nov 3 05:23:28 UTC 2009 Modified Files: src/sys/arch/i386/conf: files.i386 src/sys/arch/i386/i386: spl.S src/sys/arch/x86/x86: patch.c src/sys/arch/xen/conf: files.xen src/sys/kern: init_main.c kern_stub.c subr_prf.c src/sys/sys: systm.h Added Files: src/sys/kern: subr_spldebug.c src/sys/sys: spldebug.h Log Message: Add a kernel configuration flag, SPLDEBUG, that activates a per-CPU log of transitions to IPL_HIGH from lower IPLs. SPLDEBUG is only available on i386 and Xen kernels, today. Does this include i386 Xen kernels or amd64 Xen kernels or both? Christoph
Re: CVS commit: src/lib/libc/net
Thomas Klausner wrote: Module Name: src Committed By: wiz Date: Fri Oct 2 07:41:08 UTC 2009 Modified Files: src/lib/libc/net: getaddrinfo.3 getaddrinfo.c gethnamaddr.c Log Message: Revert a - an changes: Adding an 'n' follows pronunciation, not writing. Thanks. I was about doing that but you beat me. Christoph
Re: CVS commit: src/doc (fix grammar: a - an)
Geoff Wing wrote: On Friday 2009-10-02 07:17 +, Christoph Egger output: :Module Name: src :Committed By:cegger :Date:Fri Oct 2 07:17:16 UTC 2009 : :Modified Files: : src/doc: BUILDING.mdoc CHANGES CHANGES.prev : src/doc/roadmaps: storage : :Log Message: :fix grammar: a - an : :To generate a diff of this commit: :cvs rdiff -u -r1.77 -r1.78 src/doc/BUILDING.mdoc :cvs rdiff -u -r1.1297 -r1.1298 src/doc/CHANGES :cvs rdiff -u -r1.95 -r1.96 src/doc/CHANGES.prev :cvs rdiff -u -r1.5 -r1.6 src/doc/roadmaps/storage You're kidding, right? The only correct change is in doc/CHANGES. I reverted the wrong ones. Christoph
Re: CVS commit: src/etc/rc.d
matthew green wrote: On Thu, 10 Sep 2009, Erik Fair wrote: On Sep 8, 2009, at 01:56, Christoph Egger wrote: Modified Files: src/etc/rc.d: network Log Message: Do not flush routes if root file system is nfs mounted. Fixes boot problem when the nfs server is in a different subnet. This change should be pulled up to netbsd-5. No, this change should be backed out, and the real problem (incorrect default for flushroutes) addressed in a different way. i agree. this is the 2nd time in recent history that controversial changes to rc.d have been commited without discussion. recent history has shown that patches got discussed after commit not before. Christoph
Re: CVS commit: src/sys/ufs/ext2fs
Izumi Tsutsui wrote: Reduce diffs a bit between ext2fs_reload() and ffs_reload(). It sounds like ext2fs and ffs can share some code. Many people say ext2fs is a bad mimic of ufs and actually both ffs and ext2fs are under sys/ufs/, though detailed structures (reinvented by Linux guys?) are somewhat different to share vfsops/vnops sources. This sounds some helpers and higher level functions can be shared and that Low level functions and accessors to the structures can't be shared. Christoph
Re: CVS commit: src/etc/rc.d
Joerg Sonnenberger wrote: On Tue, Sep 08, 2009 at 02:30:56PM +0200, Christoph Egger wrote: Perhaps a better test would be that dhcpcd shouldn't touch the default route unless the default route is through the interface that dhcpcd is managing. I agree. How should dhcpcd deal with /etc/resolv.conf ? If dhcpcd removes and rewrites the entries, DNS queries in-between may fail (i.e. mounting nfs) I would say you have a completely broken setup in that case. You can easily prevent dhcpcd from changing the default route at all if you need to. I tried dhcpcd -n -p if but I ended up with having the nfs server unreachable. Christoph
Re: CVS commit: src/sys/dev
Module Name: src Committed By: dyoung Date: Tue Jul 7 19:51:22 UTC 2009 Modified Files: src/sys/dev: vnd.c Log Message: At the bottom of vndclear(), clear VNF_CLEARING: it is no longer needed to exclude vndopen(), and it will prevent subsequent opens if we leave it. To generate a diff of this commit: cvs rdiff -u -r1.202 -r1.203 src/sys/dev/vnd.c Does this fix PR 41511 ? Christoph
Re: CVS commit: src/sys/dev/pci
Christos Zoulas wrote: Module Name: src Committed By: christos Date: Tue Jul 7 17:08:20 UTC 2009 Modified Files: src/sys/dev/pci: pci_usrreq.c Log Message: simplify previous. Thanks for fixing it. (The crossbuild test with my proposed fix actually worked though. It just finished.) Christoph
Re: CVS commit: src/sys/arch
David Young wrote: Module Name: src Committed By: dyoung Date: Fri Jun 26 23:40:27 UTC 2009 Modified Files: src/sys/arch/i386/i386: machdep.c src/sys/arch/sparc64/sparc64: machdep.c Log Message: During a normal shutdown, gracefully tear down arbitrary stacks of filesystems and (pseudo-)devices, according to the algorithm at A3 and A4, below. Proposed and discussed at http://mail-index.netbsd.org/tech-kern/2009/04/20/msg004864.html. No objections. During an emergency shutdown (e.g., shutdown -n, or after a panic), shutdown is simple as always: filesystems are not sync'd or unmounted, and devices are not detached. It was necessary to change the order of operations during shutdown, but the new order is more sensible: if a core dump is desired, then cpu_reboot(9) dumps it first. cpu_reboot(9) does not call legacy shutdown hooks any longer: they can interfere with device detachment and PMF shutdown, and very few legacy hooks remain. Here is the old order of operations: B1 sync filesystems and TOD clock B2 unmount filesystems B3 dump core B4 detach devices B5 run legacy shutdown hooks B6 run PMF shutdown hooks B7 suspend interrupts B8 MD reboot/shutdown/powerdown And here is the new order: A1 dump core A2 sync filesystems and TOD clock A3 unmount one or more filesystems OR detach one or more devices OR forcefully unmount one filesystem OR skip to 5 A4 repeat at 3 A5 run PMF shutdown hooks A6 suspend interrupts A7 MD reboot/shutdown/powerdown Tested on Dell Dimension 3000, Dell PowerEdge 1950, Sun Fire V120, Soekris net4521 and net4801. VS: -- Will the new order allow Suspend-to-disk (ACPI S4) ? Christoph
Re: CVS commit: src/sys
Frank Kardel wrote: Module Name: src Committed By: kardel Date: Sun Jun 14 13:16:32 UTC 2009 Modified Files: src/sys/kern: kern_tc.c src/sys/sys: timepps.h Log Message: Make PPS work with fast time counters ( 2GHz) by making the pps count time stamp and the update time stamp u_int64. The time delta between two PPS events can now be correctly calculated avoiding any unaccounted for wraps with 32-bit counters. Please use uint64_t instead of u_int64_t. Christoph
