Re: CVS commit: src/common/lib/libc/string

2020-08-08 Thread David Holland
(yes, change is from January, I'm hugely behind) On Mon, Jan 27, 2020 at 10:22:03PM +, Andrew Doran wrote: > Modified Files: > src/common/lib/libc/string: bcmp.c memcmp.c > > Log Message: > Drop the alignment check if __NO_STRICT_ALIGNMENT (x86, m68k, vax). Even on machines that

Re: CVS commit: src/lib/libc/string

2020-04-04 Thread David Holland
On Thu, Mar 26, 2020 at 10:54:21AM +0700, Robert Elz wrote: > | I don't agree -- because applications shouldn't attempt to modify the > | result, it should be const. > > The only reason apps shouldn't modify the string is in case of > porting the app to an (well, some) ancient

Re: CVS commit: src/lib/libc/string

2020-03-25 Thread David Holland
On Wed, Mar 25, 2020 at 06:50:47PM +, Robert Elz wrote: > Modified Files: > src/lib/libc/string: strerror.3 > > Log Message: > Delete the BUGS paragraph about the "missing" const qualifier for the > result type of strerror() (and strerror_l()). While that once should > really

Re: CVS commit: src/share/mk

2019-12-20 Thread David Holland
On Thu, Dec 19, 2019 at 11:04:25PM -0500, Christos Zoulas wrote: > Module Name: src > Committed By:christos > Date:Fri Dec 20 04:04:25 UTC 2019 > > Modified Files: > src/share/mk: bsd.sys.mk sys.mk > > Log Message: > move MV to sys.mk because it is used

Re: Leak Sanitizer - how to suppress leaks

2019-09-23 Thread David Holland
On Mon, Sep 16, 2019 at 07:47:24AM +0700, Robert Elz wrote: > | There have been OSes in the past where memory not freed yet at process > | exit is _not_ freed by the system, and there might be again, > > Please everyone, let's retain some perspective. Systems like those > (Roy

Re: Leak Sanitizer - how to suppress leaks

2019-09-15 Thread David Holland
On Fri, Sep 13, 2019 at 07:03:40PM +0700, Robert Elz wrote: > It isn't so much that I think we need to save the cost of doing > the free() (though for ps it turns out to be harder than you'd expect > to actually get it right) but whether it is worth anyone time and > effort to actually work

Re: CVS commit: src/sys/ufs/ufs

2019-02-24 Thread David Holland
On Mon, Feb 25, 2019 at 06:07:23AM +, David Holland wrote: > that one doesn't set dropend correctly for small buffers, outsmarted > myself while writing it. Better change (still against 1.242) that makes the logic much simpler. Will test this overnight... Index: ufs_v

Re: CVS commit: src/sys/ufs/ufs

2019-02-24 Thread David Holland
On Mon, Feb 25, 2019 at 05:50:08AM +, David Holland wrote: > Furthermore, this: > > > + rawbuf -= dropend; > > is entirely wrong (it needs to be "rawbufmax") and without that bound > on rawbufmax the code is unsafe... I repaired this bit just n

Re: CVS commit: src/sys/ufs/ufs

2019-02-24 Thread David Holland
On Sun, Feb 24, 2019 at 07:51:24PM -0500, Christos Zoulas wrote: > Module Name: src > Committed By:christos > Date:Mon Feb 25 00:51:24 UTC 2019 > > Modified Files: > src/sys/ufs/ufs: ufs_vnops.c > > Log Message: > drop unused dropping this logic is wrong...

Re: CVS commit: src/sys/netinet

2019-02-24 Thread David Holland
On Sun, Feb 24, 2019 at 05:01:52PM +, Kamil Rytarowski wrote: > Modified Files: > src/sys/netinet: sctp_asconf.h > > Log Message: > Appease GCC7 in sctp_asconf.h > > Do not declare types inside function parameter list. > Add decklarations of types before these function

Re: CVS commit: src/bin/sleep

2019-01-28 Thread David Holland
On Mon, Jan 28, 2019 at 07:45:12PM +0700, Robert Elz wrote: > | at least the Arabic ones (momayyez). Supporting 2-3+ styles is opening > | Pandora's box; > > No-one is planning that. There are two options - the C locale, or > the locale set in the environment. Actually it's kind of

Re: CVS commit: src/sys/arch

2019-01-27 Thread David Holland
On Sun, Jan 27, 2019 at 07:10:24PM +0100, Maxime Villard wrote: > > Restore satlink's majors entries commented out and marked obsolete. > > Otherwise they might accidentally get reused later and cause a > > security problem. > > This is completely useless, please revert. You are re-adding

Re: CVS commit: src/bin/sleep

2019-01-27 Thread David Holland
On Sat, Jan 26, 2019 at 12:28:08PM +0100, Kamil Rytarowski wrote: > This is where I disagree. In my opinion (of a native user of ",") - > parsing locale specific input for such programs doesn't make sense. > > Locale specific format is in my opinion appropriate only for programs > that

Re: CVS commit: src/etc

2019-01-13 Thread David Holland
On Mon, Jan 14, 2019 at 09:42:54AM +1100, matthew green wrote: > it would be OK if this was _read-only_ access to network > configuration, but one should never be allowed to change the > it unless root. In the long run, it's quite helpful for laptops to be able to adjust the network

Re: CVS commit: src/usr.sbin/sysinst

2018-11-04 Thread David Holland
On Sat, Nov 03, 2018 at 06:30:00PM +, Martin Husemann wrote: > Remove "usage" translations - they never could be displayed as we only select > the language later. What happens in the scenario when someone's using sysinst after installation and has a locale set? -- David A. Holland

Re: CVS commit: src/usr.bin/make

2018-04-05 Thread David Holland
On Wed, Apr 04, 2018 at 08:31:11PM -0400, Christos Zoulas wrote: > Module Name: src > Committed By:christos > Date:Thu Apr 5 00:31:11 UTC 2018 > > Modified Files: > src/usr.bin/make: parse.c > > Log Message: > Be more selective about detecting a SYSV

Re: CVS commit: src/share/man/man9

2017-12-08 Thread David Holland
On Fri, Dec 08, 2017 at 03:52:01PM +, Taylor R Campbell wrote: > Modified Files: > src/share/man/man9: mutex.9 > > Log Message: > Specify memory ordering implied by mutex_(spin_)enter/exit. > > I'm hesitant to just say `implies membar_enter/exit' -- that may be a > little

Re: CVS commit: src/sys/arch

2017-12-07 Thread David Holland
On Mon, Dec 04, 2017 at 07:41:56PM +0100, Maxime Villard wrote: > > Are you saying Christos is lying about it working after reverting your > > commits? > > Why don't you read the previous emails from this thread, instead of > coming up with random, inaccurate statements like this one? I said

Re: CVS commit: src/etc/rc.d

2017-12-06 Thread David Holland
On Wed, Dec 06, 2017 at 08:25:08AM +0700, Robert Elz wrote: > It isn't the precedence of the operators that is at issue, but > deciding what is an operator - oh right, I'm pretty sure I knew about that at one point and blocked it out for the sake of my sanity :-) -- David A. Holland

Re: CVS commit: src/etc/rc.d

2017-12-05 Thread David Holland
On Mon, Dec 04, 2017 at 02:50:33PM +, Robert Elz wrote: > Modified Files: > src/etc/rc.d: sshd > > Log Message: > Do away with (not well specified, even if it happens to work) absurd > 15 arg test ([ ]) expression, and replace it with several well defined > 2 arg tests, combined

Re: CVS commit: src/sys/arch/amd64/conf

2017-12-03 Thread David Holland
On Sat, Dec 02, 2017 at 09:59:02AM +, Maxime Villard wrote: > Module Name: src > Committed By:maxv > Date:Sat Dec 2 09:59:02 UTC 2017 > > Modified Files: > src/sys/arch/amd64/conf: ALL > > Log Message: > Remove options that do not exist on amd64.

Re: CVS commit: src/sys/dev/acpi/wmi

2017-12-03 Thread David Holland
On Sun, Dec 03, 2017 at 11:53:37PM +0100, Manuel Bouyer wrote: > On Sun, Dec 03, 2017 at 11:06:47AM -0800, bch wrote: > > ... > > /usr/src/sys/dev/acpi/wmi/wmi_dell.c: In function 'wmi_dell_action': > > /usr/src/sys/dev/acpi/wmi/wmi_dell.c:234:16: error: comparison between > > signed and

Re: CVS commit: src/sys/arch

2017-12-03 Thread David Holland
On Sun, Dec 03, 2017 at 10:05:08AM +0100, Maxime Villard wrote: > Le 02/12/2017 ? 22:23, David Holland a ?crit : > > On Sat, Dec 02, 2017 at 10:04:26PM +0100, Maxime Villard wrote: > > > > Revert this. Compat on amd64 must be available all the way back to > &

Re: CVS commit: src

2017-12-02 Thread David Holland
On Wed, Oct 04, 2017 at 07:54:33PM -0400, Christos Zoulas wrote: > Log Message: > Add NOBINARIES, useful to build tools are libraries which is what's needed > for mknative. Wouldn't it make more sense for this to be a build target than a setting (as in, say, "build.sh libs")? -- David A.

Re: CVS commit: src/sys/arch

2017-12-02 Thread David Holland
On Sat, Dec 02, 2017 at 10:04:26PM +0100, Maxime Villard wrote: > > Revert this. Compat on amd64 must be available all the way back to > > 0.9, same as i386. > > > > Also, please stop unilaterally breaking the world. > > You are kidding, right? Everything below COMPAT_15 has *never* been

Re: CVS commit: src/sys/arch

2017-12-02 Thread David Holland
On Sat, Dec 02, 2017 at 01:03:15PM +, Maxime Villard wrote: > Modified Files: > src/sys/arch/amd64/conf: GENERIC files.amd64 > src/sys/arch/xen/conf: files.xen > Removed Files: > src/sys/arch/amd64/amd64: compat_13_machdep.c > > Log Message: > Drop COMPAT_13 on amd64,

Re: CVS commit: src/sys/arch/x86/x86

2017-10-03 Thread David Holland
On Tue, Oct 03, 2017 at 06:54:52PM +0200, Maxime Villard wrote: > I'm not responding to this nonsensical thread anymore, The problem is, you keep acting unilaterally without having gathered a consensus, then ignoring the resulting objections and demanding to have everything your way and only

Re: CVS commit: src/share/misc

2017-03-25 Thread David Holland
On Fri, Mar 24, 2017 at 12:49:43PM +, Brian Ginsbach wrote: > Modified Files: > src/share/misc: acronyms.comp > > Log Message: > Add the more prevalent media access control (MAC) in addition to > medium access control It doesn't really need both... -- David A. Holland

Re: CVS commit: src/sys/fs/tmpfs

2017-01-11 Thread David Holland
On Wed, Jan 11, 2017 at 12:12:33PM +, Joerg Sonnenberger wrote: > Modified Files: > src/sys/fs/tmpfs: tmpfs_vnops.c > > Log Message: > Remove RO check in tmpfs_putpages for now, the syncer doesn't like the > error code. Either removing it is wrong or it should be changed to

Re: CVS commit: src/sys

2017-01-03 Thread David Holland
On Wed, Jan 04, 2017 at 09:17:23AM +0800, Paul Goyette wrote: > > > /* info for a single history event */ > > > struct sysctl_history_event { > > > -struct timespec she_tspec; > > > +time_t she_time_sec; > > > +uint32_tshe_time_usec; > > > +

Re: CVS commit: src/doc

2017-01-02 Thread David Holland
On Mon, Jan 02, 2017 at 05:18:49AM +0100, Kamil Rytarowski wrote: > > Historically exect() is used by debuggers to start debuggees. While > > it's equivalent to using PT_TRACE_ME followed by execve(), I think the > > result is that the new process first stops immediately after the exec > >

Re: CVS commit: src/doc

2017-01-01 Thread David Holland
On Sat, Dec 31, 2016 at 08:57:16PM +, Kamil Rytarowski wrote: > Update TODO.ptrace > > Mark exect(3) for removal, there is no use-case for it. exec() is already > monitored and emits SIGTRAP when traced. Historically exect() is used by debuggers to start debuggees. While it's equivalent

Re: CVS commit: src/lib/libm/complex

2016-12-31 Thread David Holland
On Sat, Dec 31, 2016 at 08:33:04PM +, co...@sdf.org wrote: > On Sat, Dec 31, 2016 at 03:33:03PM +, Maya Rashish wrote: > > - w = r + y * I; > > + r = sqrt(x); > > + w = r; > >} > >

Re: CVS commit: src/sys/kern

2016-12-28 Thread David Holland
On Wed, Dec 28, 2016 at 07:32:05PM +, Taylor R Campbell wrote: > It's true that moving the kauth call expanded the attack surface a > little bit. Now we have to worry about: When I saw the original commit I wondered it if it was an information leak. Maybe it's not, but that's certainly a

Re: CVS commit: src/lib/libc/net

2016-12-06 Thread David Holland
On Tue, Dec 06, 2016 at 01:41:03PM -0500, Christos Zoulas wrote: > Module Name: src > Committed By:christos > Date:Tue Dec 6 18:41:03 UTC 2016 > > Modified Files: > src/lib/libc/net: linkaddr.c > > Log Message: > Fix buffer copy without checking the size of

Re: CVS commit: src/sys/arch/amd64/conf

2016-11-26 Thread David Holland
On Sat, Nov 26, 2016 at 09:21:17PM +1100, matthew green wrote: > > Modified Files: > >src/sys/arch/amd64/conf: GENERIC > > > > Log Message: > > 1.6 was the first amd64 release. (although it didn't really work too well > > before -5) > > dunno what you're talking about. i ran it for

Re: CVS commit: src/sys/arch

2016-11-25 Thread David Holland
On Fri, Nov 25, 2016 at 01:04:20PM +0100, Maxime Villard wrote: > ? It probably means there is some kind of stupid assumption or hack in > emacs. If you could send me the core, the binary and tell me which arch it > is, that would be nice. No, if there is a problem it is somewhere in

Re: CVS commit: src/sys/arch

2016-11-25 Thread David Holland
On Thu, Nov 24, 2016 at 10:28:56PM +0900, Masanobu SAITOH wrote: > > Put a one-page redzone between userland and the PTE space on amd64 and > > i386. > > > > The PTE space is a critical region that maps the page tree, and bugs have > > been found in both amd64 and i386 where the kernel would

Re: CVS commit: src/sys/dev/usb

2016-10-30 Thread David Holland
On Mon, Oct 31, 2016 at 04:15:23AM +, NONAKA Kimihiro wrote: > Modified Files: > src/sys/dev/usb: usbdevs > > Log Message: > Remove duplicated HUAWEI E353 entry. Woops, sorry about that. -- David A. Holland dholl...@netbsd.org

Re: CVS commit: src/sbin/mount

2016-10-14 Thread David Holland
On Sun, Oct 09, 2016 at 12:57:50PM -0600, Greg Oster wrote: > > Modified Files: > >src/sbin/mount: mount.c > > > > Log Message: > > change warning message > > > > previously attempting to use mount -t ext2 like myself would result in > > the warning "mount: mount_ext2 not found for

Re: CVS commit: src/sys/dev

2016-10-14 Thread David Holland
On Thu, Oct 13, 2016 at 08:56:31AM +, Ryo Shimizu wrote: > Modified Files: > src/sys/dev: mm.c > > Log Message: > /dev/mem cannot lseek over 0x8000 on 32bit architectures. This isn't enough (at least pedantically) because uio_offset is signed. (in fact, since uio_offset is

Re: CVS commit: src/sys/kern

2016-10-11 Thread David Holland
On Mon, Oct 10, 2016 at 10:23:46AM +0300, Valery Ushakov wrote: > > Log Message: > > PR 49636 Henning Petersen: use "0L" to return 0 from a function returning > > long, and test its returned value against "0L" instead of "0". > > > > This is not especially necessary, but it's also harmless.

Re: CVS commit: src/sys/fs/nfs

2016-09-23 Thread David Holland
On Thu, Sep 22, 2016 at 11:57:06AM -0400, Christos Zoulas wrote: > Modified Files: > src/sys/fs/nfs: files.newnfs > > Log Message: > add missing attribute I didn't think that even configured yet... -- David A. Holland dholl...@netbsd.org

Re: CVS commit: src/sys/dev/ic

2016-09-18 Thread David Holland
On Sun, Sep 18, 2016 at 09:52:37PM +, Jaromir Dolecek wrote: > Modified Files: > src/sys/dev/ic: ld_nvme.c > > Log Message: > must use PR_NOWAIT also during ldattach()/dkwedge discover, our i/o is there > called with a spin lock held, which triggers LOCKDEBUG panic That sounds

Re: CVS commit: src/distrib/sets/lists/modules

2016-09-17 Thread David Holland
On Sun, Sep 18, 2016 at 06:28:12AM +0800, Paul Goyette wrote: > > > Modified Files: > > > src/distrib/sets/lists/modules: md.amd64 md.i386 mi > > > > > > Log Message: > > > Fix sets lists for nvme module. Since it is being built only for the > > > i386 and amd64 platforms, the entries

Re: CVS commit: src/distrib/sets/lists/modules

2016-09-17 Thread David Holland
On Sat, Sep 17, 2016 at 02:27:19AM +, Paul Goyette wrote: > Modified Files: > src/distrib/sets/lists/modules: md.amd64 md.i386 mi > > Log Message: > Fix sets lists for nvme module. Since it is being built only for the > i386 and amd64 platforms, the entries belong in the md.xxx

Re: CVS commit: src/sys/ufs/ext2fs

2016-08-24 Thread David Holland
On Tue, Aug 23, 2016 at 02:24:30AM -0400, Christos Zoulas wrote: > Modified Files: > src/sys/ufs/ext2fs: ext2fs_vfsops.c > > Log Message: > CID 1371644: use strlcpy, remove dup copy. You sure about the dup copy? Those are different string buffers. -- David A. Holland

Re: CVS commit: src/usr.bin/xlint/lint1

2016-07-20 Thread David Holland
On Wed, Jul 20, 2016 at 02:14:12PM -0400, Christos Zoulas wrote: > Modified Files: > src/usr.bin/xlint/lint1: cgram.y > > Log Message: > accept attributes in param decls Parsing gcc attributes "correctly" (as in, where gcc accepts them) is a trainwreck. Do we really want to bother

Re: CVS commit: src/lib/libc_fp

2016-07-15 Thread David Holland
On Thu, Jul 14, 2016 at 01:59:19AM +, Matt Thomas wrote: > Added Files: > src/lib/libc_fp: Makefile gcc-softfloat.c > src/lib/libc_fp/arch/mips: Makefile.inc fpdf.S fpsf.S shlib_version > > Log Message: > Library which implements the softfloat primitives using FP instructions

Re: CVS commit: src/sys/arch/x86/x86

2016-07-11 Thread David Holland
On Mon, Jul 11, 2016 at 09:42:20AM +, Kengo NAKAHARA wrote: > Log Message: > strncpy should use destination buf length instead of source buf length. > > pointed out by nonaka@n.o. this should almost certainly be strlcpy, not strncpy. -- David A. Holland dholl...@netbsd.org

Re: CVS commit: src/sys/sys

2016-07-06 Thread David Holland
(from a while back) On Sun, Jan 24, 2016 at 02:11:56PM +0100, Joerg Sonnenberger wrote: > On Fri, Jan 22, 2016 at 11:31:30PM +, David A. Holland wrote: > > Module Name: src > > Committed By: dholland > > Date: Fri Jan 22 23:31:30 UTC 2016 > > > > Modified Files:

Re: CVS commit: src/sys/kern

2016-06-27 Thread David Holland
On Mon, Jun 20, 2016 at 03:14:35PM -0400, Christos Zoulas wrote: > Modified Files: > src/sys/kern: kern_exec.c > > Log Message: > put back commented out name resolution code that was gc'ed after previous > refactoring. Wait a moment, I thought we'd put in code to do getcwd for that

Re: CVS commit: src/sys/dev/pci

2016-06-19 Thread David Holland
On Sun, Jun 19, 2016 at 06:58:17AM +, David A. Holland wrote: > Modified Files: > src/sys/dev/pci: arcmsr.c > > Log Message: > Broaden the #if NBIO > 0 block. Should fix broken emips build. Erm: "evbppc" -- David A. Holland dholl...@netbsd.org

Re: CVS commit: src/sys

2016-06-05 Thread David Holland
On Sun, Jun 05, 2016 at 01:33:04PM +, Maxime Villard wrote: > Modified Files: > src/sys/arch/i386/stand/lib: bootmenu.c menuutils.c > src/sys/lib/libsa: gets.c stand.h > > Log Message: > Use gets_s instead of gets. The x86 bootloader prompt is easy to > overflow. That's not

Re: CVS commit: src/sys/sys

2016-03-21 Thread David Holland
On Mon, Mar 21, 2016 at 01:36:22AM +0100, Joerg Sonnenberger wrote: > Here is a trivial test case showing that the basic problem exists for > both clang and gcc: > >int a, b > >int f(void) { > return != >} Do you perhaps mean "extern int a, b;"? That's an important

Re: CVS commit: src/tests/lib/libutil

2015-12-31 Thread David Holland
On Thu, Dec 31, 2015 at 04:14:52PM -0500, Greg Troxel wrote: > > When evaluated on a Sunday, "next Sunday" means 7 days in the future, > > not 14. When evaluated on a Monday, it apparently means 13 days in the > > future. There's not exactly a spec for parsedate.y, so conform to the > >

Re: CVS commit: [netbsd-5] src/sys/ufs/lfs

2015-11-09 Thread David Holland
On Mon, Nov 09, 2015 at 09:59:18AM +, Stephen Borrill wrote: > Modified Files: > src/sys/ufs/lfs [netbsd-5]: lfs_segment.c > > Log Message: > Fix breakage from ticket #1974 > > > To generate a diff of this commit: > cvs rdiff -u -r1.213.8.1 -r1.213.8.2

Re: CVS commit: src/sys/conf

2015-09-03 Thread David Holland
On Thu, Sep 03, 2015 at 02:56:35PM +0900, Masao Uebayashi wrote: > Because ${OBJS} affects not only build order but also link order. And this matters why, in the absence of e.g. profile-driven function layout? (although it might be interesting to see if running ${OBJS} through lorder/tsort

Re: CVS commit: src/sys/conf

2015-09-02 Thread David Holland
On Thu, Sep 03, 2015 at 01:30:18AM +, Masao Uebayashi wrote: > Module Name: src > Committed By:uebayasi > Date:Thu Sep 3 01:30:18 UTC 2015 > > Modified Files: > src/sys/conf: Makefile.kern.inc > > Log Message: > Stop ordering objects alphabetically now

Re: CVS commit: src/sys

2015-08-29 Thread David Holland
On Sat, Aug 29, 2015 at 03:51:53PM +, Masao Uebayashi wrote: According to nxr.netbsd.org, nothing uses MEMORY_DISK_IMAGE. Retire it. Premature design and its build rule bloats Makefile.kern.inc. There are other ways like MEMORY_DISK_DYNAMIC. (When kernel will be built as

Re: CVS commit: src/sbin/fsck_lfs

2015-08-23 Thread David Holland
On Sun, Aug 23, 2015 at 12:00:23PM -0400, Christos Zoulas wrote: Module Name: src Committed By:christos Date:Sun Aug 23 16:00:23 UTC 2015 Modified Files: src/sbin/fsck_lfs: pass0.c Log Message: swap the formats too, not just the args. sorry, I

Re: CVS commit: src/external/mit/xorg

2015-08-10 Thread David Holland
On Sun, Aug 09, 2015 at 01:06:30AM +0200, Aymeric Vincent wrote: David Holland dholland-sourcechan...@netbsd.org writes: Fix bracket expressions by moving '-' to the end of them. GNU awk choked. Front is safer. fwiw. OK, I moved them to the front, together with '_' because

Re: CVS commit: src/external/mit/xorg

2015-08-08 Thread David Holland
On Sat, Aug 08, 2015 at 10:27:00PM +, Aymeric Vincent wrote: Modified Files: src/external/mit/xorg: xorg-pkg-ver.mk Log Message: Fix bracket expressions by moving '-' to the end of them. GNU awk choked. Front is safer. fwiw. -- David A. Holland dholl...@netbsd.org

Re: CVS commit: src/games/atc

2015-07-27 Thread David Holland
On Sun, Jul 26, 2015 at 10:22:24PM +, Thomas Klausner wrote: Modified Files: src/games/atc: atc.6 Log Message: Use An in AUTHORS section. Shouldn't the uucp address be .Aq'd too? -- David A. Holland dholl...@netbsd.org

Re: CVS commit: src/sys/ufs/lfs

2015-07-25 Thread David Holland
On Sat, Jul 25, 2015 at 10:40:35AM +, Martin Husemann wrote: Modified Files: src/sys/ufs/lfs: lfs_bio.c lfs_debug.c lfs_pages.c lfs_segment.c lfs_vnops.c Log Message: Use accessors in DEBUG and DIAGNOSTIC code as well Woops, sorry... -- David A. Holland

Re: CVS commit: src/lib/libc/arch

2015-07-15 Thread David Holland
On Wed, Jul 15, 2015 at 02:23:40PM +, Antti Kantee wrote: Modified Files: src/lib/libc/arch/i386/gen: Makefile.inc src/lib/libc/arch/x86_64/gen: Makefile.inc Log Message: Remove objects built from C sources comments. Everyone can see they're built from C sources

Re: CVS commit: src/usr.sbin/rtadvd

2015-07-03 Thread David Holland
On Fri, Jun 05, 2015 at 03:41:59PM +, Roy Marples wrote: Module Name: src Committed By:roy Date:Fri Jun 5 15:41:59 UTC 2015 Modified Files: src/usr.sbin/rtadvd: advcap.c if.c rrenum.c rtadvd.c Log Message: Use %m in syslog(3) instead of %s

Re: CVS commit: src/usr.sbin/rtadvd

2015-07-03 Thread David Holland
On Fri, Jul 03, 2015 at 08:12:42PM +0100, Roy Marples wrote: Modified Files: src/usr.sbin/rtadvd: advcap.c if.c rrenum.c rtadvd.c Log Message: Use %m in syslog(3) instead of %s strerror(3). Was this really necessary? Last I remember we considered %m a legacy mistake and

Re: CVS commit: src/sys/miscfs/specfs

2015-06-29 Thread David Holland
On Mon, Jun 29, 2015 at 12:25:49PM -0400, Christos Zoulas wrote: Module Name: src Committed By:christos Date:Mon Jun 29 16:25:49 UTC 2015 Modified Files: src/sys/miscfs/specfs: spec_vnops.c Log Message: Revert previous, and explain why. Hrm,

Re: CVS commit: src/sys/compat/netbsd32

2015-06-23 Thread David Holland
On Tue, Jun 23, 2015 at 06:23:36PM +1000, matthew green wrote: Log Message: Don't reference netbsd32_nfssvc unless NFSSERVER is defined. Fixes PR 49994. thanks. *bow* -- David A. Holland dholl...@netbsd.org

Re: CVS commit: src/usr.bin/utoppya

2015-06-21 Thread David Holland
On Sat, Jun 20, 2015 at 04:42:32PM +, Hubert Feyrer wrote: Seriously: give the reader of the manpage an idea on what this program is for without forcing them to Google or read another manpage. Thank you! (there are quite a few man pages that would benefit from this treatment...) --

Re: CVS commit: src/usr.sbin/rpcbind

2015-05-09 Thread David Holland
On Sat, May 09, 2015 at 05:22:18PM -0400, Christos Zoulas wrote: Modified Files: src/usr.sbin/rpcbind: rpcbind.c Log Message: use EXIT_SUCCESS/EXIT_FAILURE consistently. To generate a diff of this commit: cvs rdiff -u -r1.21 -r1.22 src/usr.sbin/rpcbind/rpcbind.c heh, I

Re: CVS commit: src/share/misc

2015-04-27 Thread David Holland
On Sun, Apr 26, 2015 at 09:24:26PM +0200, Marc Balmer wrote: If you persist in this attitude, you're likely to generate a consensus within this part of the Internet culture to document your sudden lack of a commit bit. David, I think this a uneeded threat. rodent's commit might not

Re: CVS commit: src/share/misc

2015-04-26 Thread David Holland
On Sun, Apr 26, 2015 at 06:09:37PM +0900, Masao Uebayashi wrote: Are you removing any inappropriate/hostile words in the tree (if exists)? If there's stuff of the same sort as the acronyms that got pruned, perhaps so. Don't know of any, but that doesn't mean it's not there. (routine bad

Re: CVS commit: src/share/misc

2015-04-25 Thread David Holland
On Fri, Apr 24, 2015 at 12:20:17AM +, Blue Rats wrote: Module Name: src Committed By:rodent Date:Fri Apr 24 00:20:17 UTC 2015 Modified Files: src/share/misc: acronyms Log Message: +BB = baby - with this commit, we document, rather than police,

Re: CVS commit: src/sys/ufs/ffs

2015-02-24 Thread David Holland
On Mon, Feb 23, 2015 at 01:38:54PM +, Maxime Villard wrote: Modified Files: src/sys/ufs/ffs: ffs_vfsops.c Log Message: Small changes: - instead of always calling DPRINTF with __func__, put __func__ directly in the macro - ffs_mountfs(): rename fsblockloc -

Re: CVS commit: src/sys/ufs/ffs

2015-02-14 Thread David Holland
On Sat, Feb 14, 2015 at 08:07:39AM +, Maxime Villard wrote: Modified Files: src/sys/ufs/ffs: ffs_appleufs.c Log Message: ffs_appleufs_validate(): - remove superfluous printfs - ensure ul_namelen!=0, otherwise the kernel accesses ul_name[-1] and overwrites the

Re: CVS commit: src/usr.bin/rsh

2014-10-30 Thread David Holland
On Wed, Oct 29, 2014 at 11:54:41PM -0700, John Nemeth wrote: On Oct 30, 6:13am, David A. Holland wrote: } } Module Name: src } Committed By: dholland } Date: Thu Oct 30 06:13:50 UTC 2014 } } Modified Files: }src/usr.bin/rsh: rsh.c } } Log

Re: CVS commit: src/usr.bin/rsh

2014-10-30 Thread David Holland
On Thu, Oct 30, 2014 at 04:40:57PM +, David Holland wrote: } } Module Name:src } Committed By: dholland } Date: Thu Oct 30 06:13:50 UTC 2014 } } Modified Files: } src/usr.bin/rsh: rsh.c } } Log Message: } Drop setuid before

Re: CVS commit: src/usr.bin/config

2014-10-30 Thread David Holland
On Thu, Oct 30, 2014 at 09:27:06PM +0900, Masao Uebayashi wrote: So, while you expect that options works before it's defined, you also expect the order is honored for no use. I'm not sure how it can work internally. At this moment, no are evaluated when it's parsed. Those no agp*

Re: CVS commit: src/sys/conf

2014-09-26 Thread David Holland
On Fri, Sep 19, 2014 at 09:05:23AM +, Matt Thomas wrote: Added Files: src/sys/conf: filesystems.config Log Message: include for configs which includes all file-systems and any dependent pseudo-devices Was this discussed anywhere? I'm not saying it's a bad idea; I'm just not

Re: CVS commit: src/lib/libc

2014-09-26 Thread David Holland
On Thu, Sep 25, 2014 at 03:08:29PM +, Emmanuel Dreyfus wrote: Modified Files: src/lib/libc/include: namespace.h src/lib/libc/sys: Makefile.inc Added Files: src/lib/libc/sys: fdiscard.c posix_fallocate.c Log Message: Fix argument paddiing for posix_fallocate and

Re: CVS commit: src/external/bsd/nvi/docs/USD.doc/vi.ref

2014-09-11 Thread David Holland
On Wed, Sep 10, 2014 at 05:44:22PM -0400, Christos Zoulas wrote: Modified Files: src/external/bsd/nvi/docs/USD.doc/vi.ref: Makefile ref.so vi.ref Log Message: Fix the index building which got completely broken after the last update. I thought I'd tested it, but maybe I failed to

Re: CVS commit: src/external/bsd/nvi/docs/USD.doc/vi.ref

2014-09-11 Thread David Holland
On Thu, Sep 11, 2014 at 09:20:54PM +, Christos Zoulas wrote: Modified Files: src/external/bsd/nvi/docs/USD.doc/vi.ref: Makefile ref.so vi.ref Log Message: Fix the index building which got completely broken after the last update. I thought I'd tested it, but maybe I

Re: CVS commit: src/usr.bin/make

2014-09-09 Thread David Holland
On Tue, Sep 09, 2014 at 02:19:02PM +0200, Joerg Sonnenberger wrote: Log Message: Restore apb's 20140820 commit (-r1.228 of main.c): It should not be an error to have VAR != command that prints no output Joerg reverted a bit too enthusiastically. Thanks. I will go over the

Re: C++ keyword/scope/c. changes

2014-09-08 Thread David Holland
On Mon, Sep 08, 2014 at 03:02:42PM +, Taylor R Campbell wrote: Why the sudden spate of changes in the kernel to change keywords, move struct and enum definitions, insert pointless casts, c.? Was this discussed anywhere? Beats me, and not that I saw, respectively. -- David A. Holland

Re: CVS commit: src/lib/libperfuse

2014-09-08 Thread David Holland
On Fri, Sep 05, 2014 at 01:57:19PM +, Emmanuel Dreyfus wrote: Modified Files: src/lib/libperfuse: ops.c perfuse.c Log Message: Improve POSIX compliance of FUSE filesystems through PERUSE - access denied is EPERM and not EACCES wait, what? EACCES

Re: CVS commit: src/common/lib/libprop

2014-09-06 Thread David Holland
On Fri, Sep 05, 2014 at 05:19:25AM +, Matt Thomas wrote: Modified Files: src/common/lib/libprop: prop_ingest.c prop_number.c Log Message: Eliminate use of C++ keywords and don't nest struct definitions. Why do we care if proppropliblib compiles in a C++ compiler? It is C code.

Re: CVS commit: src/lib/libperfuse

2014-09-03 Thread David Holland
On Wed, Sep 03, 2014 at 04:01:45PM +, Emmanuel Dreyfus wrote: Modified Files: src/lib/libperfuse: ops.c perfuse.c Log Message: Improve POSIX compliance of FUSE filesystems through PERUSE - access denied is EPERM and not EACCES wait, what? -- David A. Holland

Re: CVS commit: src

2014-07-29 Thread David Holland
On Tue, Jul 29, 2014 at 05:53:59AM -0400, Greg Troxel wrote: Also, note in the ucom(4) man page that there is about 1 ms of latency. Discussed on tech-kern in October of 2013, with the only concern being that someone who didn't know what they were doing might set up a stratum 1

Re: CVS commit: src/external/gpl3

2014-07-27 Thread David Holland
On Sun, Jul 27, 2014 at 09:23:26AM +0200, Martin Husemann wrote: hmmm, we should try to get the URL working again. it's baked into old binaries we will support for a while yet... The redirects seem to work already, this change should be backed out. Why? Even if it works, it's still an

Re: CVS commit: src/share/man/man9

2014-07-25 Thread David Holland
On Fri, Jul 25, 2014 at 08:38:29AM +, Thomas Klausner wrote: Modified Files: src/share/man/man9: vnodeops.9 Log Message: New sentence, new line. Punctuation formatting nits. Woops, sorry about that. -- David A. Holland dholl...@netbsd.org

Re: CVS commit: src/sys/kern

2014-07-25 Thread David Holland
On Fri, Jul 25, 2014 at 11:21:47AM +0200, Maxime Villard wrote: Log Message: Add fdiscard and posix_fallocate syscalls. I think 'error' instead of 'result' is better; it makes clear that it's an error code, and it's consistent with the other functions in the file. ! If you care that

Re: CVS commit: src

2014-07-20 Thread David Holland
On Sat, Jul 19, 2014 at 10:23:31PM +0200, Marc Balmer wrote: That's not how we update 3rd-party code in the tree. We use cvs import and resolve conflicts afterwards. Oh well.. Having recent Lua is more important than following a procedure that is difficult to follow. *boggle*

Re: CVS commit: src/sys/ufs/ffs

2014-07-11 Thread David Holland
On Thu, Jul 10, 2014 at 11:15:54AM -0400, Christos Zoulas wrote: Modified Files: src/sys/ufs/ffs: ffs_wapbl.c Log Message: CID 975226: hande error from UFS_WAPBL_BEGIN That won't work; AFAICT, if that UFS_WAPBL_BEGIN fails you need to do fs-fs_flags |= FS_DOWAPBL before calling

Re: CVS commit: src/sys/ufs/ffs

2014-07-11 Thread David Holland
On Fri, Jul 11, 2014 at 12:17:29PM -0400, Christos Zoulas wrote: Modified Files: src/sys/ufs/ffs: ffs_wapbl.c Log Message: move the flag setting higher to avoid KASSERT (dholland) unfortunately... I don't think that's right either. I'm not sure what might happen if it sets the

Re: CVS commit: src/sys

2014-07-01 Thread David Holland
On Tue, Jul 01, 2014 at 10:16:02AM +, Ryota Ozaki wrote: Log Message: Lock IFQ operations when NET_MPSAFE - Introduce NET_MPSAFE - not defined by default If it compiles (and is expected to continue to compile) please add it to ALL. -- David A. Holland dholl...@netbsd.org

Re: CVS commit: src/lib/libc

2014-06-24 Thread David Holland
On Mon, Jun 23, 2014 at 07:46:15PM +, Taylor R Campbell wrote: instead? (And can a reference to this be stuffed into the man page?) Read from /dev/urandom. ...ugh. Can we provide a wrapper around this for transparent casual use? (Even if it's in libutil and marked not for general

Re: CVS commit: src/lib/libc

2014-06-23 Thread David Holland
On Mon, Jun 23, 2014 at 02:14:10PM +, Taylor R Campbell wrote: Modified Files: src/lib/libc: shlib_version Log Message: Add `remove arc4random' to mythical libc major bump todo list. I'm not saying I disagree, but what's new code supposed to use instead? (And can a reference

Re: CVS commit: src/external/bsd/cron/dist

2014-06-22 Thread David Holland
On Sat, Jun 21, 2014 at 02:20:59PM +, Christos Zoulas wrote: Modified Files: src/external/bsd/cron/dist: do_command.c Log Message: Log some actual information on various failures, so you can tell what happened. ??? This code is not used. We are using the LOGIN_CAP code.

  1   2   3   4   5   >