Re: CVS commit: src/tests/lib/libarchive

2020-06-16 Thread Greg Troxel
Jason Thorpe writes: >> On Jun 16, 2020, at 8:43 AM, Martin Husemann wrote: >> >> No, that is definitively not OK, which is what the PR is about. >> >> It is not OK for a regular atf run to cause a reboot of the test machine >> though, so this is a temporary hack around the issue (and

Re: CVS commit: src/external/gpl3

2020-03-27 Thread Greg Troxel
Great to hear of progress. I don't see why we don't care about 8. Given our release policy, that is supported until 10 is released.

Re: CVS commit: src/external/gpl3

2020-03-26 Thread Greg Troxel
Generally speaking divergence with upstream is a problem and we lost these changes anyway in pkgsrc and every standalone GNU toolchain copy. Agreed that divergence is a problem, but so is having bugs. It's a question of the right balance in each case. Finding a creative way to make this at

Re: CVS commit: src/external/gpl3

2020-03-26 Thread Greg Troxel
Greg Troxel writes: > It seem really obvious to me, and obvious that it is netbsd consensus, > that a tool that needs tmp (without needing persistence) should default > to /tmp. So I think it's unreasonable to follow upstream here, and > unreasonable to ask everybody to either

Re: CVS commit: src/external/gpl3

2020-03-26 Thread Greg Troxel
Kamil Rytarowski writes: > On 26.03.2020 15:01, Martin Husemann wrote: >> On Thu, Mar 26, 2020 at 02:57:40PM +0100, Kamil Rytarowski wrote: >>> The build of tools could be fixed independently. >> The problem is that we build the whole system with the tools gcc, and that >> gcc misbehaves (or so

Re: CVS commit: src/external/gpl3

2020-03-25 Thread Greg Troxel
Taylor R Campbell writes: >> Do we insist on this patch? Can we remove it from local sources? > > We should keep the change. There is no semantic justification for > putting build-time temporary files in the directory for temporary > files that are meant to persist across reboot. These

Re: CVS commit: src/external/cddl/osnet/dist/uts/common/fs/zfs

2020-03-11 Thread Greg Troxel
J. Hannken-Illjes writes: >> Forgot to add in the commit log, the changes have been pulled in from >> upstream openzfs. >> >> https://github.com/openzfs/zfs/commit/928e8ad47d3478a3d5d01f0dd6ae74a9371af65e#diff-9fd6b453f8153161abe0728c449e6505R4386 > > This is NOT our upstream -- This seems to

Re: CVS commit: src/sys/sys

2019-12-24 Thread Greg Troxel
Warner Losh writes: > Just a quick note: when FreeBSD when from 9 to 10, we had to play 'hunt the > wumpus' for all the autoconfig scripts that suddenly thought they were > configuring for FreeBSD 1.0. > > If you can arrange it, it might make sense to do a pkgsrc run on an > experimental system

Re: CVS commit: src/sys/sys

2019-12-23 Thread Greg Troxel
Martin Husemann writes: > On Mon, Dec 23, 2019 at 09:02:50AM -0500, Greg Troxel wrote: >> Well, we are coming up on a year since netbsd-9 was branched, or at >> least will arrive there before this discussion resolves. So cutting >> -10 before we hit 100 works for me :-)

Re: CVS commit: src/sys/sys

2019-12-23 Thread Greg Troxel
Kamil Rytarowski writes: > On 23.12.2019 01:54, Roy Marples wrote: >> On 22/12/2019 22:24, Andrew Doran wrote: >>> NetBSD 9.99.29 - struct mount changed. >> >> Just curious - does our build software cope with 3 digit for the last >> number? >> >> Roy > > At least from the __NetBSD_Version__

Re: CVS commit: src/share/mk

2019-11-15 Thread Greg Troxel
David Brownlee writes: > On Thu, 14 Nov 2019 at 21:05, Christos Zoulas wrote: >> >> The first issue is that I prefer to have tar respect existing >> symlinks (ones that it did not create by default -- without having >> to specify extra flags) since to do this (in my opinion) does not >> pose a

Re: CVS commit: src

2019-08-27 Thread Greg Troxel
m...@netbsd.org writes: > These seem to be lowercase versions of the same names. We're going to > have trouble with the people who use case insensitive filesystems and > CVS. With any luck the multicase stuff is just dups to prune and not useful. > (Or maybe it's not so bad because they're

Re: CVS commit: src/distrib/amd64/liveimage/emuimage

2019-08-09 Thread Greg Troxel
Martin Husemann writes: > On Thu, Aug 08, 2019 at 08:09:19PM -0400, Greg Troxel wrote: >> In addition, I don't like it that images have stuff in /boot in the DOS >> partition that can't be found in some obvious place, like /usr/mdec. >> But I haven't gotten around to trying

Re: CVS commit: src/distrib/amd64/liveimage/emuimage

2019-08-08 Thread Greg Troxel
Andreas Gustafsson writes: > I really don't like the general idea of introducing differences > between images and systems installed through sysinst. It's confusing > for users, and also means that testing of one is less likely to apply > to the other. Agreed strongly. In addition, I don't

CVS commit: src/etc

2019-07-29 Thread Greg Troxel
Module Name:src Committed By: gdt Date: Mon Jul 29 17:53:20 UTC 2019 Modified Files: src/etc: MAKEDEV.tmpl Log Message: MAKEDEV.tmpl: Create nodes for 16 USB hubs As proposed on current-users, but with better formatting. To generate a diff of this commit: cvs rdiff -u

CVS commit: src/etc

2019-07-29 Thread Greg Troxel
Module Name:src Committed By: gdt Date: Mon Jul 29 17:53:20 UTC 2019 Modified Files: src/etc: MAKEDEV.tmpl Log Message: MAKEDEV.tmpl: Create nodes for 16 USB hubs As proposed on current-users, but with better formatting. To generate a diff of this commit: cvs rdiff -u

CVS commit: src/sys/dev/ic

2019-07-29 Thread Greg Troxel
Module Name:src Committed By: gdt Date: Mon Jul 29 12:07:57 UTC 2019 Modified Files: src/sys/dev/ic: mfi.c Log Message: sys/dev/ic/mfi.c: Add missing break in switch (The entire switch is guarded by MFI_DEBUG and is known not to build.) Reported by Oskar. To generate a

CVS commit: src/sys/dev/ic

2019-07-29 Thread Greg Troxel
Module Name:src Committed By: gdt Date: Mon Jul 29 12:07:57 UTC 2019 Modified Files: src/sys/dev/ic: mfi.c Log Message: sys/dev/ic/mfi.c: Add missing break in switch (The entire switch is guarded by MFI_DEBUG and is known not to build.) Reported by Oskar. To generate a

Re: CVS commit: src

2019-07-23 Thread Greg Troxel
Thomas Klausner writes: > P.S.: The file is 44k, so I'm not convinced by the "/ is small" > argument. ;) 100 * 44k is 4400k :-) The / and /usr distinction is longstanding, I don't think we should give up on it easily.

Re: CVS commit: src/sys

2019-05-14 Thread Greg Troxel
Ryota Ozaki writes: >> And, if someone is inclined, having better checks with meaurable >> slowdown under DEBUG sounds ok too, but my revised understanding is >> unclear on whether that's helpful. (But I am only trying to keep >> performance under DIAGNOSTIC high; I am unconcerned about DEBUG

Re: CVS commit: src/sys

2019-05-14 Thread Greg Troxel
Ryota Ozaki writes: > On Tue, May 14, 2019 at 2:31 AM Jason Thorpe wrote: >> >> >> >> > On May 13, 2019, at 7:17 AM, Greg Troxel wrote: >> > >> > 2) Your option 2 seems to involve two things at once: >> > >> > - migrat

Re: CVS commit: src/sys

2019-05-13 Thread Greg Troxel
Ryota Ozaki writes: > On Sat, May 11, 2019 at 10:49 AM Greg Troxel wrote: >> >> I'm sorry for delaying this task. Finally I have benchmarked a revised >> >> patch >> >> (our benchmarking setups have been out of service for a couple of >> >

Re: CVS commit: src/sys

2019-05-10 Thread Greg Troxel
Kamil Rytarowski writes: > On 08.05.2019 11:34, Ryota Ozaki wrote: >> On Sat, Apr 20, 2019 at 6:45 PM Ryota Ozaki wrote: >>> >>> On Fri, Apr 19, 2019 at 6:49 PM Kamil Rytarowski wrote: On 19.04.2019 11:41, J. Hannken-Illjes wrote: >> On 19. Apr 2019, at 03:52, Ryota Ozaki wrote:

Re: CVS commit: src/etc

2019-01-13 Thread Greg Troxel
matthew green writes: > (i wouldn't pick 'wheel' as this group -- i would invent a > new group either called 'net' or 'wpa', with no underscore > since they're designed to be assigned, unlike the groups > for specific programs security models.) Are you saying that you are ok with the following:

Re: CVS commit: src/etc

2019-01-13 Thread Greg Troxel
Jason Thorpe writes: >> On Jan 13, 2019, at 5:21 AM, Greg Troxel wrote: >> >> Even if you have to be root, these changes are still hugely useful. >> "sudo wpa_cli" is not that hard, even if it seems like it should not be >> necessary. > > ...but

Re: CVS commit: src/etc

2019-01-13 Thread Greg Troxel
Roy Marples writes: > On 13/01/2019 10:20, matthew green wrote: >> shouldn't one need to be root to modify network configuration? >> i shouldn't be able to tell wpa_supplicant to do something as >> non-root, in a default install. > > In a default install the only member of wheel is root and >

Re: Unaligned access in kernel on ARMv6+ (Re: CVS commit: src/sys/dev/usb)

2019-01-06 Thread Greg Troxel
matthew green writes: >> In short, this is because -munaligned-access is enabled on ARMv6+ by >> default for GCC. As the unaligned memory access is forbidden in the >> supervisor mode unlike in the user mode, we need to explicitly specify >> -mno-unaligned-access for kernel on ARMv6+. > > i

Re: CVS commit: src/sys/arch/evbarm/conf

2018-11-14 Thread Greg Troxel
matthew green writes: > Nick Hudson writes: >> On 13/11/2018 08:21, matthew green wrote: >> >> Modified Files: >> >> src/sys/arch/evbarm/conf: std.generic64 >> >> >> >> Log Message: >> >> turn on MODULAR by default on aarch64 >> > >> > optional things should not be in "std.foo". that should

Re: CVS commit: src/etc/etc.evbarm

2018-11-05 Thread Greg Troxel
Greg Troxel writes: > "Herbert J. Skuhra" writes: > >> On Sun, 04 Nov 2018 22:41:12 +0100, "Nick Hudson" wrote: >>> >>> Module Name:src >>> Committed By: skrll >>> Date: Sun Nov 4 21:41:12 UTC 20

Re: CVS commit: src/etc/etc.evbarm

2018-11-05 Thread Greg Troxel
"Herbert J. Skuhra" writes: > On Sun, 04 Nov 2018 22:41:12 +0100, "Nick Hudson" wrote: >> >> Module Name: src >> Committed By:skrll >> Date:Sun Nov 4 21:41:12 UTC 2018 >> >> Modified Files: >> src/etc/etc.evbarm: Makefile.inc >> >> Log Message: >> Only add

Re: CVS commit: src/external

2018-04-08 Thread Greg Troxel
m...@netbsd.org writes: > On Sun, Apr 08, 2018 at 04:57:07PM +, Jared D. McNeill wrote: >> @@ -82,6 +82,10 @@ The licenses currently used are: >> mpl Mozilla Public license. >> https://opensource.org/licenses/MPL-2.0 >> >> +nvidia-firmware NVIDIA

Re: CVS commit: src/sys

2017-10-03 Thread Greg Troxel
Manuel Bouyer writes: > On Mon, Oct 02, 2017 at 02:39:47PM +0200, Maxime Villard wrote: >> > Actually I did suggest to make the default dependant on MODULAR. >> >> what's the point exactly? > > that if I build a non-modular kernel with an emulation option explicitely >

Re: CVS commit: src/sys/dev/usb

2016-09-11 Thread Greg Troxel
Nick Hudson writes: > On 09/10/16 16:46, Jonathan A. Kollasch wrote: >> Module Name: src >> Committed By:jakllsch >> Date:Sat Sep 10 15:46:36 UTC 2016 >> >> Modified Files: >> src/sys/dev/usb: usbdevices.config >> >> Log Message: >> Make

Re: CVS commit: src/tests/lib/libutil

2015-12-31 Thread Greg Troxel
"David A. Holland" writes: > Module Name: src > Committed By: dholland > Date: Thu Dec 31 10:18:00 UTC 2015 > > Modified Files: > src/tests/lib/libutil: t_parsedate.c > > Log Message: > When evaluated on a Sunday, "next Sunday" means 7 days in the future, >

Re: CVS commit: src/sys/net

2015-12-10 Thread Greg Troxel
chris...@astron.com (Christos Zoulas) writes: > In article <20151210081103.e0fbbf...@cvs.netbsd.org>, > Kengo NAKAHARA wrote: >>-=-=-=-=-=- >> >>Module Name: src >>Committed By: knakahara >>Date: Thu Dec 10 08:11:03 UTC 2015 >> >>Modified Files: >>

Re: CVS commit: src/external/cddl/osnet/dist/lib/libdtrace/common

2015-09-25 Thread Greg Troxel
chris...@zoulas.com (Christos Zoulas) writes: > On Sep 25, 9:30am, m...@eterna.com.au (matthew green) wrote: > -- Subject: re: CVS commit: src/external/cddl/osnet/dist/lib/libdtrace/common > > | when you sync things, can you also include what version you sunc with? > | so for the next person to

Re: CVS commit: src/sys/dev

2015-05-05 Thread Greg Troxel
Michael van Elst mlel...@netbsd.org writes: Modified Files: src/sys/dev: dksubr.c Log Message: warn about labels only when built with DIAGNOSTIC This feels like an abuse of DIAGNOSTIC, which is supposed to be about asserts for detecting internal inconsistencies, not changing the

Re: CVS commit: src/distrib/atari/floppies/install

2015-04-26 Thread Greg Troxel
Izumi Tsutsui tsut...@ceres.dti.ne.jp writes: joerg@ wrote: Please don't commit untested and broken fix. Please file a PR instead if you can't test it. I agree with Christos that leaving the build broken is worse. The alternative band aids are much more involved, too. That shouldn't

Re: CVS commit: src/distrib/atari/floppies/install

2015-04-26 Thread Greg Troxel
Joerg Sonnenberger jo...@britannica.bec.de writes: On Sun, Apr 26, 2015 at 10:07:32AM -0400, Greg Troxel wrote: A broken build is evidence that the prior commits were not tested, and thus need fixing. Objecting to fixing the build without testing should be a far lower priority than

Re: CVS commit: src/share/misc

2015-04-22 Thread Greg Troxel
S.P.Zeidler s...@netbsd.org writes: Thus wrote Paul Goyette (p...@vps1.whooppee.com): At the very les, if we're going to have these acronyms, they should be listed in a separate file which is not searched by default. Similar to what is done with fortune(6). But that might not serve to

Re: CVS commit: src

2015-03-11 Thread Greg Troxel
Alan Barrett a...@cequrux.com writes: On Sat, 07 Mar 2015, Martin Husemann wrote: Anything that has no PCI. Could we rename LEGACY to something more descriptive? The problem with the name LEGACY is that it leaves people wondering whether or not particular hardware is old enough to be

Re: CVS commit: src

2015-03-11 Thread Greg Troxel
David Laight da...@l8s.co.uk writes: I'm also not sure we need a new kernel config. It seems the systems of interest are limited to 486 machines without PCI (and thus EISA probably), and that's a pretty narrow window around 1993-1994. So leaving the lines commented out with a comment

Re: CVS commit: src

2015-03-07 Thread Greg Troxel
Manuel Bouyer bou...@antioche.eu.org writes: On Sat, Mar 07, 2015 at 07:28:37AM +, matthew green wrote: Module Name: src Committed By:mrg Date:Sat Mar 7 07:28:37 UTC 2015 Modified Files: src/distrib/notes/i386: contents src/etc/etc.i386:

Re: CVS commit: src

2015-03-07 Thread Greg Troxel
Martin Husemann mar...@duskware.de writes: On Sat, Mar 07, 2015 at 08:13:17AM -0500, Greg Troxel wrote: Will LEGACY be built by default? I would vote no on that one. What's the set of computers that one has to use LEGACY on? Anything that has no PCI. That sounds ok, then. Is it just

Re: CVS commit: src/usr.bin/pwait

2015-03-03 Thread Greg Troxel
chris...@astron.com (Christos Zoulas) writes: If we want to make every single change to go through tech-userlevel, we should institute a rule to do so. To my knowledge we don't have yet such a rule. We already have the rest of the p* programs which originated in Solaris, we were missing this

Re: CVS commit: src/usr.bin/pwait

2015-03-03 Thread Greg Troxel
Marc Balmer m...@msys.ch writes: Am 03.03.15 um 14:35 schrieb Greg Troxel: chris...@astron.com (Christos Zoulas) writes: If we want to make every single change to go through tech-userlevel, we should institute a rule to do so. To my knowledge we don't have yet such a rule. We already

Re: CVS commit: src/usr.bin/pwait

2015-03-03 Thread Greg Troxel
Marc Balmer m...@msys.ch writes: I meant that adding to base was discuss-worthy because there's a bloat or necessary question, not because of risk of breakage. Sure. So how much bloat is pwait? Is it a huge piece of software or a small utility? I think that matters a bit. Posting a note

Re: CVS commit: src/usr.bin/pwait

2015-03-03 Thread Greg Troxel
Marc Balmer m...@msys.ch writes: I think you contradict yourself, when you say a) new programs in base are pretty rare, and b) we have too much commit first, argue about appropriate later. Both are true; some/most commit first discuss later isn't about new programs. While in some cases it

Re: CVS commit: src

2015-01-13 Thread Greg Troxel
Martin Husemann mar...@duskware.de writes: On Mon, Jan 12, 2015 at 02:14:17PM -0500, Christos Zoulas wrote: macppc? I don't think that the iso image produced there is bootable. The question is how many of those images are bootable? Ma68k and macppc need hybrid HFS+/ISO9660 images, which

Re: CVS commit: src

2014-07-29 Thread Greg Troxel
Nick Hudson sk...@netbsd.org writes: On 07/25/14 17:13, Greg Troxel wrote: Module Name: src Committed By:gdt Date:Fri Jul 25 16:13:21 UTC 2014 Modified Files: src/share/man/man4: ucom.4 src/sys/dev/usb: ucom.c Log Message: Add PPS support to ucom(4

Re: CVS commit: src/sys/netinet

2014-04-15 Thread Greg Troxel
Erik Fair f...@netbsd.org writes: On Apr 12, 2014, at 05:24, Greg Troxel g...@netbsd.org wrote: Module Name: src Committed By:gdt Date:Sat Apr 12 12:24:50 UTC 2014 Modified Files: src/sys/netinet: if_arp.c Log Message: revarprequest: Avoid leaking mbuf

Re: CVS commit: [tls-earlyentropy] src/distrib/utils/sysinst

2014-04-11 Thread Greg Troxel
Alan Barrett a...@cequrux.com writes: On Wed, 09 Apr 2014, Thor Lancelot Simon wrote: Modified Files: src/distrib/utils/sysinst [tls-earlyentropy]: util.c Log Message: Try to persistently gather some entropy at install time, to give the fresh system a better chance of not doing awful

Re: CVS commit: src/sys/dev/raidframe

2014-04-03 Thread Greg Troxel
...@ir.bbn.com (Greg Troxel) wrote: -- Subject: Re: CVS commit: src/sys/dev/raidframe | It seems there are 3 behaviors for root | | 1) don't change the root device (old behavior with -A yes) That does autoconfig for raid and does not deal with root at all. Right, but it is a way that some

Re: CVS commit: src/sys/dev/raidframe

2014-04-03 Thread Greg Troxel
chris...@zoulas.com (Christos Zoulas) writes: On Apr 3, 7:57am, m...@eterna.com.au (matthew green) wrote: -- Subject: re: CVS commit: src/sys/dev/raidframe | kernel configuration changes are not solutions, so 2 and 3 are out. | | if we do 4, we should instead add an option to mark

Re: CVS commit: src/sys/dev/raidframe

2014-04-02 Thread Greg Troxel
I seemed to have missed the discussion for this change. It seems there are 3 behaviors for root 1) don't change the root device (old behavior with -A yes) 2) if root is on a component, change root to the raid, otherwise don't change. 3) force the root device to be the raid (old

Re: CVS commit: src/sys/arch/amd64/conf

2014-03-15 Thread Greg Troxel
John Nemeth jnem...@cue.bc.ca writes: On Mar 15, 1:50pm, Jonathan A. Kollasch wrote: } } Module Name:src } Committed By: jakllsch } Date: Sat Mar 15 13:50:01 UTC 2014 } } Modified Files: } src/sys/arch/amd64/conf: XEN3_DOMU } } Log Message: } Enable

Re: CVS commit: src/sys/arch/amd64/conf

2014-03-15 Thread Greg Troxel
John Nemeth jnem...@cue.bc.ca writes: On Mar 15, 1:50pm, Jonathan A. Kollasch wrote: } } Module Name:src } Committed By: jakllsch } Date: Sat Mar 15 13:50:01 UTC 2014 } } Modified Files: } src/sys/arch/amd64/conf: XEN3_DOMU } } Log Message: } Enable

Re: CVS commit: src/sys/miscfs/genfs

2014-03-12 Thread Greg Troxel
Taylor R Campbell campbell+netbsd-source-change...@mumble.net writes: Date: Wed, 12 Mar 2014 16:16:32 +0200 From: Jukka Ruohonen jruoho...@iki.fi On Wed, Mar 12, 2014 at 09:39:23AM +, Juergen Hannken-Illjes wrote: Restructure layer_lock() to always lock before testing for

Re: CVS commit: src/sys/miscfs/genfs

2014-03-12 Thread Greg Troxel
Paul Goyette p...@whooppee.com writes: Me, too. But I'd rather that we had the equivalent ISCLR() macro, too, to remove another negation/complement. So is ISCLR when passed two bits true if both are clear, or if it's just not the case that both are set? Arguably this points out that the

Re: CVS commit: src/share/mk

2014-01-24 Thread Greg Troxel
chris...@zoulas.com (Christos Zoulas) writes: On Jan 22, 7:29am, m...@3am-software.com (Matt Thomas) wrote: -- Subject: Re: CVS commit: src/share/mk | I always wondered why we don't use ln -sf=20 | and avoid the race. That does not work because if the destnation is a directory it will

Re: CVS commit: src/etc

2014-01-08 Thread Greg Troxel
Alan Barrett a...@netbsd.org writes: If you have restrict default nopeer noquery (the uncommented line in my commit), then time service will still work, but the configured servers will be denied query permission. If you use restrict default ignore, then time service does not work. I have

Re: CVS commit: src/bin/csh

2013-08-06 Thread Greg Troxel
Alan Barrett a...@cequrux.com writes: On Tue, 06 Aug 2013, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Tue Aug 6 05:42:43 UTC 2013 Modified Files: src/bin/csh: lex.c Log Message: CID 1060854: Wrong sizeof argument (SIZEOF_MISMATCH) Does everybody

Re: CVS commit: src/bin/hostname

2013-07-23 Thread Greg Troxel
Erik Fair f...@netbsd.org writes: On Jul 19, 2013, at 03:34, Roy Marples r...@netbsd.org wrote: Module Name: src Committed By:roy Date:Fri Jul 19 10:34:51 UTC 2013 Modified Files: src/bin/hostname: hostname.1 hostname.c Log Message: Add the following

Re: CVS commit: src/sys

2013-06-05 Thread Greg Troxel
Jukka Ruohonen jruoho...@iki.fi writes: On Tue, Jun 04, 2013 at 07:11:02PM -0400, Christos Zoulas wrote: On Jun 5, 2:06am, jruoho...@iki.fi (Jukka Ruohonen) wrote: -- Subject: Re: CVS commit: src/sys | On Tue, Jun 04, 2013 at 06:47:37PM -0400, Christos Zoulas wrote: | While here,

Re: CVS commit: src/sys

2013-06-05 Thread Greg Troxel
Jukka Ruohonen jruoho...@iki.fi writes: On Wed, Jun 05, 2013 at 10:24:34AM -0400, Greg Troxel wrote: INET is really INET4. Sure; but see below. #ifdef INET ... #ifdef INET6 That's a bug; in theory one should be able to have INET6 without INET. I did try it once

Re: CVS commit: src/sys/netinet

2013-06-05 Thread Greg Troxel
Christos Zoulas chris...@netbsd.org writes: Module Name: src Committed By: christos Date: Wed Jun 5 00:48:32 UTC 2013 Modified Files: src/sys/netinet: udp_usrreq.c Log Message: conditionalize the net traversal code on FAST_IPSEC to make rump build. FAST_IPSEC does not

Re: CVS commit: src/sys

2013-06-05 Thread Greg Troxel
Christos Zoulas chris...@netbsd.org writes: Module Name: src Committed By: christos Date: Wed Jun 5 19:01:26 UTC 2013 Modified Files: src/sys/kern: init_main.c src/sys/netinet: in_pcb.c in_proto.c ip_icmp.c ip_input.c ip_mroute.c ip_output.c raw_ip.c

Re: CVS commit: src/sys/netinet6

2013-03-19 Thread Greg Troxel
David Laight da...@l8s.co.uk writes: On Mon, Mar 18, 2013 at 07:31:39PM +, Greg Troxel wrote: Module Name: src Committed By:gdt Date:Mon Mar 18 19:31:39 UTC 2013 Modified Files: src/sys/netinet6: ip6_output.c Log Message: Initialize variable used

Re: CVS commit: src/tests/fs/common

2013-03-18 Thread Greg Troxel
Nicolas Joly nj...@pasteur.fr writes: The zfs tests are failing when run as an unprivileged user in thread_create() ... because default limit for threads (160) is too low ! When run as root, the limit value (2500) seems to be high enough. So should we increase the default limits? It's

Re: CVS commit: src/sys/netinet

2013-03-12 Thread Greg Troxel
Christos Zoulas chris...@netbsd.org writes: Module Name: src Committed By: christos Date: Tue Mar 12 21:54:36 UTC 2013 Modified Files: src/sys/netinet: in4_cksum.c Log Message: - Don't panic on short packets unless DIAGNOSTIC. In general we should try to make the

Re: CVS commit: src/usr.sbin/mtree

2013-01-02 Thread Greg Troxel
chris...@zoulas.com (Christos Zoulas) writes: On Jan 2, 10:19am, mar...@homeworld.netbsd.org (Martin Husemann) wrote: -- Subject: Re: CVS commit: src/usr.sbin/mtree | On Thu, Dec 20, 2012 at 11:43:17AM -0500, Christos Zoulas wrote: | Module Name: src | Committed By: christos |

Re: CVS commit: src/sbin/ping

2013-01-02 Thread Greg Troxel
chris...@zoulas.com (Christos Zoulas) writes: ping -s 1 localhost linux: PING localhost (127.0.0.1) 1(29) bytes of data. 9 bytes from localhost (127.0.0.1): icmp_seq=1 ttl=64 so linux sends n bytes more than the header. macosx PING localhost (127.0.0.1): 1 data bytes 9 bytes from

Re: CVS commit: src/sbin/ping

2013-01-02 Thread Greg Troxel
I am not understanding why '-s argument is the number of data bytes beyond the standard 8-byte icmp header' is complicated. People who use -s are trying to control packet size, and the rule of 8 header + data seems to be longstanding. Looking at -current: the size of the timespec should be

Re: CVS commit: src/sbin/ping

2012-12-30 Thread Greg Troxel
3. Always send ICMP_MINLEN packets; this is what everyone else does. Makes ping -s n where n 8 work. Shouldn't that be an error? Otherwise people will think that something is happening when it isn't. pgpsqNepA4SMC.pgp Description: PGP signature

Re: CVS commit: src/external/public-domain/sqlite/dist

2012-12-16 Thread Greg Troxel
chris...@astron.com (Christos Zoulas) writes: In article 20121216202507.ga21...@britannica.bec.de, Joerg Sonnenberger jo...@britannica.bec.de wrote: Can you please not add random crappy files with unclear license? Every other distribution that contains sqlite3 (including commercial ones

Re: CVS commit: src/sys/dev/sdmmc

2012-07-17 Thread Greg Troxel
Modified Files: src/sys/dev/sdmmc: sdhc.c Log Message: Handle interrupt acknowledgement in the SDHC_FLAG_32BIT_ACCESS case in the same way as non-SDHC_FLAG_32BIT_ACCESS case. To generate a diff of this commit: cvs rdiff -u -r1.20 -r1.21 src/sys/dev/sdmmc/sdhc.c Two

Re: CVS commit: src/sys/dev/sdmmc

2012-07-17 Thread Greg Troxel
On Jul 17, 2012, at 0925 , Matt Thomas wrote: On Jul 17, 2012, at 5:39 AM, Greg Troxel wrote: 0x30 is aligned and that is the address that is read from a 32-bit access. Not enough coffee - I was reading hex as decimal :-) In the non-32 case, it seems that the EINTR register is read

Re: CVS commit: src/sys/dev/sdmmc

2012-07-17 Thread Greg Troxel
it seems odd to have bits set in SDHC_EINTR_STATUS without SDHC_ERROR_INTERRUPT set in SDHC_NINTR_STATUS, and the two code paths seem different still This is because the ESDHC doesn't set SDHC_ERROR_INTERRUPT in its register since you've read SDHC_EINTR_STATUS and can see those

Re: CVS commit: src/lib/libc

2012-03-01 Thread Greg Troxel
Code that is using gets(3) is almost always broken. It doesn't just No argument there, but that's not the question. The questions are should NetBSD provide a compliant C99 environment? (obviously yes) is moving gets(3) to libcompat consistent with the above (it seems not, since your

Re: CVS commit: src/sys/arch

2012-01-06 Thread Greg Troxel
David Holland dholland-sourcechan...@netbsd.org writes: On Fri, Jan 06, 2012 at 03:15:28PM +, Cherry G. Mathew wrote: Modified Files: src/sys/arch/x86/x86: pmap.c src/sys/arch/xen/x86: cpu.c Log Message: Address those pesky DIAGNOSTIC messages. \n Take a

Re: CVS commit: src/distrib/utils/sysinst

2011-10-31 Thread Greg Troxel
If TNF can provide a open resolver on a stable IPv6 address for use by sysinst, that'd be great. Do we need only a resolver that answers for things in netbsd.org, to find mirrors, or really a full resolver? pgpkxsOKL8CZH.pgp Description: PGP signature

Re: CVS commit: src/etc/skel

2011-10-19 Thread Greg Troxel
Jared McNeill jmcne...@invisible.ca writes: Please restore EDITOR=vi, otherwise the following message is going to haunt me for the rest of time: $ svn commit svn: Commit failed (details follow): svn: Could not use external editor to fetch log message; consider setting the $SVN_EDITOR

Re: CVS commit: src/lib/libc/gen

2011-03-13 Thread Greg Troxel
David Laight da...@l8s.co.uk writes: On Sun, Mar 13, 2011 at 07:40:45AM +, matthew green wrote: src/lib/libc/gen: unvis.c Log Message: cast ~0 to (size_t) when passing to a size_t taking function. fixes lint build errors. Is that right? My C promotion rules are getting rusty...

Re: CVS commit: src/sys/net

2010-11-12 Thread Greg Troxel
Roy Marples r...@netbsd.org writes: Module Name: src Committed By: roy Date: Fri Nov 12 16:30:27 UTC 2010 Modified Files: src/sys/net: link_proto.c route.h rtsock.c Log Message: Add RTM_CHGADDR to signal that an address on the interface has changed. This is mainly used

CVS commit: src/usr.bin/passwd

2010-03-02 Thread Greg Troxel
Module Name:src Committed By: gdt Date: Tue Mar 2 16:19:13 UTC 2010 Modified Files: src/usr.bin/passwd: local_passwd.c pam_passwd.c Log Message: Log successful and unsuccessful attempts to change passwords, via -l or pam, to ease IT audit guideline compliance. Patch

CVS commit: src/usr.bin/passwd

2010-03-02 Thread Greg Troxel
Module Name:src Committed By: gdt Date: Tue Mar 2 16:19:13 UTC 2010 Modified Files: src/usr.bin/passwd: local_passwd.c pam_passwd.c Log Message: Log successful and unsuccessful attempts to change passwords, via -l or pam, to ease IT audit guideline compliance. Patch

Re: CVS commit: src/sbin/fsck_ffs

2009-05-08 Thread Greg Troxel
(or just use FFSv2 (UFS2) etc.) in some man pages and related docs. (and also add the UFS2 paper into the SEE ALSO section?) I see both points, and think this is an excellent way to address both of them. pgpV50T6scYJU.pgp Description: PGP signature