Re: CVS commit: src/sys

2022-06-04 Thread J. Hannken-Illjes
o the /dev/xxx nodes. This breaks at least sparc64/GENERIC: sys/dev/sequencer.c:285:1: error: no previous prototype for 'sequencerattach' [-Werror=missing-prototypes] 285 | sequencerattach(int n) | ^~~ It has "midi* at midibus?" but no "pseudo-device sequence

Re: CVS commit: src

2022-05-29 Thread J. Hannken-Illjes
we build all 2**20 configurations to be sure everything at least builds? Isn't it better to always build everything and move this selection into the set lists or whatever you use to get the final image? -- J. Hannken-Illjes - hann...@mailbox.org signature.asc Description: Message signed with OpenPGP

Re: CVS commit: src/sys/dev/raidframe

2022-04-16 Thread J. Hannken-Illjes
gt; cvs rdiff -u -r1.406 -r1.407 src/sys/dev/raidframe/rf_netbsdkintf.c > > Please note that diffs are not public domain; they are subject to the > copyright notices on the relevant files. Thanks, replacing vput() with vrele() would have been even better ... -- J. Hannken-Illjes -

Re: CVS commit: src/etc

2022-02-05 Thread J. Hannken-Illjes
m /etc/fstab > first, and if /sbin/mount fails, then try to find a zfs dataset > for the failed entry and /sbin/zfs mount it. But if things go > wrong, a complicated mounting process will make troubleshooting > harder. For that reason, I'd like to keep mountcrit_zfs separate > from mountcrit_local. -- J. Hannken-Illjes - hann...@mailbox.org signature.asc Description: Message signed with OpenPGP

Re: CVS commit: src/sys

2021-02-17 Thread J. Hannken-Illjes
Jared, please test if the attached diff is sufficient. -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig uvm_swap.c.diff Description: Binary data > On 17. Feb 2021, at 13:07, Jared McNeill wrote: > > I noticed this on reboot since this change: > > [ 3636.2

Re: CVS commit: src/sys/dev/pci

2021-02-01 Thread J. Hannken-Illjes
apable: on Per-Vector Masking Capable: off Extended Message Data Capable: off Extended Message Data Enable: off Message Address (lower) register: 0xfee0 Message Address (upper) register: 0x Message Data register: 0x0064 Any ideas how to fix this issue? -

Re: CVS commit: src/sys/rump/include/rump

2020-06-16 Thread J. Hannken-Illjes
the relevant files. This broke most or all NFS tests on ATF (see attached list). Please revert or investigate. -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany) fs/nfs/t_mountd::mountdhup fs/vfs/t_full::nfs_fillfs fs/vfs/t_io::nfs_extendfile fs/vfs/t_io::nfs_extendfile_app

Re: CVS commit: src/external/cddl/osnet/dist/uts/common/fs/zfs

2020-05-07 Thread J. Hannken-Illjes
reference the vnode/znode and works for in-memory znodes only so we have to guarantee it doesn't get called after VOP_RECLAIM(). > Do you have a test case that can trigger the problem? Under load I get use-after-free of znodes in zfs_get_data() or entirely miss znodes here. See the oth

Re: CVS commit: src

2020-03-23 Thread J. Hannken-Illjes
rumpkern/rump.c:426 Are sure it is ok to detach a non-attached event? -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig signature.asc Description: Message signed with OpenPGP

Re: CVS commit: src/external/cddl/osnet/dist/uts/common/fs/zfs

2020-03-11 Thread J . Hannken-Illjes
/zfs/metaslab.c >> >> Please note that diffs are not public domain; they are subject to the >> copyright notices on the relevant files. >> > > Forgot to add in the commit log, the changes have been pulled in from > upstream openzfs. > > https://github.com

Re: CVS commit: src/sys/kern

2020-02-18 Thread J. Hannken-Illjes
> On Feb 17, 2020, at 11:19 PM, Andrew Doran wrote: > > Hi, > > On Thu, Feb 06, 2020 at 06:33:55PM +0100, J. Hannken-Illjes wrote: > >>> On 12. Jan 2020, at 18:49, Andrew Doran wrote: >>> >>> Module Name:src >>> Committed By:

Re: CVS commit: src/sys/kern

2020-02-06 Thread J. Hannken-Illjes
e calling thread, shared lock held by anyone or unlocked, respectively. This function must never be used to make locking decisions at run time: it is provided only for diagnostic purposes. I suppose you cannot determine if the current thread holds a shared l

Re: CVS commit: src/sys/miscfs/nullfs

2019-12-16 Thread J. Hannken-Illjes
ublic domain; they are subject to the > copyright notices on the relevant files. Great! Please request pullups to -8 and -9. -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig signature.asc Description: Message signed with OpenPGP

Re: CVS commit: src/external/cddl/osnet/dist/uts/common/fs/zfs

2019-10-15 Thread J. Hannken-Illjes
Should be fixed with Rev. 1.4 of src/external/cddl/osnet/dist/uts/common/fs/zfs/dmu_diff.c -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig > On 15. Oct 2019, at 00:13, Paul Goyette wrote: > > I'm now seeing a build error: > > # compile libzpool/dmu_dif

Re: CVS commit: src/tools

2019-06-23 Thread J. Hannken-Illjes
fined(__DragonFly__) || defined(__OpenBSD__) >> -# include >> # else >> # ifdef HAVE_ALLOCA_H >> # include > > This looks like unintended change? Fixed. -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de <mailto:hann...@eis.cs.tu-bs.de> - TU Braunschweig signature.asc Description: Message signed with OpenPGP

Re: CVS commit: src

2019-06-01 Thread J. Hannken-Illjes
> On 1. Jun 2019, at 13:44, Robert Elz wrote: > >Date:Sat, 1 Jun 2019 10:34:41 +0200 >From: "J. Hannken-Illjes" >Message-ID: > > | This looks wrong -- you should have added an weak alias to > | sys/rump/librump/rumpke

Re: CVS commit: src

2019-06-01 Thread J. Hannken-Illjes
t; Please note that diffs are not public domain; they are subject to the > copyright notices on the relevant files. This looks wrong -- you should have added an weak alias to sys/rump/librump/rumpkern/emul.c to handle the case where librumpvfs is not present. Please revert and fix correct

Re: CVS commit: src/sys/arch/sparc64/sparc64

2019-05-22 Thread J. Hannken-Illjes
note: each undeclared identifier is reported only once for each function it appears in -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig > On 22. May 2019, at 09:40, Martin Husemann wrote: > > Module Name: src > Committed By: martin > Date: Wed May

Re: CVS commit: src/tools

2019-05-07 Thread J. Hannken-Illjes
> On 7. May 2019, at 12:17, matthew green wrote: > >> Diff is NOT reversed. > > ah yes, i see. please commit. Done. -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Re: CVS commit: src/tools

2019-05-07 Thread J. Hannken-Illjes
Rev. 1.202 makefile has: SUBDIR+= grep xz-lib libprop .if ${TOOLS_BUILDRUMP} == "no" SUBDIR += .WAIT texinfo \ .WAIT tic \ .WAIT pax \ .WAIT ${TOOLCHAIN_BITS} \ Here libprop needs pax, but pax gets built after it. -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Re: CVS commit: src/tools

2019-05-07 Thread J. Hannken-Illjes
> Add support for libprop as a host tool library. > > > To generate a diff of this commit: > cvs rdiff -u -r1.201 -r1.202 src/tools/Makefile > cvs rdiff -u -r0 -r1.1 src/tools/libprop/Makefile Looks like libprop needs pax. Is the attached diff ok? -- J. Hannken-Illje

Re: CVS commit: src/sys

2019-04-19 Thread J. Hannken-Illjes
unused field of struct lwp is reused. For DIAGNOSTIC-only operations LWP specific data (see kern/subr_lwp_specificdata.c) is a better choice. -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig signature.asc Description: Message signed with OpenPGP

Re: CVS commit: src/sys/kern

2018-09-30 Thread J. Hannken-Illjes
domly > fail (whenever fstrans_setstate() can actually take a long > time without deadlock has to be determined, but I suspect it can). > > I think fstrans_setstate() should pause and retry in this case. As Manuel said ... This change is wrong, there is no upper time limit for a successf

Re: CVS commit: src/usr.bin/kdump

2018-06-03 Thread J. Hannken-Illjes
c/x86_64--netbsd/6.4.0/include-fixed /build/devel/obj/dist.amd64/usr/include Most includes come from "cddl/osnet/sys/sys" which looks wrong. Suppose the search better starts with "-I${NETBSDSRCDIR}/sys" ... -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germa

Re: CVS commit: src/usr.bin/make

2018-05-13 Thread J. Hannken-Illjes
mit: > cvs rdiff -u -r1.192 -r1.193 src/usr.bin/make/job.c > > Please note that diffs are not public domain; they are subject to the > copyright notices on the relevant files. > After this commit parallel builds take much longer. Building amd64 release with -j16 for example goes from 45 to 380 minutes. -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Re: CVS commit: src

2018-05-01 Thread J. Hannken-Illjes
Files in flist but missing from DESTDIR. File wasn't installed ? -- ./usr/lib/i386/lua/5.3/netpgp.so ==== end of 1 missing files == -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Re: CVS commit: src/sys/kern

2018-04-17 Thread J. Hannken-Illjes
XX/status by a factor of ~12. > >> Ok: core@ > > Any chance to pull up it to -8? Ticket #771 -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Re: CVS commit: src/sys/miscfs/procfs

2018-04-07 Thread J. Hannken-Illjes
terested in to prevent it from disappearing >> before getcwd_common(). >> >> Should fix PR kern/53096 (netbsd-8 crash on heavy disk I/O) > > Pullup? Already requested with ticket #702. -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Re: CVS commit: src/sys

2017-10-27 Thread J. Hannken-Illjes
to go this route the return value should match userland, either -1 on error or number of characters printed. The other kernel printf variants should be changed too. It needs a kernel version bump. -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Re: CVS commit: src

2016-12-08 Thread J. Hannken-Illjes
> On 08 Dec 2016, at 15:41, Nathanial Sloss <n...@netbsd.org> wrote: > > On Thu, 8 Dec 2016 23:57:51 J. Hannken-Illjes wrote: >> +#defineD_MCLOSE0x0004 >> >> What is a MCLOSE device class? >> > > Normally character device

Re: CVS commit: src

2016-12-08 Thread J. Hannken-Illjes
0x0004 What is a MCLOSE device class? > cvs rdiff -u -r1.34 -r1.35 src/sys/sys/audioio.h > cvs rdiff -u -r1.146 -r1.147 src/sys/sys/conf.h > cvs rdiff -u -r1.19 -r1.20 src/usr.bin/audio/ctl/audioctl.1 > cvs rdiff -u -r1.40 -r1.41 src/usr.bin/audio/ctl/ctl.c > > Please note

Re: CVS commit: src/sys

2016-11-23 Thread J. Hannken-Illjes
> On 11 Nov 2016, at 22:28, Jaromír Doleček <jaromir.dole...@gmail.com> wrote: > > 2016-11-11 11:52 GMT+01:00 J. Hannken-Illjes <hann...@eis.cs.tu-bs.de>: >> Returning a pointer to an arbitrary list element and using it >> later is bad d

Re: CVS commit: src/sys

2016-11-07 Thread J. Hannken-Illjes
mpossible to fix fsck here: fsck gets a file system where some inodes have the same block allocated. It is impossible to determine which allocation is wrong as its inode was in truncation. -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Re: CVS commit: src/sys

2016-11-07 Thread J. Hannken-Illjes
> On 07 Nov 2016, at 21:53, Jaromír Doleček <jaromir.dole...@gmail.com> wrote: > > 2016-11-07 12:11 GMT+01:00 J. Hannken-Illjes <hann...@eis.cs.tu-bs.de>: >> It gets used when a block of block pointers has been deallocated and >> brelsed, that is

Re: CVS commit: src/sys

2016-11-07 Thread J. Hannken-Illjes
> On 07 Nov 2016, at 11:54, Jaromír Doleček <jaromir.dole...@gmail.com> wrote: > > 2016-11-07 10:25 GMT+01:00 J. Hannken-Illjes <hann...@eis.cs.tu-bs.de>: >> The first part should not be necessary. After the loop we should have >> "i == last" --

Re: CVS commit: src/sys

2016-11-07 Thread J. Hannken-Illjes
> On 07 Nov 2016, at 00:11, Jaromír Doleček <jaromir.dole...@gmail.com> wrote: > >> On Fri, Nov 04, 2016 at 04:44:10PM +0100, J. Hannken-Illjes wrote: >>> - This change results in "panic: ffs_blkfree_common: freeing free block" >>> if I put a file

Re: CVS commit: src/sys

2016-11-04 Thread J. Hannken-Illjes
zeroing the blocks to be freed before freeing them makes the life of fsck harder. - Running "brelse(bp, BC_INVAL)" doesn't look OK. Please fix or revert soon. -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany) *1 The stress is running the shell script atta

Re: CVS commit: src/sys

2016-07-12 Thread J. Hannken-Illjes
T_HEAD(_IFADDR_HASH(ia->ia_addr.sin_addr.s_addr), ia, ia_hash); IN_ADDRHASH_WRITER_INSERT_HEAD(ia); } else if (need_reinsert) { This one looks wrong -- we enqueue "ia" twice. -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Re: CVS commit: src/sys

2016-05-26 Thread J. Hannken-Illjes
gs removed were already protected by _VFS_VNODE_PRIVATE and therefore invisible outside sys/kern/vfs_*. -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Re: CVS commit: src/sys/arch/sparc

2016-04-05 Thread J. Hannken-Illjes
> On 05 Apr 2016, at 15:05, Martin Husemann <mar...@duskware.de> wrote: > > On Tue, Apr 05, 2016 at 03:02:25PM +0200, J. Hannken-Illjes wrote: >> The attached hack works for me -- looks like we cannot use a mutex >> so early ... > > Or just skip the mutex_{e

Re: CVS commit: src/sys/arch/sparc

2016-04-05 Thread J. Hannken-Illjes
xe33790 ERROR: Last Trap: Fast Data Access MMU Miss The attached hack works for me -- looks like we cannot use a mutex so early ... -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany) openfirm.diff Description: Binary data

Re: CVS commit: src/external/gpl3/gcc.old/dist/gcc

2016-03-09 Thread J. Hannken-Illjes
st/gcc/output.h \ >src/external/gpl3/gcc.old/dist/gcc/varasm.c > cvs rdiff -u -r1.3 -r1.4 \ >src/external/gpl3/gcc.old/dist/gcc/config/i386/i386.c This change seems to break rump, number of failed tests on arch amd64 goes from 19 to 1342, same problem on i386. -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Re: CVS commit: src/sys

2015-08-27 Thread J. Hannken-Illjes
On 27 Aug 2015, at 13:26, Michael van Elst mlel...@serpens.de wrote: On Thu, Aug 27, 2015 at 11:48:15AM +0200, J. Hannken-Illjes wrote: disk_busy(dksc-sc_dkdev); + mutex_exit(dksc-sc_iolock); error = dkd-d_diskstart(dksc-sc_dev, bp

Re: CVS commit: src/sys

2015-08-27 Thread J. Hannken-Illjes
On 27 Aug 2015, at 13:26, Michael van Elst mlel...@serpens.de wrote: On Thu, Aug 27, 2015 at 11:48:15AM +0200, J. Hannken-Illjes wrote: disk_busy(dksc-sc_dkdev); + mutex_exit(dksc-sc_iolock); error = dkd-d_diskstart(dksc-sc_dev, bp

Re: CVS commit: src/sys

2015-08-27 Thread J. Hannken-Illjes
notices on the relevant files. -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Re: CVS commit: src/sys/dev/ic

2015-07-27 Thread J. Hannken-Illjes
Sure, will request pullups after one week (Jul 29). -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany) On 27 Jul 2015, at 02:15, Erik Fair f...@netbsd.org wrote: Pull up to netbsd-7 and netbsd-6? Erik On Jul 22, 2015, at 01:33, Juergen Hannken-Illjes hann

Re: CVS commit: src/sys/miscfs

2015-07-01 Thread J. Hannken-Illjes
is: large_blk: panic: kernel diagnostic assertion devvp-v_data == NULL failed: file /tmp/bracket/build/2015.06.30.06.42.06-i386/src/sys/ufs/mfs/mfs_vfsops.c, line 324 Should be fixed now. Passes ATF on i386. -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Re: CVS commit: src/sys/miscfs/specfs

2015-06-29 Thread J. Hannken-Illjes
. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Re: CVS commit: src

2015-06-02 Thread J. Hannken-Illjes
: 2015-06-01 08:50 UTC The official atf runs for i386, amd64 and sparc show sporadic failures for this test. Does it fail on every run? -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Re: CVS commit: src

2015-05-29 Thread J. Hannken-Illjes
On 29 May 2015, at 16:26, J. Hannken-Illjes hann...@eis.cs.tu-bs.de wrote: On 29 May 2015, at 09:37, Emmanuel Dreyfus m...@netbsd.org wrote: Module Name: src Committed By:manu Date:Fri May 29 07:37:32 UTC 2015 Modified Files: src/include: limits.h src

Re: CVS commit: src

2015-05-29 Thread J. Hannken-Illjes
On 29 May 2015, at 16:57, Emmanuel Dreyfus m...@netbsd.org wrote: On Fri, May 29, 2015 at 04:26:33PM +0200, J. Hannken-Illjes wrote: With this change some programs fail with assertion pthread__tsd_destructors[key] != NULL failed file src/lib/libpthread/pthread_tsd.c, line 169

Re: CVS commit: src

2014-07-28 Thread J. Hannken-Illjes
'%hhd' expects argument of type 'signed char *', but argument 3 has type 'int_fast8_t *' [-Werror=format=] Kannst Du Dir das bitte einmal ansehen? -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany) On 25 Jul 2014, at 23:43, Joerg Sonnenberger jo...@netbsd.org wrote

Re: CVS commit: src

2014-07-28 Thread J. Hannken-Illjes
oops, this was meant for Joerg only ... Since this commit i386 doesn't build, pleas take a look. On 28 Jul 2014, at 09:40, J. Hannken-Illjes hann...@eis.cs.tu-bs.de wrote: Jörg, seit diesem Commit gibt es keine i386 Builds mehr: src/tests/include/t_inttypes.c:173:2: error: format '%hhd

Re: CVS commit: src/sys/fs/msdosfs

2014-07-13 Thread J. Hannken-Illjes
a patch to lsof/dialects/n+obsd/dlsof.h like #if defined (NETBSDV) #define VFS_PROTOS(dummy) /**/ #endif before including msdosfsmount.h? -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Re: CVS commit: src/sys/kern

2014-06-15 Thread J. Hannken-Illjes
now run cache_lookup_entry() without a cpu_lock and without namecache_lock so the list may change while it gets traversed. See the comment on top of cache_lookup_entry(). Please revert your changes to vfs_cache.c. -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Re: CVS commit: src/sys

2014-06-14 Thread J. Hannken-Illjes
. This change leads to a deadlock: Thread 1 calls cache_revlookup(), holds ncp-nc_lock @ line 589, wants cpup-cpu_lock @ line 604 Thread 2 calls cache_lookup(), holds cpup-cpu_lock @ line 391, calls cache_lookup_entry(), wants ncp-nc_lock @ line 308 -- J. Hannken-Illjes - hann

Re: CVS commit: src/sys/kern

2014-04-16 Thread J. Hannken-Illjes
() which wants the proc_lock. Now we successfully stopped all softclk threads. The callout for kpause() will not fire - deadlock/ -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Re: CVS commit: src/distrib/sets/lists/comp

2014-02-27 Thread J . Hannken-Illjes
? -- ./usr/include/g++/bits/sparc ./usr/include/g++/bits/sparc64 = end of 2 extra files === Reverting this change makes sparc64 build again. -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Re: CVS commit: src

2014-02-27 Thread J. Hannken-Illjes
should be the same as before. -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Re: CVS commit: src

2014-02-27 Thread J. Hannken-Illjes
On Feb 27, 2014, at 7:01 PM, Mindaugas Rasiukevicius rm...@netbsd.org wrote: J. Hannken-Illjes hann...@eis.cs.tu-bs.de wrote: I have not had time to follow your VFS changes, but can you explain why did you remove VOP_LOCK/VOP_UNLOCK in tmpfs_reclaim()? It was added to prevent from the racy

Re: CVS commit: src/distrib/sets/lists/comp

2014-02-27 Thread J. Hannken-Illjes
? -- ./usr/include/g++/bits/sparc/c++config.h ./usr/include/g++/bits/sparc64/c++config.h end of 2 missing files == -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Re: CVS commit: src/sys

2014-02-06 Thread J. Hannken-Illjes
and operations going down to specfs for example. Here we have the problem that the specfs operation may take forever -- reading from a tty for example. -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Re: CVS commit: src/share/mk

2014-01-22 Thread J. Hannken-Illjes
be no). This breaks all builds as MKGCCCMDS is now missing from the set list print controls. See distrib/sets/mkvars.mk, target mkvars -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Re: CVS commit: src/sys/fs/tmpfs

2014-01-08 Thread J. Hannken-Illjes
calls to kmem_zalloc() and kmem_free(); OK rmind@. From OpenBSD. Is it really a good idea to allocate 528 bytes on the kernel stack? File systems nest and already use much stack space. Looks better to use a pool_cache. -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Re: CVS commit: src/sys/fs/tmpfs

2014-01-04 Thread J. Hannken-Illjes
On Jan 3, 2014, at 10:18 PM, J. Hannken-Illjes hann...@eis.cs.tu-bs.de wrote: On Jan 3, 2014, at 10:13 PM, Mindaugas Rasiukevicius rm...@netbsd.org wrote: Juergen Hannken-Illjes hann...@netbsd.org wrote: Module Name:src Committed By: hannken Date: Fri Jan 3 09

Re: CVS commit: src/sys/fs/tmpfs

2014-01-03 Thread J. Hannken-Illjes
not just check for tn_links == 0 in tmpfs_fhtovp()? Because it is ok as long as the corresponding vnode is open/referenced. -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Re: CVS commit: src/external/bsd/ntp/dist

2013-12-30 Thread J. Hannken-Illjes
/ntp.conf fails as: ntpd[317]: line 33 column 1 syntax error, unexpected T_String, expecting $end ntpd[317]: syntax error in /etc/ntp.conf line 33, column 1 -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Re: CVS commit: src/sys

2013-11-28 Thread J. Hannken-Illjes
. There are multiple reports of hangs in VFS (see something's wrong thread on current-users@ and PR/48411). It seems to be due to this change. Can you revert it for now? No -- please give me some hours more to investigate. -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig

Re: CVS commit: src/sys/fs/tmpfs

2013-11-10 Thread J. Hannken-Illjes
/vfs/t_union/tmpfs_basic and fs/vfs/t_union/tmpfs_whiteout start failing after this commit. -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Re: CVS commit: src/sys

2013-04-28 Thread J. Hannken-Illjes
() for example. The lock order is mountlist_lock-mnt_unmounting, but dounmount() locks in reverse direction. Please fix or revert. -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Re: CVS commit: src/sys

2013-04-28 Thread J. Hannken-Illjes
On Apr 28, 2013, at 10:56 AM, Michael van Elst mlel...@serpens.de wrote: On Sun, Apr 28, 2013 at 10:31:19AM +0200, J. Hannken-Illjes wrote: On Apr 27, 2013, at 12:27 AM, Michael van Elst mlel...@netbsd.org wrote: Module Name:src Committed By: mlelstv Date: Fri

Re: CVS commit: src/sys

2013-04-28 Thread J. Hannken-Illjes
On Apr 28, 2013, at 4:32 PM, Michael van Elst mlel...@serpens.de wrote: On Sun, Apr 28, 2013 at 01:50:37PM +0200, J. Hannken-Illjes wrote: The locking order hasn't been changed, but the faulty tryenter has been replaced with an enter. Sure -- and that is the problem. The locking order

Re: CVS commit: src/sys/kern

2012-12-30 Thread J. Hannken-Illjes
but there is no I/O pending. This caused my laptop to hang on boot_findwedge because: findroot: unable to read block 358331527 of dev dk0 (22) Thanks. Just applied the same to breadn(). -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Re: CVS commit: src/sys

2012-12-28 Thread J. Hannken-Illjes
to be documented in buffercache(9). Both bread() and breadn() will either return with `error == 0, *bpp != NULL' or `error != 0, *bpp == NULL'. -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Re: CVS commit: src/sys/arch/x68k/conf

2012-11-03 Thread J. Hannken-Illjes
On Nov 3, 2012, at 3:44 PM, Izumi Tsutsui wrote: Module Name: src Committed By: tsutsui Date: Sat Nov 3 14:44:29 UTC 2012 Modified Files: src/sys/arch/x68k/conf: GENERIC Log Message: Comment out pseudo-device fss. We already has options FFS_NO_SNAPSHOT. This is not

Re: CVS commit: src/sys/arch/x68k/conf

2012-11-03 Thread J. Hannken-Illjes
On Nov 3, 2012, at 4:51 PM, Izumi Tsutsui wrote: hannken@ wrote: Modified Files: src/sys/arch/x68k/conf: GENERIC Log Message: Comment out pseudo-device fss. We already has options FFS_NO_SNAPSHOT. This is not the same: - having fss makes it possible to use file system external

Re: CVS commit: src/sys/fs/union

2011-11-23 Thread J. Hannken-Illjes
On Nov 23, 2011, at 11:11 AM, Alan Barrett wrote: My vote would be to remove [unionfs]; it doesn't work and the only reason it was ever brought in had to do with alleged locking improvements. Is anyone using it? I used to make heavy use of unionfs, and I had no problems. (That was on a

Re: CVS commit: src/sys/kern

2011-11-20 Thread J. Hannken-Illjes
On Nov 19, 2011, at 5:11 PM, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Sat Nov 19 16:11:24 UTC 2011 Modified Files: src/sys/kern: cnmagic.c Log Message: PR/45633: Christian Biere: Don't access byte after NUL when setting magic. This cannot

Re: CVS commit: src/sys/kern

2011-11-20 Thread J. Hannken-Illjes
On Nov 20, 2011, at 6:10 PM, Christos Zoulas wrote: On Nov 20, 10:02am, hann...@eis.cs.tu-bs.de (J. Hannken-Illjes) wrote: -- Subject: Re: CVS commit: src/sys/kern | | On Nov 19, 2011, at 5:11 PM, Christos Zoulas wrote: | | Module Name: src | Committed By: christos | Date

Re: CVS commit: src/sys/arch/i386/i386

2011-11-19 Thread J. Hannken-Illjes
On Oct 31, 2011, at 1:42 PM, YAMAMOTO Takashi wrote: Module Name: src Committed By: yamt Date: Mon Oct 31 12:42:53 UTC 2011 Modified Files: src/sys/arch/i386/i386: dumpsys.c Log Message: dumpsys_seg: don't overwrite the previous mapping With this change in place core

Re: CVS commit: src/sys/nfs

2011-11-15 Thread J. Hannken-Illjes
On Nov 15, 2011, at 4:08 AM, YAMAMOTO Takashi wrote: hi, Module Name: src Committed By:hannken Date:Sun Oct 30 12:00:28 UTC 2011 Modified Files: src/sys/nfs: nfs_serv.c Log Message: VOP_GETATTR() needs a shared lock at least. this seems trying to lock

Re: CVS commit: src/sys

2011-10-15 Thread J. Hannken-Illjes
On Oct 15, 2011, at 3:30 AM, matthew green wrote: Module Name: src Committed By:hannken Date:Fri Oct 14 09:23:31 UTC 2011 Modified Files: src/sys/compat/linux/common: linux_file.c linux_file64.c linux_ioctl.c linux_misc.c

Re: CVS commit: src/sys/dev/pci

2011-10-07 Thread J. Hannken-Illjes
On Oct 8, 2011, at 12:42 AM, Roland Dowdeswell wrote: Module Name: src Committed By: elric Date: Fri Oct 7 22:42:19 UTC 2011 Modified Files: src/sys/dev/pci: if_iwn.c This breaks building kernels: sys/dev/pci/if_iwn.c: In function 'iwn5000_runtime_calib':

Re: CVS commit: src/sys/kern

2011-10-02 Thread J. Hannken-Illjes
On Oct 2, 2011, at 3:26 PM, Adam Hamsik wrote: On Oct,Sunday 2 2011, at 3:00 PM, Juergen Hannken-Illjes wrote: Module Name: src Committed By:hannken Date:Sun Oct 2 13:00:07 UTC 2011 Modified Files: src/sys/kern: vfs_vnode.c Log Message: The path

Re: CVS commit: src/sys/uvm

2011-09-29 Thread J. Hannken-Illjes
On Sep 29, 2011, at 12:52 AM, Matt Thomas wrote: Module Name: src Committed By: matt Date: Wed Sep 28 22:52:16 UTC 2011 Modified Files: src/sys/uvm: uvm_page.c uvm_pager.c uvm_pager.h Log Message: Reallocate emergency pager va when ncolors is increased. (modication of

Re: CVS commit: src/sys/kern

2011-08-29 Thread J. Hannken-Illjes
On Aug 29, 2011, at 2:39 AM, Mindaugas Rasiukevicius wrote: Module Name: src Committed By: rmind Date: Mon Aug 29 00:39:16 UTC 2011 Modified Files: src/sys/kern: sys_select.c Log Message: Add kern.direct_select sysctl. Default to 0 for now. Why is it disabled by

Re: CVS commit: src/distrib/alpha/instkernel/ramdisk

2011-06-21 Thread J. Hannken-Illjes
Looks like an error in the `list' file: SPECIAL pingsrcdir distrib/utils/x_gzip SPECIAL pingsrcdir distrib/utils/x_ping -- Juergen Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany) On Jun 21, 2011, at 1:36 AM, Christos Zoulas wrote: