Re: CVS commit: src/sys/uvm

2020-07-18 Thread Jukka Ruohonen
On Sat, Jul 18, 2020 at 05:19:07PM +0900, Rin Okuyama wrote: > For most (all?) ports, these specifiers are exposed only for > _KERNEL and friends. So, inttypes(*3*) would not be the best > place for them. Currently, I'm not sure where they should be. > /usr/share/misc/style? Perhaps a new

Re: CVS commit: src/sys/uvm

2020-07-16 Thread Jukka Ruohonen
On Thu, Jul 16, 2020 at 05:02:18PM +1000, matthew green wrote: > thanks! i'll try to remember we have PRIxPADDR because i > considered looking for it and thought we didn't have it... The whole { PRIxPADDR, PRIxPSIZE, ..., PRIxREGISTER } family should probably be documented in inttypes(3)? -

Re: CVS commit: src/libexec/httpd

2020-07-13 Thread Jukka Ruohonen
On Mon, Jul 13, 2020 at 07:15:45PM +1000, matthew green wrote: > i'm not sure i agree about 500 -> abusive behaviour. that's > when there's some _internal_ error and could just as easily > be caused by a human or code error on the server side. > > i don't know blocklist well enough to suggestion

Re: CVS commit: src/sys/dev/scsipi

2020-07-11 Thread Jukka Ruohonen
On Sat, Jul 11, 2020 at 02:31:46PM +, Kimmo Suominen wrote: > Use case 2: A Linode boot profile with multiple disks results in > the first disk ("sda") on LUN 1, while the second disk ("sdb") is > on LUN 0, each on their own bus. As Linode is quite popular, and supposedly uses a rather

Re: CVS commit: src/tests/lib/libc/stdlib

2020-06-27 Thread Jukka Ruohonen
On Sat, Jun 27, 2020 at 10:39:08AM +, m...@netbsd.org wrote: > > Add the default TNF copyright (2005), cf. PR misc/55419. > > I don't think we can generally do this. Can you clarify if you discussed > this with the author in commit messages? Well, the committer is christos, and I doubt he

Re: CVS commit: src/tests/usr.sbin

2020-06-24 Thread Jukka Ruohonen
On Wed, Jun 24, 2020 at 03:05:45PM +, Martin Husemann wrote: > Modified Files: > src/tests/usr.sbin/stdethers: Makefile > src/tests/usr.sbin/stdhosts: Makefile > > Log Message: > Add input files Ups. I try to be more careful, now that I again remember the nitty-gritties. - Jukka

Re: CVS commit: src/sys/dev/acpi

2020-06-23 Thread Jukka Ruohonen
On Mon, Jun 22, 2020 at 04:14:18PM +, Maxime Villard wrote: > Module Name: src > Committed By: maxv > Date: Mon Jun 22 16:14:18 UTC 2020 > > Modified Files: > src/sys/dev/acpi: acpi.c > > Log Message: > Fix memory leak. Found by kLSan. > + > + default: > +

Re: CVS commit: src/sys

2014-04-26 Thread Jukka Ruohonen
On Fri, Apr 25, 2014 at 11:54:59PM +, Taylor R Campbell wrote: Module Name: src Committed By: riastradh Date: Fri Apr 25 23:54:59 UTC 2014 Modified Files: src/sys/dev/ic: apple_smc.c src/sys/external/bsd/drm2/dist/drm/i915: intel_bios.c

Re: CVS commit: src/sys/arch/x86/acpi

2014-04-18 Thread Jukka Ruohonen
On Thu, Apr 17, 2014 at 12:01:24PM -0400, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Thu Apr 17 16:01:24 UTC 2014 Modified Files: src/sys/arch/x86/acpi: acpi_cpu_md.c Log Message: CID/1203191: Out of bounds read Oh, nasty. The code was pretty

Re: CVS commit: [tls-earlyentropy] src/distrib/utils/sysinst

2014-04-14 Thread Jukka Ruohonen
On Fri, Apr 11, 2014 at 07:14:41AM -0400, Greg Troxel wrote: All of this feels awkward. Basically it belongs in var, so I wonder about having a /rootvar or something in the root fs in the case when /var is not, and then /rootvar/db/entropy-file Please no more root-level directories! Once

Re: CVS commit: src/sys/external/bsd/drm2

2014-04-13 Thread Jukka Ruohonen
On Thu, Apr 10, 2014 at 04:29:23AM +, Taylor R Campbell wrote: Date: Wed, 9 Apr 2014 20:30:24 +0300 From: Jukka Ruohonen jruoho...@iki.fi On Fri, Apr 04, 2014 at 11:47:47AM +, Taylor R Campbell wrote: For now, yes. I can make it a sysctl, but do you have a suggestion

Re: CVS commit: src/sys/external/bsd/drm2

2014-04-09 Thread Jukka Ruohonen
On Fri, Apr 04, 2014 at 11:47:47AM +, Taylor R Campbell wrote: Date: Fri, 04 Apr 2014 11:06:45 +1100 from: matthew green m...@eterna.com.au Taylor R Campbell writes: Enable drm debug output iff boothowto has AB_DEBUG set. does this mean i can only get drm debug output

Re: CVS commit: src/sys

2014-04-09 Thread Jukka Ruohonen
On Tue, Apr 01, 2014 at 05:59:34PM +, Taylor R Campbell wrote: (That code was based on a userland version using i386_iopl, inb, and outb which I did confirm to work; I've just never run it in-kernel.) A manual page or an entry to ALL/GENERIC might be reasonable (perhaps with the word

Re: CVS commit: src/sys/external/bsd/acpica/dist/tables

2014-03-21 Thread Jukka Ruohonen
On Thu, Mar 20, 2014 at 01:40:02PM +, Taylor R Campbell wrote: Module Name: src Committed By: riastradh Date: Thu Mar 20 13:40:02 UTC 2014 Modified Files: src/sys/external/bsd/acpica/dist/tables: tbutils.c Log Message: Don't unmap Rsdp until we've finished using it.

Re: CVS commit: src/sys/external/bsd/acpica/dist/tables

2014-03-21 Thread Jukka Ruohonen
On Fri, Mar 21, 2014 at 05:01:51PM +0200, Jukka Ruohonen wrote: On Thu, Mar 20, 2014 at 01:40:02PM +, Taylor R Campbell wrote: Module Name:src Committed By: riastradh Date: Thu Mar 20 13:40:02 UTC 2014 Modified Files: src/sys/external/bsd/acpica

Re: CVS commit: src/sys/miscfs/genfs

2014-03-13 Thread Jukka Ruohonen
On Thu, Mar 13, 2014 at 04:01:33AM +, David Holland wrote: On Wed, Mar 12, 2014 at 08:11:26AM -0700, Paul Goyette wrote: Me, too. But I'd rather that we had the equivalent ISCLR() macro, too, to remove another negation/complement. So is ISCLR when passed two bits true if both are

Re: CVS commit: src/sys/miscfs/genfs

2014-03-12 Thread Jukka Ruohonen
On Wed, Mar 12, 2014 at 09:39:23AM +, Juergen Hannken-Illjes wrote: Module Name: src Committed By: hannken Date: Wed Mar 12 09:39:23 UTC 2014 Modified Files: src/sys/miscfs/genfs: layer_vnops.c Log Message: Restructure layer_lock() to always lock before testing for

Re: CVS commit: src/tests/lib/libm

2014-03-02 Thread Jukka Ruohonen
On Sat, Mar 01, 2014 at 09:08:39PM +, David Laight wrote: Log Message: Some of the acos() tests seem to fail on some systems. Sorting out why isn't helped by the tests not reporting the erronous value. Change the 'boilerplate' pattern used so that all the values are output. Reduce the

Re: CVS commit: src/distrib/sets/lists/modules

2014-01-06 Thread Jukka Ruohonen
On Sat, Jan 04, 2014 at 06:35:51PM +, David Holland wrote: I don't know 'solaris' either. That line was present in the file before I made any changes. It's the compat glop used by zfs. (I believe.) It would indeed be useful if everyting in modstat(8)'s output would have a

Re: CVS commit: src/sys/arch/x86/x86

2013-12-10 Thread Jukka Ruohonen
On Tue, Dec 10, 2013 at 02:02:41PM +0900, Masanobu SAITOH wrote: How about the following patch? Is it ok to commit? Looks good to me! - Jukka. Index: sys/arch/x86/acpi/acpi_cpu_md.c === RCS file:

Re: CVS commit: src/sys/arch/x86/x86

2013-12-08 Thread Jukka Ruohonen
On Sun, Dec 08, 2013 at 04:07:38AM +, SAITOH Masanobu wrote: Module Name: src Committed By: msaitoh Date: Sun Dec 8 04:07:38 UTC 2013 Modified Files: src/sys/arch/x86/x86: tsc.c Log Message: Update invariant TSC detect code from both Intel and AMD documents. The

Re: CVS commit: src/sys/sys

2013-11-25 Thread Jukka Ruohonen
On Mon, Nov 25, 2013 at 08:27:46PM -0500, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Tue Nov 26 01:27:46 UTC 2013 Modified Files: src/sys/sys: queue.h Log Message: Provide TAILQ_REPLACE for tmux, from FreeBSD. This should be documented in

Re: CVS commit: src/sys/arch/xen/x86

2013-11-11 Thread Jukka Ruohonen
On Sun, Nov 10, 2013 at 11:17:54AM -0800, John Nemeth wrote: } x86_wbind()? Which however appears to be (icorrectly?) #ifndef'd for Xen. Uh, the function for Xen would be wbinvd(), which would create a very nice infinite loop as all that function does is call xpq_flush_cache(). This

Re: CVS commit: src/sys/arch/xen/x86

2013-11-11 Thread Jukka Ruohonen
On Mon, Nov 11, 2013 at 02:52:30AM -0800, John Nemeth wrote: My point is, if you want to know, go read the thread in port-xen@, or the code. Also, what trivial function for Xen? The wrappers in cpufunc.S'es. - Jukka.

Re: CVS commit: src/sys/arch/xen/x86

2013-11-11 Thread Jukka Ruohonen
Thanks for the explanation! Btw, it was not criticism but a question. - Jukka. On Mon, Nov 11, 2013 at 12:31:19PM -0800, John Nemeth wrote: On Nov 11, 1:05pm, Jukka Ruohonen wrote: } On Mon, Nov 11, 2013 at 02:52:30AM -0800, John Nemeth wrote: } My point is, if you want to know, go

Re: CVS commit: src/sys/arch/xen/x86

2013-11-10 Thread Jukka Ruohonen
On Sun, Nov 10, 2013 at 01:19:13AM +, John Nemeth wrote: Module Name: src Committed By: jnemeth Date: Sun Nov 10 01:19:13 UTC 2013 Modified Files: src/sys/arch/xen/x86: x86_xpmap.c Log Message: Change xpq_flush_cache to just do WBINVD letting the hypervisor trap and

Re: CVS commit: src/common/lib/libc/arch/arm/atomic

2013-11-09 Thread Jukka Ruohonen
On Fri, Nov 08, 2013 at 10:42:52PM +, Matt Thomas wrote: Log Message: Add support for the gcc __sync builtins. A stupid but important question: what is __sync? - Jukka.

Re: CVS commit: src/usr.bin/flock

2013-10-29 Thread Jukka Ruohonen
On Tue, Oct 29, 2013 at 12:02:15PM -0400, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Tue Oct 29 16:02:15 UTC 2013 Modified Files: src/usr.bin/flock: flock.c Log Message: PR/48351: Dennis Ferguson: Fix incorrect parsing of flock flags. XXX: still

Re: CVS commit: src/distrib/sets

2013-10-27 Thread Jukka Ruohonen
On Sun, Oct 27, 2013 at 09:29:42AM +, Alan Barrett wrote: Module Name: src Committed By: apb Date: Sun Oct 27 09:29:42 UTC 2013 Modified Files: src/distrib/sets: Makefile Log Message: Add make sortlists, for sorting the set lists. This may be run manually, before

Re: CVS commit: src/sys/sys

2013-10-25 Thread Jukka Ruohonen
On Fri, Oct 25, 2013 at 08:51:55AM +, Alan Barrett wrote: Module Name: src Committed By: apb Date: Fri Oct 25 08:51:55 UTC 2013 Modified Files: src/sys/sys: cdefs.h Log Message: Add __diagused and __debugused. These are for marking variables that are used only in

Re: CVS commit: src/tests/lib/libc/net

2013-10-23 Thread Jukka Ruohonen
On Sun, Oct 20, 2013 at 01:22:49PM -0400, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Sun Oct 20 17:22:49 UTC 2013 Modified Files: src/tests/lib/libc/net: t_hostent.sh Log Message: broadway changed addresses. Something else too: the test appears

Re: CVS commit: src/sys/arch/i386/conf

2013-10-23 Thread Jukka Ruohonen
On Wed, Oct 23, 2013 at 10:37:15AM -0700, Paul Goyette wrote: On Wed, 23 Oct 2013, Matt Thomas wrote: Module Name: src Committed By:matt Date:Wed Oct 23 17:26:08 UTC 2013 Modified Files: src/sys/arch/i386/conf: GENERIC XEN3_DOM0 Log Message: Add xhci

Re: CVS commit: src/tests/lib/libc/net

2013-10-23 Thread Jukka Ruohonen
On Wed, Oct 23, 2013 at 11:11:49AM -0700, Paul Goyette wrote: Fail: stdout does not match expected value --- /tmp/inline.19256b2013-10-23 14:25:50.0 + +++ /tmp/check.19256a/stdout 2013-10-23 14:25:50.0 + @@ -1 +1 @@ -name=sixthavenue.astron.com, length=4,

Re: CVS commit: src/sys/arch/sparc

2013-10-20 Thread Jukka Ruohonen
On Sat, Oct 19, 2013 at 07:40:23PM +, matthew green wrote: Log Message: - remove unused but set variables. - use __USE() where necessary. - remove useless 'volatile' markers kd.c:consinit() might be wrong for old proms, but i've not changed it really. And a continuum: it seems to me

Re: CVS commit: src/sys/modules/lua

2013-10-18 Thread Jukka Ruohonen
On Fri, Oct 18, 2013 at 08:16:32AM +0100, Alexander Nasonov wrote: First of all, the code has been imported the wrong way as I stated in the previous email. You should properly import Lua 5.2 to sys/external/ and then apply local changes required to run it in kernel space. I agree. Already for

Re: CVS commit: xsrc/external/mit/xdm/dist/xdm

2013-10-18 Thread Jukka Ruohonen
On Fri, Oct 18, 2013 at 03:59:38PM +, Alan Barrett wrote: Module Name: xsrc Committed By: apb Date: Fri Oct 18 15:59:38 UTC 2013 Modified Files: xsrc/external/mit/xdm/dist/xdm: dm.c Log Message: Print time_t values by casting to intmax_t and using %ji format.

Re: CVS commit: src/sys/dev/pci

2013-10-17 Thread Jukka Ruohonen
On Wed, Oct 16, 2013 at 03:32:30PM -0400, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Wed Oct 16 19:32:30 UTC 2013 Modified Files: src/sys/dev/pci: cs4281.c Log Message: use __USE() What is __USE()? Might be worth a brief manual page... - Jukka.

Re: CVS commit: src/sys/dev/pci

2013-10-17 Thread Jukka Ruohonen
On Thu, Oct 17, 2013 at 08:26:33AM +0200, Martin Husemann wrote: On Thu, Oct 17, 2013 at 09:22:02AM +0300, Jukka Ruohonen wrote: Log Message: use __USE() What is __USE()? Might be worth a brief manual page... Sure, although I was thinking a brief note (with caveats) appended

Re: CVS commit: src

2013-07-24 Thread Jukka Ruohonen
On Wed, Jul 24, 2013 at 11:45:48AM +, Nick Hudson wrote: Module Name: src Committed By: skrll Date: Wed Jul 24 11:45:48 UTC 2013 Modified Files: src/doc: HACKS src/tests/lib/libc/sys: Makefile Log Message: There wasn't a codegen bug - the test program itself

Re: CVS commit: src

2013-07-19 Thread Jukka Ruohonen
On Wed, Jul 17, 2013 at 10:36:26PM +, Matt Thomas wrote: Log Message: Some constification. Add kcpuset_clone, kcpuset_insersection, kcpuset_remove, kcpuset_ffs, kcpuset_ffs_intersecting, kcpuset_atomicly_merge, kcpuset_atomicly_intersect, kcpuset_atomicly_remove A small nit:

Re: CVS commit: src

2013-07-19 Thread Jukka Ruohonen
On Fri, Jul 19, 2013 at 08:52:22AM -0700, Matt Thomas wrote: There is a reason for the difference. the atomic_{set,cler} are actually atomic. the atomicly use atomic operation but since they work word-by-word they aren't truly atomic. Ah, I see. Might be worth to mention this also in the

Re: CVS commit: src/sys

2013-06-05 Thread Jukka Ruohonen
On Wed, Jun 05, 2013 at 10:24:34AM -0400, Greg Troxel wrote: INET is really INET4. Sure; but see below. #ifdef INET ... #ifdef INET6 That's a bug; in theory one should be able to have INET6 without INET. I did try it once several years ago, and had some trouble that

Re: CVS commit: src/sys

2013-06-05 Thread Jukka Ruohonen
On Wed, Jun 05, 2013 at 11:25:00AM -0400, Greg Troxel wrote: The real decision is how many conditional options to have. Agreed. make INET mandatory. (Of course, I don't expect you or anyone else to fix these bugs unless you are in the mood.) I think the networking code is among the last

Re: CVS commit: src/sys

2013-06-04 Thread Jukka Ruohonen
On Tue, Jun 04, 2013 at 07:11:02PM -0400, Christos Zoulas wrote: On Jun 5, 2:06am, jruoho...@iki.fi (Jukka Ruohonen) wrote: -- Subject: Re: CVS commit: src/sys | On Tue, Jun 04, 2013 at 06:47:37PM -0400, Christos Zoulas wrote: | While here, simplify the code and remove the IPSEC_NAT_T

Re: CVS commit: xsrc/external/mit/xauth/dist

2013-06-02 Thread Jukka Ruohonen
On Sun, Jun 02, 2013 at 12:40:12AM +, Christos Zoulas wrote: Reminds me: should/can __UNCONST() be revisited w.r.t. the thread below? http://lists.freebsd.org/pipermail/freebsd-arch/2013-May/014371.html How/why? Yes, it's unsafe. That's the *point*. Well, there is an

Re: CVS commit: xsrc/external/mit/xauth/dist

2013-05-31 Thread Jukka Ruohonen
On Fri, May 31, 2013 at 06:46:39AM +, matthew green wrote: Module Name: xsrc Committed By: mrg Date: Fri May 31 06:46:39 UTC 2013 Modified Files: xsrc/external/mit/xauth/dist: process.c Log Message: apply __UNCONST() if it exists. Reminds me: should/can __UNCONST()

Re: CVS commit: src/crypto/external/bsd/libsaslc/dist/src

2013-05-10 Thread Jukka Ruohonen
On Fri, May 10, 2013 at 12:39:25PM -0400, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Fri May 10 16:39:25 UTC 2013 Modified Files: src/crypto/external/bsd/libsaslc/dist/src: dict.c Log Message: use explicit_bzero instead of memset to zero memory

Re: CVS commit: src/tests/fs/common

2013-03-18 Thread Jukka Ruohonen
On Mon, Mar 18, 2013 at 09:13:35PM +0100, Nicolas Joly wrote: That make a 80 CPUs host require a thread limit value of 814 (=261+7*79) to be able to run this test. Sounds like a serious test case - Jukka.

Re: CVS commit: src

2012-12-17 Thread Jukka Ruohonen
On Mon, Dec 17, 2012 at 06:17:27PM +, Alan Barrett wrote: Log Message: Add shell implementations of basename and dirname to rc.subr. They are supposed to mimic basename(1) and dirname(1), except that they are usable before /usr/bin is mounted. This demands a question: is duplication

Re: CVS commit: src/usr.sbin/envstat

2012-12-14 Thread Jukka Ruohonen
On Fri, Dec 14, 2012 at 06:18:57PM +0100, Marc Balmer wrote: Ironically, proper ressource managements tends to make it much easier to fulfill at least two of the three items... proper resource management is a good thing - if the code continues to run. In this case, where the program

Re: CVS commit: src/usr.sbin/envstat

2012-12-13 Thread Jukka Ruohonen
On Thu, Dec 13, 2012 at 11:53:24AM -0800, Paul Goyette wrote: While we're making sure to free() things, should we not also defend against memory leaks in the case where an option is used more than once? While we are here, I wonder why sysmon(9) does not follow the common guidelines w.r.t. for

Re: CVS commit: src/sys/arch

2012-12-08 Thread Jukka Ruohonen
On Sat, Dec 08, 2012 at 08:27:17AM -0600, Jonathan A. Kollasch wrote: #ifdef - #endif-ed. NMCA, NISA, NNPX, NIOAPIC, LAPIC, MPBIOS and MULTIPROCESSOR. To generate a diff of this commit: cvs rdiff -u -r1.68 -r1.69 src/sys/arch/i386/i386/db_interface.c cvs rdiff -u -r1.265 -r1.266

Re: CVS commit: src/sys/arch/i386

2012-10-01 Thread Jukka Ruohonen
On Mon, Oct 01, 2012 at 07:37:24AM +0100, David Laight wrote: The constants from it get used for ACPI power management But the only thing used for APM in ACPI is APM emulation ;-). and for power management on some completely unrelated hardware. Possibly they could be moved to a different

Re: CVS commit: src/sys/arch/i386

2012-10-01 Thread Jukka Ruohonen
On Mon, Oct 01, 2012 at 12:48:24AM +, David Holland wrote: (Also, what's the recommended usermode API for programs that want to do power stuff?) I don't think we want a single all-encompassing tool for this. At least that is my opinion, and the general direction to which many things have

Re: CVS commit: src/sys

2012-08-02 Thread Jukka Ruohonen
[6~ Also, thinking to use FreeBSD code for validation (plus checking for memwords we have). It seems to be simpler and faster: http://www.netbsd.org/~rmind/bpf_validate.diff It is nice that you point out to comprehensive test suite, but you don't have time nor interest to do anything about

Re: CVS commit: src

2012-07-30 Thread Jukka Ruohonen
On Mon, Jul 30, 2012 at 06:57:20PM +, DEGROOTE Arnaud wrote: - not connected to pmf(9) (unable to test it) This is not nice as the same thing frequently breaks suspend and resume. Hint: registering pmf(9) and testing that 'drvctl -S' works is almost the same thing as testing with real

Re: CVS commit: src/regress/lib/libc/cdb

2012-07-21 Thread Jukka Ruohonen
On Sat, Jul 21, 2012 at 10:22:56PM +, Mindaugas Rasiukevicius wrote: Module Name: src Committed By: rmind Date: Sat Jul 21 22:22:55 UTC 2012 Added Files: src/regress/lib/libc/cdb: cdb_test.c Log Message: Add a simple test for cdb(5). Is there a particular reason why

Re: CVS commit: src/tests/lib/libexecinfo

2012-06-02 Thread Jukka Ruohonen
On Sat, Jun 02, 2012 at 02:52:29PM +, Nicolas Joly wrote: Module Name: src Committed By: njoly Date: Sat Jun 2 14:52:28 UTC 2012 Modified Files: src/tests/lib/libexecinfo: t_backtrace.c Log Message: Adjust test for recent atf_machine (amd64) - atf_arch (x86_64)

Re: CVS commit: src/tests/lib/libexecinfo

2012-05-31 Thread Jukka Ruohonen
On Thu, May 31, 2012 at 12:29:55PM +0200, Martin Husemann wrote: On Wed, May 30, 2012 at 03:11:58PM +, Jukka Ruohonen wrote: Log Message: Use atf_arch instead of atf_machine; see atf-config(1). What is the difference? I think there is no such thing as atf_machine. - Jukka.

Re: CVS commit: src/tests/lib/libexecinfo

2012-05-31 Thread Jukka Ruohonen
On Thu, May 31, 2012 at 01:00:52PM +0200, Martin Husemann wrote: Well, it worked for me ;-) atf_machine The machine type name detected by ATF. This should not be tunable but is provided for symmetry with atf_arch. My bad.

Re: CVS commit: src/sys/kern

2012-05-16 Thread Jukka Ruohonen
On Wed, May 16, 2012 at 09:41:11AM +, Martin Husemann wrote: Module Name: src Committed By: martin Date: Wed May 16 09:41:11 UTC 2012 Modified Files: src/sys/kern: sys_pipe.c Log Message: Make sure we can deliver two file descriptors for pipe2() before we set up

Re: CVS commit: src/etc/mtree

2012-04-13 Thread Jukka Ruohonen
On Sat, Apr 14, 2012 at 12:14:22AM +, Paul Goyette wrote: Module Name: src Committed By: pgoyette Date: Sat Apr 14 00:14:22 UTC 2012 Modified Files: src/etc/mtree: NetBSD.dist.tests Log Message: Create the directory for the helper program; hopefully fixes the build

Re: CVS commit: src

2012-04-02 Thread Jukka Ruohonen
On Tue, Apr 03, 2012 at 11:31:13AM +1000, Simon Burge wrote: There used to be a test in regress/lib/libc/randomid/idtest.c but I can't seem to locate that in the current source tree. That tested for duplicate random numbers within a given number of calls to randomid(). I'm sure that test

Re: CVS commit: src

2012-03-29 Thread Jukka Ruohonen
On Thu, Mar 29, 2012 at 08:40:53AM +0200, Alan Barrett wrote: n=4 would probably be enough iterations, and I'd suggest checking Adjusted. By the way, some general RNG tests should be added too. I vaguely remember the so-called diehard tests somewhere from the 1990s -- perhaps something like

Re: CVS commit: src/tests/ipf

2012-03-27 Thread Jukka Ruohonen
On Tue, Mar 27, 2012 at 03:38:50PM +0200, Alan Barrett wrote: Mark the failing tests as broken. XXX: If no one is willing to maintain the ipf tests, these should be removed. I object to this. If ipf fails its tests, then the fact should be made clear in the test reports, not hidden by

Re: CVS commit: src/tests/lib/librt

2012-03-18 Thread Jukka Ruohonen
On Sat, Mar 17, 2012 at 10:14:16PM -0400, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Sun Mar 18 02:14:16 UTC 2012 Modified Files: src/tests/lib/librt: t_sched.c Log Message: this should be fixed. Hmm. But now it fails with the third check:

Re: CVS commit: src/sbin/ifconfig

2012-03-18 Thread Jukka Ruohonen
On Sun, Mar 18, 2012 at 11:57:08PM +0900, Julio Merino wrote: But why is stderr being involved? If you really want to ignore stderr in the test, pass -e ignore to atf_check. The default is -o empty -e empty. Now, the question is: do you really want to ignore the message, or do you want

Re: CVS commit: src/lib/libc/sys

2012-03-18 Thread Jukka Ruohonen
On Sat, Mar 17, 2012 at 10:04:40PM -0400, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Sun Mar 18 02:04:40 UTC 2012 Modified Files: src/lib/libc/sys: sched.c Log Message: fail as the man page says sched_rr_get_interval should. #include string.h

Re: CVS commit: src/doc

2012-03-01 Thread Jukka Ruohonen
On Fri, Mar 02, 2012 at 07:06:31AM +, Alan Barrett wrote: Module Name: src Committed By: apb Date: Fri Mar 2 07:06:31 UTC 2012 Modified Files: src/doc: 3RDPARTY Log Message: tzcode2012b and tzdata2012b ahve been released. We have updated to tzdata2012b. What was

Re: CVS commit: src/sys/external/bsd/acpica/dist/include

2012-02-19 Thread Jukka Ruohonen
On Sun, Feb 19, 2012 at 12:34:19PM +0200, Alan Barrett wrote: On Sun, 19 Feb 2012, Christos Zoulas wrote: Modified Files: src/sys/external/bsd/acpica/dist/include: acapps.h +#ifdef ACPI_REPRO +#define ACPI_DATE 1 Jan 1970 +#else +#define ACPI_DATE __DATE__ +#endif Can we use a

Re: CVS commit: src

2012-02-12 Thread Jukka Ruohonen
On Sun, Feb 12, 2012 at 09:37:25AM +0100, Martin Husemann wrote: On Sun, Feb 12, 2012 at 10:21:44AM +0200, Jukka Ruohonen wrote: Because of the consensus that /tests should mimic /src. The same note applies to more or less all syscalls etc. Generally, the current tests/kernel, tests/syscall

Re: CVS commit: src/tests/include

2011-11-06 Thread Jukka Ruohonen
On Sun, Nov 06, 2011 at 04:18:27PM +, Jukka Ruohonen wrote: Module Name: src Committed By: jruoho Date: Sun Nov 6 16:18:27 UTC 2011 Modified Files: src/tests/include: t_paths.c Log Message: Skip the test on sparc and point to PR port-sparc/45580. If there is someone

Re: CVS commit: src/share/man/man5

2011-11-06 Thread Jukka Ruohonen
On Sun, Nov 06, 2011 at 10:34:48PM +, Matthias Scheler wrote: Module Name: src Committed By: tron Date: Sun Nov 6 22:34:48 UTC 2011 Modified Files: src/share/man/man5: mk.conf.5 Log Message: Stack-smash protection is not enabled by default, at least not for the

Re: CVS commit: src/sys

2011-10-26 Thread Jukka Ruohonen
On Tue, Oct 25, 2011 at 06:21:41PM +, Christos Zoulas wrote: Another nice thing would be a KPI for sampling things like this (e.g. more robust measures like medium, harmonic mean, etc.). Or even something that could enable this kind of profiling on-demand. (I know, DTrace is there.) I

Re: CVS commit: src/sys

2011-10-25 Thread Jukka Ruohonen
On Tue, Oct 25, 2011 at 02:36:50PM +, Christos Zoulas wrote: We really want to be switching most things in the kernel to timespec from timeval not the other way around? A case came up where the transition latencies are very high, and I'd like to still use uint64_t. The precision is hardly

Re: CVS commit: src/sys

2011-10-25 Thread Jukka Ruohonen
On Tue, Oct 25, 2011 at 04:04:35PM +, Christos Zoulas wrote: In this case a simple change from: s += ntb.tv_nsec; to: s += ntb.tv_nsec / 1000; would have been sufficient since the division is outside the critical sampling section. Heh, obviously. Could be, but in the

Re: CVS commit: src/sbin/atactl

2011-10-24 Thread Jukka Ruohonen
On Mon, Oct 24, 2011 at 07:13:04PM +, Jonathan A. Kollasch wrote: Module Name: src Committed By: jakllsch Date: Mon Oct 24 19:13:04 UTC 2011 Modified Files: src/sbin/atactl: atactl.c Log Message: constify Can you follow common style guidelines and wrap longs line to

Re: CVS commit: src/sys/arch/x86/x86

2011-10-18 Thread Jukka Ruohonen
On Tue, Oct 18, 2011 at 08:43:46AM +0200, Marc Balmer wrote: Am 18.10.11 06:27, schrieb Jukka Ruohonen: On Tue, Oct 18, 2011 at 12:07:45AM +, Jared D. McNeill wrote: Module Name: src Committed By: jmcneill Date: Tue Oct 18 00:07:45 UTC 2011 Modified Files

Re: CVS commit: src

2011-10-18 Thread Jukka Ruohonen
On Tue, Oct 18, 2011 at 09:50:25AM +, Thomas Klausner wrote: Module Name: src Committed By: wiz Date: Tue Oct 18 09:50:25 UTC 2011 Modified Files: src/distrib/sets/lists/man: mi src/share/man/man4: Makefile Added Files: src/share/man/man4: vmt.4 Log

Re: CVS commit: src/sys/arch/x86/x86

2011-10-18 Thread Jukka Ruohonen
On Tue, Oct 18, 2011 at 06:39:49AM -0400, Jared McNeill wrote: I would argue that any manually loaded module shouldn't be autounloaded. What do you think about flagging modules as autoloaded and only autounloading the autoloaded ones? That sounds right to me. As noted, generally I am not

Re: CVS commit: src/sys/arch/x86/x86

2011-10-18 Thread Jukka Ruohonen
On Tue, Oct 18, 2011 at 12:44:52PM +0100, Iain Hibbert wrote: The real benefit of the modular system is that you don't need to load hundreds of modules on the off chance that they will be used. A cron entry could be used to flush unused modules if the sysop cares about that, why do we need a

Re: CVS commit: src/sys/arch/x86/x86

2011-10-18 Thread Jukka Ruohonen
On Tue, Oct 18, 2011 at 07:59:35AM -0400, Jared D. McNeill wrote: Well I loaded vmt manually and it was auto unloaded on me a few minutes later, that's why I made this change in the first place. On 2011-10-18, at 7:57 AM, Paul Goyette wrote: On Tue, 18 Oct 2011, Jukka Ruohonen wrote

Re: CVS commit: src/share/man/man4/man4.x86

2011-10-18 Thread Jukka Ruohonen
On Tue, Oct 18, 2011 at 02:25:06PM +, Thomas Klausner wrote: Module Name: src Committed By: wiz Date: Tue Oct 18 14:25:06 UTC 2011 Modified Files: src/share/man/man4/man4.x86: vmt.4 Log Message: Fix xref; comment out cpu(4) reference, does not exist. We could write

Re: CVS commit: src/sys/arch/x86/x86

2011-10-18 Thread Jukka Ruohonen
On Tue, Oct 18, 2011 at 08:49:39AM -0600, Warner Losh wrote: On Oct 18, 2011, at 4:39 AM, Jared McNeill wrote: I would argue that any manually loaded module shouldn't be autounloaded. What do you think about flagging modules as autoloaded and only autounloading the autoloaded ones?

Re: CVS commit: src/sys/fs/puffs

2011-10-18 Thread Jukka Ruohonen
On Tue, Oct 18, 2011 at 03:39:10PM +, Emmanuel Dreyfus wrote: Module Name: src Committed By: manu Date: Tue Oct 18 15:39:09 UTC 2011 Modified Files: src/sys/fs/puffs: puffs_msgif.c puffs_node.c puffs_vfsops.c puffs_vnops.c Log Message: Make sure pagedaemon

Re: CVS commit: src/external/bsd/cron/dist

2011-10-12 Thread Jukka Ruohonen
On Wed, Oct 12, 2011 at 12:39:48PM -0400, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Wed Oct 12 16:39:48 UTC 2011 Modified Files: src/external/bsd/cron/dist: cron.8 database.c pathnames.h Log Message: process files in /etc/cron.d/ Not that I see

Re: CVS commit: src/tests/net/net

2011-09-30 Thread Jukka Ruohonen
On Wed, Sep 28, 2011 at 12:13:03PM -0400, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Wed Sep 28 16:13:03 UTC 2011 Modified Files: src/tests/net/net: Makefile Added Files: src/tests/net/net: t_unix.c Log Message: Add a unix socket pathname

Re: CVS commit: src

2011-09-29 Thread Jukka Ruohonen
On Thu, Sep 29, 2011 at 10:51:25PM +0200, Jean-Yves Migeon wrote: Blocking kmem is not necessarily a bug is you hold an adaptive lock. Your mutex is IPL_NONE, if I remember correctly. You probably don't need to be smart. I am not sure that this lock will be released if the LWP needs to sleep

Re: CVS commit: src

2011-09-29 Thread Jukka Ruohonen
On Thu, Sep 29, 2011 at 10:56:48PM +0100, Alexander Nasonov wrote: Elements must go in descendant order but since values of CPUFREQ_STATE_DISABLED and CPUFREQ_STATE_ENABLED are unspecified, the manual should explicitly state in which order these two states should go. True. Every time you

Re: CVS commit: src/external/bsd/bind/dist/lib/isc/include/isc

2011-09-23 Thread Jukka Ruohonen
On Wed, Sep 14, 2011 at 08:32:44AM +0100, David Laight wrote: On Tue, Sep 13, 2011 at 03:07:44PM -0400, Christos Zoulas wrote: Module Name:src Committed By: christos Date: Tue Sep 13 19:07:44 UTC 2011 Modified Files:

Re: CVS commit: src/lib/libm/man

2011-09-17 Thread Jukka Ruohonen
On Sat, Sep 17, 2011 at 03:32:22PM +0200, Thomas Klausner wrote: Remove rest of the NOTES and ERRORS and references to pow(3) family. Why did you remove so much of the explanations in the man page? Because much of it was outdated or incomplete, and the rest was what others have criticized of

Re: CVS commit: src/tests/lib/libm

2011-09-16 Thread Jukka Ruohonen
On Fri, Sep 16, 2011 at 09:02:37AM +, Martin Husemann wrote: I am not sure if this is correct here. While some tests rely on NAN and similar IEEE 754 specific properties of the underlying floating point format should not be build (or skipped) on vax, this test case does not have any reason

Re: CVS commit: src/tests/lib/libm

2011-09-13 Thread Jukka Ruohonen
On Tue, Sep 13, 2011 at 08:38:07AM +0200, Marc Balmer wrote: Am 12.09.11 18:28, schrieb Jukka Ruohonen: Module Name:src Committed By: jruoho Date: Mon Sep 12 16:28:37 UTC 2011 Modified Files: src/tests/lib/libm: t_ldexp.c t_scalbn.c t_tanh.c Log

Re: CVS commit: src/tests/lib/libm

2011-09-13 Thread Jukka Ruohonen
On Tue, Sep 13, 2011 at 06:50:41AM +, Jukka Ruohonen wrote: Module Name: src Committed By: jruoho Date: Tue Sep 13 06:50:41 UTC 2011 Modified Files: src/tests/lib/libm: t_scalbn.c Log Message: Test that scalbn(x) == ldexp(2) whenever FLT_RADIX == 2 (like it should

Re: CVS commit: src/lib/libm/man

2011-09-12 Thread Jukka Ruohonen
On Mon, Sep 12, 2011 at 08:00:53PM +0200, Joerg Sonnenberger wrote: On Mon, Sep 12, 2011 at 02:44:27PM +, Jukka Ruohonen wrote: Module Name:src Committed By: jruoho Date: Mon Sep 12 14:44:27 UTC 2011 Modified Files: src/lib/libm/man: ldexp.3

Re: CVS commit: src/lib/libc/stdio

2011-09-11 Thread Jukka Ruohonen
On Mon, Sep 12, 2011 at 02:41:07AM +, David Holland wrote: On Sun, Sep 11, 2011 at 07:37:06AM +, Jukka Ruohonen wrote: Modified Files: src/lib/libc/stdio: funopen.3 Log Message: It is not just funopen(3) that is a BSDism. While that's true, those functions aren't

Re: CVS commit: src/share/man/man4

2011-09-07 Thread Jukka Ruohonen
On Wed, Sep 07, 2011 at 09:24:22AM +, David Holland wrote: The purpose of GENERIC is (and has been since before Linux was invented) to include all drivers and features that can reasonably be expected to work. Drivers and other code that are commented out in GENERIC (or not present at all)

Re: CVS commit: src/share/man/man4

2011-09-03 Thread Jukka Ruohonen
On Fri, Sep 02, 2011 at 11:23:08PM -0700, John Nemeth wrote: In NetBSD, GENERIC kernels generally contain everything that could possibly be useful and doesn't cause problems (some newer drivers are buggy, some interfere with other devices, and some have caused damage to hardware). This

Re: CVS commit: src/sys/arch

2011-08-30 Thread Jukka Ruohonen
Message- From: Jukka Ruohonen Sent: Tuesday, August 30, 2011 4:01 AM Newsgroups: gmane.os.netbsd.devel.cvs.full To: source-changes-full-qavaossjccednm+yrof...@public.gmane.org Subject: CVS commit: src/sys/arch Module Name: src Committed By: jruoho Date: Tue Aug 30 08:01:13 UTC 2011

Re: CVS commit: src/share/man/man4

2011-08-30 Thread Jukka Ruohonen
On Tue, Aug 30, 2011 at 03:42:34PM +0300, Jukka Ruohonen wrote: mplayer, MythTV, VDR, Kaffeine, VLC, Totem, you name it -- won't work. Correction: mplayer may work. I have couple of these cards and if time permits, I might consider a dtv(4) rewrite. - Jukka.

  1   2   3   4   5   >