CVS commit: src/libexec/ftpd

2023-09-30 Thread Mateusz Kocielski
Module Name:src Committed By: shm Date: Sat Sep 30 18:10:55 UTC 2023 Modified Files: src/libexec/ftpd: version.h Log Message: NetBSD-ftpd 20230930 Update version to "NetBSD-ftpd 20230930" for changes: - fix uninitialized memory usage in count_users() - fix pam_set_item

CVS commit: src/libexec/ftpd

2023-09-30 Thread Mateusz Kocielski
Module Name:src Committed By: shm Date: Sat Sep 30 18:10:55 UTC 2023 Modified Files: src/libexec/ftpd: version.h Log Message: NetBSD-ftpd 20230930 Update version to "NetBSD-ftpd 20230930" for changes: - fix uninitialized memory usage in count_users() - fix pam_set_item

CVS commit: src/libexec/ftpd

2023-09-30 Thread Mateusz Kocielski
Module Name:src Committed By: shm Date: Sat Sep 30 18:06:24 UTC 2023 Modified Files: src/libexec/ftpd: ftpd.c Log Message: pam_set_item PAM_SOCKADDR expects sockaddr_storage structure Instead, internal struct sockinet was used. Because it's length is shorter than

CVS commit: src/libexec/ftpd

2023-09-30 Thread Mateusz Kocielski
Module Name:src Committed By: shm Date: Sat Sep 30 18:06:24 UTC 2023 Modified Files: src/libexec/ftpd: ftpd.c Log Message: pam_set_item PAM_SOCKADDR expects sockaddr_storage structure Instead, internal struct sockinet was used. Because it's length is shorter than

CVS commit: src/libexec/ftpd

2023-09-29 Thread Mateusz Kocielski
Module Name:src Committed By: shm Date: Fri Sep 29 14:49:03 UTC 2023 Modified Files: src/libexec/ftpd: conf.c Log Message: Fix uninitialized memory usage in count_users() If the file was previously empty, pids table is not set, the code however used pids[0] which is

CVS commit: src/libexec/ftpd

2023-09-29 Thread Mateusz Kocielski
Module Name:src Committed By: shm Date: Fri Sep 29 14:49:03 UTC 2023 Modified Files: src/libexec/ftpd: conf.c Log Message: Fix uninitialized memory usage in count_users() If the file was previously empty, pids table is not set, the code however used pids[0] which is

CVS commit: src/libexec/telnetd

2023-09-22 Thread Mateusz Kocielski
Module Name:src Committed By: shm Date: Fri Sep 22 15:28:36 UTC 2023 Modified Files: src/libexec/telnetd: state.c Log Message: Fix off by one in telrcv() In case of "\r" in the data buffer, the code was unconditionally looking ahead to next character, even if "\r" was

CVS commit: src/libexec/telnetd

2023-09-22 Thread Mateusz Kocielski
Module Name:src Committed By: shm Date: Fri Sep 22 15:28:36 UTC 2023 Modified Files: src/libexec/telnetd: state.c Log Message: Fix off by one in telrcv() In case of "\r" in the data buffer, the code was unconditionally looking ahead to next character, even if "\r" was

CVS commit: src/libexec/ftpd

2023-09-22 Thread Mateusz Kocielski
Module Name:src Committed By: shm Date: Fri Sep 22 11:23:28 UTC 2023 Modified Files: src/libexec/ftpd: ftpcmd.y Log Message: Add missing check_login checks for MLST and MLSD To generate a diff of this commit: cvs rdiff -u -r1.94 -r1.95 src/libexec/ftpd/ftpcmd.y Please

CVS commit: src/libexec/ftpd

2023-09-22 Thread Mateusz Kocielski
Module Name:src Committed By: shm Date: Fri Sep 22 11:23:28 UTC 2023 Modified Files: src/libexec/ftpd: ftpcmd.y Log Message: Add missing check_login checks for MLST and MLSD To generate a diff of this commit: cvs rdiff -u -r1.94 -r1.95 src/libexec/ftpd/ftpcmd.y Please

CVS commit: src/libexec/telnetd

2023-09-21 Thread Mateusz Kocielski
Module Name:src Committed By: shm Date: Thu Sep 21 14:00:34 UTC 2023 Modified Files: src/libexec/telnetd: telnetd.c Log Message: Fix memory leak - free resources allocated by getaddrinfo To generate a diff of this commit: cvs rdiff -u -r1.58 -r1.59

CVS commit: src/libexec/telnetd

2023-09-21 Thread Mateusz Kocielski
Module Name:src Committed By: shm Date: Thu Sep 21 14:00:34 UTC 2023 Modified Files: src/libexec/telnetd: telnetd.c Log Message: Fix memory leak - free resources allocated by getaddrinfo To generate a diff of this commit: cvs rdiff -u -r1.58 -r1.59

CVS commit: src/lib/libc/gen

2023-09-21 Thread Mateusz Kocielski
Module Name:src Committed By: shm Date: Thu Sep 21 13:46:12 UTC 2023 Modified Files: src/lib/libc/gen: getcap.c Log Message: Fix memory leak in getent() Memory was not freed if record was not found To generate a diff of this commit: cvs rdiff -u -r1.57 -r1.58

CVS commit: src/lib/libc/gen

2023-09-21 Thread Mateusz Kocielski
Module Name:src Committed By: shm Date: Thu Sep 21 13:46:12 UTC 2023 Modified Files: src/lib/libc/gen: getcap.c Log Message: Fix memory leak in getent() Memory was not freed if record was not found To generate a diff of this commit: cvs rdiff -u -r1.57 -r1.58

CVS commit: src/libexec/httpd

2023-09-20 Thread Mateusz Kocielski
Module Name:src Committed By: shm Date: Wed Sep 20 08:41:35 UTC 2023 Modified Files: src/libexec/httpd: cgi-bozo.c Log Message: Removed unnecessary comment Thanks leot@ for pointing this out To generate a diff of this commit: cvs rdiff -u -r1.55 -r1.56

CVS commit: src/libexec/httpd

2023-09-20 Thread Mateusz Kocielski
Module Name:src Committed By: shm Date: Wed Sep 20 08:41:35 UTC 2023 Modified Files: src/libexec/httpd: cgi-bozo.c Log Message: Removed unnecessary comment Thanks leot@ for pointing this out To generate a diff of this commit: cvs rdiff -u -r1.55 -r1.56

CVS commit: src/libexec/httpd

2023-09-20 Thread Mateusz Kocielski
Module Name:src Committed By: shm Date: Wed Sep 20 07:13:35 UTC 2023 Modified Files: src/libexec/httpd: bozohttpd.c Log Message: Fix off-by-one in bozo_decode_url_percent In case of strings that end with '%', debug function was reading past buffer. To generate a diff

CVS commit: src/libexec/httpd

2023-09-20 Thread Mateusz Kocielski
Module Name:src Committed By: shm Date: Wed Sep 20 07:13:35 UTC 2023 Modified Files: src/libexec/httpd: bozohttpd.c Log Message: Fix off-by-one in bozo_decode_url_percent In case of strings that end with '%', debug function was reading past buffer. To generate a diff

CVS commit: src/libexec/httpd

2023-09-20 Thread Mateusz Kocielski
Module Name:src Committed By: shm Date: Wed Sep 20 07:09:14 UTC 2023 Modified Files: src/libexec/httpd: cgi-bozo.c Log Message: Remove unused variable (bp) To generate a diff of this commit: cvs rdiff -u -r1.54 -r1.55 src/libexec/httpd/cgi-bozo.c Please note that diffs

CVS commit: src/libexec/httpd

2023-09-20 Thread Mateusz Kocielski
Module Name:src Committed By: shm Date: Wed Sep 20 07:09:14 UTC 2023 Modified Files: src/libexec/httpd: cgi-bozo.c Log Message: Remove unused variable (bp) To generate a diff of this commit: cvs rdiff -u -r1.54 -r1.55 src/libexec/httpd/cgi-bozo.c Please note that diffs

CVS commit: src/libexec/httpd

2023-09-19 Thread Mateusz Kocielski
Module Name:src Committed By: shm Date: Tue Sep 19 07:51:43 UTC 2023 Modified Files: src/libexec/httpd: auth-bozo.c Log Message: Fix hr_authrealm memory leak hr_authrealm might be already set, so we need to free it before overwriting the value To generate a diff of

CVS commit: src/libexec/httpd

2023-09-19 Thread Mateusz Kocielski
Module Name:src Committed By: shm Date: Tue Sep 19 07:51:43 UTC 2023 Modified Files: src/libexec/httpd: auth-bozo.c Log Message: Fix hr_authrealm memory leak hr_authrealm might be already set, so we need to free it before overwriting the value To generate a diff of

CVS commit: src/usr.bin/mail

2023-09-08 Thread Mateusz Kocielski
Module Name:src Committed By: shm Date: Fri Sep 8 20:46:45 UTC 2023 Modified Files: src/usr.bin/mail: support.c Log Message: Add check for space presence after comma in skin() Check if comma is followed by space, otherwise it may lead to overflow in the output buffer as

CVS commit: src/usr.bin/mail

2023-09-08 Thread Mateusz Kocielski
Module Name:src Committed By: shm Date: Fri Sep 8 20:46:45 UTC 2023 Modified Files: src/usr.bin/mail: support.c Log Message: Add check for space presence after comma in skin() Check if comma is followed by space, otherwise it may lead to overflow in the output buffer as

CVS commit: src/usr.bin/mail

2023-09-08 Thread Mateusz Kocielski
Module Name:src Committed By: shm Date: Fri Sep 8 20:37:07 UTC 2023 Modified Files: src/usr.bin/mail: support.c Log Message: Fix writing outside of the nbuf buffer in skin() Data provided to skin() can be longer than LINEBUF (if same header is provided multiple times,

CVS commit: src/usr.bin/mail

2023-09-08 Thread Mateusz Kocielski
Module Name:src Committed By: shm Date: Fri Sep 8 20:37:07 UTC 2023 Modified Files: src/usr.bin/mail: support.c Log Message: Fix writing outside of the nbuf buffer in skin() Data provided to skin() can be longer than LINEBUF (if same header is provided multiple times,

CVS commit: src/usr.bin/mail

2023-09-08 Thread Mateusz Kocielski
Module Name:src Committed By: shm Date: Fri Sep 8 14:34:02 UTC 2023 Modified Files: src/usr.bin/mail: format.c Log Message: Fix check_bufsize() incorrect behaviour The function ensures that that buffer is large enough to store the data (if not, it reallocates it). It

CVS commit: src/usr.bin/mail

2023-09-08 Thread Mateusz Kocielski
Module Name:src Committed By: shm Date: Fri Sep 8 14:34:02 UTC 2023 Modified Files: src/usr.bin/mail: format.c Log Message: Fix check_bufsize() incorrect behaviour The function ensures that that buffer is large enough to store the data (if not, it reallocates it). It

CVS commit: src/usr.bin/mail

2023-09-08 Thread Mateusz Kocielski
Module Name:src Committed By: shm Date: Fri Sep 8 14:22:04 UTC 2023 Modified Files: src/usr.bin/mail: vars.c Log Message: Fixed undefined behaviour in hash() Shift left on large int values was causing an undefined behaviour, fix it by operating on unsigned int type

CVS commit: src/usr.bin/mail

2023-09-08 Thread Mateusz Kocielski
Module Name:src Committed By: shm Date: Fri Sep 8 14:22:04 UTC 2023 Modified Files: src/usr.bin/mail: vars.c Log Message: Fixed undefined behaviour in hash() Shift left on large int values was causing an undefined behaviour, fix it by operating on unsigned int type

CVS commit: src/libexec/httpd

2023-09-07 Thread Mateusz Kocielski
Module Name:src Committed By: shm Date: Thu Sep 7 06:40:56 UTC 2023 Modified Files: src/libexec/httpd: bozohttpd.c Log Message: Fix memory leaks in bozo_cleanup To generate a diff of this commit: cvs rdiff -u -r1.143 -r1.144 src/libexec/httpd/bozohttpd.c Please note

CVS commit: src/libexec/httpd

2023-09-07 Thread Mateusz Kocielski
Module Name:src Committed By: shm Date: Thu Sep 7 06:40:56 UTC 2023 Modified Files: src/libexec/httpd: bozohttpd.c Log Message: Fix memory leaks in bozo_cleanup To generate a diff of this commit: cvs rdiff -u -r1.143 -r1.144 src/libexec/httpd/bozohttpd.c Please note

CVS commit: src/libexec/mail.local

2023-09-06 Thread Mateusz Kocielski
Module Name:src Committed By: shm Date: Wed Sep 6 08:12:09 UTC 2023 Modified Files: src/libexec/mail.local: mail.local.c Log Message: - remove lock file on error - clarify diagnostic messages - initialize struct stat if lstat(2) failed (from mhal at rbox dot co) - ensure

CVS commit: src/libexec/mail.local

2023-09-06 Thread Mateusz Kocielski
Module Name:src Committed By: shm Date: Wed Sep 6 08:12:09 UTC 2023 Modified Files: src/libexec/mail.local: mail.local.c Log Message: - remove lock file on error - clarify diagnostic messages - initialize struct stat if lstat(2) failed (from mhal at rbox dot co) - ensure

CVS commit: src/sys/miscfs/procfs

2022-06-17 Thread Mateusz Kocielski
Module Name:src Committed By: shm Date: Fri Jun 17 14:30:37 UTC 2022 Modified Files: src/sys/miscfs/procfs: procfs_vnops.c Log Message: Add missing permission check To generate a diff of this commit: cvs rdiff -u -r1.228 -r1.229 src/sys/miscfs/procfs/procfs_vnops.c

CVS commit: src/sys/miscfs/procfs

2022-06-17 Thread Mateusz Kocielski
Module Name:src Committed By: shm Date: Fri Jun 17 14:30:37 UTC 2022 Modified Files: src/sys/miscfs/procfs: procfs_vnops.c Log Message: Add missing permission check To generate a diff of this commit: cvs rdiff -u -r1.228 -r1.229 src/sys/miscfs/procfs/procfs_vnops.c