Re: [sctp fix] Re: CVS commit: src/sys/kern

2020-07-18 Thread Maxime Villard
Le 28/04/2020 à 09:16, Luke Mewburn a écrit : On 20-04-26 18:15, Maxime Villard wrote: | - There was no demonstrated use-case justifying importing it. In addition, |major OSes like Windows and macOS do not implement SCTP. There just is no |demand for SCTP on the market

[mii locking] Re: CVS commit: src/sys

2020-07-09 Thread Maxime Villard
Module Name:src Committed By: thorpej Date: Sun Mar 15 23:04:51 UTC 2020 Modified Files: src/sys/arch/arm/amlogic: gxlphy.c src/sys/arch/x86/pci: if_vmx.c src/sys/dev/mii: acphy.c amhphy.c atphy.c bmtphy.c brgphy.c ciphy.c dmphy.c etphy.c

Re: [statfs12] CVS commit: src

2020-07-03 Thread Maxime Villard
Le 27/06/2020 à 17:50, Christos Zoulas a écrit : Please revert all of this change. First, there was a clear vulnerability in this change, which I fixed in: https://mail-index.netbsd.org/source-changes/2020/06/27/msg118731.html Then, as I said in the change, there are additional

[statfs12] Re: CVS commit: src

2020-06-27 Thread Maxime Villard
Module Name:src Committed By: christos Date: Fri Oct 4 01:28:03 UTC 2019 Modified Files: src/lib/libc/compat/sys: compat_statfs.c src/sys/compat/common: vfs_syscalls_20.c src/sys/compat/sys: mount.h Log Message: deduplicate the conversion function from

Re: [stos, again] Re: CVS commit: src/sys/arch/amd64

2020-06-03 Thread Maxime Villard
Le 03/06/2020 à 02:03, Kamil Rytarowski a écrit : On 03.06.2020 01:49, Andrew Doran wrote: On the assembly thing recall that recently you expressed a desire to remove all of the amd64 assembly string functions from libc because of sanitizers - I invested my time to do up a little demo to try

Re: [stos, again] Re: CVS commit: src/sys/arch/amd64

2020-06-03 Thread Maxime Villard
Le 03/06/2020 à 01:49, Andrew Doran a écrit : On Tue, Jun 02, 2020 at 08:41:53AM +0200, Maxime Villard wrote: Le 02/06/2020 ? 00:58, Andrew Doran a ?crit?: Module Name:src Committed By: ad Date: Mon Jun 1 22:58:06 UTC 2020 Modified Files: src/sys/arch/amd64/amd64

[stos, again] Re: CVS commit: src/sys/arch/amd64

2020-06-02 Thread Maxime Villard
Le 02/06/2020 à 00:58, Andrew Doran a écrit : Module Name:src Committed By: ad Date: Mon Jun 1 22:58:06 UTC 2020 Modified Files: src/sys/arch/amd64/amd64: cpufunc.S src/sys/arch/amd64/include: frameasm.h Log Message: Reported-by:

Re: [virtio] Re: CVS commit: src/sys/dev/pci

2020-05-31 Thread Maxime Villard
Le 01/06/2020 à 03:23, Shoichi Yamaguchi a écrit : Hi, On Wed, May 27, 2020 at 8:47 PM Shoichi Yamaguchi wrote: I modified virtio(4) not to allocate unused memory. I guess it fixes the issue. Could you check this? I confirmed your closing the report on syzbot.

Re: [stos] Re: CVS commit: src/sys/arch

2020-05-28 Thread Maxime Villard
Le 28/05/2020 à 23:58, Andrew Doran a écrit : On Thu, May 28, 2020 at 07:06:04PM +0200, Maxime Villard wrote: Le 27/05/2020 ? 21:58, Maxime Villard a ?crit?: Le 27/05/2020 ? 21:33, Andrew Doran a ?crit?: Module Name:??? src Committed By:??? ad Date:??? Wed May 27 19:33:40 UTC 2020

Re: [stos] Re: CVS commit: src/sys/arch

2020-05-28 Thread Maxime Villard
Le 28/05/2020 à 19:06, Maxime Villard a écrit : Le 27/05/2020 à 21:58, Maxime Villard a écrit : Le 27/05/2020 à 21:33, Andrew Doran a écrit : Module Name:    src Committed By:    ad Date:    Wed May 27 19:33:40 UTC 2020 Modified Files: src/sys/arch/amd64/amd64: cpufunc.S locore.S

Re: [stos] Re: CVS commit: src/sys/arch

2020-05-28 Thread Maxime Villard
Le 27/05/2020 à 21:58, Maxime Villard a écrit : Le 27/05/2020 à 21:33, Andrew Doran a écrit : Module Name:    src Committed By:    ad Date:    Wed May 27 19:33:40 UTC 2020 Modified Files: src/sys/arch/amd64/amd64: cpufunc.S locore.S src/sys/arch/i386/i386: cpufunc.S locore.S

[stos] Re: CVS commit: src/sys/arch

2020-05-27 Thread Maxime Villard
Le 27/05/2020 à 21:33, Andrew Doran a écrit : Module Name:src Committed By: ad Date: Wed May 27 19:33:40 UTC 2020 Modified Files: src/sys/arch/amd64/amd64: cpufunc.S locore.S src/sys/arch/i386/i386: cpufunc.S locore.S src/sys/arch/x86/include: pmap.h

[virtio] Re: CVS commit: src/sys/dev/pci

2020-05-26 Thread Maxime Villard
Hi, I don't know if this is related to your changes, but kMSan detected one uninit variable in virtio 3h ago: https://syzkaller.appspot.com/text?tag=CrashReport=12084ef610 [ 153.4370851] panic: MSan: Uninitialized Kmem Memory From virtio_pci_setup_interrupts() [

[acl] Re: CVS commit: src

2020-05-20 Thread Maxime Villard
Module Name:src Committed By: christos Date: Sat May 16 18:31:54 UTC 2020 Modified Files: [...] Log Message: Add ACL support for FFS. From FreeBSD. This broke compilation on LLVM. https://syzkaller.appspot.com/text?tag=CrashReport=153178f610 Please fix

[cpufunc] Re: CVS commit: src/sys/arch

2020-05-20 Thread Maxime Villard
Module Name:src Committed By: ad Date: Tue May 19 21:40:55 UTC 2020 Modified Files: src/sys/arch/amd64/amd64: cpufunc.S src/sys/arch/i386/i386: cpufunc.S i386func.S Log Message: Make cpu_counter(), cpu_counter32() and tsc_get_timecount() into a single

[sctp fix] Re: CVS commit: src/sys/kern

2020-04-26 Thread Maxime Villard
Le 26/04/2020 à 16:21, Jonathan A. Kollasch a écrit : > Module Name: src > Committed By: jakllsch > Date: Sun Apr 26 14:21:14 UTC 2020 > > Modified Files: > src/sys/kern: uipc_socket.c > > Log Message: > Implement SCTP bug fixes found by maxv@. > > Adding these seems to improve

Re: CVS commit: src

2020-04-26 Thread Maxime Villard
e in src/tests/sys/ or somewhere more > appropriate? > > > > > On Sun, 26 Apr 2020, Maxime Villard wrote: > >> Module Name:    src >> Committed By:    maxv >> Date:    Sun Apr 26 09:08:41 UTC 2020 >> >> Modified Files: >> src/distr

Re: CVS commit: src/sys/modules/compat_netbsd32

2020-04-19 Thread Maxime Villard
I almost got a heart attack between your first email and your second one, wondering how this code got re-enabled. Thanks for clarifying. Relevant example, by the way. Committed on August 20th 2019 at 09:32 https://mail-index.netbsd.org/source-changes/2019/08/20/msg108321.html Disabled

[disk changes] CVS commit: src/sys/dev/dkwedge

2020-04-13 Thread Maxime Villard
> Module Name:src > Committed By: jdolecek > Date: Sat Apr 11 16:00:34 UTC 2020 > > Modified Files: > src/sys/dev/dkwedge: dkwedge_apple.c dkwedge_bsdlabel.c dkwedge_gpt.c > dkwedge_mbr.c dkwedge_rdb.c It appears that since your recent changes, there is a

[vfs_cache] Re: CVS commit: src/sys/kern

2020-03-29 Thread Maxime Villard
Le 23/03/2020 à 21:02, Andrew Doran a écrit : > Module Name: src > Committed By: ad > Date: Mon Mar 23 20:02:14 UTC 2020 > > Modified Files: > src/sys/kern: vfs_cache.c > > Log Message: > cache_remove(): remove from the vnode list first, so cache_revlookup() > doesn't try to

Re: CVS commit: src

2020-03-26 Thread Maxime Villard
Le 26/03/2020 à 15:32, Jonathan A. Kollasch a écrit : > On Tue, Aug 14, 2018 at 02:49:14PM +0000, Maxime Villard wrote: >> Module Name: src >> Committed By:maxv >> Date:Tue Aug 14 14:49:14 UTC 2018 >> Log Message: >> Retire EtherI

Re: CVS commit: src/sys/dev/usb

2020-03-23 Thread Maxime Villard
Le 23/03/2020 à 04:07, Roy Marples a écrit : > On 22/03/2020 08:30, Maxime Villard wrote: >> Overall "From OpenBSD" is a redflag for buggy and vulnerable code.. > > We should be above this, no software is perfect, not even ours. > > Roy You seem to be confusing

Re: CVS commit: src/sys/dev/usb

2020-03-22 Thread Maxime Villard
Le 19/03/2020 à 08:49, Pierre Pronchery a écrit : > Module Name: src > Committed By: khorben > Date: Thu Mar 19 07:49:29 UTC 2020 > > Modified Files: > src/sys/dev/usb: if_umb.c > > Log Message: > When there is no network around the state timeout fires over and over again. >

Re: CVS commit: src/sys/ufs/ufs

2020-03-11 Thread Maxime Villard
Le 27/02/2020 à 01:36, Simon Burge a écrit : > "Maxime Villard" wrote: > >> Module Name: src >> Committed By:maxv >> Date:Wed Feb 26 18:00:12 UTC 2020 >> >> Modified Files: >> >> src/sys/ufs/ufs: ufs_vnops.c

Re: CVS commit: src/sys/kern

2020-03-09 Thread Maxime Villard
Le 08/03/2020 à 21:41, Andrew Doran a écrit : > On Sun, Mar 08, 2020 at 08:34:29AM +0100, Maxime Villard wrote: >> Le 08/03/2020 ? 01:31, Andrew Doran a ?crit?: >>> Module Name:src >>> Committed By: ad >>> Date: Sun Mar 8 00:3

Re: CVS commit: src

2020-03-07 Thread Maxime Villard
Le 08/03/2020 à 02:33, Andrew Doran a écrit : > On Sat, Mar 07, 2020 at 12:24:21PM +0100, Maxime Villard wrote: > >> Can we revert the "__aligned(COHERENCY_UNIT)" for now? There is no particular >> hurry to fix this bug, however the KUBSAN instance has been down for

Re: CVS commit: src/sys/kern

2020-03-07 Thread Maxime Villard
Le 08/03/2020 à 01:31, Andrew Doran a écrit : > Module Name: src > Committed By: ad > Date: Sun Mar 8 00:31:19 UTC 2020 > > Modified Files: > src/sys/kern: subr_kmem.c > > Log Message: > KMEM_SIZE: append the size_t to the allocated buffer, rather than > prepending, so it doesn't

Re: CVS commit: src

2020-03-07 Thread Maxime Villard
Le 25/02/2020 à 19:18, Maxime Villard a écrit : > Le 23/02/2020 à 23:19, Andrew Doran a écrit : >> On Fri, Feb 21, 2020 at 02:14:31PM +0100, Kamil Rytarowski wrote: >> >>> On 22.12.2019 20:47, Andrew Doran wrote: >>>> Module Name:    src >>>> Commit

Re: CVS commit: src

2020-02-25 Thread Maxime Villard
Le 23/02/2020 à 23:19, Andrew Doran a écrit : On Fri, Feb 21, 2020 at 02:14:31PM +0100, Kamil Rytarowski wrote: On 22.12.2019 20:47, Andrew Doran wrote: Module Name:src Committed By: ad Date: Sun Dec 22 19:47:35 UTC 2019 Modified Files:

Re: CVS commit: src/sys/arch/aarch64

2020-01-30 Thread Maxime Villard
Le 28/01/2020 à 19:39, Nick Hudson a écrit : > On 28/01/2020 17:47, Maxime Villard wrote: >> @@ -460,8 +460,7 @@ cpu_setup_id(struct cpu_info *ci) >> >>   id->ac_aa64mmfr0 = reg_id_aa64mmfr0_el1_read(); >>   id->ac_aa64mmfr1 = reg_id_aa64mmfr1_el1_r

Re: [x86 pmap changes] CVS commit: src/sys/arch

2020-01-09 Thread Maxime Villard
Le 08/01/2020 à 22:50, Andrew Doran a écrit : On Tue, Jan 07, 2020 at 09:39:22AM +0100, Maxime Villard wrote: Module Name:src Committed By: ad Date: Sat Jan 4 22:49:20 UTC 2020 Modified Files: src/sys/arch/x86/include: pmap.h pmap_pv.h src/sys/arch/x86/x86

Re: [x86 pmap changes] CVS commit: src/sys/arch

2020-01-07 Thread Maxime Villard
Le 07/01/2020 à 09:39, Maxime Villard a écrit : Module Name:    src Committed By:   ad Date:   Sat Jan  4 22:49:20 UTC 2020 Modified Files:     src/sys/arch/x86/include: pmap.h pmap_pv.h     src/sys/arch/x86/x86: pmap.c     src/sys/arch/xen/x86: xen_pmap.c Log Message: x86

[x86 pmap changes] CVS commit: src/sys/arch

2020-01-07 Thread Maxime Villard
Module Name:src Committed By: ad Date: Sat Jan 4 22:49:20 UTC 2020 Modified Files: src/sys/arch/x86/include: pmap.h pmap_pv.h src/sys/arch/x86/x86: pmap.c src/sys/arch/xen/x86: xen_pmap.c Log Message: x86 pmap improvements, reducing system time during a

Re: CVS commit: src/sys/arch/amd64

2020-01-05 Thread Maxime Villard
Le 05/01/2020 à 13:56, Maxime Villard a écrit : > Le 05/01/2020 à 02:03, Emmanuel Dreyfus a écrit : >> On Sat, Jan 04, 2020 at 08:43:16AM +0100, Maxime Villard wrote: >>> +.section multiboot,"",@note >>> Why @note? It will be in the .text anyway. Also why n

Re: CVS commit: src/sys/arch/amd64

2020-01-05 Thread Maxime Villard
Le 05/01/2020 à 02:03, Emmanuel Dreyfus a écrit : > On Sat, Jan 04, 2020 at 08:43:16AM +0100, Maxime Villard wrote: >> +.section multiboot,"",@note >> Why @note? It will be in the .text anyway. Also why no dot in the section >> name? That's supposed to be the

Re: CVS commit: src/sys/arch/amd64

2020-01-04 Thread Maxime Villard
Le 04/01/2020 à 03:33, Emmanuel Dreyfus a écrit : On Tue, Dec 31, 2019 at 09:32:05AM +0100, Maxime Villard wrote: I think max-page-size=0x1000 is the right thing to do, but someone needs to verify that the resulting binary is correct and that the resulting in-memory layout is correct too

Re: CVS commit: src/sys/arch/amd64

2019-12-31 Thread Maxime Villard
Le 30/12/2019 à 16:15, Emmanuel Dreyfus a écrit : > On Sat, Dec 28, 2019 at 02:22:21AM +, Emmanuel Dreyfus wrote: >>> Regardless of whether it is needed in this specific case, cutting the 2MBs >>> of zero in the binary is wanted. Unfortunately last I looked at this (two >>> years ago) there

Re: CVS commit: src/sys/arch/amd64

2019-12-27 Thread Maxime Villard
Le 27/12/2019 à 17:45, Emmanuel Dreyfus a écrit : > On Fri, Dec 27, 2019 at 09:02:17AM +0100, Maxime Villard wrote: >> Please stop with the nonsense... In this patch you are making the multiboot >> header executable, and putting it in a section shared with userland under >>

Re: CVS commit: src/sys/arch/amd64

2019-12-27 Thread Maxime Villard
Le 26/12/2019 à 17:55, Emmanuel Dreyfus a écrit : > On Wed, Dec 25, 2019 at 05:05:11PM +0900, Masanobu SAITOH wrote: After this change, amd64 kernel does not boot on my HP Spectre x360 13-inch ae019TU laptop with pure UEFI boot mode. >> I have a UEFI boot machine and it also doesn't

Re: CVS commit: src

2019-12-23 Thread Maxime Villard
Le 23/12/2019 à 04:18, Taylor R Campbell a écrit : Date: Sun, 22 Dec 2019 10:24:01 +0100 From: Maxime Villard You, Martin Christos and Taylor, are trying to change subject, find excuses, and are sending me irrelevant responses vaguely insinuating that I should revert my change only without

Re: CVS commit: src

2019-12-22 Thread Maxime Villard
Le 21/12/2019 à 23:48, Christos Zoulas a écrit : In article <15520611-7273-9567-33a4-ff2490b2e...@m00nbsd.net>, Maxime Villard wrote: Le 21/12/2019 à 00:05, Taylor R Campbell a écrit : Security-team is not perfect. We're happy to discuss a better way to disable filemon provisi

Re: CVS commit: src

2019-12-21 Thread Maxime Villard
Le 21/12/2019 à 00:05, Taylor R Campbell a écrit : Security-team is not perfect. We're happy to discuss a better way to disable filemon provisionally, and/or how to better address the existing users if we are to delete it -- after you do as core asked you to do to resolve the interim dispute by

Re: CVS commit: src

2019-12-21 Thread Maxime Villard
End of excerpt from Maxime Villard The first proposed change was to create a .plist file. I liked it because it didn't require running postinstall to get the fix. It provoked a bit of disgruntled voices, a continuation tech-kern bikeshed about the correct way to disable module auto-loading in a per-mod

Re: CVS commit: src

2019-12-20 Thread Maxime Villard
Le 20/12/2019 à 20:52, Martin Husemann a écrit : On Fri, Dec 20, 2019 at 07:54:36PM +0100, Maxime Villard wrote: Alright, fair enough. I will revert my removal over the week-end, because it hasn't received sufficient public discussion. Thank you! As well, I will revert secteam's killing

Re: CVS commit: src

2019-12-20 Thread Maxime Villard
Le 19/12/2019 à 17:57, Taylor R Campbell a écrit : Date: Thu, 19 Dec 2019 08:19:07 +0100 From: Maxime Villard I think you meant to say "REMOVING things you don't like". Correct, I made an editing error. Sorry for the confusion. In the meantime, I have absolutely no intent to

Re: CVS commit: src

2019-12-18 Thread Maxime Villard
Answering quickly: Le 18/12/2019 à 21:24, Taylor R Campbell a écrit : Module Name:src Committed By: maxv Date: Wed Dec 18 07:37:19 UTC 2019 Log Message: Retire filemon, discussed on tech-kern@. Please refrain from taking unilateral actions such as things you don't like

Re: CVS commit: src/sys/arch

2019-12-13 Thread Maxime Villard
Le 12/12/2019 à 10:20, Maxime Villard a écrit : Le 10/12/2019 à 03:06, Emmanuel Dreyfus a écrit : Module Name:    src Committed By:    manu Date:    Tue Dec 10 02:06:07 UTC 2019 Modified Files: src/sys/arch/amd64/amd64: locore.S machdep.c src/sys/arch/amd64/conf: GENERIC

Re: CVS commit: src/sys/arch

2019-12-12 Thread Maxime Villard
Le 10/12/2019 à 03:06, Emmanuel Dreyfus a écrit : Module Name:src Committed By: manu Date: Tue Dec 10 02:06:07 UTC 2019 Modified Files: src/sys/arch/amd64/amd64: locore.S machdep.c src/sys/arch/amd64/conf: GENERIC files.amd64 kern.ldscript

Re: CVS commit: src/sys/kern

2019-12-12 Thread Maxime Villard
Le 08/12/2019 à 14:22, Martin Husemann a écrit : On Sun, Dec 08, 2019 at 12:58:20PM +0100, Maxime Villard wrote: kMSan has special constraints which, in this specific case, come down to: each function called from a KCOV instrumentation callback must be a static inline tagged with __nomsan

Re: CVS commit: src/sys/kern

2019-12-08 Thread Maxime Villard
Le 08/12/2019 à 00:51, Kamil Rytarowski a écrit : On 08.12.2019 00:35, matthew green wrote: Module Name:src Committed By: kamil Date: Sat Dec 7 19:50:34 UTC 2019 Modified Files: src/sys/kern: subr_kcov.c Log Message: Revert the in_interrupt() change to use again the

Re: CVS commit: src/sys

2019-12-06 Thread Maxime Villard
Le 06/12/2019 à 08:49, m...@netbsd.org a écrit : > On Fri, Dec 06, 2019 at 07:27:07AM +0000, Maxime Villard wrote: >> Log Message: >> Minor changes, reported by the LGTM bot. > > Would be nice if the commit message was "address some integer overflows" >

Re: CVS commit: src/sys/kern [change in kern_lwp.c]

2019-12-03 Thread Maxime Villard
Le 01/12/2019 à 16:27, Andrew Doran a écrit : Module Name:src Committed By: ad Date: Sun Dec 1 15:27:58 UTC 2019 Modified Files: src/sys/kern: kern_lwp.c Log Message: Fix a longstanding problem with LWP limits. When changing the user's LWP count, we must use the

CVS commit: src/sys/netatalk

2019-11-29 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Nov 29 17:40:16 UTC 2019 Modified Files: src/sys/netatalk: ddp_usrreq.c Log Message: Add sanity check, only sat_len bytes got copied in, the rest is uninitialized. Found by KMSAN. To generate a diff of this commit: cvs rdiff

CVS commit: src/sys/netatalk

2019-11-29 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Nov 29 17:40:16 UTC 2019 Modified Files: src/sys/netatalk: ddp_usrreq.c Log Message: Add sanity check, only sat_len bytes got copied in, the rest is uninitialized. Found by KMSAN. To generate a diff of this commit: cvs rdiff

CVS commit: src/sys/dev

2019-11-28 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Nov 28 17:09:10 UTC 2019 Modified Files: src/sys/dev/pci: if_et.c if_msk.c if_sk.c mpii.c src/sys/dev/pcmcia: if_xi.c src/sys/dev/usb: if_atu.c if_urtw.c if_zyd.c Log Message: localify To generate a diff of

CVS commit: src/sys/dev

2019-11-28 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Nov 28 17:09:10 UTC 2019 Modified Files: src/sys/dev/pci: if_et.c if_msk.c if_sk.c mpii.c src/sys/dev/pcmcia: if_xi.c src/sys/dev/usb: if_atu.c if_urtw.c if_zyd.c Log Message: localify To generate a diff of

CVS commit: src/sys

2019-11-27 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Nov 27 19:21:37 UTC 2019 Modified Files: src/sys/arch/x86/pci: if_vmx.c src/sys/dev/pci: mfii.c Log Message: localify To generate a diff of this commit: cvs rdiff -u -r1.51 -r1.52 src/sys/arch/x86/pci/if_vmx.c cvs

CVS commit: src/sys

2019-11-27 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Nov 27 19:21:37 UTC 2019 Modified Files: src/sys/arch/x86/pci: if_vmx.c src/sys/dev/pci: mfii.c Log Message: localify To generate a diff of this commit: cvs rdiff -u -r1.51 -r1.52 src/sys/arch/x86/pci/if_vmx.c cvs

CVS commit: src/sys/arch/x86

2019-11-26 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Nov 27 06:24:33 UTC 2019 Modified Files: src/sys/arch/x86/include: cpu.h fpu.h src/sys/arch/x86/x86: cpu.c fpu.c Log Message: Add a small API for in-kernel FPU operations. fpu_kern_enter(); /* do FPU

CVS commit: src/sys/arch/x86

2019-11-26 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Nov 27 06:24:33 UTC 2019 Modified Files: src/sys/arch/x86/include: cpu.h fpu.h src/sys/arch/x86/x86: cpu.c fpu.c Log Message: Add a small API for in-kernel FPU operations. fpu_kern_enter(); /* do FPU

CVS commit: src/sys

2019-11-22 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Nov 22 14:28:46 UTC 2019 Modified Files: src/sys/kern: subr_msan.c src/sys/lib/libkern: libkern.h Log Message: Ah, strcat/strchr/strrchr are ASM functions, so instrument them. To generate a diff of this commit: cvs

CVS commit: src/sys

2019-11-22 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Nov 22 14:28:46 UTC 2019 Modified Files: src/sys/kern: subr_msan.c src/sys/lib/libkern: libkern.h Log Message: Ah, strcat/strchr/strrchr are ASM functions, so instrument them. To generate a diff of this commit: cvs

CVS commit: src/tests/lib/libnvmm

2019-11-22 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Nov 22 10:26:32 UTC 2019 Modified Files: src/tests/lib/libnvmm: h_mem_assist.c Log Message: Several improvements. In particular, reduce CS.limit, because Intel CPUs perform strict sanity checks, and the previous (too high)

CVS commit: src/tests/lib/libnvmm

2019-11-22 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Nov 22 10:26:32 UTC 2019 Modified Files: src/tests/lib/libnvmm: h_mem_assist.c Log Message: Several improvements. In particular, reduce CS.limit, because Intel CPUs perform strict sanity checks, and the previous (too high)

CVS commit: src/sys/dev/nvmm/x86

2019-11-20 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Nov 20 10:26:56 UTC 2019 Modified Files: src/sys/dev/nvmm/x86: nvmm_x86_svm.c nvmm_x86_vmx.c Log Message: Hide XSAVES-specific stuff and the masked extended states. To generate a diff of this commit: cvs rdiff -u -r1.53

CVS commit: src/sys/dev/nvmm/x86

2019-11-20 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Nov 20 10:26:56 UTC 2019 Modified Files: src/sys/dev/nvmm/x86: nvmm_x86_svm.c nvmm_x86_vmx.c Log Message: Hide XSAVES-specific stuff and the masked extended states. To generate a diff of this commit: cvs rdiff -u -r1.53

CVS commit: src/sys/arch/amd64

2019-11-17 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Nov 17 14:07:00 UTC 2019 Modified Files: src/sys/arch/amd64/amd64: vector.S src/sys/arch/amd64/include: frameasm.h Log Message: Disable KCOV - by raising the interrupt level - in the TLB IPI handler, because this is

CVS commit: src/sys/arch/amd64

2019-11-17 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Nov 17 14:07:00 UTC 2019 Modified Files: src/sys/arch/amd64/amd64: vector.S src/sys/arch/amd64/include: frameasm.h Log Message: Disable KCOV - by raising the interrupt level - in the TLB IPI handler, because this is

CVS commit: src/sys/dev/usb

2019-11-17 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Nov 17 11:28:48 UTC 2019 Modified Files: src/sys/dev/usb: vhci.c Log Message: Not a bug strictly speaking, but compute the address only after the length checks, for clarity and to appease kUBSan. To generate a diff of this

CVS commit: src/sys/dev/usb

2019-11-17 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Nov 17 11:28:48 UTC 2019 Modified Files: src/sys/dev/usb: vhci.c Log Message: Not a bug strictly speaking, but compute the address only after the length checks, for clarity and to appease kUBSan. To generate a diff of this

Re: CVS commit: src [llvm]

2019-11-17 Thread Maxime Villard
Le 16/11/2019 à 23:01, Joerg Sonnenberger a écrit : On Tue, Nov 12, 2019 at 11:39:09AM +0100, Maxime Villard wrote: Le 11/11/2019 à 23:45, Joerg Sonnenberger a écrit : Module Name:src Committed By: joerg Date: Mon Nov 11 22:45:32 UTC 2019 [...] Log Message: Update LLVM

CVS commit: src/sys/dev/nvmm/x86

2019-11-16 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Nov 16 17:53:46 UTC 2019 Modified Files: src/sys/dev/nvmm/x86: nvmm_x86.c Log Message: Don't report MWAITX by default. To generate a diff of this commit: cvs rdiff -u -r1.7 -r1.8 src/sys/dev/nvmm/x86/nvmm_x86.c Please note

CVS commit: src/sys/dev/nvmm/x86

2019-11-16 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Nov 16 17:53:46 UTC 2019 Modified Files: src/sys/dev/nvmm/x86: nvmm_x86.c Log Message: Don't report MWAITX by default. To generate a diff of this commit: cvs rdiff -u -r1.7 -r1.8 src/sys/dev/nvmm/x86/nvmm_x86.c Please note

CVS commit: src/sys/arch/x86/x86

2019-11-16 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Nov 16 10:19:29 UTC 2019 Modified Files: src/sys/arch/x86/x86: pmap.c Log Message: Add a NULL check on the structure pointer, not to retrieve its first field if it is NULL. The previous code was not buggy strictly speaking.

CVS commit: src/sys/arch/x86/x86

2019-11-16 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Nov 16 10:19:29 UTC 2019 Modified Files: src/sys/arch/x86/x86: pmap.c Log Message: Add a NULL check on the structure pointer, not to retrieve its first field if it is NULL. The previous code was not buggy strictly speaking.

CVS commit: src/sys/netinet

2019-11-16 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Nov 16 10:15:10 UTC 2019 Modified Files: src/sys/netinet: tcp_input.c Log Message: Call rtcache_unref() only when the checks succeed, instead of relying on another NULL check in rtcache_unref(). Because, in order to resolve

CVS commit: src/sys/netinet

2019-11-16 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Nov 16 10:15:10 UTC 2019 Modified Files: src/sys/netinet: tcp_input.c Log Message: Call rtcache_unref() only when the checks succeed, instead of relying on another NULL check in rtcache_unref(). Because, in order to resolve

CVS commit: src/sys/kern

2019-11-16 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Nov 16 10:07:53 UTC 2019 Modified Files: src/sys/kern: vfs_mount.c Log Message: NULL-check the structure pointer, not the address of its first field. Also add KASSERT. For clarity, and to appease kUBSan. To generate a diff of

CVS commit: src/sys/kern

2019-11-16 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Nov 16 10:07:53 UTC 2019 Modified Files: src/sys/kern: vfs_mount.c Log Message: NULL-check the structure pointer, not the address of its first field. Also add KASSERT. For clarity, and to appease kUBSan. To generate a diff of

CVS commit: src/sys/kern

2019-11-16 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Nov 16 10:05:44 UTC 2019 Modified Files: src/sys/kern: vfs_subr.c Log Message: Add a NULL check on the structure (same logic as my previous change in this file). For clarity, and to appease kUBSan. To generate a diff of this

CVS commit: src/sys/kern

2019-11-16 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Nov 16 10:05:44 UTC 2019 Modified Files: src/sys/kern: vfs_subr.c Log Message: Add a NULL check on the structure (same logic as my previous change in this file). For clarity, and to appease kUBSan. To generate a diff of this

CVS commit: src/sys/kern

2019-11-15 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Nov 15 15:51:57 UTC 2019 Modified Files: src/sys/kern: vfs_subr.c Log Message: NULL-check the structure pointer, not the address of its first field. This is clearer and also appeases syzbot. Reported-by:

CVS commit: src/sys/kern

2019-11-15 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Nov 15 15:51:57 UTC 2019 Modified Files: src/sys/kern: vfs_subr.c Log Message: NULL-check the structure pointer, not the address of its first field. This is clearer and also appeases syzbot. Reported-by:

CVS commit: src/sys

2019-11-15 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Nov 15 12:18:46 UTC 2019 Modified Files: src/sys/kern: subr_msan.c src/sys/sys: systm.h Log Message: Instrument ufetch/ustore in kMSan, these were the last remaining functions. To generate a diff of this commit: cvs

CVS commit: src/sys

2019-11-15 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Nov 15 12:18:46 UTC 2019 Modified Files: src/sys/kern: subr_msan.c src/sys/sys: systm.h Log Message: Instrument ufetch/ustore in kMSan, these were the last remaining functions. To generate a diff of this commit: cvs

CVS commit: src/sys/arch/amd64/amd64

2019-11-15 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Nov 15 09:50:01 UTC 2019 Modified Files: src/sys/arch/amd64/amd64: cpu_in_cksum.S Log Message: Since cpu_in_cksum.S can be built outside of the kernel, add an ugly #ifdef _KERNEL for kMSan. To generate a diff of this commit:

CVS commit: src/sys/arch/amd64/amd64

2019-11-15 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Nov 15 09:50:01 UTC 2019 Modified Files: src/sys/arch/amd64/amd64: cpu_in_cksum.S Log Message: Since cpu_in_cksum.S can be built outside of the kernel, add an ugly #ifdef _KERNEL for kMSan. To generate a diff of this commit:

CVS commit: src

2019-11-15 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Nov 15 09:44:44 UTC 2019 Modified Files: src/share/mk: bsd.sys.mk src/sys/kern: subr_kcov.c Log Message: Make kMSan compatible with KCOV. With kMSan we are forced to stay with the fsanitize flag on subr_kcov.c, which

CVS commit: src

2019-11-15 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Nov 15 09:44:44 UTC 2019 Modified Files: src/share/mk: bsd.sys.mk src/sys/kern: subr_kcov.c Log Message: Make kMSan compatible with KCOV. With kMSan we are forced to stay with the fsanitize flag on subr_kcov.c, which

CVS commit: src/sys/arch

2019-11-15 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Nov 15 09:03:26 UTC 2019 Modified Files: src/sys/arch/amd64/amd64: cpufunc.S src/sys/arch/i386/i386: cpufunc.S src/sys/arch/x86/include: pio.h Log Message: Remove the ins* and outs* functions. Not

CVS commit: src/sys/arch

2019-11-15 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Nov 15 09:03:26 UTC 2019 Modified Files: src/sys/arch/amd64/amd64: cpufunc.S src/sys/arch/i386/i386: cpufunc.S src/sys/arch/x86/include: pio.h Log Message: Remove the ins* and outs* functions. Not

CVS commit: src/sys

2019-11-15 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Nov 15 08:11:37 UTC 2019 Modified Files: src/sys/kern: subr_csan.c src/sys/sys: systm.h Log Message: Instrument copyout() in kCSan, for parity with kMSan. To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.5

CVS commit: src/sys

2019-11-15 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Nov 15 08:11:37 UTC 2019 Modified Files: src/sys/kern: subr_csan.c src/sys/sys: systm.h Log Message: Instrument copyout() in kCSan, for parity with kMSan. To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.5

CVS commit: src/sys

2019-11-14 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Nov 14 17:09:23 UTC 2019 Modified Files: src/sys/arch/aarch64/aarch64: aarch64_machdep.c pmap.c src/sys/arch/amd64/amd64: machdep.c src/sys/arch/x86/x86: pmap.c src/sys/sys: asan.h Log Message: Mark

CVS commit: src/sys

2019-11-14 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Nov 14 17:09:23 UTC 2019 Modified Files: src/sys/arch/aarch64/aarch64: aarch64_machdep.c pmap.c src/sys/arch/amd64/amd64: machdep.c src/sys/arch/x86/x86: pmap.c src/sys/sys: asan.h Log Message: Mark

CVS commit: src/sys/kern

2019-11-14 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Nov 14 16:56:13 UTC 2019 Modified Files: src/sys/kern: subr_csan.c Log Message: Don't include "opt_kcsan.h" since there's already included. To generate a diff of this commit: cvs rdiff -u -r1.3 -r1.4 src/sys/kern/subr_csan.c

CVS commit: src/sys/kern

2019-11-14 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Nov 14 16:56:13 UTC 2019 Modified Files: src/sys/kern: subr_csan.c Log Message: Don't include "opt_kcsan.h" since there's already included. To generate a diff of this commit: cvs rdiff -u -r1.3 -r1.4 src/sys/kern/subr_csan.c

CVS commit: src/sys

2019-11-14 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Nov 14 16:48:51 UTC 2019 Modified Files: src/sys/arch/aarch64/aarch64: aarch64_machdep.c pmap.c src/sys/arch/amd64/amd64: machdep.c src/sys/uvm: uvm_glue.c Log Message: Don't include "opt_kasan.h" when there's

CVS commit: src/doc

2019-11-14 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Nov 14 16:27:26 UTC 2019 Modified Files: src/doc: CHANGES Log Message: Note kMSan. To generate a diff of this commit: cvs rdiff -u -r1.2613 -r1.2614 src/doc/CHANGES Please note that diffs are not public domain; they are

CVS commit: src/doc

2019-11-14 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Nov 14 16:27:26 UTC 2019 Modified Files: src/doc: CHANGES Log Message: Note kMSan. To generate a diff of this commit: cvs rdiff -u -r1.2613 -r1.2614 src/doc/CHANGES Please note that diffs are not public domain; they are

  1   2   3   4   5   6   7   8   >