CVS commit: src/sys/dev/filemon

2019-10-30 Thread Simon J. Gerraty
Module Name:src Committed By: sjg Date: Wed Oct 30 18:35:06 UTC 2019 Modified Files: src/sys/dev/filemon: filemon.c Log Message: filemon_ioctl: check fd for write permission Reviewed by: christos Reported by: ivansprundel To generate a diff of this commit: cvs rdiff -u

CVS commit: src/sys/dev/filemon

2019-10-30 Thread Simon J. Gerraty
Module Name:src Committed By: sjg Date: Wed Oct 30 18:35:06 UTC 2019 Modified Files: src/sys/dev/filemon: filemon.c Log Message: filemon_ioctl: check fd for write permission Reviewed by: christos Reported by: ivansprundel To generate a diff of this commit: cvs rdiff -u

CVS commit: src/usr.bin/make

2019-09-26 Thread Simon J. Gerraty
Module Name:src Committed By: sjg Date: Thu Sep 26 21:09:55 UTC 2019 Modified Files: src/usr.bin/make: parse.c Log Message: Do not assume safe to pass NULL to realpath(3). PR: 54574 Reviewed by: buhrow To generate a diff of this commit: cvs rdiff -u -r1.232 -r1.233

CVS commit: src/usr.bin/make

2019-09-26 Thread Simon J. Gerraty
Module Name:src Committed By: sjg Date: Thu Sep 26 21:09:55 UTC 2019 Modified Files: src/usr.bin/make: parse.c Log Message: Do not assume safe to pass NULL to realpath(3). PR: 54574 Reviewed by: buhrow To generate a diff of this commit: cvs rdiff -u -r1.232 -r1.233

Re: CVS commit: src/usr.bin/make

2018-05-13 Thread Simon J. Gerraty
J. Hannken-Illjes wrote: > After this commit parallel builds take much longer. Building > amd64 release with -j16 for example goes from 45 to 380 minutes. Interesting. Removing the sleep would help there - the busy waiting issue isn't new anyway.

Re: CVS commit: src/usr.bin/make

2017-04-21 Thread Simon J. Gerraty
Simon J. Gerraty <s...@juniper.net> wrote: > <co...@sdf.org> wrote: > > > On Tue, Apr 11, 2017 at 05:30:13PM +, Simon J. Gerraty wrote: > > > Log Message: > > > Str_Match: allow [^a-z] to behave as expected. > > > > % env A=NetBSD-7-

Re: CVS commit: src/usr.bin/make

2017-04-21 Thread Simon J. Gerraty
<co...@sdf.org> wrote: > On Tue, Apr 11, 2017 at 05:30:13PM +0000, Simon J. Gerraty wrote: > > Log Message: > > Str_Match: allow [^a-z] to behave as expected. > > % env A=NetBSD-7-x86_64 make -V '${A:MNetBSD-[^0-1]-i386}' > NetBSD-7-x86_64 Well that's interesting - thanks...

Re: CVS commit: src/usr.bin/make

2016-06-04 Thread Simon J. Gerraty
Joerg Sonnenberger wrote: > > This improves the worst case performance (eg examining libc with > > nothing to do) by a factor of 4. > > ...except now build.sh on !NetBSD fails immediately due to missing > strlcpy. Should be fixed... Don't know if you want to get carried away with

Re: CVS commit: src/usr.bin/make

2016-06-04 Thread Simon J. Gerraty
Joerg Sonnenberger wrote: > > This improves the worst case performance (eg examining libc with > > nothing to do) by a factor of 4. > > ...except now build.sh on !NetBSD fails immediately due to missing > strlcpy. Gah, bmake provides strlcpy... sorry about that.

Re: CVS commit: src/usr.bin/make

2016-01-16 Thread Simon J. Gerraty
Joerg Sonnenberger wrote: > I suspect this change broke editors/xemacs-current, which is now failing > with: > > make[1]: make[1]: don't know how to make insert-data-in-exec. Stop I'm guessing you are talking about a makefile that comes with emacs? I don't see anything

Re: CVS commit: src/usr.bin/make

2015-12-01 Thread Simon J. Gerraty
Joerg Sonnenberger wrote: > > Log Message: > > Avoid calling brk_string() and hence Var_Export1() on > > empty strings. > > I'm not sure which change, but now I get fallout in the clang builds > from constructs like: Shouldn't this one since only affects exporting of

Re: CVS commit: src/usr.bin/make

2015-10-20 Thread Simon J. Gerraty
Thanks - fixed. > /work/src/usr.bin/make/var.c:2772:7: error: variable 'emsg' is used > uninitialized whenever 'if' condition is false > [-Werror,-Wsometimes-uninitialized] > if (wantit) > /work/src/usr.bin/make/var.c:2777:7: note: uninitialized use occurs here > if (emsg)

Re: CVS commit: src/lib/csu

2011-02-06 Thread Simon J. Gerraty
Making .PARSEDIR always absolute should fix this problem, but in the general case requires realpath(). Yes. Though it is worth noting that setting .PARSEDIR to .CURDIR when the makefile path contains no '/' may be sufficient for correct operation. However, I'm guessing that .PARSEDIR may not

Re: CVS commit: src/lib/csu

2011-01-31 Thread Simon J. Gerraty
I can comment out the MAKEOBJDIR assignment in nbmake-amd64 and it still works fine. BSDOBJDIR doesn't seem to do anything. BUILDID breaks this. I have no idea why those variables even exist, the code in bsd.own.mk is messy at best and I don't think it justifies the changes to the Makefiles.

Re: CVS commit: src/usr.bin/make

2010-04-22 Thread Simon J. Gerraty
On Thu, 22 Apr 2010 19:51:07 +, Tom Spindler writes: Modified Files: src/usr.bin/make: job.c main.c make.h Log Message: Just because $TMPDIR is set does not mean it is valid. Add a central function for creating temp files so we have one place to audit. This breaks build.sh when

Re: CVS commit: src/usr.bin/make

2010-04-22 Thread Simon J. Gerraty
Dh already commited the exact same change I just tried to. On Thu, 22 Apr 2010 19:51:07 +, Tom Spindler writes: Modified Files: src/usr.bin/make: job.c main.c make.h Log Message: Just because $TMPDIR is set does not mean it is valid. Add a central function for creating temp files

Re: CVS commit: src/usr.bin/make

2010-04-22 Thread Simon J. Gerraty
Thanks for fixing that. On Thu, 22 Apr 2010 22:00:26 +, David Holland writes: On Thu, Apr 22, 2010 at 02:11:31PM -0700, Simon J. Gerraty wrote: Dh already commited the exact same change I just tried to. sorry, didn't look here first. :-/

Re: CVS commit: src/usr.bin/make

2009-11-22 Thread Simon J. Gerraty
Yes, cvs log has been fixed. Log Message: PR: make.unexport Reviewed by: Hmm, this is a little unusual commit message. Bernd