CVS commit: src/sys/dev/audio

2021-10-10 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Oct 10 11:21:05 UTC 2021 Modified Files: src/sys/dev/audio: audio.c Log Message: audio(9): Issue pserialize_perform outside sc_lock in audiodetach. Breaks another deadlock between sc_lock and high-priority xcalls at

CVS commit: src/sys/dev/audio

2021-10-10 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Oct 10 11:21:05 UTC 2021 Modified Files: src/sys/dev/audio: audio.c Log Message: audio(9): Issue pserialize_perform outside sc_lock in audiodetach. Breaks another deadlock between sc_lock and high-priority xcalls at

CVS commit: src

2021-10-10 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Oct 10 11:20:47 UTC 2021 Modified Files: src/share/man/man9: pserialize.9 src/sys/kern: subr_pserialize.c Log Message: pserialize(9): Lift rule that pserialize_perform be serialized. There may have been a

CVS commit: src

2021-10-10 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Oct 10 11:20:47 UTC 2021 Modified Files: src/share/man/man9: pserialize.9 src/sys/kern: subr_pserialize.c Log Message: pserialize(9): Lift rule that pserialize_perform be serialized. There may have been a

CVS commit: src/sys/dev/audio

2021-10-10 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Oct 10 11:20:29 UTC 2021 Modified Files: src/sys/dev/audio: audio.c Log Message: audio(9): Call hw_if->getdev without sc_lock. Holding sc_lock is not necessary -- I reviewed all ~70 cases in-tree, and none of them rely on

CVS commit: src/sys/dev/audio

2021-10-10 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Oct 10 11:20:29 UTC 2021 Modified Files: src/sys/dev/audio: audio.c Log Message: audio(9): Call hw_if->getdev without sc_lock. Holding sc_lock is not necessary -- I reviewed all ~70 cases in-tree, and none of them rely on

Re: CVS commit: src/sys

2021-10-06 Thread Taylor R Campbell
> Date: Wed, 6 Oct 2021 17:44:22 +0200 > From: Reinoud Zandijk > > Sorry for my ignorance but I thought that the ksyms list was static? ie > read-only? Or is this change to support kernel modules symbols too and thus > need rw access control? The main kernel's symbols don't change, but the

Re: CVS commit: src/sys

2021-09-15 Thread Taylor R Campbell
> Date: Wed, 15 Sep 2021 19:58:20 +0900 > From: Rin Okuyama > > login: [ 95.5000696] panic: kernel diagnostic assertion "slock != NULL" > failed: file "../../../../uvm/uvm_pdaemon.c", line 398 pg 0x8c66bd88 uobj > 0x8fa7e400, NULL lock > [...] > > It seems that I can avoid this panic if > >

CVS commit: src/sys

2021-09-11 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Sep 11 10:09:55 UTC 2021 Modified Files: src/sys/arch/sparc64/sparc64: machdep.c src/sys/kern: kern_ksyms.c subr_csan.c subr_msan.c src/sys/sys: ksyms.h Log Message: ksyms: Use pserialize(9) for kernel

CVS commit: src/sys

2021-09-11 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Sep 11 10:09:55 UTC 2021 Modified Files: src/sys/arch/sparc64/sparc64: machdep.c src/sys/kern: kern_ksyms.c subr_csan.c subr_msan.c src/sys/sys: ksyms.h Log Message: ksyms: Use pserialize(9) for kernel

CVS commit: src/sys/kern

2021-09-11 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Sep 11 10:09:31 UTC 2021 Modified Files: src/sys/kern: kern_ksyms.c Log Message: ksyms(4): Take a complete snapshot on each open. - Snapshots are stored in pageable anonymous uvm objects. - Snapshots are reference-counted

CVS commit: src/sys/kern

2021-09-11 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Sep 11 10:09:31 UTC 2021 Modified Files: src/sys/kern: kern_ksyms.c Log Message: ksyms(4): Take a complete snapshot on each open. - Snapshots are stored in pageable anonymous uvm objects. - Snapshots are reference-counted

CVS commit: src/sys/kern

2021-09-11 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Sep 11 10:09:14 UTC 2021 Modified Files: src/sys/kern: sys_descrip.c vfs_vnops.c Log Message: sys/kern: Avoid fp->f_offset without the object (here, vnode) lock. To generate a diff of this commit: cvs rdiff -u -r1.37

CVS commit: src/sys/kern

2021-09-11 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Sep 11 10:09:14 UTC 2021 Modified Files: src/sys/kern: sys_descrip.c vfs_vnops.c Log Message: sys/kern: Avoid fp->f_offset without the object (here, vnode) lock. To generate a diff of this commit: cvs rdiff -u -r1.37

CVS commit: src/sys

2021-09-11 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Sep 11 10:08:56 UTC 2021 Modified Files: src/sys/compat/netbsd32: netbsd32_fs.c src/sys/kern: sys_generic.c vfs_syscalls.c vfs_vnops.c src/sys/sys: file.h Log Message: sys/kern: Allow custom fileops to

CVS commit: src/sys

2021-09-11 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Sep 11 10:08:56 UTC 2021 Modified Files: src/sys/compat/netbsd32: netbsd32_fs.c src/sys/kern: sys_generic.c vfs_syscalls.c vfs_vnops.c src/sys/sys: file.h Log Message: sys/kern: Allow custom fileops to

CVS commit: src/sys/dev

2021-09-09 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Thu Sep 9 23:26:37 UTC 2021 Modified Files: src/sys/dev/isa: mcd.c src/sys/dev/pci: if_iwi.c src/sys/dev/raidframe: rf_netbsdkintf.c src/sys/dev/scsipi: ses.c Log Message: sys/dev: Memset zero before

CVS commit: src/sys/dev

2021-09-09 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Thu Sep 9 23:26:37 UTC 2021 Modified Files: src/sys/dev/isa: mcd.c src/sys/dev/pci: if_iwi.c src/sys/dev/raidframe: rf_netbsdkintf.c src/sys/dev/scsipi: ses.c Log Message: sys/dev: Memset zero before

CVS commit: src/sys/kern

2021-09-07 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Sep 7 16:56:25 UTC 2021 Modified Files: src/sys/kern: kern_ksyms.c Log Message: Revert "ksyms(4): Simply block unload until last /dev/ksyms close." This appears to break t_execsnoop -- presumably something goes wrong

CVS commit: src/sys/kern

2021-09-07 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Sep 7 16:56:25 UTC 2021 Modified Files: src/sys/kern: kern_ksyms.c Log Message: Revert "ksyms(4): Simply block unload until last /dev/ksyms close." This appears to break t_execsnoop -- presumably something goes wrong

CVS commit: src/sys

2021-09-07 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Sep 7 16:56:13 UTC 2021 Modified Files: src/sys/arch/sparc64/sparc64: machdep.c src/sys/kern: kern_ksyms.c subr_csan.c subr_msan.c src/sys/sys: ksyms.h Log Message: Revert "ksyms: Use pserialize(9) for

CVS commit: src/sys

2021-09-07 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Sep 7 16:56:13 UTC 2021 Modified Files: src/sys/arch/sparc64/sparc64: machdep.c src/sys/kern: kern_ksyms.c subr_csan.c subr_msan.c src/sys/sys: ksyms.h Log Message: Revert "ksyms: Use pserialize(9) for

CVS commit: src/sys/compat

2021-09-07 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Sep 7 11:43:05 UTC 2021 Modified Files: src/sys/compat/common: ieee80211_20.c if_media_80.c kern_info_09.c kern_info_43.c kern_resource_43.c kern_sig_13.c kern_sig_43.c kern_time_50.c

CVS commit: src/sys/compat

2021-09-07 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Sep 7 11:43:05 UTC 2021 Modified Files: src/sys/compat/common: ieee80211_20.c if_media_80.c kern_info_09.c kern_info_43.c kern_resource_43.c kern_sig_13.c kern_sig_43.c kern_time_50.c

CVS commit: src/sys/kern

2021-09-07 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Sep 7 11:00:13 UTC 2021 Modified Files: src/sys/kern: kern_crashme.c Log Message: New crashme sysctl to enter ddb directly. To generate a diff of this commit: cvs rdiff -u -r1.3 -r1.4 src/sys/kern/kern_crashme.c Please

CVS commit: src/sys/kern

2021-09-07 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Sep 7 11:00:13 UTC 2021 Modified Files: src/sys/kern: kern_crashme.c Log Message: New crashme sysctl to enter ddb directly. To generate a diff of this commit: cvs rdiff -u -r1.3 -r1.4 src/sys/kern/kern_crashme.c Please

CVS commit: src/sys

2021-09-07 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Sep 7 11:00:02 UTC 2021 Modified Files: src/sys/arch/sparc64/sparc64: machdep.c src/sys/kern: kern_ksyms.c subr_csan.c subr_msan.c src/sys/sys: ksyms.h Log Message: ksyms: Use pserialize(9) for kernel

CVS commit: src/sys

2021-09-07 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Sep 7 11:00:02 UTC 2021 Modified Files: src/sys/arch/sparc64/sparc64: machdep.c src/sys/kern: kern_ksyms.c subr_csan.c subr_msan.c src/sys/sys: ksyms.h Log Message: ksyms: Use pserialize(9) for kernel

CVS commit: src/sys/kern

2021-09-07 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Sep 7 10:59:46 UTC 2021 Modified Files: src/sys/kern: kern_ksyms.c Log Message: ksyms(4): Simply block unload until last /dev/ksyms close. Otherwise, readers may get a garbled snapshot of ksyms (or a crash on an

CVS commit: src/sys/kern

2021-09-07 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Sep 7 10:59:46 UTC 2021 Modified Files: src/sys/kern: kern_ksyms.c Log Message: ksyms(4): Simply block unload until last /dev/ksyms close. Otherwise, readers may get a garbled snapshot of ksyms (or a crash on an

CVS commit: src/sys/dev/usb

2021-09-07 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Sep 7 10:44:18 UTC 2021 Modified Files: src/sys/dev/usb: usb_subr.c usbdi.c usbdivar.h Log Message: usb(4): Fix xfer race between software abort and hardware completion. This fixes a bug in the API contract of

CVS commit: src/sys/dev/usb

2021-09-07 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Sep 7 10:44:18 UTC 2021 Modified Files: src/sys/dev/usb: usb_subr.c usbdi.c usbdivar.h Log Message: usb(4): Fix xfer race between software abort and hardware completion. This fixes a bug in the API contract of

CVS commit: src/sys/dev/usb

2021-09-07 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Sep 7 10:44:05 UTC 2021 Modified Files: src/sys/dev/usb: ugen.c Log Message: ugen(4): Keep fields null when not allocated; kassert on close. This avoids silent leaks in DIAGNOSTIC kernels. To generate a diff of this

CVS commit: src/sys/dev/usb

2021-09-07 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Sep 7 10:44:05 UTC 2021 Modified Files: src/sys/dev/usb: ugen.c Log Message: ugen(4): Keep fields null when not allocated; kassert on close. This avoids silent leaks in DIAGNOSTIC kernels. To generate a diff of this

CVS commit: src/sys/dev/usb

2021-09-07 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Sep 7 10:43:51 UTC 2021 Modified Files: src/sys/dev/usb: ugen.c Log Message: ugen(4): Use cv_wait loop for draining reference count on detach. - Should be no need to use cv_timedwait because all users have now been

CVS commit: src/sys/dev/usb

2021-09-07 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Sep 7 10:43:51 UTC 2021 Modified Files: src/sys/dev/usb: ugen.c Log Message: ugen(4): Use cv_wait loop for draining reference count on detach. - Should be no need to use cv_timedwait because all users have now been

CVS commit: src/sys/dev/usb

2021-09-07 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Sep 7 10:43:34 UTC 2021 Modified Files: src/sys/dev/usb: ugen.c Log Message: ugen(4): Use cv_broadcast to wake all I/O operations on detach. Nothing prevents two concurrent reads or two concurrent writes on any

CVS commit: src/sys/dev/usb

2021-09-07 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Sep 7 10:43:34 UTC 2021 Modified Files: src/sys/dev/usb: ugen.c Log Message: ugen(4): Use cv_broadcast to wake all I/O operations on detach. Nothing prevents two concurrent reads or two concurrent writes on any

CVS commit: src/sys/dev/usb

2021-09-07 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Sep 7 10:43:21 UTC 2021 Modified Files: src/sys/dev/usb: ugen.c Log Message: ugen(4): Issue explicit wakeup on detach for OUT endpoints too. Writers can be blocked in cv_timedwait_sig too. While here, fix comment:

CVS commit: src/sys/dev/usb

2021-09-07 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Sep 7 10:43:21 UTC 2021 Modified Files: src/sys/dev/usb: ugen.c Log Message: ugen(4): Issue explicit wakeup on detach for OUT endpoints too. Writers can be blocked in cv_timedwait_sig too. While here, fix comment:

CVS commit: src/sys/dev/usb

2021-09-07 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Sep 7 10:43:11 UTC 2021 Modified Files: src/sys/dev/usb: ugen.c Log Message: ugen(4): Ensure we close pipes on detach. Calling vdevgone has the effect of VOP_REVOKE -> spec_node_revoke -> VOP_CLOSE -> spec_close ->

CVS commit: src/sys/dev/usb

2021-09-07 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Sep 7 10:43:11 UTC 2021 Modified Files: src/sys/dev/usb: ugen.c Log Message: ugen(4): Ensure we close pipes on detach. Calling vdevgone has the effect of VOP_REVOKE -> spec_node_revoke -> VOP_CLOSE -> spec_close ->

CVS commit: src/sys/dev/usb

2021-09-07 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Sep 7 10:42:59 UTC 2021 Modified Files: src/sys/dev/usb: ugen.c Log Message: ugen(4): Refuse non-forced detach with EBUSY if endpoints are open. Sprinkle some comments. To generate a diff of this commit: cvs rdiff -u

CVS commit: src/sys/dev/usb

2021-09-07 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Sep 7 10:42:59 UTC 2021 Modified Files: src/sys/dev/usb: ugen.c Log Message: ugen(4): Refuse non-forced detach with EBUSY if endpoints are open. Sprinkle some comments. To generate a diff of this commit: cvs rdiff -u

CVS commit: src/sys/dev/usb

2021-09-07 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Sep 7 10:42:48 UTC 2021 Modified Files: src/sys/dev/usb: ugen.c Log Message: ugen(4): Prevent ugenopen while ugen_set_config is in progress. (except on the control endpoint) Although we hold the kernel lock (which we

CVS commit: src/sys/dev/usb

2021-09-07 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Sep 7 10:42:48 UTC 2021 Modified Files: src/sys/dev/usb: ugen.c Log Message: ugen(4): Prevent ugenopen while ugen_set_config is in progress. (except on the control endpoint) Although we hold the kernel lock (which we

CVS commit: src/sys/dev/usb

2021-09-07 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Sep 7 10:42:34 UTC 2021 Modified Files: src/sys/dev/usb: ugen.c Log Message: ugen(4): Fix race of ugenopen against itself. Even though we have the kernel lock held, a sleep during kmem_alloc or usbd_open_pipe could allow

CVS commit: src/sys/dev/usb

2021-09-07 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Sep 7 10:42:34 UTC 2021 Modified Files: src/sys/dev/usb: ugen.c Log Message: ugen(4): Fix race of ugenopen against itself. Even though we have the kernel lock held, a sleep during kmem_alloc or usbd_open_pipe could allow

CVS commit: src/sys/dev/usb

2021-09-07 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Sep 7 10:42:22 UTC 2021 Modified Files: src/sys/dev/usb: ugen.c Log Message: ugen(4): Sprinkle KERNEL_LOCKED_P assertions around sc_is_open. To generate a diff of this commit: cvs rdiff -u -r1.158 -r1.159

CVS commit: src/sys/dev/usb

2021-09-07 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Sep 7 10:42:22 UTC 2021 Modified Files: src/sys/dev/usb: ugen.c Log Message: ugen(4): Sprinkle KERNEL_LOCKED_P assertions around sc_is_open. To generate a diff of this commit: cvs rdiff -u -r1.158 -r1.159

Re: CVS commit: src/crypto/external/bsd/openssh/dist

2021-09-06 Thread Taylor R Campbell
> Date: Mon, 6 Sep 2021 22:32:22 +0900 > From: Rin Okuyama > > On 2021/09/06 22:11, Ryo ONODERA wrote: > > Module Name:src > > Committed By: ryoon > > Date: Mon Sep 6 13:11:34 UTC 2021 > > > > Modified Files: > > src/crypto/external/bsd/openssh/dist: dns.c > >

CVS commit: src/sys/altq

2021-08-30 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Aug 30 08:40:32 UTC 2021 Modified Files: src/sys/altq: altq_hfsc.c altq_priq.c Log Message: sys/altq: Memset zero before copyout. Just in case of uninitialized padding which would lead to kernel stack disclosure. If the

CVS commit: src/sys/altq

2021-08-30 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Aug 30 08:40:32 UTC 2021 Modified Files: src/sys/altq: altq_hfsc.c altq_priq.c Log Message: sys/altq: Memset zero before copyout. Just in case of uninitialized padding which would lead to kernel stack disclosure. If the

CVS commit: src/sys/compat/sys

2021-08-30 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Aug 30 08:40:00 UTC 2021 Modified Files: src/sys/compat/sys: mount.h Log Message: sys/compat: Don't clobber f_oflags with zero. Mistake was introduced in previous refactoring. To generate a diff of this commit: cvs

CVS commit: src/sys/compat/sys

2021-08-30 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Aug 30 08:40:00 UTC 2021 Modified Files: src/sys/compat/sys: mount.h Log Message: sys/compat: Don't clobber f_oflags with zero. Mistake was introduced in previous refactoring. To generate a diff of this commit: cvs

CVS commit: src/sys/compat/netbsd32

2021-08-30 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Aug 30 08:39:24 UTC 2021 Modified Files: src/sys/compat/netbsd32: netbsd32_nfssvc.c Log Message: compat_netbsd32: Copy out 32-bit version in nfssvc32_nsd_out. To generate a diff of this commit: cvs rdiff -u -r1.6 -r1.7

CVS commit: src/sys/compat/netbsd32

2021-08-30 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Aug 30 08:39:24 UTC 2021 Modified Files: src/sys/compat/netbsd32: netbsd32_nfssvc.c Log Message: compat_netbsd32: Copy out 32-bit version in nfssvc32_nsd_out. To generate a diff of this commit: cvs rdiff -u -r1.6 -r1.7

CVS commit: src/external/cddl/osnet/dist/lib/libzfs/common

2021-08-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Aug 28 10:47:46 UTC 2021 Modified Files: src/external/cddl/osnet/dist/lib/libzfs/common: libzfs_import.c Log Message: libzfs: Zero DIOCLWEDGES input before ioctl. Otherwise we ask the kernel to write over whatever random

CVS commit: src/external/cddl/osnet/dist/lib/libzfs/common

2021-08-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Aug 28 10:47:46 UTC 2021 Modified Files: src/external/cddl/osnet/dist/lib/libzfs/common: libzfs_import.c Log Message: libzfs: Zero DIOCLWEDGES input before ioctl. Otherwise we ask the kernel to write over whatever random

Re: CVS commit: src/sys/kern

2021-08-17 Thread Taylor R Campbell
> Module Name:src > Committed By: mlelstv > Date: Sun Jul 18 06:57:28 UTC 2021 > > Modified Files: > src/sys/kern: kern_ksyms.c > > Log Message: > skip symbol tables that were unloaded again to avoid EFAULT when reading > ksyms. > > also restore TAILQ_FOREACH idiom.

Re: CVS commit: src/sys/dev/pad

2021-06-16 Thread Taylor R Campbell
> Date: Wed, 16 Jun 2021 17:38:26 +0900 > From: Rin Okuyama > > KASSERT added to pad_attach() by this commit fires on macppc with mixerctl(1): > [...] panic: kernel diagnostic assertion "KERNEL_LOCKED_P()" failed: file > "/usr/src/sys/dev/pad/pad.c", line 214 Can you share `ident netbsd | grep

Re: CVS commit: src/sys/kern

2021-06-02 Thread Taylor R Campbell
> Date: Wed, 2 Jun 2021 17:33:39 +0900 > From: Rin Okuyama > > On 2021/06/02 6:11, Taylor R Campbell wrote: > > - KASSERT(filepos <= sizeof(struct ksyms_hdr) + > > + KASSERT(filepos == sizeof(struct ksyms_hdr) + > > ksyms_hdr.kh_shdr[SYMTAB].sh_siz

Re: CVS commit: src/sys

2021-04-30 Thread Taylor R Campbell
> Module Name:src > Committed By: thorpej > Date: Sat Apr 24 23:37:01 UTC 2021 > > Log Message: > Merge thorpej-cfargs branch: > > Simplify and make extensible the config_search() / config_found() / > config_attach() interfaces: rather than having different variants for > which

Re: CVS commit: src/sys/dev/pci

2021-01-23 Thread Taylor R Campbell
> Date: Sat, 23 Jan 2021 22:59:22 - (UTC) > From: chris...@astron.com (Christos Zoulas) > > In article <23974.1611441...@splode.eterna.com.au>, > matthew green wrote: > >this seems dangerous to me. we don't define it on > >some platforms because we can't, so having it faked > >out here

Re: CVS commit: src/share/man/man5

2021-01-15 Thread Taylor R Campbell
> Date: Sat, 16 Jan 2021 14:46:46 +1100 > from: matthew green > > > Log Message: > > Tweak wording for consistency: `if empty or not set', not `if unset'. > > is this correct? > > rc complains if unset or not set (ie, if "$foo" is zero length): > > /etc/rc.d/upsdriver: WARNING: $upsdriver is

Re: CVS commit: src

2020-11-12 Thread Taylor R Campbell
> Date: Thu, 12 Nov 2020 11:21:43 -0800 > From: Jason Thorpe > > > On Nov 12, 2020, at 9:40 AM, nia wrote: > > > > For the record I'm just trying to fix things so that running > > third-party software on NetBSD sucks less. If fewer third-party > > libraries were exposed by the base system this

Re: CVS commit: src

2020-11-10 Thread Taylor R Campbell
> Module Name:src > Committed By: nia > Date: Sun Nov 8 21:56:48 UTC 2020 > > Modified Files: > src/external/bsd/kyua-cli: Makefile.inc > src/external/ibm-public/postfix: Makefile.inc > src/external/public-domain/sqlite: Makefile.inc >

Re: CVS commit: src

2020-09-22 Thread Taylor R Campbell
> Date: Wed, 23 Sep 2020 01:46:14 +0200 > From: Tobias Nygren > > > Modified Files: > > src/include: unistd.h > > src/lib/libc/gen: Makefile.inc > > Removed Files: > > src/lib/libc/gen: getentropy.3 getentropy.c > > > > Log Message: > > remove getentropy bits > > I know it is

Re: CVS commit: src

2020-09-10 Thread Taylor R Campbell
> Module Name:src > Committed By: maxv > Date: Sat Sep 5 07:22:26 UTC 2020 > > nvmm: update copyright headers > > [...] > -.\" Copyright (c) 2018-2020 The NetBSD Foundation, Inc. > +.\" Copyright (c) 2018-2020 Maxime Villard, m00nbsd.net > .\" All rights reserved. > .\" > -.\"

Re: CVS commit: src

2020-08-15 Thread Taylor R Campbell
> Date: Sat, 15 Aug 2020 10:23:02 + > From: nia > > Obviously, I disagree with core's decision, but let's try to be > productive about this. > > I'm happy to have getrandom in NetBSD, it's a good thing. But not with > this behaviour. > > 1) Adopting getrandom for compatibility does not

Re: CVS commit: src/sys/kern

2020-08-02 Thread Taylor R Campbell
> Date: Sun, 2 Aug 2020 17:35:06 +0200 > From: Kamil Rytarowski > > On 02.08.2020 16:44, Taylor R Campbell wrote: > >> Date: Sun, 2 Aug 2020 16:04:15 +0200 > >> From: Kamil Rytarowski > >> > >> On 02.08.2020 15:57, Taylor R Campbell wrote:

Re: CVS commit: src/sys/kern

2020-08-02 Thread Taylor R Campbell
> Date: Sun, 2 Aug 2020 16:04:15 +0200 > From: Kamil Rytarowski > > On 02.08.2020 15:57, Taylor R Campbell wrote: > > But it sounds like the original motivation is that it triggered > > -Wvla...which frankly strikes me as a compiler bug since there's > > obviously n

Re: CVS commit: src/sys/kern

2020-08-02 Thread Taylor R Campbell
> Date: Sun, 2 Aug 2020 10:47:21 +0200 > From: Jarom�r Dole ek > > Readability first and foremost in this case. > > I was exploring if I can disable VLAs for the kernel altogether, this > can't be done for now. Nevertheless, this change looked like it would > be useful to make anyway. Why does

Re: CVS commit: src/sys/arch/x86

2020-08-01 Thread Taylor R Campbell
> Module Name:src > Committed By: jdolecek > Date: Sat Aug 1 12:36:36 UTC 2020 > > Modified Files: > src/sys/arch/x86/pci: pci_intr_machdep.c > src/sys/arch/x86/x86: mainbus.c > > Log Message: > reorder includes to pull __HAVE_PCI_MSI_MSIX properly via > If

Re: CVS commit: src/sys/kern

2020-08-01 Thread Taylor R Campbell
> Module Name:src > Committed By: jdolecek > Date: Sat Aug 1 11:18:26 UTC 2020 > > Modified Files: > src/sys/kern: subr_autoconf.c > > Log Message: > avoid VLA for the sizeof() calculations Why?

Re: CVS commit: src/share/misc

2020-08-01 Thread Taylor R Campbell
> Module Name:src > Committed By: lukem > Date: Sat Aug 1 02:45:36 UTC 2020 > > Modified Files: > src/share/misc: style > > Log Message: > style: prefer braces for single statement control statements > > Prefer to use { braces } around single statements after > control

Re: CVS commit: src/sys/arch/xen/xen

2020-06-24 Thread Taylor R Campbell
> Module Name:src > Committed By: jdolecek > Date: Fri Apr 10 18:03:06 UTC 2020 > > Modified Files: > src/sys/arch/xen/xen: if_xennet_xenbus.c > > Log Message: > convert to bus_dma(9), remove now not necessary XENPVHVM redefines > [...] > +

Re: CVS commit: src/sys/dev/usb

2020-05-27 Thread Taylor R Campbell
> Date: Wed, 27 May 2020 05:28:41 -0700 (PDT) > From: Paul Goyette > > Do you also need to decrement the number of busses when one is > detached? Not really, because we just need to know whether usb_once_init has been run. Now, should we use something other than RUN_ONCE, which can both set up

Re: CVS commit: src/tests/lib/libc/sys

2020-05-14 Thread Taylor R Campbell
> Date: Thu, 14 May 2020 23:36:28 +0200 > From: Kamil Rytarowski > > If a signal would not reach the child process (as it is ignored or > masked+SA_IGNOREd) and it is not a crash signal, it is dropped. As I > checked, it's the design in UNIX to overlook SIGCHLD signals in UNIX. > Race free

Re: CVS commit: src/sys/uvm

2020-05-10 Thread Taylor R Campbell
> Date: Sun, 10 May 2020 23:53:00 +0100 > From: Alexander Nasonov > > Taylor R Campbell wrote: > > Log Message: > > Implement swap encryption. > > > > Enabled by sysctl -w vm.swap_encrypt=1. > > If secmodel_securelevel(9) is still a thing, locking

Re: CVS commit: src/external/cddl/osnet/dist/uts/common/fs/zfs

2020-05-07 Thread Taylor R Campbell
> Module Name:src > Committed By: hannken > Date: Thu May 7 09:12:03 UTC 2020 > > Modified Files: > src/external/cddl/osnet/dist/uts/common/fs/zfs: zfs_vnops.c > > Log Message: > Revert Rev. 1.63 and add a comment why we have to zil_commit() here: > > Operation

Re: CVS commit: src

2020-05-04 Thread Taylor R Campbell
> Module Name:src > Committed By: maxv > Date: Sat May 2 11:37:17 UTC 2020 > > Log Message: > Modify the hotpatch mechanism, in order to make it much less ROP-friendly. > > Currently x86_patch_window_open is a big problem, because it is a perfect > function to inject/modify

Re: CVS commit: src/sys/modules/examples/fopsmapper

2020-04-01 Thread Taylor R Campbell
> Date: Wed, 1 Apr 2020 07:42:53 -0700 > From: Jason Thorpe > > If PAGE_SIZE is ostensibly a vsize_t / size_t, why not define it as (1U << > PAGE_SHIFT)? Without running the following program, can you tell me what it will print? It might work to define PAGE_SIZE to be ((size_t)1 <<

Re: CVS commit: src/external/gpl3

2020-03-26 Thread Taylor R Campbell
> Date: Thu, 26 Mar 2020 14:57:40 +0100 > From: Kamil Rytarowski > > Maybe we could specify TMPDIR somewhere in /etc and point to /tmp? > > The build of tools could be fixed independently. It is wrong for gcc to abuse /var/tmp for files that aren't meaningfully persistent, just like it would

Re: CVS commit: src/external/gpl3

2020-03-25 Thread Taylor R Campbell
> Date: Thu, 26 Mar 2020 01:26:05 +0100 > From: Kamil Rytarowski > > Upstream (GCC) is strongly against this change (even under __NetBSD__ > ifdef) as /var/tmp is typically larger than /tmp: > > > I'd strongly recommend against this as-is. > > > > The whole reason we prefer /var/tmp is because

Re: CVS commit: src/sys/rump

2020-03-09 Thread Taylor R Campbell
> Module Name:src > Committed By: kamil > Date: Mon Mar 9 00:03:00 UTC 2020 > > Modified Files: > src/sys/rump: Makefile.rump > > Log Message: > Build RUMP with -fno-delete-null-pointer-checks on all compilers I asked you to hold off on making this change, ten hours

Re: CVS commit: src/lib

2020-03-03 Thread Taylor R Campbell
> Date: Tue, 03 Mar 2020 20:05:14 +1100 > from: matthew green > > thanksand can you please have this pulled up to other > branches it's present on. Already done: https://releng.NetBSD.org/cgi-bin/req-9.cgi?show=756 https://releng.NetBSD.org/cgi-bin/req-8.cgi?show=1513

Re: CVS commit: src/sys/kern

2020-03-02 Thread Taylor R Campbell
> Date: Tue, 3 Mar 2020 12:41:32 +0900 > From: Rin Okuyama > > On 2020/03/03 1:00, Taylor R Campbell wrote: > > Include kern_crashme.c in non-DEBUG kernels. > > > > This is useful for simulating crashes in production to test failover. > > I like this. >

Re: CVS commit: src/doc

2020-02-29 Thread Taylor R Campbell
> Module Name:src > Committed By: kamil > Date: Sat Feb 29 04:27:01 UTC 2020 > > Modified Files: > src/doc: CHANGES > > Log Message: > ld.elf_so(1): Implement DT_GNU_HASH Was this discussed anywhere? What are the advantages and drawbacks of this over what we were doing

Re: CVS commit: src/sys/arch

2019-12-23 Thread Taylor R Campbell
> Module Name:src > Committed By: thorpej > Date: Sun Dec 22 15:09:39 UTC 2019 > > Add intr_mask() and corresponding intr_unmask() calls that allow specific > interrupt lines / sources to be masked as needed (rather than making a > set of sources by IPL as with spl*()). > > +

Re: CVS commit: src/sys/uvm

2019-12-23 Thread Taylor R Campbell
> Module Name:src > Committed By: ad > Date: Sat Dec 21 14:41:44 UTC 2019 > > - Add inlines to set/get locator values in the unused lower bits of > pg->phys_addr. Begin by using it to cache the freelist index, because > computing it is expensive and that shows up during

Re: CVS commit: src

2019-12-22 Thread Taylor R Campbell
> Date: Sun, 22 Dec 2019 10:24:01 +0100 > From: Maxime Villard > > You, Martin Christos and Taylor, are trying to change subject, find > excuses, and are sending me irrelevant responses vaguely insinuating that > I should revert my change only without addressing the additional concerns >

Re: CVS commit: src

2019-12-20 Thread Taylor R Campbell
Security-team is not perfect. We're happy to discuss a better way to disable filemon provisionally, and/or how to better address the existing users if we are to delete it -- after you do as core asked you to do to resolve the interim dispute by restoring the tree. This is a social process. We

Re: CVS commit: src

2019-12-19 Thread Taylor R Campbell
> Date: Thu, 19 Dec 2019 08:19:07 +0100 > From: Maxime Villard > > I think you meant to say "REMOVING things you don't like". Correct, I made an editing error. Sorry for the confusion. > In the meantime, I have absolutely no intent to reinstate filemon. You can > reinstate it if you want, but

Re: CVS commit: src

2019-12-18 Thread Taylor R Campbell
> Module Name:src > Committed By: maxv > Date: Wed Dec 18 07:37:19 UTC 2019 > > Log Message: > Retire filemon, discussed on tech-kern@. Please refrain from taking unilateral actions such as things you don't like without reasonable discussion. - Nobody skimming tech-kern by

Re: CVS commit: src/sys/uvm

2019-12-01 Thread Taylor R Campbell
> Date: Sun, 1 Dec 2019 11:54:24 + > From: Andrew Doran > > On Sun, Dec 01, 2019 at 08:19:09AM +, Maxime Villard wrote: > > > Modified Files: > > src/sys/uvm: uvm_fault.c > > > > Log Message: > > Use atomic_{load,store}_relaxed() on global counters. > > If you would be so kind,

CVS commit: src/sys/arch/ia64/ia64

2019-11-30 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Nov 30 16:23:46 UTC 2019 Modified Files: src/sys/arch/ia64/ia64: pmap.c Log Message: Need for atomic_inc_64. Emptying out had the side effect of removing an implied #include . To generate a diff of this commit: cvs

CVS commit: src/sys/arch/ia64/ia64

2019-11-30 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Nov 30 16:23:46 UTC 2019 Modified Files: src/sys/arch/ia64/ia64: pmap.c Log Message: Need for atomic_inc_64. Emptying out had the side effect of removing an implied #include . To generate a diff of this commit: cvs

CVS commit: src/sys/sys

2019-11-30 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Nov 30 15:34:07 UTC 2019 Modified Files: src/sys/sys: mutex.h Log Message: Nix vestigial references to MUTEX_GIVE and MUTEX_RECEIVE in comments. To generate a diff of this commit: cvs rdiff -u -r1.22 -r1.23

CVS commit: src/sys/sys

2019-11-30 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Nov 30 15:34:07 UTC 2019 Modified Files: src/sys/sys: mutex.h Log Message: Nix vestigial references to MUTEX_GIVE and MUTEX_RECEIVE in comments. To generate a diff of this commit: cvs rdiff -u -r1.22 -r1.23

  1   2   3   4   >