Re: CVS commit: src/lib/libcurses

2021-07-26 Thread Valery Ushakov
On Mon, Jul 26, 2021 at 21:04:37 +, nia wrote: > On Mon, Jul 26, 2021 at 09:01:51PM +, nia wrote: > > On Mon, Jul 26, 2021 at 11:55:24PM +0300, Valery Ushakov wrote: > > > On Mon, Jul 26, 2021 at 20:17:10 +, Nia Alarie wrote: > > > > > > >

Re: CVS commit: src/lib/libcurses

2021-07-26 Thread Valery Ushakov
On Mon, Jul 26, 2021 at 20:17:10 +, Nia Alarie wrote: > Module Name: src > Committed By: nia > Date: Mon Jul 26 20:17:10 UTC 2021 > > Modified Files: > src/lib/libcurses: curses_standout.3 > > Log Message: > The BUGS sections is incorrect again for "modern" terminals. > >

Re: CVS commit: src/tests/lib/libcurses/director

2021-04-05 Thread Valery Ushakov
On Tue, Apr 06, 2021 at 00:47:00 +, Roland Illig wrote: > The previous "table" was an insult to any reader. It was unsorted, > listed the functions shuffled, and was not even formatted consistently. That's pretty rude. Please, tone down your commit "messages". -uwe

Re: CVS commit: src/usr.bin/xlint

2021-03-26 Thread Valery Ushakov
On Sat, Mar 27, 2021 at 01:44:07 +0100, Roland Illig wrote: > On 27.03.2021 00:16, Valery Ushakov wrote: > > On Sat, Mar 27, 2021 at 00:01:25 +0100, Roland Illig wrote: > > > To me, writing 'sizeof expr' is clearer than 'sizeof(expr)' since > > > 'sizeof' is not a fun

Re: CVS commit: src/usr.bin/xlint

2021-03-26 Thread Valery Ushakov
On Sat, Mar 27, 2021 at 00:01:25 +0100, Roland Illig wrote: > > > Log Message: > > > lint: in malloc calls, use 'sizeof *ptr' instead of 'sizeof(type)' > > > > style says "sizeof(" not "sizeof " > > > > * Casts and sizeof's are not followed by a space. > > There are several forms of

Re: CVS commit: src/usr.bin/sed

2021-03-11 Thread Valery Ushakov
On Thu, Mar 11, 2021 at 10:15:05 -0500, Christos Zoulas wrote: > Module Name: src > Committed By: christos > Date: Thu Mar 11 15:15:05 UTC 2021 > > Modified Files: > src/usr.bin/sed: main.c sed.1 > > Log Message: > Add -G to support GNU extensions This is inverse of m4(1) where

Re: POINTER_ALIGNED_P (was: Re: CVS commit: src/sys)

2021-02-17 Thread Valery Ushakov
On Wed, Feb 17, 2021 at 17:49:15 -, Christos Zoulas wrote: > In article , > Valery Ushakov wrote: > > >But to get back to my main point, PLEASE, can we stop making random > >aimless changes without prior discussion? > > Here's the change I'd like to make: >

Re: POINTER_ALIGNED_P (was: Re: CVS commit: src/sys)

2021-02-16 Thread Valery Ushakov
On Tue, Feb 16, 2021 at 18:51:43 -0500, Christos Zoulas wrote: > On Feb 17, 2:20am, u...@stderr.spb.ru (Valery Ushakov) wrote: > -- Subject: Re: POINTER_ALIGNED_P (was: Re: CVS commit: src/sys) > > | Well, it was you who did the definion of ALIGNED_POINTER centralized > |

Re: POINTER_ALIGNED_P (was: Re: CVS commit: src/sys)

2021-02-16 Thread Valery Ushakov
On Wed, Feb 17, 2021 at 00:51:03 +0100, Roland Illig wrote: > 17.02.2021 00:25:10 Valery Ushakov : > > On Tue, Feb 16, 2021 at 23:54:46 +0100, Roland Illig wrote: > >> Yes, it does. That's what the "#undef __NO_STRICT_ALIGNMENT" in the > >> test is

Re: POINTER_ALIGNED_P (was: Re: CVS commit: src/sys)

2021-02-16 Thread Valery Ushakov
On Tue, Feb 16, 2021 at 17:53:09 -0500, Christos Zoulas wrote: > In this case "type" is a struct and we have __alignof() to handle > it, but does this give the right answer? > > Also ALIGNED_POINTER is not conditional to __NO_STRICT_ALIGNMENT and > can be overriden (the opposite goes for

Re: POINTER_ALIGNED_P (was: Re: CVS commit: src/sys)

2021-02-16 Thread Valery Ushakov
On Tue, Feb 16, 2021 at 23:54:46 +0100, Roland Illig wrote: > On 16.02.2021 23:40, Valery Ushakov wrote: > > On Tue, Feb 16, 2021 at 22:56:19 +0100, Roland Illig wrote: > > > > > On 16.02.2021 19:46, Roy Marples wrote: > > > > I suggest we change POINTER_ALI

Re: POINTER_ALIGNED_P (was: Re: CVS commit: src/sys)

2021-02-16 Thread Valery Ushakov
On Tue, Feb 16, 2021 at 22:56:19 +0100, Roland Illig wrote: > On 16.02.2021 19:46, Roy Marples wrote: > > I suggest we change POINTER_ALIGNED_P to accept the alignment value we > > want rather than the bitwise test we supply, like so: > > > > #define POINTER_ALIGNED_P(p, a) (((uintptr_t)(p) &

Re: CVS commit: src

2021-02-13 Thread Valery Ushakov
On Sat, Feb 13, 2021 at 14:30:37 +, Roland Illig wrote: > Libcurses can be built in 2 modes: with wide character support or > without (-DDISABLE_WCHAR). The test suite only covers the variant with > wide characters. The single-byte variant has to be tested manually. > Running sysinst with

Re: CVS commit: src

2021-02-13 Thread Valery Ushakov
Thanks for working on this, but a couple of nitpicks: On Sat, Feb 13, 2021 at 14:30:37 +, Roland Illig wrote: > In sysinst, the installation screen is indented with tabs. Sysinst uses > msgc, which brings its own text layout engine. This engine does not use > addbytes but addch. [...] >

Re: CVS commit: src/sys/sys

2021-01-26 Thread Valery Ushakov
On Wed, Jan 27, 2021 at 01:00:05 +, Jason R Thorpe wrote: > Module Name: src > Committed By: thorpej > Date: Wed Jan 27 01:00:05 UTC 2021 > > Modified Files: > src/sys/sys: device.h > > Log Message: > Define a macro to terminate the common usage of device_compatible_entry >

Re: CVS commit: src/sys/arch

2021-01-25 Thread Valery Ushakov
On Mon, Jan 25, 2021 at 20:28:52 +0300, Valery Ushakov wrote: > On Mon, Jan 25, 2021 at 08:19:44 -0800, Jason Thorpe wrote: > > > > On Jan 25, 2021, at 6:22 AM, Kamil Rytarowski wrote: > > > > > > I have no problem with this change but I am curious why should

Re: CVS commit: src/sys/arch

2021-01-25 Thread Valery Ushakov
On Mon, Jan 25, 2021 at 08:19:44 -0800, Jason Thorpe wrote: > > On Jan 25, 2021, at 6:22 AM, Kamil Rytarowski wrote: > > > > I have no problem with this change but I am curious why should we use "{ > > }"? It's a C GNU extension and C++ syntax. > > Using { 0 } makes an assumption about the

Re: CVS commit: src/share/man/man5

2021-01-15 Thread Valery Ushakov
On Sat, Jan 16, 2021 at 14:46:46 +1100, matthew green wrote: > > Log Message: > > Tweak wording for consistency: `if empty or not set', not `if unset'. > > is this correct? > > rc complains if unset or not set (ie, if "$foo" is zero length): > > /etc/rc.d/upsdriver: WARNING: $upsdriver is not

catman (Was: CVS commit: src/games/fortune/datfiles)

2020-11-08 Thread Valery Ushakov
On Sun, Nov 08, 2020 at 17:37:30 +, Kamil Rytarowski wrote: > Module Name: src > Committed By: kamil > Date: Sun Nov 8 17:37:30 UTC 2020 > > Modified Files: > src/games/fortune/datfiles: fortunes > > Log Message: > catman(8) is a past thing Please, revert this. It's

Re: CVS commit: src/usr.sbin/puffs/mount_9p

2020-08-30 Thread Valery Ushakov
On Sun, Aug 30, 2020 at 17:12:45 -0400, Christos Zoulas wrote: > Module Name: src > Committed By: christos > Date: Sun Aug 30 21:12:45 UTC 2020 > > Modified Files: > src/usr.sbin/puffs/mount_9p: Makefile > > Log Message: > include bsd.init.mk to avoid: > make: Bad conditional

Re: CVS commit: src/share/man/man4

2020-08-24 Thread Valery Ushakov
On Tue, Aug 25, 2020 at 10:03:28 +0900, Ryo ONODERA wrote: > Valery Ushakov writes: > > > On Mon, Aug 24, 2020 at 19:27:36 +, Ryo ONODERA wrote: > > > >> Module Name: src > >> Committed By: ryoon > >> Date: Mon Aug 2

Re: CVS commit: src/share/man/man4

2020-08-24 Thread Valery Ushakov
On Mon, Aug 24, 2020 at 19:27:36 +, Ryo ONODERA wrote: > Module Name: src > Committed By: ryoon > Date: Mon Aug 24 19:27:36 UTC 2020 > > Modified Files: > src/share/man/man4: viomb.4 > > Log Message: > Add a missing comma > > And bump date. I don't think minor edits like

Re: CVS commit: src/share/man/man8

2020-08-15 Thread Valery Ushakov
On Sat, Aug 15, 2020 at 16:12:40 +0200, Leonardo Taccari wrote: > > +.Ic export > > PKG_PATH=https://ftp.netbsd.org/pub/pkgsrc/packages/NetBSD/9.0/amd64/All > > +.Ic pkg_add pkgin > > [...] > > Can this use cdn.NetBSD.org and made a bit more general instead of > hardcoding version/port please?

Re: CVS commit: src/external/gpl3/gcc/dist/gcc/config/m68k

2020-08-10 Thread Valery Ushakov
On Mon, Aug 10, 2020 at 06:24:39 +, Rin Okuyama wrote: > Modified Files: > src/external/gpl3/gcc/dist/gcc/config/m68k: netbsd-elf.h > > Log Message: > PR port-m68k/6 > > Reset STACK_BOUNDARY to default, 16, to fix strange freeze for amiga, > when kernel is compiled by GCC8. This

Re: CVS commit: src/sys/dev/mii

2020-08-03 Thread Valery Ushakov
On Tue, Aug 04, 2020 at 07:12:54 +0300, Valery Ushakov wrote: > On Tue, Aug 04, 2020 at 12:50:11 +0900, SAITOH Masanobu wrote: > > > On 2020/08/03 23:00, Valeriy E. Ushakov wrote: > > > Module Name: src > > > Committed By: uwe > > > Date:

Re: CVS commit: src/sys/dev/mii

2020-08-03 Thread Valery Ushakov
On Tue, Aug 04, 2020 at 12:50:11 +0900, SAITOH Masanobu wrote: > On 2020/08/03 23:00, Valeriy E. Ushakov wrote: > > Module Name:src > > Committed By: uwe > > Date: Mon Aug 3 14:00:41 UTC 2020 > > > > Modified Files: > > src/sys/dev/mii: miidevs_data.h > > > >

Re: CVS commit: src/usr.bin/printf

2020-06-28 Thread Valery Ushakov
On Sun, Jun 28, 2020 at 21:52:23 +0700, Robert Elz wrote: > Date:Fri, 26 Jun 2020 22:05:05 + > From:"Valeriy E. Ushakov" > Message-ID: <20200626220505.e9030f...@cvs.netbsd.org> > > | Modified Files: > | src/usr.bin/printf: printf.1 > | > | Log Message:

Re: CVS commit: src/sys/arch/x86/x86

2020-06-06 Thread Valery Ushakov
On Sat, Jun 06, 2020 at 11:25:19 +0200, Kamil Rytarowski wrote: > On 06.06.2020 09:42, Simon Burge wrote: > > "Kamil Rytarowski" wrote: > > > >> Module Name: src > >> Committed By: kamil > >> Date: Fri Jun 5 21:48:04 UTC 2020 > >> > >> Modified Files: > >> > >>

Re: CVS commit: src/distrib/sets/lists/base

2020-06-02 Thread Valery Ushakov
On Tue, Jun 02, 2020 at 19:15:15 +, Roy Marples wrote: > Module Name: src > Committed By: roy > Date: Tue Jun 2 19:15:15 UTC 2020 > > Modified Files: > src/distrib/sets/lists/base: mi > > Log Message: > dhcpcd: delete the obsolete chroot paths > > postinstall will take care

Re: CVS commit: src/sys/dev/usb

2020-03-14 Thread Valery Ushakov
On Sat, Mar 14, 2020 at 10:27:27 -0400, Christos Zoulas wrote: > > I don't belive that "if". It's like claiming you got rid of a stain > > on a wallpaper after you demolish a wall (not load-bearing, > > fortunately) and have to put it back and put new wallpaper. :) Get rid > > of the stain,

Re: CVS commit: src/sys/dev/usb

2020-03-14 Thread Valery Ushakov
On Sat, Mar 14, 2020 at 09:57:36 -0400, Christos Zoulas wrote: > > Even for the ones without the widths specified. E.g. I personally > > prefer zero printed as 0x0, not as 0, so I assume that when people > > choose either one that reflects their preference. Why mess with it? > > It's all so

Re: CVS commit: src/sys/dev/usb

2020-03-13 Thread Valery Ushakov
On Fri, Mar 13, 2020 at 22:26:05 -0400, Christos Zoulas wrote: > > On Mar 13, 2020, at 10:25 PM, Valery Ushakov wrote: > > > > As I wrote in a follow up email, it changes formatting b/c you didn't > > change field widths and IMO using %# with a field width is mos

Re: CVS commit: src/sys/dev/usb

2020-03-13 Thread Valery Ushakov
On Fri, Mar 13, 2020 at 22:15:31 -0400, Christos Zoulas wrote: > > This was not a part of the PR and is completely cosmetic (surely it > > supports plain %x if it does support %#x). Why was this necessary? > > (I know I would be quite miffed if someone made a change like that to > > my code). >

Re: CVS commit: src/sys/dev/usb

2020-03-13 Thread Valery Ushakov
On Fri, Mar 13, 2020 at 17:09:14 -0700, Paul Goyette wrote: > On Sat, 14 Mar 2020, Valery Ushakov wrote: > > > On Fri, Mar 13, 2020 at 14:17:42 -0400, Christos Zoulas wrote: > > > > > Log Message: > > > PR/55068: sc.dying: Fix

Re: CVS commit: src/sys/dev/usb

2020-03-13 Thread Valery Ushakov
On Fri, Mar 13, 2020 at 14:17:42 -0400, Christos Zoulas wrote: > Log Message: > PR/55068: sc.dying: Fix printf formats: [...] > - 0x% -> %# This was not a part of the PR and is completely cosmetic (surely it supports plain %x if it does support %#x). Why was this necessary? (I know I would be

Re: CVS commit: src/lib/libcurses

2020-03-11 Thread Valery Ushakov
On Wed, Mar 11, 2020 at 23:47:40 +, Roy Marples wrote: > Module Name: src > Committed By: roy > Date: Wed Mar 11 23:47:40 UTC 2020 > > Modified Files: > src/lib/libcurses: erase.c > > Log Message: > curses: Fix werase(3) wide character support > > We need to consider erasing

Re: CVS commit: src/sys/conf

2020-03-07 Thread Valery Ushakov
On Sat, Mar 07, 2020 at 19:18:41 -0500, Christos Zoulas wrote: > Module Name: src > Committed By: christos > Date: Sun Mar 8 00:18:41 UTC 2020 > > Modified Files: > src/sys/conf: files > > Log Message: > undo previous since config has been fixed It's still not. Nested ifdefs

Re: CVS commit: src/external/bsd/tcpdump/dist

2020-02-24 Thread Valery Ushakov
On Mon, Feb 24, 2020 at 16:19:35 +, Kamil Rytarowski wrote: > Module Name: src > Committed By: kamil > Date: Mon Feb 24 16:19:35 UTC 2020 > > Modified Files: > src/external/bsd/tcpdump/dist: extract.h > > Log Message: > Rearrange the code to make UNALIGNED_OK available for

Re: CVS commit: src/lib/libc/stdlib

2020-02-23 Thread Valery Ushakov
On Sun, Feb 23, 2020 at 10:57:28 +0100, Kamil Rytarowski wrote: > On 23.02.2020 08:46, Martin Husemann wrote: > > > Source code consistency is a very important stylistic plus, every break of > > that should be accompanied by a comment. > > Done. Thank you. -uwe

Re: CVS commit: src/lib/libc/stdlib

2020-02-22 Thread Valery Ushakov
On Sun, Feb 23, 2020 at 03:35:19 +0100, Kamil Rytarowski wrote: > On 23.02.2020 03:20, Valery Ushakov wrote: > > On Sun, Feb 23, 2020 at 02:51:49 +0100, Kamil Rytarowski wrote: > > > >> On 23.02.2020 02:29, Valery Ushakov wrote: > >>> On Sat, Feb 22, 2020

Re: CVS commit: src/lib/libc/stdlib

2020-02-22 Thread Valery Ushakov
On Sun, Feb 23, 2020 at 02:51:49 +0100, Kamil Rytarowski wrote: > On 23.02.2020 02:29, Valery Ushakov wrote: > > On Sat, Feb 22, 2020 at 14:07:57 +, Kamil Rytarowski wrote: > > > >> Module Name: src > >> Committed By: kamil > >> Date:

Re: CVS commit: src/lib/libc/stdlib

2020-02-22 Thread Valery Ushakov
On Sat, Feb 22, 2020 at 14:07:57 +, Kamil Rytarowski wrote: > Module Name: src > Committed By: kamil > Date: Sat Feb 22 14:07:57 UTC 2020 > > Modified Files: > src/lib/libc/stdlib: _rand48.c > > Log Message: > Avoid undefined behavior in the rand48(3) implementation > >

Re: CVS commit: src/external/apache2/llvm/config/llvm/Config

2020-02-21 Thread Valery Ushakov
On Fri, Feb 21, 2020 at 11:13:24 +0100, Kamil Rytarowski wrote: > This patch changes cryptic failure in linking to a verbose message: > > http://netbsd.org/~kamil/patch-00231-llvm-terminfo-tools.txt > > Does it look to commit? The "devel library" is linux-specific terminology. There's no need

Re: CVS commit: src/external/apache2/llvm/config/llvm/Config

2020-02-20 Thread Valery Ushakov
On Thu, Feb 20, 2020 at 00:09:28 +, Roy Marples wrote: > On 19/02/2020 22:29, Kamil Rytarowski wrote: > > Why do you need terminfo/termios in ./build.sh tools? > > We build the nbtic tool so we can build the terminfo database. The database is not a problem. If we want to keep this code

Re: CVS commit: src/external/apache2/llvm/config/llvm/Config

2020-02-20 Thread Valery Ushakov
On Thu, Feb 20, 2020 at 10:54:50 +0100, Kamil Rytarowski wrote: > >> https://syzkaller.appspot.com/text?tag=CrashLog=11aafc09e0 > > > > Yes and that is completely useless for figuring out the why. > > We don't have any direct reproducer (we tried) and we must figure it > out from syzkaller

Re: CVS commit: src/external/bsd/dhcpcd/dist/src

2020-02-13 Thread Valery Ushakov
On Thu, Feb 13, 2020 at 18:25:41 +0100, Kamil Rytarowski wrote: > On 13.02.2020 18:00, Valery Ushakov wrote: > > Arguably, if the tool you use is broken, you shouln't be mutilating > > the source code just to shut that tool up. > > The introduced changes were good, even i

Re: CVS commit: src/external/bsd/dhcpcd/dist/src

2020-02-13 Thread Valery Ushakov
On Thu, Feb 13, 2020 at 15:03:35 +0100, Kamil Rytarowski wrote: > On 13.02.2020 14:50, Valery Ushakov wrote: > > On Thu, Feb 13, 2020 at 14:18:43 +0100, Kamil Rytarowski wrote: > > > > Can you show the original problem that you are trying to fix here? > > When

Re: CVS commit: src/external/bsd/dhcpcd/dist/src

2020-02-13 Thread Valery Ushakov
On Thu, Feb 13, 2020 at 14:18:43 +0100, Kamil Rytarowski wrote: > Feel free to fix GCC. That's sounds rather dismissive to me. Can you show the original problem that you are trying to fix here? When and how did you get warning? I do NOT see the warning for this kind of conversion with either

Re: CVS commit: src/usr.sbin/altq/altqstat

2020-02-07 Thread Valery Ushakov
On Fri, Feb 07, 2020 at 20:13:26 +, Santhosh Raju wrote: > Module Name: src > Committed By: fox > Date: Fri Feb 7 20:13:26 UTC 2020 > > Modified Files: > src/usr.sbin/altq/altqstat: quip_client.c > > Log Message: > usr.sbin/altq: Fix -Wstringop-truncation warning. > > Looks

sys_ptrace_lwpstatus.c (Was: CVS commit: src/sys)

2019-12-26 Thread Valery Ushakov
On Thu, Dec 26, 2019 at 08:52:39 +, Kamil Rytarowski wrote: > Module Name: src > Committed By: kamil > Date: Thu Dec 26 08:52:39 UTC 2019 > > Modified Files: > src/sys/kern: files.kern sys_ptrace_common.c > src/sys/sys: ptrace.h > Added Files: > src/sys/kern:

Re: CVS commit: src/share/tmac

2019-12-24 Thread Valery Ushakov
On Tue, Dec 24, 2019 at 16:13:56 -, Christos Zoulas wrote: > In article <20191224113037.gl24...@pony.stderr.spb.ru>, > Valery Ushakov wrote: > >On Tue, Dec 24, 2019 at 08:46:49 +0700, Robert Elz wrote: > > > >> | |but since we run with -ww we

Re: CVS commit: src/share/tmac

2019-12-24 Thread Valery Ushakov
On Tue, Dec 24, 2019 at 08:46:49 +0700, Robert Elz wrote: > Date:Mon, 23 Dec 2019 23:45:34 +0100 > From:Steffen Nurpmeso > Message-ID: <20191223224534.8ufgy%stef...@sdaoden.eu> > > > | |Troff reads .ie and checks the condition. The condition is true and > |

Re: CVS commit: src/share/tmac

2019-12-23 Thread Valery Ushakov
On Mon, Dec 23, 2019 at 22:13:23 +0100, Steffen Nurpmeso wrote: > Valeriy E. Ushakov wrote in <20191223201734.0e415f...@cvs.netbsd.org>: > > |Modified Files: > | src/share/tmac: doc2html > | > |Log Message: > |Fix if/else syntax in previous. > > What was wrong with that? > > . ie

Re: CVS commit: src/share/man/man9

2019-12-07 Thread Valery Ushakov
On Sat, Dec 07, 2019 at 12:22:19 +, Thomas Klausner wrote: > Modified Files: > src/share/man/man9: atomic_loadstore.9 > > Log Message: > Simplify macro usage. > > > To generate a diff of this commit: > cvs rdiff -u -r1.3 -r1.4 src/share/man/man9/atomic_loadstore.9 This breaks

Re: CVS commit: src/distrib/notes/common

2019-12-04 Thread Valery Ushakov
On Wed, Dec 04, 2019 at 19:59:06 +0700, Robert Elz wrote: > While "Administrivia" is not really a word, it is a common > slang expression indicating trivial issues that are related > to administration (I have no idea what Administrativa might be, > "administrative" is a word, but meaningless in

Re: CVS commit: src/distrib/notes/common

2019-12-02 Thread Valery Ushakov
My apologies. Thanks for the heads up. I was running the extraction script on src only. I will restore these entries. On Tue, Dec 03, 2019 at 08:00:40 +0900, Izumi Tsutsui wrote: > Date: Tue, 3 Dec 2019 08:00:40 +0900 > From: Izumi Tsutsui > Subject: Re: CVS commit: src/distrib/notes/common

Re: CVS commit: src/sys/kern

2019-11-07 Thread Valery Ushakov
On Thu, Nov 07, 2019 at 19:06:29 +0100, Martin Husemann wrote: > OK, why is it 8 byte aligned? Checking > > > revision 1.108 > > date: 2011-01-18 20:52:24 +0100; author: matt; state: Exp; lines: +2 -1; > > Make struct disklabel 8 byte aligned. This increases its size by 4 bytes > > on

Re: CVS commit: src/sys/kern

2019-11-07 Thread Valery Ushakov
On Thu, Nov 07, 2019 at 18:08:40 +0100, Kamil Rytarowski wrote: > On 07.11.2019 16:45, Kamil Rytarowski wrote: > > On 07.11.2019 16:26, Martin Husemann wrote: > >> On Thu, Nov 07, 2019 at 02:53:08PM +0100, Kamil Rytarowski wrote: > >>> On 07.11.20

Re: CVS commit: src/sys/kern

2019-11-07 Thread Valery Ushakov
On Thu, Nov 07, 2019 at 09:58:06 -0600, David Young wrote: > On Thu, Nov 07, 2019 at 04:26:51PM +0100, Martin Husemann wrote: > > On Thu, Nov 07, 2019 at 02:53:08PM +0100, Kamil Rytarowski wrote: > > > On 07.11.2019 14:25, Valery Ushakov wrote: > > > > If the sanit

Re: CVS commit: src/sys/kern

2019-11-07 Thread Valery Ushakov
On Thu, Nov 07, 2019 at 15:48:55 +0300, Valery Ushakov wrote: > On Thu, Nov 07, 2019 at 13:37:21 +0100, Kamil Rytarowski wrote: > > > On 07.11.2019 13:17, Valery Ushakov wrote: > > > On Thu, Nov 07, 2019 at 06:02:39 +0100, Kamil Rytarowski wrote: > > >

Re: CVS commit: src/sys/kern

2019-11-07 Thread Valery Ushakov
On Thu, Nov 07, 2019 at 13:59:37 +0100, Kamil Rytarowski wrote: > On 07.11.2019 13:48, Valery Ushakov wrote: > > On Thu, Nov 07, 2019 at 13:37:21 +0100, Kamil Rytarowski wrote: > > > >> On 07.11.2019 13:17, Valery Ushakov wrote: > >>> On Thu, Nov 07, 2019

Re: CVS commit: src/sys/kern

2019-11-07 Thread Valery Ushakov
On Thu, Nov 07, 2019 at 13:37:21 +0100, Kamil Rytarowski wrote: > On 07.11.2019 13:17, Valery Ushakov wrote: > > On Thu, Nov 07, 2019 at 06:02:39 +0100, Kamil Rytarowski wrote: > > > >> I have checked received the following patch and received a feedback fr

Re: CVS commit: src/sys/kern

2019-11-07 Thread Valery Ushakov
On Thu, Nov 07, 2019 at 06:02:39 +0100, Kamil Rytarowski wrote: > I have checked received the following patch and received a feedback from > a LLVM developer. > > On 07.11.2019 05:47, 'Dmitry Vyukov' via syzkaller-netbsd-bugs wrote: > > I've consulted with some people and _presumably_ (to the

Re: CVS commit: src/sys

2019-10-16 Thread Valery Ushakov
On Wed, Oct 16, 2019 at 11:27:39 -0400, Christos Zoulas wrote: > Module Name: src > Committed By: christos > Date: Wed Oct 16 15:27:39 UTC 2019 > > Modified Files: > src/sys/kern: kern_core.c kern_hook.c kern_sig.c kern_veriexec.c > subr_ipi.c subr_pool.c subr_vmem.c

Re: CVS commit: src/lib/libc/db/db

2019-10-05 Thread Valery Ushakov
On Sat, Oct 05, 2019 at 18:07:58 +, Valeriy E. Ushakov wrote: > Module Name: src > Committed By: uwe > Date: Sat Oct 5 18:07:58 UTC 2019 > > Modified Files: > src/lib/libc/db/db: db.c > > Log Message: > __dberr: tweak signature to make gcc8 -Wbad-function-cast happy about >

Re: CVS commit: src/sys/arch/acorn32/acorn32

2019-10-04 Thread Valery Ushakov
. I'm happy for them and that there's %#x that they can use. What does it have to do with with anything? > On 04.10.2019 04:09, Christos Zoulas wrote: > > Thanks, and zero is special for 0#. Should I revert it? > > > > christos > > > >> On

Re: CVS commit: src/sys/arch/acorn32/acorn32

2019-10-03 Thread Valery Ushakov
On Thu, Oct 03, 2019 at 22:09:28 -0400, Christos Zoulas wrote: > Thanks, and zero is special for 0#. Should I revert it? Yes, please. > > On Oct 3, 2019, at 10:06 PM, Valery Ushakov wrote: > > > > > >> Modified Files: > >>src/sys/arch/acorn3

Re: CVS commit: src/sys/arch/acorn32/acorn32

2019-10-03 Thread Valery Ushakov
> Modified Files: > src/sys/arch/acorn32/acorn32: rpc_machdep.c > > Log Message: > change 0x% -> %x This should read %#x. And this is wrong. 1) With # the 0x is part of the width, so 0x%08x -> 0x0001 %#08x -> 0x01 0x 0x0001 0x01 2) # doesn't add

Re: CVS commit: src

2019-09-02 Thread Valery Ushakov
On Mon, Sep 02, 2019 at 09:08:29 +, Roy Marples wrote: > curses(3): add curses_version() > > Returns NetBSD-Curses %s > Where %s is the NetBSD version taken from sys/param.h > > Discussed on tech-net@, only for ncurses compat. [This was on tech-userlevel@] I know I'm late, but the patch

Re: CVS commit: src/sys/dev/rasops

2019-07-28 Thread Valery Ushakov
On Sun, Jul 28, 2019 at 02:18:14 -0400, Michael wrote: > On Sat, 27 Jul 2019 21:35:04 +0200 > Joerg Sonnenberger wrote: > > > On Fri, Jul 26, 2019 at 07:54:15AM -0300, Jared McNeill wrote: > > > On Fri, 26 Jul 2019, Rin Okuyama wrote: > > > > > > > Also, convert loop of byte-wise copy into

Re: CVS commit: src/libexec/getty

2019-07-11 Thread Valery Ushakov
On Thu, Jul 11, 2019 at 09:48:23 +, Thomas Klausner wrote: > Module Name: src > Committed By: wiz > Date: Thu Jul 11 09:48:22 UTC 2019 > > Modified Files: > src/libexec/getty: gettytab.5 > > Log Message: > Merge lines. Fixes display problem noted in PR 54361 by he@ This

Re: CVS commit: src

2019-06-07 Thread Valery Ushakov
On Sat, Jun 08, 2019 at 08:20:49 +1000, matthew green wrote: > > amd64 is probably one of the few ports that has different -p and -m > > values (there are others, but you wouldn't normally run build.sh on > > them :) > > evbarm on modern hardware is one such platform. uname -p can > be a really

Re: CVS commit: src

2019-06-07 Thread Valery Ushakov
On Sat, Jun 08, 2019 at 01:18:03 +0900, Izumi Tsutsui wrote: > > Fix long-term broken pattern match when determining if uname -p output is > > valid. [^a-z] syntax isn't valid. > > Does this fix PR toolchain/54100? > http://gnats.netbsd.org/54100 No, that's unrelated. Make uses regexps, wher ^

Re: audio2

2019-05-28 Thread Valery Ushakov
On Tue, May 28, 2019 at 20:25:33 +0300, Andreas Gustafsson wrote: > On May 23, Valery Ushakov wrote: > > This feels inverted. The mathematically correct operation required > > here is symmetric division (that rounds towards zero). > > Rounding towards zero is absolutely

Re: audio2

2019-05-25 Thread Valery Ushakov
On Fri, May 24, 2019 at 21:51:35 +0900, Tetsuya Isaki wrote: > At Thu, 23 May 2019 17:08:42 +0300, > Valery Ushakov wrote: > > > +#if defined(__GNUC__) > > > +/* gcc defines '>>' as ASR. */ > > > +#define AUDIO_ASR(value, shift) ((value) >> (shift)

Re: audio2

2019-05-23 Thread Valery Ushakov
On Thu, May 23, 2019 at 21:28:51 +0900, Tetsuya Isaki wrote: > +/* > + * AUDIO_ASR() does Arithmetic Shift Right operation. > + * This macro should be used for audio wave data only. > + * > + * Division by power of two is replaced with shift operation in the most > + * compiler, but even then

Re: CVS commit: src/sys/arch/sh3/sh3

2019-05-09 Thread Valery Ushakov
On Thu, May 09, 2019 at 16:48:31 +, Ryo Shimizu wrote: > Module Name: src > Committed By: ryo > Date: Thu May 9 16:48:31 UTC 2019 > > Modified Files: > src/sys/arch/sh3/sh3: db_trace.c > > Log Message: > fix backtrace. it was broken. > - use db_read_bytes() to avoid faults.

Re: CVS commit: src/distrib/sets/lists

2019-03-18 Thread Valery Ushakov
On Tue, Mar 19, 2019 at 08:04:18 +1100, matthew green wrote: > "Thomas Klausner" writes: > > Module Name:src > > Committed By: wiz > > Date: Mon Mar 18 09:03:08 UTC 2019 > > > > Modified Files: > > src/distrib/sets/lists/comp: ad.mips > >

Re: CVS commit: src/sys/arch

2019-03-10 Thread Valery Ushakov
istos Zoulas , > u...@stderr.spb.ru > > Le 10/03/2019 ? 11:58, Valery Ushakov a ?crit : > > On Sun, Mar 10, 2019 at 08:30:51 +0100, Maxime Villard wrote: > > > Date: Sun, 10 Mar 2019 08:30:51 +0100 > > > From: Maxime Villard > > > Subject: Re: CVS commit: s

Re: CVS commit: src/sys/arch

2019-03-10 Thread Valery Ushakov
On Sun, Mar 10, 2019 at 08:30:51 +0100, Maxime Villard wrote: > Date: Sun, 10 Mar 2019 08:30:51 +0100 > From: Maxime Villard > Subject: Re: CVS commit: src/sys/arch > To: Christos Zoulas , source-changes-d@NetBSD.org > > Le 10/03/2019 ? 04:25, Christos Zoulas a ?crit : > > In article

Re: CVS commit: src/sys/netinet

2019-02-25 Thread Valery Ushakov
On Mon, Feb 25, 2019 at 06:23:33 +0100, Martin Husemann wrote: > On Sun, Feb 24, 2019 at 09:43:52PM +0100, Kamil Rytarowski wrote: > > I consider that this is just GCC specific behavior to make some warnings > > fatal depending on driver configuration. This is typical behavior of GCC > > that we

Re: CVS commit: src/usr.bin/printf

2019-01-27 Thread Valery Ushakov
On Sun, Jan 27, 2019 at 12:03:09 +, Robert Elz wrote: > Modified Files: > src/usr.bin/printf: printf.c > > Log Message: > Revert previous, it was based upon a misreading of the POSIX > spec. POSIX requires "as if by calling strtod()" which we > did already ... by calling strtod().

Re: CVS commit: src/bin/sleep

2019-01-25 Thread Valery Ushakov
On Fri, Jan 25, 2019 at 20:59:56 +0700, Robert Elz wrote: > What other commands take floating point args on the command line > (aside from awk assignments to vars, which are certainly intended to > be locale specific) I'm not sure I can think of one. I think printf(1) comes closest.

Re: CVS commit: src/bin/sleep

2019-01-25 Thread Valery Ushakov
On Fri, Jan 25, 2019 at 17:38:31 +0700, Robert Elz wrote: > Date:Fri, 25 Jan 2019 12:30:23 +0300 > From: Valery Ushakov > Message-ID: <20190125093023.gc18...@pony.stderr.spb.ru> > > | As someone who actually have to ecnoutner

Re: CVS commit: src/bin/sleep

2019-01-25 Thread Valery Ushakov
On Fri, Jan 25, 2019 at 09:48:26 +, David Brownlee wrote: > On Fri, 25 Jan 2019 at 09:30, Valery Ushakov wrote: > > > > On Fri, Jan 25, 2019 at 10:43:10 +0700, Robert Elz wrote: > > > > > Date:Thu, 24 Jan 2019 16:18:49 +0100 > > &

Re: CVS commit: src/bin/sleep

2019-01-25 Thread Valery Ushakov
On Fri, Jan 25, 2019 at 10:43:10 +0700, Robert Elz wrote: > Date:Thu, 24 Jan 2019 16:18:49 +0100 > From:Joerg Sonnenberger > Message-ID: <20190124151849.ga10...@britannica.bec.de> > > | This is overcomplicated and fragile, IMO. Can we just go back to the old > |

Re: CVS commit: src/bin/sleep

2019-01-24 Thread Valery Ushakov
On Thu, Jan 24, 2019 at 16:18:49 +0100, Joerg Sonnenberger wrote: > Date: Thu, 24 Jan 2019 16:18:49 +0100 > From: Joerg Sonnenberger > Subject: Re: CVS commit: src/bin/sleep > To: source-changes-d@NetBSD.org > Mail-Followup-To: source-changes-d@NetBSD.org > w > On Sat, Jan 19, 2019 at 01:27:12PM

Re: CVS commit: src/lib/libwrap

2019-01-11 Thread Valery Ushakov
On Fri, Jan 11, 2019 at 07:39:58 +0700, Robert Elz wrote: > farily easy to add, if only gcc didn't go and do printf format string > analysis and complain when it sees something it does not understand. gcc has plugin API that lets you add support for custom format languages. We use it at work

Re: CVS commit: src

2018-12-30 Thread Valery Ushakov
On Sun, Dec 30, 2018 at 18:19:41 -0500, Christos Zoulas wrote: > Modified Files: > src: build.sh > > Log Message: > add build libs (undocumented). Just curious, what is it for? Also build.sh -V NOBINARIES= build already does more or less the same, isn't it? -uwe

Re: CVS commit: src/sys

2018-11-30 Thread Valery Ushakov
On Fri, Nov 30, 2018 at 13:59:11 +0100, Martin Husemann wrote: > On Fri, Nov 30, 2018 at 07:47:38AM -0500, Christos Zoulas wrote: > > We need to see if the spec says so. I am not sure if we can depend > > that an implementation does it. > > The spec only talks about members not named in the list

Re: CVS commit: src/sys/sys

2018-11-06 Thread Valery Ushakov
On Tue, Nov 06, 2018 at 16:26:44 +, Maya Rashish wrote: > Module Name: src > Committed By: maya > Date: Tue Nov 6 16:26:44 UTC 2018 > > Modified Files: > src/sys/sys: stdint.h types.h > > Log Message: > Guard from type redefinition (needed by pre-C11 C) in a safer way. > >

Re: CVS commit: src/distrib/sets/lists/comp

2018-10-27 Thread Valery Ushakov
On Sat, Oct 27, 2018 at 07:24:59 +, Kamil Rytarowski wrote: > Module Name: src > Committed By: kamil > Date: Sat Oct 27 07:24:58 UTC 2018 > > Modified Files: > src/distrib/sets/lists/comp: mi > > Log Message: > Register missing files in distrib sets > > Add curses_insch.0,

Re: CVS commit: src/lib/libcurses

2018-10-05 Thread Valery Ushakov
On Fri, Oct 05, 2018 at 11:59:05 +, Roy Marples wrote: > Module Name: src > Committed By: roy > Date: Fri Oct 5 11:59:05 UTC 2018 > > Modified Files: > src/lib/libcurses: newwin.c refresh.c > > Log Message: > curses: allow drawing the lowest right hand cell of the terminal >

Re: CVS commit: src/sys/dev/hpc

2018-09-18 Thread Valery Ushakov
On Tue, Sep 18, 2018 at 13:35:45 +0300, Valery Ushakov wrote: > On Tue, Sep 18, 2018 at 18:52:34 +0900, Rin Okuyama wrote: > > > On 2018/09/18 18:21, Valery Ushakov wrote: > > > On Tue, Sep 18, 2018 at 12:17:41 +0900, Rin Okuyama wrote: > > > > > > >

Re: CVS commit: src/sys/dev/hpc

2018-09-18 Thread Valery Ushakov
On Tue, Sep 18, 2018 at 18:52:34 +0900, Rin Okuyama wrote: > On 2018/09/18 18:21, Valery Ushakov wrote: > > On Tue, Sep 18, 2018 at 12:17:41 +0900, Rin Okuyama wrote: > > > > > > @@ -278,8 +279,10 @@ hpckbd_keymap_setup(struct hpckbd_core * > > > >

Re: CVS commit: src/sys/dev/hpc

2018-09-18 Thread Valery Ushakov
On Tue, Sep 18, 2018 at 18:16:05 +0900, Rin Okuyama wrote: > Just curious; why comment lines within 80 char column are not > allowed for this file? Just cosmetic reasons? 80 chars is "hard" limit, but it's convenient to use less than that if you can so that you have extra space for things like

Re: CVS commit: src/sys/dev/hpc

2018-09-18 Thread Valery Ushakov
On Tue, Sep 18, 2018 at 12:17:41 +0900, Rin Okuyama wrote: > > @@ -278,8 +279,10 @@ hpckbd_keymap_setup(struct hpckbd_core * > > * XXX The way this is done is really wrong. The __UNCONST() > > * is a hint as to what is wrong. This actually ends up modifying > > * initialized data

Re: CVS commit: src/external/bsd/dhcpcd/dist/src

2018-08-03 Thread Valery Ushakov
On Fri, Aug 03, 2018 at 18:08:24 +0300, Valery Ushakov wrote: > On Fri, Aug 03, 2018 at 15:54:24 +0200, Martin Husemann wrote: > > > On Fri, Aug 03, 2018 at 08:28:55PM +0700, Robert Elz wrote: > > > Where is the signed arithmetic that was supposedly a probem? > >

Re: CVS commit: src/external/bsd/dhcpcd/dist/src

2018-08-03 Thread Valery Ushakov
On Fri, Aug 03, 2018 at 15:54:24 +0200, Martin Husemann wrote: > On Fri, Aug 03, 2018 at 08:28:55PM +0700, Robert Elz wrote: > > Where is the signed arithmetic that was supposedly a probem? > > Ah, stupid C integer promotion rules. uint16_t is promoted to int > here, not unsigned int or size_t.

Re: CVS commit: src/sys/compat/sys

2018-06-15 Thread Valery Ushakov
On Fri, Jun 15, 2018 at 17:11:49 +0300, Valery Ushakov wrote: > It seems that with restrict we can just memset the whole struct and > the compiler will elide the memset completely when there's no pad to > scrub. Alas, with the real code the compiler cannot elide the memset. :( -uwe

  1   2   >