Re: CVS commit: src/sys/ufs/ufs

2014-05-22 Thread YAMAMOTO Takashi
. how about adding a version field so that it won't happen again? YAMAMOTO Takashi

Re: CVS commit: src/lib/libc

2013-08-21 Thread YAMAMOTO Takashi
On Wed, Aug 21, 2013 at 12:43:58AM +, YAMAMOTO Takashi wrote: On Tue, Aug 20, 2013 at 03:31:01PM +, YAMAMOTO Takashi wrote: On Tue, Aug 20, 2013 at 09:31:18AM +, YAMAMOTO Takashi wrote: Module Name: src Committed By:joerg Date:Mon Aug 19 22:43

Re: CVS commit: src

2013-08-20 Thread YAMAMOTO Takashi
Removed Files: src/lib/libc/nls: _catclose.c _catgets.c _catopen.c Log Message: Add nl_langinfo_l, catopen_l and wcsftime_l. is catopen_l your invention? YAMAMOTO Takashi To generate a diff of this commit: cvs rdiff -u -r1.9 -r1.10 src/include/langinfo.h cvs rdiff -u -r1.12 -r1.13

Re: CVS commit: src/lib/libc

2013-08-20 Thread YAMAMOTO Takashi
of locale.cache. why? YAMAMOTO Takashi To generate a diff of this commit: cvs rdiff -u -r1.12 -r1.13 src/lib/libc/citrus/citrus_lc_ctype.c cvs rdiff -u -r1.24 -r1.25 src/lib/libc/gen/isctype.c cvs rdiff -u -r1.18 -r1.19 src/lib/libc/locale/global_locale.c cvs rdiff -u -r1.12 -r1.13 src

Re: CVS commit: src/lib/libc

2013-08-20 Thread YAMAMOTO Takashi
On Tue, Aug 20, 2013 at 09:31:18AM +, YAMAMOTO Takashi wrote: Module Name: src Committed By: joerg Date: Mon Aug 19 22:43:28 UTC 2013 Modified Files: src/lib/libc/citrus: citrus_lc_ctype.c src/lib/libc/gen: isctype.c src/lib/libc/locale

Re: CVS commit: src

2013-08-20 Thread YAMAMOTO Takashi
On Tue, Aug 20, 2013 at 09:30:12AM +, YAMAMOTO Takashi wrote: Module Name: src Committed By: joerg Date: Mon Aug 19 08:03:34 UTC 2013 Modified Files: src/include: langinfo.h nl_types.h wchar.h src/lib/libc/include: namespace.h src/lib/libc

Re: CVS commit: src

2013-04-23 Thread YAMAMOTO Takashi
On Wed, Apr 17, 2013 at 06:32:30AM +, YAMAMOTO Takashi wrote: Module Name: src Committed By: joerg Date: Tue Apr 16 21:44:08 UTC 2013 Modified Files: src/common/lib/libc/stdlib: _strtol.h _strtoul.h strtoll.c strtoull.c strtoumax.c src

Re: CVS commit: src/lib/libc/locale

2013-04-21 Thread YAMAMOTO Takashi
On Thu, Apr 18, 2013 at 06:58:42AM +, YAMAMOTO Takashi wrote: On Tue, Apr 16, 2013 at 11:34:52PM +, YAMAMOTO Takashi wrote: On Tue, Apr 16, 2013 at 11:39:50PM +0900, Takehiko NOZAKI wrote: so that the struct _locale __C_locale in libc is much more wasteful. I should add

Re: CVS commit: src/lib/libc/locale

2013-04-18 Thread YAMAMOTO Takashi
On Tue, Apr 16, 2013 at 11:34:52PM +, YAMAMOTO Takashi wrote: On Tue, Apr 16, 2013 at 11:39:50PM +0900, Takehiko NOZAKI wrote: so that the struct _locale __C_locale in libc is much more wasteful. I should add that it is an internal detail and the way the composed C locale is stored

Re: CVS commit: src

2013-04-17 Thread YAMAMOTO Takashi
bump. is it safe to make tools use host's strtoul? YAMAMOTO Takashi To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.5 src/common/lib/libc/stdlib/_strtol.h \ src/common/lib/libc/stdlib/_strtoul.h cvs rdiff -u -r1.6 -r1.7 src/common/lib/libc/stdlib/strtoll.c cvs rdiff -u

Re: CVS commit: src/lib/libc/locale

2013-04-16 Thread YAMAMOTO Takashi
the extension easily, and 3) a portable application can trivially have a fallback implementation using newlocale+pthread_once. YAMAMOTO Takashi

Re: CVS commit: src/lib/libc/locale

2013-04-15 Thread YAMAMOTO Takashi
. YAMAMOTO Takashi Joerg

Re: CVS commit: src/lib/libpthread

2013-03-31 Thread YAMAMOTO Takashi
In article 20130329032804.23b1514a...@mail.netbsd.org, YAMAMOTO Takashi y...@mwd.biglobe.ne.jp wrote: mono escaping its scope? Yes, I already added it to lwp_park to avoid the hack but not using the syscall yet until we decide what we need to pass to lwp_park to avoid priority inversion

Re: CVS commit: src/lib/libpthread

2013-03-28 Thread YAMAMOTO Takashi
: pullup to 6. mono escaping its scope? YAMAMOTO Takashi To generate a diff of this commit: cvs rdiff -u -r1.59 -r1.60 src/lib/libpthread/pthread_cond.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.

Re: CVS commit: src/sys/kern

2013-03-11 Thread YAMAMOTO Takashi
there's contention and a pool doesn't have emptygroups would do. depending on mutex_init's arguments (type and ipl), a mutex can be spin or adaptive. rump mutex implementation should honor the behaviour, i guess. YAMAMOTO Takashi To generate a diff of this commit: cvs rdiff -u -r1.199

Re: CVS commit: src/sys/sys

2013-03-10 Thread YAMAMOTO Takashi
: (EXPR) ? 1 : -1; })] any comments from C lawyers? YAMAMOTO Takashi Module Name: src Committed By: pooka Date: Wed Mar 6 18:16:58 UTC 2013 Modified Files: src/sys/sys: ucontext.h Log Message: Move CTASSERT a few lines down so as to not collide with the CTASSERT in rtsock.c

Re: CVS commit: src/sys

2012-11-30 Thread YAMAMOTO Takashi
in the anonymous or reserved port allocation. what's the purpose of this feature? fd_set doesn't seem like an appropriate structure for this. YAMAMOTO Takashi To generate a diff of this commit: cvs rdiff -u -r1.302 -r1.303 src/sys/netinet/ip_input.c cvs rdiff -u -r1.1 -r1.2 src/sys/netinet

Re: CVS commit: src/lib/libpthread

2012-11-21 Thread YAMAMOTO Takashi
functions, to one that invalidates values of keys in other threads when pthread_key_delete() is called. This fixes chromium, which expects pthread_key_delete() to do cleanup in all threads. i think pthread_key_delete should not call dtor. YAMAMOTO Takashi To generate a diff of this commit

Re: CVS commit: src

2012-07-03 Thread YAMAMOTO Takashi
directories and make the usermode kernels buildalbe under build.sh. The resulting kernels are build and packaged correctly as are the associated modules. this seems to break cross build. (target amd64, host i386) YAMAMOTO Takashi cc1: warnings being treated as errors /siro/nbsd/src/sys/arch

Re: CVS commit: src

2012-04-22 Thread YAMAMOTO Takashi
Log Message: PR/46360: YAMAMOTO Takashi: Restore NetBSD-5 compatibility with putenv() copying the passed string (which is not ToG compliant), instead of using it directly in the environment arrat as it should. Needs to be pulled up to NetBSd-6. thanks for a quick fix. but why the compat code

Re: CVS commit: [matt-nb5-mips64] src/sys/uvm

2012-04-12 Thread YAMAMOTO Takashi
On Apr 11, 2012, at 7:34 PM, YAMAMOTO Takashi wrote: hi, Module Name:src Committed By: matt Date: Thu Apr 12 01:40:27 UTC 2012 Modified Files: src/sys/uvm [matt-nb5-mips64]: uvm_extern.h uvm_fault.c uvm_km.c uvm_meter.c uvm_pdaemon.c

Re: CVS commit: [matt-nb5-mips64] src/sys/uvm

2012-04-11 Thread YAMAMOTO Takashi
Message: Separate object-less anon pages out of the active list if there is no swap device. Make uvm_reclaimable and uvm.*estimatable understand colors and kmem allocations. i like the idea. - why the queue is inside the pdpolicy? - why don't you use PQ_SWAPBACKED? YAMAMOTO Takashi

Re: CVS commit: src/lib/libc

2012-03-01 Thread YAMAMOTO Takashi
hi, Module Name: src Committed By: dholland Date: Fri Feb 24 16:06:39 UTC 2012 Modified Files: src/lib/libc: shlib_version Log Message: Note that gets() is finally dead in C11 and can be removed if we ever bump libc. it doesn't sound good or realistic to me. YAMAMOTO

Re: CVS commit: src/sys/kern

2012-02-15 Thread YAMAMOTO Takashi
that never made it to userland. please take a look at uvm_proc_exit(). it borrows proc0.p_vmspace for exiting process. while which of these methods is cleaner is probably a matter of taste, these two cases should use the same method. YAMAMOTO Takashi To generate a diff of this commit: cvs

Re: CVS commit: src

2012-01-30 Thread YAMAMOTO Takashi
hi, is the change in conf/std still necessary? YAMAMOTO Takashi Module Name: src Committed By: tls Date: Sat Dec 17 20:05:40 UTC 2011 Modified Files: src/share/man/man4: rnd.4 src/share/man/man9: cprng.9 rnd.9 src/sys/conf: files src/sys/crypto

Re: CVS commit: src/sys/kern

2012-01-30 Thread YAMAMOTO Takashi
simply moving the #ifdef blocks to callers? YAMAMOTO Takashi To generate a diff of this commit: cvs rdiff -u -r1.40 -r1.41 src/sys/kern/subr_kmem.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.

Re: CVS commit: src/sys

2011-12-28 Thread YAMAMOTO Takashi
hi, On Dec 21, 5:07am, y...@mwd.biglobe.ne.jp (YAMAMOTO Takashi) wrote: -- Subject: Re: CVS commit: src/sys | why? | i thought the reason of having this as a separate member was performance. All the code paths that use NBIO check bits in so_state... I would like to see the benchmark

Re: CVS commit: src/sys

2011-12-20 Thread YAMAMOTO Takashi
: fifo_vnops.c src/sys/netiso: tp_usrreq.c src/sys/sys: socket.h socketvar.h Log Message: - Eliminate so_nbio and turn it into a bit SS_NBIO in so_state. why? i thought the reason of having this as a separate member was performance. YAMAMOTO Takashi - Introduce MSG_NBIO so

Re: CVS commit: src/sys/fs/union

2011-11-21 Thread YAMAMOTO Takashi
hi, do you have any plan on fs/unionfs? eg. remove it YAMAMOTO Takashi Module Name: src Committed By: hannken Date: Mon Nov 21 18:29:23 UTC 2011 Modified Files: src/sys/fs/union: union.h union_subr.c union_vfsops.c union_vnops.c Log Message: Replace flag based union

Re: CVS commit: src/sys/arch/i386/i386

2011-11-20 Thread YAMAMOTO Takashi
hi, On Oct 31, 2011, at 1:42 PM, YAMAMOTO Takashi wrote: Module Name: src Committed By:yamt Date:Mon Oct 31 12:42:53 UTC 2011 Modified Files: src/sys/arch/i386/i386: dumpsys.c Log Message: dumpsys_seg: don't overwrite the previous mapping

Re: CVS commit: [yamt-pagecache] src/sys

2011-11-20 Thread YAMAMOTO Takashi
Module Name: src Committed By: yamt Date: Sun Nov 20 10:52:35 UTC 2011 Modified Files: src/sys/kern [yamt-pagecache]: init_main.c src/sys/uvm [yamt-pagecache]: uvm.h uvm_extern.h uvm_init.c uvm_loan.c uvm_meter.c uvm_page.c uvm_page.h uvm_page_status.c

Re: CVS commit: src/sys/nfs

2011-11-14 Thread YAMAMOTO Takashi
YAMAMOTO Takashi To generate a diff of this commit: cvs rdiff -u -r1.160 -r1.161 src/sys/nfs/nfs_serv.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.

Re: CVS commit: src/sys/net

2011-11-07 Thread YAMAMOTO Takashi
On Sun, Nov 06, 2011 at 11:43:06PM +, YAMAMOTO Takashi wrote: hi, isn't PR/40516 a problem for this particular usage? Probably. Should we use Andrew's version for now? matt, can you take a look? YAMAMOTO Takashi Dave -- David Young OJC Technologies is now Pixo

Re: CVS commit: src/sys/net

2011-11-06 Thread YAMAMOTO Takashi
hi, isn't PR/40516 a problem for this particular usage? YAMAMOTO Takashi Module Name: src Committed By: dyoung Date: Wed Nov 2 01:17:59 UTC 2011 Modified Files: src/sys/net: if_gre.c if_gre.h Log Message: For simplicity's sake, use pcq(9) instead of my own circular

Re: CVS commit: src/lib/libterminfo

2011-11-02 Thread YAMAMOTO Takashi
the same file using the -p option, there is no longer a need to store these files in CVS. i guess you need to tweak tools/tic? YAMAMOTO Takashi To generate a diff of this commit: cvs rdiff -u -r1.17 -r1.18 src/lib/libterminfo/Makefile cvs rdiff -u -r1.2 -r0 src/lib/libterminfo

Re: CVS commit: src/sys/net

2011-11-02 Thread YAMAMOTO Takashi
hi, On Thu, Oct 20, 2011 at 06:59:42AM +, YAMAMOTO Takashi wrote: hi, Module Name: src Committed By: dyoung Date: Wed Oct 19 01:34:37 UTC 2011 Modified Files: src/sys/net: if.c if.h Log Message: Start to untangle the ifnet ioctls mess

Re: CVS commit: src/sys/arch/m68k

2011-10-31 Thread YAMAMOTO Takashi
with this pmap, i think pool_allocator_meta is ok. YAMAMOTO Takashi --- Izumi Tsutsui

Re: CVS commit: src/sys/arch/m68k

2011-10-30 Thread YAMAMOTO Takashi
hi, is a nointr pool safe for this pmap? iirc x86 pmap allocates pv entries from kmem_map to avoid this kind of recursion. YAMAMOTO Takashi Module Name: src Committed By: tsutsui Date: Sat Oct 29 18:26:20 UTC 2011 Modified Files: src/sys/arch/m68k/include: pmap_motorola.h

Re: CVS commit: src/sys/kern

2011-10-23 Thread YAMAMOTO Takashi
owned by caller (string could be allocated on stack). what needs it? YAMAMOTO Takashi To generate a diff of this commit: cvs rdiff -u -r1.31 -r1.32 src/sys/kern/subr_workqueue.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant

Re: CVS commit: src/sys/net

2011-10-21 Thread YAMAMOTO Takashi
? YAMAMOTO Takashi To generate a diff of this commit: cvs rdiff -u -r1.251 -r1.252 src/sys/net/if.c cvs rdiff -u -r1.151 -r1.152 src/sys/net/if.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.

Re: CVS commit: src/lib/libutil

2011-10-21 Thread YAMAMOTO Takashi
hi, Module Name: src Committed By: christos Date: Fri Oct 21 02:05:36 UTC 2011 Modified Files: src/lib/libutil: Makefile Log Message: Add proc_compare you forgot to commit proc_compare.3? YAMAMOTO Takashi To generate a diff of this commit: cvs rdiff -u -r1.67

Re: CVS commit: src/sys/fs/puffs

2011-10-12 Thread YAMAMOTO Takashi
hi, YAMAMOTO Takashi y...@mwd.biglobe.ne.jp wrote: if it trapped forever, it's a bug and should be fixed. my point was that your change didn't fix the bug. blocking ioflush is merely a symptom. The problem with userland filesystems is that we may have little control as theses may

Re: CVS commit: src/sys/fs/puffs

2011-10-11 Thread YAMAMOTO Takashi
hi, YAMAMOTO Takashi y...@mwd.biglobe.ne.jp wrote: Sure ioflush do not directly free memory, but vnodes' dirty page use memory, don't they? If ioflush stops working, is pageadaemon able to pageout that kind of memory? pagedaemon flushes dirty pages by itself, yes. So

Re: CVS commit: src/sys/fs/puffs

2011-09-23 Thread YAMAMOTO Takashi
hi, YAMAMOTO Takashi y...@mwd.biglobe.ne.jp wrote: This avoids deadlocks in the following situations: 1) when memory is low: ioflush waits the fileystem, the fielsystem waits for memory can you explain how it is a problem? As I understand, one way to free memory is to flush vnode

Re: CVS commit: src/sys/fs/puffs

2011-09-23 Thread YAMAMOTO Takashi
hi, YAMAMOTO Takashi y...@mwd.biglobe.ne.jp wrote: as i told you a few times, ioflush is not a thread to free memory. pagedaemon is. Sure ioflush do not directly free memory, but vnodes' dirty page use memory, don't they? If ioflush stops working, is pageadaemon able to pageout

Re: CVS commit: src/sys/fs/puffs

2011-09-22 Thread YAMAMOTO Takashi
the filesystem. This avoids deadlocks in the following situations: 1) when memory is low: ioflush waits the fileystem, the fielsystem waits for memory can you explain how it is a problem? YAMAMOTO Takashi 2) when the filesystem does not respond (e.g.: network outage ona distributed

Re: CVS commit: src/sys

2011-09-22 Thread YAMAMOTO Takashi
in this way. please revert. YAMAMOTO Takashi To generate a diff of this commit: cvs rdiff -u -r1.156 -r1.157 src/sys/fs/puffs/puffs_vnops.c cvs rdiff -u -r1.46 -r1.47 src/sys/miscfs/syncfs/sync_subr.c Please note that diffs are not public domain; they are subject to the copyright notices

Re: CVS commit: src/sys/kern

2011-08-10 Thread YAMAMOTO Takashi
On Wed, Aug 10, 2011 at 03:10:13AM +, YAMAMOTO Takashi wrote: Log Message: Fail namei immediately if searchdir is unlinked / has been rmdir'd. Do this by checking if v_size == 0. Should fix PR 44658 (and PR 32661). why is this necessary? can't we just let VOP_LOOKUP fail

Re: CVS commit: src

2011-08-10 Thread YAMAMOTO Takashi
. YAMAMOTO Takashi To generate a diff of this commit: cvs rdiff -u -r1.55 -r1.56 src/bin/cp/cp.c cvs rdiff -u -r1.39 -r1.40 src/bin/cp/utils.c cvs rdiff -u -r1.41 -r1.42 src/bin/mv/mv.c cvs rdiff -u -r1.1651 -r1.1652 src/distrib/sets/lists/comp/mi cvs rdiff -u -r1.178 -r1.179 src/lib/libc/gen

Re: CVS commit: src

2011-08-10 Thread YAMAMOTO Takashi
hi, On Wed, Aug 10, 2011 at 08:59:48AM +, YAMAMOTO Takashi wrote: is extattr_namespace_access really necessary? uid-based priviledge check in userland is often a mistake. For now it duplicates the same simple access check as in kernel: system attributes are restricted to root

Re: CVS commit: src/sys/uvm

2011-08-10 Thread YAMAMOTO Takashi
[ moving to tech-kern ] hi, y...@mwd.biglobe.ne.jp (YAMAMOTO Takashi) wrote: Here is the updated patch after your changes: http://www.netbsd.org/~rmind/uvm_anon_freelst2.diff As you noted, uvm_anfree() can temporarily release the amap lock - that can happen in amap_copy

Re: CVS commit: src/sys/kern

2011-08-09 Thread YAMAMOTO Takashi
). why is this necessary? can't we just let VOP_LOOKUP fail? the v_size == 0 check sounds wrong. does it work for eg. nfs? YAMAMOTO Takashi To generate a diff of this commit: cvs rdiff -u -r1.186 -r1.187 src/sys/kern/vfs_lookup.c Please note that diffs are not public domain

Re: CVS commit: src/sys/uvm

2011-07-25 Thread YAMAMOTO Takashi
hi, y...@mwd.biglobe.ne.jp (YAMAMOTO Takashi) wrote: Log Message: amap_copy(): Keep the source amap locked until its lock has been copied. btw, this code seems to assume that uvm_anfree does not release the lock even temporarily while the comment on uvm_anfree1 says

Re: CVS commit: src/sys/uvm

2011-07-05 Thread YAMAMOTO Takashi
hi, y...@mwd.biglobe.ne.jp (YAMAMOTO Takashi) wrote: Module Name: src Committed By: hannken Date: Mon Jun 27 15:56:37 UTC 2011 Modified Files: src/sys/uvm: uvm_amap.c Log Message: amap_copy(): Keep the source amap locked until its lock has been

Re: CVS commit: src/sys/uvm

2011-06-27 Thread YAMAMOTO Takashi
the lock even temporarily while the comment on uvm_anfree1 says the opposite. YAMAMOTO Takashi Kernel assertion anon-an_lock == amap-am_lock no longer fails. Ok: Mindaugas Rasiukevicius rm...@netbsd.org To generate a diff of this commit: cvs rdiff -u -r1.99 -r1.100 src/sys/uvm/uvm_amap.c

Re: CVS commit: src/sys/net

2011-06-23 Thread YAMAMOTO Takashi
smpls_len. First label encountered is BoS. XXX: need to do the same for LSE and this feature needs to be documented. what will use this? (just curious) YAMAMOTO Takashi To generate a diff of this commit: cvs rdiff -u -r1.5 -r1.6 src/sys/net/if_mpls.c Please note that diffs

Re: CVS commit: src/sys/netinet

2011-04-25 Thread YAMAMOTO Takashi
hi, On Thu, Apr 14, 2011 at 07:03:49AM +, YAMAMOTO Takashi wrote: please just weaken the assertion and clear the flag, rather than complicating the code. I'm not quite sure I see exactly what you would like the code to look like. What we have now: /* * We may

Re: CVS commit: src/sys

2011-04-24 Thread YAMAMOTO Takashi
by network card drivers. - who clears the flag? - probably it would be better to have separate flags for tx and rx. (i thought ETHERCAP_VLAN_HWTAGGING was for transmitting, but our tree seems inconsistent.) YAMAMOTO Takashi To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3 src/sys

Re: CVS commit: src/sys/netinet

2011-04-14 Thread YAMAMOTO Takashi
and clear the flag, rather than complicating the code. YAMAMOTO Takashi To generate a diff of this commit: cvs rdiff -u -r1.205 -r1.206 src/sys/netinet/ip_output.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.

Re: CVS commit: src/sys/kern

2011-03-15 Thread YAMAMOTO Takashi
hi, On 12.03.11 08:16, YAMAMOTO Takashi wrote: Module Name: src Committed By:yamt Date:Sat Mar 12 07:16:50 UTC 2011 Hi, nice to read/hear you're alive. Christoph thank you. YAMAMOTO Takashi

Re: CVS commit: src

2011-03-01 Thread YAMAMOTO Takashi
hi, Hello, y...@mwd.biglobe.ne.jp (YAMAMOTO Takashi) wrote: Log Message: an implementation of radix tree. the idea from linux. How is that different from ptree? while i'm not familiar with ptree... Patricia/Radix tree added by Matt (see src/common/lib/libc/gen/ptree.c

Re: CVS commit: src

2011-02-23 Thread YAMAMOTO Takashi
hi, On Wed, Feb 23, 2011 at 01:33:05AM +, YAMAMOTO Takashi wrote: hi, On Feb 22, 2011, at 1:31 PM, YAMAMOTO Takashi wrote: Module Name: src Committed By: yamt Date: Tue Feb 22 21:31:16 UTC 2011 Added Files: src/common/lib/libc/gen: radixtree.c

Re: CVS commit: src

2011-02-23 Thread YAMAMOTO Takashi
hi, On Thu, Feb 24, 2011 at 12:12:50AM +, YAMAMOTO Takashi wrote: I wrote: Aren't both ptree and radixtree missing documentation? right. both of them are work-in-progress piece of code. well, at least radixtree is. are you suggesting something? Yes: commit new libraries

Re: CVS commit: src/lib/librumphijack

2011-02-22 Thread YAMAMOTO Takashi
On Mon Feb 21 2011 at 23:19:47 +, YAMAMOTO Takashi wrote: Module Name: src Committed By: pooka Date: Mon Feb 7 19:34:39 UTC 2011 Modified Files: src/lib/librumphijack: hijack.c Log Message: Force gcc to generate a stack frame for the call

Re: CVS commit: src

2011-02-22 Thread YAMAMOTO Takashi
hi, On Feb 22, 2011, at 1:31 PM, YAMAMOTO Takashi wrote: Module Name: src Committed By:yamt Date:Tue Feb 22 21:31:16 UTC 2011 Added Files: src/common/lib/libc/gen: radixtree.c src/sys/sys: radixtree.h Log Message: an implementation of radix tree

Re: CVS commit: src/lib/librumphijack

2011-02-21 Thread YAMAMOTO Takashi
Thing happened. do you want -fno-optimize-sibling-calls ? YAMAMOTO Takashi To generate a diff of this commit: cvs rdiff -u -r1.31 -r1.32 src/lib/librumphijack/hijack.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.

Re: CVS commit: src/lib/libc/time

2011-02-13 Thread YAMAMOTO Takashi
hi, On Feb 11, 11:47pm, y...@mwd.biglobe.ne.jp (YAMAMOTO Takashi) wrote: -- Subject: Re: CVS commit: src/lib/libc/time | hi, | | Module Name: src | Committed By: christos | Date: Thu Jan 6 02:41:34 UTC 2011 | | Modified Files: |src/lib/libc/time

Re: CVS commit: src/lib/libc/time

2011-02-11 Thread YAMAMOTO Takashi
will unfortunately persist, even if later calls to those functions succeed. Move the EOVERFLOW setting to the top level calls. did you forget to update gmtime/gmtime_r/offtime/offtime_r? YAMAMOTO Takashi To generate a diff of this commit: cvs rdiff -u -r1.50 -r1.51 src/lib/libc/time/localtime.c

Re: CVS commit: src/share/man/man9

2011-01-25 Thread YAMAMOTO Takashi
hi, How about ABI? KASSERT(9) should preserve ABI IMO. sorry, i'm not sure what you mean. can you explain? YAMAMOTO Takashi

Re: CVS commit: src/sys/uvm

2011-01-20 Thread YAMAMOTO Takashi
hi, do you have any plan to use pg-offset of anon pages, or is it an unnecessary side-effect? YAMAMOTO Takashi Module Name: src Committed By: matt Date: Tue Jan 4 08:26:33 UTC 2011 Modified Files: src/sys/uvm: uvm_extern.h uvm_fault.c uvm_km.c uvm_page.c Log Message

Re: CVS commit: src/sys/uvm

2011-01-16 Thread YAMAMOTO Takashi
hi, (Just in case, have you read my paper?) which paper? i guess no. http://uebayasi.dyndns.org/~uebayasi/tmp/xip.pdf i will put it on my todo list. thanks. YAMAMOTO Takashi

Re: CVS commit: src/sys/kern

2011-01-10 Thread YAMAMOTO Takashi
but dangerous for data integrity). From simon a long while back. i don't think this kind of knob should be system global. are they merely for debug? YAMAMOTO Takashi To generate a diff of this commit: cvs rdiff -u -r1.38 -r1.39 src/sys/kern/vfs_wapbl.c Please note that diffs are not public

Re: CVS commit: src/tests/fs/common

2011-01-10 Thread YAMAMOTO Takashi
hi, On Thu, Jan 06, 2011 at 12:53:28AM +, YAMAMOTO Takashi wrote: (one nfsro test currently fails with EROFS vs. EACCES. Hopefully someone else can debate the correct errno) the NFS ACCESS procedure, which is used for open time permission checks, does not have a way

Re: CVS commit: src/tests/fs/common

2011-01-05 Thread YAMAMOTO Takashi
is used for open time permission checks, does not have a way to distinguish EROFS and EACCES. ie. EACCES is the expected behaviour in this case. YAMAMOTO Takashi To generate a diff of this commit: cvs rdiff -u -r1.23 -r1.24 src/tests/fs/common/h_fsmacros.h Please note that diffs are not public

Re: CVS commit: src/sys/uvm

2011-01-04 Thread YAMAMOTO Takashi
this sentence? (Just in case, have you read my paper?) which paper? i guess no. YAMAMOTO Takashi

Re: CVS commit: src/sys/uvm

2010-12-21 Thread YAMAMOTO Takashi
hi, Could you ack this discussion? sorry for dropping a ball. On Tue, Dec 07, 2010 at 01:19:46AM +0900, Masao Uebayashi wrote: On Thu, Nov 25, 2010 at 11:32:39PM +, YAMAMOTO Takashi wrote: [ adding cc: tech-kern@ ] hi, On Wed, Nov 24, 2010 at 11:26:39PM -0800, Matt Thomas

Re: CVS commit: src/sys/kern

2010-12-19 Thread YAMAMOTO Takashi
hi, On Fri Dec 17 2010 at 22:34:04 +, YAMAMOTO Takashi wrote: Module Name: src Committed By:yamt Date:Fri Dec 17 22:34:04 UTC 2010 Modified Files: src/sys/kern: vfs_lookup.c Log Message: - lookup_once: when crossing a mount point, don't keep the parent

Re: CVS commit: src/sys/uvm

2010-11-25 Thread YAMAMOTO Takashi
[ adding cc: tech-kern@ ] hi, On Wed, Nov 24, 2010 at 11:26:39PM -0800, Matt Thomas wrote: On Nov 24, 2010, at 10:47 PM, Masao Uebayashi wrote: On Thu, Nov 25, 2010 at 05:44:21AM +, YAMAMOTO Takashi wrote: hi, On Thu, Nov 25, 2010 at 04:18:25AM +, YAMAMOTO Takashi wrote

Re: CVS commit: src/sys/kern

2010-11-24 Thread YAMAMOTO Takashi
hi, Hello, Sorry for late reply. y...@mwd.biglobe.ne.jp (YAMAMOTO Takashi) wrote: how about the attached patch? Consider offset = (INT64_MAX - PAGE_SIZE) and len = PAGE_SIZE. That would still panic.. heh, right. then, how about: if (round_page(offset

Re: CVS commit: src/sys/uvm

2010-11-24 Thread YAMAMOTO Takashi
hi, - what's VM_PHYSSEG_OP_PG? - why *offp calculation is done in _p functions, rather than the caller? YAMAMOTO Takashi Module Name: src Committed By: uebayasi Date: Sun Nov 14 15:06:34 UTC 2010 Modified Files: src/sys/uvm: uvm_page.c uvm_page.h uvm_pglist.c Log

Re: CVS commit: src/sys/uvm

2010-11-24 Thread YAMAMOTO Takashi
hi, Hi, thanks for review. On Thu, Nov 25, 2010 at 01:58:04AM +, YAMAMOTO Takashi wrote: hi, - what's VM_PHYSSEG_OP_PG? It's to lookup vm_physseg by struct vm_page *, relying on that struct vm_page *[] is allocated linearly. It'll be used to remove vm_page::phys_addr as we

Re: CVS commit: src/sys/uvm

2010-11-24 Thread YAMAMOTO Takashi
hi, On Thu, Nov 25, 2010 at 04:18:25AM +, YAMAMOTO Takashi wrote: hi, Hi, thanks for review. On Thu, Nov 25, 2010 at 01:58:04AM +, YAMAMOTO Takashi wrote: hi, - what's VM_PHYSSEG_OP_PG? It's to lookup vm_physseg by struct vm_page *, relying on that struct vm_page

Re: CVS commit: src/sys/kern

2010-11-11 Thread YAMAMOTO Takashi
incorrect and makes putpages panic. note that round_page(INT64_MAX) is negative. how about the attached patch? YAMAMOTO Takashi Thanks to jakllsch@ for debug info. To generate a diff of this commit: cvs rdiff -u -r1.17 -r1.18 src/sys/kern/sys_descrip.c Please note that diffs are not public

Re: CVS commit: src/sys/kern

2010-11-11 Thread YAMAMOTO Takashi
hi, On Thu, Nov 11, 2010 at 02:10:00PM +, YAMAMOTO Takashi wrote: hi, Module Name: src Committed By: rmind Date: Wed Oct 27 02:58:05 UTC 2010 Modified Files: src/sys/kern: sys_descrip.c Log Message: do_posix_fadvise: check for a negative

Re: CVS commit: src/sys/kern

2010-11-11 Thread YAMAMOTO Takashi
hi, y...@mwd.biglobe.ne.jp (YAMAMOTO Takashi) wrote: hi, Module Name: src Committed By: rmind Date: Wed Oct 27 02:58:05 UTC 2010 Modified Files: src/sys/kern: sys_descrip.c Log Message: do_posix_fadvise: check for a negative length; truncate

Re: CVS commit: src/sys/kern

2010-11-11 Thread YAMAMOTO Takashi
hi, y...@mwd.biglobe.ne.jp (YAMAMOTO Takashi) wrote: hi, Module Name: src Committed By: rmind Date: Wed Oct 27 02:58:05 UTC 2010 Modified Files: src/sys/kern: sys_descrip.c Log Message: do_posix_fadvise: check for a negative length; truncate

Re: CVS commit: src/sys/net/agr

2010-05-26 Thread YAMAMOTO Takashi
state variables that need it. can you explain why they need to be volatile? aren't they protected by a mutex? btw, i'm not sure why this driver needs this complicate locking. i guess it's better to (re?)design locking protocol for ifioctl before putting this complicity to drivers. YAMAMOTO Takashi

Re: CVS commit: src/sys/dev

2010-04-15 Thread YAMAMOTO Takashi
for the old ioctl size. Detect and error files which are definitely sparse (va_bytes va_size). please revert this part of the change. because: - the check doesn't work for certain filesystems. eg. zfs - sparse files work fine in some cases. eg. read-only usage, nfs YAMAMOTO Takashi

Re: CVS commit: [uebayasi-xip] src/sys/miscfs/genfs

2010-03-15 Thread YAMAMOTO Takashi
, which is beyond filesystem's task. it doesn't sound convincing to me, given that you have a separate copy of genfs_getpages for xip. YAMAMOTO Takashi Why not adding pgo_get_xip - because I didn't think it's worth adding it. XIP is transparent to other UVM pagers. (And only used by vnode

Re: CVS commit: src/sys

2010-03-15 Thread YAMAMOTO Takashi
merge of what? your xip branch? it's better to do it before the merge if you want people review it. I clean up it today then. Masao done? YAMAMOTO Takashi

CVS commit: src/external/bsd/iscsi/dist

2010-03-02 Thread YAMAMOTO Takashi
Module Name:src Committed By: yamt Date: Wed Mar 3 00:44:52 UTC 2010 Modified Files: src/external/bsd/iscsi/dist/include: iscsiprotocol.h src/external/bsd/iscsi/dist/src/lib: disk.c target.c Log Message: fix multi-thread problems wrt read/write buffer. PR/42651.

CVS commit: src/external/bsd/iscsi/dist

2010-03-02 Thread YAMAMOTO Takashi
Module Name:src Committed By: yamt Date: Wed Mar 3 00:44:52 UTC 2010 Modified Files: src/external/bsd/iscsi/dist/include: iscsiprotocol.h src/external/bsd/iscsi/dist/src/lib: disk.c target.c Log Message: fix multi-thread problems wrt read/write buffer. PR/42651.

CVS commit: src/sys/sys

2010-03-02 Thread YAMAMOTO Takashi
Module Name:src Committed By: yamt Date: Wed Mar 3 00:45:55 UTC 2010 Modified Files: src/sys/sys: proc.h Log Message: comment To generate a diff of this commit: cvs rdiff -u -r1.295 -r1.296 src/sys/sys/proc.h Please note that diffs are not public domain; they are

CVS commit: src/sys/sys

2010-03-02 Thread YAMAMOTO Takashi
Module Name:src Committed By: yamt Date: Wed Mar 3 00:45:55 UTC 2010 Modified Files: src/sys/sys: proc.h Log Message: comment To generate a diff of this commit: cvs rdiff -u -r1.295 -r1.296 src/sys/sys/proc.h Please note that diffs are not public domain; they are

CVS commit: src/sys/kern

2010-03-02 Thread YAMAMOTO Takashi
Module Name:src Committed By: yamt Date: Wed Mar 3 00:47:31 UTC 2010 Modified Files: src/sys/kern: kern_exit.c kern_ktrace.c kern_resource.c kern_runq.c kern_sig.c kern_synch.c vfs_syscalls.c Log Message: remove redundant checks of PK_MARKER. To generate a

CVS commit: src/sys/kern

2010-03-02 Thread YAMAMOTO Takashi
Module Name:src Committed By: yamt Date: Wed Mar 3 00:47:31 UTC 2010 Modified Files: src/sys/kern: kern_exit.c kern_ktrace.c kern_resource.c kern_runq.c kern_sig.c kern_synch.c vfs_syscalls.c Log Message: remove redundant checks of PK_MARKER. To generate a

Re: CVS commit: src/sys

2010-02-23 Thread YAMAMOTO Takashi
merge. Give me one week... merge of what? your xip branch? it's better to do it before the merge if you want people review it. YAMAMOTO Takashi Masao

Re: CVS commit: [uebayasi-xip] src/sys/miscfs/genfs

2010-02-23 Thread YAMAMOTO Takashi
and pgo_get_xip? is it allowed to return both of device pages and normal pages mixed for a request? YAMAMOTO Takashi To generate a diff of this commit: cvs rdiff -u -r1.36 -r1.36.2.1 src/sys/miscfs/genfs/genfs_io.c Please note that diffs are not public domain; they are subject to the copyright

Re: CVS commit: [uebayasi-xip] src/sys/uvm

2010-02-23 Thread YAMAMOTO Takashi
)? YAMAMOTO Takashi To generate a diff of this commit: cvs rdiff -u -r1.153.2.7 -r1.153.2.8 src/sys/uvm/uvm_page.c cvs rdiff -u -r1.59.2.5 -r1.59.2.6 src/sys/uvm/uvm_page.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.

Re: CVS commit: src/sys

2010-02-16 Thread YAMAMOTO Takashi
hi, can you please add comments on each uvm_fault_* functions you introduced? eg. what uvm_fault_lower1 does is not clear from its name at all. to me, it isn't clear what was the purpose of the mechanical splitting of these functions. YAMAMOTO Takashi

  1   2   >