Re: CVS commit: src

On Tue, Oct 23, 2018 at 10:05:27PM +0900, Rin Okuyama wrote: > Well, it makes sense on one hand. But, on the other hand, your argument > can be very dangerous if it is abused; I really hate an attitude like > "Oh, discussion is falling into a bike shed! Let's commit it to shut them > up!" Of

Re: CVS commit: src/share/man/man9

On Mon, Oct 16, 2017 at 04:53:17PM +0300, Valery Ushakov wrote: > On Mon, Oct 16, 2017 at 11:53:00 +, Maya Rashish wrote: > > Modified Files: > > src/share/man/man9: byteorder.9 > > > > Log Message: > > Suggest to include the POSIX rather than BSD > > Section 9 is kernel internals, so

Re: CVS commit: src/sys/arch

I'm not randomly seeking out code to delete. I was poking at nearby code due to a bug report. I saw dead code, so I deleted it. I have some more changes to nearby code that I haven't committed / was debating.

Re: CVS commit: src/distrib

On Sun, Sep 17, 2017 at 09:51:31AM +0200, Martin Husemann wrote: > I haven't checked, but the other arch that imediately came to my mind > when doing this was VAX, and the CD image (including debug sets) fits > just fine there. > > Could you create a list of architectures where DVD is unlikely

Re: CVS import: xsrc/external/mit/fontconfig/dist

Now I get: $ fc-match anything Fontconfig warning: line 148: blank doesn't take any effect anymore. please remove it from your fonts.conf Vera.ttf: "Bitstream Vera Sans" "Roman" I can't find where the lines in fonts.conf come from. any ideas?

Re: CVS commit: xsrc/external/mit/libpciaccess/dist

On Tue, Aug 29, 2017 at 05:52:34AM +, matthew green wrote: > @@ -175,6 +179,9 @@ insert( uint16_t vendor ) > struct pci_id_node * child = > calloc( 1, sizeof( struct pci_id_node ) ); > > + if ( tree == NULL ) > + return NULL; > + >

Re: CVS commit: src/sys/ufs/ffs

On Sun, Aug 20, 2017 at 12:51:39PM +, Maya Rashish wrote: > - panic("%s: dup alloc ino=%" PRId64 " on %s: mode %x/%x " > + panic("%s: dup alloc ino=%" PRId64 " on %s: mode %o/%o " Can I do this in a panic message btw?

Re: CVS commit: src/sys/arch/mips/mips

spoiler alert: we can dedup a lot more > @@ -1288,10 +1295,7 @@ NESTED_NOPROFILE(MIPSX(user_reserved_ins > /* >* Save a minimum of registers to see if this is rdhwr $3,$29 >*/ > -#ifdef MIPS3_LOONGSON2 > - li k0, MIPS_DIAG_BTB_CLEAR | MIPS_DIAG_RAS_DISABLE > -

Re: CVS commit: src/sys/arch/amd64/conf

try to run 7.1 ifconfig on 8.0. without COMPAT_70 in the kernel, it won't run. Its non-compatibility is probably buried deep within a switch statement for a generic function. The only way we can reasonably make it work is: - lie about what compat is, and build it inot the kernel, which also

Re: CVS commit: src/sys/arch

On Fri, Aug 18, 2017 at 10:02:37AM +, Maxime Villard wrote: > Remove unused and broken code. On amd64 we won't want int3 from kernel > mode to be valid. > - /* > - * DTrace Function Boundary Trace (fbt) probes are triggered > - * by int3 (0xcc). > - */ Is there some other

Re: CVS commit: src

On Sat, Aug 12, 2017 at 07:35:08AM +, Maxime Villard wrote: > Module Name: src > Committed By: maxv > Date: Sat Aug 12 07:35:08 UTC 2017 > > Modified Files: > src/distrib/sets/lists/comp: md.amd64 md.i386 > src/sys/arch/i386/include: Makefile mcontext.h segments.h >

Re: CVS commit: src/sys/arch/evbmips/conf

On Tue, Aug 08, 2017 at 12:22:21PM +, Maya Rashish wrote: > This only need to be performed on kernel code, because only there we can have > accesses not translated/limited by TLB. For user code, it is impossible to > generate accesses to unwanted physical address. So it is safe. > > Also, to

Re: CVS commit: src/sys/arch

On Fri, Aug 04, 2017 at 12:26:01PM +0200, Maxime Villard wrote: > We can; but this would be an executable page at a fixed location, and by > definition it violates ASLR. Even more so if the page happens to contain > instruction patterns suitable for all kinds of exploits... linux seems to

Re: CVS commit: src/sys/ufs/lfs

> Log Message: > fix buffer overflow/KASSERT when cookies are supplied > lfs no longer uses the ffs-style struct direct, use the correct minimum > size For kicks, 'found by running COMPAT_LINUX', which does this (so does NFS). LFS still comes with this warning that is very hard to miss: WARNING:

Re: CVS commit: src/sys/arch/amd64/conf

paulg adds: This is not making GENERIC fail because COMPAT_43 is not really removed on it. $ nm /home/fly/amd/sys/arch/amd64/compile/GENERIC/netbsd |grep compat_43 80403485 T compat_43_netbsd32_fstat43 8040371a T compat_43_netbsd32_killpg 80403431 T

Re: CVS commit: src

On Tue, Aug 01, 2017 at 06:28:39PM +0200, Joerg Sonnenberger wrote: > Correct, do not remove obsolete entries from the set files without a > very good reason. This one is plain wrong. Thanks, I reverted that part.

Re: CVS commit: src

On Tue, Aug 01, 2017 at 01:57:03PM +, Maxime Villard wrote: > Module Name: src > Committed By: maxv > Date: Tue Aug 1 13:57:03 UTC 2017 > > Modified Files: > src/distrib/sets/lists/comp: md.amd64 md.i386 > Removed Files: > src/sys/arch/i386/include: svr4_machdep.h > >

Re: CVS commit: src/sys

On Sat, Jul 29, 2017 at 10:39:49AM +, Maxime Villard wrote: > Log Message: > Remove exec_aout support in compat_freebsd. The only reason we still have > compat_freebsd is because of tw_cli, and it is an elf32 binary (could test, > manuel sent it to me). How far is this binary from working?

Re: CVS commit: src/tests/lib/libm

There is no other way to find and fix these problems. nobody runs sh3 tests, and non-x86 ports have so many failures that it's going to be drowned in the noise. And it adds an actual test for functionality, to be sure we weren't wrong in adding the function for that arch. This is causing

Re: CVS commit: src/tests/lib/libm

ree, not in the public repo. > > coypu - an alternative would be to make a test that (when run as a test, > rather than when being built) attempts to compile code to use whatever > interface that is, so that the test fails if the interface doesn't exist, > rather than actually breaking

Re: CVS commit: src/tests/lib/libm

On Tue, Jul 25, 2017 at 09:26:56PM +, Valeriy E. Ushakov wrote: > Module Name: src > Committed By: uwe > Date: Tue Jul 25 21:26:56 UTC 2017 > > Modified Files: > src/tests/lib/libm: t_fe_round.c > > Log Message: > Revert previous as it breaks at least sparc and hpcsh builds. >

Re: CVS commit: src/sys/uvm

On Fri, May 19, 2017 at 03:30:19PM +, Chuck Silvers wrote: > Module Name: src > Committed By: chs > Date: Fri May 19 15:30:19 UTC 2017 > > Modified Files: > src/sys/uvm: uvm_map.c uvm_mmap.c > > Log Message: > make MAP_FIXED mapping operations atomic. fixes PR 52239. >

Re: CVS commit: src/lib/libm

Diff to 7.1 (also libm.so.0.11) libm diff to 7.1 4a5 > r __GNU_EH_FRAME_HDR 10c11 < w __deregister_frame_info@@GCC_3.0 --- > w __deregister_frame_info 94c95 < w __register_frame_info@@GCC_3.0 --- > w __register_frame_info 96a98 > U __signbitf 111d112 < T _casinl

Re: CVS commit: src/lib/libm

On Sat, May 06, 2017 at 02:03:25PM -0400, Christos Zoulas wrote: > Module Name: src > Committed By: christos > Date: Sat May 6 18:03:25 UTC 2017 > > Modified Files: > src/lib/libm: Makefile > Added Files: > src/lib/libm/src: s_llrint.c s_llrintf.c s_llrintl.c s_llround.c >

Re: CVS commit: [prg-localcount2] src

src/sys/external/bsd/drm2/drm/drm_drv.c isn't an upstream file, no need to worry about changing it

Re: CVS commit: [jdolecek-ncq] src/sys/dev/ata

Re: CVS commit: src/usr.bin/make

On Tue, Apr 11, 2017 at 05:30:13PM +, Simon J. Gerraty wrote: > Log Message: > Str_Match: allow [^a-z] to behave as expected. % env A=NetBSD-7-x86_64 make -V '${A:MNetBSD-[^0-1]-i386}' NetBSD-7-x86_64

Re: CVS commit: src/sbin/fsck_ext2fs

On Fri, Apr 21, 2017 at 07:46:27PM +0200, Kamil Rytarowski wrote: > > It's a valid code. > Other things fail: http://releng.netbsd.org/builds/HEAD/201704202350Z/evbarm64-aarch64.build.failed /home/source/ab/HEAD/src/bin/ln/ln.c:357:1: error: function 'usage' could be declared with attribute

Re: CVS commit: src/sbin/fsck_ext2fs

On Fri, Apr 21, 2017 at 01:33:05PM -0400, Christos Zoulas wrote: > e2di_block is an array; can't be NULL, (clang) I'm guessing this is from http://releng.netbsd.org/builds/HEAD-llvm/201704191240Z/amd64.build.failed /home/source/ab/HEAD-llvm/src/sbin/fsck_ext2fs/pass1.c:242:39: warning:

Re: CVS commit: src/sys/opencrypto

On Tue, Apr 18, 2017 at 05:05:06PM +, Maya Rashish wrote: > XXX surrounding code seems fishy > > @@ -759,7 +759,6 @@ swcr_compdec(struct cryptodesc *crd, con > if (result < crd->crd_len) { > adj = result - crd->crd_len; > if (outtype == CRYPTO_BUF_MBUF) { > -

Re: CVS commit: src/external/bsd/bc/dist

joerg mentions you can get around the dummy returns/breaks after bc_exit to quiet compiler warnings by tagging it dead

Re: CVS commit: src/external/bsd/bc/dist

Hi, -DIGIT [0-9A-F] +DIGIT [0-9A-Z] Looks off, is that intended? Thanks.

Re: CVS commit: [netbsd-7] src

On Wed, Apr 05, 2017 at 07:54:27PM +, Soren Jacobsen wrote: > Module Name: src > Committed By: snj > Date: Wed Apr 5 19:54:23 UTC 2017 > > Modified Files: .. > src/sys/external/bsd/common/include/linux [netbsd-7]: kernel.h > src/sys/external/bsd/drm2/dist/drm/radeon

Re: CVS commit: src/sys/arch/amd64/amd64

On Thu, Mar 23, 2017 at 05:25:51PM +, Maxime Villard wrote: > Module Name: src > Committed By: maxv > Date: Thu Mar 23 17:25:51 UTC 2017 > > Modified Files: > src/sys/arch/amd64/amd64: locore.S machdep.c trap.c > > Log Message: > Remove this call gate on amd64, it is useless

Re: CVS commit: src/sys/arch

On Sun, Feb 26, 2017 at 12:03:15PM +, Rin Okuyama wrote: > Add DKWEDGE_METHOD_RDB option, which is enabled for x86, commented out for > other platforms by default. > Please disable this on x86. It shouldn't be everyone's junkyard.

Re: CVS commit: src/lib/libc/gen

On Mon, Feb 13, 2017 at 12:04:02PM +, co...@sdf.org wrote: > ASan is wrong about where the problem happens, This can be dealt with -fno-omit-frame-pointer.

Re: CVS commit: src/lib/libc/gen

On Sun, Feb 12, 2017 at 05:37:49PM -0500, Christos Zoulas wrote: > Module Name: src > Committed By: christos > Date: Sun Feb 12 22:37:49 UTC 2017 > > Modified Files: > src/lib/libc/gen: vis.c > > Log Message: > fix off-by-one, found by asan. > It fails in another case, attached

Re: CVS commit: src/sys/dev/pci

On Thu, Feb 02, 2017 at 03:41:22AM +, Jonathan A. Kollasch wrote: > @@ -432,6 +433,10 @@ wpi_detach(device_t self, int flags __un > pci_intr_disestablish(sc->sc_pct, sc->sc_ih); > sc->sc_ih = NULL; > } > + if (sc->sc_pihp != NULL) { > +

Re: CVS commit: src/sys/net

oops, I was wrong here, please disregard :-)

Re: CVS commit: src/sys/net

On Thu, Jan 26, 2017 at 09:13:19PM +, Nick Hudson wrote: > @@ -803,32 +790,14 @@ tunread(dev_t dev, struct uio *uio, int > goto out; > } > tp->tun_flags |= TUN_RWAIT; > - if (mtsleep((void *)tp,

Re: CVS commit: src/sys/net

Hi, On Thu, Jan 26, 2017 at 09:13:19PM +, Nick Hudson wrote: > @@ -534,14 +527,12 @@ tun_output(struct ifnet *ifp, struct mbu > const struct rtentry *rt) > { > struct tun_softc *tp = ifp->if_softc; > - int s; > int error; > #if defined(INET) ||

Re: CVS commit: src/sys/kern

> @@ -162,7 +162,7 @@ module_load_plist_vfs(const char *modpat > base = NULL; > > proppath = PNBUF_GET(); > - strcpy(proppath, modpath); > + strlcpy(proppath, modpath, MAXPATHLEN); > pathlen = strlen(proppath); > if ((pathlen >= 6) && (strcmp([pathlen - 5],

Re: CVS commit: src/sys/kern

On Sun, Jan 15, 2017 at 01:28:14AM +, Maya Rashish wrote: > - strcpy(name, t->l_name); > + strlcpy(name, t->l_name, sizeof(name)); > This seems limited in setname, and getname was unlimited. I don't see where else it is set, let me know if I'm wrong!

Re: CVS commit: src/sys/dev/raidframe

It's still a behaviour change.. On Thu, Jan 12, 2017 at 11:22:16PM -0500, Christos Zoulas wrote: > +static void > +rf_handle_hosed(RF_Raid_t *raidPtr, RF_Config_t *cfgPtr, int hosed_column) > +{ > + if (raidPtr->Disks[hosed_column].status == rf_ds_failed) > + return; equivalent

Re: CVS commit: src/sys/dev/raidframe

On Thu, Jan 12, 2017 at 11:22:16PM -0500, Christos Zoulas wrote: > +rf_handle_hosed(RF_Raid_t *raidPtr, RF_Config_t *cfgPtr, int hosed_column) > +{ : > + if (raidPtr->Disks[hosed_column].status == rf_ds_failed) > + return; equivalent to if (raidPtr->Disks[hosed_column].status !=

Re: CVS commit: src/sys/dev/pcmcia

By the way, this code appears to do bogus things with i_len, like "clear trailing garbage" except using the wrong (constant) length. it's possible it doesn't work for SSIDs longer than NETWORK_NAME due to that, but I don't have one or have the confidence to fix it blindly. On Thu, Jan 12, 2017 at

Re: CVS commit: src/sys/arch/x86/pci

> #define VMXNET3_CORE_LOCK_ASSERT(_sc)mutex_owned((_sc)->vmx_mtx) > > #define VMXNET3_RXQ_LOCK_ASSERT(_rxq)\ > mutex_owned((_rxq)->vxrxq_mtx) > #define VMXNET3_TXQ_LOCK_ASSERT(_txq)\ > mutex_owned((_txq)->vxtxq_mtx) These should probably

Re: CVS commit: src/doc

On Sun, Jan 08, 2017 at 04:17:44PM +, Thomas Klausner wrote: > Module Name: src > Committed By: wiz > Date: Sun Jan 8 16:17:44 UTC 2017 > > Modified Files: > src/doc: 3RDPARTY > > Log Message: > zlib-1.2.9 out. > 1.2.10 is out

Re: CVS commit: src/lib/libm/complex

On Sat, Dec 31, 2016 at 03:33:03PM +, Maya Rashish wrote: > - w = r + y * I; > + r = sqrt(x); > + w = r; > } > } > return w; I'm an alignment newbie. Could

Re: CVS commit: src/sys/uvm

On Fri, Dec 23, 2016 at 09:22:22AM +1100, matthew green wrote: > > Log Message: > > Use uvm_physseg.h:uvm_page_physload() instead of uvm_extern.h > > > > For this, include uvm_physseg.h in the build and include tree, make a > > cosmetic modification to the prototype for uvm_page_physload(). > >

Re: CVS commit: src/tests/lib/libm

On Mon, Dec 19, 2016 at 05:44:56PM +, co...@sdf.org wrote: > I suppose the name is dumb, but I only thought about it > after committing. sorry. > It should crash with SIGFPE on alpha, which is why I thought > of exceptions when naming it! ... except it shouldn't do that either now. I'm gonna

Re: CVS commit: src/tests/lib/libm

On Mon, Dec 19, 2016 at 05:38:24PM +, Maya Rashish wrote: > Module Name: src > Committed By: maya > Date: Mon Dec 19 17:38:24 UTC 2016 > > Modified Files: > src/tests/lib/libm: Makefile > Added Files: > src/tests/lib/libm: t_fe_round.c > > Log Message: > add test for

Re: CVS commit: src/sys

On Fri, Dec 16, 2016 at 11:35:04PM +, Taylor R Campbell wrote: > Fix return value of nommap. > pullups?

Re: CVS commit: src/sys/sys

On Mon, Dec 12, 2016 at 10:07:12PM +, co...@sdf.org wrote: > > This unfortunately presents a problem with pulling up > the fix to -7. on icb someone mentioned 7.1 is a different version anyway. so it shouldn't be an issue here, yay.

Re: CVS commit: src/sys/sys

On Mon, Dec 12, 2016 at 09:56:00PM +, Maya Rashish wrote: > Bump for drm2 da_fb_linebytes > This unfortunately presents a problem with pulling up the fix to -7. it's not normally a module. thoughts?

Re: CVS commit: src/sys/dev/raidframe

err, this does introduce a functional change... oops it's if panicstr != NULL, but that's not the argument.

Re: CVS commit: src

On Thu, Dec 08, 2016 at 05:03:04PM +0100, J. Hannken-Illjes wrote: > > > On 08 Dec 2016, at 15:41, Nathanial Sloss wrote: > > > > On Thu, 8 Dec 2016 23:57:51 J. Hannken-Illjes wrote: > >> +#defineD_MCLOSE0x0004 > >> > >> What is a MCLOSE device class? > >> > >

Re: CVS commit: src/sys/dev/pci

On Sun, Nov 27, 2016 at 12:15:56AM +0900, Kimihiro Nonaka wrote: > Hi, > > 2016-11-26 17:29 GMT+09:00 : > > > This strangely causes fallpoint for sandpoint because: > > sandpoint/include/pci_machdep.h:38:#define __HAVE_PCI_MSI_MSIX > > Does it really? > > fixed > >

Re: CVS commit: src/sys/dev/pci

This strangely causes fallpoint for sandpoint because: sandpoint/include/pci_machdep.h:38:#define __HAVE_PCI_MSI_MSIX Does it really? Failure at http://releng.netbsd.org/builds/HEAD/201611252110Z/sandpoint.build.failed if_re_pci.o: In function `re_pci_detach': if_re_pci.c:(.text+0x70):

Re: CVS commit: src/lib/librumpuser/build-aux

For the record, this is because the build server is running -6-1..

Re: CVS commit: src/lib/librumpuser/build-aux

On Wed, Oct 19, 2016 at 09:41:30AM +, Antti Kantee wrote: > No idea about the cause, but there seem to be other variants of the same > theme in the build logs, suggesting a more general problem, e.g.: > https://releng.netbsd.org/builds/HEAD/201610171520Z/sbmips-mipseb.build.failed > > In all

Re: CVS commit: src/lib/librumpuser/build-aux

On Tue, Oct 18, 2016 at 10:28:04PM +, Antti Kantee wrote: > On 17/10/16 18:24, Maya Rashish wrote: > >Module Name: src > >Committed By:maya > >Date:Mon Oct 17 18:24:42 UTC 2016 > > > >Modified Files: > > src/lib/librumpuser/build-aux: install-sh > > > >Log Message:

Re: CVS commit: src/lib/librumpuser/build-aux

On Mon, Oct 17, 2016 at 06:24:42PM +, Maya Rashish wrote: > Module Name: src > Committed By: maya > Date: Mon Oct 17 18:24:42 UTC 2016 > > Modified Files: > src/lib/librumpuser/build-aux: install-sh > > Log Message: > use mktemp instead of $RANDOM for tmpdir > Woops, this is

Re: CVS commit: src/sys/arch/arm/omap

Hi, On Sat, Oct 15, 2016 at 03:09:00PM +, KIYOHARA Takashi wrote: > + fifo = OMAP2_I2C_FIFOBYTES(fifodepth); >From >http://releng.netbsd.org/builds/HEAD/201610160020Z/evbarm-earmv7hf.build.failed --- kern-BEAGLEBONE --- /home/source/ab/HEAD/src/sys/arch/arm/omap/ti_iic.c: In function

Re: CVS commit: src/sbin/mount

On Sun, Oct 09, 2016 at 12:57:50PM -0600, Greg Oster wrote: > > mount -t ext2 /dev/sd0e /mnt1 > mount -t ext2 /dev/sd1e /mnt2 > mount -t ext2 /dev/sd2e /mnt3 > mount -t ext2 /dev/sd3e /mnt4 > - > > and getting the message: > > mount: mount_ext2 not found > > Now: which of those mounts

Re: CVS commit: src/share/mk

On Fri, Sep 09, 2016 at 09:26:40PM +, co...@sdf.org wrote: > On Fri, Sep 09, 2016 at 04:02:18PM +, co...@sdf.org wrote: > > On Thu, Sep 08, 2016 at 09:37:25PM -0400, Christos Zoulas wrote: > > > On Sep 8, 8:40pm, co...@sdf.org (co...@sdf.org) wrote: > > > -- Subject: Re: CVS commit:

Re: CVS commit: src/share/mk

On Fri, Sep 09, 2016 at 04:02:18PM +, co...@sdf.org wrote: > On Thu, Sep 08, 2016 at 09:37:25PM -0400, Christos Zoulas wrote: > > On Sep 8, 8:40pm, co...@sdf.org (co...@sdf.org) wrote: > > -- Subject: Re: CVS commit: src/share/mk > > > > | I think we need to revert this commit. I see issues

Re: CVS commit: src/share/mk

I think we need to revert this commit. I see issues with awk on pmax too. I don't have a nice hardfloat case like martin in PR 51026 but attempting to build anything from pkgsrc will fail on checksum compare. On Sat, Sep 03, 2016 at 08:32:12AM -0400, Christos Zoulas wrote: > Module Name: src >

Re: CVS commit: src/sys/dev

On Wed, Jul 27, 2016 at 01:09:44AM +, Paul Goyette wrote: > Module Name: src > Committed By: pgoyette > Date: Wed Jul 27 01:09:44 UTC 2016 > > Modified Files: > src/sys/dev: md.c > > Log Message: > If we're going to check for a NULL pointer, do the check before we >

Re: CVS commit: src/sys/arch/arm/arm32

On Fri, Jul 15, 2016 at 05:59:46AM +, Nick Hudson wrote: > + > +bool > +mm_md_page_color(paddr_t pa, int *colorp) > +{ > + *colorp = atop(pa & arm_cache_prefer_mask); > + > + return arm_cache_prefer_mask ? false : true; > +} > arm_cache_prefer_mask only exists for armv6/armv7 now

Re: CVS commit: src/sys/arch/arm/arm32

On Fri, Jul 15, 2016 at 05:59:46AM +, Nick Hudson wrote: > Module Name: src > Committed By: skrll > Date: Fri Jul 15 05:59:46 UTC 2016 > > Modified Files: > src/sys/arch/arm/arm32: arm32_machdep.c > > Log Message: > Provide a mm_md_page_color and fix some kernel builds > >

Re: CVS commit: src/sys/arch/x86/x86

On Fri, Jul 01, 2016 at 11:44:05AM +, Maxime Villard wrote: > Log Message: > Use pmap_bootstrap_valloc and pmap_bootstrap_palloc under XEN at least > once, for these not to appear as unused functions (not tested, but I > guess). Maybe __used or ifndef XEN?