Le 09/10/2015 06:49, Masanobu SAITOH a écrit :
> On 2015/10/06 6:10, Jean-Yves Migeon wrote:
>>> Log Message:
>>> kmem_free() the address returned by kmem_alloc(). found by Brainy.
>>> use the newly aligned location if we needed it. found by kre.
>>>
&g
(). found by Brainy.
> use the newly aligned location if we needed it. found by kre.
>
>
> To generate a diff of this commit:
> cvs rdiff -u -r1.8 -r1.9 src/sys/arch/x86/x86/cpu_ucode_intel.c
IMHO this should be pulled-up to -6 and -7.
Any argument against? If the old code worked, it's pure luck.
--
Jean-Yves Migeon
Le 21/04/12 14:50, Jean-Yves Migeon a écrit :
The machine did not drop into ddb, it simply rebooted. Unfortunately
it did not leave a core dump behind, so I don't have much to look at
just yet. When I get home later today, I will try to get more info.
BTW, this occurred while running the ATF
Le 21/04/12 19:47, Christoph Egger a écrit :
rip 0x0 and rsp 0x50202 look really abnormal to me. I'll have a look in
FreeBSD, that's probably a group of exceptions that have to be handled
differently.
rip 0x0 often means that a function pointer has been called which is
NULL.
Christoph
Le 21/04/12 23:25, Christos Zoulas a écrit :
In article4f930a8c.6040...@free.fr,
Jean-Yves Migeonjeanyves.mig...@free.fr wrote:
Le 21/04/12 20:52, Christos Zoulas a écrit :
Module Name:src
Committed By: christos
Date: Sat Apr 21 18:52:37 UTC 2012
Modified Files:
crude
and i'll change that.
Hope this answers most of your questions.
Waiting for mines :)
--
Jean-Yves Migeon
j...@netbsd.org
the point about
emulation, and even more so about the alleged extra security where this
can be trivially bypassed. Return to libfoo and ROP are quite mainstream
techniques these days...
--
Jean-Yves Migeon
j...@netbsd.org
On 04.12.2011 21:07, Alan Barrett wrote:
On Sun, 04 Dec 2011, Jean-Yves Migeon wrote:
Log Message:
Implement the register/deregister/evaluation API for secmodel(9). It
allows registration of callbacks that can be used later for
cross-secmodel safe communication.
Where and when
to reproduce:
- connect to a dom0 system
- try ballooning up or down, with:
sysctl -w machdep.xen.balloon.target=10
All newly created processes will then stay in tstile, and the sysctl
never returns, waiting on rplq wait channel.
Observed in QEMU, Virtualbox, and my amd64 spare host.
--
Jean-Yves
: is there a different rule applicable to man pages for
4-clause vs 2-clause BSD? I occasionally see new man pages written with
a 4-clause BSD, however, most newly written code is 2-clause.
--
Jean-Yves Migeon
jeanyves.mig...@free.fr
.
Strictly speaking, PAE is enabled when we are running in long mode. I
set the sysctl(7) a while ago for NX regression tests in ATF, but not
the variable. Maybe I should.
--
Jean-Yves Migeon
jeanyves.mig...@free.fr
you want to do this one yourself ?
Please do :)
--
Jean-Yves Migeon
jeanyves.mig...@free.fr
for MP in the near future :o
--
Jean-Yves Migeon
jeanyves.mig...@free.fr
review :) Thanks for starting the merge
of your branch.
--
Jean-Yves Migeon
jeanyves.mig...@free.fr
; the old code does
not permit that, unless you build and store the string somewhere,
forcing the caller to *know* that it only keeps a pointer and does not
copy the content. This will get misused, sooner or later.
--
Jean-Yves Migeon
jeanyves.mig...@free.fr
that the lock will block other LWPs from
running even when they do not need to allocate memory.
--
Jean-Yves Migeon
jeanyves.mig...@free.fr
On 20.09.2011 02:12, Jean-Yves Migeon wrote:
Module Name:src
Committed By: jym
Date: Tue Sep 20 00:12:25 UTC 2011
Modified Files:
[snip]
Log Message:
Merge jym-xensuspend branch in -current. ok bouyer@.
Goal: save/restore support in NetBSD domUs, for i386, i386 PAE and amd64
On 06.09.2011 12:54, Thomas Klausner wrote:
On Mon, Aug 22, 2011 at 06:54:07PM +, Jean-Yves Migeon wrote:
Module Name: src
Committed By:jym
Date:Mon Aug 22 18:54:06 UTC 2011
[snip]
Log Message:
Modify etc/defaults/Makefile so that architectures can specify
this; thanks for reporting!
--
Jean-Yves Migeon
jeanyves.mig...@free.fr
mmu queues
Thanks for looking into it!
--
Jean-Yves Migeon
jeanyves.mig...@free.fr
On Mon, 29 Aug 2011 11:46:06 +0200, Manuel Bouyer wrote:
On Mon, Aug 29, 2011 at 09:01:47AM +0200, Jean-Yves Migeon wrote:
What kind of console is attaching for you in dom0? I can't see how
'+' would get wired in by default. At least when either started
from
bare metal, or QEMU
to common/, and I am more at
peace knowing that we have a valid strnlen() in kernel rather than a
bogus macro that may spread elsewhere...
--
Jean-Yves Migeon
jeanyves.mig...@free.fr
On 27.08.2011 20:28, Joerg Sonnenberger wrote:
On Sat, Aug 27, 2011 at 08:13:28PM +0200, Jean-Yves Migeon wrote:
On 27.08.2011 19:57, Reinoud Zandijk wrote:
Fix copystring routines to NOT just copy all since not all space might be
writable. This can be fixed by implementing/importing strnlen(3
atomic operation with the hardware TLB,
as
this is, precisely, a shadow PT and not the one used by hardware.
--
Jean-Yves Migeon
jeanyves.mig...@free.fr
all
Xen MMU hypercalls to be reentrant.
--
Jean-Yves Migeon
jeanyves.mig...@free.fr
On 21.08.2011 12:26, Jean-Yves Migeon wrote:
- second, the lock is not placed at the correct abstraction level IMHO,
it is way too high in the caller/callee hierarchy. It should remain
hidden from most consumers of the xpq_queue API, and should only be used
to protect the xpq_queue array
is completely different to
ours: it maps the entire physical memory in the kernel virtual space
(with tricks when there's more than 1GiB involved), while we use
recursive mappings. And Xen has problems validating these.
--
Jean-Yves Migeon
jeanyves.mig...@free.fr
On Mon, 18 Jul 2011 07:41:30 +0100, David Laight wrote:
On Mon, Jul 18, 2011 at 02:18:54AM +0200, Jean-Yves Migeon wrote:
On 18.07.2011 02:00, David Young wrote:
Can we please use ansi function definitions in newly committed
code?
This was tedious enough without converting to ANSI function
away from manipulating code (particularly crypto) when I
don't have good knowledge of it. And this is far from being the case for
me with OpenSSL.
Anyway, I'll look into it next week for cleanup.
--
Jean-Yves Migeon
jeanyves.mig...@free.fr
had to do it manually. It's even the opposite, spatch has issues when
parsing non-ANSI declarations, so you have to do the conversion all by
yourself first...
--
Jean-Yves Migeon
jeanyves.mig...@free.fr
), and there are other potential tools usable out there (lsof(1),
maybe?).
Isn't it something that rather fits the kauth(9) ACLs?
--
Jean-Yves Migeon
jeanyves.mig...@free.fr
regarding refcnt fetch
(not actually possible as port-xen is not MP, but will become soonish)
I'll remove the volatile declaration too, only xbdi_put/_get use the
refcnt for G/C anyway.
Thanks for pointing that out!
--
Jean-Yves Migeon
jeanyves.mig...@free.fr
.
--
Jean-Yves Migeon
jeanyves.mig...@free.fr
) especially as the code behind can evolve (hey, Lars
:) ).
--
Jean-Yves Migeon
jeanyves.mig...@free.fr
are no longer checking for big ones as well.
This applies to all allocators.
So, any thread sleeping for an allocation cannot be interrupted?
--
Jean-Yves Migeon
jeanyves.mig...@free.fr
On 06.04.2011 20:01, Manuel Bouyer wrote:
You could also use
xvifxiy (e.g. xvif5i2, where i stands for 'index').
or any other letter ...
Huh hmm indeed... I wonder why I did not think about this approach before...
--
Jean-Yves Migeon
jeanyves.mig...@free.fr
not only what to load, but
also, what is the state of a driver module. Module's loading can
change the state of devices, and rebooting/calling bootloader will _not_
reset that state.
--
Jean-Yves Migeon
jeanyves.mig...@free.fr
] http://en.wikipedia.org/wiki/Voting_paradox
--
Jean-Yves Migeon
jeanyves.mig...@free.fr
, like zfs and solaris compat layer. And these makes up
for ~ half the size of /stand (5MiB).
--
Jean-Yves Migeon
jeanyves.mig...@free.fr
that should be enabled by default, and what could stay out
(or as a third party module if you urgently need it back). One example:
accf_* is a questionable choice, whether its inside GENERIC (as a
builtin), or enabled by default in MONOLITHIC.
--
Jean-Yves Migeon
jeanyves.mig...@free.fr
On 19.02.2011 10:27, Bernd Ernesti wrote:
On Wed, Feb 16, 2011 at 03:16:58AM +, Jean-Yves Migeon wrote:
Module Name: src
Committed By:jym
Date:Wed Feb 16 03:16:58 UTC 2011
Modified Files:
src/sys/arch/amd64/conf: GENERIC INSTALL
Log Message:
Build certain
way, it's fine; but please -- i386 and amd64 should share
common grounds. If some want a MONOLITHIC amd64, it's even possible,
although I can't see the point given the arguments above. That would
also save us a kernel build for i386 release.
--
Jean-Yves Migeon
jeanyves.mig...@free.fr
On 13.02.2011 14:42, David Laight wrote:
On Sun, Feb 13, 2011 at 04:37:21AM +, Jean-Yves Migeon wrote:
Module Name: src Committed By: jym Date: Sun Feb 13
04:37:21 UTC
2011
Modified Files: src/sys/arch/i386/conf: GENERIC
Log Message: Compile FFS and NFS
On 13.02.2011 17:02, Paul Goyette wrote:
On Sun, 13 Feb 2011, Jean-Yves Migeon wrote:
...
For order of preference, see module(7):
The loader will look first for a built-in module with the specified
name that has not been disabled (see module_unload() below). If a
built-in module
On 11.02.2011 07:30, Matthias Scheler wrote:
On Fri, Feb 11, 2011 at 05:06:43AM +0100, Jean-Yves Migeon wrote:
Indeed, it would be good to have at least some exec formats and
file-systems builtin by default in GENERIC:
EXEC_ELF32, _SCRIPT # obvious
FFS, CD9660, MFS, TMPFS, NFS, EXT2FS
On 10.02.2011 22:23, David Laight wrote:
On Thu, Feb 10, 2011 at 04:49:19PM +, Jean-Yves Migeon wrote:
Module Name: src
Committed By:jym
Date:Thu Feb 10 16:49:19 UTC 2011
Modified Files:
src/sys/arch/i386/conf: INSTALL
Log Message:
For i386, include
On 31.12.2010 11:10, Jukka Ruohonen wrote:
On Fri, Dec 31, 2010 at 11:01:08AM +0100, Jean-Yves Migeon wrote:
I am using machdep.sleep_state as node to put a domU into suspend mode.
Up to now, putting sleep_state under machdep allowed powerd(8)
sleep_button to be used regardless
states that ACPI names are not sufficient even to
describe all of the potential sleep states of ACPI hardware. I have a
laptop that's perfectly capable of an S3-like sleep, but the ACPI BIOS
doesn't support S3, and the HDD is not formatted properly for the S4
sleep.
--
Jean-Yves Migeon
On 27.11.2010 18:38, Jean-Yves Migeon wrote:
Module Name: src
Committed By: jym
Date: Sat Nov 27 17:38:49 UTC 2010
Modified Files:
src/sys/dev/mii: miidevs.h
Log Message:
Correct string for BCM6709S.
s/BCM6709S/BCM5709S/
--
Jean-Yves Migeon
j...@netbsd.org
.
Second time I got burned on that one :/
--
Jean-Yves Migeon
jeanyves.mig...@free.fr
On 06.10.2010 12:16, Manuel Bouyer wrote:
On Tue, Oct 05, 2010 at 11:48:17PM +, Jean-Yves Migeon wrote:
[...]
XXX Currently, savecore(8) will fail to dump a PAE kernel in a !PAE
environment (and reciprocally). So you need to sync and reboot
with a kernel of the same mode
On 27.09.2010 23:25, Christos Zoulas wrote:
Module Name: src
Committed By: christos
Date: Mon Sep 27 21:25:39 UTC 2010
Modified Files:
src/sys/dev/pci: agp.c
src/sys/sys: agpio.h
Log Message:
backwards compat code for paddr_t being 32 bits.
Thanks!
--
Jean-Yves
if
its system is running under PAE.
--
Jean-Yves Migeon
jeanyves.mig...@free.fr
paddr_t
will not automagically solve the all PAs are unsigned long assumption of
kvm(3).
/long_explanation
--
Jean-Yves Migeon
jeanyves.mig...@free.fr
maintaining binary compatibility.
I don't think so; modules that manipulates 32 bits bus_addr_t will likely
fail with PAE when you cross the 4GB boundary. I don't see how the union
could solve that.
--
Jean-Yves Migeon
jeanyves.mig...@free.fr
as i386_use_fxsave.
i386_use_pae may get use elsewhere eventually, so I added it to cpu.h.
--
Jean-Yves Migeon
jeanyves.mig...@free.fr
above 4GB.
Eventually, PAE and !PAE kernels core files should be handled by kvm, if
that's what you are asking.
PAE does not affect program core files.
--
Jean-Yves Migeon
jeanyves.mig...@free.fr
on). It becomes a matter of calling the proper code within kvm(3), by
checking if PAE was enabled within the kernel dump (through kvm_nlist,
for example).
--
Jean-Yves Migeon
jeanyves.mig...@free.fr
,
even if the upper 32 bits are always 0 in GENERIC.
Pleaes fix the amd64 build error reported on current-us...@.
The build error is related to rump.
Investigating. rumptest just finished for i386 and amd64, and no error
whatsoever. Guess I'll have to dig further...
--
Jean-Yves Migeon
jeanyves.mig
for these platforms. But here, i386 and PAE are so
close in concept that it feels like a quirk (at least to me).
--
Jean-Yves Migeon
jeanyves.mig...@free.fr
with them in
_KERNEL when option PAE is enabled.
For kvm(3), both could be used; I could extract a value from a symbol
like pae_enabled out of a core file through kvm_nlist, then use the
relevant vatop functions.
--
Jean-Yves Migeon
jeanyves.mig...@free.fr
that could be labeled as security-sensitive (not
exploitable directly though). Bumping revision makes it easier to say
-current under rev 5.99.x is affected, 5.99.x+1 is not.
--
Jean-Yves Migeon
jeanyves.mig...@free.fr
Module Name:src
Committed By: jym
Date: Tue Mar 9 23:12:06 UTC 2010
Modified Files:
src/sys/arch/xen/x86: xen_bus_dma.c
Log Message:
Although Xen's documentation states that the address_bits field is not used
by XENMEM_decrease_reservation, it is checked by the
Module Name:src
Committed By: jym
Date: Tue Mar 9 23:12:06 UTC 2010
Modified Files:
src/sys/arch/xen/x86: xen_bus_dma.c
Log Message:
Although Xen's documentation states that the address_bits field is not used
by XENMEM_decrease_reservation, it is checked by the
Module Name:src
Committed By: jym
Date: Wed Mar 3 00:09:03 UTC 2010
Modified Files:
src/sys/arch/xen/x86: cpu.c
Log Message:
Use roundup2() instead of hardcoding the CACHE_LINE_SIZE rounding
operation.
To generate a diff of this commit:
cvs rdiff -u -r1.41 -r1.42
Module Name:src
Committed By: jym
Date: Wed Mar 3 00:09:03 UTC 2010
Modified Files:
src/sys/arch/xen/x86: cpu.c
Log Message:
Use roundup2() instead of hardcoding the CACHE_LINE_SIZE rounding
operation.
To generate a diff of this commit:
cvs rdiff -u -r1.41 -r1.42
Module Name:src
Committed By: jym
Date: Tue Mar 2 00:13:50 UTC 2010
Modified Files:
src/sys/arch/xen/x86: xen_bus_dma.c
Log Message:
Catch the return value from the XENMEM_decrease_reservation hypercall,
and not some error value stored earlier.
While here, fix a typo in
Module Name:src
Committed By: jym
Date: Tue Mar 2 00:13:50 UTC 2010
Modified Files:
src/sys/arch/xen/x86: xen_bus_dma.c
Log Message:
Catch the return value from the XENMEM_decrease_reservation hypercall,
and not some error value stored earlier.
While here, fix a typo in
Module Name:src
Committed By: jym
Date: Mon Mar 1 00:55:33 UTC 2010
Modified Files:
src/sys/arch/i386/include: pmap.h
Log Message:
Use PDP_SIZE for NTOPLEVEL_PDES (number of top level PDEs) instead of
#ifdef'ing PAE.
To generate a diff of this commit:
cvs rdiff -u
Module Name:src
Committed By: jym
Date: Mon Mar 1 00:55:33 UTC 2010
Modified Files:
src/sys/arch/i386/include: pmap.h
Log Message:
Use PDP_SIZE for NTOPLEVEL_PDES (number of top level PDEs) instead of
#ifdef'ing PAE.
To generate a diff of this commit:
cvs rdiff -u
Module Name:src
Committed By: jym
Date: Mon Mar 1 01:15:24 UTC 2010
Modified Files:
src/sys/arch/i386/i386: machdep.c rbus_machdep.c
src/sys/arch/i386/include: rbus_machdep.h
Log Message:
Change rbus_min_start_hint() semantic for i386. ram is now psize_t
(instead
Module Name:src
Committed By: jym
Date: Mon Mar 1 01:15:24 UTC 2010
Modified Files:
src/sys/arch/i386/i386: machdep.c rbus_machdep.c
src/sys/arch/i386/include: rbus_machdep.h
Log Message:
Change rbus_min_start_hint() semantic for i386. ram is now psize_t
(instead
Module Name:src
Committed By: jym
Date: Mon Mar 1 01:35:11 UTC 2010
Modified Files:
src/sys/arch/amd64/amd64: machdep.c
src/sys/arch/i386/i386: machdep.c
Log Message:
Do not forget that ptoa() casts the result to vaddr_t, which is bad
for paddr_t values under
Module Name:src
Committed By: jym
Date: Sat Feb 27 09:22:40 UTC 2010
Modified Files:
src/sys/arch/xen/x86: xen_bus_dma.c
Log Message:
Make a XENMEM_decrease_reservation DEBUG printf() more meaningful.
To generate a diff of this commit:
cvs rdiff -u -r1.17 -r1.18
Module Name:src
Committed By: jym
Date: Sat Feb 27 09:22:40 UTC 2010
Modified Files:
src/sys/arch/xen/x86: xen_bus_dma.c
Log Message:
Make a XENMEM_decrease_reservation DEBUG printf() more meaningful.
To generate a diff of this commit:
cvs rdiff -u -r1.17 -r1.18
Module Name:src
Committed By: jym
Date: Fri Feb 26 18:47:13 UTC 2010
Modified Files:
src/sys/kern: kern_proc.c
Log Message:
Change RSS (resident set size) limit. Instead of setting it arbitrarily
to the total free memory available to the system, use the smallest value
Module Name:src
Committed By: jym
Date: Fri Feb 26 18:47:13 UTC 2010
Modified Files:
src/sys/kern: kern_proc.c
Log Message:
Change RSS (resident set size) limit. Instead of setting it arbitrarily
to the total free memory available to the system, use the smallest value
Module Name:src
Committed By: jym
Date: Fri Feb 26 19:25:07 UTC 2010
Modified Files:
src/sys/arch/amd64/include: pte.h
src/sys/arch/i386/i386: dumpsys.c
src/sys/arch/i386/include: pte.h
src/sys/arch/i386/pci: elan520.c
src/sys/arch/x86/x86:
Module Name:src
Committed By: jym
Date: Fri Feb 26 19:25:07 UTC 2010
Modified Files:
src/sys/arch/amd64/include: pte.h
src/sys/arch/i386/i386: dumpsys.c
src/sys/arch/i386/include: pte.h
src/sys/arch/i386/pci: elan520.c
src/sys/arch/x86/x86:
Module Name:src
Committed By: jym
Date: Thu Feb 25 23:10:49 UTC 2010
Modified Files:
src/sys/uvm: uvm_glue.c
Log Message:
Change RSS (resident set size) limit. Instead of setting it arbitrarily
to the total free memory available to the system, use the smallest value
Module Name:src
Committed By: jym
Date: Wed Feb 24 00:01:12 UTC 2010
Modified Files:
src/sys/dev/pci: agp.c
src/sys/uvm: uvm_page.c
Log Message:
- Use ctob() instead of ptoa() to obtain physical addresses from frame
numbers. Using ptoa() will cast to vaddr_t,
Module Name:src
Committed By: jym
Date: Mon Feb 22 23:52:17 UTC 2010
Modified Files:
src/sys/arch/i386/i386: genassym.cf
Log Message:
Remove a duplicate entry for PTE_BASE.
While here, introduce PDP_SIZE and PDE_SIZE. They will be used by asm code
to make it more generic
Module Name:src
Committed By: jym
Date: Mon Feb 22 23:52:17 UTC 2010
Modified Files:
src/sys/arch/i386/i386: genassym.cf
Log Message:
Remove a duplicate entry for PTE_BASE.
While here, introduce PDP_SIZE and PDE_SIZE. They will be used by asm code
to make it more generic
Module Name:src
Committed By: jym
Date: Tue Feb 9 22:51:14 UTC 2010
Modified Files:
src/sys/arch/i386/include: pmap.h
src/sys/arch/x86/include: pmap.h
src/sys/arch/x86/x86: pmap.c
Log Message:
Fix typos in comments.
To generate a diff of this commit:
Module Name:src
Committed By: jym
Date: Tue Feb 9 23:09:47 UTC 2010
Modified Files:
src/sys/arch/i386/i386: mptramp.S
Log Message:
Use CR0_PE (enable protected mode) instead of hardcoding constant.
To generate a diff of this commit:
cvs rdiff -u -r1.19 -r1.20
Module Name:src
Committed By: jym
Date: Tue Feb 9 23:47:10 UTC 2010
Modified Files:
src/sys/arch/x86/x86: cpu.c
Log Message:
Use roundup2() instead of hardcoding the operation.
To generate a diff of this commit:
cvs rdiff -u -r1.66 -r1.67 src/sys/arch/x86/x86/cpu.c
Module Name:src
Committed By: jym
Date: Tue Feb 9 23:52:14 UTC 2010
Modified Files:
src/sys/arch/x86/x86: cpu.c x86_machdep.c
Log Message:
Wrap a comment; add a space after a comma to another (align with next line)
To generate a diff of this commit:
cvs rdiff -u -r1.67
Module Name:src
Committed By: jym
Date: Sun Jan 10 12:10:23 UTC 2010
Modified Files:
src/sys/arch/x86/x86: pmap.c
Log Message:
Simplify pmap_init_tmp_pgtbl() a bit.
The first level of the temporary page mappings are also done in the first
iteration of the loop below, so
to drain the per-CPU
caches before draining the global cache.
- pool_cache_invalidate_local(): remove.
Thanks!
--
Jean-Yves Migeon
jeanyves.mig...@free.fr
89 matches
Mail list logo