CVS commit: src/sys/dev/usb

2022-09-22 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Thu Sep 22 14:27:52 UTC 2022 Modified Files: src/sys/dev/usb: umass.c Log Message: umass(4): Reduce timeout for control xfers to standard USB timeout. This should reduce the timeout for a failed sd@umass transfer from n*(1min

CVS commit: src/sys/dev/usb

2022-09-22 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Thu Sep 22 07:02:21 UTC 2022 Modified Files: src/sys/dev/usb: usbnet.c Log Message: usbnet(9): Omit needless miilock around uno_stop. This time for real! To generate a diff of this commit: cvs rdiff -u -r1.112 -r1.113

CVS commit: src/sys/dev/usb

2022-09-22 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Thu Sep 22 07:02:21 UTC 2022 Modified Files: src/sys/dev/usb: usbnet.c Log Message: usbnet(9): Omit needless miilock around uno_stop. This time for real! To generate a diff of this commit: cvs rdiff -u -r1.112 -r1.113

CVS commit: src/sys/dev/usb

2022-09-20 Thread matthew green
Module Name:src Committed By: mrg Date: Tue Sep 20 07:15:46 UTC 2022 Modified Files: src/sys/dev/usb: usbnet.c Log Message: revert rev 1.111 (which was 1.106 again, without the 1.107 changes). fixes an assert reported by msaitoh@. also fix another missing miilock assert

CVS commit: src/sys/dev/usb

2022-09-20 Thread matthew green
Module Name:src Committed By: mrg Date: Tue Sep 20 07:15:46 UTC 2022 Modified Files: src/sys/dev/usb: usbnet.c Log Message: revert rev 1.111 (which was 1.106 again, without the 1.107 changes). fixes an assert reported by msaitoh@. also fix another missing miilock assert

CVS commit: src/sys/dev/usb

2022-09-16 Thread SAITOH Masanobu
Module Name:src Committed By: msaitoh Date: Fri Sep 16 07:35:44 UTC 2022 Modified Files: src/sys/dev/usb: usb.h Log Message: Cast to uint32_t to avoid undefined behavior in UGETDW(). Found by kUBSan. To generate a diff of this commit: cvs rdiff -u -r1.120 -r1.121

CVS commit: src/sys/dev/usb

2022-09-16 Thread SAITOH Masanobu
Module Name:src Committed By: msaitoh Date: Fri Sep 16 07:35:44 UTC 2022 Modified Files: src/sys/dev/usb: usb.h Log Message: Cast to uint32_t to avoid undefined behavior in UGETDW(). Found by kUBSan. To generate a diff of this commit: cvs rdiff -u -r1.120 -r1.121

CVS commit: src/sys/dev/usb

2022-09-16 Thread SAITOH Masanobu
Module Name:src Committed By: msaitoh Date: Fri Sep 16 07:34:36 UTC 2022 Modified Files: src/sys/dev/usb: if_ure.c Log Message: Use unsigned to avoid undefined behavior in ure_uno_mcast(). Found by kUBSan. To generate a diff of this commit: cvs rdiff -u -r1.57 -r1.58

CVS commit: src/sys/dev/usb

2022-09-16 Thread SAITOH Masanobu
Module Name:src Committed By: msaitoh Date: Fri Sep 16 07:34:36 UTC 2022 Modified Files: src/sys/dev/usb: if_ure.c Log Message: Use unsigned to avoid undefined behavior in ure_uno_mcast(). Found by kUBSan. To generate a diff of this commit: cvs rdiff -u -r1.57 -r1.58

CVS commit: src/sys/dev/usb

2022-09-13 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Sep 13 10:33:37 UTC 2022 Modified Files: src/sys/dev/usb: xhci.c Log Message: xhci(4): After attach, access to sc_child/2 requires sc_intr_lock. Serializes access with xhci_intr. XXX Need to ensure the interrupt handler

CVS commit: src/sys/dev/usb

2022-09-13 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Sep 13 10:33:37 UTC 2022 Modified Files: src/sys/dev/usb: xhci.c Log Message: xhci(4): After attach, access to sc_child/2 requires sc_intr_lock. Serializes access with xhci_intr. XXX Need to ensure the interrupt handler

CVS commit: src/sys/dev/usb

2022-09-13 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Sep 13 10:32:58 UTC 2022 Modified Files: src/sys/dev/usb: usbdi.c Log Message: usbdi(9): Sprinkle usbhist into usb xfer timeout logic. To generate a diff of this commit: cvs rdiff -u -r1.246 -r1.247

CVS commit: src/sys/dev/usb

2022-09-13 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Sep 13 10:32:58 UTC 2022 Modified Files: src/sys/dev/usb: usbdi.c Log Message: usbdi(9): Sprinkle usbhist into usb xfer timeout logic. To generate a diff of this commit: cvs rdiff -u -r1.246 -r1.247

CVS commit: src/sys/dev/usb

2022-09-13 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Sep 13 10:32:41 UTC 2022 Modified Files: src/sys/dev/usb: usbdi.c Log Message: usbdi(9): Fix mistake in usbdi.c 1.244. Need to clear ux_timeout_set only when we finally actually process the timeout in

CVS commit: src/sys/dev/usb

2022-09-13 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Sep 13 10:32:41 UTC 2022 Modified Files: src/sys/dev/usb: usbdi.c Log Message: usbdi(9): Fix mistake in usbdi.c 1.244. Need to clear ux_timeout_set only when we finally actually process the timeout in

CVS commit: src/sys/dev/usb

2022-09-13 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Sep 13 10:15:29 UTC 2022 Modified Files: src/sys/dev/usb: xhci.c Log Message: xhci(4): Resume commands even if USBSTS.SRE is set. Commands might not work after this but let's at least not deadlock -- give them an

CVS commit: src/sys/dev/usb

2022-09-13 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Sep 13 10:15:29 UTC 2022 Modified Files: src/sys/dev/usb: xhci.c Log Message: xhci(4): Resume commands even if USBSTS.SRE is set. Commands might not work after this but let's at least not deadlock -- give them an

CVS commit: src/sys/dev/usb

2022-09-13 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Sep 13 09:47:17 UTC 2022 Modified Files: src/sys/dev/usb: usbdi.c Log Message: usbdi(9): Rule out possible race to read xfer->ux_status. I think this might actually be safe, because when it's synchronous, the xfer can't

CVS commit: src/sys/dev/usb

2022-09-13 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Sep 13 09:47:17 UTC 2022 Modified Files: src/sys/dev/usb: usbdi.c Log Message: usbdi(9): Rule out possible race to read xfer->ux_status. I think this might actually be safe, because when it's synchronous, the xfer can't

CVS commit: src/sys/dev/usb

2022-09-13 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Sep 13 09:38:19 UTC 2022 Modified Files: src/sys/dev/usb: usbnet.c Log Message: usbnet(9): Call mii_down once we've finished with mii_tick. To generate a diff of this commit: cvs rdiff -u -r1.110 -r1.111

CVS commit: src/sys/dev/usb

2022-09-13 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Sep 13 09:38:19 UTC 2022 Modified Files: src/sys/dev/usb: usbnet.c Log Message: usbnet(9): Call mii_down once we've finished with mii_tick. To generate a diff of this commit: cvs rdiff -u -r1.110 -r1.111

CVS commit: src/sys/dev/usb

2022-09-07 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Wed Sep 7 10:41:34 UTC 2022 Modified Files: src/sys/dev/usb: usbdi.c Log Message: usbdi(9): Fix timeout after non-racy xfer resubmission. Previously we would never clear ux_timeout_set if an xfer timedout, so resubmission of

CVS commit: src/sys/dev/usb

2022-09-07 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Wed Sep 7 10:41:34 UTC 2022 Modified Files: src/sys/dev/usb: usbdi.c Log Message: usbdi(9): Fix timeout after non-racy xfer resubmission. Previously we would never clear ux_timeout_set if an xfer timedout, so resubmission of

CVS commit: src/sys/dev/usb

2022-09-05 Thread Nathanial Sloss
Module Name:src Committed By: nat Date: Tue Sep 6 02:31:08 UTC 2022 Modified Files: src/sys/dev/usb: udl.c Log Message: Don't hold a spin lock entering usbd_transfer. This avoids a crash found with LOCKDEBUG. To generate a diff of this commit: cvs rdiff -u -r1.32

CVS commit: src/sys/dev/usb

2022-09-05 Thread Nathanial Sloss
Module Name:src Committed By: nat Date: Tue Sep 6 02:31:08 UTC 2022 Modified Files: src/sys/dev/usb: udl.c Log Message: Don't hold a spin lock entering usbd_transfer. This avoids a crash found with LOCKDEBUG. To generate a diff of this commit: cvs rdiff -u -r1.32

CVS commit: src/sys/dev/usb

2022-09-05 Thread Nathanial Sloss
Module Name:src Committed By: nat Date: Tue Sep 6 02:28:35 UTC 2022 Modified Files: src/sys/dev/usb: udl.c Log Message: Do a full screen update upon vt switch. To generate a diff of this commit: cvs rdiff -u -r1.31 -r1.32 src/sys/dev/usb/udl.c Please note that diffs

CVS commit: src/sys/dev/usb

2022-09-05 Thread Nathanial Sloss
Module Name:src Committed By: nat Date: Tue Sep 6 02:28:35 UTC 2022 Modified Files: src/sys/dev/usb: udl.c Log Message: Do a full screen update upon vt switch. To generate a diff of this commit: cvs rdiff -u -r1.31 -r1.32 src/sys/dev/usb/udl.c Please note that diffs

CVS commit: src/sys/dev/usb

2022-09-05 Thread Nathanial Sloss
Module Name:src Committed By: nat Date: Tue Sep 6 02:26:11 UTC 2022 Modified Files: src/sys/dev/usb: udl.c Log Message: Ensure the device is fully initialized before starting the update thread. To generate a diff of this commit: cvs rdiff -u -r1.30 -r1.31

CVS commit: src/sys/dev/usb

2022-09-05 Thread Nathanial Sloss
Module Name:src Committed By: nat Date: Tue Sep 6 02:26:11 UTC 2022 Modified Files: src/sys/dev/usb: udl.c Log Message: Ensure the device is fully initialized before starting the update thread. To generate a diff of this commit: cvs rdiff -u -r1.30 -r1.31

CVS commit: src/sys/dev/usb

2022-09-05 Thread Nathanial Sloss
Module Name:src Committed By: nat Date: Tue Sep 6 02:23:50 UTC 2022 Modified Files: src/sys/dev/usb: udl.c Log Message: Don't throttle the frame rate. Throttling of the frame rate is no longer necessary as most screen updates are now partial updates. To generate a

CVS commit: src/sys/dev/usb

2022-09-05 Thread Nathanial Sloss
Module Name:src Committed By: nat Date: Tue Sep 6 02:23:50 UTC 2022 Modified Files: src/sys/dev/usb: udl.c Log Message: Don't throttle the frame rate. Throttling of the frame rate is no longer necessary as most screen updates are now partial updates. To generate a

CVS commit: src/sys/dev/usb

2022-09-05 Thread Nathanial Sloss
Module Name:src Committed By: nat Date: Tue Sep 6 02:20:17 UTC 2022 Modified Files: src/sys/dev/usb: udl.c udl.h Log Message: Finally fix the blitting function. This means better performance for mostly static displays. Full screen updates are still done five times a

CVS commit: src/sys/dev/usb

2022-09-05 Thread Nathanial Sloss
Module Name:src Committed By: nat Date: Tue Sep 6 02:20:17 UTC 2022 Modified Files: src/sys/dev/usb: udl.c udl.h Log Message: Finally fix the blitting function. This means better performance for mostly static displays. Full screen updates are still done five times a

CVS commit: src/sys/dev/usb

2022-09-01 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Thu Sep 1 18:09:45 UTC 2022 Modified Files: src/sys/dev/usb: xhci.c Log Message: xhci(4): Make sure to destroy sc_rhlock on detach. To generate a diff of this commit: cvs rdiff -u -r1.168 -r1.169 src/sys/dev/usb/xhci.c

CVS commit: src/sys/dev/usb

2022-09-01 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Thu Sep 1 18:09:45 UTC 2022 Modified Files: src/sys/dev/usb: xhci.c Log Message: xhci(4): Make sure to destroy sc_rhlock on detach. To generate a diff of this commit: cvs rdiff -u -r1.168 -r1.169 src/sys/dev/usb/xhci.c

CVS commit: src/sys/dev/usb

2022-08-23 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Aug 23 15:16:44 UTC 2022 Modified Files: src/sys/dev/usb: xhci.c Log Message: xhci(4): Fix error branch for failed suspend. If suspend failed, at least we can stop it from blocking all subsequent xhci commands or making a

CVS commit: src/sys/dev/usb

2022-08-23 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Aug 23 15:16:44 UTC 2022 Modified Files: src/sys/dev/usb: xhci.c Log Message: xhci(4): Fix error branch for failed suspend. If suspend failed, at least we can stop it from blocking all subsequent xhci commands or making a

CVS commit: src/sys/dev/usb

2022-08-22 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Aug 23 01:08:04 UTC 2022 Modified Files: src/sys/dev/usb: usbnet.c Log Message: usbnet(9): Don't touch ifp->if_flags in usbnet_start_locked. Instead, consult unp->unp_txstopped -- but the caller already guarantees it is

CVS commit: src/sys/dev/usb

2022-08-22 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Aug 23 01:08:04 UTC 2022 Modified Files: src/sys/dev/usb: usbnet.c Log Message: usbnet(9): Don't touch ifp->if_flags in usbnet_start_locked. Instead, consult unp->unp_txstopped -- but the caller already guarantees it is

CVS commit: src/sys/dev/usb

2022-08-22 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Aug 22 08:37:16 UTC 2022 Modified Files: src/sys/dev/usb: usbnet.h Log Message: usbnet(9): Update comments about locking to reflect current reality. No functional change. To generate a diff of this commit: cvs rdiff -u

CVS commit: src/sys/dev/usb

2022-08-22 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Aug 22 08:37:16 UTC 2022 Modified Files: src/sys/dev/usb: usbnet.h Log Message: usbnet(9): Update comments about locking to reflect current reality. No functional change. To generate a diff of this commit: cvs rdiff -u

CVS commit: src/sys/dev/usb

2022-08-20 Thread Jason R Thorpe
Module Name:src Committed By: thorpej Date: Sat Aug 20 19:11:08 UTC 2022 Modified Files: src/sys/dev/usb: if_ural.c Log Message: ural_start(): Replace "IFQ_DEQUEUE() -> IF_PREPEND() on failure" with "IFQ_POLL() -> IFQ_DEQUEUE() on success". (This one was an even worse

CVS commit: src/sys/dev/usb

2022-08-20 Thread Jason R Thorpe
Module Name:src Committed By: thorpej Date: Sat Aug 20 19:11:08 UTC 2022 Modified Files: src/sys/dev/usb: if_ural.c Log Message: ural_start(): Replace "IFQ_DEQUEUE() -> IF_PREPEND() on failure" with "IFQ_POLL() -> IFQ_DEQUEUE() on success". (This one was an even worse

CVS commit: src/sys/dev/usb

2022-08-20 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Aug 20 14:09:21 UTC 2022 Modified Files: src/sys/dev/usb: if_udav.c Log Message: udav(4): Prune dead branch: legacy IFF_ALLMULTI is never set here. To generate a diff of this commit: cvs rdiff -u -r1.98 -r1.99

CVS commit: src/sys/dev/usb

2022-08-20 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Aug 20 14:09:21 UTC 2022 Modified Files: src/sys/dev/usb: if_udav.c Log Message: udav(4): Prune dead branch: legacy IFF_ALLMULTI is never set here. To generate a diff of this commit: cvs rdiff -u -r1.98 -r1.99

CVS commit: src/sys/dev/usb

2022-08-20 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Aug 20 14:09:10 UTC 2022 Modified Files: src/sys/dev/usb: if_cue.c Log Message: cue(4): Prune dead branch: IFF_BROADCAST is always set here. To generate a diff of this commit: cvs rdiff -u -r1.107 -r1.108

CVS commit: src/sys/dev/usb

2022-08-20 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Aug 20 14:09:10 UTC 2022 Modified Files: src/sys/dev/usb: if_cue.c Log Message: cue(4): Prune dead branch: IFF_BROADCAST is always set here. To generate a diff of this commit: cvs rdiff -u -r1.107 -r1.108

CVS commit: src/sys/dev/usb

2022-08-20 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Aug 20 14:08:47 UTC 2022 Modified Files: src/sys/dev/usb: usbnet.c Log Message: usbnet(9): Rename core lock -> mii lock. No functional change intended. To generate a diff of this commit: cvs rdiff -u -r1.107 -r1.108

CVS commit: src/sys/dev/usb

2022-08-20 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Aug 20 14:08:47 UTC 2022 Modified Files: src/sys/dev/usb: usbnet.c Log Message: usbnet(9): Rename core lock -> mii lock. No functional change intended. To generate a diff of this commit: cvs rdiff -u -r1.107 -r1.108

CVS commit: src/sys/dev/usb

2022-08-20 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Aug 20 14:08:38 UTC 2022 Modified Files: src/sys/dev/usb: usbnet.c Log Message: usbnet(9): Limit scope of core lock to mii and tick scheduling. Bringing the interface up or down is serialized by IFNET_LOCK, and we prevent

CVS commit: src/sys/dev/usb

2022-08-20 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Aug 20 14:08:38 UTC 2022 Modified Files: src/sys/dev/usb: usbnet.c Log Message: usbnet(9): Limit scope of core lock to mii and tick scheduling. Bringing the interface up or down is serialized by IFNET_LOCK, and we prevent

CVS commit: src/sys/dev/usb

2022-08-20 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Aug 20 14:08:27 UTC 2022 Modified Files: src/sys/dev/usb: usbnet.c Log Message: usbnet(9): Call mii_down once we've finished with mii_tick. To generate a diff of this commit: cvs rdiff -u -r1.105 -r1.106

CVS commit: src/sys/dev/usb

2022-08-20 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Aug 20 14:08:27 UTC 2022 Modified Files: src/sys/dev/usb: usbnet.c Log Message: usbnet(9): Call mii_down once we've finished with mii_tick. To generate a diff of this commit: cvs rdiff -u -r1.105 -r1.106

CVS commit: src/sys/dev/usb

2022-08-20 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Aug 20 14:08:17 UTC 2022 Modified Files: src/sys/dev/usb: usbnet.c Log Message: usbnet(9): Simplify core lock use in usbnet_tick_task. To generate a diff of this commit: cvs rdiff -u -r1.104 -r1.105

CVS commit: src/sys/dev/usb

2022-08-20 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Aug 20 14:08:17 UTC 2022 Modified Files: src/sys/dev/usb: usbnet.c Log Message: usbnet(9): Simplify core lock use in usbnet_tick_task. To generate a diff of this commit: cvs rdiff -u -r1.104 -r1.105

CVS commit: src/sys/dev/usb

2022-08-20 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Aug 20 14:08:05 UTC 2022 Modified Files: src/sys/dev/usb: usbnet.c Log Message: usbnet(9): Call uno_tick before mii stuff. The one driver that uses it, cue(4), uses it just for statistics gathering; hard to imagine that

CVS commit: src/sys/dev/usb

2022-08-20 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Aug 20 14:08:05 UTC 2022 Modified Files: src/sys/dev/usb: usbnet.c Log Message: usbnet(9): Call uno_tick before mii stuff. The one driver that uses it, cue(4), uses it just for statistics gathering; hard to imagine that

CVS commit: src/sys/dev/usb

2022-08-20 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Aug 20 14:07:53 UTC 2022 Modified Files: src/sys/dev/usb: usbnet.c Log Message: usbnet(9): Assert core lock is held on usbnet_set_link. This is only allowed to be called via the uno_statchg callback, which in turn is

CVS commit: src/sys/dev/usb

2022-08-20 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Aug 20 14:07:53 UTC 2022 Modified Files: src/sys/dev/usb: usbnet.c Log Message: usbnet(9): Assert core lock is held on usbnet_set_link. This is only allowed to be called via the uno_statchg callback, which in turn is

CVS commit: src/sys/dev/usb

2022-08-20 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Aug 20 14:06:21 UTC 2022 Modified Files: src/sys/dev/usb: usbnet.c Log Message: usbnet(9): Split unp_stopping into stopped/txstopped/rxstopped. In practical terms this could be done with one variable and an atomic store,

CVS commit: src/sys/dev/usb

2022-08-20 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Aug 20 14:06:21 UTC 2022 Modified Files: src/sys/dev/usb: usbnet.c Log Message: usbnet(9): Split unp_stopping into stopped/txstopped/rxstopped. In practical terms this could be done with one variable and an atomic store,

CVS commit: src/sys/dev/usb

2022-08-20 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Aug 20 14:06:09 UTC 2022 Modified Files: src/sys/dev/usb: usbnet.c Log Message: usbnet(9): Don't touch unp_stopping in usbnet_pipe_intr. This access was unprotected by a lock, but it's not necessary anyway: usbnet_stop

CVS commit: src/sys/dev/usb

2022-08-20 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Aug 20 14:06:09 UTC 2022 Modified Files: src/sys/dev/usb: usbnet.c Log Message: usbnet(9): Don't touch unp_stopping in usbnet_pipe_intr. This access was unprotected by a lock, but it's not necessary anyway: usbnet_stop

CVS commit: src/sys/dev/usb

2022-08-20 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Aug 20 14:05:58 UTC 2022 Modified Files: src/sys/dev/usb: usbnet.c Log Message: usbnet(9): Omit needless un->un_intr test in usbnet_pipe_intr. un->un_intr can't change after attach, and we don't open the pipe if it's

CVS commit: src/sys/dev/usb

2022-08-20 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Aug 20 14:05:58 UTC 2022 Modified Files: src/sys/dev/usb: usbnet.c Log Message: usbnet(9): Omit needless un->un_intr test in usbnet_pipe_intr. un->un_intr can't change after attach, and we don't open the pipe if it's

CVS commit: src/sys/dev/usb

2022-08-20 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Aug 20 12:30:00 UTC 2022 Modified Files: src/sys/dev/usb: usbnet.c Log Message: usbnet(9): Revert previous -- usbnet_media_upd does have IFNET_LOCK. Not sure why I thought otherwise. To generate a diff of this commit:

CVS commit: src/sys/dev/usb

2022-08-20 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Aug 20 12:30:00 UTC 2022 Modified Files: src/sys/dev/usb: usbnet.c Log Message: usbnet(9): Revert previous -- usbnet_media_upd does have IFNET_LOCK. Not sure why I thought otherwise. To generate a diff of this commit:

CVS commit: src/sys/dev/usb

2022-08-20 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Aug 20 12:28:25 UTC 2022 Modified Files: src/sys/dev/usb: usbnet.c Log Message: usbnet(9): Avoid ether_mediachange if stopped. We are called without IFNET_LOCK held here, so touching ifp->if_flags is forbidden, but that's

CVS commit: src/sys/dev/usb

2022-08-20 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Aug 20 12:28:25 UTC 2022 Modified Files: src/sys/dev/usb: usbnet.c Log Message: usbnet(9): Avoid ether_mediachange if stopped. We are called without IFNET_LOCK held here, so touching ifp->if_flags is forbidden, but that's

CVS commit: src/sys/dev/usb

2022-08-20 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Aug 20 11:32:20 UTC 2022 Modified Files: src/sys/dev/usb: usbdi.c usbdi.h Log Message: usbdi(9): Nix resurrected usbd_request_async. We killed this back in 2013, but it came back from the dead on a driver imported from

CVS commit: src/sys/dev/usb

2022-08-20 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Aug 20 11:32:20 UTC 2022 Modified Files: src/sys/dev/usb: usbdi.c usbdi.h Log Message: usbdi(9): Nix resurrected usbd_request_async. We killed this back in 2013, but it came back from the dead on a driver imported from

CVS commit: src/sys/dev/usb

2022-08-20 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Aug 20 11:32:08 UTC 2022 Modified Files: src/sys/dev/usb: if_umb.c Log Message: umb(4): Use usbd_do_request as drivers are intended to do. To generate a diff of this commit: cvs rdiff -u -r1.24 -r1.25

CVS commit: src/sys/dev/usb

2022-08-20 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Aug 20 11:32:08 UTC 2022 Modified Files: src/sys/dev/usb: if_umb.c Log Message: umb(4): Use usbd_do_request as drivers are intended to do. To generate a diff of this commit: cvs rdiff -u -r1.24 -r1.25

CVS commit: src/sys/dev/usb

2022-08-17 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Wed Aug 17 20:03:05 UTC 2022 Modified Files: src/sys/dev/usb: uhci.c Log Message: uhci(4): Fix wrong lock in callout_halt in uhci_suspend. Maybe this should just be unconditional and outside the lock to make it simpler.

CVS commit: src/sys/dev/usb

2022-08-17 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Wed Aug 17 20:03:05 UTC 2022 Modified Files: src/sys/dev/usb: uhci.c Log Message: uhci(4): Fix wrong lock in callout_halt in uhci_suspend. Maybe this should just be unconditional and outside the lock to make it simpler.

CVS commit: src/sys/dev/usb

2022-08-15 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Aug 16 00:44:20 UTC 2022 Modified Files: src/sys/dev/usb: usbnet.c Log Message: usbnet(9): Omit needless usbnet_core_mutex function. While here, use inline, not __inline__, since this is not a header file where inline

CVS commit: src/sys/dev/usb

2022-08-15 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Aug 16 00:44:20 UTC 2022 Modified Files: src/sys/dev/usb: usbnet.c Log Message: usbnet(9): Omit needless usbnet_core_mutex function. While here, use inline, not __inline__, since this is not a header file where inline

CVS commit: src/sys/dev/usb

2022-08-12 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Fri Aug 12 19:13:36 UTC 2022 Modified Files: src/sys/dev/usb: if_rum.c Log Message: rum(4): Avoid uninitialized garbage in failed register read. Reported-by: syzbot+f2cba71b1b1bc9102...@syzkaller.appspotmail.com

CVS commit: src/sys/dev/usb

2022-08-12 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Fri Aug 12 19:13:36 UTC 2022 Modified Files: src/sys/dev/usb: if_rum.c Log Message: rum(4): Avoid uninitialized garbage in failed register read. Reported-by: syzbot+f2cba71b1b1bc9102...@syzkaller.appspotmail.com

CVS commit: src/sys/dev/usb

2022-08-12 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Fri Aug 12 11:25:46 UTC 2022 Modified Files: src/sys/dev/usb: usbnet.c Log Message: usbnet(9): Fix mbuf alignment and narrow bounds check. In usbnet.c rev. 1.16, usbnet_newbuf was first passed a buffer length to verify it

CVS commit: src/sys/dev/usb

2022-08-12 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Fri Aug 12 11:25:46 UTC 2022 Modified Files: src/sys/dev/usb: usbnet.c Log Message: usbnet(9): Fix mbuf alignment and narrow bounds check. In usbnet.c rev. 1.16, usbnet_newbuf was first passed a buffer length to verify it

CVS commit: src/sys/dev/usb

2022-08-07 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Aug 7 23:49:30 UTC 2022 Modified Files: src/sys/dev/usb: usbnet.c Log Message: usbnet(9): Simplify assertions now that urndis(4) is less sketchy. To generate a diff of this commit: cvs rdiff -u -r1.94 -r1.95

CVS commit: src/sys/dev/usb

2022-08-07 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Aug 7 23:49:30 UTC 2022 Modified Files: src/sys/dev/usb: usbnet.c Log Message: usbnet(9): Simplify assertions now that urndis(4) is less sketchy. To generate a diff of this commit: cvs rdiff -u -r1.94 -r1.95

CVS commit: src/sys/dev/usb

2022-08-07 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Aug 7 11:25:33 UTC 2022 Modified Files: src/sys/dev/usb: uirda.c Log Message: uirda(4): Unconditionally initializes mutexes and selq on attach. We're going to unconditionally destroy them on detach. Reported-by:

CVS commit: src/sys/dev/usb

2022-08-07 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Aug 7 11:25:33 UTC 2022 Modified Files: src/sys/dev/usb: uirda.c Log Message: uirda(4): Unconditionally initializes mutexes and selq on attach. We're going to unconditionally destroy them on detach. Reported-by:

CVS commit: src/sys/dev/usb

2022-07-31 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Sun Jul 31 13:01:17 UTC 2022 Modified Files: src/sys/dev/usb: umodem_common.c Log Message: Compute a unique port number from interface index. To generate a diff of this commit: cvs rdiff -u -r1.35 -r1.36

CVS commit: src/sys/dev/usb

2022-07-31 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Sun Jul 31 13:01:17 UTC 2022 Modified Files: src/sys/dev/usb: umodem_common.c Log Message: Compute a unique port number from interface index. To generate a diff of this commit: cvs rdiff -u -r1.35 -r1.36

CVS commit: src/sys/dev/usb

2022-07-31 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Sun Jul 31 12:59:26 UTC 2022 Modified Files: src/sys/dev/usb: if_urtwn.c Log Message: Don't report errors as timeout. To generate a diff of this commit: cvs rdiff -u -r1.104 -r1.105 src/sys/dev/usb/if_urtwn.c Please note that

CVS commit: src/sys/dev/usb

2022-07-31 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Sun Jul 31 12:59:26 UTC 2022 Modified Files: src/sys/dev/usb: if_urtwn.c Log Message: Don't report errors as timeout. To generate a diff of this commit: cvs rdiff -u -r1.104 -r1.105 src/sys/dev/usb/if_urtwn.c Please note that

CVS commit: src/sys/dev/usb

2022-07-29 Thread Rin Okuyama
Module Name:src Committed By: rin Date: Fri Jul 29 13:07:15 UTC 2022 Modified Files: src/sys/dev/usb: uslsa.c Log Message: PR kern/56946 Baud rate must be in little endian for SLSA_R_SET_BAUDRATE request. To generate a diff of this commit: cvs rdiff -u -r1.31 -r1.32

CVS commit: src/sys/dev/usb

2022-07-29 Thread Rin Okuyama
Module Name:src Committed By: rin Date: Fri Jul 29 13:07:15 UTC 2022 Modified Files: src/sys/dev/usb: uslsa.c Log Message: PR kern/56946 Baud rate must be in little endian for SLSA_R_SET_BAUDRATE request. To generate a diff of this commit: cvs rdiff -u -r1.31 -r1.32

CVS commit: src/sys/dev/usb

2022-07-06 Thread Juergen Hannken-Illjes
Module Name:src Committed By: hannken Date: Wed Jul 6 15:24:14 UTC 2022 Modified Files: src/sys/dev/usb: uplcom.c Log Message: Add missing brace. To generate a diff of this commit: cvs rdiff -u -r1.93 -r1.94 src/sys/dev/usb/uplcom.c Please note that diffs are not

CVS commit: src/sys/dev/usb

2022-07-06 Thread Juergen Hannken-Illjes
Module Name:src Committed By: hannken Date: Wed Jul 6 15:24:14 UTC 2022 Modified Files: src/sys/dev/usb: uplcom.c Log Message: Add missing brace. To generate a diff of this commit: cvs rdiff -u -r1.93 -r1.94 src/sys/dev/usb/uplcom.c Please note that diffs are not

CVS commit: src/sys/dev/usb

2022-07-06 Thread Nathanial Sloss
Module Name:src Committed By: nat Date: Wed Jul 6 06:25:24 UTC 2022 Modified Files: src/sys/dev/usb: uplcom.c Log Message: Cosmetic changes. No functional change intended. To generate a diff of this commit: cvs rdiff -u -r1.92 -r1.93 src/sys/dev/usb/uplcom.c Please

CVS commit: src/sys/dev/usb

2022-07-06 Thread Nathanial Sloss
Module Name:src Committed By: nat Date: Wed Jul 6 06:25:24 UTC 2022 Modified Files: src/sys/dev/usb: uplcom.c Log Message: Cosmetic changes. No functional change intended. To generate a diff of this commit: cvs rdiff -u -r1.92 -r1.93 src/sys/dev/usb/uplcom.c Please

CVS commit: src/sys/dev/usb

2022-07-06 Thread Nathanial Sloss
Module Name:src Committed By: nat Date: Wed Jul 6 06:00:40 UTC 2022 Modified Files: src/sys/dev/usb: uplcom.c Log Message: Add support for HXN variants from openbsd. To generate a diff of this commit: cvs rdiff -u -r1.91 -r1.92 src/sys/dev/usb/uplcom.c Please note

CVS commit: src/sys/dev/usb

2022-07-06 Thread Nathanial Sloss
Module Name:src Committed By: nat Date: Wed Jul 6 06:00:40 UTC 2022 Modified Files: src/sys/dev/usb: uplcom.c Log Message: Add support for HXN variants from openbsd. To generate a diff of this commit: cvs rdiff -u -r1.91 -r1.92 src/sys/dev/usb/uplcom.c Please note

CVS commit: src/sys/dev/usb

2022-06-30 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Fri Jul 1 01:08:06 UTC 2022 Modified Files: src/sys/dev/usb: umidi.c Log Message: umidi(4): Clarify loops. No functional change intended. To generate a diff of this commit: cvs rdiff -u -r1.88 -r1.89

CVS commit: src/sys/dev/usb

2022-06-30 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Fri Jul 1 01:08:06 UTC 2022 Modified Files: src/sys/dev/usb: umidi.c Log Message: umidi(4): Clarify loops. No functional change intended. To generate a diff of this commit: cvs rdiff -u -r1.88 -r1.89

CVS commit: src/sys/dev/usb

2022-06-30 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Fri Jul 1 01:07:32 UTC 2022 Modified Files: src/sys/dev/usb: if_upgt.c Log Message: upgt(4): Make upgt_free_cmd match upgt_alloc_cmd. Reported-by: syzbot+365e26863f286c667...@syzkaller.appspotmail.com To generate a diff of

<    1   2   3   4   5   6   7   8   9   10   >