Module Name:src
Committed By: riastradh
Date: Sat Apr 22 14:23:50 UTC 2023
Modified Files:
src/sys/kern: sys_descrip.c
Log Message:
fcntl(2), flock(2): Unify error branches.
Let's make this a bit less error-prone by having everything converge
in the same place instead of
Module Name:src
Committed By: riastradh
Date: Sat Apr 22 14:23:50 UTC 2023
Modified Files:
src/sys/kern: sys_descrip.c
Log Message:
fcntl(2), flock(2): Unify error branches.
Let's make this a bit less error-prone by having everything converge
in the same place instead of
Module Name:src
Committed By: riastradh
Date: Sat Apr 22 14:23:32 UTC 2023
Modified Files:
src/sys/kern: sys_descrip.c
Log Message:
fcntl(2), flock(2): Fix missing fd_putfile in error branch.
Oops!
To generate a diff of this commit:
cvs rdiff -u -r1.43 -r1.44
Module Name:src
Committed By: riastradh
Date: Sat Apr 22 14:23:32 UTC 2023
Modified Files:
src/sys/kern: sys_descrip.c
Log Message:
fcntl(2), flock(2): Fix missing fd_putfile in error branch.
Oops!
To generate a diff of this commit:
cvs rdiff -u -r1.43 -r1.44
Module Name:src
Committed By: riastradh
Date: Sat Apr 22 11:58:01 UTC 2023
Modified Files:
src/sys/kern: subr_disk.c
Log Message:
disk(9): Fix missing unlock in error branch in previous change.
Reported-by: syzbot+870665adaf8911c0d...@syzkaller.appspotmail.com
Module Name:src
Committed By: riastradh
Date: Sat Apr 22 11:58:01 UTC 2023
Modified Files:
src/sys/kern: subr_disk.c
Log Message:
disk(9): Fix missing unlock in error branch in previous change.
Reported-by: syzbot+870665adaf8911c0d...@syzkaller.appspotmail.com
Module Name:src
Committed By: riastradh
Date: Sat Apr 22 11:22:36 UTC 2023
Modified Files:
src/sys/kern: vfs_vnops.c
Log Message:
readdir(2), lseek(2): Fix races in access to struct file::f_offset.
For non-directory vnodes:
- reading f_offset requires a shared or
Module Name:src
Committed By: riastradh
Date: Sat Apr 22 11:22:36 UTC 2023
Modified Files:
src/sys/kern: vfs_vnops.c
Log Message:
readdir(2), lseek(2): Fix races in access to struct file::f_offset.
For non-directory vnodes:
- reading f_offset requires a shared or
Module Name:src
Committed By: riastradh
Date: Fri Apr 21 18:30:04 UTC 2023
Modified Files:
src/sys/kern: subr_disk.c
Log Message:
disk(9): Fix use-after-free race with concurrent disk_set_info.
This can happen with dk(4), which allows wedges to have their size
increased
Module Name:src
Committed By: riastradh
Date: Fri Apr 21 18:30:04 UTC 2023
Modified Files:
src/sys/kern: subr_disk.c
Log Message:
disk(9): Fix use-after-free race with concurrent disk_set_info.
This can happen with dk(4), which allows wedges to have their size
increased
Module Name:src
Committed By: riastradh
Date: Fri Apr 21 17:35:43 UTC 2023
Modified Files:
src/sys/kern: subr_autoconf.c
Log Message:
autoconf(9): Add a comment where we risk arithmetic overflow.
To generate a diff of this commit:
cvs rdiff -u -r1.309 -r1.310
Module Name:src
Committed By: riastradh
Date: Fri Apr 21 17:35:43 UTC 2023
Modified Files:
src/sys/kern: subr_autoconf.c
Log Message:
autoconf(9): Add a comment where we risk arithmetic overflow.
To generate a diff of this commit:
cvs rdiff -u -r1.309 -r1.310
Module Name:src
Committed By: skrll
Date: Mon Apr 17 08:14:51 UTC 2023
Modified Files:
src/sys/kern: subr_kobj.c
Log Message:
KNF
To generate a diff of this commit:
cvs rdiff -u -r1.76 -r1.77 src/sys/kern/subr_kobj.c
Please note that diffs are not public domain; they
Module Name:src
Committed By: skrll
Date: Mon Apr 17 08:14:51 UTC 2023
Modified Files:
src/sys/kern: subr_kobj.c
Log Message:
KNF
To generate a diff of this commit:
cvs rdiff -u -r1.76 -r1.77 src/sys/kern/subr_kobj.c
Please note that diffs are not public domain; they
Module Name:src
Committed By: riastradh
Date: Sun Apr 16 11:18:25 UTC 2023
Modified Files:
src/sys/kern: subr_autoconf.c
Log Message:
autoconf(9): Assert alldevs_lock held in config_unit_nextfree.
The one caller, config_unit_alloc, guarantees it through
Module Name:src
Committed By: riastradh
Date: Sun Apr 16 11:18:25 UTC 2023
Modified Files:
src/sys/kern: subr_autoconf.c
Log Message:
autoconf(9): Assert alldevs_lock held in config_unit_nextfree.
The one caller, config_unit_alloc, guarantees it through
Module Name:src
Committed By: riastradh
Date: Sun Apr 16 11:14:58 UTC 2023
Modified Files:
src/sys/kern: subr_autoconf.c
Log Message:
autoconf(9): Avoid potential ABA bug in config_makeroom.
When we unlock alldevs_lock to allocate a new cd_devs array nsp,
other threads
Module Name:src
Committed By: riastradh
Date: Sun Apr 16 11:14:58 UTC 2023
Modified Files:
src/sys/kern: subr_autoconf.c
Log Message:
autoconf(9): Avoid potential ABA bug in config_makeroom.
When we unlock alldevs_lock to allocate a new cd_devs array nsp,
other threads
Module Name:src
Committed By: riastradh
Date: Sun Apr 16 04:52:19 UTC 2023
Modified Files:
src/sys/kern: subr_pserialize.c
Log Message:
pserialize(9): Fix buggy assertion inside assertion.
If there has been a context switch, then we can't be in a pserialize
read section
Module Name:src
Committed By: riastradh
Date: Sun Apr 16 04:52:19 UTC 2023
Modified Files:
src/sys/kern: subr_pserialize.c
Log Message:
pserialize(9): Fix buggy assertion inside assertion.
If there has been a context switch, then we can't be in a pserialize
read section
Module Name:src
Committed By: riastradh
Date: Fri Apr 14 16:51:46 UTC 2023
Modified Files:
src/sys/kern: subr_pserialize.c
Log Message:
pserialize(9): Fix bug in recent micro-optimization.
curcpu() is always a valid struct cpu_info pointer, but curlwp->l_cpu
is not
Module Name:src
Committed By: riastradh
Date: Fri Apr 14 16:51:46 UTC 2023
Modified Files:
src/sys/kern: subr_pserialize.c
Log Message:
pserialize(9): Fix bug in recent micro-optimization.
curcpu() is always a valid struct cpu_info pointer, but curlwp->l_cpu
is not
Module Name:src
Committed By: riastradh
Date: Tue Apr 11 13:06:21 UTC 2023
Modified Files:
src/sys/kern: subr_thmap.c
Log Message:
thmap(9): kmem_zalloc(KM_SLEEP) never fails. Prune dead branch.
To generate a diff of this commit:
cvs rdiff -u -r1.12 -r1.13
Module Name:src
Committed By: riastradh
Date: Tue Apr 11 13:06:21 UTC 2023
Modified Files:
src/sys/kern: subr_thmap.c
Log Message:
thmap(9): kmem_zalloc(KM_SLEEP) never fails. Prune dead branch.
To generate a diff of this commit:
cvs rdiff -u -r1.12 -r1.13
Module Name:src
Committed By: riastradh
Date: Tue Apr 11 10:23:47 UTC 2023
Modified Files:
src/sys/kern: tty.c
Log Message:
ttwrite(9): Assert we mangle uio_resid only if we also return error.
To generate a diff of this commit:
cvs rdiff -u -r1.308 -r1.309
Module Name:src
Committed By: riastradh
Date: Tue Apr 11 10:23:47 UTC 2023
Modified Files:
src/sys/kern: tty.c
Log Message:
ttwrite(9): Assert we mangle uio_resid only if we also return error.
To generate a diff of this commit:
cvs rdiff -u -r1.308 -r1.309
Module Name:src
Committed By: riastradh
Date: Tue Apr 11 10:22:04 UTC 2023
Modified Files:
src/sys/kern: subr_copy.c
Log Message:
uiomove(9): Stronger assertions about iov array.
To generate a diff of this commit:
cvs rdiff -u -r1.17 -r1.18 src/sys/kern/subr_copy.c
Module Name:src
Committed By: riastradh
Date: Tue Apr 11 10:22:04 UTC 2023
Modified Files:
src/sys/kern: subr_copy.c
Log Message:
uiomove(9): Stronger assertions about iov array.
To generate a diff of this commit:
cvs rdiff -u -r1.17 -r1.18 src/sys/kern/subr_copy.c
Module Name:src
Committed By: riastradh
Date: Tue Apr 11 10:19:56 UTC 2023
Modified Files:
src/sys/kern: subr_msan.c
Log Message:
kmsan: Format exact instruction addresses relative to symbols.
To generate a diff of this commit:
cvs rdiff -u -r1.18 -r1.19
Module Name:src
Committed By: riastradh
Date: Tue Apr 11 10:19:56 UTC 2023
Modified Files:
src/sys/kern: subr_msan.c
Log Message:
kmsan: Format exact instruction addresses relative to symbols.
To generate a diff of this commit:
cvs rdiff -u -r1.18 -r1.19
Module Name:src
Committed By: riastradh
Date: Sun Apr 9 12:22:00 UTC 2023
Modified Files:
src/sys/kern: subr_pool.c
Log Message:
pool(9): Tweak branch prediction in pool_cache_get_paddr assertion.
No functional change intended.
To generate a diff of this commit:
cvs
Module Name:src
Committed By: riastradh
Date: Sun Apr 9 12:22:00 UTC 2023
Modified Files:
src/sys/kern: subr_pool.c
Log Message:
pool(9): Tweak branch prediction in pool_cache_get_paddr assertion.
No functional change intended.
To generate a diff of this commit:
cvs
Module Name:src
Committed By: riastradh
Date: Sun Apr 9 12:16:42 UTC 2023
Modified Files:
src/sys/kern: kern_synch.c
Log Message:
kpause(9): Simplify assertion. No functional change intended.
To generate a diff of this commit:
cvs rdiff -u -r1.353 -r1.354
Module Name:src
Committed By: riastradh
Date: Sun Apr 9 12:16:42 UTC 2023
Modified Files:
src/sys/kern: kern_synch.c
Log Message:
kpause(9): Simplify assertion. No functional change intended.
To generate a diff of this commit:
cvs rdiff -u -r1.353 -r1.354
Module Name:src
Committed By: riastradh
Date: Sun Apr 9 12:16:34 UTC 2023
Modified Files:
src/sys/kern: subr_pool.c
Log Message:
pool(9): Simplify assertion in pool_update_curpage.
Add message while here.
To generate a diff of this commit:
cvs rdiff -u -r1.288 -r1.289
Module Name:src
Committed By: riastradh
Date: Sun Apr 9 12:16:34 UTC 2023
Modified Files:
src/sys/kern: subr_pool.c
Log Message:
pool(9): Simplify assertion in pool_update_curpage.
Add message while here.
To generate a diff of this commit:
cvs rdiff -u -r1.288 -r1.289
Module Name:src
Committed By: riastradh
Date: Sun Apr 9 09:18:10 UTC 2023
Modified Files:
src/sys/kern: exec_subr.c kern_event.c kern_lwp.c kern_proc.c
kern_sig.c kern_sleepq.c kern_softint.c kern_sysctl.c
kern_turnstile.c kern_veriexec.c
Module Name:src
Committed By: riastradh
Date: Sun Apr 9 09:18:10 UTC 2023
Modified Files:
src/sys/kern: exec_subr.c kern_event.c kern_lwp.c kern_proc.c
kern_sig.c kern_sleepq.c kern_softint.c kern_sysctl.c
kern_turnstile.c kern_veriexec.c
Module Name:src
Committed By: riastradh
Date: Sun Apr 9 08:50:20 UTC 2023
Modified Files:
src/sys/kern: subr_kmem.c
Log Message:
kmem(9): Tweak branch predictions in fast paths.
To generate a diff of this commit:
cvs rdiff -u -r1.87 -r1.88 src/sys/kern/subr_kmem.c
Module Name:src
Committed By: riastradh
Date: Sun Apr 9 08:50:20 UTC 2023
Modified Files:
src/sys/kern: subr_kmem.c
Log Message:
kmem(9): Tweak branch predictions in fast paths.
To generate a diff of this commit:
cvs rdiff -u -r1.87 -r1.88 src/sys/kern/subr_kmem.c
Module Name:src
Committed By: riastradh
Date: Sun Apr 9 08:28:25 UTC 2023
Modified Files:
src/sys/kern: subr_pserialize.c
Log Message:
pserialize(9): Micro-optimize pserialize_read_exit.
Most of the time we're not cold, so let's convince gcc to make that a
statically
Module Name:src
Committed By: riastradh
Date: Sun Apr 9 08:28:25 UTC 2023
Modified Files:
src/sys/kern: subr_pserialize.c
Log Message:
pserialize(9): Micro-optimize pserialize_read_exit.
Most of the time we're not cold, so let's convince gcc to make that a
statically
Module Name:src
Committed By: riastradh
Date: Sun Apr 9 08:17:45 UTC 2023
Modified Files:
src/sys/kern: subr_pserialize.c
Log Message:
pserialize(9): Micro-optimize pserialize_not_in_read_section_p.
Load l_ncsw to test whether we have been preempted, rather than
loading
Module Name:src
Committed By: riastradh
Date: Sun Apr 9 08:17:45 UTC 2023
Modified Files:
src/sys/kern: subr_pserialize.c
Log Message:
pserialize(9): Micro-optimize pserialize_not_in_read_section_p.
Load l_ncsw to test whether we have been preempted, rather than
loading
Module Name:src
Committed By: riastradh
Date: Sun Apr 9 08:17:36 UTC 2023
Modified Files:
src/sys/kern: kern_lock.c
Log Message:
ASSERT_SLEEPABLE(9): Micro-optimize this a little bit.
This convinces gcc to do less -- make a smaller stack frame, compute
fewer conditional
Module Name:src
Committed By: riastradh
Date: Sun Apr 9 08:17:36 UTC 2023
Modified Files:
src/sys/kern: kern_lock.c
Log Message:
ASSERT_SLEEPABLE(9): Micro-optimize this a little bit.
This convinces gcc to do less -- make a smaller stack frame, compute
fewer conditional
Module Name:src
Committed By: skrll
Date: Sat Apr 1 06:30:20 UTC 2023
Modified Files:
src/sys/kern: uipc_mbuf.c
Log Message:
0x%p -> %p in KASSERTMSGs
To generate a diff of this commit:
cvs rdiff -u -r1.249 -r1.250 src/sys/kern/uipc_mbuf.c
Please note that diffs are
Module Name:src
Committed By: skrll
Date: Sat Apr 1 06:30:20 UTC 2023
Modified Files:
src/sys/kern: uipc_mbuf.c
Log Message:
0x%p -> %p in KASSERTMSGs
To generate a diff of this commit:
cvs rdiff -u -r1.249 -r1.250 src/sys/kern/uipc_mbuf.c
Please note that diffs are
Module Name:src
Committed By: riastradh
Date: Fri Mar 31 19:22:56 UTC 2023
Modified Files:
src/sys/kern: uipc_mbuf.c
Log Message:
mbuf(9): Sprinkle KASSERTMSG.
No functional change intended.
To generate a diff of this commit:
cvs rdiff -u -r1.248 -r1.249
Module Name:src
Committed By: riastradh
Date: Fri Mar 31 19:22:56 UTC 2023
Modified Files:
src/sys/kern: uipc_mbuf.c
Log Message:
mbuf(9): Sprinkle KASSERTMSG.
No functional change intended.
To generate a diff of this commit:
cvs rdiff -u -r1.248 -r1.249
Module Name:src
Committed By: riastradh
Date: Thu Mar 30 15:58:21 UTC 2023
Modified Files:
src/sys/kern: uipc_domain.c
Log Message:
sockaddr_alloc(9): Avoid uninitialized buffer in sockaddr_checklen.
Manifests only under DIAGNOSTIC because the DIAGNOSTIC check itself
Module Name:src
Committed By: riastradh
Date: Thu Mar 30 15:58:21 UTC 2023
Modified Files:
src/sys/kern: uipc_domain.c
Log Message:
sockaddr_alloc(9): Avoid uninitialized buffer in sockaddr_checklen.
Manifests only under DIAGNOSTIC because the DIAGNOSTIC check itself
Module Name:src
Committed By: bouyer
Date: Fri Mar 24 12:22:52 UTC 2023
Modified Files:
src/sys/kern: vfs_xattr.c
Log Message:
extattr_set_vp(): properly handle XATTR_REPLACE flags, FFSv2ea will return
ENOATTR, not ENODATA if the attribute is missing.
Makes glusterfs 10
Module Name:src
Committed By: bouyer
Date: Fri Mar 24 12:22:52 UTC 2023
Modified Files:
src/sys/kern: vfs_xattr.c
Log Message:
extattr_set_vp(): properly handle XATTR_REPLACE flags, FFSv2ea will return
ENOATTR, not ENODATA if the attribute is missing.
Makes glusterfs 10
Module Name:src
Committed By: riastradh
Date: Mon Mar 13 18:13:19 UTC 2023
Modified Files:
src/sys/kern: vfs_vnops.c
Log Message:
vn_open(9): Add assertion that vp is locked on return.
Null out vp internally out of paranoia so we'll crash in evaluating
the assertion if
Module Name:src
Committed By: riastradh
Date: Mon Mar 13 18:13:19 UTC 2023
Modified Files:
src/sys/kern: vfs_vnops.c
Log Message:
vn_open(9): Add assertion that vp is locked on return.
Null out vp internally out of paranoia so we'll crash in evaluating
the assertion if
Module Name:src
Committed By: riastradh
Date: Mon Mar 13 18:12:52 UTC 2023
Modified Files:
src/sys/kern: vfs_vnops.c
Log Message:
vn_open(9): Clarify that this returns a locked vnode.
Comment only, no functional change intended.
To generate a diff of this commit:
cvs
Module Name:src
Committed By: riastradh
Date: Mon Mar 13 18:12:52 UTC 2023
Modified Files:
src/sys/kern: vfs_vnops.c
Log Message:
vn_open(9): Clarify that this returns a locked vnode.
Comment only, no functional change intended.
To generate a diff of this commit:
cvs
Module Name:src
Committed By: riastradh
Date: Sun Mar 5 14:40:32 UTC 2023
Modified Files:
src/sys/kern: vfs_syscalls.c
Log Message:
open(2): Don't map ERESTART to EINTR.
If a file or device's open function returns ERESTART, respect that --
restart the syscall; don't
Module Name:src
Committed By: riastradh
Date: Sun Mar 5 14:40:32 UTC 2023
Modified Files:
src/sys/kern: vfs_syscalls.c
Log Message:
open(2): Don't map ERESTART to EINTR.
If a file or device's open function returns ERESTART, respect that --
restart the syscall; don't
Module Name:src
Committed By: riastradh
Date: Fri Mar 3 12:52:50 UTC 2023
Modified Files:
src/sys/kern: kern_entropy.c
Log Message:
entropy(9): Allow changing flags on all entropy sources at once.
Entropy sources should all have nonempty names, and this will enable
an
Module Name:src
Committed By: riastradh
Date: Fri Mar 3 12:52:50 UTC 2023
Modified Files:
src/sys/kern: kern_entropy.c
Log Message:
entropy(9): Allow changing flags on all entropy sources at once.
Entropy sources should all have nonempty names, and this will enable
an
Module Name:src
Committed By: riastradh
Date: Wed Mar 1 08:13:54 UTC 2023
Modified Files:
src/sys/kern: kern_entropy.c
Log Message:
random(4): Report number of bytes ready to read, not number of bits.
Only affects systems with the diagnostic and testing option
Module Name:src
Committed By: riastradh
Date: Wed Mar 1 08:13:54 UTC 2023
Modified Files:
src/sys/kern: kern_entropy.c
Log Message:
random(4): Report number of bytes ready to read, not number of bits.
Only affects systems with the diagnostic and testing option
Module Name:src
Committed By: skrll
Date: Sat Feb 25 08:22:00 UTC 2023
Modified Files:
src/sys/kern: kern_fork.c
Log Message:
Trailing whitespace
To generate a diff of this commit:
cvs rdiff -u -r1.229 -r1.230 src/sys/kern/kern_fork.c
Please note that diffs are not
Module Name:src
Committed By: skrll
Date: Sat Feb 25 08:22:00 UTC 2023
Modified Files:
src/sys/kern: kern_fork.c
Log Message:
Trailing whitespace
To generate a diff of this commit:
cvs rdiff -u -r1.229 -r1.230 src/sys/kern/kern_fork.c
Please note that diffs are not
Module Name:src
Committed By: riastradh
Date: Fri Feb 24 11:21:29 UTC 2023
Modified Files:
src/sys/kern: kern_mutex.c
Log Message:
mutex(9): Simplify membars.
- Elide macro indirection for membar_acquire.
- Use atomic_store_release instead of membar_release and store.
Module Name:src
Committed By: riastradh
Date: Fri Feb 24 11:21:29 UTC 2023
Modified Files:
src/sys/kern: kern_mutex.c
Log Message:
mutex(9): Simplify membars.
- Elide macro indirection for membar_acquire.
- Use atomic_store_release instead of membar_release and store.
Module Name:src
Committed By: riastradh
Date: Fri Feb 24 11:11:10 UTC 2023
Modified Files:
src/sys/kern: kern_rwlock.c
Log Message:
rwlock(9): Omit needless macro indirection for membars.
No functional change intended.
To generate a diff of this commit:
cvs rdiff -u
Module Name:src
Committed By: riastradh
Date: Fri Feb 24 11:11:10 UTC 2023
Modified Files:
src/sys/kern: kern_rwlock.c
Log Message:
rwlock(9): Omit needless macro indirection for membars.
No functional change intended.
To generate a diff of this commit:
cvs rdiff -u
Module Name:src
Committed By: riastradh
Date: Fri Feb 24 11:02:27 UTC 2023
Modified Files:
src/sys/kern: kern_auth.c kern_descrip.c kern_mutex_obj.c kern_rwlock.c
kern_rwlock_obj.c subr_copy.c subr_ipi.c subr_pcq.c subr_pool.c
sys_futex.c
Module Name:src
Committed By: riastradh
Date: Fri Feb 24 11:02:27 UTC 2023
Modified Files:
src/sys/kern: kern_auth.c kern_descrip.c kern_mutex_obj.c kern_rwlock.c
kern_rwlock_obj.c subr_copy.c subr_ipi.c subr_pcq.c subr_pool.c
sys_futex.c
Module Name:src
Committed By: riastradh
Date: Fri Feb 24 11:01:44 UTC 2023
Modified Files:
src/sys/kern: kern_rwlock.c
Log Message:
rwlock(9): Fix membars.
rw_downgrade must be a release operation, and rw_tryupgrade must be
an acquire operation. membar_producer is not
Module Name:src
Committed By: riastradh
Date: Fri Feb 24 11:01:44 UTC 2023
Modified Files:
src/sys/kern: kern_rwlock.c
Log Message:
rwlock(9): Fix membars.
rw_downgrade must be a release operation, and rw_tryupgrade must be
an acquire operation. membar_producer is not
Module Name:src
Committed By: riastradh
Date: Thu Feb 23 14:57:29 UTC 2023
Modified Files:
src/sys/kern: kern_lock.c kern_mutex.c
Log Message:
KERNEL_LOCK(9): Minor tweaks to ci->ci_biglock_wanted access.
1. Use atomic_load_relaxed to read ci->ci_biglock_wanted from
Module Name:src
Committed By: riastradh
Date: Thu Feb 23 14:57:29 UTC 2023
Modified Files:
src/sys/kern: kern_lock.c kern_mutex.c
Log Message:
KERNEL_LOCK(9): Minor tweaks to ci->ci_biglock_wanted access.
1. Use atomic_load_relaxed to read ci->ci_biglock_wanted from
Module Name:src
Committed By: riastradh
Date: Thu Feb 23 03:03:58 UTC 2023
Modified Files:
src/sys/kern: subr_pcq.c
Log Message:
pcq(9): KASSERT(A && B) -> KASSERT(A); KASSERT(B)
To generate a diff of this commit:
cvs rdiff -u -r1.18 -r1.19 src/sys/kern/subr_pcq.c
Module Name:src
Committed By: riastradh
Date: Thu Feb 23 03:03:58 UTC 2023
Modified Files:
src/sys/kern: subr_pcq.c
Log Message:
pcq(9): KASSERT(A && B) -> KASSERT(A); KASSERT(B)
To generate a diff of this commit:
cvs rdiff -u -r1.18 -r1.19 src/sys/kern/subr_pcq.c
Module Name:src
Committed By: riastradh
Date: Thu Feb 23 03:03:45 UTC 2023
Modified Files:
src/sys/kern: subr_pcq.c
Log Message:
pcq(9): Sketch correctness proof for some critical properties.
No functional change intended.
To generate a diff of this commit:
cvs rdiff
Module Name:src
Committed By: riastradh
Date: Thu Feb 23 03:03:45 UTC 2023
Modified Files:
src/sys/kern: subr_pcq.c
Log Message:
pcq(9): Sketch correctness proof for some critical properties.
No functional change intended.
To generate a diff of this commit:
cvs rdiff
Module Name:src
Committed By: riastradh
Date: Thu Feb 23 03:01:49 UTC 2023
Modified Files:
src/sys/kern: subr_pcq.c
Log Message:
pcq(9): Explain why membar_release isn't needed in pcq_get.
No functional change intended.
To generate a diff of this commit:
cvs rdiff -u
Module Name:src
Committed By: riastradh
Date: Thu Feb 23 03:01:49 UTC 2023
Modified Files:
src/sys/kern: subr_pcq.c
Log Message:
pcq(9): Explain why membar_release isn't needed in pcq_get.
No functional change intended.
To generate a diff of this commit:
cvs rdiff -u
Module Name:src
Committed By: riastradh
Date: Thu Feb 23 03:01:35 UTC 2023
Modified Files:
src/sys/kern: subr_pcq.c
Log Message:
pcq(9): Explain why store need not be atomic in pcq_get.
No functional change intended.
To generate a diff of this commit:
cvs rdiff -u
Module Name:src
Committed By: riastradh
Date: Thu Feb 23 03:01:35 UTC 2023
Modified Files:
src/sys/kern: subr_pcq.c
Log Message:
pcq(9): Explain why store need not be atomic in pcq_get.
No functional change intended.
To generate a diff of this commit:
cvs rdiff -u
Module Name:src
Committed By: riastradh
Date: Thu Feb 23 03:01:22 UTC 2023
Modified Files:
src/sys/kern: subr_pcq.c
Log Message:
pcq(9): Fix consume operation in pcq_peek/get.
These use atomic_load_consume to match the atomic_store_release in
pcq_put for
Module Name:src
Committed By: riastradh
Date: Thu Feb 23 03:01:22 UTC 2023
Modified Files:
src/sys/kern: subr_pcq.c
Log Message:
pcq(9): Fix consume operation in pcq_peek/get.
These use atomic_load_consume to match the atomic_store_release in
pcq_put for
Module Name:src
Committed By: riastradh
Date: Thu Feb 23 03:00:53 UTC 2023
Modified Files:
src/sys/kern: subr_pcq.c
Log Message:
pcq(9): Make pcq_put a release operation, in memory ordering.
Otherwise, for example, the following assertion could fail:
/*
Module Name:src
Committed By: riastradh
Date: Thu Feb 23 03:00:53 UTC 2023
Modified Files:
src/sys/kern: subr_pcq.c
Log Message:
pcq(9): Make pcq_put a release operation, in memory ordering.
Otherwise, for example, the following assertion could fail:
/*
Module Name:src
Committed By: riastradh
Date: Thu Feb 23 03:00:15 UTC 2023
Modified Files:
src/sys/kern: kern_descrip.c
Log Message:
kern_descrip.c: Change membar_enter to membar_acquire in fd_getfile.
membar_acquire is cheaper on many CPUs, and unlikely to be costlier
Module Name:src
Committed By: riastradh
Date: Thu Feb 23 03:00:15 UTC 2023
Modified Files:
src/sys/kern: kern_descrip.c
Log Message:
kern_descrip.c: Change membar_enter to membar_acquire in fd_getfile.
membar_acquire is cheaper on many CPUs, and unlikely to be costlier
Module Name:src
Committed By: riastradh
Date: Thu Feb 23 02:58:41 UTC 2023
Modified Files:
src/sys/kern: kern_descrip.c
Log Message:
kern_descrip.c: Use atomic_store_relaxed/release for ff->ff_file.
1. atomic_store_relaxed in fd_close avoids the appearance of race in
Module Name:src
Committed By: riastradh
Date: Thu Feb 23 02:58:41 UTC 2023
Modified Files:
src/sys/kern: kern_descrip.c
Log Message:
kern_descrip.c: Use atomic_store_relaxed/release for ff->ff_file.
1. atomic_store_relaxed in fd_close avoids the appearance of race in
Module Name:src
Committed By: riastradh
Date: Thu Feb 23 02:58:28 UTC 2023
Modified Files:
src/sys/kern: kern_descrip.c
Log Message:
kern_descrip.c: Fix membars around reference count decrement.
In general, the `last one out hit the lights' style of reference
counting
Module Name:src
Committed By: riastradh
Date: Thu Feb 23 02:58:28 UTC 2023
Modified Files:
src/sys/kern: kern_descrip.c
Log Message:
kern_descrip.c: Fix membars around reference count decrement.
In general, the `last one out hit the lights' style of reference
counting
Module Name:src
Committed By: riastradh
Date: Thu Feb 23 02:57:17 UTC 2023
Modified Files:
src/sys/kern: kern_time.c
Log Message:
itimer(9): Sprinkle some more assertions.
To generate a diff of this commit:
cvs rdiff -u -r1.220 -r1.221 src/sys/kern/kern_time.c
Please
Module Name:src
Committed By: riastradh
Date: Thu Feb 23 02:57:17 UTC 2023
Modified Files:
src/sys/kern: kern_time.c
Log Message:
itimer(9): Sprinkle some more assertions.
To generate a diff of this commit:
cvs rdiff -u -r1.220 -r1.221 src/sys/kern/kern_time.c
Please
Module Name:src
Committed By: riastradh
Date: Thu Feb 23 02:56:25 UTC 2023
Modified Files:
src/sys/kern: kern_time.c
Log Message:
itimer(9): Use callout_setfunc/schedule instead of callout_reset.
No semantic change intended.
To generate a diff of this commit:
cvs rdiff
Module Name:src
Committed By: riastradh
Date: Thu Feb 23 02:56:25 UTC 2023
Modified Files:
src/sys/kern: kern_time.c
Log Message:
itimer(9): Use callout_setfunc/schedule instead of callout_reset.
No semantic change intended.
To generate a diff of this commit:
cvs rdiff
Module Name:src
Committed By: riastradh
Date: Wed Feb 22 21:44:21 UTC 2023
Modified Files:
src/sys/kern: vfs_vnode.c
Log Message:
_vstate_assert: Use atomic_load/store_relaxed. Omit membar_enter.
Can't find anything this is supposed to pair with. Pretty sure this
is
Module Name:src
Committed By: riastradh
Date: Wed Feb 22 21:44:21 UTC 2023
Modified Files:
src/sys/kern: vfs_vnode.c
Log Message:
_vstate_assert: Use atomic_load/store_relaxed. Omit membar_enter.
Can't find anything this is supposed to pair with. Pretty sure this
is
301 - 400 of 1954 matches
Mail list logo
