Re: CVS commit: src/sys/kern

Christos Zoulas wrote: > Module Name: src > Committed By: christos > Date: Sun Apr 1 19:29:43 UTC 2018 > > Modified Files: > src/sys/kern: subr_prf.c > > Log Message: > Add the ability to prepend a timestamp [ sec.nsec] relative to boottime > in kernel messages if KLOG_TIMESTAMP

Re: CVS commit: src/sys/kern

On Fri, Mar 09, 2018 at 08:43:57PM +0100, Joerg Sonnenberger wrote: > > In this case pcu_valid should be 0, unless pcu is used for something else > > than FPU. > > What is happening exactly ? Is it a kernel panic ? do you have a stack > > trace ? > > OK, so there are two different error modes

Re: CVS commit: src/sys/kern

On Wed, Mar 07, 2018 at 11:10:52AM +0100, Manuel Bouyer wrote: > On Tue, Mar 06, 2018 at 03:43:24PM +0100, Joerg Sonnenberger wrote: > > > > This change is responsible for an instant trap of init(8) on evbppc, at > > > > least for the TWR1025. > > > > > > Do you have more details ? > > > I guess

Re: CVS commit: src/sys/kern

On Tue, Mar 06, 2018 at 03:43:24PM +0100, Joerg Sonnenberger wrote: > > > This change is responsible for an instant trap of init(8) on evbppc, at > > > least for the TWR1025. > > > > Do you have more details ? > > I guess it's because we now call pcu_state_release() with a possibly-NULL > >

Re: CVS commit: src/sys/kern

On Sat, Mar 03, 2018 at 08:44:46PM +0100, Manuel Bouyer wrote: > On Sat, Mar 03, 2018 at 07:29:23PM +0100, Joerg Sonnenberger wrote: > > On Mon, Oct 16, 2017 at 03:03:57PM +, Manuel Bouyer wrote: > > > Module Name: src > > > Committed By: bouyer > > > Date: Mon Oct 16

Re: CVS commit: src/sys/kern

On Sat, Mar 03, 2018 at 07:29:23PM +0100, Joerg Sonnenberger wrote: > On Mon, Oct 16, 2017 at 03:03:57PM +, Manuel Bouyer wrote: > > Module Name:src > > Committed By: bouyer > > Date: Mon Oct 16 15:03:57 UTC 2017 > > > > Modified Files: > > src/sys/kern:

Re: CVS commit: src/sys/kern

On Mon, Oct 16, 2017 at 03:03:57PM +, Manuel Bouyer wrote: > Module Name: src > Committed By: bouyer > Date: Mon Oct 16 15:03:57 UTC 2017 > > Modified Files: > src/sys/kern: subr_pcu.c > > Log Message: > PR port-arm/52603: This change is responsible for an instant trap of

Re: CVS commit: src/sys/kern

Christos Zoulas writes: > Log Message: > make sure that we have enough space, don't require the exact size > (Tom Ivar Helbekkmo) Oops. That wasn't enough. If we're going to allow the caller of getsockopt(2) to supply an oversized buffer for receiving the option data, we

Re: CVS commit: src/sys/kern

Tom Ivar Helbekkmo writes: > Wouldn't it be better to check that sopt->sopt_size >= len, and return > an error if not? ...in other words, something like this (the second change is for sockopt_setmbuf() a few lines down, where I suspect the same risk is present): Index:

Re: CVS commit: src/sys/kern

Christos Zoulas writes: > Log Message: > pass valsize for getsockopt like we do for setsockopt Looks like that uncovered something: Crash version 8.99.9, image version 8.99.9. System panicked: kernel diagnostic assertion "sopt->sopt_size == len" failed: file

Re: CVS commit: src/sys/kern

On 22.12.2017 17:58, Robert Elz wrote: > Date:Fri, 22 Dec 2017 23:35:12 +0700 > From:Robert Elz > Message-ID: <19521.1513960...@andromeda.noi.kre.to> > > | The EFAULT that is returned there is probably the one Kamil mentioned. > > And of course

Re: CVS commit: src/sys/kern

Date:Fri, 22 Dec 2017 23:35:12 +0700 From:Robert Elz Message-ID: <19521.1513960...@andromeda.noi.kre.to> | The EFAULT that is returned there is probably the one Kamil mentioned. And of course it is, as in the test ... if ((p != curproc

Re: CVS commit: src/sys/kern

Date:Fri, 22 Dec 2017 23:22:37 +0700 From:Robert Elz Message-ID: <1080.1513959...@andromeda.noi.kre.to> | where vm was declared as | | struct vmspace *vm; | | but is not otherwise initialised Well, not quite, I missed this call in

Re: CVS commit: src/sys/kern

Date:Fri, 22 Dec 2017 15:02:57 + From:"Kamil Rytarowski" Message-ID: <20171222150257.8e519f...@cvs.netbsd.org> | ptrace: Partially undo PT_{READ,WRITE}_{I,D} and unbreak these commands | | The refactored code did not work and was

Re: CVS commit: src/sys/kern

On Dec 17, 5:31am, p...@whooppee.com (Paul Goyette) wrote: -- Subject: Re: CVS commit: src/sys/kern | Does this break autoloading only of a non-built-in sysv_ipc module? Yes. | Or does it affect autoloading of any module? No. | And do we have a plan on how to restore the auto-load capability

Re: CVS commit: src/sys/kern

On Sat, 16 Dec 2017, Christos Zoulas wrote: Module Name:src Committed By: christos Date: Sat Dec 16 18:42:22 UTC 2017 Modified Files: src/sys/kern: kern_stub.c Log Message: Fix the build: XXX this might^Wwill break module autoloading... It is the general issue about

Re: CVS commit: src/sys/kern

Date:Fri, 25 Aug 2017 17:28:24 + (UTC) From:chris...@astron.com (Christos Zoulas) Message-ID: | Doesn't __nothing work? No idea, never heard of it ... feel free to change it to that if it works and is better. kre

Re: CVS commit: src/sys/kern

In article <20170824171856.11a6ef...@cvs.netbsd.org>, Robert Elz wrote: >-=-=-=-=-=- > >Module Name: src >Committed By: kre >Date: Thu Aug 24 17:18:55 UTC 2017 > >Modified Files: > src/sys/kern: subr_extent.c > >Log Message: >Build fix attempt ...

Re: CVS commit: src/sys/kern

On 08/24/17 18:18, Robert Elz wrote: Module Name:src Committed By: kre Date: Thu Aug 24 17:18:55 UTC 2017 Modified Files: src/sys/kern: subr_extent.c Log Message: Build fix attempt ... changes affect !KERNEL (ie: userland, rump) version of this file only. Rather than

Re: CVS commit: src/sys/kern

In article <20170614005237.85228f...@cvs.netbsd.org>, Chuck Silvers wrote: >-=-=-=-=-=- > >Module Name: src >Committed By: chs >Date: Wed Jun 14 00:52:37 UTC 2017 > >Modified Files: > src/sys/kern: kern_ksyms.c > >Log Message: >create an nmap table

Re: CVS commit: src/sys/kern

On 21.04.2017 18:09, Martin Husemann wrote: > On Fri, Apr 21, 2017 at 05:50:41PM +0200, Kamil Rytarowski wrote: > >> .section ".note.netbsd.ident", "", @note > > That is missing an "a" flag: > > .section ".note.netbsd.ident", "a", @note > > Look at readelf -a output, no program header is

Re: CVS commit: src/sys/kern

On Fri, Apr 21, 2017 at 05:50:41PM +0200, Kamil Rytarowski wrote: > .section ".note.netbsd.ident", "", @note That is missing an "a" flag: .section ".note.netbsd.ident", "a", @note Look at readelf -a output, no program header is generated for your variant, but if you add the flag, all is fine

Re: CVS commit: src/sys/kern

On 12.02.2017 22:52, Valeriy E. Ushakov wrote: > Module Name: src > Committed By: uwe > Date: Sun Feb 12 21:52:46 UTC 2017 > > Modified Files: > src/sys/kern: exec_elf.c > > Log Message: > netbsd_elf_signature - look at note segments (phdrs) not note > sections. They point to the

Re: CVS commit: src/sys/kern

On Mar 30, 12:27am, n...@gmx.com ("Kamil Rytarowski") wrote: -- Subject: Re: CVS commit: src/sys/kern | I've checked the emulation code and indeed, there is a variety of | possibilities. | There are longer and shorter AUX vectors. | | Two simple solutions: | - revert and keep som

Re: CVS commit: src/sys/kern

> Sent: Wednesday, March 29, 2017 at 11:27 PM > From: "Kamil Rytarowski" <n...@gmx.com> > To: "Christos Zoulas" <chris...@astron.com> > Cc: source-changes-d@NetBSD.org > Subject: Re: CVS commit: src/sys/kern > > > > > Sent: We

Re: CVS commit: src/sys/kern

> Sent: Wednesday, March 29, 2017 at 10:09 PM > From: "Christos Zoulas" <chris...@astron.com> > To: source-changes-d@NetBSD.org > Subject: Re: CVS commit: src/sys/kern > > In article <20170329195230.d895af...@cvs.netbsd.org>, > Kamil Ryt

Re: CVS commit: src/sys/kern

In article <20170329195230.d895af...@cvs.netbsd.org>, Kamil Rytarowski wrote: >-=-=-=-=-=- > >Module Name: src >Committed By: kamil >Date: Wed Mar 29 19:52:30 UTC 2017 > >Modified Files: > src/sys/kern: core_elf32.c sys_ptrace_common.c > >Log

re: CVS commit: src/sys/kern

"Christos Zoulas" writes: > Module Name: src > Committed By: christos > Date: Thu Jan 26 15:54:31 UTC 2017 > > Modified Files: > src/sys/kern: kern_proc.c > > Log Message: > use __HAVE_COMPAT_NETBSD32 this is ugly. and gross. we should be removing refs to compat code from the

Re: CVS commit: src/sys/kern

On Wed, Jan 25, 2017 at 12:57:14PM -0500, Christos Zoulas wrote: > Module Name: src > Committed By: christos > Date: Wed Jan 25 17:57:14 UTC 2017 > > Modified Files: > src/sys/kern: kern_exec.c > > Log Message: > es_arglen is already in bytes... > > > To generate a diff of this

Re: CVS commit: src/sys/kern

> @@ -162,7 +162,7 @@ module_load_plist_vfs(const char *modpat > base = NULL; > > proppath = PNBUF_GET(); > - strcpy(proppath, modpath); > + strlcpy(proppath, modpath, MAXPATHLEN); > pathlen = strlen(proppath); > if ((pathlen >= 6) && (strcmp([pathlen - 5],

Re: CVS commit: src/sys/kern

On Sun, Jan 15, 2017 at 01:28:14AM +, Maya Rashish wrote: > - strcpy(name, t->l_name); > + strlcpy(name, t->l_name, sizeof(name)); > This seems limited in setname, and getname was unlimited. I don't see where else it is set, let me know if I'm wrong!

Re: CVS commit: src/sys/kern

On 09.01.2017 05:06, Christos Zoulas wrote: > On Jan 9, 4:40am, n...@gmx.com (Kamil Rytarowski) wrote: > -- Subject: Re: CVS commit: src/sys/kern > > | It's almost 5 years since commenting out - I assumed that it will rot to > | the point that it might need to be rewritten. A

Re: CVS commit: src/sys/kern

On Jan 9, 4:40am, n...@gmx.com (Kamil Rytarowski) wrote: -- Subject: Re: CVS commit: src/sys/kern | It's almost 5 years since commenting out - I assumed that it will rot to | the point that it might need to be rewritten. A reminder could be added | to roadmap and the code is still there in code

Re: CVS commit: src/sys/kern

On 09.01.2017 04:36, Christos Zoulas wrote: > In article <20170109003130.33807f...@cvs.netbsd.org>, > Kamil Rytarowski wrote: >> -=-=-=-=-=- >> >> Module Name: src >> Committed By:kamil >> Date:Mon Jan 9 00:31:30 UTC 2017 >> >> Modified

Re: CVS commit: src/sys/kern

In article <20170109003130.33807f...@cvs.netbsd.org>, Kamil Rytarowski wrote: >-=-=-=-=-=- > >Module Name: src >Committed By: kamil >Date: Mon Jan 9 00:31:30 UTC 2017 > >Modified Files: > src/sys/kern: kern_exec.c kern_exit.c kern_fork.c > >Log

Re: CVS commit: src/sys/kern

On 29/12/16 07:27, David Holland wrote: > On Wed, Dec 28, 2016 at 07:32:05PM +, Taylor R Campbell wrote: > > It's true that moving the kauth call expanded the attack surface a > > little bit. Now we have to worry about: > > When I saw the original commit I wondered it if it was an

Re: CVS commit: src/sys/kern

On Wed, Dec 28, 2016 at 07:32:05PM +, Taylor R Campbell wrote: > It's true that moving the kauth call expanded the attack surface a > little bit. Now we have to worry about: When I saw the original commit I wondered it if it was an information leak. Maybe it's not, but that's certainly a

re: CVS commit: src/sys/kern

co...@sdf.org writes: > On Wed, Dec 28, 2016 at 12:05:58AM +, Roy Marples wrote: > > Can you please explain how the security model was broken? > > > > intention with securelevel is to do less things kernel-side > if it is raised (which, I hope, reduces our attack surface). > > I don't think

Re: CVS commit: src/sys/kern

On 27/12/16 09:34, Maya Rashish wrote: > Module Name: src > Committed By: maya > Date: Tue Dec 27 09:34:44 UTC 2016 > > Modified Files: > src/sys/kern: kern_module.c > > Log Message: > Revert previous commit (to r1.117) > > Superfluous warnings in simple userland programs is not

Re: CVS commit: src/sys/kern

On Fri, 18 Nov 2016, Paul Goyette wrote: Module Name:src Committed By: pgoyette Date: Fri Nov 18 02:37:33 UTC 2016 Modified Files: src/sys/kern: subr_bufq.c Log Message: By popular request, don't both initializing a static pointer to NULL. bother

re: CVS commit: src/sys/kern

Christos Zoulas writes: > In article <20161117080649.dc7dff...@cvs.netbsd.org>, > Paul Goyette wrote: > >-=-=-=-=-=- > > > >Module Name: src > >Committed By:pgoyette > >Date:Thu Nov 17 08:06:49 UTC 2016 > > > >Modified Files: > >

Re: CVS commit: src/sys/kern

In article <20161117080649.dc7dff...@cvs.netbsd.org>, Paul Goyette wrote: >-=-=-=-=-=- > >Module Name: src >Committed By: pgoyette >Date: Thu Nov 17 08:06:49 UTC 2016 > >Modified Files: > src/sys/kern: subr_bufq.c > >Log Message: >Use compile-time

Re: CVS commit: src/sys/kern

On Nov 14, 6:14am, n...@gmx.com (Kamil Rytarowski) wrote: -- Subject: Re: CVS commit: src/sys/kern | There is a side topic. how useful is /proc, as it was implemented in | order to address old (4.4BSD as far as I know) defects in ptrace(2). The | deficiencies have been addressed long time ago

Re: CVS commit: src/sys/kern

On 13.11.2016 03:39, Robert Elz wrote: > Date:Sun, 13 Nov 2016 02:44:03 +0100 > From:Kamil Rytarowski > Message-ID: <332a57da-1ac6-38ed-4fc3-947e2e6ca...@gmx.com> > > | I can add a test for it, comparing old parent identifier with p_ppid > | from

Re: CVS commit: src/sys/kern

On Nov 13, 8:39am, k...@munnari.oz.au (Robert Elz) wrote: -- Subject: Re: CVS commit: src/sys/kern | Date:Sat, 12 Nov 2016 14:42:47 -0500 | From:"Christos Zoulas" <chris...@netbsd.org> | Message-ID: <20161112194247.37910f...@cvs.netbsd.org> |

Re: CVS commit: src/sys/kern

Date:Sun, 13 Nov 2016 12:13:48 +0700 From:Robert Elz Message-ID: <18703.1479014...@andromeda.noi.kre.to> | In an earlier message I said ... | and the modification of p_ppid there [to init] | could be handled outside proc_reparent() Too

Re: CVS commit: src/sys/kern

In an earlier message I said ... | Maybe the real bug here was that proc_reparent() is changing the | child's p_ppid ? | | I can see no reason for that, There is one, an obvious one, I had forgotten ... when a child is inherited by init, we want its ppid to become 1. That one is

Re: CVS commit: src/sys/kern

Date:Sun, 13 Nov 2016 02:44:03 +0100 From:Kamil Rytarowski Message-ID: <332a57da-1ac6-38ed-4fc3-947e2e6ca...@gmx.com> | I can add a test for it, comparing old parent identifier with p_ppid | from kinfo_proc2. That would be useful, I suspect they

Re: CVS commit: src/sys/kern

On 13.11.2016 02:44, Kamil Rytarowski wrote: > > > On 13.11.2016 02:39, Robert Elz wrote: >> Date:Sat, 12 Nov 2016 14:42:47 -0500 >> From:"Christos Zoulas" >> Message-ID: <20161112194247.37910f...@cvs.netbsd.org> >> >> | PR/51624: Return the

Re: CVS commit: src/sys/kern

On 13.11.2016 02:39, Robert Elz wrote: > Date:Sat, 12 Nov 2016 14:42:47 -0500 > From:"Christos Zoulas" > Message-ID: <20161112194247.37910f...@cvs.netbsd.org> > > | PR/51624: Return the original parent for a traced process. > > Maybe the

Re: CVS commit: src/sys/kern

Date:Sat, 12 Nov 2016 14:42:47 -0500 From:"Christos Zoulas" Message-ID: <20161112194247.37910f...@cvs.netbsd.org> | PR/51624: Return the original parent for a traced process. Maybe the real bug here was that proc_reparent() is changing the

Re: CVS commit: src/sys/kern

On Nov 12, 5:47pm, u...@stderr.spb.ru (Valery Ushakov) wrote: -- Subject: Re: CVS commit: src/sys/kern | So what's going on here? I think that the tests were broken. I have reverted it... christos

Re: CVS commit: src/sys/kern

On 12.11.2016 15:47, Valery Ushakov wrote: > On Fri, Nov 11, 2016 at 12:10:04 -0500, Christos Zoulas wrote: > >> Date:Fri Nov 11 17:10:04 UTC 2016 >> >> Modified Files: >> src/sys/kern: sys_ptrace_common.c >> >> Log Message: >> kern/51621: When attaching to a child send it a

Re: CVS commit: src/sys/kern

On Fri, Nov 11, 2016 at 12:10:04 -0500, Christos Zoulas wrote: > Date: Fri Nov 11 17:10:04 UTC 2016 > > Modified Files: > src/sys/kern: sys_ptrace_common.c > > Log Message: > kern/51621: When attaching to a child send it a SIGTRAP not a SIGSTOP like > Linux and FreeBSD do. > > >

Re: CVS commit: src/sys/kern

On 11.11.2016 18:10, Christos Zoulas wrote: > Module Name: src > Committed By: christos > Date: Fri Nov 11 17:10:04 UTC 2016 > > Modified Files: > src/sys/kern: sys_ptrace_common.c > > Log Message: > kern/51621: When attaching to a child send it a SIGTRAP not a SIGSTOP like >

Re: CVS commit: src/sys/kern

Hello, On Fri, 4 Nov 2016 14:12:06 -0400 "Christos Zoulas" wrote: > Module Name: src > Committed By: christos > Date: Fri Nov 4 18:12:06 UTC 2016 > > Modified Files: > src/sys/kern: kern_exit.c > > Log Message: > Cleanup old parent from zombies too. Fixes

Re: CVS commit: src/sys/kern

On Mon, Oct 10, 2016 at 10:23:46AM +0300, Valery Ushakov wrote: > > Log Message: > > PR 49636 Henning Petersen: use "0L" to return 0 from a function returning > > long, and test its returned value against "0L" instead of "0". > > > > This is not especially necessary, but it's also harmless.

Re: CVS commit: src/sys/kern

On Mon, Oct 10, 2016 at 01:22:08 +, David A. Holland wrote: > Modified Files: > src/sys/kern: uipc_socket.c > > Log Message: > PR 49636 Henning Petersen: use "0L" to return 0 from a function returning > long, and test its returned value against "0L" instead of "0". > > This is not

Re: CVS commit: src/sys/kern

Le 21/09/2016 à 07:58, matthew green a écrit : "Maxime Villard" writes: Module Name:src Committed By: maxv Date: Sat Sep 17 12:00:35 UTC 2016 Modified Files: src/sys/kern: kern_proc.c Log Message: Use VM_MAXUSER_ADDRESS for proc0, not VM_MAX_ADDRESS. It normally does

re: CVS commit: src/sys/kern

"Maxime Villard" writes: > Module Name: src > Committed By: maxv > Date: Sat Sep 17 12:00:35 UTC 2016 > > Modified Files: > src/sys/kern: kern_proc.c > > Log Message: > Use VM_MAXUSER_ADDRESS for proc0, not VM_MAX_ADDRESS. It normally does not > change anything, since kernel

Re: CVS commit: src/sys/kern

On Fri, 15 Jul 2016, Christos Zoulas wrote: In article <20160714215706.414caf...@cvs.netbsd.org>, Paul Goyette wrote: -=-=-=-=-=- Module Name:src Committed By: pgoyette Date: Thu Jul 14 21:57:06 UTC 2016 Modified Files: src/sys/kern:

Re: CVS commit: src/sys/kern

In article <20160714215706.414caf...@cvs.netbsd.org>, Paul Goyette wrote: >-=-=-=-=-=- > >Module Name: src >Committed By: pgoyette >Date: Thu Jul 14 21:57:06 UTC 2016 > >Modified Files: > src/sys/kern: subr_autoconf.c > >Log Message: >Remove a call

Re: CVS commit: src/sys/kern

On Mon, Jun 20, 2016 at 03:14:35PM -0400, Christos Zoulas wrote: > Modified Files: > src/sys/kern: kern_exec.c > > Log Message: > put back commented out name resolution code that was gc'ed after previous > refactoring. Wait a moment, I thought we'd put in code to do getcwd for that

Re: CVS commit: src/sys/kern

In article <20150927143642.gb23...@snowdrop.l8s.co.uk>, David Laight wrote: >On Thu, Sep 24, 2015 at 10:30:52AM -0400, Christos Zoulas wrote: >> Module Name: src >> Committed By:christos >> Date:Thu Sep 24 14:30:52 UTC 2015 >> >> Modified Files: >>

Re: CVS commit: src/sys/kern

On Thu, Sep 24, 2015 at 10:30:52AM -0400, Christos Zoulas wrote: > Module Name: src > Committed By: christos > Date: Thu Sep 24 14:30:52 UTC 2015 > > Modified Files: > src/sys/kern: makesyscalls.sh > > Log Message: > create an array of altsyscallnames, which are the syscall names

Re: CVS commit: src/sys/kern

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 11.09.2015 03:23, Christos Zoulas wrote: > Module Name: src Committed By: christos Date: Fri Sep 11 > 01:23:37 > UTC 2015 > > Modified Files: src/sys/kern: kern_exec.c > > Log Message: On non absolute exec pathnames, prepend

Re: CVS commit: src/sys/kern

In article cadbf7eesqk_em_byggw_5d4x8hsewh_8or+wgyb15ffsfya...@mail.gmail.com, Masao Uebayashi uebay...@gmail.com wrote: On Fri, Aug 21, 2015 at 3:55 PM, Christos Zoulas chris...@netbsd.org wrote: Module Name:src Committed By: christos Date: Fri Aug 21 06:55:25 UTC 2015

Re: CVS commit: src/sys/kern

On Wed, Aug 19, 2015 at 02:05:33PM +1000, matthew green wrote: also: why did you not bring up this API change on tech-kern? I was going to say that needs-count needing to die is an old goal, but it turns out my config(5) is wrong and that defpseudo will not depend on needs-count being present

re: CVS commit: src/sys/kern

Masao Uebayashi writes: Module Name: src Committed By: uebayasi Date: Tue Aug 18 13:46:20 UTC 2015 Modified Files: src/sys/kern: kern_cpu.c kern_drvctl.c Log Message: Convert pseudo attach functions to take no arguments, as some functions (pppattach(), putterattach(),

Re: CVS commit: src/sys/kern

Can compilers warn that `variables that should not be used are mistakenly used'? If not, marking with `__unused' does not prove that those variables are really unused.

re: CVS commit: src/sys/kern

Masao Uebayashi writes: On Wed, Aug 19, 2015 at 10:27 AM, Paul Goyette p...@vps1.whooppee.com wrote: (snip) Wasn't the 'n' parameter supposed to be used to tell the driver how many instances of the pseudo-device should be instantiated? At least, for those drivers which do not

Re: CVS commit: src/sys/kern

Of course I can revert changes but I'd point out that pseudo attach functions were already inconsistent, and I want to fix that inconsistency. Could you list a number of other instances that use `int n'? On Wed, Aug 19, 2015 at 11:34 AM, matthew green m...@eterna.com.au wrote: Masao Uebayashi

re: CVS commit: src/sys/kern

Masao Uebayashi writes: Can compilers warn that `variables that should not be used are mistakenly used'? If not, marking with `__unused' does not prove that those variables are really unused. we do not support the use of marking arguments as unused. just read the code. it's pretty obvious

re: CVS commit: src/sys/kern

Masao Uebayashi writes: Of course I can revert changes but I'd point out that pseudo attach functions were already inconsistent, and I want to fix that inconsistency. can you show me these? if they're not taking an (unused) int argument, then they're already not consistent, and should be

re: CVS commit: src/sys/kern

also: why did you not bring up this API change on tech-kern? .mrg.

Re: CVS commit: src/sys/kern

On Wed, Aug 19, 2015 at 10:27 AM, Paul Goyette p...@vps1.whooppee.com wrote: (snip) Wasn't the 'n' parameter supposed to be used to tell the driver how many instances of the pseudo-device should be instantiated? At least, for those drivers which do not automatically clone? Yes. Have all of

Re: CVS commit: src/sys/kern

On Wed, Aug 19, 2015 at 5:31 AM, matthew green m...@eterna.com.au wrote: Masao Uebayashi writes: Module Name: src Committed By: uebayasi Date: Tue Aug 18 13:46:20 UTC 2015 Modified Files: src/sys/kern: kern_cpu.c kern_drvctl.c Log Message: Convert pseudo attach functions

Re: CVS commit: src/sys/kern

On Wed, 19 Aug 2015, Masao Uebayashi wrote: On Wed, Aug 19, 2015 at 5:31 AM, matthew green m...@eterna.com.au wrote: Masao Uebayashi writes: Module Name: src Committed By: uebayasi Date: Tue Aug 18 13:46:20 UTC 2015 Modified Files: src/sys/kern: kern_cpu.c kern_drvctl.c Log

Re: CVS commit: src/sys/kern

raidattach() doesn't seem to use `int num': http://nxr.netbsd.org/xref/src/sys/dev/raidframe/rf_netbsdkintf.c#395

Re: CVS commit: src/sys/kern

On Aug 7, 9:19pm, m...@m00nbsd.net (Maxime Villard) wrote: -- Subject: Re: CVS commit: src/sys/kern | In fact, I remember that at the time I wrote this patch - more than a | year ago -, I had read in the ELF spec that libraries normally don't | have an entry point, but that some do only

Re: CVS commit: src/sys/kern

In article 3d46b9f1-20f7-4e64-ae31-5da4192a0...@3am-software.com, Matt Thomas m...@3am-software.com wrote: On Aug 7, 2015, at 4:05 PM, matthew green m...@eterna.com.au wrote: linux ld.so has an entry point, for instance. IIRC, it's related to how their ldd(1) works. As does our

Re: CVS commit: src/sys/kern

Le 07/08/2015 11:38, Christos Zoulas a écrit : In article 21928.1438883...@splode.eterna.com.au, matthew green m...@eterna.com.au wrote: ya - this might actually break some linux binary packages, where there is a well-defined interface to executing a library. i think this part should be

re: CVS commit: src/sys/kern

Maxime Villard writes: Le 07/08/2015 11:38, Christos Zoulas a écrit : In article 21928.1438883...@splode.eterna.com.au, matthew green m...@eterna.com.au wrote: ya - this might actually break some linux binary packages, where there is a well-defined interface to executing a library.

Re: CVS commit: src/sys/kern

On Thu, Aug 06, 2015 at 03:51:38PM -0700, Matt Thomas wrote: It's also used for PIE which are usually DYN instead of EXEC. And we actually have tests for that! Martin

Re: CVS commit: src/sys/kern

In article 21928.1438883...@splode.eterna.com.au, matthew green m...@eterna.com.au wrote: ya - this might actually break some linux binary packages, where there is a well-defined interface to executing a library. i think this part should be reverted. Indeed: [5:16am] 1003#/lib/libc.so.6 GNU

Re: CVS commit: src/sys/kern

On Aug 7, 2015, at 4:05 PM, matthew green m...@eterna.com.au wrote: linux ld.so has an entry point, for instance. IIRC, it's related to how their ldd(1) works. As does our ld.elf_so.1

Re: CVS commit: src/sys/kern

On Aug 5, 2015, at 11:52 PM, Martin Husemann mar...@netbsd.org wrote: When I first ran into the exec a .so path I've been told it is a feature and exists on purpose (though our native in-tree libs do not make use of it). It's also used for PIE which are usually DYN instead of EXEC.

re: CVS commit: src/sys/kern

Martin Husemann writes: On Wed, Aug 05, 2015 at 03:58:01PM +, Maxime Villard wrote: Module Name:src Committed By: maxv Date: Wed Aug 5 15:58:01 UTC 2015 Modified Files: src/sys/kern: exec_elf.c Log Message: stupid comment, and make sure we

Re: CVS commit: src/sys/kern

On Wed, Aug 05, 2015 at 03:58:01PM +, Maxime Villard wrote: Module Name: src Committed By: maxv Date: Wed Aug 5 15:58:01 UTC 2015 Modified Files: src/sys/kern: exec_elf.c Log Message: stupid comment, and make sure we are not executing a lib When I first ran into the

Re: CVS commit: src/sys/kern

In article 20150503014244.gw1...@nef.pbox.org, Alistair Crooks a...@pkgsrc.org wrote: Hi Tyler, On Sat, May 02, 2015 at 11:46:05PM +, Tyler R. Retzlaff wrote: Module Name: src Committed By:rtr Date:Sat May 2 23:46:04 UTC 2015 Modified Files: src/sys/kern:

Re: CVS commit: src/sys/kern

hey, On 5/2/2015 9:42 PM, Alistair Crooks wrote: Hi Tyler, On Sat, May 02, 2015 at 11:46:05PM +, Tyler R. Retzlaff wrote: Module Name:src Committed By: rtr Date: Sat May 2 23:46:04 UTC 2015 Modified Files: src/sys/kern: uipc_socket.c Log Message: compare mbuf *

Re: CVS commit: src/sys/kern

On Sun, May 03, 2015 at 09:48:43AM -0400, Tyler Retzlaff wrote: hey, On 5/2/2015 9:42 PM, Alistair Crooks wrote: Hi Tyler, On Sat, May 02, 2015 at 11:46:05PM +, Tyler R. Retzlaff wrote: Module Name:src Committed By: rtr Date: Sat May 2 23:46:04 UTC 2015

Re: CVS commit: src/sys/kern

Hi On 2015/02/08 23:46, Michael van Elst wrote: Module Name:src Committed By: mlelstv Date: Sun Feb 8 14:46:30 UTC 2015 Modified Files: src/sys/kern: uipc_mbuf.c Log Message: Correct m_len calculation for m_dup() with mbuf clusters. Fixes kern/49650. To

Re: CVS commit: src/sys/kern

On 2015/02/09 13:27, Masanobu SAITOH wrote: Hi On 2015/02/08 23:46, Michael van Elst wrote: Module Name:src Committed By:mlelstv Date:Sun Feb 8 14:46:30 UTC 2015 Modified Files: src/sys/kern: uipc_mbuf.c Log Message: Correct m_len calculation for m_dup() with

Re: CVS commit: src/sys/kern

On Mon, Aug 18, 2014 at 04:49:17AM +, Christos Zoulas wrote: In article 20140817230358.6b94...@cvs.netbsd.org, Chuck Silvers source-changes-d@NetBSD.org wrote: -=-=-=-=-=- Module Name: src Committed By:chs Date:Sun Aug 17 23:03:58 UTC 2014 Modified Files:

Re: CVS commit: src/sys/kern

On Mon, Aug 18, 2014 at 07:14:46AM -0700, Chuck Silvers wrote: On Mon, Aug 18, 2014 at 04:49:17AM +, Christos Zoulas wrote: In article 20140817230358.6b94...@cvs.netbsd.org, Chuck Silvers source-changes-d@NetBSD.org wrote: -=-=-=-=-=- Module Name: src Committed By: chs

Re: CVS commit: src/sys/kern

On Aug 18, 7:14am, c...@chuq.com (Chuck Silvers) wrote: -- Subject: Re: CVS commit: src/sys/kern | On Mon, Aug 18, 2014 at 04:49:17AM +, Christos Zoulas wrote: | In article 20140817230358.6b94...@cvs.netbsd.org, | Chuck Silvers source-changes-d@NetBSD.org wrote

re: CVS commit: src/sys/kern

https://code.google.com/p/go/source/detail?spec=svnb86ee06ef235d5766845f44056f152e1808da110r=59a0284a32de10811abce538b94f97418d10561d hmmm, this code seems to imply that golang hard codes netbsd 5.99 version in the note, which seems like a recipe for future failure to me.. we get this info from

Re: CVS commit: src/sys/kern

In article 20140817230358.6b94...@cvs.netbsd.org, Chuck Silvers source-changes-d@NetBSD.org wrote: -=-=-=-=-=- Module Name: src Committed By: chs Date: Sun Aug 17 23:03:58 UTC 2014 Modified Files: src/sys/kern: exec_elf.c Log Message: eliminate COMPAT_OLDNOTE and just always

Re: CVS commit: src/sys/kern

On Thu, Jul 31, 2014 at 08:28:59PM +, matthew green wrote: Module Name: src Committed By: mrg Date: Thu Jul 31 20:28:59 UTC 2014 Modified Files: src/sys/kern: uipc_socket.c Log Message: call -pr_abort(so) now instead of generic PRU_ABORT. fixes kern/49056, and

<    1   2   3   4   5   6   7   >