Re: CVS commit: othersrc/zfs/external/cddl/osnet/dist

2009-03-26 Thread Simon Burge
Andrew Doran wrote:

 Module Name:  othersrc
 Committed By: ad
 Date: Thu Mar 26 21:50:47 UTC 2009
 
 Modified Files:
 
   othersrc/zfs/external/cddl/osnet/dist/cmd/zpool: zpool_vdev.c
   othersrc/zfs/external/cddl/osnet/dist/cmd/ztest: ztest.c
   othersrc/zfs/external/cddl/osnet/dist/uts/common/fs/zfs: arc.c dmu.c
   dsl_deleg.c spa.c spa_history.c vdev_disk.c zfs_ctldir.c zfs_dir.c
   zfs_ioctl.c zfs_vfsops.c zfs_znode.c zvol.c
   othersrc/zfs/external/cddl/osnet/dist/uts/common/fs/zfs/sys:
   vdev_disk.h zfs_znode.h zvol.h
 
 Log Message:
 
 Apply NetBSD changes.

Just out of interest...


Index: othersrc/zfs/external/cddl/osnet/dist/uts/common/fs/zfs/arc.c
diff -u othersrc/zfs/external/cddl/osnet/dist/uts/common/fs/zfs/arc.c:1.1.1.1 
othersrc/zfs/external/cddl/osnet/dist/uts/common/fs/zfs/arc.c:1.2
--- othersrc/zfs/external/cddl/osnet/dist/uts/common/fs/zfs/arc.c:1.1.1.1   
Fri Mar 27 08:43:43 2009
+++ othersrc/zfs/external/cddl/osnet/dist/uts/common/fs/zfs/arc.c   Fri Mar 
27 08:50:47 2009
@@ -133,6 +133,42 @@
 #include sys/callb.h
 #include sys/kstat.h
   
+#ifdef __NetBSD__
+#include uvm/uvm.h
+#definebtop(x) ((x) * PAGE_SIZE)
  [ ... ]

Isn't that working out pages to bytes and not bytes to pages ?

Unless btop() means something non-obvious in Solaris land...

Simon.


Re: CVS commit: othersrc/zfs/external/cddl/osnet/dist

2009-03-26 Thread Andrew Doran
On Thu, Mar 26, 2009 at 10:21:49PM +, Andrew Doran wrote:
 On Fri, Mar 27, 2009 at 09:14:40AM +1100, Simon Burge wrote:
 
  +#ifdef __NetBSD__
  +#include uvm/uvm.h
  +#definebtop(x) ((x) * PAGE_SIZE)
[ ... ]
  
  Isn't that working out pages to bytes and not bytes to pages ?
  
  Unless btop() means something non-obvious in Solaris land...
 
 Probably, please fix ;-)

By the way, this is basically the tarball that I posted to tech-kern in
January: it doesn't work yet. Interest has been expressed in finishing it.