Re: CVS commit: src/crypto/external/bsd/libsaslc/dist/src

2013-05-10 Thread Jukka Ruohonen 
On Fri, May 10, 2013 at 12:39:25PM -0400, Christos Zoulas wrote:
 Module Name:  src
 Committed By: christos
 Date: Fri May 10 16:39:25 UTC 2013
 
 Modified Files:
   src/crypto/external/bsd/libsaslc/dist/src: dict.c
 
 Log Message:
 use explicit_bzero instead of memset to zero memory

Can you briefly note what is __explicit_bzero(XXX) and why it should be used
instead of memset(3)?

- Jukka.

Re: CVS commit: src/crypto/external/bsd/libsaslc/dist/src

2011-02-14 Thread Takeshi Nakayama 
 Christos Zoulas chris...@netbsd.org wrote

 Module Name:  src
 Committed By: christos
 Date: Sun Feb 13 05:39:52 UTC 2011
 
 Modified Files:
   src/crypto/external/bsd/libsaslc/dist/src: mech.c
 
 Log Message:
 Make all mechanisms optional, so we can compile in only the ones we want.

 @@ -100,7 +106,9 @@
   saslc__error_set_errno(ERR(ctx), ERROR_NOMEM);
   return NULL;
   }
 - for (i = 0; saslc__mechanisms[i] != NULL; i++) {
 + for (i = 0; __arraycount(saslc__mechanisms); i++) {
 + if (saslc__mechanisms[i] == NULL)
 + continue;
   if ((node = calloc(1, sizeof(*node))) == NULL)
   goto error;

i  is missing?

-- Takeshi Nakayama

Re: CVS commit: src/crypto/external/bsd/libsaslc/dist/src

2011-02-14 Thread Christos Zoulas 
On Feb 14,  9:30pm, t...@catvmics.ne.jp (Takeshi Nakayama) wrote:
-- Subject: Re: CVS commit: src/crypto/external/bsd/libsaslc/dist/src

|  Christos Zoulas chris...@netbsd.org wrote
| 
|  Module Name:src
|  Committed By:   christos
|  Date:   Sun Feb 13 05:39:52 UTC 2011
|  
|  Modified Files:
|  src/crypto/external/bsd/libsaslc/dist/src: mech.c
|  
|  Log Message:
|  Make all mechanisms optional, so we can compile in only the ones we want.
| 
|  @@ -100,7 +106,9 @@
|  saslc__error_set_errno(ERR(ctx), ERROR_NOMEM);
|  return NULL;
|  }
|  -   for (i = 0; saslc__mechanisms[i] != NULL; i++) {
|  +   for (i = 0; __arraycount(saslc__mechanisms); i++) {
|  +   if (saslc__mechanisms[i] == NULL)
|  +   continue;
|  if ((node = calloc(1, sizeof(*node))) == NULL)
|  goto error;

Fixed, thanks.

christos