Re: CVS commit: src/external/apache2/llvm/config/llvm/Config
On Fri, Feb 21, 2020 at 11:13:24AM +0100, Kamil Rytarowski wrote: > On 21.02.2020 07:20, Martin Husemann wrote: > > On Fri, Feb 21, 2020 at 03:01:45AM +0100, Kamil Rytarowski wrote: > >> I consider calling ncurses-dev essential as a bug. > > > > My knee jerk reaction was: if a unix compiler needs terminfo (especially > > when it only does that to create coloured unreadable messages) it needs > > to be moved to pkgsrc. Same goes for a command line debugger. > > > > But if I understood Joerg's (extremely terse) objection: > > there should be logic in the tools build dealing with missing terminfo > > libs and this case needs more analyzis to understand why it fails. > > > > Martin > > > > This patch changes cryptic failure in linking to a verbose message: > > http://netbsd.org/~kamil/patch-00231-llvm-terminfo-tools.txt > > Does it look to commit? No, absolutely not. This is just making the problem a 100 times worse. Joerg
Re: CVS commit: src/external/apache2/llvm/config/llvm/Config
On Fri, Feb 21, 2020 at 11:13:24 +0100, Kamil Rytarowski wrote: > This patch changes cryptic failure in linking to a verbose message: > > http://netbsd.org/~kamil/patch-00231-llvm-terminfo-tools.txt > > Does it look to commit? The "devel library" is linux-specific terminology. There's no need for ALL CAPS. -uwe
Re: CVS commit: src/external/apache2/llvm/config/llvm/Config
On 21.02.2020 07:20, Martin Husemann wrote: > On Fri, Feb 21, 2020 at 03:01:45AM +0100, Kamil Rytarowski wrote: >> I consider calling ncurses-dev essential as a bug. > > My knee jerk reaction was: if a unix compiler needs terminfo (especially > when it only does that to create coloured unreadable messages) it needs > to be moved to pkgsrc. Same goes for a command line debugger. > > But if I understood Joerg's (extremely terse) objection: > there should be logic in the tools build dealing with missing terminfo > libs and this case needs more analyzis to understand why it fails. > > Martin > This patch changes cryptic failure in linking to a verbose message: http://netbsd.org/~kamil/patch-00231-llvm-terminfo-tools.txt Does it look to commit? A real fix (assuming we want terminfo in tools) is to build terminfo together with tools. I defer this to someone else. signature.asc Description: OpenPGP digital signature
Re: CVS commit: src/external/apache2/llvm/config/llvm/Config
On 21.02.2020 09:17, Leonardo Taccari wrote: > Kamil Rytarowski writes: >> [...] >> ./build.sh tools for LLVM is broken when host ships with no terminfo >> devel libraries. I tried to disable this superfluous feature for tools >> (for colors in a terminal), but it got reverted (breaking TNF rules) here. >> [...] > > Apart possible technical arguments, AFAICS the revert probably haven't > broken the rules: you have asked for feedback on #NetBSD@Freenode IRC > channel and then replied with a no but you have committed them > anyway. > This message was not reached/noted on my end (as it was not prefixed with my login over there) and later (next day) it was out of IRC log scroll buffer. I don't object formally. signature.asc Description: OpenPGP digital signature
Re: CVS commit: src/external/apache2/llvm/config/llvm/Config
Kamil Rytarowski writes: > [...] > ./build.sh tools for LLVM is broken when host ships with no terminfo > devel libraries. I tried to disable this superfluous feature for tools > (for colors in a terminal), but it got reverted (breaking TNF rules) here. > [...] Apart possible technical arguments, AFAICS the revert probably haven't broken the rules: you have asked for feedback on #NetBSD@Freenode IRC channel and then replied with a no but you have committed them anyway.
Re: CVS commit: src/external/apache2/llvm/config/llvm/Config
On Fri, Feb 21, 2020 at 03:01:45AM +0100, Kamil Rytarowski wrote: > I consider calling ncurses-dev essential as a bug. My knee jerk reaction was: if a unix compiler needs terminfo (especially when it only does that to create coloured unreadable messages) it needs to be moved to pkgsrc. Same goes for a command line debugger. But if I understood Joerg's (extremely terse) objection: there should be logic in the tools build dealing with missing terminfo libs and this case needs more analyzis to understand why it fails. Martin
Re: CVS commit: src/external/apache2/llvm/config/llvm/Config
On 21.02.2020 02:47, Christos Zoulas wrote: > So host needs to install terminfo-dev. How is that different from the host > environment needing to provide other pieces of the development environment? > For example if another tool needed openssl-dev, would we disable crypto? Or > if it needed yacc/bison or autoconf/automake wouldn't we rather install > those? Isn't simple to type one command to install the appropriate packages? > > christos > > christos > Maybe it is simpler to require terminfo, but it shall be verbose and fail in the 'configure' phase (the need-terminfo: target in tools/llvm/Makefile). It was breaking the public bot for cryptic reasons for a number of days. As far as I am aware the contract for ./build.sh tools was to bootstrap on a very minimal system with a functional essential development packages. I consider calling ncurses-dev essential as a bug. Requiring OpenSSL-dev would be worse as it is API incompatibile between versions and we promised to bootstrap from "anything". yacc, m4, make, gmake etc are tools generated on the top of essential packages. If we insist on terminfo-dev from host, it is better to build it as a tool. signature.asc Description: OpenPGP digital signature
Re: CVS commit: src/external/apache2/llvm/config/llvm/Config
So host needs to install terminfo-dev. How is that different from the host environment needing to provide other pieces of the development environment? For example if another tool needed openssl-dev, would we disable crypto? Or if it needed yacc/bison or autoconf/automake wouldn't we rather install those? Isn't simple to type one command to install the appropriate packages? christos christos > On Feb 20, 2020, at 7:32 PM, Kamil Rytarowski wrote: > > On 21.02.2020 01:17, Christos Zoulas wrote: >> In article <5f8df6c1-bb25-f24a-27fc-b3a752a6d...@gmx.com>, >> Kamil Rytarowski wrote: >> >>> We don't have any direct reproducer (we tried) and we must figure it out >>> from syzkaller bot. We don't have access to the machine and a limited >>> access to an admin over there (who has no expertise on BSDs). This >>> failure breaks kMSan build for long time now. There is full build log. >> >> If we don't undestand the problem we don't just disable code to make the >> tool happy. This is: hand hurts, amputate. Let's try to figure out what's >> wrong first. >> >>> Calling syzbot report useless does not help. Lack of support in the >>> build phase will result in removal of the bot instance and turn our work >>> into futile effort. >> >> We need to have more details in order to fix the problem. >> >> christos >> > > ./build.sh tools for LLVM is broken when host ships with no terminfo > devel libraries. I tried to disable this superfluous feature for tools > (for colors in a terminal), but it got reverted (breaking TNF rules) here. > > The broken tools logic was workarounded in the syzbot setup and we > installed there ncurses-dev package and the build passed. > > PR toolchain/54993 > >
Re: CVS commit: src/external/apache2/llvm/config/llvm/Config
On 21.02.2020 01:17, Christos Zoulas wrote: > In article <5f8df6c1-bb25-f24a-27fc-b3a752a6d...@gmx.com>, > Kamil Rytarowski wrote: > >> We don't have any direct reproducer (we tried) and we must figure it out >>from syzkaller bot. We don't have access to the machine and a limited >> access to an admin over there (who has no expertise on BSDs). This >> failure breaks kMSan build for long time now. There is full build log. > > If we don't undestand the problem we don't just disable code to make the > tool happy. This is: hand hurts, amputate. Let's try to figure out what's > wrong first. > >> Calling syzbot report useless does not help. Lack of support in the >> build phase will result in removal of the bot instance and turn our work >> into futile effort. > > We need to have more details in order to fix the problem. > > christos > ./build.sh tools for LLVM is broken when host ships with no terminfo devel libraries. I tried to disable this superfluous feature for tools (for colors in a terminal), but it got reverted (breaking TNF rules) here. The broken tools logic was workarounded in the syzbot setup and we installed there ncurses-dev package and the build passed. PR toolchain/54993 signature.asc Description: OpenPGP digital signature
Re: CVS commit: src/external/apache2/llvm/config/llvm/Config
In article <5f8df6c1-bb25-f24a-27fc-b3a752a6d...@gmx.com>, Kamil Rytarowski wrote: >We don't have any direct reproducer (we tried) and we must figure it out >from syzkaller bot. We don't have access to the machine and a limited >access to an admin over there (who has no expertise on BSDs). This >failure breaks kMSan build for long time now. There is full build log. If we don't undestand the problem we don't just disable code to make the tool happy. This is: hand hurts, amputate. Let's try to figure out what's wrong first. >Calling syzbot report useless does not help. Lack of support in the >build phase will result in removal of the bot instance and turn our work >into futile effort. We need to have more details in order to fix the problem. christos
Re: CVS commit: src/external/apache2/llvm/config/llvm/Config
On Thu, Feb 20, 2020 at 00:09:28 +, Roy Marples wrote: > On 19/02/2020 22:29, Kamil Rytarowski wrote: > > Why do you need terminfo/termios in ./build.sh tools? > > We build the nbtic tool so we can build the terminfo database. The database is not a problem. If we want to keep this code turned on in llvm we are better providing a small do-nothing libterminfo stub as a fallback that would claim that the current TERM doesn't support colors. -uwe
Re: CVS commit: src/external/apache2/llvm/config/llvm/Config
On Thu, Feb 20, 2020 at 10:54:50 +0100, Kamil Rytarowski wrote: > >> https://syzkaller.appspot.com/text?tag=CrashLog&x=11aafc09e0 > > > > Yes and that is completely useless for figuring out the why. > > We don't have any direct reproducer (we tried) and we must figure it > out from syzkaller bot. We don't have access to the machine and a > limited access to an admin over there (who has no expertise on > BSDs). This failure breaks kMSan build for long time now. There is > full build log. We can start by dropping "> /dev/null 2>&1" in tools/llvm/Makefile (may be temporarily). -uwe
Re: CVS commit: src/external/apache2/llvm/config/llvm/Config
On 20.02.2020 01:09, Roy Marples wrote: > On 19/02/2020 22:29, Kamil Rytarowski wrote: >> Why do you need terminfo/termios in ./build.sh tools? > > We build the nbtic tool so we can build the terminfo database. > > Roy I will try to have a look and switch to our internal terminfo. signature.asc Description: OpenPGP digital signature
Re: CVS commit: src/external/apache2/llvm/config/llvm/Config
On 19.02.2020 23:50, Joerg Sonnenberger wrote: > On Wed, Feb 19, 2020 at 11:29:09PM +0100, Kamil Rytarowski wrote: >> On 19.02.2020 23:03, Joerg Sonnenberger wrote: >>> On Wed, Feb 19, 2020 at 04:10:17PM +0100, Kamil Rytarowski wrote: On 19.02.2020 14:32, Joerg Sonnenberger wrote: > Module Name: src > Committed By: joerg > Date: Wed Feb 19 13:32:40 UTC 2020 > > Modified Files: > src/external/apache2/llvm/config/llvm/Config: config.h.in > > Log Message: > Revert last. It was objected to pre-commit, there is no actual error > analysis or report and there is existing logic supposed to handle this. > > > To generate a diff of this commit: > cvs rdiff -u -r1.2 -r1.3 \ > src/external/apache2/llvm/config/llvm/Config/config.h.in > > Please note that diffs are not public domain; they are subject to the > copyright notices on the relevant files. > Objected pre-commit? Nothing reached me and I see nothing in logs. No report? It was discussed in public syzkaller ML and semipublic IRC channel with 5 people involved. https://syzkaller.appspot.com/text?tag=CrashLog&x=11aafc09e0 No analysis? There is analysis in the commit message that we remove optional features. I request either to reintroduce it now or land another fix. >>> >>> While I am on many mailing lists, I'm certainly not on all lists. I >>> answered in the only forum where I saw the message. I am strongly >>> objecting here because you make the tools compiler a lot less usable. >>> You haven't acutally shown *why* the existing logic doesn't work. >>> >> >> The existing logic does not work as it is breaking bootstrap on >> Linux/Ubuntu as presented here: >> >> https://syzkaller.appspot.com/text?tag=CrashLog&x=11aafc09e0 > > Yes and that is completely useless for figuring out the why. > > Joerg > We don't have any direct reproducer (we tried) and we must figure it out from syzkaller bot. We don't have access to the machine and a limited access to an admin over there (who has no expertise on BSDs). This failure breaks kMSan build for long time now. There is full build log. Calling syzbot report useless does not help. Lack of support in the build phase will result in removal of the bot instance and turn our work into futile effort. signature.asc Description: OpenPGP digital signature
Re: CVS commit: src/external/apache2/llvm/config/llvm/Config
On 19/02/2020 22:29, Kamil Rytarowski wrote: Why do you need terminfo/termios in ./build.sh tools? We build the nbtic tool so we can build the terminfo database. Roy
Re: CVS commit: src/external/apache2/llvm/config/llvm/Config
On Wed, Feb 19, 2020 at 11:29:09PM +0100, Kamil Rytarowski wrote: > On 19.02.2020 23:03, Joerg Sonnenberger wrote: > > On Wed, Feb 19, 2020 at 04:10:17PM +0100, Kamil Rytarowski wrote: > >> On 19.02.2020 14:32, Joerg Sonnenberger wrote: > >>> Module Name: src > >>> Committed By: joerg > >>> Date: Wed Feb 19 13:32:40 UTC 2020 > >>> > >>> Modified Files: > >>> src/external/apache2/llvm/config/llvm/Config: config.h.in > >>> > >>> Log Message: > >>> Revert last. It was objected to pre-commit, there is no actual error > >>> analysis or report and there is existing logic supposed to handle this. > >>> > >>> > >>> To generate a diff of this commit: > >>> cvs rdiff -u -r1.2 -r1.3 \ > >>> src/external/apache2/llvm/config/llvm/Config/config.h.in > >>> > >>> Please note that diffs are not public domain; they are subject to the > >>> copyright notices on the relevant files. > >>> > >> > >> Objected pre-commit? Nothing reached me and I see nothing in logs. > >> > >> No report? It was discussed in public syzkaller ML and semipublic IRC > >> channel with 5 people involved. > >> > >> https://syzkaller.appspot.com/text?tag=CrashLog&x=11aafc09e0 > >> > >> No analysis? There is analysis in the commit message that we remove > >> optional features. > >> > >> I request either to reintroduce it now or land another fix. > > > > While I am on many mailing lists, I'm certainly not on all lists. I > > answered in the only forum where I saw the message. I am strongly > > objecting here because you make the tools compiler a lot less usable. > > You haven't acutally shown *why* the existing logic doesn't work. > > > > The existing logic does not work as it is breaking bootstrap on > Linux/Ubuntu as presented here: > > https://syzkaller.appspot.com/text?tag=CrashLog&x=11aafc09e0 Yes and that is completely useless for figuring out the why. Joerg
Re: CVS commit: src/external/apache2/llvm/config/llvm/Config
On 19.02.2020 23:03, Joerg Sonnenberger wrote: > On Wed, Feb 19, 2020 at 04:10:17PM +0100, Kamil Rytarowski wrote: >> On 19.02.2020 14:32, Joerg Sonnenberger wrote: >>> Module Name:src >>> Committed By: joerg >>> Date: Wed Feb 19 13:32:40 UTC 2020 >>> >>> Modified Files: >>> src/external/apache2/llvm/config/llvm/Config: config.h.in >>> >>> Log Message: >>> Revert last. It was objected to pre-commit, there is no actual error >>> analysis or report and there is existing logic supposed to handle this. >>> >>> >>> To generate a diff of this commit: >>> cvs rdiff -u -r1.2 -r1.3 \ >>> src/external/apache2/llvm/config/llvm/Config/config.h.in >>> >>> Please note that diffs are not public domain; they are subject to the >>> copyright notices on the relevant files. >>> >> >> Objected pre-commit? Nothing reached me and I see nothing in logs. >> >> No report? It was discussed in public syzkaller ML and semipublic IRC >> channel with 5 people involved. >> >> https://syzkaller.appspot.com/text?tag=CrashLog&x=11aafc09e0 >> >> No analysis? There is analysis in the commit message that we remove >> optional features. >> >> I request either to reintroduce it now or land another fix. > > While I am on many mailing lists, I'm certainly not on all lists. I > answered in the only forum where I saw the message. I am strongly > objecting here because you make the tools compiler a lot less usable. > You haven't acutally shown *why* the existing logic doesn't work. > The existing logic does not work as it is breaking bootstrap on Linux/Ubuntu as presented here: https://syzkaller.appspot.com/text?tag=CrashLog&x=11aafc09e0 > Joerg > Why do you need terminfo/termios in ./build.sh tools? We need to fix bootstrap on Linux and it is easier to remove terminfo features and termios ones. We don't need to handle terminal resizing detection or colors for tools. Instead of supporting these features dynamically it is easier to disable them unconditionally. But if you insist to detect them dynamically and maintain it, please land a patch that will resurrect the bot. signature.asc Description: OpenPGP digital signature
Re: CVS commit: src/external/apache2/llvm/config/llvm/Config
On Wed, Feb 19, 2020 at 04:10:17PM +0100, Kamil Rytarowski wrote: > On 19.02.2020 14:32, Joerg Sonnenberger wrote: > > Module Name:src > > Committed By: joerg > > Date: Wed Feb 19 13:32:40 UTC 2020 > > > > Modified Files: > > src/external/apache2/llvm/config/llvm/Config: config.h.in > > > > Log Message: > > Revert last. It was objected to pre-commit, there is no actual error > > analysis or report and there is existing logic supposed to handle this. > > > > > > To generate a diff of this commit: > > cvs rdiff -u -r1.2 -r1.3 \ > > src/external/apache2/llvm/config/llvm/Config/config.h.in > > > > Please note that diffs are not public domain; they are subject to the > > copyright notices on the relevant files. > > > > Objected pre-commit? Nothing reached me and I see nothing in logs. > > No report? It was discussed in public syzkaller ML and semipublic IRC > channel with 5 people involved. > > https://syzkaller.appspot.com/text?tag=CrashLog&x=11aafc09e0 > > No analysis? There is analysis in the commit message that we remove > optional features. > > I request either to reintroduce it now or land another fix. While I am on many mailing lists, I'm certainly not on all lists. I answered in the only forum where I saw the message. I am strongly objecting here because you make the tools compiler a lot less usable. You haven't acutally shown *why* the existing logic doesn't work. Joerg
Re: CVS commit: src/external/apache2/llvm/config/llvm/Config
On 19.02.2020 14:32, Joerg Sonnenberger wrote: > Module Name: src > Committed By: joerg > Date: Wed Feb 19 13:32:40 UTC 2020 > > Modified Files: > src/external/apache2/llvm/config/llvm/Config: config.h.in > > Log Message: > Revert last. It was objected to pre-commit, there is no actual error > analysis or report and there is existing logic supposed to handle this. > > > To generate a diff of this commit: > cvs rdiff -u -r1.2 -r1.3 \ > src/external/apache2/llvm/config/llvm/Config/config.h.in > > Please note that diffs are not public domain; they are subject to the > copyright notices on the relevant files. > Objected pre-commit? Nothing reached me and I see nothing in logs. No report? It was discussed in public syzkaller ML and semipublic IRC channel with 5 people involved. https://syzkaller.appspot.com/text?tag=CrashLog&x=11aafc09e0 No analysis? There is analysis in the commit message that we remove optional features. I request either to reintroduce it now or land another fix. signature.asc Description: OpenPGP digital signature
