Re: CVS commit: src/external/bsd/nvi/usr.bin/nvi

2021-02-25 Thread Christos Zoulas
Too bad, looks like they just made a copy of the FreeBSD changes. I will revert.

christos

> On Feb 25, 2021, at 6:47 PM, Rin Okuyama  wrote:
> 
> Hi,
> 
> This does not work since nvi requires non-standard wregex API, whose
> ``char *'' arguments are replaced by ``wchar_t *'' ones:
> 
> https://mail-index.netbsd.org/tech-userlevel/2008/08/06/msg000960.html
> https://mail-index.netbsd.org/tech-userlevel/2008/08/06/msg000967.html
> 
> In principle, we can rewrite nvi to use standard regex API, but this
> causes wide to multibyte char conversion *every time* for text search
> (internal encoding of nvi is wide char). I'm not sure whether this is
> acceptable for users of slow machines, who merely want to edit ASCII
> texts.
> 
> Thanks,
> rin
> 
> On 2021/02/26 6:56, Christos Zoulas wrote:
>> Module Name: src
>> Committed By:christos
>> Date:Thu Feb 25 21:56:35 UTC 2021
>> Modified Files:
>>  src/external/bsd/nvi/usr.bin/nvi: Makefile
>> Log Message:
>> we don't need the extra copy wide-regex anymore.
>> To generate a diff of this commit:
>> cvs rdiff -u -r1.22 -r1.23 src/external/bsd/nvi/usr.bin/nvi/Makefile
>> Please note that diffs are not public domain; they are subject to the
>> copyright notices on the relevant files.



signature.asc
Description: Message signed with OpenPGP


Re: CVS commit: src/external/bsd/nvi/usr.bin/nvi

2021-02-25 Thread Rin Okuyama

Hi,

This does not work since nvi requires non-standard wregex API, whose
``char *'' arguments are replaced by ``wchar_t *'' ones:

https://mail-index.netbsd.org/tech-userlevel/2008/08/06/msg000960.html
https://mail-index.netbsd.org/tech-userlevel/2008/08/06/msg000967.html

In principle, we can rewrite nvi to use standard regex API, but this
causes wide to multibyte char conversion *every time* for text search
(internal encoding of nvi is wide char). I'm not sure whether this is
acceptable for users of slow machines, who merely want to edit ASCII
texts.

Thanks,
rin

On 2021/02/26 6:56, Christos Zoulas wrote:

Module Name:src
Committed By:   christos
Date:   Thu Feb 25 21:56:35 UTC 2021

Modified Files:
src/external/bsd/nvi/usr.bin/nvi: Makefile

Log Message:
we don't need the extra copy wide-regex anymore.


To generate a diff of this commit:
cvs rdiff -u -r1.22 -r1.23 src/external/bsd/nvi/usr.bin/nvi/Makefile

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.


CVS commit: src/external/bsd/nvi/usr.bin/nvi

2019-10-29 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Tue Oct 29 21:14:37 UTC 2019

Modified Files:
src/external/bsd/nvi/usr.bin/nvi: Makefile

Log Message:
PR/54656: Martin Husemann: gcc-8 miscompiles ex_filter.c even with -O1, make
it -O0. The tm argument gets passed in as non-null and it is non-null after
the command execution, but then becomes null and causes a null dereference.


To generate a diff of this commit:
cvs rdiff -u -r1.19 -r1.20 src/external/bsd/nvi/usr.bin/nvi/Makefile

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/external/bsd/nvi/usr.bin/nvi

2019-10-29 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Tue Oct 29 21:14:37 UTC 2019

Modified Files:
src/external/bsd/nvi/usr.bin/nvi: Makefile

Log Message:
PR/54656: Martin Husemann: gcc-8 miscompiles ex_filter.c even with -O1, make
it -O0. The tm argument gets passed in as non-null and it is non-null after
the command execution, but then becomes null and causes a null dereference.


To generate a diff of this commit:
cvs rdiff -u -r1.19 -r1.20 src/external/bsd/nvi/usr.bin/nvi/Makefile

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/external/bsd/nvi/usr.bin/nvi/Makefile
diff -u src/external/bsd/nvi/usr.bin/nvi/Makefile:1.19 src/external/bsd/nvi/usr.bin/nvi/Makefile:1.20
--- src/external/bsd/nvi/usr.bin/nvi/Makefile:1.19	Wed Jul 24 04:37:59 2019
+++ src/external/bsd/nvi/usr.bin/nvi/Makefile	Tue Oct 29 17:14:37 2019
@@ -1,4 +1,4 @@
-#	$NetBSD: Makefile,v 1.19 2019/07/24 08:37:59 rin Exp $
+#	$NetBSD: Makefile,v 1.20 2019/10/29 21:14:37 christos Exp $
 
 .include 
 
@@ -114,6 +114,10 @@ version.h:	../../Makefile.inc
 #	${_MKTARGET_CREATE}
 #	${TOOL_PERL} -n ${.ALLSRC} > ${.TARGET}
 
+.if ${MACHINE_ARCH} == "aarch64"
+COPTS.ex_filter.c+=-O0
+.endif
+
 
 .include "${.CURDIR}/../../Makefile.inc"