Re: CVS commit: src/sys/arch/sparc64/dev

2020-10-24 Thread Julian Coleman
Hi Tobias, > If you're interested there is an older version[1] of envctrl in the > Attic that might be relevant to use for reference. It supported fan > speed controls on E450. IIRC I got some of the magic constants from > OpenSolaris. Sadly I don't own an E450 any more. > > [1] >

Re: CVS commit: src/sys/arch/sparc64/dev

2020-10-24 Thread Tobias Nygren
On Sat, 24 Oct 2020 15:16:39 + Julian Coleman wrote: > Module Name: src > Committed By: jdc > Date: Sat Oct 24 15:16:39 UTC 2020 > > Modified Files: > src/sys/arch/sparc64/dev: pcf8591_envctrl.c > > Log Message: > Add support for automatically changing the CPU fan speed on

Re: CVS commit: src/sys/dev/wsfb

2020-10-21 Thread Rin Okuyama
Hi, On 2020/10/21 15:42, Michael wrote: Hello, On Sun, 18 Oct 2020 11:54:21 + "Rin Okuyama" wrote: Module Name:src Committed By: rin Date: Sun Oct 18 11:54:21 UTC 2020 Modified Files: src/sys/dev/wsfb: genfb.c Log Message: For WSDISPLAYIO_GET_FBINFO ioctl, set

Re: CVS commit: src/sys/dev/wsfb

2020-10-21 Thread Michael
Hello, On Sun, 18 Oct 2020 11:54:21 + "Rin Okuyama" wrote: > Module Name: src > Committed By: rin > Date: Sun Oct 18 11:54:21 UTC 2020 > > Modified Files: > src/sys/dev/wsfb: genfb.c > > Log Message: > For WSDISPLAYIO_GET_FBINFO ioctl, set WSFB_VRAM_IS_RAM to fbi_flags >

Re: CVS commit: src/sys

2020-10-20 Thread Paul Goyette
This still isn't quite correct. For i386, a custom kernel build fails. Here's the diff between GENERIC and the custom config (this mirrors the config I used on amd64 to file the original PR kern/55731): --- GENERIC 2020-09-27 22:28:13.468056102 -0700 +++ TEST2020-10-20

Re: CVS commit: src/sys

2020-10-20 Thread Paul Goyette
I am getting errors, too, when I build a NOCOMPAT kernel: # link NOCOMPAT/netbsd /build/netbsd-compat/tools/x86_64/amd64/bin/x86_64--netbsd-ld -Map netbsd.map --cref -T netbsd.ldscript -Ttext 0x8020 -e start -z max-page-size=0x20 -X -o netbsd

Re: CVS commit: src/sys

2020-10-20 Thread Rin Okuyama
Hi, This causes build failures for LP64 archs without COMPAT_NETBSD32, i.e., alpha and ie64: kern_core.o: in function `coredump_modcmd': (.text+0x1c4): undefined reference to `real_coredump_elf32 https://releng.netbsd.org/builds/HEAD/202010200300Z/ (Failure for aarch64eb is irrelevant, and

Re: CVS commit: src/sys/kern

2020-10-19 Thread Christos Zoulas
In article <20201019144701.a6d3bf...@cvs.netbsd.org>, Kamil Rytarowski wrote: >-=-=-=-=-=- > >Module Name: src >Committed By: kamil >Date: Mon Oct 19 14:47:01 UTC 2020 > >Modified Files: > src/sys/kern: sys_ptrace.c sys_ptrace_common.c > >Log Message: >Remove obsolete references

Re: CVS commit: src/sys/dev/wsfb

2020-10-18 Thread Rin Okuyama
On 2020/10/18 21:18, Jared McNeill wrote: I think WSFB_VRAM_IS_RAM is meant to be a hint for what kind of memory you get when you mmap the device. When shadow FB is used, that is generally only used for rasops and mmap bypasses the shadow and uses device memory directly. So I think this could

Re: CVS commit: src/sys/dev/wsfb

2020-10-18 Thread Jared McNeill
I think WSFB_VRAM_IS_RAM is meant to be a hint for what kind of memory you get when you mmap the device. When shadow FB is used, that is generally only used for rasops and mmap bypasses the shadow and uses device memory directly. So I think this could cause performance regressions on such

Re: CVS commit: src/sys/dev/pci

2020-10-16 Thread SAITOH Masanobu
On 2020/10/16 14:53, SAITOH Masanobu wrote: Module Name:src Committed By: msaitoh Date: Fri Oct 16 05:53:40 UTC 2020 Modified Files: src/sys/dev/pci: if_wm.c Log Message: Fixes a problem that the attach function reported "wm_gmii_setup_phytype: Unknown PHY model.

Re: CVS commit: src/sys/arch/aarch64/aarch64

2020-10-13 Thread Martin Husemann
On Tue, Oct 13, 2020 at 12:57:44PM +0200, Kamil Rytarowski wrote: > > Log Message: > > BE32 binaries are no longer supported for ARMv7 and later, and > > therefore for aarch64eb. > > > > Reject them with ENOEXEC, rather than causing illegal instruction > > exceptions due to unexpected binary

Re: CVS commit: src/sys/arch/aarch64/aarch64

2020-10-13 Thread Rin Okuyama
On 2020/10/13 19:57, Kamil Rytarowski wrote: On 13.10.2020 09:04, Rin Okuyama wrote: Module Name:src Committed By: rin Date: Tue Oct 13 07:04:49 UTC 2020 Modified Files: src/sys/arch/aarch64/aarch64: exec_machdep.c Log Message: BE32 binaries are no longer supported for

Re: CVS commit: src/sys/arch/aarch64/aarch64

2020-10-13 Thread Kamil Rytarowski
On 13.10.2020 09:04, Rin Okuyama wrote: > Module Name: src > Committed By: rin > Date: Tue Oct 13 07:04:49 UTC 2020 > > Modified Files: > src/sys/arch/aarch64/aarch64: exec_machdep.c > > Log Message: > BE32 binaries are no longer supported for ARMv7 and later, and > therefore for

Re: CVS commit: src/sys/dev/pci

2020-10-12 Thread Michael
Hello, On Sun, 11 Oct 2020 21:41:57 + "Julian Coleman" wrote: > Module Name: src > Committed By: jdc > Date: Sun Oct 11 21:41:57 UTC 2020 > > Modified Files: > src/sys/dev/pci: radeonfb.c > > Log Message: ... > don't ignore the bottom 200 lines of the display (for no

re: CVS commit: src/sys/kern

2020-10-08 Thread David H. Gutteridge
On Mon, 07 Sep 2020 at 20:47:25 +1000, matthew green wrote: "Jason R Thorpe" writes: Module Name:src Committed By: thorpej Date: Mon Sep 7 03:50:41 UTC 2020 Modified Files: src/sys/kern: files.kern init_main.c Log Message: Add the ability to set an alternate cnmagic

Re: CVS commit: src/sys/arch

2020-10-06 Thread Thomas Klausner
Thank you very much! Thomas > On 06.10.2020, at 15:42, Christos Zoulas wrote: > > Module Name: src > Committed By: christos > Date: Tue Oct 6 13:42:03 UTC 2020 > > Modified Files: > src/sys/arch/aarch64/include: vmparam.h > src/sys/arch/amd64/include: vmparam.h >

Re: CVS commit: src/sys/arch/aarch64/aarch64

2020-10-06 Thread Rin Okuyama
It works fine now. Thank you for quick fix!! rin On 2020/10/06 15:28, Nick Hudson wrote: On 06/10/2020 01:54, Rin Okuyama wrote: Hi, On 2020/10/01 1:35, Nick Hudson wrote: Module Name:    src Committed By:    skrll Date:    Wed Sep 30 16:35:49 UTC 2020 Modified Files:

Re: CVS commit: src/sys/arch/aarch64/aarch64

2020-10-06 Thread Nick Hudson
On 06/10/2020 01:54, Rin Okuyama wrote: Hi, On 2020/10/01 1:35, Nick Hudson wrote: Module Name:    src Committed By:    skrll Date:    Wed Sep 30 16:35:49 UTC 2020 Modified Files: src/sys/arch/aarch64/aarch64: cpuswitch.S vectors.S Log Message: Move el[01]_trap_exit into vectors.S

Re: CVS commit: src/sys/arch/aarch64/aarch64

2020-10-05 Thread Rin Okuyama
Hi, On 2020/10/01 1:35, Nick Hudson wrote: Module Name:src Committed By: skrll Date: Wed Sep 30 16:35:49 UTC 2020 Modified Files: src/sys/arch/aarch64/aarch64: cpuswitch.S vectors.S Log Message: Move el[01]_trap_exit into vectors.S where the callers exist To generate

Re: CVS commit: src/sys/dev/fdt

2020-10-02 Thread Rin Okuyama
On 2020/10/02 22:42, Jonathan A. Kollasch wrote: On Sun, Jul 21, 2019 at 03:57:24PM +, Rin Okuyama wrote: Module Name:src Committed By: rin Date: Sun Jul 21 15:57:24 UTC 2019 Modified Files: src/sys/dev/fdt: dw_apb_uart.c Log Message: The device cannot recognize

Re: CVS commit: src/sys/dev/fdt

2020-10-02 Thread Jonathan A. Kollasch
On Sun, Jul 21, 2019 at 03:57:24PM +, Rin Okuyama wrote: > Module Name: src > Committed By: rin > Date: Sun Jul 21 15:57:24 UTC 2019 > > Modified Files: > src/sys/dev/fdt: dw_apb_uart.c > > Log Message: > The device cannot recognize break signal. Use + (five plus signs) as

Re: CVS commit: src/sys/arch/aarch64

2020-10-01 Thread Ryo Shimizu
>> Index: src/sys/arch/aarch64/include/cpu.h >> diff -u src/sys/arch/aarch64/include/cpu.h:1.27 src/sys/arch/aarch64/inc= >lude/cpu.h:1.28 >> --- src/sys/arch/aarch64/include/cpu.h:1.27 Mon Sep 14 10:06:35 2020 >> +++ src/sys/arch/aarch64/include/cpu.h Thu Oct 1 06:40:16 2020 >> @@ -1,4

Re: CVS commit: src/sys/arch/aarch64

2020-10-01 Thread Nick Hudson
On 01/10/2020 07:40, Ryo Shimizu wrote: Module Name:src Committed By: ryo Date: Thu Oct 1 06:40:16 UTC 2020 Modified Files: src/sys/arch/aarch64/aarch64: procfs_machdep.c src/sys/arch/aarch64/include: cpu.h Log Message: fix build error with LLVM [...] Index:

Re: CVS commit: src/sys/arch/aarch64/aarch64

2020-09-24 Thread Ryo Shimizu
>On 24/09/2020 10:04, Ryo Shimizu wrote: >> Module Name: src >> Committed By:ryo >> Date:Thu Sep 24 09:04:38 UTC 2020 >> >> Modified Files: >> src/sys/arch/aarch64/aarch64: bus_space_asm_generic.S >> >> Log Message: >> fix bugs in *_bs_rm_8_swap(). it was only

Re: CVS commit: src/sys/arch/aarch64/aarch64

2020-09-24 Thread Nick Hudson
On 24/09/2020 10:04, Ryo Shimizu wrote: Module Name:src Committed By: ryo Date: Thu Sep 24 09:04:38 UTC 2020 Modified Files: src/sys/arch/aarch64/aarch64: bus_space_asm_generic.S Log Message: fix bugs in *_bs_rm_8_swap(). it was only reading 4 bytes, not 8 bytes. I

Re: CVS commit: src/sys/uvm

2020-09-22 Thread Ryo ONODERA
Hi, Chuck Silvers writes: > On Tue, Sep 22, 2020 at 01:51:33AM +0900, Ryo ONODERA wrote: >> Hi, >> >> It seems that r1.124 of uvm_amap.c causes random userland segfaults >> on my NetBSD/amd64. > > this should be fixed now, could you try again? > > this was another case of my usual trick "test

Re: CVS commit: src/sys/uvm

2020-09-21 Thread Chuck Silvers
On Tue, Sep 22, 2020 at 01:51:33AM +0900, Ryo ONODERA wrote: > Hi, > > It seems that r1.124 of uvm_amap.c causes random userland segfaults > on my NetBSD/amd64. this should be fixed now, could you try again? this was another case of my usual trick "test a change well, modify the change at the

Re: CVS commit: src/sys/uvm

2020-09-21 Thread Ryo ONODERA
Hi, It seems that r1.124 of uvm_amap.c causes random userland segfaults on my NetBSD/amd64. If you cannot reproduce the random segfaults, I will send my backtraces. "Chuck Silvers" writes: > Module Name: src > Committed By: chs > Date: Sun Sep 20 23:03:01 UTC 2020 > > Modified Files:

Re: CVS commit: src/sys/dev/scsipi

2020-09-19 Thread Kimmo Suominen
I don't think this should be reverted, because LUN 0 must exist, but if there is no device on it, it will report "NOT PRESENT". We do not want the scan to stop in this case, but it should continue with other LUNs (such as those found through REPORT LUNS in the future). Kind regards, + Kimmo On

Re: CVS commit: src/sys

2020-09-11 Thread Kamil Rytarowski
On 11.09.2020 17:16, Roy Marples wrote: > Module Name: src > Committed By: roy > Date: Fri Sep 11 15:16:00 UTC 2020 > > Modified Files: > src/sys/net: if_llatbl.c > src/sys/netinet: if_arp.c if_inarp.h tcp_input.c > > Log Message: > ARP: Use ND rather than our own. > > This

re: CVS commit: src/sys/kern

2020-09-07 Thread matthew green
"Jason R Thorpe" writes: > Module Name: src > Committed By: thorpej > Date: Mon Sep 7 03:50:41 UTC 2020 > > Modified Files: > src/sys/kern: files.kern init_main.c > > Log Message: > Add the ability to set an alternate cnmagic in the kernel config > file, e.g.: > > options

Re: CVS commit: src/sys/arch/alpha/include

2020-09-03 Thread Jason Thorpe
> On Sep 3, 2020, at 1:14 PM, matthew green wrote: > > "Jason R Thorpe" writes: >> Module Name: src >> Committed By:thorpej >> Date:Thu Sep 3 04:20:54 UTC 2020 >> >> Modified Files: >> src/sys/arch/alpha/include: cpu.h >> >> Log Message: >> Garabage-collect

re: CVS commit: src/sys/arch/alpha/include

2020-09-03 Thread matthew green
"Jason R Thorpe" writes: > Module Name: src > Committed By: thorpej > Date: Thu Sep 3 04:20:54 UTC 2020 > > Modified Files: > src/sys/arch/alpha/include: cpu.h > > Log Message: > Garabage-collect curpcb / cpu_info::ci_curpcb. does alpha have modules? this may be a ABI change

Re: CVS commit: src/sys/dev/mii (PR/kern 55538)

2020-08-27 Thread Frank Kardel
Hi Martin ! That is strange - I didn't expect that, especially as the previous code was wrong with respect to state tracking. Can you check whether the addresses do not have the DEtACHED flag? You could try the dtrace script from the PR - it shows a little bit what is going on. There was also

Re: CVS commit: src/sys/dev/mii (PR/kern 55538)

2020-08-27 Thread Martin Husemann
On Mon, Aug 24, 2020 at 12:46:04PM +, Frank Kardel wrote: > Module Name: src > Committed By: kardel > Date: Mon Aug 24 12:46:04 UTC 2020 > > Modified Files: > src/sys/dev/mii: mii_physubr.c > > Log Message: > Keep the change check invariant intact. The previous code could miss

re: CVS commit: src/sys/uvm/pmap

2020-08-23 Thread matthew green
> Modified Files: > src/sys/uvm/pmap: pmap_segtab.c > > Log Message: > Remove the #if defined(__mips_n64) && PAGE_SIZE == 8192 and make the > check MI - all PTs are PAGE_SIZE aligned thanks! that is a much better way of doing it. .mrg.

Re: CVS commit: src/sys/arch

2020-08-16 Thread Rin Okuyama
On 2020/08/11 10:24, matthew green wrote: XXX Apply similar fixes to other m68k ports. yes...but also, a long-term project to consolidate all the almost-identical m68k code copied into each port would avoid this probably :-) Agreed. Also, I've found many dead codes in amiga/locore.s. I'd

Re: CVS commit: src/sys

2020-08-14 Thread Chuck Silvers
On Sat, Aug 15, 2020 at 01:20:48AM +0900, Ryo ONODERA wrote: > Hi, > > "Chuck Silvers" writes: > > > Module Name:src > > Committed By: chs > > Date: Fri Aug 14 09:06:15 UTC 2020 > > > > Modified Files: > > src/sys/miscfs/genfs: genfs_io.c > > src/sys/uvm:

Re: CVS commit: src/sys

2020-08-14 Thread Ryo ONODERA
Hi, "Chuck Silvers" writes: > Module Name: src > Committed By: chs > Date: Fri Aug 14 09:06:15 UTC 2020 > > Modified Files: > src/sys/miscfs/genfs: genfs_io.c > src/sys/uvm: uvm_extern.h uvm_object.c uvm_object.h uvm_page.c > uvm_page_status.c uvm_pager.c

Re: CVS commit: src/sys

2020-08-11 Thread Robert Swindells
matthew green wrote: >however, i'm looking at the changes and i'm not 100% convinced >it's safe to simply replace this file as-is. > > - struct v4l2_pix_format is laid out differently > - enum v4l2_buf_type <-> u_int32_t does not seem safe, in > eg struct v4l2_buffer. i *think* it may be,

re: CVS commit: src/sys

2020-08-10 Thread matthew green
matthew green writes: > > also, these updates to video(4) don't require a kernel bump > > so please revert that too. > > but this part could be done if you do it fast.. uvideo(4) as a module proves me wrong about this one too.. however, i'm looking at the changes and i'm not 100% convinced it's

Re: CVS commit: src/sys

2020-08-10 Thread Robert Swindells
matthew green wrote: >"Robert Swindells" writes: >> Module Name: src >> Committed By:rjs >> Date:Mon Aug 10 19:27:28 UTC 2020 >> >> Modified Files: >> src/sys/dev: video.c >> src/sys/dev/usb: uvideo.c >> src/sys/sys: videoio.h >> >> Log Message: >> Add

re: CVS commit: src/sys

2020-08-10 Thread matthew green
> > Import sys/videoio.h from OpenBSD, this is just the Linux headers > > concatenated together. > > this seems very problematic in that you've added GPLv2 code > into src/sys/sys. > > please revert. ah- i see it has dual-license, please ignore me. thanks to nia@ for the hint.. > also, these

re: CVS commit: src/sys

2020-08-10 Thread matthew green
"Robert Swindells" writes: > Module Name: src > Committed By: rjs > Date: Mon Aug 10 19:27:28 UTC 2020 > > Modified Files: > src/sys/dev: video.c > src/sys/dev/usb: uvideo.c > src/sys/sys: videoio.h > > Log Message: > Add some extra V4L ioctl() requests to latest V4L

re: CVS commit: src/sys/arch

2020-08-10 Thread matthew green
thanks! > XXX > Apply similar fixes to other m68k ports. yes...but also, a long-term project to consolidate all the almost-identical m68k code copied into each port would avoid this probably :-)

Re: CVS commit: src/sys/arch/amiga/amiga

2020-08-08 Thread Rin Okuyama
Hi, Sorry for the serious delay in my response. On 2020/07/22 13:37, matthew green wrote: thanks for getting more m68k working! Thanks! "Rin Okuyama" writes: Module Name:src Committed By: rin Date: Tue Jul 21 06:39:31 UTC 2020 Modified Files:

Re: CVS commit: src/sys/dev/mii

2020-08-03 Thread Valery Ushakov
On Tue, Aug 04, 2020 at 07:12:54 +0300, Valery Ushakov wrote: > On Tue, Aug 04, 2020 at 12:50:11 +0900, SAITOH Masanobu wrote: > > > On 2020/08/03 23:00, Valeriy E. Ushakov wrote: > > > Module Name: src > > > Committed By: uwe > > > Date: Mon Aug 3 14:00:41 UTC 2020 > > >

Re: CVS commit: src/sys/dev/mii

2020-08-03 Thread SAITOH Masanobu
On 2020/08/04 12:50, SAITOH Masanobu wrote: Hi. On 2020/08/03 23:00, Valeriy E. Ushakov wrote: Module Name:    src Committed By:    uwe Date:    Mon Aug  3 14:00:41 UTC 2020 Modified Files: src/sys/dev/mii: miidevs_data.h Log Message: mii_knowndevs[] is de facto const, define it as

Re: CVS commit: src/sys/external/bsd/acpica/dist

2020-08-03 Thread Herbert J. Skuhra
On Mon, Aug 03, 2020 at 02:31:11PM -0700, Tom Spindler (moof) wrote: > On Mon, Aug 03, 2020 at 10:59:04PM +0200, Herbert J. Skuhra wrote: > > This breaks the build (amd64) on FreeBSD and GNU/Linux: > > > > aslcompilerlex.l: In function 'AslCompilerlex': > > aslcompilerlex.l:589:22: error:

Re: CVS commit: src/sys/dev/mii

2020-08-03 Thread Valery Ushakov
On Tue, Aug 04, 2020 at 12:50:11 +0900, SAITOH Masanobu wrote: > On 2020/08/03 23:00, Valeriy E. Ushakov wrote: > > Module Name:src > > Committed By: uwe > > Date: Mon Aug 3 14:00:41 UTC 2020 > > > > Modified Files: > > src/sys/dev/mii: miidevs_data.h > > > >

Re: CVS commit: src/sys/dev/mii

2020-08-03 Thread SAITOH Masanobu
Hi. On 2020/08/03 23:00, Valeriy E. Ushakov wrote: Module Name:src Committed By: uwe Date: Mon Aug 3 14:00:41 UTC 2020 Modified Files: src/sys/dev/mii: miidevs_data.h Log Message: mii_knowndevs[] is de facto const, define it as such. To generate a diff of this

Re: CVS commit: src/sys/external/bsd/acpica/dist

2020-08-03 Thread Tom Spindler (moof)
On Mon, Aug 03, 2020 at 10:59:04PM +0200, Herbert J. Skuhra wrote: > This breaks the build (amd64) on FreeBSD and GNU/Linux: > > aslcompilerlex.l: In function 'AslCompilerlex': > aslcompilerlex.l:589:22: error: 'PARSEOP_REGIONSPACE_PRM' undeclared (first > use in this function); did you mean

Re: CVS commit: src/sys/external/bsd/acpica/dist

2020-08-03 Thread Herbert J. Skuhra
On Sun, 02 Aug 2020 22:25:55 +0200, "Christos Zoulas" wrote: > > Module Name: src > Committed By: christos > Date: Sun Aug 2 20:25:55 UTC 2020 > > Modified Files: > src/sys/external/bsd/acpica/dist/compiler: aslcompiler.l aslerror.c > aslload.c aslxref.c >

Re: CVS commit: src/sys/kern

2020-08-02 Thread Kamil Rytarowski
On 02.08.2020 17:50, Taylor R Campbell wrote: >> Date: Sun, 2 Aug 2020 17:35:06 +0200 >> From: Kamil Rytarowski >> >> On 02.08.2020 16:44, Taylor R Campbell wrote: Date: Sun, 2 Aug 2020 16:04:15 +0200 From: Kamil Rytarowski On 02.08.2020 15:57, Taylor R Campbell wrote: >

Re: CVS commit: src/sys/kern

2020-08-02 Thread Taylor R Campbell
> Date: Sun, 2 Aug 2020 17:35:06 +0200 > From: Kamil Rytarowski > > On 02.08.2020 16:44, Taylor R Campbell wrote: > >> Date: Sun, 2 Aug 2020 16:04:15 +0200 > >> From: Kamil Rytarowski > >> > >> On 02.08.2020 15:57, Taylor R Campbell wrote: > >>> But it sounds like the original motivation is

Re: CVS commit: src/sys/kern

2020-08-02 Thread Kamil Rytarowski
On 02.08.2020 16:44, Taylor R Campbell wrote: >> Date: Sun, 2 Aug 2020 16:04:15 +0200 >> From: Kamil Rytarowski >> >> On 02.08.2020 15:57, Taylor R Campbell wrote: >>> But it sounds like the original motivation is that it triggered >>> -Wvla...which frankly strikes me as a compiler bug since

Re: CVS commit: src/sys/kern

2020-08-02 Thread Jaromír Doleček
Le dim. 2 août 2020 à 15:57, Taylor R Campbell a écrit : > Why does it improve readability? Certainly using cringe language features does not help readability. > What else does -Wvla choke on in src/sys? Some drm drivers, and uvm, particularly uvm_bio.c. I'd like to work towards enabling -Wvla

Re: CVS commit: src/sys/kern

2020-08-02 Thread Taylor R Campbell
> Date: Sun, 2 Aug 2020 16:04:15 +0200 > From: Kamil Rytarowski > > On 02.08.2020 15:57, Taylor R Campbell wrote: > > But it sounds like the original motivation is that it triggered > > -Wvla...which frankly strikes me as a compiler bug since there's > > obviously no actual VLA created in

Re: CVS commit: src/sys/kern

2020-08-02 Thread Joerg Sonnenberger
On Sun, Aug 02, 2020 at 01:57:11PM +, Taylor R Campbell wrote: > But it sounds like the original motivation is that it triggered > -Wvla...which frankly strikes me as a compiler bug since there's > obviously no actual VLA created in sizeof; as far as I can tell > there's no semantic difference

Re: CVS commit: src/sys/kern

2020-08-02 Thread Kamil Rytarowski
On 02.08.2020 16:25, Paul Goyette wrote: > On Sun, 2 Aug 2020, Kamil Rytarowski wrote: > >> On 02.08.2020 15:57, Taylor R Campbell wrote: >>> But it sounds like the original motivation is that it triggered >>> -Wvla...which frankly strikes me as a compiler bug since there's >>> obviously no

Re: CVS commit: src/sys/kern

2020-08-02 Thread Paul Goyette
On Sun, 2 Aug 2020, Kamil Rytarowski wrote: On 02.08.2020 15:57, Taylor R Campbell wrote: But it sounds like the original motivation is that it triggered -Wvla...which frankly strikes me as a compiler bug since there's obviously no actual VLA created in sizeof; as far as I can tell there's no

Re: CVS commit: src/sys/kern

2020-08-02 Thread Kamil Rytarowski
On 02.08.2020 15:57, Taylor R Campbell wrote: > But it sounds like the original motivation is that it triggered > -Wvla...which frankly strikes me as a compiler bug since there's > obviously no actual VLA created in sizeof; as far as I can tell > there's no semantic difference between

Re: CVS commit: src/sys/kern

2020-08-02 Thread Taylor R Campbell
> Date: Sun, 2 Aug 2020 10:47:21 +0200 > From: Jarom�r Dole ek > > Readability first and foremost in this case. > > I was exploring if I can disable VLAs for the kernel altogether, this > can't be done for now. Nevertheless, this change looked like it would > be useful to make anyway. Why does

Re: CVS commit: src/sys/kern

2020-08-02 Thread Jaromír Doleček
Readability first and foremost in this case. I was exploring if I can disable VLAs for the kernel altogether, this can't be done for now. Nevertheless, this change looked like it would be useful to make anyway. Le dim. 2 août 2020 à 01:15, Taylor R Campbell a écrit : > > > Module Name:src >

Re: CVS commit: src/sys/arch/x86

2020-08-01 Thread Taylor R Campbell
> Module Name:src > Committed By: jdolecek > Date: Sat Aug 1 12:36:36 UTC 2020 > > Modified Files: > src/sys/arch/x86/pci: pci_intr_machdep.c > src/sys/arch/x86/x86: mainbus.c > > Log Message: > reorder includes to pull __HAVE_PCI_MSI_MSIX properly via > If

Re: CVS commit: src/sys/kern

2020-08-01 Thread Taylor R Campbell
> Module Name:src > Committed By: jdolecek > Date: Sat Aug 1 11:18:26 UTC 2020 > > Modified Files: > src/sys/kern: subr_autoconf.c > > Log Message: > avoid VLA for the sizeof() calculations Why?

re: CVS commit: src/sys/dev

2020-07-28 Thread matthew green
"Jaromir Dolecek" writes: > Module Name: src > Committed By: jdolecek > Date: Tue Jul 28 09:36:05 UTC 2020 > > Modified Files: > src/sys/dev/ic: nvmevar.h > src/sys/dev/pci: nvme_pci.c > > Log Message: > add a quirk to disable MSI, and enable it for Intel SSD DC P4500 > >

Re: CVS commit: src/sys/crypto/aes

2020-07-28 Thread Roy Marples
On 27/07/2020 21:44, Taylor R Campbell wrote: Module Name:src Committed By: riastradh Date: Mon Jul 27 20:44:30 UTC 2020 Modified Files: src/sys/crypto/aes: aes_ccm.c aes_ccm.h Log Message: Gather auth[16] and ctr[16] into one authctr[32]. Should appease clang. clang

re: CVS commit: src/sys/arch/amiga/amiga

2020-07-21 Thread matthew green
thanks for getting more m68k working! "Rin Okuyama" writes: > Module Name: src > Committed By: rin > Date: Tue Jul 21 06:39:31 UTC 2020 > > Modified Files: > src/sys/arch/amiga/amiga: locore.s > > Log Message: > Align tmpstk to 4-byte boundary in the same manner as mac68k. > >

Re: CVS commit: src/sys/uvm

2020-07-18 Thread Rin Okuyama
On 2020/07/18 17:30, Jukka Ruohonen wrote: On Sat, Jul 18, 2020 at 05:19:07PM +0900, Rin Okuyama wrote: For most (all?) ports, these specifiers are exposed only for _KERNEL and friends. So, inttypes(*3*) would not be the best place for them. Currently, I'm not sure where they should be.

Re: CVS commit: src/sys/uvm

2020-07-18 Thread Jukka Ruohonen
On Sat, Jul 18, 2020 at 05:19:07PM +0900, Rin Okuyama wrote: > For most (all?) ports, these specifiers are exposed only for > _KERNEL and friends. So, inttypes(*3*) would not be the best > place for them. Currently, I'm not sure where they should be. > /usr/share/misc/style? Perhaps a new

Re: CVS commit: src/sys/uvm

2020-07-18 Thread Rin Okuyama
On 2020/07/16 16:02, matthew green wrote: thanks! i'll try to remember we have PRIxPADDR because i considered looking for it and thought we didn't have it... My pleasure! On 2020/07/16 16:10, Jukka Ruohonen wrote: The whole { PRIxPADDR, PRIxPSIZE, ..., PRIxREGISTER } family should probably

Re: [sctp fix] Re: CVS commit: src/sys/kern

2020-07-18 Thread Maxime Villard
Le 28/04/2020 à 09:16, Luke Mewburn a écrit : On 20-04-26 18:15, Maxime Villard wrote: | - There was no demonstrated use-case justifying importing it. In addition, |major OSes like Windows and macOS do not implement SCTP. There just is no |demand for SCTP on the market; and on

Re: CVS commit: src/sys/dev/pci

2020-07-17 Thread Jaromír Doleček
One of the things which need to be done is calling the if_ioctl always with the IFNET_LOCK() held. Right now it sometimes is, and other times it is not, so it's not possible to rely on it and KASSERT(). As for bnx(4) I did just some basic fixes around making it work with MSI(-X), since I don't

Re: CVS commit: src/sys/dev/pci

2020-07-17 Thread Jason Thorpe
> On Jul 17, 2020, at 3:50 PM, matthew green wrote: > > any chance you can look at NET_MPSAFE here etc? :) I have a bunch of local changes for this in one of my trees, and I hope to get back to it after netbsd-10 branches. -- thorpej

re: CVS commit: src/sys/dev/pci

2020-07-17 Thread matthew green
"Jaromir Dolecek" writes: > Module Name: src > Committed By: jdolecek > Date: Fri Jul 17 09:48:21 UTC 2020 > > Modified Files: > src/sys/dev/pci: if_bnx.c > > Log Message: > re-enable MSI/MSI-X, the TX timeouts were caused by the IFF_OACTIVE handling, > which was fixed in previous

Re: CVS commit: src/sys/uvm

2020-07-16 Thread Jukka Ruohonen
On Thu, Jul 16, 2020 at 05:02:18PM +1000, matthew green wrote: > thanks! i'll try to remember we have PRIxPADDR because i > considered looking for it and thought we didn't have it... The whole { PRIxPADDR, PRIxPSIZE, ..., PRIxREGISTER } family should probably be documented in inttypes(3)? -

re: CVS commit: src/sys/uvm

2020-07-16 Thread matthew green
"Rin Okuyama" writes: > Module Name: src > Committed By: rin > Date: Wed Jul 15 15:08:26 UTC 2020 > > Modified Files: > src/sys/uvm: uvm_physseg.c > > Log Message: > Fix typo. Use PRIxPADDR rather than casting. thanks! i'll try to remember we have PRIxPADDR because i considered

re: [mii locking] Re: CVS commit: src/sys

2020-07-13 Thread matthew green
> Since this change if_udav.c doesn't work. Simply plugging a USB-to-ethernet > device triggers a page fault on mutex_enter in udav_attach. > > Quickly looking at the code: > > 240 usbnet_lock_core(un); > 241 usbnet_busy(un); > 242 > 243 ///* reset the adapter */ > 244 //

Re: CVS commit: src/sys/dev/i2c

2020-07-12 Thread Kimmo Suominen
Hi Michael, Perhaps your commit missed some changes? The code no longer compiles. Cheers, + Kimmo /p/netbsd/cvs/src/sys/dev/i2c/dbcool.c: In function 'dbcool_attach': /p/netbsd/cvs/src/sys/dev/i2c/dbcool.c:778:4: error: 'struct dbcool_softc' has no member named 'sc_prop' sc->sc_prop =

Re: CVS commit: src/sys/dev/scsipi

2020-07-11 Thread Kimmo Suominen
On Sun, Jul 12, 2020 at 12:05:37AM +0700, Robert Elz wrote: > Just to make things clear here, the LUN you're talking about is not > the scsi unit number (which is what I think Martin was referring to) > but a sub-device number within a single scsi ID. Right? Correct. I should have written "SCSI

Re: CVS commit: src/sys/dev/scsipi

2020-07-11 Thread Robert Elz
Date:Sat, 11 Jul 2020 18:24:51 +0300 From:Kimmo Suominen Message-ID: <20200711152451.ga1...@homeworld.netbsd.org> | On Sat, Jul 11, 2020 at 05:00:02PM +0200, Martin Husemann wrote: | > I don't understand the change. When was this broken? This has always worked

Re: CVS commit: src/sys/dev/scsipi

2020-07-11 Thread Martin Husemann
On Sat, Jul 11, 2020 at 06:24:51PM +0300, Kimmo Suominen wrote: > I think all real SCSI hardware I've had has always just only had LUN 0, > and each disk has been on its own SCSI ID (target). Yes, I confused ID and LUN here - just ignore me. Martin

Re: CVS commit: src/sys/dev/scsipi

2020-07-11 Thread Kimmo Suominen
On Sat, Jul 11, 2020 at 05:00:02PM +0200, Martin Husemann wrote: > I don't understand the change. When was this broken? This has always worked > for me e.g. with the sd0 at LUN 3 and the controller at 6 or 7. I think all real SCSI hardware I've had has always just only had LUN 0, and each disk

Re: CVS commit: src/sys/dev/scsipi

2020-07-11 Thread Martin Husemann
On Sat, Jul 11, 2020 at 05:57:46PM +0300, Kimmo Suominen wrote: > On Sat, Jul 11, 2020 at 05:47:34PM +0300, Jukka Ruohonen wrote: > > I'd reckon a pullup to NetBSD 9 would be in order? > > Yes, I was just waiting to be able to link to mail-index. I had > already checked that the patch applies

Re: CVS commit: src/sys/dev/scsipi

2020-07-11 Thread Kimmo Suominen
On Sat, Jul 11, 2020 at 05:47:34PM +0300, Jukka Ruohonen wrote: > I'd reckon a pullup to NetBSD 9 would be in order? Yes, I was just waiting to be able to link to mail-index. I had already checked that the patch applies cleanly to both netbsd-9 and netbsd-8.

Re: CVS commit: src/sys/dev/scsipi

2020-07-11 Thread Jukka Ruohonen
On Sat, Jul 11, 2020 at 02:31:46PM +, Kimmo Suominen wrote: > Use case 2: A Linode boot profile with multiple disks results in > the first disk ("sda") on LUN 1, while the second disk ("sdb") is > on LUN 0, each on their own bus. As Linode is quite popular, and supposedly uses a rather

[mii locking] Re: CVS commit: src/sys

2020-07-09 Thread Maxime Villard
Module Name:src Committed By: thorpej Date: Sun Mar 15 23:04:51 UTC 2020 Modified Files: src/sys/arch/arm/amlogic: gxlphy.c src/sys/arch/x86/pci: if_vmx.c src/sys/dev/mii: acphy.c amhphy.c atphy.c bmtphy.c brgphy.c ciphy.c dmphy.c etphy.c

Re: CVS commit: src/sys/conf

2020-07-08 Thread Simon Burge
"Valeriy E. Ushakov" wrote: > Module Name: src > Committed By: uwe > Date: Wed Jul 8 19:39:22 UTC 2020 > > Modified Files: > > src/sys/conf: assym.mk > > Log Message: > > Drop -fstack-usage* from CFLAGS passed genassym. > We don't want it to create a "-.su" file. Thanks! Cheers,

Re: CVS commit: src/sys

2020-07-08 Thread Jason Thorpe
> On Jul 8, 2020, at 12:22 AM, Martin Husemann wrote: > > On Tue, Jul 07, 2020 at 03:38:49AM +, Jason R Thorpe wrote: >> Provide a new resource provider API: > > This is *extremly* verbose and overflows message buffer, can you move the > new messages to aprint_debug or ifdef with some

Re: CVS commit: src/sys

2020-07-08 Thread Martin Husemann
On Tue, Jul 07, 2020 at 03:38:49AM +, Jason R Thorpe wrote: > Provide a new resource provider API: This is *extremly* verbose and overflows message buffer, can you move the new messages to aprint_debug or ifdef with some proper DEBUG_* please? Martin

Re: CVS commit: src/sys/arch/powerpc/booke

2020-07-06 Thread Rin Okuyama
On 2020/07/07 9:51, Jason Thorpe wrote: On Jul 6, 2020, at 5:28 PM, Rin Okuyama wrote: Module Name:src Committed By: rin Date: Tue Jul 7 00:28:31 UTC 2020 Modified Files: src/sys/arch/powerpc/booke: e500_tlb.c Log Message: Fix kernel panic due to tmpfs. pmap for

Re: CVS commit: src/sys/arch/powerpc/booke

2020-07-06 Thread Jason Thorpe
> On Jul 6, 2020, at 5:28 PM, Rin Okuyama wrote: > > Module Name: src > Committed By: rin > Date: Tue Jul 7 00:28:31 UTC 2020 > > Modified Files: > src/sys/arch/powerpc/booke: e500_tlb.c > > Log Message: > Fix kernel panic due to tmpfs. > > pmap for booke assumes that the

Re: CVS commit: src/sys/arch/aarch64/aarch64

2020-07-02 Thread Jared McNeill
I think this will have issues on some big.LITTLE configurations like Rockchip RK3399. In the RK3399 case cpu[0-3] is VIPT I$ and cpu[4-5] is PIPT I$. Boot order of secondaries is not guaranteed so it is possible to get different values of aarch64_cache_vindexsize from one boot to the next.

Re: CVS commit: src/sys/arch/ia64/stand/ia64/efi

2020-07-02 Thread scole_mail
Martin Husemann writes: > > That build pre-dates Luke's fix. > Ahh, you are correct and it built fine for me, apologies. Thanks

Re: CVS commit: src/sys/arch/ia64/stand/ia64/efi

2020-07-02 Thread Martin Husemann
On Thu, Jul 02, 2020 at 08:03:09AM -0700, scole_mail wrote: > That change didn't work: > > http://releng.netbsd.org/builds/HEAD/202007020210Z/ia64.build.failed > ... > nbmake[10]: nbmake[10]: don't know how to make loader.efi.c. Stop That build pre-dates Luke's fix. Martin

Re: CVS commit: src/sys/arch/ia64/stand/ia64/efi

2020-07-02 Thread scole_mail
"Luke Mewburn" writes: > Module Name: src > Committed By: lukem > Date: Thu Jul 2 09:07:25 UTC 2020 > > Modified Files: > src/sys/arch/ia64/stand/ia64/efi: Makefile > > Log Message: > loader.efi doesn't have source > > (Untested fix) > > > To generate a diff of this commit: > cvs

Re: CVS commit: src/sys/compat/sys

2020-06-28 Thread Christos Zoulas
> On Jun 28, 2020, at 10:24 AM, Robert Elz wrote: > >Date:Sat, 27 Jun 2020 11:49:30 -0400 >From:"Christos Zoulas" >Message-ID: <20200627154930.84e22f...@cvs.netbsd.org> > > | Modified Files: > |src/sys/compat/sys: mount.h > | > | Log Message: > | Ignore

Re: CVS commit: src/sys/compat/sys

2020-06-28 Thread Robert Elz
Date:Sat, 27 Jun 2020 11:49:30 -0400 From:"Christos Zoulas" Message-ID: <20200627154930.84e22f...@cvs.netbsd.org> | Modified Files: | src/sys/compat/sys: mount.h | | Log Message: | Ignore the supplied size, and always use the argument size that we know.

  1   2   3   4   5   6   7   8   9   10   >