Re: CVS commit: src/sys/dev/acpi

2020-06-23 Thread Jukka Ruohonen
On Mon, Jun 22, 2020 at 04:14:18PM +, Maxime Villard wrote: > Module Name: src > Committed By: maxv > Date: Mon Jun 22 16:14:18 UTC 2020 > > Modified Files: > src/sys/dev/acpi: acpi.c > > Log Message: > Fix memory leak. Found by kLSan. > + > + default: > +

Re: CVS commit: src/sys/dev/acpi

2020-06-07 Thread Nick Hudson
On 10/08/2018 18:11, Taylor R Campbell wrote: Module Name:src Committed By: riastradh Date: Fri Aug 10 17:11:56 UTC 2018 Modified Files: src/sys/dev/acpi: acpi_bat.c Log Message: Don't hold up boot: defer acpibat(4) inquiry until threads are running. ok jmcneill@

CVS commit: src/sys/dev/acpi

2019-10-13 Thread Jared D. McNeill
Module Name:src Committed By: jmcneill Date: Mon Oct 14 00:15:13 UTC 2019 Modified Files: src/sys/dev/acpi: acpi_mcfg.c Log Message: The MCFG base address field is the physical address of the base of mmio space relative to bus 0, not the start bus number specified in the

CVS commit: src/sys/dev/acpi

2019-10-13 Thread Jared D. McNeill
Module Name:src Committed By: jmcneill Date: Mon Oct 14 00:15:13 UTC 2019 Modified Files: src/sys/dev/acpi: acpi_mcfg.c Log Message: The MCFG base address field is the physical address of the base of mmio space relative to bus 0, not the start bus number specified in the

CVS commit: src/sys/dev/acpi

2019-09-28 Thread Manuel Bouyer
Module Name:src Committed By: bouyer Date: Sat Sep 28 11:24:10 UTC 2019 Modified Files: src/sys/dev/acpi: acpi_i2c.c Log Message: joshua stein, PR kern/54493: acpi_i2c uses incorrect arguments for _DSM call The last argument to the _DSM call has to be ACPI_TYPE_PACKAGE,

CVS commit: src/sys/dev/acpi

2019-09-28 Thread Manuel Bouyer
Module Name:src Committed By: bouyer Date: Sat Sep 28 11:24:10 UTC 2019 Modified Files: src/sys/dev/acpi: acpi_i2c.c Log Message: joshua stein, PR kern/54493: acpi_i2c uses incorrect arguments for _DSM call The last argument to the _DSM call has to be ACPI_TYPE_PACKAGE,

CVS commit: src/sys/dev/acpi

2019-09-23 Thread Jared D. McNeill
Module Name:src Committed By: jmcneill Date: Mon Sep 23 08:50:52 UTC 2019 Modified Files: src/sys/dev/acpi: dwiic_acpi.c Log Message: Match APMC0D0F compatible string. To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3 src/sys/dev/acpi/dwiic_acpi.c Please note

CVS commit: src/sys/dev/acpi

2019-09-23 Thread Jared D. McNeill
Module Name:src Committed By: jmcneill Date: Mon Sep 23 08:50:52 UTC 2019 Modified Files: src/sys/dev/acpi: dwiic_acpi.c Log Message: Match APMC0D0F compatible string. To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3 src/sys/dev/acpi/dwiic_acpi.c Please note

CVS commit: src/sys/dev/acpi

2019-08-11 Thread Rin Okuyama
Module Name:src Committed By: rin Date: Sun Aug 11 06:46:35 UTC 2019 Modified Files: src/sys/dev/acpi: pckbc_acpi.c Log Message: Appease GCC maybe-uninitialized for optimization level -Os on amd64. To generate a diff of this commit: cvs rdiff -u -r1.36 -r1.37

Re: CVS commit: src/sys/dev/acpi

2019-08-05 Thread Masanobu SAITOH
On 2019/08/05 23:06, Joerg Sonnenberger wrote: > On Mon, Aug 05, 2019 at 10:12:04AM +, SAITOH Masanobu wrote: >> Module Name: src >> Committed By:msaitoh >> Date:Mon Aug 5 10:12:04 UTC 2019 >> >> Modified Files: >> src/sys/dev/acpi: acpi_ec.c >> >> Log Message: >>

CVS commit: src/sys/dev/acpi

2019-08-05 Thread SAITOH Masanobu
Module Name:src Committed By: msaitoh Date: Tue Aug 6 01:53:47 UTC 2019 Modified Files: src/sys/dev/acpi: acpi_ec.c Log Message: - Make the case that width < 8 behave as the same as before. Pointed out by Joerg. - Change "switch" to "if" for simplify. To generate a

CVS commit: src/sys/dev/acpi

2019-08-05 Thread SAITOH Masanobu
Module Name:src Committed By: msaitoh Date: Tue Aug 6 01:53:47 UTC 2019 Modified Files: src/sys/dev/acpi: acpi_ec.c Log Message: - Make the case that width < 8 behave as the same as before. Pointed out by Joerg. - Change "switch" to "if" for simplify. To generate a

Re: CVS commit: src/sys/dev/acpi

2019-08-05 Thread Joerg Sonnenberger
On Mon, Aug 05, 2019 at 10:12:04AM +, SAITOH Masanobu wrote: > Module Name: src > Committed By: msaitoh > Date: Mon Aug 5 10:12:04 UTC 2019 > > Modified Files: > src/sys/dev/acpi: acpi_ec.c > > Log Message: > - Fix a bug that acpiec_space_handler() doesn't access more than

Re: CVS commit: src/sys/dev/acpi

2019-08-05 Thread SAITOH Masanobu
On 2019/08/05 19:12, SAITOH Masanobu wrote: > Module Name: src > Committed By: msaitoh > Date: Mon Aug 5 10:12:04 UTC 2019 > > Modified Files: > src/sys/dev/acpi: acpi_ec.c > > Log Message: > - Fix a bug that acpiec_space_handler() doesn't access more than 64bit > correctly.

CVS commit: src/sys/dev/acpi

2019-08-05 Thread SAITOH Masanobu
Module Name:src Committed By: msaitoh Date: Mon Aug 5 10:12:04 UTC 2019 Modified Files: src/sys/dev/acpi: acpi_ec.c Log Message: - Fix a bug that acpiec_space_handler() doesn't access more than 64bit correctly. Found by kUBSan on Thinkpad X220. acpiec0 accessed 128bits

CVS commit: src/sys/dev/acpi

2019-08-05 Thread SAITOH Masanobu
Module Name:src Committed By: msaitoh Date: Mon Aug 5 10:12:04 UTC 2019 Modified Files: src/sys/dev/acpi: acpi_ec.c Log Message: - Fix a bug that acpiec_space_handler() doesn't access more than 64bit correctly. Found by kUBSan on Thinkpad X220. acpiec0 accessed 128bits

CVS commit: src/sys/dev/acpi

2019-08-05 Thread SAITOH Masanobu
Module Name:src Committed By: msaitoh Date: Mon Aug 5 10:09:35 UTC 2019 Modified Files: src/sys/dev/acpi: thinkpad_acpi.c Log Message: Fix undefined behavior in thinkpad_mask_init(). Found by kUBSan. To generate a diff of this commit: cvs rdiff -u -r1.46 -r1.47

CVS commit: src/sys/dev/acpi

2019-08-05 Thread SAITOH Masanobu
Module Name:src Committed By: msaitoh Date: Mon Aug 5 10:09:35 UTC 2019 Modified Files: src/sys/dev/acpi: thinkpad_acpi.c Log Message: Fix undefined behavior in thinkpad_mask_init(). Found by kUBSan. To generate a diff of this commit: cvs rdiff -u -r1.46 -r1.47

CVS commit: src/sys/dev/acpi

2019-06-22 Thread Jared D. McNeill
Module Name:src Committed By: jmcneill Date: Sat Jun 22 19:35:40 UTC 2019 Modified Files: src/sys/dev/acpi: xhci_acpi.c Log Message: Use bus_dmatag_subregion to get a 32-bit tag To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.5 src/sys/dev/acpi/xhci_acpi.c

CVS commit: src/sys/dev/acpi

2019-06-22 Thread Jared D. McNeill
Module Name:src Committed By: jmcneill Date: Sat Jun 22 19:35:40 UTC 2019 Modified Files: src/sys/dev/acpi: xhci_acpi.c Log Message: Use bus_dmatag_subregion to get a 32-bit tag To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.5 src/sys/dev/acpi/xhci_acpi.c

CVS commit: src/sys/dev/acpi

2019-06-19 Thread Jared D. McNeill
Module Name:src Committed By: jmcneill Date: Wed Jun 19 13:40:23 UTC 2019 Modified Files: src/sys/dev/acpi: xhci_acpi.c Log Message: Conditionally use a 32- or 64-bit DMA tag based on HCCPARAMS To generate a diff of this commit: cvs rdiff -u -r1.3 -r1.4

CVS commit: src/sys/dev/acpi

2019-06-19 Thread Jared D. McNeill
Module Name:src Committed By: jmcneill Date: Wed Jun 19 13:40:23 UTC 2019 Modified Files: src/sys/dev/acpi: xhci_acpi.c Log Message: Conditionally use a 32- or 64-bit DMA tag based on HCCPARAMS To generate a diff of this commit: cvs rdiff -u -r1.3 -r1.4

Re: CVS commit: src/sys/dev/acpi

2018-10-15 Thread Jared McNeill
Hi Jaromir -- This change breaks the build of the one kernel that includes this code (evbarm GENERIC64) as intr_establish_xname is not an MI API. Cheers, Jared On Mon, 15 Oct 2018, Jaromir Dolecek wrote: Module Name:src Committed By: jdolecek Date: Mon Oct 15 06:58:08 UTC

Re: CVS commit: src/sys/dev/acpi

2017-12-29 Thread Manuel Bouyer
On Mon, Dec 11, 2017 at 12:22:56AM +0100, Jaromír Dole?ek wrote: [in response to acpi_intr_establish() introduction] > Can we have acpi_intr_establish() accept the xname? It's very useful to > have the driver name registered for "intrctl list". The attached patch does it.

Re: CVS commit: src/sys/dev/acpi

2017-12-11 Thread Jaromír Doleček
Can we have acpi_intr_establish() accept the xname? It's very useful to have the driver name registered for "intrctl list". Jaromir 2017-12-10 17:51 GMT+01:00 Manuel Bouyer : > Module Name:src > Committed By: bouyer > Date: Sun Dec 10 16:51:30 UTC 2017 > >

Re: CVS commit: src/sys/dev/acpi/wmi

2017-12-03 Thread David Holland
On Sun, Dec 03, 2017 at 11:53:37PM +0100, Manuel Bouyer wrote: > On Sun, Dec 03, 2017 at 11:06:47AM -0800, bch wrote: > > ... > > /usr/src/sys/dev/acpi/wmi/wmi_dell.c: In function 'wmi_dell_action': > > /usr/src/sys/dev/acpi/wmi/wmi_dell.c:234:16: error: comparison between > > signed and

Re: CVS commit: src/sys/dev/acpi/wmi

2017-12-03 Thread Manuel Bouyer
On Sun, Dec 03, 2017 at 11:06:47AM -0800, bch wrote: > ... > /usr/src/sys/dev/acpi/wmi/wmi_dell.c: In function 'wmi_dell_action': > /usr/src/sys/dev/acpi/wmi/wmi_dell.c:234:16: error: comparison between > signed and unsigned integer expressions [-Werror=sign-compare] > for (i = 0; i <

Re: CVS commit: src/sys/dev/acpi/wmi

2017-12-03 Thread bch
... /usr/src/sys/dev/acpi/wmi/wmi_dell.c: In function 'wmi_dell_action': /usr/src/sys/dev/acpi/wmi/wmi_dell.c:234:16: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] for (i = 0; i < __arraycount(wmi_dell_actions); i++) { ^ cc1: all

Re: CVS commit: src/sys/dev/acpi

2011-08-06 Thread Jukka Ruohonen
On Fri, Aug 05, 2011 at 06:27:48PM +, Jonathan A. Kollasch wrote: Module Name: src Committed By: jakllsch Date: Fri Aug 5 18:27:48 UTC 2011 Modified Files: src/sys/dev/acpi: acpi.c Log Message: As we add a handler for the ACPI fixed feature button events, ensure

Re: CVS commit: src/sys/dev/acpi

2011-08-06 Thread Jonathan A. Kollasch
On Sat, Aug 06, 2011 at 02:55:15PM +0300, Jukka Ruohonen wrote: On Fri, Aug 05, 2011 at 06:27:48PM +, Jonathan A. Kollasch wrote: Module Name:src Committed By: jakllsch Date: Fri Aug 5 18:27:48 UTC 2011 Modified Files: src/sys/dev/acpi: acpi.c

Re: CVS commit: src/sys/dev/acpi

2011-08-06 Thread Jukka Ruohonen
On Sat, Aug 06, 2011 at 12:02:52PM +, Jonathan A. Kollasch wrote: The current version does what I needed. But what is that? - Jukka.

Re: CVS commit: src/sys/dev/acpi

2011-08-06 Thread Jonathan A. Kollasch
On Sat, Aug 06, 2011 at 03:04:27PM +0300, Jukka Ruohonen wrote: On Sat, Aug 06, 2011 at 12:02:52PM +, Jonathan A. Kollasch wrote: The current version does what I needed. But what is that? Prevent immediate shutdowns because the button was pressed at power up. Jonathan Kollasch

Re: CVS commit: src/sys/dev/acpi

2011-05-22 Thread Iain Hibbert
On Sun, 22 May 2011, Joerg Sonnenberger wrote: Modified Files: src/sys/dev/acpi: acpi_power.c Log Message: Let's not be silly. Use a fancy if else to decide behavior of a bool and hope cosmic radition doesn't create a third state. I'll just say here, that I found a code generation

Re: CVS commit: src/sys/dev/acpi

2011-04-25 Thread Christos Zoulas
In article 20110425053021.afdbf17...@cvs.netbsd.org, Jukka Ruohonen source-changes-d@NetBSD.org wrote: -=-=-=-=-=- Module Name: src Committed By: jruoho Date: Mon Apr 25 05:30:21 UTC 2011 Modified Files: src/sys/dev/acpi: acpi_cpu.c Log Message: Add a missing case value in a

Re: CVS commit: src/sys/dev/acpi

2011-02-28 Thread Mindaugas Rasiukevicius
Jukka Ruohonen jruoho...@iki.fi wrote: Are there any plans for kernel equivalent to cpuset(3)? Yes, there is kcpuset(9), see kcpuset_create() and friends. I plan to modify it so it could be used early in MD code (when memory allocation is not yet available) and thus unify random MD cpuset

Re: CVS commit: src/sys/dev/acpi

2011-02-25 Thread Jukka Ruohonen
On Fri, Feb 25, 2011 at 07:55:07PM +, Jukka Ruohonen wrote: Log Message: Start to derive the percpu(9) (or per-domain) state coordination mechanisms by parsing the _CSD, _PSD, and _TSD objects by default. This is quite interesting development affecting the whole x86; the sleep and

Re: CVS commit: src/sys/dev/acpi

2011-02-22 Thread Jukka Ruohonen
On Tue, Feb 22, 2011 at 09:34:13AM +, Jukka Ruohonen wrote: in acpicpu_cstate_fadt(). Note that this violates the specification, given: PBlockAddress provides the system I/O address for the processors register block. Each processor can supply a different such address.

Re: CVS commit: src/sys/dev/acpi

2011-02-17 Thread Jukka Ruohonen
The so-called wakedev code might be broken for a short while. The reasons are listed below. - Jukka. On Thu, Feb 17, 2011 at 10:49:30AM +, Jukka Ruohonen wrote: Module Name: src Committed By: jruoho Date: Thu Feb 17 10:49:30 UTC 2011 Modified Files: src/sys/dev/acpi:

Re: CVS commit: src/sys/dev/acpi

2011-02-17 Thread Jukka Ruohonen
On Thu, Feb 17, 2011 at 07:36:49PM +, Jukka Ruohonen wrote: Log Message: As explained in the new ACPICA documentation, as of ACPICA 20101207, the _PRW methods are no longer automatically executed as part of the ACPICA initialization. Refactor and rewrite the wake-device code to account

Re: CVS commit: src/sys/dev/acpi

2011-01-04 Thread Mindaugas Rasiukevicius
Jukka Ruohonen jruoho...@iki.fi wrote: +/* + * sysmon_task_queue_cancel: + * + * Cancel a scheduled task. + */ +int +sysmon_task_queue_cancel(void (*func)(void *)) +{ + struct sysmon_task *st; + + if (func == NULL) + return EINVAL; + +

Re: CVS commit: src/sys/dev/acpi

2011-01-04 Thread Jukka Ruohonen
On Tue, Jan 04, 2011 at 12:52:57PM +, Mindaugas Rasiukevicius wrote: 1) There is a use-after-free. Hint: TAILQ_FOREACH_SAFE(). 2) It is not safe; while lock is dropped, the 'next' entry may also be removed and freed. Hint: have a local list and avoid relocking. Hmm. 2) implies that the

Re: CVS commit: src/sys/dev/acpi

2011-01-03 Thread Jukka Ruohonen
On Tue, Jan 04, 2011 at 05:48:49AM +, Jukka Ruohonen wrote: Do not queue functions via sysmon_taskq(9) in the pmf(9) resume hooks. There is a small and unlikely race when the drivers are loaded as modules; suspend, resume, queue a function, and immediately unload the module.

Re: CVS commit: src/sys/dev/acpi

2010-08-08 Thread Christoph Egger
On 09.08.10 07:00, Jukka Ruohonen wrote: Module Name: src Committed By: jruoho Date: Mon Aug 9 05:00:24 UTC 2010 Modified Files: src/sys/dev/acpi: acpi_cpu_cstate.c Log Message: Downgrade the currently supported maximum C-state to C1. There appears to be timer-related

Re: CVS commit: src/sys/dev/acpi

2010-08-08 Thread Jukka Ruohonen
On Mon, Aug 09, 2010 at 07:30:52AM +0200, Christoph Egger wrote: Log Message: Downgrade the currently supported maximum C-state to C1. There appears to be timer-related interrupt issues also in C2. With C1 it is guaranteed that acpicpu(4) will not cause any slowdowns due stalled local APIC

Re: CVS commit: src/sys/dev/acpi

2010-07-30 Thread Jukka Ruohonen
On Sun, Jul 18, 2010 at 08:59:33PM -0400, Christos Zoulas wrote: 1. ACPI seems to define cpuids 1..n; we define 0..n-1. Adjust for that 2. My laptop is dual core, but ACPI reports 4 cpu nodes. Instead of attaching the unmatched ones, make the match fail. Do we want to attach and do

Re: CVS commit: src/sys/dev/acpi

2010-07-30 Thread Christos Zoulas
In article 20100730072156.ga20...@marx.bitnet, Jukka Ruohonen jruoho...@iki.fi wrote: -=-=-=-=-=- On Sun, Jul 18, 2010 at 08:59:33PM -0400, Christos Zoulas wrote: 1. ACPI seems to define cpuids 1..n; we define 0..n-1. Adjust for that 2. My laptop is dual core, but ACPI reports 4 cpu nodes.

Re: CVS commit: src/sys/dev/acpi

2010-07-24 Thread Jukka Ruohonen
On Mon, Jul 19, 2010 at 12:39:08PM +, Quentin Garnier wrote: When the platform uses the APIC interrupt model, OSPM associates processors declared in the namespace with entries in the MADT. Prior to ACPI 3.0, this was accomplished using the processor object's ProcessorID and the ACPI

Re: CVS commit: src/sys/dev/acpi

2010-07-21 Thread Christoph Egger
On 19.07.10 02:59, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Mon Jul 19 00:59:32 UTC 2010 Modified Files: src/sys/dev/acpi: acpi_cpu.c acpi_cpu.h acpi_cpu_cstate.c Log Message: XXX: If this is not correct, revert or fix. This makes my laptop

Re: CVS commit: src/sys/dev/acpi

2010-07-19 Thread Jukka Ruohonen
On Mon, Jul 19, 2010 at 09:32:58AM +0300, Jukka Ruohonen wrote: This is a known issue. No clean solution exist in any implementation I am aware of. The IDs may also vary between the processor object and MADT. As I noted to Christos in private mail, the right solution is likely to include the

Re: CVS commit: src/sys/dev/acpi

2010-07-19 Thread Christoph Egger
Module Name: src Committed By: christos Date: Mon Jul 19 00:59:32 UTC 2010 Modified Files: src/sys/dev/acpi: acpi_cpu.c acpi_cpu.h acpi_cpu_cstate.c Log Message: XXX: If this is not correct, revert or fix. This makes my laptop boot instead of panic: panic: kernel

Re: CVS commit: src/sys/dev/acpi

2010-07-19 Thread Quentin Garnier
On Mon, Jul 19, 2010 at 09:32:58AM +0300, Jukka Ruohonen wrote: On Sun, Jul 18, 2010 at 08:59:33PM -0400, Christos Zoulas wrote: 1. ACPI seems to define cpuids 1..n; we define 0..n-1. Adjust for that ACPI is silent about the CPU IDs in the processor object. In all three Huh? 8.4 Declaring

Re: CVS commit: src/sys/dev/acpi

2010-04-03 Thread Christoph Egger
On 03.04.10 18:29, Jukka Ruohonen wrote: Module Name: src Committed By: jruoho Date: Sat Apr 3 16:29:22 UTC 2010 Modified Files: src/sys/dev/acpi: acpi_bat.c Log Message: Update the limits when a change from absent to present is detected. Does acpi_bat also detect the

Re: CVS commit: src/sys/dev/acpi

2010-04-03 Thread Jukka Ruohonen
On Sat, Apr 03, 2010 at 06:39:54PM +0200, Christoph Egger wrote: Does acpi_bat also detect the other way around ? I.e. when you have multiple batteries you can unplug a full charged battery and then re-plug an empty one for charging. Yes, this should be possible. (This change only fixed an

Re: CVS commit: src/sys/dev/acpi

2010-04-03 Thread Paul Goyette
On Sat, 3 Apr 2010, Christoph Egger wrote: On 03.04.10 18:29, Jukka Ruohonen wrote: Module Name:src Committed By: jruoho Date: Sat Apr 3 16:29:22 UTC 2010 Modified Files: src/sys/dev/acpi: acpi_bat.c Log Message: Update the limits when a change from absent to present

CVS commit: src/sys/dev/acpi

2010-03-10 Thread Jukka Ruohonen
Module Name:src Committed By: jruoho Date: Wed Mar 10 08:12:44 UTC 2010 Modified Files: src/sys/dev/acpi: acpi.c Log Message: Some pretty printing for ACPIVERBOSE. To generate a diff of this commit: cvs rdiff -u -r1.157 -r1.158 src/sys/dev/acpi/acpi.c Please note that

CVS commit: src/sys/dev/acpi

2010-03-10 Thread Jukka Ruohonen
Module Name:src Committed By: jruoho Date: Wed Mar 10 08:12:44 UTC 2010 Modified Files: src/sys/dev/acpi: acpi.c Log Message: Some pretty printing for ACPIVERBOSE. To generate a diff of this commit: cvs rdiff -u -r1.157 -r1.158 src/sys/dev/acpi/acpi.c Please note that

CVS commit: src/sys/dev/acpi

2010-03-10 Thread Jukka Ruohonen
Module Name:src Committed By: jruoho Date: Wed Mar 10 09:42:46 UTC 2010 Modified Files: src/sys/dev/acpi: acpi.c acpivar.h Log Message: Move the ACPI_ACTIVATE_DEV block to one place. While there, provide missing prototype for a function, try to make the code more simple,

CVS commit: src/sys/dev/acpi

2010-03-09 Thread Jukka Ruohonen
Module Name:src Committed By: jruoho Date: Tue Mar 9 18:15:22 UTC 2010 Modified Files: src/sys/dev/acpi: acpi.c acpi_pci.c acpi_wakedev.c acpivar.h Log Message: Remove the namespace scopes. These are neither used nor useful beyond the parser and interpreter. ok

CVS commit: src/sys/dev/acpi

2010-03-08 Thread Jukka Ruohonen
Module Name:src Committed By: jruoho Date: Mon Mar 8 10:53:03 UTC 2010 Modified Files: src/sys/dev/acpi: wmi_acpi.c Log Message: Add a detachment routine. To generate a diff of this commit: cvs rdiff -u -r1.15 -r1.16 src/sys/dev/acpi/wmi_acpi.c Please note that diffs

CVS commit: src/sys/dev/acpi

2010-03-08 Thread Jukka Ruohonen
Module Name:src Committed By: jruoho Date: Mon Mar 8 11:39:43 UTC 2010 Modified Files: src/sys/dev/acpi: dalb_acpi.c Log Message: Remove unused struct sysctllog from the softc. To generate a diff of this commit: cvs rdiff -u -r1.9 -r1.10 src/sys/dev/acpi/dalb_acpi.c

CVS commit: src/sys/dev/acpi

2010-03-08 Thread Jukka Ruohonen
Module Name:src Committed By: jruoho Date: Mon Mar 8 11:39:43 UTC 2010 Modified Files: src/sys/dev/acpi: dalb_acpi.c Log Message: Remove unused struct sysctllog from the softc. To generate a diff of this commit: cvs rdiff -u -r1.9 -r1.10 src/sys/dev/acpi/dalb_acpi.c

CVS commit: src/sys/dev/acpi

2010-03-08 Thread Jukka Ruohonen
Module Name:src Committed By: jruoho Date: Mon Mar 8 11:45:45 UTC 2010 Modified Files: src/sys/dev/acpi: acpi_bat.c Log Message: Use the predefined ACPI_STA_BATTERY_PRESENT instead of defining a local one. To generate a diff of this commit: cvs rdiff -u -r1.84 -r1.85

CVS commit: src/sys/dev/acpi

2010-03-08 Thread Jukka Ruohonen
Module Name:src Committed By: jruoho Date: Mon Mar 8 11:45:45 UTC 2010 Modified Files: src/sys/dev/acpi: acpi_bat.c Log Message: Use the predefined ACPI_STA_BATTERY_PRESENT instead of defining a local one. To generate a diff of this commit: cvs rdiff -u -r1.84 -r1.85

CVS commit: src/sys/dev/acpi

2010-03-08 Thread Constantine A. Murenin
Module Name:src Committed By: cnst Date: Mon Mar 8 11:54:35 UTC 2010 Modified Files: src/sys/dev/acpi: atk0110.c Log Message: register aibs(4) with pmf(9) to quiet the latter down; reported Dieter Roelants To generate a diff of this commit: cvs rdiff -u -r1.9 -r1.10

CVS commit: src/sys/dev/acpi

2010-03-08 Thread Constantine A. Murenin
Module Name:src Committed By: cnst Date: Mon Mar 8 11:54:35 UTC 2010 Modified Files: src/sys/dev/acpi: atk0110.c Log Message: register aibs(4) with pmf(9) to quiet the latter down; reported Dieter Roelants To generate a diff of this commit: cvs rdiff -u -r1.9 -r1.10

Re: CVS commit: src/sys/dev/acpi

2010-03-06 Thread Constantine Aleksandrovich Murenin
This doesn't sound right: if sysmon_envsys(9) functions are specifically used in these drivers, then depending on header pollution for the prototypes of these functions instead of explicitly including dev/sysmon/sysmonvar.h sounds like a definite bug, not at all a feature. C. On 05/03/2010,

CVS commit: src/sys/dev/acpi

2010-03-05 Thread Jukka Ruohonen
Module Name:src Committed By: jruoho Date: Fri Mar 5 08:30:48 UTC 2010 Modified Files: src/sys/dev/acpi: acpi_ecvar.h acpi_madt.h acpi_osd.h acpi_pci.h acpi_slit.h acpi_srat.h acpi_timer.h acpi_wakedev.h acpica.h acpireg.h acpivar.h fdc_acpireg.h

CVS commit: src/sys/dev/acpi

2010-03-05 Thread Jukka Ruohonen
Module Name:src Committed By: jruoho Date: Fri Mar 5 08:30:48 UTC 2010 Modified Files: src/sys/dev/acpi: acpi_ecvar.h acpi_madt.h acpi_osd.h acpi_pci.h acpi_slit.h acpi_srat.h acpi_timer.h acpi_wakedev.h acpica.h acpireg.h acpivar.h fdc_acpireg.h

CVS commit: src/sys/dev/acpi

2010-03-05 Thread Paul Goyette
Module Name:src Committed By: pgoyette Date: Fri Mar 5 12:44:16 UTC 2010 Modified Files: src/sys/dev/acpi: acpi_tz.c Log Message: As pointed out by Rhialto, degrees Kelvin is redundant. So fix a couple of comments related to converstion between Kelvin and degC. To

CVS commit: src/sys/dev/acpi

2010-03-05 Thread Paul Goyette
Module Name:src Committed By: pgoyette Date: Fri Mar 5 12:44:16 UTC 2010 Modified Files: src/sys/dev/acpi: acpi_tz.c Log Message: As pointed out by Rhialto, degrees Kelvin is redundant. So fix a couple of comments related to converstion between Kelvin and degC. To

CVS commit: src/sys/dev/acpi

2010-03-05 Thread Jukka Ruohonen
Module Name:src Committed By: jruoho Date: Fri Mar 5 14:00:17 UTC 2010 Modified Files: src/sys/dev/acpi: acpi.c acpi_acad.c acpi_apm.c acpi_bat.c acpi_button.c acpi_ec.c acpi_lid.c acpi_madt.c acpi_pci.c acpi_pci_link.c acpi_powerres.c

CVS commit: src/sys/dev/acpi

2010-03-05 Thread Jukka Ruohonen
Module Name:src Committed By: jruoho Date: Fri Mar 5 14:00:17 UTC 2010 Modified Files: src/sys/dev/acpi: acpi.c acpi_acad.c acpi_apm.c acpi_bat.c acpi_button.c acpi_ec.c acpi_lid.c acpi_madt.c acpi_pci.c acpi_pci_link.c acpi_powerres.c

CVS commit: src/sys/dev/acpi

2010-03-05 Thread Jukka Ruohonen
Module Name:src Committed By: jruoho Date: Fri Mar 5 17:04:26 UTC 2010 Modified Files: src/sys/dev/acpi: acpi_timer.c acpi_timer.h Log Message: Add missing license. ok drochner@ To generate a diff of this commit: cvs rdiff -u -r1.15 -r1.16

CVS commit: src/sys/dev/acpi

2010-03-05 Thread Jukka Ruohonen
Module Name:src Committed By: jruoho Date: Fri Mar 5 17:04:26 UTC 2010 Modified Files: src/sys/dev/acpi: acpi_timer.c acpi_timer.h Log Message: Add missing license. ok drochner@ To generate a diff of this commit: cvs rdiff -u -r1.15 -r1.16

CVS commit: src/sys/dev/acpi

2010-03-05 Thread Jukka Ruohonen
Module Name:src Committed By: jruoho Date: Fri Mar 5 21:01:44 UTC 2010 Modified Files: src/sys/dev/acpi: acpi.c acpi_lid.c acpi_wakedev.c acpi_wakedev.h Log Message: Preparing a device for wakeup involves: (a) turning on all power resources required by the device; and

CVS commit: src/sys/dev/acpi

2010-03-05 Thread Jukka Ruohonen
Module Name:src Committed By: jruoho Date: Fri Mar 5 21:01:44 UTC 2010 Modified Files: src/sys/dev/acpi: acpi.c acpi_lid.c acpi_wakedev.c acpi_wakedev.h Log Message: Preparing a device for wakeup involves: (a) turning on all power resources required by the device; and

CVS commit: src/sys/dev/acpi

2010-03-05 Thread Jukka Ruohonen
Module Name:src Committed By: jruoho Date: Fri Mar 5 22:00:11 UTC 2010 Modified Files: src/sys/dev/acpi: acpi_wakedev.c Log Message: Add the _COMPONENT definition and missing prototypes. Some related cosmetics. To generate a diff of this commit: cvs rdiff -u -r1.4

CVS commit: src/sys/dev/acpi

2010-03-05 Thread Jukka Ruohonen
Module Name:src Committed By: jruoho Date: Fri Mar 5 22:00:11 UTC 2010 Modified Files: src/sys/dev/acpi: acpi_wakedev.c Log Message: Add the _COMPONENT definition and missing prototypes. Some related cosmetics. To generate a diff of this commit: cvs rdiff -u -r1.4

CVS commit: src/sys/dev/acpi

2010-03-04 Thread Jukka Ruohonen
Module Name:src Committed By: jruoho Date: Thu Mar 4 08:44:55 UTC 2010 Modified Files: src/sys/dev/acpi: atk0110.c Log Message: Provide the _COMPONENT definition and use ACPI_FREE(x) instead of AcpiOsFree(). If the memory tracking of ACPICA is enabled, the latter is

CVS commit: src/sys/dev/acpi

2010-03-04 Thread Paul Goyette
Module Name:src Committed By: pgoyette Date: Thu Mar 4 13:07:01 UTC 2010 Modified Files: src/sys/dev/acpi: smbus_acpi.c Log Message: Fix this correctly. Thanks jruoho@ To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.5 src/sys/dev/acpi/smbus_acpi.c Please

CVS commit: src/sys/dev/acpi

2010-03-04 Thread Paul Goyette
Module Name:src Committed By: pgoyette Date: Thu Mar 4 13:07:01 UTC 2010 Modified Files: src/sys/dev/acpi: smbus_acpi.c Log Message: Fix this correctly. Thanks jruoho@ To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.5 src/sys/dev/acpi/smbus_acpi.c Please

CVS commit: src/sys/dev/acpi

2010-03-04 Thread Paul Goyette
Module Name:src Committed By: pgoyette Date: Thu Mar 4 13:11:15 UTC 2010 Modified Files: src/sys/dev/acpi: smbus_acpi.c Log Message: This really should be ACPI_BUS_COMPONENT Maybe I should stay out the acpi stuff? :) To generate a diff of this commit: cvs rdiff -u

CVS commit: src/sys/dev/acpi

2010-03-04 Thread Paul Goyette
Module Name:src Committed By: pgoyette Date: Thu Mar 4 13:11:15 UTC 2010 Modified Files: src/sys/dev/acpi: smbus_acpi.c Log Message: This really should be ACPI_BUS_COMPONENT Maybe I should stay out the acpi stuff? :) To generate a diff of this commit: cvs rdiff -u

Re: CVS commit: src/sys/dev/acpi

2010-03-04 Thread Paul Goyette
On Thu, 4 Mar 2010, Jukka Ruohonen wrote: Well, this is wrong in the sense that the _COMPONENT definition was incorrect to begin with, and in the sense that we have explicitly tried to recently add the _COMPONENT definitions. Also: now it does BadThings(tm) if the memory tracking of ACPICA is

Re: CVS commit: src/sys/dev/acpi

2010-03-04 Thread Jukka Ruohonen
On Thu, Mar 04, 2010 at 05:12:43AM -0800, Paul Goyette wrote: On Thu, 4 Mar 2010, Jukka Ruohonen wrote: Well, this is wrong in the sense that the _COMPONENT definition was incorrect to begin with, and in the sense that we have explicitly tried to recently add the _COMPONENT definitions.

CVS commit: src/sys/dev/acpi

2010-03-04 Thread Jukka Ruohonen
Module Name:src Committed By: jruoho Date: Thu Mar 4 20:17:30 UTC 2010 Modified Files: src/sys/dev/acpi: acpi.c atk0110.c smbus_acpi.c Log Message: Fix ACPI_DEBUG build failures reported by Greg A. Woods. To generate a diff of this commit: cvs rdiff -u -r1.152 -r1.153

CVS commit: src/sys/dev/acpi

2010-03-04 Thread Jukka Ruohonen
Module Name:src Committed By: jruoho Date: Thu Mar 4 20:17:30 UTC 2010 Modified Files: src/sys/dev/acpi: acpi.c atk0110.c smbus_acpi.c Log Message: Fix ACPI_DEBUG build failures reported by Greg A. Woods. To generate a diff of this commit: cvs rdiff -u -r1.152 -r1.153

CVS commit: src/sys/dev/acpi

2010-03-04 Thread Jukka Ruohonen
Module Name:src Committed By: jruoho Date: Thu Mar 4 20:46:18 UTC 2010 Modified Files: src/sys/dev/acpi: smbus_acpi.c Log Message: Fix two memory leaks. To generate a diff of this commit: cvs rdiff -u -r1.7 -r1.8 src/sys/dev/acpi/smbus_acpi.c Please note that diffs

CVS commit: src/sys/dev/acpi

2010-03-04 Thread Jukka Ruohonen
Module Name:src Committed By: jruoho Date: Thu Mar 4 20:46:18 UTC 2010 Modified Files: src/sys/dev/acpi: smbus_acpi.c Log Message: Fix two memory leaks. To generate a diff of this commit: cvs rdiff -u -r1.7 -r1.8 src/sys/dev/acpi/smbus_acpi.c Please note that diffs

CVS commit: src/sys/dev/acpi

2010-03-04 Thread Jukka Ruohonen
Module Name:src Committed By: jruoho Date: Thu Mar 4 22:29:47 UTC 2010 Modified Files: src/sys/dev/acpi: acpi_button.c Log Message: Cleanup: * Semantics. * No need for dev/acpi/acpica.h. * Reduce the amount of error reporting. * Remove ACPI_BUT_DEBUG and

CVS commit: src/sys/dev/acpi

2010-03-04 Thread Jukka Ruohonen
Module Name:src Committed By: jruoho Date: Thu Mar 4 22:29:47 UTC 2010 Modified Files: src/sys/dev/acpi: acpi_button.c Log Message: Cleanup: * Semantics. * No need for dev/acpi/acpica.h. * Reduce the amount of error reporting. * Remove ACPI_BUT_DEBUG and

CVS commit: src/sys/dev/acpi

2010-03-04 Thread Jukka Ruohonen
Module Name:src Committed By: jruoho Date: Thu Mar 4 23:25:07 UTC 2010 Modified Files: src/sys/dev/acpi: acpi.c Log Message: Remove ACPI_BUG_DEBUG by using ACPI_DEBUG_PRINT(x) instead. To generate a diff of this commit: cvs rdiff -u -r1.153 -r1.154

CVS commit: src/sys/dev/acpi

2010-03-04 Thread Jukka Ruohonen
Module Name:src Committed By: jruoho Date: Thu Mar 4 23:25:07 UTC 2010 Modified Files: src/sys/dev/acpi: acpi.c Log Message: Remove ACPI_BUG_DEBUG by using ACPI_DEBUG_PRINT(x) instead. To generate a diff of this commit: cvs rdiff -u -r1.153 -r1.154

Re: CVS commit: src/sys/dev/acpi

2010-03-03 Thread Jukka Ruohonen
On Thu, Mar 04, 2010 at 03:10:18AM +, Paul Goyette wrote: Module Name: src Committed By: pgoyette Date: Thu Mar 4 03:10:18 UTC 2010 Modified Files: src/sys/dev/acpi: smbus_acpi.c Log Message: Replace ACPI_FREE() with AcpiOsFree() so we no longer need to define

CVS commit: src/sys/dev/acpi

2010-03-02 Thread Jukka Ruohonen
Module Name:src Committed By: jruoho Date: Tue Mar 2 18:44:47 UTC 2010 Modified Files: src/sys/dev/acpi: acpi.c acpi_ec.c acpi_madt.c acpi_powerres.c acpi_resource.c aiboost.c atk0110.c dalb_acpi.c fdc_acpi.c sony_acpi.c Log Message: Format string

CVS commit: src/sys/dev/acpi

2010-03-02 Thread Jukka Ruohonen
Module Name:src Committed By: jruoho Date: Tue Mar 2 18:44:47 UTC 2010 Modified Files: src/sys/dev/acpi: acpi.c acpi_ec.c acpi_madt.c acpi_powerres.c acpi_resource.c aiboost.c atk0110.c dalb_acpi.c fdc_acpi.c sony_acpi.c Log Message: Format string

CVS commit: src/sys/dev/acpi

2010-03-02 Thread Jukka Ruohonen
Module Name:src Committed By: jruoho Date: Wed Mar 3 06:54:25 UTC 2010 Modified Files: src/sys/dev/acpi: acpi.c Log Message: Refactor acpi_make_devnode() to make it a little more readable. No functional change intended. To generate a diff of this commit: cvs rdiff -u

CVS commit: src/sys/dev/acpi

2010-03-02 Thread Jukka Ruohonen
Module Name:src Committed By: jruoho Date: Wed Mar 3 06:54:25 UTC 2010 Modified Files: src/sys/dev/acpi: acpi.c Log Message: Refactor acpi_make_devnode() to make it a little more readable. No functional change intended. To generate a diff of this commit: cvs rdiff -u

CVS commit: src/sys/dev/acpi

2010-03-02 Thread Jukka Ruohonen
Module Name:src Committed By: jruoho Date: Wed Mar 3 06:57:05 UTC 2010 Modified Files: src/sys/dev/acpi: acpi.c Log Message: Convert the single instance of ACPI_EXTRA_DEBUG to ACPIVERBOSE. To generate a diff of this commit: cvs rdiff -u -r1.151 -r1.152

CVS commit: src/sys/dev/acpi

2010-03-02 Thread Jukka Ruohonen
Module Name:src Committed By: jruoho Date: Wed Mar 3 06:57:05 UTC 2010 Modified Files: src/sys/dev/acpi: acpi.c Log Message: Convert the single instance of ACPI_EXTRA_DEBUG to ACPIVERBOSE. To generate a diff of this commit: cvs rdiff -u -r1.151 -r1.152

  1   2   >