CVS commit: src/sys/dev/bluetooth

2022-10-26 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Wed Oct 26 23:44:03 UTC 2022 Modified Files: src/sys/dev/bluetooth: btuart.c Log Message: btuart(4): Convert to ttylock/ttyunlock. To generate a diff of this commit: cvs rdiff -u -r1.30 -r1.31 src/sys/dev/bluetooth/btuart.c

CVS commit: src/sys/dev/bluetooth

2022-10-26 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Wed Oct 26 23:44:03 UTC 2022 Modified Files: src/sys/dev/bluetooth: btuart.c Log Message: btuart(4): Convert to ttylock/ttyunlock. To generate a diff of this commit: cvs rdiff -u -r1.30 -r1.31 src/sys/dev/bluetooth/btuart.c

CVS commit: src/sys/dev/bluetooth

2022-10-26 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Wed Oct 26 23:43:34 UTC 2022 Modified Files: src/sys/dev/bluetooth: bth5.c Log Message: bth5(4): Convert to ttylock/ttyunlock. To generate a diff of this commit: cvs rdiff -u -r1.7 -r1.8 src/sys/dev/bluetooth/bth5.c Please

CVS commit: src/sys/dev/bluetooth

2022-10-26 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Wed Oct 26 23:43:34 UTC 2022 Modified Files: src/sys/dev/bluetooth: bth5.c Log Message: bth5(4): Convert to ttylock/ttyunlock. To generate a diff of this commit: cvs rdiff -u -r1.7 -r1.8 src/sys/dev/bluetooth/bth5.c Please

CVS commit: src/sys/dev/bluetooth

2022-10-26 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Wed Oct 26 23:43:21 UTC 2022 Modified Files: src/sys/dev/bluetooth: bcsp.c Log Message: bcsp(4): Convert to ttylock/ttyunlock. To generate a diff of this commit: cvs rdiff -u -r1.32 -r1.33 src/sys/dev/bluetooth/bcsp.c

CVS commit: src/sys/dev/bluetooth

2022-10-26 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Wed Oct 26 23:43:21 UTC 2022 Modified Files: src/sys/dev/bluetooth: bcsp.c Log Message: bcsp(4): Convert to ttylock/ttyunlock. To generate a diff of this commit: cvs rdiff -u -r1.32 -r1.33 src/sys/dev/bluetooth/bcsp.c

CVS commit: src/sys/dev/bluetooth

2022-06-28 Thread Iain Hibbert
Module Name:src Committed By: plunky Date: Tue Jun 28 13:25:36 UTC 2022 Modified Files: src/sys/dev/bluetooth: bcsp.c bth5.c btuart.c Log Message: remove KASSERT() checking for t_oproc at open since assigning this line discipline to a pty may not have that set. Instead do

CVS commit: src/sys/dev/bluetooth

2022-06-28 Thread Iain Hibbert
Module Name:src Committed By: plunky Date: Tue Jun 28 13:25:36 UTC 2022 Modified Files: src/sys/dev/bluetooth: bcsp.c bth5.c btuart.c Log Message: remove KASSERT() checking for t_oproc at open since assigning this line discipline to a pty may not have that set. Instead do

CVS commit: src/sys/dev/bluetooth

2019-11-16 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Sat Nov 16 22:06:50 UTC 2019 Modified Files: src/sys/dev/bluetooth: bth5.c Log Message: Don't wait in interrupt context. To generate a diff of this commit: cvs rdiff -u -r1.5 -r1.6 src/sys/dev/bluetooth/bth5.c Please note

CVS commit: src/sys/dev/bluetooth

2019-11-16 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Sat Nov 16 22:06:50 UTC 2019 Modified Files: src/sys/dev/bluetooth: bth5.c Log Message: Don't wait in interrupt context. To generate a diff of this commit: cvs rdiff -u -r1.5 -r1.6 src/sys/dev/bluetooth/bth5.c Please note

Re: CVS commit: src/sys/dev/bluetooth

2015-05-08 Thread Maxime Villard
Le 30/04/2015 18:01, Christos Zoulas a écrit : Module Name: src Committed By: christos Date: Thu Apr 30 16:01:52 UTC 2015 Modified Files: src/sys/dev/bluetooth: bcsp.c Log Message: Fix more memory leaks by changing the transmit routines to always free the mbuf to send.

Re: CVS commit: src/sys/dev/bluetooth

2015-05-08 Thread Christos Zoulas
On May 8, 12:05pm, m...@m00nbsd.net (Maxime Villard) wrote: -- Subject: Re: CVS commit: src/sys/dev/bluetooth | Why didn't you put a goto out here: | | 1369:if (_m-m_len 0) | 1370:return false; I missed it. I don't know if the test is valid though

Re: CVS commit: src/sys/dev/bluetooth

2015-05-01 Thread Martin Husemann
On Fri, May 01, 2015 at 08:42:57AM +0200, Maxime Villard wrote: Yes, ffs_oldfscompat_read() should theoretically be called before ffs_superblock_validate(), otherwise, several fields being overwritten, you either end up with unsanitized values or your disk gets kicked out. I am not sure what

Re: CVS commit: src/sys/dev/bluetooth

2015-05-01 Thread Maxime Villard
Le 30/04/2015 16:07, Christos Zoulas a écrit : On Apr 30, 8:57am, m...@m00nbsd.net (Maxime Villard) wrote: -- Subject: Re: CVS commit: src/sys/dev/bluetooth How about helping investigate what's wrong with: /* Check the size of cylinder groups */ fs_cgsize = ffs_fragroundup

Re: CVS commit: src/sys/dev/bluetooth

2015-04-30 Thread Maxime Villard
What about the M_PREPEND()? Le 29/04/2015 23:07, Iain Hibbert a écrit : On Wed, 29 Apr 2015, Christos Zoulas wrote: On Apr 29, 4:27pm, m...@m00nbsd.net (Maxime Villard) wrote: -- Subject: Re: CVS commit: src/sys/dev/bluetooth | You didn't test this change, nor did you test the five other

Re: CVS commit: src/sys/dev/bluetooth

2015-04-30 Thread Christos Zoulas
On Apr 30, 8:57am, m...@m00nbsd.net (Maxime Villard) wrote: -- Subject: Re: CVS commit: src/sys/dev/bluetooth | What about the M_PREPEND()? void m_freem(struct mbuf *m) { struct mbuf *n; if (m == NULL) return; do { MFREE(m, n

Re: CVS commit: src/sys/dev/bluetooth

2015-04-30 Thread Christos Zoulas
On Apr 29, 10:07pm, plu...@ogmig.net (Iain Hibbert) wrote: -- Subject: Re: CVS commit: src/sys/dev/bluetooth | On Wed, 29 Apr 2015, Christos Zoulas wrote: | | On Apr 29, 4:27pm, m...@m00nbsd.net (Maxime Villard) wrote: | -- Subject: Re: CVS commit: src/sys/dev/bluetooth | | | You didn't

Re: CVS commit: src/sys/dev/bluetooth

2015-04-29 Thread Maxime Villard
Le 27/04/2015 19:36, Christos Zoulas a écrit : Module Name: src Committed By: christos Date: Mon Apr 27 17:36:41 UTC 2015 Modified Files: src/sys/dev/bluetooth: bcsp.c Log Message: free mbuf on failure (Brainy) To generate a diff of this commit: cvs rdiff -u -r1.25

Re: CVS commit: src/sys/dev/bluetooth

2015-04-29 Thread Iain Hibbert
On Wed, 29 Apr 2015, Christos Zoulas wrote: On Apr 29, 4:27pm, m...@m00nbsd.net (Maxime Villard) wrote: -- Subject: Re: CVS commit: src/sys/dev/bluetooth | You didn't test this change, nor did you test the five other fixes | you committed. I checked the code to the best of my ability

Re: CVS commit: src/sys/dev/bluetooth

2015-04-29 Thread Christos Zoulas
On Apr 29, 4:27pm, m...@m00nbsd.net (Maxime Villard) wrote: -- Subject: Re: CVS commit: src/sys/dev/bluetooth | You didn't test this change, nor did you test the five other fixes | you committed. I checked the code to the best of my ability; perhaps I missed something. | So now please revert

Re: CVS commit: src/sys/dev/bluetooth

2012-01-11 Thread Radoslaw Kujawa
Hi Iain. On 7 sty 2012, at 09:42, Iain Hibbert wrote: I don't have a USB keyboard, but pressing the caps lock on my laptop or Bluetooth keyboard does always toggle both LEDs. Even after applying your patch it doesn't work this way for me, so probably the problem with this is somewhere else.

Re: CVS commit: src/sys/dev/bluetooth

2012-01-11 Thread David Laight
On Wed, Jan 11, 2012 at 05:27:45PM +, Iain Hibbert wrote: Module Name: src Committed By: plunky Date: Wed Jan 11 17:27:45 UTC 2012 Modified Files: src/sys/dev/bluetooth: bthidev.c btkbd.c Log Message: offset processing of input reports to a kernel thread, to avoid

Re: CVS commit: src/sys/dev/bluetooth

2012-01-07 Thread Iain Hibbert
On Mon, 2 Jan 2012, Radoslaw Kujawa wrote: On 2 sty 2012, at 11:00, Iain Hibbert wrote: On Sun, 1 Jan 2012, Radoslaw Kujawa wrote: btkbd_set_leds() may be called from wskbd directly (by pressing caps lock on your built-in keyboard for instance) I've tested this patch by pressing the

Re: CVS commit: src/sys/dev/bluetooth

2012-01-02 Thread Iain Hibbert
On Sun, 1 Jan 2012, Radoslaw Kujawa wrote: On 1 sty 2012, at 20:44, Iain Hibbert wrote: On Sat, 31 Dec 2011, Radoslaw Kujawa wrote: Module Name: src Committed By: rkujawa Date: Sat Dec 31 01:16:09 UTC 2011 Modified Files: src/sys/dev/bluetooth:

re: CVS commit: src/sys/dev/bluetooth

2012-01-02 Thread matthew green
Module Name: src Committed By:rkujawa Date:Sat Dec 31 01:16:09 UTC 2011 Modified Files: src/sys/dev/bluetooth: bthidev.c btkbd.c Log Message: Fix panic triggered by pressing the caps lock key: http://c0ff33.net/drop/bt_caps_panic.jpg this

Re: CVS commit: src/sys/dev/bluetooth

2012-01-02 Thread Iain Hibbert
On Mon, 2 Jan 2012, Iain Hibbert wrote: Also, what kernel options do you have? I am using i386 and have always used DIAGNOSTIC (built in now) and I have run with LOCKDEBUG in the past though am not at the moment booting a LOCKDEBUG kernel shows the same problem here btw iain

re: CVS commit: src/sys/dev/bluetooth

2012-01-02 Thread Iain Hibbert
On Mon, 2 Jan 2012, matthew green wrote: Just dropping the lock and reaquiring it around the sc_input/sc_feature call is probably not exactly the right thing to do though (as the stack will not be aware that that might have happened and data structures could have changed), it really

Re: CVS commit: src/sys/dev/bluetooth

2012-01-02 Thread Radoslaw Kujawa
Hi. On 2 sty 2012, at 11:00, Iain Hibbert wrote: On Sun, 1 Jan 2012, Radoslaw Kujawa wrote: I can easily reproduce this problem with Apple Wireless Keyboard (version without numeric keypad) on NetBSD/amd64 HEAD. If this patch is not applied, pressing caps lock always results in panic, as

Re: CVS commit: src/sys/dev/bluetooth

2012-01-01 Thread Radoslaw Kujawa
Hi Iain. Sorry, I should have consulted you before committing this. On 1 sty 2012, at 20:44, Iain Hibbert wrote: On Sat, 31 Dec 2011, Radoslaw Kujawa wrote: Module Name: src Committed By:rkujawa Date:Sat Dec 31 01:16:09 UTC 2011 Modified Files:

Re: CVS commit: src/sys/dev/bluetooth

2011-12-30 Thread Iain Hibbert
On Sat, 31 Dec 2011, Radoslaw Kujawa wrote: Module Name: src Committed By: rkujawa Date: Sat Dec 31 01:16:09 UTC 2011 Modified Files: src/sys/dev/bluetooth: bthidev.c btkbd.c Log Message: Fix panic triggered by pressing the caps lock key: