CVS commit: src/sys/dev/eisa
Module Name:src Committed By: thorpej Date: Tue Jul 12 02:12:26 UTC 2022 Modified Files: src/sys/dev/eisa: mlx_eisa.c Log Message: Remove unneeded bus_space_barrier() calls. To generate a diff of this commit: cvs rdiff -u -r1.29 -r1.30 src/sys/dev/eisa/mlx_eisa.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/sys/dev/eisa/mlx_eisa.c diff -u src/sys/dev/eisa/mlx_eisa.c:1.29 src/sys/dev/eisa/mlx_eisa.c:1.30 --- src/sys/dev/eisa/mlx_eisa.c:1.29 Sat Jul 24 19:06:25 2021 +++ src/sys/dev/eisa/mlx_eisa.c Tue Jul 12 02:12:26 2022 @@ -1,4 +1,4 @@ -/* $NetBSD: mlx_eisa.c,v 1.29 2021/07/24 19:06:25 thorpej Exp $ */ +/* $NetBSD: mlx_eisa.c,v 1.30 2022/07/12 02:12:26 thorpej Exp $ */ /*- * Copyright (c) 2001 The NetBSD Foundation, Inc. @@ -34,7 +34,7 @@ */ #include -__KERNEL_RCSID(0, "$NetBSD: mlx_eisa.c,v 1.29 2021/07/24 19:06:25 thorpej Exp $"); +__KERNEL_RCSID(0, "$NetBSD: mlx_eisa.c,v 1.30 2022/07/12 02:12:26 thorpej Exp $"); #include #include @@ -221,9 +221,6 @@ mlx_v1_submit(struct mlx_softc *mlx, str /* Copy mailbox data to window. */ bus_space_write_region_1(mlx->mlx_iot, mlx->mlx_ioh, MLX_V1REG_MAILBOX, mc->mc_mbox, 13); - bus_space_barrier(mlx->mlx_iot, mlx->mlx_ioh, - MLX_V1REG_MAILBOX, 13, - BUS_SPACE_BARRIER_WRITE); /* Post command. */ mlx_outb(mlx, MLX_V1REG_IDB, MLX_V1_IDB_FULL);
CVS commit: src/sys/dev/eisa
Module Name:src Committed By: thorpej Date: Tue Jul 12 02:12:26 UTC 2022 Modified Files: src/sys/dev/eisa: mlx_eisa.c Log Message: Remove unneeded bus_space_barrier() calls. To generate a diff of this commit: cvs rdiff -u -r1.29 -r1.30 src/sys/dev/eisa/mlx_eisa.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/dev/eisa
Module Name:src
Committed By: riastradh
Date: Fri Aug 30 00:36:53 UTC 2019
Modified Files:
src/sys/dev/eisa: if_fea.c
Log Message:
Delete dead null test after malloc(M_WAITOK).
Reported as a possible null pointer dereference by Dr Silvio Cesare
of InfoSect, but the branch is dead code anyway.
To generate a diff of this commit:
cvs rdiff -u -r1.47 -r1.48 src/sys/dev/eisa/if_fea.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/dev/eisa/if_fea.c
diff -u src/sys/dev/eisa/if_fea.c:1.47 src/sys/dev/eisa/if_fea.c:1.48
--- src/sys/dev/eisa/if_fea.c:1.47 Thu Jul 14 10:19:06 2016
+++ src/sys/dev/eisa/if_fea.c Fri Aug 30 00:36:53 2019
@@ -1,4 +1,4 @@
-/* $NetBSD: if_fea.c,v 1.47 2016/07/14 10:19:06 msaitoh Exp $ */
+/* $NetBSD: if_fea.c,v 1.48 2019/08/30 00:36:53 riastradh Exp $ */
/*-
* Copyright (c) 1995, 1996 Matt Thomas
@@ -33,7 +33,7 @@
*/
#include
-__KERNEL_RCSID(0, "$NetBSD: if_fea.c,v 1.47 2016/07/14 10:19:06 msaitoh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_fea.c,v 1.48 2019/08/30 00:36:53 riastradh Exp $");
#include "opt_inet.h"
@@ -245,10 +245,6 @@ pdq_eisa_attach(
int irq = ffs(ed->ioconf.irq) - 1;
sc = (pdq_softc_t *) malloc(sizeof(*sc), M_DEVBUF, M_WAITOK|M_ZERO);
-if (sc == NULL) {
- printf("fea%d: malloc failed!\n", sc->sc_if.if_unit);
- return -1;
-}
pdqs_eisa[ed->unit] = sc;
sc->sc_if.if_name = "fea";
CVS commit: src/sys/dev/eisa
Module Name:src Committed By: pooka Date: Mon Jan 18 19:00:58 UTC 2010 Modified Files: src/sys/dev/eisa: if_ep_eisa.c if_fea.c if_tlp_eisa.c Log Message: nuke unused bpf inclusions To generate a diff of this commit: cvs rdiff -u -r1.41 -r1.42 src/sys/dev/eisa/if_ep_eisa.c cvs rdiff -u -r1.42 -r1.43 src/sys/dev/eisa/if_fea.c cvs rdiff -u -r1.23 -r1.24 src/sys/dev/eisa/if_tlp_eisa.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
