Re: CVS commit: src/sys/dev/scsipi

2020-09-19 Thread Kimmo Suominen
I don't think this should be reverted, because LUN 0 must exist, but if there is no device on it, it will report "NOT PRESENT". We do not want the scan to stop in this case, but it should continue with other LUNs (such as those found through REPORT LUNS in the future). Kind regards, + Kimmo On

Re: CVS commit: src/sys/dev/scsipi

2020-07-11 Thread Kimmo Suominen
On Sun, Jul 12, 2020 at 12:05:37AM +0700, Robert Elz wrote: > Just to make things clear here, the LUN you're talking about is not > the scsi unit number (which is what I think Martin was referring to) > but a sub-device number within a single scsi ID. Right? Correct. I should have written "SCSI

Re: CVS commit: src/sys/dev/scsipi

2020-07-11 Thread Robert Elz
Date:Sat, 11 Jul 2020 18:24:51 +0300 From:Kimmo Suominen Message-ID: <20200711152451.ga1...@homeworld.netbsd.org> | On Sat, Jul 11, 2020 at 05:00:02PM +0200, Martin Husemann wrote: | > I don't understand the change. When was this broken? This has always worked

Re: CVS commit: src/sys/dev/scsipi

2020-07-11 Thread Martin Husemann
On Sat, Jul 11, 2020 at 06:24:51PM +0300, Kimmo Suominen wrote: > I think all real SCSI hardware I've had has always just only had LUN 0, > and each disk has been on its own SCSI ID (target). Yes, I confused ID and LUN here - just ignore me. Martin

Re: CVS commit: src/sys/dev/scsipi

2020-07-11 Thread Kimmo Suominen
On Sat, Jul 11, 2020 at 05:00:02PM +0200, Martin Husemann wrote: > I don't understand the change. When was this broken? This has always worked > for me e.g. with the sd0 at LUN 3 and the controller at 6 or 7. I think all real SCSI hardware I've had has always just only had LUN 0, and each disk

Re: CVS commit: src/sys/dev/scsipi

2020-07-11 Thread Martin Husemann
On Sat, Jul 11, 2020 at 05:57:46PM +0300, Kimmo Suominen wrote: > On Sat, Jul 11, 2020 at 05:47:34PM +0300, Jukka Ruohonen wrote: > > I'd reckon a pullup to NetBSD 9 would be in order? > > Yes, I was just waiting to be able to link to mail-index. I had > already checked that the patch applies

Re: CVS commit: src/sys/dev/scsipi

2020-07-11 Thread Kimmo Suominen
On Sat, Jul 11, 2020 at 05:47:34PM +0300, Jukka Ruohonen wrote: > I'd reckon a pullup to NetBSD 9 would be in order? Yes, I was just waiting to be able to link to mail-index. I had already checked that the patch applies cleanly to both netbsd-9 and netbsd-8.

Re: CVS commit: src/sys/dev/scsipi

2020-07-11 Thread Jukka Ruohonen
On Sat, Jul 11, 2020 at 02:31:46PM +, Kimmo Suominen wrote: > Use case 2: A Linode boot profile with multiple disks results in > the first disk ("sda") on LUN 1, while the second disk ("sdb") is > on LUN 0, each on their own bus. As Linode is quite popular, and supposedly uses a rather

CVS commit: src/sys/dev/scsipi

2019-09-18 Thread SAITOH Masanobu
Module Name:src Committed By: msaitoh Date: Thu Sep 19 03:37:31 UTC 2019 Modified Files: src/sys/dev/scsipi: scsipi_base.c Log Message: Use unsigned to avoid undefined behavior in scsipi_{get,put}_tag(). Found by kUBSan. To generate a diff of this commit: cvs rdiff -u

CVS commit: src/sys/dev/scsipi

2019-09-18 Thread SAITOH Masanobu
Module Name:src Committed By: msaitoh Date: Thu Sep 19 03:37:31 UTC 2019 Modified Files: src/sys/dev/scsipi: scsipi_base.c Log Message: Use unsigned to avoid undefined behavior in scsipi_{get,put}_tag(). Found by kUBSan. To generate a diff of this commit: cvs rdiff -u

CVS commit: src/sys/dev/scsipi

2019-05-30 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Thu May 30 16:57:39 UTC 2019 Modified Files: src/sys/dev/scsipi: scsipi_ioctl.c Log Message: use correct size when copying outgoing sense data. To generate a diff of this commit: cvs rdiff -u -r1.71 -r1.72

CVS commit: src/sys/dev/scsipi

2019-05-30 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Thu May 30 16:57:39 UTC 2019 Modified Files: src/sys/dev/scsipi: scsipi_ioctl.c Log Message: use correct size when copying outgoing sense data. To generate a diff of this commit: cvs rdiff -u -r1.71 -r1.72

CVS commit: src/sys/dev/scsipi

2019-05-26 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Sun May 26 08:12:41 UTC 2019 Modified Files: src/sys/dev/scsipi: scsipi_ioctl.c Log Message: Add sanity checks to SCIOCCOMMAND, adapter drivers might be confused or trigger assertions (e.g. umass). To generate a diff of this

CVS commit: src/sys/dev/scsipi

2019-05-26 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Sun May 26 08:12:41 UTC 2019 Modified Files: src/sys/dev/scsipi: scsipi_ioctl.c Log Message: Add sanity checks to SCIOCCOMMAND, adapter drivers might be confused or trigger assertions (e.g. umass). To generate a diff of this

CVS commit: src/sys/dev/scsipi

2019-05-19 Thread Frank Kardel
Module Name:src Committed By: kardel Date: Sun May 19 19:06:53 UTC 2019 Modified Files: src/sys/dev/scsipi: st.c Log Message: Add simple position recovery when positioning to EOM by reading the position with READ_POSITION. this allows for mt eom mt st to

Re: CVS commit: src/sys/dev/scsipi

2018-03-24 Thread Kamil Rytarowski
On 24.03.2018 16:47, Martin Husemann wrote: > On Sat, Mar 24, 2018 at 09:38:15AM +0100, Thomas Klausner wrote: >> On Sat, Mar 24, 2018 at 09:06:25AM +0100, Michael van Elst wrote: >>> On Sat, Mar 24, 2018 at 02:50:05AM +0100, Kamil Rytarowski wrote: >>> I had to revert this in order to

Re: CVS commit: src/sys/dev/scsipi

2018-03-24 Thread Martin Husemann
On Sat, Mar 24, 2018 at 09:38:15AM +0100, Thomas Klausner wrote: > On Sat, Mar 24, 2018 at 09:06:25AM +0100, Michael van Elst wrote: > > On Sat, Mar 24, 2018 at 02:50:05AM +0100, Kamil Rytarowski wrote: > > > > > I had to revert this in order to unbreak build. > > > > > > Please never do that.

Re: CVS commit: src/sys/dev/scsipi

2018-03-24 Thread Thomas Klausner
On Sat, Mar 24, 2018 at 09:06:25AM +0100, Michael van Elst wrote: > On Sat, Mar 24, 2018 at 02:50:05AM +0100, Kamil Rytarowski wrote: > > > I had to revert this in order to unbreak build. > > > Please never do that. I think it's appropriate if it's a small patch that breaks the build and can

Re: CVS commit: src/sys/dev/scsipi

2018-03-24 Thread Michael van Elst
On Sat, Mar 24, 2018 at 02:50:05AM +0100, Kamil Rytarowski wrote: > I had to revert this in order to unbreak build. Please never do that. -- Michael van Elst Internet: mlel...@serpens.de "A potential Snark may lurk in every

Re: CVS commit: src/sys/dev/scsipi

2018-03-23 Thread Robert Elz
Date:Sat, 24 Mar 2018 02:50:05 +0100 From:Kamil Rytarowski Message-ID: <8b2f90cf-0c7f-1154-b3fb-c4c600d07...@gmx.com> | > To generate a diff of this commit: | > cvs rdiff -u -r1.231 -r1.232 src/sys/dev/scsipi/st.c | | I had to revert this in

Re: CVS commit: src/sys/dev/scsipi

2018-03-23 Thread Kamil Rytarowski
On 23.03.2018 07:01, Michael van Elst wrote: > Module Name: src > Committed By: mlelstv > Date: Fri Mar 23 06:01:07 UTC 2018 > > Modified Files: > src/sys/dev/scsipi: st.c > > Log Message: > Use separate lock to protect internal state and release locks when > calling biodone. > >

Re: CVS commit: src/sys/dev/scsipi

2017-06-18 Thread Kengo NAKAHARA
Hi, Today, I found my environment panic while rebooting. As bisecting, it seems the cause is below commit. On 2017/06/18 7:35, Michael van Elst wrote: > Module Name: src > Committed By: mlelstv > Date: Sat Jun 17 22:35:50 UTC 2017 > > Modified Files: > src/sys/dev/scsipi:

Re: CVS commit: src/sys/dev/scsipi

2017-04-11 Thread Martin Husemann
On Tue, Apr 11, 2017 at 02:13:42AM +, Christos Zoulas wrote: > Can't we fix this a different way? What's the problem? The log description might have been confusing. It just makes no sense to try to autoload any module while / is not yet available. It may make sense to move the check for this

Re: CVS commit: src/sys/dev/scsipi

2017-04-10 Thread Christos Zoulas
In article <20170410215338.12a45f...@cvs.netbsd.org>, Jaromir Dolecek wrote: >-=-=-=-=-=- > >just do not autoload scsiverbose module, it causes deadlock if it happens >while root fs is being mounted > >adresses second part of PR kern/52147 by Michael van Elst, thank

Re: CVS commit: src/sys/dev/scsipi

2013-08-10 Thread Frank Kardel
Hi Erik ! I agree that 5 minutes is a really long time. Actually the inventory command will wait even longer (5 min per element + 10 minutes as safeguard - I didn't change that). Generating a uprintf would mean to manage a separate callout and using, I believe, the tprintf() call from the

Re: CVS commit: src/sys/dev/scsipi

2013-08-10 Thread Frank Kardel
Erik, I agree with this very much. Actually I have been toying around with this idea quite some time. My thoughts where to build a sysctl tree for all scsi commands with their default values and another level of sysctl timeout nodes where the vendor and device name or driver name is part of

Re: CVS commit: src/sys/dev/scsipi

2013-08-09 Thread Erik Fair
On Aug 9, 2013, at 12:58 , Frank Kardel kar...@netbsd.org wrote: Module Name: src Committed By: kardel Date: Fri Aug 9 19:58:44 UTC 2013 Modified Files: src/sys/dev/scsipi: ch.c Log Message: bump command timeout to 5 minutes. several types of changers (Overland

Re: CVS commit: src/sys/dev/scsipi

2013-08-09 Thread Erik Fair
On Aug 9, 2013, at 12:58 , Frank Kardel kar...@netbsd.org wrote: Module Name: src Committed By: kardel Date: Fri Aug 9 19:58:44 UTC 2013 Modified Files: src/sys/dev/scsipi: ch.c Log Message: bump command timeout to 5 minutes. several types of changers (Overland

Re: CVS commit: src/sys/dev/scsipi

2012-04-20 Thread Manuel Bouyer
On Thu, Apr 19, 2012 at 06:39:29PM -0600, Warner Losh wrote: FreeBSD started out with MPSAFE and then went to NEEDS_GIANT as flags for the drivers. I'm with Matthew: patch the drivers that are broken (or not known to be safe) and then you have a convenient thing to grep for when you want to

Re: CVS commit: src/sys/dev/scsipi

2012-04-20 Thread David Holland
On Fri, Apr 20, 2012 at 09:37:00AM +0200, Manuel Bouyer wrote: we've never had autoconfig run with the kernel lock AFAICT, so this assumption has never been true. So this is a bug. The contract was really that spl-locked drivers would continue to work as is when fine-grained locking

Re: CVS commit: src/sys/dev/scsipi

2012-04-20 Thread Manuel Bouyer
On Fri, Apr 20, 2012 at 07:46:35AM +, David Holland wrote: On Fri, Apr 20, 2012 at 09:37:00AM +0200, Manuel Bouyer wrote: we've never had autoconfig run with the kernel lock AFAICT, so this assumption has never been true. So this is a bug. The contract was really that

Re: CVS commit: src/sys/dev/scsipi

2012-04-20 Thread Manuel Bouyer
On Fri, Apr 20, 2012 at 06:06:35PM +1000, matthew green wrote: we've never had autoconfig run with the kernel lock AFAICT, so this assumption has never been true. So this is a bug. The contract was really that spl-locked drivers would continue to work as is when fine-grained locking

re: CVS commit: src/sys/dev/scsipi

2012-04-19 Thread matthew green
Module Name: src Committed By: bouyer Date: Wed Apr 18 20:37:49 UTC 2012 Modified Files: src/sys/dev/scsipi: scsipi_base.c Log Message: Fix KASSERT(): autoconf doesn't run under the KERNEL_LOCK this is true, but can you please fix it differently? ie autoconf isn't

Re: CVS commit: src/sys/dev/scsipi

2012-04-19 Thread Manuel Bouyer
On Thu, Apr 19, 2012 at 04:41:04PM +1000, matthew green wrote: Module Name:src Committed By: bouyer Date: Wed Apr 18 20:37:49 UTC 2012 Modified Files: src/sys/dev/scsipi: scsipi_base.c Log Message: Fix KASSERT(): autoconf doesn't run under the

re: CVS commit: src/sys/dev/scsipi

2012-04-19 Thread matthew green
Module Name: src Committed By: bouyer Date: Wed Apr 18 20:37:49 UTC 2012 Modified Files: src/sys/dev/scsipi: scsipi_base.c Log Message: Fix KASSERT(): autoconf doesn't run under the KERNEL_LOCK this is true, but can you please fix it

Re: CVS commit: src/sys/dev/scsipi

2012-04-19 Thread Manuel Bouyer
On Thu, Apr 19, 2012 at 06:25:54PM +1000, matthew green wrote: [...] If the driver's attach is called after cold (e.g. after a detach/rescan of the pci bus), the driver's attach should be called with KERNEL_LOCK held, or bad things may happen when interrupts are enabled for this driver.

re: CVS commit: src/sys/dev/scsipi

2012-04-19 Thread matthew green
If the driver's attach is called after cold (e.g. after a detach/rescan of the pci bus), the driver's attach should be called with KERNEL_LOCK held, or bad things may happen when interrupts are enabled for this driver. there should be no reliance on cold being set for normal

Re: CVS commit: src/sys/dev/scsipi

2012-04-19 Thread Manuel Bouyer
On Thu, Apr 19, 2012 at 07:00:56PM +1000, matthew green wrote: If the driver's attach is called after cold (e.g. after a detach/rescan of the pci bus), the driver's attach should be called with KERNEL_LOCK held, or bad things may happen when interrupts are enabled for this

re: CVS commit: src/sys/dev/scsipi

2012-04-19 Thread matthew green
scsipi depends upon kernel lock. thus, callers should arrange for it to be held. since these are drivers calling, it is upto each driver to do this currently. this is what we've done with other problems we have hit as they've arrived. if the caller is MPSAFE, I agree. Non-MPSAFE

Re: CVS commit: src/sys/dev/scsipi

2012-04-19 Thread Warner Losh
On Apr 19, 2012, at 6:03 PM, matthew green wrote: But that's a problem with autoconf not dealing with non-MPSAFE drivers, not the driver themselve (they were working before the MP changes, they should continue to work as-is). If you want autoconf to not run under the KERNEL_LOCK when not

Re: CVS commit: src/sys/dev/scsipi

2011-04-25 Thread David Young
On Mon, Apr 25, 2011 at 02:14:23PM +, Juergen Hannken-Illjes wrote: Module Name: src Committed By: hannken Date: Mon Apr 25 14:14:22 UTC 2011 Modified Files: src/sys/dev/scsipi: scsiconf.c Log Message: Don't kill outstanding requests when detaching a scsibus on

Re: CVS commit: src/sys/dev/scsipi

2011-04-25 Thread Juergen Hannken-Illjes
On Mon, Apr 25, 2011 at 10:33:14AM -0500, David Young wrote: On Mon, Apr 25, 2011 at 02:14:23PM +, Juergen Hannken-Illjes wrote: Module Name:src Committed By: hannken Date: Mon Apr 25 14:14:22 UTC 2011 Modified Files: src/sys/dev/scsipi: scsiconf.c

Re: CVS commit: src/sys/dev/scsipi

2011-04-25 Thread David Young
On Mon, Apr 25, 2011 at 06:26:09PM +0200, Juergen Hannken-Illjes wrote: On Mon, Apr 25, 2011 at 10:33:14AM -0500, David Young wrote: On Mon, Apr 25, 2011 at 02:14:23PM +, Juergen Hannken-Illjes wrote: Module Name: src Committed By: hannken Date: Mon Apr 25

CVS commit: src/sys/dev/scsipi

2010-02-12 Thread Antti Kantee
Module Name:src Committed By: pooka Date: Fri Feb 12 11:39:33 UTC 2010 Modified Files: src/sys/dev/scsipi: scsipi_base.c Log Message: delay() is used here, so need to include machine/param.h. To generate a diff of this commit: cvs rdiff -u -r1.150 -r1.151

CVS commit: src/sys/dev/scsipi

2010-02-06 Thread Christoph Egger
Module Name:src Committed By: cegger Date: Sat Feb 6 23:13:59 UTC 2010 Modified Files: src/sys/dev/scsipi: scsi_spc.h Log Message: scsi_sense_data: add comments taken from src/sys/dev/ieee1394/sbp.h To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.5

Re: CVS commit: src/sys/dev/scsipi

2009-08-15 Thread Paul Goyette
On Sat, 15 Aug 2009, David Laight wrote: On Sat, Aug 15, 2009 at 12:44:55PM +, Paul Goyette wrote: 2. Replace a numeric constant with some sizeof's when calculating the size of the mode_select command buffer, clear the entire buffer, and KASSERT to ensure the page_0_size loaded from

Re: CVS commit: src/sys/dev/scsipi

2009-05-13 Thread Christos Zoulas
On May 13, 7:56am, christoph_eg...@gmx.de (Christoph Egger) wrote: -- Subject: Re: CVS commit: src/sys/dev/scsipi | Christos Zoulas wrote: | Module Name:src | Committed By: christos | Date: Wed May 13 02:35:25 UTC 2009 | | Modified Files: | src/sys/dev