CVS commit: src/sys/dev/sdmmc

2019-10-28 Thread Joerg Sonnenberger
Module Name:src Committed By: joerg Date: Mon Oct 28 18:11:16 UTC 2019 Modified Files: src/sys/dev/sdmmc: sdhc.c Log Message: Avoid warnings for tautological shifts as sole conditional. To generate a diff of this commit: cvs rdiff -u -r1.105 -r1.106

CVS commit: src/sys/dev/sdmmc

2019-10-28 Thread Joerg Sonnenberger
Module Name:src Committed By: joerg Date: Mon Oct 28 18:11:16 UTC 2019 Modified Files: src/sys/dev/sdmmc: sdhc.c Log Message: Avoid warnings for tautological shifts as sole conditional. To generate a diff of this commit: cvs rdiff -u -r1.105 -r1.106

CVS commit: src/sys/dev/sdmmc

2019-10-28 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Mon Oct 28 06:31:39 UTC 2019 Modified Files: src/sys/dev/sdmmc: ld_sdmmc.c sdmmc_cis.c sdmmc_mem.c sdmmcdevs Log Message: Whitespace police To generate a diff of this commit: cvs rdiff -u -r1.36 -r1.37

CVS commit: src/sys/dev/sdmmc

2019-10-28 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Mon Oct 28 06:32:11 UTC 2019 Modified Files: src/sys/dev/sdmmc: sdmmcdevs.h Log Message: regen To generate a diff of this commit: cvs rdiff -u -r1.6 -r1.7 src/sys/dev/sdmmc/sdmmcdevs.h Please note that diffs are not public

CVS commit: src/sys/dev/sdmmc

2019-10-28 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Mon Oct 28 06:31:39 UTC 2019 Modified Files: src/sys/dev/sdmmc: ld_sdmmc.c sdmmc_cis.c sdmmc_mem.c sdmmcdevs Log Message: Whitespace police To generate a diff of this commit: cvs rdiff -u -r1.36 -r1.37

CVS commit: src/sys/dev/sdmmc

2019-10-28 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Mon Oct 28 06:32:11 UTC 2019 Modified Files: src/sys/dev/sdmmc: sdmmcdevs.h Log Message: regen To generate a diff of this commit: cvs rdiff -u -r1.6 -r1.7 src/sys/dev/sdmmc/sdmmcdevs.h Please note that diffs are not public

CVS commit: src/sys/dev/sdmmc

2019-10-28 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Mon Oct 28 06:26:19 UTC 2019 Modified Files: src/sys/dev/sdmmc: sdmmc_ioreg.h Log Message: Missing commit for sdio abort function. To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.5 src/sys/dev/sdmmc/sdmmc_ioreg.h

CVS commit: src/sys/dev/sdmmc

2019-10-28 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Mon Oct 28 06:26:19 UTC 2019 Modified Files: src/sys/dev/sdmmc: sdmmc_ioreg.h Log Message: Missing commit for sdio abort function. To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.5 src/sys/dev/sdmmc/sdmmc_ioreg.h

CVS commit: src/sys/dev/sdmmc

2019-10-28 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Mon Oct 28 06:20:01 UTC 2019 Modified Files: src/sys/dev/sdmmc: if_bwfm_sdio.c sdmmc_io.c sdmmcvar.h Log Message: Simplyfy sdmmc_io_set_blocklen function signature by dropping the extra softc pointer. Aligns with OpenBSD. To

CVS commit: src/sys/dev/sdmmc

2019-10-28 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Mon Oct 28 06:20:01 UTC 2019 Modified Files: src/sys/dev/sdmmc: if_bwfm_sdio.c sdmmc_io.c sdmmcvar.h Log Message: Simplyfy sdmmc_io_set_blocklen function signature by dropping the extra softc pointer. Aligns with OpenBSD. To

CVS commit: src/sys/dev/sdmmc

2019-10-28 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Mon Oct 28 06:16:46 UTC 2019 Modified Files: src/sys/dev/sdmmc: sdmmc.c sdmmc_io.c sdmmc_mem.c sdmmcvar.h Log Message: Add and use sdmmc_pause to avoid long-term busy waits. Add sdio abort function. Additional error messages.

CVS commit: src/sys/dev/sdmmc

2019-10-28 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Mon Oct 28 06:16:46 UTC 2019 Modified Files: src/sys/dev/sdmmc: sdmmc.c sdmmc_io.c sdmmc_mem.c sdmmcvar.h Log Message: Add and use sdmmc_pause to avoid long-term busy waits. Add sdio abort function. Additional error messages.

CVS commit: src/sys/dev/sdmmc

2019-10-28 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Mon Oct 28 06:00:14 UTC 2019 Modified Files: src/sys/dev/sdmmc: sdhc.c Log Message: Skip setting power when the voltage doesn't change. Also increase some timeouts. To generate a diff of this commit: cvs rdiff -u -r1.104

CVS commit: src/sys/dev/sdmmc

2019-10-28 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Mon Oct 28 06:00:14 UTC 2019 Modified Files: src/sys/dev/sdmmc: sdhc.c Log Message: Skip setting power when the voltage doesn't change. Also increase some timeouts. To generate a diff of this commit: cvs rdiff -u -r1.104

CVS commit: src/sys/dev/sdmmc

2019-10-27 Thread Christoph Badura
Module Name:src Committed By: bad Date: Sun Oct 27 21:39:50 UTC 2019 Modified Files: src/sys/dev/sdmmc: if_bwfm_sdio.c Log Message: white space police. To generate a diff of this commit: cvs rdiff -u -r1.6 -r1.7 src/sys/dev/sdmmc/if_bwfm_sdio.c Please note that diffs

CVS commit: src/sys/dev/sdmmc

2019-10-27 Thread Christoph Badura
Module Name:src Committed By: bad Date: Sun Oct 27 21:39:50 UTC 2019 Modified Files: src/sys/dev/sdmmc: if_bwfm_sdio.c Log Message: white space police. To generate a diff of this commit: cvs rdiff -u -r1.6 -r1.7 src/sys/dev/sdmmc/if_bwfm_sdio.c Please note that diffs

CVS commit: src/sys/dev/sdmmc

2019-10-03 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Thu Oct 3 10:53:34 UTC 2019 Modified Files: src/sys/dev/sdmmc: if_bwfm_sdio.h Log Message: More register definitions. To generate a diff of this commit: cvs rdiff -u -r1.1 -r1.2 src/sys/dev/sdmmc/if_bwfm_sdio.h Please note

CVS commit: src/sys/dev/sdmmc

2019-10-03 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Thu Oct 3 10:53:34 UTC 2019 Modified Files: src/sys/dev/sdmmc: if_bwfm_sdio.h Log Message: More register definitions. To generate a diff of this commit: cvs rdiff -u -r1.1 -r1.2 src/sys/dev/sdmmc/if_bwfm_sdio.h Please note

CVS commit: src/sys/dev/sdmmc

2019-09-25 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Wed Sep 25 16:21:14 UTC 2019 Modified Files: src/sys/dev/sdmmc: if_bwfm_sdio.c Log Message: Use correct function to verify if a task has been queued. Avoids race that can corrupt the task queue. To generate a diff of this

CVS commit: src/sys/dev/sdmmc

2019-09-25 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Wed Sep 25 16:21:14 UTC 2019 Modified Files: src/sys/dev/sdmmc: if_bwfm_sdio.c Log Message: Use correct function to verify if a task has been queued. Avoids race that can corrupt the task queue. To generate a diff of this

CVS commit: src/sys/dev/sdmmc

2019-09-23 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Tue Sep 24 04:56:54 UTC 2019 Modified Files: src/sys/dev/sdmmc: sdmmc_cis.c Log Message: Remove debug printf. To generate a diff of this commit: cvs rdiff -u -r1.6 -r1.7 src/sys/dev/sdmmc/sdmmc_cis.c Please note that diffs

CVS commit: src/sys/dev/sdmmc

2019-09-23 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Tue Sep 24 04:56:54 UTC 2019 Modified Files: src/sys/dev/sdmmc: sdmmc_cis.c Log Message: Remove debug printf. To generate a diff of this commit: cvs rdiff -u -r1.6 -r1.7 src/sys/dev/sdmmc/sdmmc_cis.c Please note that diffs

CVS commit: src/sys/dev/sdmmc

2019-09-13 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Fri Sep 13 11:21:03 UTC 2019 Modified Files: src/sys/dev/sdmmc: if_bwfm_sdio.c Log Message: Don't pass empty mbufs to the network stack. To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.5

CVS commit: src/sys/dev/sdmmc

2019-09-13 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Fri Sep 13 11:21:03 UTC 2019 Modified Files: src/sys/dev/sdmmc: if_bwfm_sdio.c Log Message: Don't pass empty mbufs to the network stack. To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.5

CVS commit: src/sys/dev/sdmmc

2019-09-02 Thread Jared D. McNeill
Module Name:src Committed By: jmcneill Date: Mon Sep 2 11:09:42 UTC 2019 Modified Files: src/sys/dev/sdmmc: sdmmc_io.c Log Message: SD_IO_RW_EXTENDED is a data transfer command, so set ADTC flag instead of AC To generate a diff of this commit: cvs rdiff -u -r1.15

CVS commit: src/sys/dev/sdmmc

2019-09-02 Thread Jared D. McNeill
Module Name:src Committed By: jmcneill Date: Mon Sep 2 11:09:42 UTC 2019 Modified Files: src/sys/dev/sdmmc: sdmmc_io.c Log Message: SD_IO_RW_EXTENDED is a data transfer command, so set ADTC flag instead of AC To generate a diff of this commit: cvs rdiff -u -r1.15

CVS commit: src/sys/dev/sdmmc

2019-08-31 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Sun Sep 1 05:51:45 UTC 2019 Modified Files: src/sys/dev/sdmmc: if_bwfm_sdio.c Added Files: src/sys/dev/sdmmc: if_bwfm_sdio.h Log Message: >From OpenBSD: - All the missing pieces (firmware load, chip setup, protocol

CVS commit: src/sys/dev/sdmmc

2019-08-31 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Sun Sep 1 05:51:45 UTC 2019 Modified Files: src/sys/dev/sdmmc: if_bwfm_sdio.c Added Files: src/sys/dev/sdmmc: if_bwfm_sdio.h Log Message: >From OpenBSD: - All the missing pieces (firmware load, chip setup, protocol

CVS commit: src/sys/dev/sdmmc

2019-08-31 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Sun Sep 1 05:45:42 UTC 2019 Modified Files: src/sys/dev/sdmmc: sdmmc.c sdmmc_cis.c sdmmc_io.c sdmmc_ioreg.h sdmmcvar.h Log Message: >From OpenBSD: - support block length per function - add functions to read/write

CVS commit: src/sys/dev/sdmmc

2019-08-31 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Sun Sep 1 05:45:42 UTC 2019 Modified Files: src/sys/dev/sdmmc: sdmmc.c sdmmc_cis.c sdmmc_io.c sdmmc_ioreg.h sdmmcvar.h Log Message: >From OpenBSD: - support block length per function - add functions to read/write

CVS commit: src/sys/dev/sdmmc

2019-08-24 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Sat Aug 24 11:24:17 UTC 2019 Modified Files: src/sys/dev/sdmmc: sdmmcdevs.h Log Message: regen To generate a diff of this commit: cvs rdiff -u -r1.5 -r1.6 src/sys/dev/sdmmc/sdmmcdevs.h Please note that diffs are not public

CVS commit: src/sys/dev/sdmmc

2019-08-24 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Sat Aug 24 11:24:17 UTC 2019 Modified Files: src/sys/dev/sdmmc: sdmmcdevs.h Log Message: regen To generate a diff of this commit: cvs rdiff -u -r1.5 -r1.6 src/sys/dev/sdmmc/sdmmcdevs.h Please note that diffs are not public

CVS commit: src/sys/dev/sdmmc

2019-08-24 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Sat Aug 24 11:24:00 UTC 2019 Modified Files: src/sys/dev/sdmmc: sdmmcdevs Log Message: Fix typo To generate a diff of this commit: cvs rdiff -u -r1.5 -r1.6 src/sys/dev/sdmmc/sdmmcdevs Please note that diffs are not public

CVS commit: src/sys/dev/sdmmc

2019-08-24 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Sat Aug 24 11:24:00 UTC 2019 Modified Files: src/sys/dev/sdmmc: sdmmcdevs Log Message: Fix typo To generate a diff of this commit: cvs rdiff -u -r1.5 -r1.6 src/sys/dev/sdmmc/sdmmcdevs Please note that diffs are not public

CVS commit: src/sys/dev/sdmmc

2019-08-18 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Sun Aug 18 14:32:05 UTC 2019 Modified Files: src/sys/dev/sdmmc: sdmmcdevs Log Message: Add Broadcom devices To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.5 src/sys/dev/sdmmc/sdmmcdevs Please note that diffs are

CVS commit: src/sys/dev/sdmmc

2019-08-18 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Sun Aug 18 14:32:05 UTC 2019 Modified Files: src/sys/dev/sdmmc: sdmmcdevs Log Message: Add Broadcom devices To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.5 src/sys/dev/sdmmc/sdmmcdevs Please note that diffs are

CVS commit: src/sys/dev/sdmmc

2019-08-18 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Sun Aug 18 14:32:34 UTC 2019 Modified Files: src/sys/dev/sdmmc: sdmmcdevs.h Log Message: regen To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.5 src/sys/dev/sdmmc/sdmmcdevs.h Please note that diffs are not public

CVS commit: src/sys/dev/sdmmc

2019-08-18 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Sun Aug 18 14:32:34 UTC 2019 Modified Files: src/sys/dev/sdmmc: sdmmcdevs.h Log Message: regen To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.5 src/sys/dev/sdmmc/sdmmcdevs.h Please note that diffs are not public

Re: CVS commit: src/sys/dev/sdmmc

2019-07-24 Thread Nick Hudson
On 24/07/2019 06:45, SAITOH Masanobu wrote: [snip] @@ -27,7 +27,7 @@ /* CMD52 arguments */ #define SD_ARG_CMD52_READ (0<<31) -#define SD_ARG_CMD52_WRITE (1<<31) +#define SD_ARG_CMD52_WRITE (1UL<<31) #define SD_ARG_CMD52_FUNC_SHIFT 28

CVS commit: src/sys/dev/sdmmc

2019-07-23 Thread SAITOH Masanobu
Module Name:src Committed By: msaitoh Date: Wed Jul 24 05:45:42 UTC 2019 Modified Files: src/sys/dev/sdmmc: sdmmc_ioreg.h Log Message: Define SD_ARG_CMD52_WRITE macro correctly. Found by KUBSan. This macro is used in sdmmc_io_write_1() and sdmmc_io_reset. To generate a

CVS commit: src/sys/dev/sdmmc

2019-07-23 Thread SAITOH Masanobu
Module Name:src Committed By: msaitoh Date: Wed Jul 24 05:45:42 UTC 2019 Modified Files: src/sys/dev/sdmmc: sdmmc_ioreg.h Log Message: Define SD_ARG_CMD52_WRITE macro correctly. Found by KUBSan. This macro is used in sdmmc_io_write_1() and sdmmc_io_reset. To generate a

CVS commit: src/sys/dev/sdmmc

2019-07-03 Thread Jared D. McNeill
Module Name:src Committed By: jmcneill Date: Wed Jul 3 23:10:08 UTC 2019 Modified Files: src/sys/dev/sdmmc: sdhc.c Log Message: If switching to fixed sampling clock, do not return an error to the sdmmc layer. To generate a diff of this commit: cvs rdiff -u -r1.102

CVS commit: src/sys/dev/sdmmc

2019-07-03 Thread Jared D. McNeill
Module Name:src Committed By: jmcneill Date: Wed Jul 3 23:10:08 UTC 2019 Modified Files: src/sys/dev/sdmmc: sdhc.c Log Message: If switching to fixed sampling clock, do not return an error to the sdmmc layer. To generate a diff of this commit: cvs rdiff -u -r1.102

CVS commit: src/sys/dev/sdmmc

2019-06-06 Thread Jared D. McNeill
Module Name:src Committed By: jmcneill Date: Thu Jun 6 20:50:46 UTC 2019 Modified Files: src/sys/dev/sdmmc: sdmmc_mem.c Log Message: If setting HS_TIMING fails, keep trying slower speeds instead of bailing out. To generate a diff of this commit: cvs rdiff -u -r1.67

CVS commit: src/sys/dev/sdmmc

2019-06-06 Thread Jared D. McNeill
Module Name:src Committed By: jmcneill Date: Thu Jun 6 20:50:46 UTC 2019 Modified Files: src/sys/dev/sdmmc: sdmmc_mem.c Log Message: If setting HS_TIMING fails, keep trying slower speeds instead of bailing out. To generate a diff of this commit: cvs rdiff -u -r1.67

CVS commit: src/sys/dev/sdmmc

2019-05-27 Thread Jared D. McNeill
Module Name:src Committed By: jmcneill Date: Tue May 28 00:25:27 UTC 2019 Modified Files: src/sys/dev/sdmmc: sdmmc_mem.c Log Message: If a mem function fails to initialize, set the error flag so sdmmc doesn't try to use it anyway. To generate a diff of this commit: cvs

CVS commit: src/sys/dev/sdmmc

2019-05-27 Thread Jared D. McNeill
Module Name:src Committed By: jmcneill Date: Tue May 28 00:25:27 UTC 2019 Modified Files: src/sys/dev/sdmmc: sdmmc_mem.c Log Message: If a mem function fails to initialize, set the error flag so sdmmc doesn't try to use it anyway. To generate a diff of this commit: cvs

Re: CVS commit: src/sys/dev/sdmmc

2017-11-08 Thread Pierre Pronchery
Hi Jared, On 07/11/2017 18:01, Jared McNeill wrote: > Could have saved yourself a lot of time if you had emailed me first, > I've been sitting on this code since I ported bwfm but didn't commit it > as the original code doesn't actually work. Do you plan on finishing it?

Re: CVS commit: src/sys/dev/sdmmc

2017-11-07 Thread Jared McNeill
On Wed, 8 Nov 2017, Pierre Pronchery wrote: Sorry, I could not guess that, and I currently do not have reliable Internet at home so I often have to work on this offline. I got this part to build, thought this was a net positive and decided to commit it so it can benefit others too. You are

Re: CVS commit: src/sys/dev/sdmmc

2017-11-07 Thread Jared McNeill
Could have saved yourself a lot of time if you had emailed me first, I've been sitting on this code since I ported bwfm but didn't commit it as the original code doesn't actually work. Do you plan on finishing it? On Tue, 7 Nov 2017, Pierre Pronchery wrote: Module Name:src Committed By:

Re: CVS commit: src/sys/dev/sdmmc

2017-07-17 Thread Jared McNeill
Thank you, I will see if I can make some progress in this area. One of my sunxi boards has DDR52-capable eMMC. On Mon, 17 Jul 2017, Kimihiro Nonaka wrote: I remember that it was not working yet. 2017-07-17 3:36 GMT+09:00 Jared McNeill : Does the DDR52 code work? I

Re: CVS commit: src/sys/dev/sdmmc

2017-07-17 Thread Kimihiro Nonaka
I remember that it was not working yet. 2017-07-17 3:36 GMT+09:00 Jared McNeill : > Does the DDR52 code work? I don't see sdhc setting SMC_CAPS_MMC_DDR52 > anywhere.. > > > > On Fri, 17 Feb 2017, NONAKA Kimihiro wrote: > >> Module Name:src >> Committed By: nonaka >>

Re: CVS commit: src/sys/dev/sdmmc

2017-07-16 Thread Jared McNeill
Does the DDR52 code work? I don't see sdhc setting SMC_CAPS_MMC_DDR52 anywhere.. On Fri, 17 Feb 2017, NONAKA Kimihiro wrote: Module Name:src Committed By: nonaka Date: Fri Feb 17 10:50:43 UTC 2017 Modified Files: src/sys/dev/sdmmc: sdhc.c sdmmc_mem.c sdmmcchip.h

KTHREAD_MPSAFE [was Re: CVS commit: src/sys/dev/sdmmc]

2017-07-09 Thread Nick Hudson
On 07/08/17 19:38, Jared D. McNeill wrote: Module Name:src Committed By: jmcneill Date: Sat Jul 8 18:38:57 UTC 2017 Modified Files: src/sys/dev/sdmmc: ld_sdmmc.c Log Message: The config_* APIs are not MPSAFE, so make sure the deferred attach thread holds KERNEL_LOCK.

Re: CVS commit: src/sys/dev/sdmmc

2016-07-04 Thread KIYOHARA Takashi
Hi! From: Nick Hudson Date: Mon, 4 Jul 2016 20:34:15 +0100 > On 07/03/16 13:12, KIYOHARA Takashi wrote: >> Hi! >> >> From: Nick Hudson >> Date: Sun, 3 Jul 2016 12:58:58 +0100 >> >>> On 07/03/16 12:55, KIYOHARA Takashi wrote: Module Name: src

Re: CVS commit: src/sys/dev/sdmmc

2016-07-04 Thread Nick Hudson
On 07/03/16 13:12, KIYOHARA Takashi wrote: Hi! From: Nick Hudson Date: Sun, 3 Jul 2016 12:58:58 +0100 On 07/03/16 12:55, KIYOHARA Takashi wrote: Module Name:src Committed By: kiyohara Date: Sun Jul 3 11:55:27 UTC 2016 Modified Files:

Re: CVS commit: src/sys/dev/sdmmc

2016-07-03 Thread KIYOHARA Takashi
Hi! From: Nick Hudson Date: Sun, 3 Jul 2016 12:58:58 +0100 > On 07/03/16 12:55, KIYOHARA Takashi wrote: >> Module Name: src >> Committed By:kiyohara >> Date:Sun Jul 3 11:55:27 UTC 2016 >> >> Modified Files: >> src/sys/dev/sdmmc: sdhc.c >> >> Log

Re: CVS commit: src/sys/dev/sdmmc

2016-07-03 Thread Nick Hudson
On 07/03/16 12:55, KIYOHARA Takashi wrote: Module Name:src Committed By: kiyohara Date: Sun Jul 3 11:55:27 UTC 2016 Modified Files: src/sys/dev/sdmmc: sdhc.c Log Message: Please more delay, if timeout in sdhc_wait_intr(). err, why? Nick

Re: CVS commit: src/sys/dev/sdmmc

2012-07-17 Thread Greg Troxel
Modified Files: src/sys/dev/sdmmc: sdhc.c Log Message: Handle interrupt acknowledgement in the SDHC_FLAG_32BIT_ACCESS case in the same way as non-SDHC_FLAG_32BIT_ACCESS case. To generate a diff of this commit: cvs rdiff -u -r1.20 -r1.21 src/sys/dev/sdmmc/sdhc.c Two

Re: CVS commit: src/sys/dev/sdmmc

2012-07-17 Thread Matt Thomas
On Jul 17, 2012, at 5:39 AM, Greg Troxel wrote: Modified Files: src/sys/dev/sdmmc: sdhc.c Log Message: Handle interrupt acknowledgement in the SDHC_FLAG_32BIT_ACCESS case in the same way as non-SDHC_FLAG_32BIT_ACCESS case. To generate a diff of this commit: cvs rdiff

Re: CVS commit: src/sys/dev/sdmmc

2012-07-17 Thread Greg Troxel
On Jul 17, 2012, at 0925 , Matt Thomas wrote: On Jul 17, 2012, at 5:39 AM, Greg Troxel wrote: 0x30 is aligned and that is the address that is read from a 32-bit access. Not enough coffee - I was reading hex as decimal :-) In the non-32 case, it seems that the EINTR register is read

Re: CVS commit: src/sys/dev/sdmmc

2012-07-17 Thread Matt Thomas
On Jul 17, 2012, at 7:08 AM, Greg Troxel wrote: So the 4-byte read causes the SDHC_ERROR_INTERRUPT not to get set because the same read reads EINTR_STATUS, or the chip that's in systems that need 4-byte reads is different (ESDHC vs SDHC?)? The chip does not implement SDHC_ERROR_INTERRUPT.

Re: CVS commit: src/sys/dev/sdmmc

2012-07-17 Thread Greg Troxel
it seems odd to have bits set in SDHC_EINTR_STATUS without SDHC_ERROR_INTERRUPT set in SDHC_NINTR_STATUS, and the two code paths seem different still This is because the ESDHC doesn't set SDHC_ERROR_INTERRUPT in its register since you've read SDHC_EINTR_STATUS and can see those

Re: CVS commit: src/sys/dev/sdmmc

2010-09-21 Thread Valeriy E. Ushakov
On Tue, Sep 21, 2010 at 04:57:44 +, KIYOHARA Takashi wrote: Module Name: src Committed By: kiyohara Date: Tue Sep 21 04:57:44 UTC 2010 Modified Files: src/sys/dev/sdmmc: sdmmcvar.h Log Message: + Add macro SMC_CAPS_8BIT_MODE for 8bit mode support. + Typo.

Re: CVS commit: src/sys/dev/sdmmc

2010-09-20 Thread Tom Spindler
Modified Files: src/sys/dev/sdmmc: sdmmc_mem.c Did you miss committing a header file and/or further sets of patches? /usr/src/sys/dev/sdmmc/sdmmc_mem.c: In function 'sdmmc_mem_init': /usr/src/sys/dev/sdmmc/sdmmc_mem.c:476: error: 'SMC_CAPS_8BIT_MODE' undeclared (first use in this

CVS commit: src/sys/dev/sdmmc

2010-01-12 Thread Masao Uebayashi
Module Name:src Committed By: uebayasi Date: Tue Jan 12 08:41:16 UTC 2010 Modified Files: src/sys/dev/sdmmc: sdhc.c Log Message: According to SD Host Controller Simplified Specification Version 2.00, 2.2.10. Host Control Register (Offset 028h), the Data Transfer Width bit

CVS commit: src/sys/dev/sdmmc

2010-01-08 Thread David Young
Module Name:src Committed By: dyoung Date: Fri Jan 8 19:53:10 UTC 2010 Modified Files: src/sys/dev/sdmmc: sdhc.c sdhcvar.h Log Message: Expand PMF_FN_* macros. To generate a diff of this commit: cvs rdiff -u -r1.3 -r1.4 src/sys/dev/sdmmc/sdhc.c cvs rdiff -u -r1.1 -r1.2