CVS commit: src/sys/dev/sysmon

2019-08-26 Thread Takeshi Nakayama
Module Name:src Committed By: nakayama Date: Mon Aug 26 10:05:35 UTC 2019 Modified Files: src/sys/dev/sysmon: sysmon.c Log Message: Module class of sysmon_envsys, sysmon_wdog and sysmon_power is MODULE_CLASS_DRIVER, not MODULE_CLASS_MISC. Fix that invoking envsys without

CVS commit: src/sys/dev/sysmon

2019-08-26 Thread Takeshi Nakayama
Module Name:src Committed By: nakayama Date: Mon Aug 26 10:05:35 UTC 2019 Modified Files: src/sys/dev/sysmon: sysmon.c Log Message: Module class of sysmon_envsys, sysmon_wdog and sysmon_power is MODULE_CLASS_DRIVER, not MODULE_CLASS_MISC. Fix that invoking envsys without

CVS commit: src/sys/dev/sysmon

2019-08-20 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Aug 20 18:43:57 UTC 2019 Modified Files: src/sys/dev/sysmon: sysmon_power.c Log Message: Fix info leak, not all of 'pev' is initialized. To generate a diff of this commit: cvs rdiff -u -r1.60 -r1.61

CVS commit: src/sys/dev/sysmon

2019-08-20 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Aug 20 18:43:57 UTC 2019 Modified Files: src/sys/dev/sysmon: sysmon_power.c Log Message: Fix info leak, not all of 'pev' is initialized. To generate a diff of this commit: cvs rdiff -u -r1.60 -r1.61

Re: CVS commit: src/sys/dev/sysmon

2018-05-26 Thread Jason Thorpe
Unknown of course -- thorpej Sent from my iPhone. > On May 26, 2018, at 2:15 PM, Jason R Thorpe wrote: > > Module Name:src > Committed By:thorpej > Date:Sat May 26 21:15:46 UTC 2018 > > Modified Files: >src/sys/dev/sysmon: sysmon_envsys.c > > Log

Re: CVS commit: src/sys/dev/sysmon

2015-06-23 Thread Paul Goyette
yeah - done! thanks! On Tue, 23 Jun 2015, Christoph Badura wrote: On Tue, Jun 23, 2015 at 10:41:42AM +, Paul Goyette wrote: Committed By: pgoyette Date: Tue Jun 23 10:41:42 UTC 2015 Modified Files: src/sys/dev/sysmon: sysmon_envsys_events.c Log Message: Fix the

Re: CVS commit: src/sys/dev/sysmon

2015-06-23 Thread Christoph Badura
On Tue, Jun 23, 2015 at 10:41:42AM +, Paul Goyette wrote: Committed By: pgoyette Date: Tue Jun 23 10:41:42 UTC 2015 Modified Files: src/sys/dev/sysmon: sysmon_envsys_events.c Log Message: Fix the KASSERT - we want to make sure that _both_ pointers are non-NULL, not

Re: CVS commit: src/sys/dev/sysmon

2015-05-05 Thread Christos Zoulas
On May 5, 10:22am, p...@vps1.whooppee.com (Paul Goyette) wrote: -- Subject: Re: CVS commit: src/sys/dev/sysmon | On Tue, 5 May 2015, Christos Zoulas wrote: | | In article 20150505002825.9e50...@cvs.netbsd.org, | Paul Goyette source-changes-d@NetBSD.org wrote: | -=-=-=-=-=- | | Module Name

Re: CVS commit: src/sys/dev/sysmon

2015-05-05 Thread Paul Goyette
On Tue, 5 May 2015, Christos Zoulas wrote: | If module_autoload() returns an error, just return that value instead | of overwriting with ENODEV. | | | Yes, but break before the mutex_enter... | | Need to hold the mutex so we can release it below... Return error then? Yeah, possible. let

Re: CVS commit: src/sys/dev/sysmon

2015-05-04 Thread Paul Goyette
On Tue, 5 May 2015, Christos Zoulas wrote: In article 20150505002825.9e50...@cvs.netbsd.org, Paul Goyette source-changes-d@NetBSD.org wrote: -=-=-=-=-=- Module Name:src Committed By: pgoyette Date: Tue May 5 00:28:25 UTC 2015 Modified Files: src/sys/dev/sysmon:

Re: CVS commit: src/sys/dev/sysmon

2015-05-04 Thread Christos Zoulas
In article 20150504235036.d534...@cvs.netbsd.org, Paul Goyette source-changes-d@NetBSD.org wrote: -=-=-=-=-=- Module Name: src Committed By: pgoyette Date: Mon May 4 23:50:36 UTC 2015 Modified Files: src/sys/dev/sysmon: sysmon.c Log Message: If autoload of the subcomponent

Re: CVS commit: src/sys/dev/sysmon

2015-05-04 Thread Paul Goyette
On Tue, 5 May 2015, Christos Zoulas wrote: Module Name:src Committed By: pgoyette Date: Mon May 4 23:50:36 UTC 2015 Modified Files: src/sys/dev/sysmon: sysmon.c Log Message: If autoload of the subcomponent module fails, don't try to call its open routine. Just return

Re: CVS commit: src/sys/dev/sysmon

2015-05-04 Thread Christos Zoulas
In article 20150505002825.9e50...@cvs.netbsd.org, Paul Goyette source-changes-d@NetBSD.org wrote: -=-=-=-=-=- Module Name: src Committed By: pgoyette Date: Tue May 5 00:28:25 UTC 2015 Modified Files: src/sys/dev/sysmon: sysmon.c Log Message: If module_autoload() returns an

Re: CVS commit: src/sys/dev/sysmon

2015-04-28 Thread Taylor R Campbell
Date: Tue, 28 Apr 2015 17:01:10 +0800 (PHT) From: Paul Goyette p...@vps1.whooppee.com Well, it really is a (pseudo-)device, and even has its own major device number. We cannot avoid all of the device goop, since a non-built-in-module would still have to merge in the devsw.

Re: CVS commit: src/sys/dev/sysmon

2015-04-28 Thread Paul Goyette
Well, it really is a (pseudo-)device, and even has its own major device number. We cannot avoid all of the device goop, since a non-built-in-module would still have to merge in the devsw. My goal is to eventually be able to build and run a kernel which has no portion of sysmon built-in, and

Re: CVS commit: src/sys/dev/sysmon

2015-04-27 Thread Taylor R Campbell
Date: Thu, 23 Apr 2015 23:22:03 + From: Paul Goyette pgoye...@netbsd.org Modularize sysmon and its components Why does this introduce a sysmon(4) autoconf device? It seems like needless bookkeeping -- you could just make the mutex global, like all the state it protects, and skip

re: CVS commit: src/sys/dev/sysmon

2015-04-25 Thread matthew green
Christos Zoulas writes: Module Name: src Committed By: christos Date: Sat Apr 25 14:06:58 UTC 2015 Modified Files: src/sys/dev/sysmon: sysmon_envsys.c Log Message: make things boot again, from martin. thanks. updating to test now.. but shouldn't this use RUN_ONCE()

Re: CVS commit: src/sys/dev/sysmon

2015-04-25 Thread Paul Goyette
Done. Doing some testing now but should be ok. On Sat, 25 Apr 2015, Christos Zoulas wrote: In article 1723.1429983...@splode.eterna.com.au, matthew green m...@eterna.com.au wrote: Christos Zoulas writes: Module Name:src Committed By: christos Date: Sat Apr 25 14:06:58 UTC

Re: CVS commit: src/sys/dev/sysmon

2015-04-25 Thread Paul Goyette
Thanks. :) I'll get this (and the corresponding changes to sysmon_power and sysmon_wdog subcomponents) done shortly. On Sat, 25 Apr 2015, Christos Zoulas wrote: In article 1723.1429983...@splode.eterna.com.au, matthew green m...@eterna.com.au wrote: Christos Zoulas writes: Module

Re: CVS commit: src/sys/dev/sysmon

2015-04-25 Thread Jeff Rizzo
On 4/25/15 3:46 PM, Paul Goyette wrote: Module Name:src Committed By: pgoyette Date: Sat Apr 25 22:46:31 UTC 2015 + if (pmf_device_register(sysmon_dev, NULL, NULL)) + aprintf_error(%s: failed to register with pmf\n, I think you mean aprint_error. This

Re: CVS commit: src/sys/dev/sysmon

2015-04-25 Thread Paul Goyette
Ooops - this should have been two commits. Log message is correct for sysmon.c For the others, message has been corrected to read: Handle early initialization requirements - thanks martin@ and others On Sat, 25 Apr 2015, Paul Goyette wrote: Module Name:src Committed

Re: CVS commit: src/sys/dev/sysmon

2015-04-25 Thread Paul Goyette
Yup - fixing now... On Sat, 25 Apr 2015, Jeff Rizzo wrote: On 4/25/15 3:46 PM, Paul Goyette wrote: Module Name:src Committed By: pgoyette Date: Sat Apr 25 22:46:31 UTC 2015 + if (pmf_device_register(sysmon_dev, NULL, NULL)) + aprintf_error(%s: failed to

Re: CVS commit: src/sys/dev/sysmon

2015-04-25 Thread Christos Zoulas
In article 1723.1429983...@splode.eterna.com.au, matthew green m...@eterna.com.au wrote: Christos Zoulas writes: Module Name: src Committed By:christos Date:Sat Apr 25 14:06:58 UTC 2015 Modified Files: src/sys/dev/sysmon: sysmon_envsys.c Log Message: make

Re: CVS commit: src/sys/dev/sysmon

2011-06-19 Thread Paul Goyette
On Sun, 19 Jun 2011, Martin Husemann wrote: Module Name:src Committed By: martin Date: Sun Jun 19 11:40:26 UTC 2011 Modified Files: src/sys/dev/sysmon: sysmon_envsys.c Log Message: Instead of crashing, print a usable error message when a driver eroneously does not

Re: CVS commit: src/sys/dev/sysmon

2011-06-15 Thread Paul Goyette
On Wed, 15 Jun 2011, Paul Goyette wrote: Module Name:src Committed By: pgoyette Date: Wed Jun 15 13:34:13 UTC 2011 Modified Files: src/sys/dev/sysmon: sysmon_envsys.c Log Message: Previous fix broke the setting of current value for Indicator and Battery-Charge sensors.

Re: CVS commit: src/sys/dev/sysmon

2011-06-04 Thread Jukka Ruohonen
On Sat, Jun 04, 2011 at 01:24:33PM +, Paul Goyette wrote: Since nothing actually records or maintains an average sensor value, remove value_avg from the prop_dict. We can't completely remove it because there's one driver that uses this field for its own private purposes, so for now we

Re: CVS commit: src/sys/dev/sysmon

2011-06-04 Thread Paul Goyette
On Sat, 4 Jun 2011, Jukka Ruohonen wrote: On Sat, Jun 04, 2011 at 01:24:33PM +, Paul Goyette wrote: Since nothing actually records or maintains an average sensor value, remove value_avg from the prop_dict. We can't completely remove it because there's one driver that uses this field for

Re: CVS commit: src/sys/dev/sysmon

2010-10-23 Thread Antti Kantee
On Sat Oct 23 2010 at 01:49:25 +, Jonathan A. Kollasch wrote: On Wed, Oct 20, 2010 at 06:50:47PM +, Antti Kantee wrote: Module Name:src Committed By: pooka Date: Wed Oct 20 18:50:47 UTC 2010 Modified Files: src/sys/dev/sysmon: swsensor.c

Re: CVS commit: src/sys/dev/sysmon

2010-10-23 Thread Antti Kantee
On Sat Oct 23 2010 at 04:52:17 -0700, Paul Goyette wrote: On Sat, 23 Oct 2010, Antti Kantee wrote: This breaks the i386 ALL kernel. Ok, I put it back apart from the incorrect comment. Thanks. Yes, my bad for the incorrect comment. Sorry. If I got a penny every time I wrote an

Re: CVS commit: src/sys/dev/sysmon

2010-10-22 Thread Jonathan A. Kollasch
On Wed, Oct 20, 2010 at 06:50:47PM +, Antti Kantee wrote: Module Name: src Committed By: pooka Date: Wed Oct 20 18:50:47 UTC 2010 Modified Files: src/sys/dev/sysmon: swsensor.c Log Message: remove unused routine (per comment) To generate a diff of this commit:

CVS commit: src/sys/dev/sysmon

2010-02-14 Thread Paul Goyette
Module Name:src Committed By: pgoyette Date: Sun Feb 14 16:22:09 UTC 2010 Modified Files: src/sys/dev/sysmon: sysmon_envsys_events.c Log Message: Correct one more instance of checking flags in the wrong place. To generate a diff of this commit: cvs rdiff -u -r1.80

CVS commit: src/sys/dev/sysmon

2010-02-14 Thread Paul Goyette
Module Name:src Committed By: pgoyette Date: Sun Feb 14 23:30:52 UTC 2010 Modified Files: src/sys/dev/sysmon: sysmon_envsys_events.c Log Message: Replace large amount of replicated code with a macro to improve readability. To generate a diff of this commit: cvs rdiff -u

CVS commit: src/sys/dev/sysmon

2010-02-13 Thread Paul Goyette
Module Name:src Committed By: pgoyette Date: Sat Feb 13 19:34:14 UTC 2010 Modified Files: src/sys/dev/sysmon: sysmon_envsys_events.c Log Message: When checking current sensor value vs limits, check the correct set of flags to determine which limits are present. To

CVS commit: src/sys/dev/sysmon

2010-02-05 Thread Jukka Ruohonen
Module Name:src Committed By: jruoho Date: Fri Feb 5 19:22:25 UTC 2010 Modified Files: src/sys/dev/sysmon: sysmon_envsys_events.c Log Message: Fix a typo in one DPRINTF (s/edata-des/edata-desc/). To generate a diff of this commit: cvs rdiff -u -r1.78 -r1.79

CVS commit: src/sys/dev/sysmon

2010-02-04 Thread Paul Goyette
Module Name:src Committed By: pgoyette Date: Thu Feb 4 18:06:53 UTC 2010 Modified Files: src/sys/dev/sysmon: sysmon_envsys_events.c Log Message: If the AC adapter is flagged with SME_DISABLE_REFRESH, don't try to call its refresh() callback. Just assume that its value

CVS commit: src/sys/dev/sysmon

2010-01-30 Thread Antti Kantee
Module Name:src Committed By: pooka Date: Sun Jan 31 02:54:56 UTC 2010 Modified Files: src/sys/dev/sysmon: swwdog.c Log Message: print newline after timer expiry message To generate a diff of this commit: cvs rdiff -u -r1.8 -r1.9 src/sys/dev/sysmon/swwdog.c Please note

CVS commit: src/sys/dev/sysmon

2010-01-29 Thread Paul Goyette
Module Name:src Committed By: pgoyette Date: Sat Jan 30 02:46:53 UTC 2010 Modified Files: src/sys/dev/sysmon: sysmon_envsys.c sysmon_envsys_events.c Log Message: Validate limit-based monitoring in one place, so we can apply the constraints to both driver-requested and

CVS commit: src/sys/dev/sysmon

2010-01-18 Thread Paul Goyette
Module Name:src Committed By: pgoyette Date: Mon Jan 18 21:48:15 UTC 2010 Modified Files: src/sys/dev/sysmon: sysmon_envsys_events.c Log Message: If no limits are exceeded, make sure we set state to SVALID To generate a diff of this commit: cvs rdiff -u -r1.74 -r1.75

CVS commit: src/sys/dev/sysmon

2010-01-02 Thread Paul Goyette
Module Name:src Committed By: pgoyette Date: Sat Jan 2 19:02:40 UTC 2010 Modified Files: src/sys/dev/sysmon: sysmon_envsys_events.c Log Message: Flags for existence of limit values need to be propagated to the event data. Otherwise, they're not processed. XXX This

CVS commit: src/sys/dev/sysmon

2010-01-01 Thread Paul Goyette
Module Name:src Committed By: pgoyette Date: Fri Jan 1 15:41:25 UTC 2010 Modified Files: src/sys/dev/sysmon: sysmon_envsys_events.c Log Message: Don't infer a sensor driver's ability to handle limit checking itself. To generate a diff of this commit: cvs rdiff -u