Re: CVS commit: src/sys/dev/usb

2020-05-27 Thread Paul Goyette
On Wed, 27 May 2020, Taylor R Campbell wrote: Not really, because we just need to know whether usb_once_init has been run. OK, great! Now, should we use something other than RUN_ONCE, which can both set up and tear down? Sure, that might be better in principle, but there probably aren't

Re: CVS commit: src/sys/dev/usb

2020-05-27 Thread Taylor R Campbell
> Date: Wed, 27 May 2020 05:28:41 -0700 (PDT) > From: Paul Goyette > > Do you also need to decrement the number of busses when one is > detached? Not really, because we just need to know whether usb_once_init has been run. Now, should we use something other than RUN_ONCE, which can both set up

Re: CVS commit: src/sys/dev/usb

2020-05-27 Thread Paul Goyette
Do you also need to decrement the number of busses when one is detached? On Wed, 27 May 2020, Nick Hudson wrote: Module Name:src Committed By: skrll Date: Wed May 27 07:17:45 UTC 2020 Modified Files: src/sys/dev/usb: usb.c Log Message: Don't allow open of /dev/usb if

Re: CVS commit: src/sys/dev/usb

2020-04-02 Thread sc dying
On Thu, Apr 2, 2020 at 8:37 PM Nick Hudson wrote: > > Module Name:src > Committed By: skrll > Date: Thu Apr 2 11:37:23 UTC 2020 > > Modified Files: > src/sys/dev/usb: xhci.c xhcivar.h > > Log Message: > Reduce the memory footprint by allocating a ring per endpoint/pipe on

Re: CVS commit: src/sys/dev/usb

2020-03-23 Thread Maxime Villard
Le 23/03/2020 à 04:07, Roy Marples a écrit : > On 22/03/2020 08:30, Maxime Villard wrote: >> Overall "From OpenBSD" is a redflag for buggy and vulnerable code.. > > We should be above this, no software is perfect, not even ours. > > Roy You seem to be confusing one-off defects and structural

Re: CVS commit: src/sys/dev/usb

2020-03-22 Thread Roy Marples
On 22/03/2020 08:30, Maxime Villard wrote: Overall "From OpenBSD" is a redflag for buggy and vulnerable code.. We should be above this, no software is perfect, not even ours. Roy

Re: CVS commit: src/sys/dev/usb

2020-03-22 Thread Maxime Villard
Le 19/03/2020 à 08:49, Pierre Pronchery a écrit : > Module Name: src > Committed By: khorben > Date: Thu Mar 19 07:49:29 UTC 2020 > > Modified Files: > src/sys/dev/usb: if_umb.c > > Log Message: > When there is no network around the state timeout fires over and over again. >

Re: CVS commit: src/sys/dev/usb

2020-03-18 Thread Nick Hudson
On 18/03/2020 11:33, Robert Elz wrote: > Module Name: src > Committed By: kre > Date: Wed Mar 18 11:33:32 UTC 2020 > > Modified Files: > src/sys/dev/usb: if_aue.c > > Log Message: > This was still not correct,. USB_DEBUG is what mattered, not AUE_DEBUG, > the two are orthogonal.

Re: CVS commit: src/sys/dev/usb

2020-03-17 Thread Robert Elz
Date:Tue, 17 Mar 2020 22:58:24 -0400 From:"Christos Zoulas" Message-ID: <20200318025824.93b28f...@cvs.netbsd.org> | Log Message: | define un (pointed out by kre@) The reason I didn't suggest that change, is that now un is unused when USB_DEBUG is not defined.

Re: CVS commit: src/sys/dev/usb

2020-03-14 Thread Christos Zoulas
In article <20200314143238.gr5...@pony.stderr.spb.ru>, Valery Ushakov wrote: >How is is affected by the decision to change (or not) 0x%x to %#x? > This was in response to the statement: ... with a bit of patience might have been less drastic and as effective. christos

Re: CVS commit: src/sys/dev/usb

2020-03-14 Thread Valery Ushakov
On Sat, Mar 14, 2020 at 10:27:27 -0400, Christos Zoulas wrote: > > I don't belive that "if". It's like claiming you got rid of a stain > > on a wallpaper after you demolish a wall (not load-bearing, > > fortunately) and have to put it back and put new wallpaper. :) Get rid > > of the stain,

Re: CVS commit: src/sys/dev/usb

2020-03-14 Thread Christos Zoulas
> I don't belive that "if". It's like claiming you got rid of a stain > on a wallpaper after you demolish a wall (not load-bearing, > fortunately) and have to put it back and put new wallpaper. :) Get rid > of the stain, sure; but may be looking closely with a bit of patience > might have been

Re: CVS commit: src/sys/dev/usb

2020-03-14 Thread Valery Ushakov
On Sat, Mar 14, 2020 at 09:57:36 -0400, Christos Zoulas wrote: > > Even for the ones without the widths specified. E.g. I personally > > prefer zero printed as 0x0, not as 0, so I assume that when people > > choose either one that reflects their preference. Why mess with it? > > It's all so

Re: CVS commit: src/sys/dev/usb

2020-03-14 Thread Christos Zoulas
> Even for the ones without the widths specified. E.g. I personally > prefer zero printed as 0x0, not as 0, so I assume that when people > choose either one that reflects their preference. Why mess with it? > It's all so unnecessary. Yes, now we are discussing cosmetics (if 0 should be printed

re: CVS commit: src/sys/dev/usb

2020-03-14 Thread matthew green
> As I wrote in a follow up email, it changes formatting b/c you didn't > change field widths and IMO using %# with a field width is mostly > trouble to begin with. It's not the first time someone tries to do > this without actually understanding the consequences of the change. > Please, can we

Re: CVS commit: src/sys/dev/usb

2020-03-13 Thread Valery Ushakov
On Fri, Mar 13, 2020 at 22:26:05 -0400, Christos Zoulas wrote: > > On Mar 13, 2020, at 10:25 PM, Valery Ushakov wrote: > > > > As I wrote in a follow up email, it changes formatting b/c you didn't > > change field widths and IMO using %# with a field width is mostly > > trouble to begin with.

Re: CVS commit: src/sys/dev/usb

2020-03-13 Thread Christos Zoulas
> On Mar 13, 2020, at 10:25 PM, Valery Ushakov wrote: > > As I wrote in a follow up email, it changes formatting b/c you didn't > change field widths and IMO using %# with a field width is mostly > trouble to begin with. It's not the first time someone tries to do > this without actually

Re: CVS commit: src/sys/dev/usb

2020-03-13 Thread Valery Ushakov
On Fri, Mar 13, 2020 at 22:15:31 -0400, Christos Zoulas wrote: > > This was not a part of the PR and is completely cosmetic (surely it > > supports plain %x if it does support %#x). Why was this necessary? > > (I know I would be quite miffed if someone made a change like that to > > my code). >

Re: CVS commit: src/sys/dev/usb

2020-03-13 Thread Christos Zoulas
> This was not a part of the PR and is completely cosmetic (surely it > supports plain %x if it does support %#x). Why was this necessary? > (I know I would be quite miffed if someone made a change like that to > my code). Yes, that %x formatting change was not part of the PR, but I only

Re: CVS commit: src/sys/dev/usb

2020-03-13 Thread Valery Ushakov
On Fri, Mar 13, 2020 at 17:09:14 -0700, Paul Goyette wrote: > On Sat, 14 Mar 2020, Valery Ushakov wrote: > > > On Fri, Mar 13, 2020 at 14:17:42 -0400, Christos Zoulas wrote: > > > > > Log Message: > > > PR/55068: sc.dying: Fix printf formats: > > [...] > > > - 0x% -> %# > > > > This was not a

Re: CVS commit: src/sys/dev/usb

2020-03-13 Thread Paul Goyette
On Sat, 14 Mar 2020, Valery Ushakov wrote: On Fri, Mar 13, 2020 at 14:17:42 -0400, Christos Zoulas wrote: Log Message: PR/55068: sc.dying: Fix printf formats: [...] - 0x% -> %# This was not a part of the PR and is completely cosmetic (surely it supports plain %x if it does support %#x).

Re: CVS commit: src/sys/dev/usb

2020-03-13 Thread Valery Ushakov
On Fri, Mar 13, 2020 at 14:17:42 -0400, Christos Zoulas wrote: > Log Message: > PR/55068: sc.dying: Fix printf formats: [...] > - 0x% -> %# This was not a part of the PR and is completely cosmetic (surely it supports plain %x if it does support %#x). Why was this necessary? (I know I would be

Re: CVS commit: src/sys/dev/usb

2019-12-14 Thread maya
On Tue, Dec 03, 2019 at 05:01:45AM +, Taylor R Campbell wrote: > Module Name: src > Committed By: riastradh > Date: Tue Dec 3 05:01:45 UTC 2019 > > Modified Files: > src/sys/dev/usb: usbnet.c > > Log Message: > Fix order of nulling un->un_pri->unp_ec.ec_mii. > > Can't null

CVS commit: src/sys/dev/usb

2019-11-29 Thread Andreas Gustafsson
Module Name:src Committed By: gson Date: Fri Nov 29 14:15:42 UTC 2019 Modified Files: src/sys/dev/usb: ohci.c Log Message: Preserve the toggleCarry bit in the Endpoint Descriptor in ohci_abort_xfer(). Fixes the OHCI part of PR kern/50278. To generate a diff of this

CVS commit: src/sys/dev/usb

2019-11-29 Thread Andreas Gustafsson
Module Name:src Committed By: gson Date: Fri Nov 29 14:15:42 UTC 2019 Modified Files: src/sys/dev/usb: ohci.c Log Message: Preserve the toggleCarry bit in the Endpoint Descriptor in ohci_abort_xfer(). Fixes the OHCI part of PR kern/50278. To generate a diff of this

CVS commit: src/sys/dev/usb

2019-11-29 Thread Andreas Gustafsson
Module Name:src Committed By: gson Date: Fri Nov 29 14:13:04 UTC 2019 Modified Files: src/sys/dev/usb: ohci.c Log Message: Preserve the toggleCarry bit in the Endpoint Descriptor when handling a DataUnderrun condition. Fixes PR kern/54070. To generate a diff of this

CVS commit: src/sys/dev/usb

2019-11-29 Thread Andreas Gustafsson
Module Name:src Committed By: gson Date: Fri Nov 29 14:13:04 UTC 2019 Modified Files: src/sys/dev/usb: ohci.c Log Message: Preserve the toggleCarry bit in the Endpoint Descriptor when handling a DataUnderrun condition. Fixes PR kern/54070. To generate a diff of this

CVS commit: src/sys/dev/usb

2019-11-26 Thread Andreas Gustafsson
Module Name:src Committed By: gson Date: Tue Nov 26 10:34:16 UTC 2019 Modified Files: src/sys/dev/usb: if_urtwn.c Log Message: Change 0x%jx -> %#jx as suggested by christos. To generate a diff of this commit: cvs rdiff -u -r1.74 -r1.75 src/sys/dev/usb/if_urtwn.c Please

CVS commit: src/sys/dev/usb

2019-11-26 Thread Andreas Gustafsson
Module Name:src Committed By: gson Date: Tue Nov 26 10:34:16 UTC 2019 Modified Files: src/sys/dev/usb: if_urtwn.c Log Message: Change 0x%jx -> %#jx as suggested by christos. To generate a diff of this commit: cvs rdiff -u -r1.74 -r1.75 src/sys/dev/usb/if_urtwn.c Please

CVS commit: src/sys/dev/usb

2019-11-26 Thread Andreas Gustafsson
Module Name:src Committed By: gson Date: Tue Nov 26 10:24:17 UTC 2019 Modified Files: src/sys/dev/usb: if_urtwn.c Log Message: Convert debug printfs to usbhist. To generate a diff of this commit: cvs rdiff -u -r1.73 -r1.74 src/sys/dev/usb/if_urtwn.c Please note that

CVS commit: src/sys/dev/usb

2019-11-26 Thread Andreas Gustafsson
Module Name:src Committed By: gson Date: Tue Nov 26 10:24:17 UTC 2019 Modified Files: src/sys/dev/usb: if_urtwn.c Log Message: Convert debug printfs to usbhist. To generate a diff of this commit: cvs rdiff -u -r1.73 -r1.74 src/sys/dev/usb/if_urtwn.c Please note that

CVS commit: src/sys/dev/usb

2019-11-17 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Nov 17 11:28:48 UTC 2019 Modified Files: src/sys/dev/usb: vhci.c Log Message: Not a bug strictly speaking, but compute the address only after the length checks, for clarity and to appease kUBSan. To generate a diff of this

CVS commit: src/sys/dev/usb

2019-11-17 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Nov 17 11:28:48 UTC 2019 Modified Files: src/sys/dev/usb: vhci.c Log Message: Not a bug strictly speaking, but compute the address only after the length checks, for clarity and to appease kUBSan. To generate a diff of this

CVS commit: src/sys/dev/usb

2019-11-05 Thread matthew green
Module Name:src Committed By: mrg Date: Wed Nov 6 07:30:59 UTC 2019 Modified Files: src/sys/dev/usb: usbnet.c Log Message: add a note about ifnet lock vs usbnet locks. To generate a diff of this commit: cvs rdiff -u -r1.29 -r1.30 src/sys/dev/usb/usbnet.c Please note

CVS commit: src/sys/dev/usb

2019-11-05 Thread matthew green
Module Name:src Committed By: mrg Date: Wed Nov 6 07:30:59 UTC 2019 Modified Files: src/sys/dev/usb: usbnet.c Log Message: add a note about ifnet lock vs usbnet locks. To generate a diff of this commit: cvs rdiff -u -r1.29 -r1.30 src/sys/dev/usb/usbnet.c Please note

CVS commit: src/sys/dev/usb

2019-11-03 Thread Tetsuya Isaki
Module Name:src Committed By: isaki Date: Mon Nov 4 05:46:39 UTC 2019 Modified Files: src/sys/dev/usb: uaudio.c Log Message: Use kmem_zalloc() instead of kmem_alloc() to initialize structure. struct audio_format added a member since isaki-audio2. Fix PR kern/54662

CVS commit: src/sys/dev/usb

2019-11-03 Thread Tetsuya Isaki
Module Name:src Committed By: isaki Date: Mon Nov 4 05:46:39 UTC 2019 Modified Files: src/sys/dev/usb: uaudio.c Log Message: Use kmem_zalloc() instead of kmem_alloc() to initialize structure. struct audio_format added a member since isaki-audio2. Fix PR kern/54662

Re: CVS commit: src/sys/dev/usb

2019-10-31 Thread maya
On Thu, Oct 31, 2019 at 11:59:40AM +, Maya Rashish wrote: > Module Name: src > Committed By: maya > Date: Thu Oct 31 11:59:40 UTC 2019 > > Modified Files: > src/sys/dev/usb: if_urndis.c > > Log Message: > check if buf/bufsz are non-NULL before freeing. > > not all control

CVS commit: src/sys/dev/usb

2019-10-31 Thread Maya Rashish
Module Name:src Committed By: maya Date: Thu Oct 31 11:59:40 UTC 2019 Modified Files: src/sys/dev/usb: if_urndis.c Log Message: check if buf/bufsz are non-NULL before freeing. not all control messages that can be received result in buf being initialized, we might get a

CVS commit: src/sys/dev/usb

2019-10-31 Thread Maya Rashish
Module Name:src Committed By: maya Date: Thu Oct 31 11:59:40 UTC 2019 Modified Files: src/sys/dev/usb: if_urndis.c Log Message: check if buf/bufsz are non-NULL before freeing. not all control messages that can be received result in buf being initialized, we might get a

CVS commit: src/sys/dev/usb

2019-10-22 Thread Maya Rashish
Module Name:src Committed By: maya Date: Wed Oct 23 01:30:54 UTC 2019 Modified Files: src/sys/dev/usb: uvideo.c Log Message: we want to check that the allocation is going to be zero, not whether some pointer is NULL (oops). Should be the right version this time! To

CVS commit: src/sys/dev/usb

2019-10-22 Thread Maya Rashish
Module Name:src Committed By: maya Date: Wed Oct 23 01:30:54 UTC 2019 Modified Files: src/sys/dev/usb: uvideo.c Log Message: we want to check that the allocation is going to be zero, not whether some pointer is NULL (oops). Should be the right version this time! To

CVS commit: src/sys/dev/usb

2019-10-22 Thread Maya Rashish
Module Name:src Committed By: maya Date: Wed Oct 23 01:03:36 UTC 2019 Modified Files: src/sys/dev/usb: uvideo.c Log Message: Check if size is zero, too. PR kern/53734 To generate a diff of this commit: cvs rdiff -u -r1.50 -r1.51 src/sys/dev/usb/uvideo.c Please note

CVS commit: src/sys/dev/usb

2019-10-22 Thread Maya Rashish
Module Name:src Committed By: maya Date: Wed Oct 23 01:03:36 UTC 2019 Modified Files: src/sys/dev/usb: uvideo.c Log Message: Check if size is zero, too. PR kern/53734 To generate a diff of this commit: cvs rdiff -u -r1.50 -r1.51 src/sys/dev/usb/uvideo.c Please note

CVS commit: src/sys/dev/usb

2019-10-22 Thread Maya Rashish
Module Name:src Committed By: maya Date: Wed Oct 23 00:52:39 UTC 2019 Modified Files: src/sys/dev/usb: uvideo.c Log Message: Avoid kmem_alloc(0,..), which hits an assertion. PR kern/53734: Prevent kernel panic during Wide Vision FHD Camera detection To generate a diff

CVS commit: src/sys/dev/usb

2019-10-22 Thread Maya Rashish
Module Name:src Committed By: maya Date: Wed Oct 23 00:52:39 UTC 2019 Modified Files: src/sys/dev/usb: uvideo.c Log Message: Avoid kmem_alloc(0,..), which hits an assertion. PR kern/53734: Prevent kernel panic during Wide Vision FHD Camera detection To generate a diff

CVS commit: src/sys/dev/usb

2019-10-16 Thread Christoph Badura
Module Name:src Committed By: bad Date: Wed Oct 16 13:11:16 UTC 2019 Modified Files: src/sys/dev/usb: if_ure.c Log Message: allocate a random mac address if on-chip mac is all zeroes. helps ure(4) on NanoPi R1. partly from ganbold@freebsd r346052. XXX pullup-9 To

CVS commit: src/sys/dev/usb

2019-10-16 Thread Christoph Badura
Module Name:src Committed By: bad Date: Wed Oct 16 13:11:16 UTC 2019 Modified Files: src/sys/dev/usb: if_ure.c Log Message: allocate a random mac address if on-chip mac is all zeroes. helps ure(4) on NanoPi R1. partly from ganbold@freebsd r346052. XXX pullup-9 To

CVS commit: src/sys/dev/usb

2019-10-16 Thread Christoph Badura
Module Name:src Committed By: bad Date: Wed Oct 16 13:02:51 UTC 2019 Modified Files: src/sys/dev/usb: if_ure.c Log Message: read mac address of ure version 4c10 from URE_PLA_IDR, save as 4c00. from ganbold@freebsd r346052. XXX pullup-9 To generate a diff of this

CVS commit: src/sys/dev/usb

2019-10-16 Thread Christoph Badura
Module Name:src Committed By: bad Date: Wed Oct 16 13:02:51 UTC 2019 Modified Files: src/sys/dev/usb: if_ure.c Log Message: read mac address of ure version 4c10 from URE_PLA_IDR, save as 4c00. from ganbold@freebsd r346052. XXX pullup-9 To generate a diff of this

CVS commit: src/sys/dev/usb

2019-10-10 Thread Christoph Badura
Module Name:src Committed By: bad Date: Thu Oct 10 23:30:02 UTC 2019 Modified Files: src/sys/dev/usb: if_urtwn.c Log Message: use ether_snprintf instead of open coding it. To generate a diff of this commit: cvs rdiff -u -r1.72 -r1.73 src/sys/dev/usb/if_urtwn.c Please

CVS commit: src/sys/dev/usb

2019-10-10 Thread Christoph Badura
Module Name:src Committed By: bad Date: Thu Oct 10 23:30:02 UTC 2019 Modified Files: src/sys/dev/usb: if_urtwn.c Log Message: use ether_snprintf instead of open coding it. To generate a diff of this commit: cvs rdiff -u -r1.72 -r1.73 src/sys/dev/usb/if_urtwn.c Please

CVS commit: src/sys/dev/usb

2019-10-08 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Tue Oct 8 07:30:58 UTC 2019 Modified Files: src/sys/dev/usb: if_run.c if_runvar.h Log Message: Merge more changes from FreeBSD/OpenBSD. My two run(4) devices now work again. To generate a diff of this commit: cvs rdiff -u

CVS commit: src/sys/dev/usb

2019-10-08 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Tue Oct 8 07:30:58 UTC 2019 Modified Files: src/sys/dev/usb: if_run.c if_runvar.h Log Message: Merge more changes from FreeBSD/OpenBSD. My two run(4) devices now work again. To generate a diff of this commit: cvs rdiff -u

CVS commit: src/sys/dev/usb

2019-10-07 Thread Nick Hudson
Module Name:src Committed By: skrll Date: Mon Oct 7 09:37:16 UTC 2019 Modified Files: src/sys/dev/usb: if_udav.c Log Message: Avoid a warning To generate a diff of this commit: cvs rdiff -u -r1.71 -r1.72 src/sys/dev/usb/if_udav.c Please note that diffs are not public

CVS commit: src/sys/dev/usb

2019-10-07 Thread Nick Hudson
Module Name:src Committed By: skrll Date: Mon Oct 7 09:37:16 UTC 2019 Modified Files: src/sys/dev/usb: if_udav.c Log Message: Avoid a warning To generate a diff of this commit: cvs rdiff -u -r1.71 -r1.72 src/sys/dev/usb/if_udav.c Please note that diffs are not public

CVS commit: src/sys/dev/usb

2019-10-06 Thread Martin Husemann
Module Name:src Committed By: martin Date: Sun Oct 6 17:23:05 UTC 2019 Modified Files: src/sys/dev/usb: usbdevs.h usbdevs_data.h Log Message: Regen To generate a diff of this commit: cvs rdiff -u -r1.763 -r1.764 src/sys/dev/usb/usbdevs.h \

CVS commit: src/sys/dev/usb

2019-10-06 Thread Martin Husemann
Module Name:src Committed By: martin Date: Sun Oct 6 17:23:05 UTC 2019 Modified Files: src/sys/dev/usb: usbdevs.h usbdevs_data.h Log Message: Regen To generate a diff of this commit: cvs rdiff -u -r1.763 -r1.764 src/sys/dev/usb/usbdevs.h \

CVS commit: src/sys/dev/usb

2019-10-06 Thread Martin Husemann
Module Name:src Committed By: martin Date: Sun Oct 6 17:22:29 UTC 2019 Modified Files: src/sys/dev/usb: usbdevs Log Message: Add a few TP-Link "Archer" wlan devices To generate a diff of this commit: cvs rdiff -u -r1.773 -r1.774 src/sys/dev/usb/usbdevs Please note

CVS commit: src/sys/dev/usb

2019-10-06 Thread Martin Husemann
Module Name:src Committed By: martin Date: Sun Oct 6 17:22:29 UTC 2019 Modified Files: src/sys/dev/usb: usbdevs Log Message: Add a few TP-Link "Archer" wlan devices To generate a diff of this commit: cvs rdiff -u -r1.773 -r1.774 src/sys/dev/usb/usbdevs Please note

CVS commit: src/sys/dev/usb

2019-10-02 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Oct 3 05:20:31 UTC 2019 Modified Files: src/sys/dev/usb: usb_subr.c Log Message: Fix memory leaks. Was wondering where memory had gone after several hours of attach/detach with vHCI. To generate a diff of this commit: cvs

CVS commit: src/sys/dev/usb

2019-10-02 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Oct 3 05:20:31 UTC 2019 Modified Files: src/sys/dev/usb: usb_subr.c Log Message: Fix memory leaks. Was wondering where memory had gone after several hours of attach/detach with vHCI. To generate a diff of this commit: cvs

CVS commit: src/sys/dev/usb

2019-10-02 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Oct 3 05:16:16 UTC 2019 Modified Files: src/sys/dev/usb: umidi.c Log Message: More less kmem_zalloc(0). To generate a diff of this commit: cvs rdiff -u -r1.79 -r1.80 src/sys/dev/usb/umidi.c Please note that diffs are not

CVS commit: src/sys/dev/usb

2019-10-02 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Oct 3 05:16:16 UTC 2019 Modified Files: src/sys/dev/usb: umidi.c Log Message: More less kmem_zalloc(0). To generate a diff of this commit: cvs rdiff -u -r1.79 -r1.80 src/sys/dev/usb/umidi.c Please note that diffs are not

CVS commit: src/sys/dev/usb

2019-10-02 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Oct 3 05:13:24 UTC 2019 Modified Files: src/sys/dev/usb: vhci.c Log Message: Improvements: - Don't process packets if the USB device is detached. Contrary to the other HCIs, vHCI has no timeout, so we never collect the

CVS commit: src/sys/dev/usb

2019-09-25 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Thu Sep 26 01:35:08 UTC 2019 Modified Files: src/sys/dev/usb: usbdivar.h Log Message: subdevlen is an array length, make it unsigned To generate a diff of this commit: cvs rdiff -u -r1.118 -r1.119 src/sys/dev/usb/usbdivar.h

CVS commit: src/sys/dev/usb

2019-09-25 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Thu Sep 26 01:35:08 UTC 2019 Modified Files: src/sys/dev/usb: usbdivar.h Log Message: subdevlen is an array length, make it unsigned To generate a diff of this commit: cvs rdiff -u -r1.118 -r1.119 src/sys/dev/usb/usbdivar.h

CVS commit: src/sys/dev/usb

2019-09-22 Thread David Sainty
Module Name:src Committed By: dsainty Date: Sun Sep 22 07:29:16 UTC 2019 Modified Files: src/sys/dev/usb: ubt.c udsir.c Log Message: Purge an ancient email address, use dsai...@netbsd.org instead To generate a diff of this commit: cvs rdiff -u -r1.62 -r1.63

CVS commit: src/sys/dev/usb

2019-09-22 Thread David Sainty
Module Name:src Committed By: dsainty Date: Sun Sep 22 07:29:16 UTC 2019 Modified Files: src/sys/dev/usb: ubt.c udsir.c Log Message: Purge an ancient email address, use dsai...@netbsd.org instead To generate a diff of this commit: cvs rdiff -u -r1.62 -r1.63

CVS commit: src/sys/dev/usb

2019-09-22 Thread David Sainty
Module Name:src Committed By: dsainty Date: Sun Sep 22 07:28:35 UTC 2019 Modified Files: src/sys/dev/usb: ustir.c ustirreg.h Log Message: Purge an ancient email address, use dsai...@netbsd.org instead To generate a diff of this commit: cvs rdiff -u -r1.41 -r1.42

CVS commit: src/sys/dev/usb

2019-09-22 Thread David Sainty
Module Name:src Committed By: dsainty Date: Sun Sep 22 07:28:35 UTC 2019 Modified Files: src/sys/dev/usb: ustir.c ustirreg.h Log Message: Purge an ancient email address, use dsai...@netbsd.org instead To generate a diff of this commit: cvs rdiff -u -r1.41 -r1.42

CVS commit: src/sys/dev/usb

2019-09-15 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Sep 15 09:24:39 UTC 2019 Modified Files: src/sys/dev/usb: usb_subr.c Log Message: Reset ud_pipe0 to NULL before calling usbd_setup_pipe_flags(). If the call fails we call usbd_remove_device(), which tries to free ud_pipe0, but

CVS commit: src/sys/dev/usb

2019-09-15 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Sep 15 09:24:39 UTC 2019 Modified Files: src/sys/dev/usb: usb_subr.c Log Message: Reset ud_pipe0 to NULL before calling usbd_setup_pipe_flags(). If the call fails we call usbd_remove_device(), which tries to free ud_pipe0, but

CVS commit: src/sys/dev/usb

2019-09-15 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Sep 15 09:21:36 UTC 2019 Modified Files: src/sys/dev/usb: uvideo.c Log Message: Add missing length checks on descriptors, to prevent buffer overflows. Found via KASAN+vHCI. Some remain however, but it looks like the code needs

CVS commit: src/sys/dev/usb

2019-09-15 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Sep 15 09:21:36 UTC 2019 Modified Files: src/sys/dev/usb: uvideo.c Log Message: Add missing length checks on descriptors, to prevent buffer overflows. Found via KASAN+vHCI. Some remain however, but it looks like the code needs

CVS commit: src/sys/dev/usb

2019-09-15 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Sep 15 09:18:17 UTC 2019 Modified Files: src/sys/dev/usb: umidi.c Log Message: Don't kmem_alloc(0) if there are no endpoints, otherwise panic. Found via vHCI. To generate a diff of this commit: cvs rdiff -u -r1.78 -r1.79

CVS commit: src/sys/dev/usb

2019-09-15 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Sep 15 09:18:17 UTC 2019 Modified Files: src/sys/dev/usb: umidi.c Log Message: Don't kmem_alloc(0) if there are no endpoints, otherwise panic. Found via vHCI. To generate a diff of this commit: cvs rdiff -u -r1.78 -r1.79

CVS commit: src/sys/dev/usb

2019-09-14 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Sep 14 15:24:23 UTC 2019 Modified Files: src/sys/dev/usb: udl.c udl.h Log Message: Fix error handling, to prevent kernel crashes at detach time. The code is slightly reorganized. Found via vHCI. To generate a diff of this

CVS commit: src/sys/dev/usb

2019-09-14 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Sep 14 15:24:23 UTC 2019 Modified Files: src/sys/dev/usb: udl.c udl.h Log Message: Fix error handling, to prevent kernel crashes at detach time. The code is slightly reorganized. Found via vHCI. To generate a diff of this

CVS commit: src/sys/dev/usb

2019-09-14 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Sep 14 15:22:31 UTC 2019 Modified Files: src/sys/dev/usb: usscanner.c Log Message: Fix NULL deref. Found by vHCI. To generate a diff of this commit: cvs rdiff -u -r1.44 -r1.45 src/sys/dev/usb/usscanner.c Please note that

CVS commit: src/sys/dev/usb

2019-09-14 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Sep 14 15:22:31 UTC 2019 Modified Files: src/sys/dev/usb: usscanner.c Log Message: Fix NULL deref. Found by vHCI. To generate a diff of this commit: cvs rdiff -u -r1.44 -r1.45 src/sys/dev/usb/usscanner.c Please note that

CVS commit: src/sys/dev/usb

2019-09-14 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Sep 14 15:21:19 UTC 2019 Modified Files: src/sys/dev/usb: ustir.c Log Message: Fix error handling, to prevent kernel crashes at detach time. Found by vHCI. To generate a diff of this commit: cvs rdiff -u -r1.40 -r1.41

CVS commit: src/sys/dev/usb

2019-09-14 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Sep 14 15:21:19 UTC 2019 Modified Files: src/sys/dev/usb: ustir.c Log Message: Fix error handling, to prevent kernel crashes at detach time. Found by vHCI. To generate a diff of this commit: cvs rdiff -u -r1.40 -r1.41

CVS commit: src/sys/dev/usb

2019-09-14 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Sep 14 15:19:52 UTC 2019 Modified Files: src/sys/dev/usb: uvisor.c Log Message: Fix possible NULL deref. Found by vHCI. To generate a diff of this commit: cvs rdiff -u -r1.51 -r1.52 src/sys/dev/usb/uvisor.c Please note that

CVS commit: src/sys/dev/usb

2019-09-14 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Sep 14 15:19:52 UTC 2019 Modified Files: src/sys/dev/usb: uvisor.c Log Message: Fix possible NULL deref. Found by vHCI. To generate a diff of this commit: cvs rdiff -u -r1.51 -r1.52 src/sys/dev/usb/uvisor.c Please note that

CVS commit: src/sys/dev/usb

2019-09-14 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Sep 14 12:53:24 UTC 2019 Modified Files: src/sys/dev/usb: if_upgt.c if_upgtvar.h Log Message: Fix error handling, to prevent kernel crashes when detaching an upgt0 device. Found with vHCI. To generate a diff of this commit:

CVS commit: src/sys/dev/usb

2019-09-14 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Sep 14 12:53:24 UTC 2019 Modified Files: src/sys/dev/usb: if_upgt.c if_upgtvar.h Log Message: Fix error handling, to prevent kernel crashes when detaching an upgt0 device. Found with vHCI. To generate a diff of this commit:

CVS commit: src/sys/dev/usb

2019-09-14 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Sep 14 12:50:16 UTC 2019 Modified Files: src/sys/dev/usb: udsbr.c Log Message: Fix NULL deref, to prevent kernel crashes when detaching an udsbr0 device. Found with vHCI. To generate a diff of this commit: cvs rdiff -u

CVS commit: src/sys/dev/usb

2019-09-14 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Sep 14 12:50:16 UTC 2019 Modified Files: src/sys/dev/usb: udsbr.c Log Message: Fix NULL deref, to prevent kernel crashes when detaching an udsbr0 device. Found with vHCI. To generate a diff of this commit: cvs rdiff -u

CVS commit: src/sys/dev/usb

2019-09-14 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Sep 14 12:48:51 UTC 2019 Modified Files: src/sys/dev/usb: ugensa.c Log Message: Fix error handling, to prevent kernel crashes when detaching an ugensa0 device. Also move usbd_add_drv_event() down, after we are sure the attach

CVS commit: src/sys/dev/usb

2019-09-14 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Sep 14 12:48:51 UTC 2019 Modified Files: src/sys/dev/usb: ugensa.c Log Message: Fix error handling, to prevent kernel crashes when detaching an ugensa0 device. Also move usbd_add_drv_event() down, after we are sure the attach

CVS commit: src/sys/dev/usb

2019-09-14 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Sep 14 12:46:00 UTC 2019 Modified Files: src/sys/dev/usb: uipaq.c Log Message: Fix NULL deref, to prevent kernel crashes when detaching an uipaq0 device. Found with vHCI. To generate a diff of this commit: cvs rdiff -u

CVS commit: src/sys/dev/usb

2019-09-14 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Sep 14 12:46:00 UTC 2019 Modified Files: src/sys/dev/usb: uipaq.c Log Message: Fix NULL deref, to prevent kernel crashes when detaching an uipaq0 device. Found with vHCI. To generate a diff of this commit: cvs rdiff -u

CVS commit: src/sys/dev/usb

2019-09-14 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Sep 14 12:42:36 UTC 2019 Modified Files: src/sys/dev/usb: if_ural.c if_uralvar.h Log Message: Fix error handling, to prevent kernel crashes when detaching an ural0 device. Found with vHCI. To generate a diff of this commit:

CVS commit: src/sys/dev/usb

2019-09-14 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Sep 14 12:42:36 UTC 2019 Modified Files: src/sys/dev/usb: if_ural.c if_uralvar.h Log Message: Fix error handling, to prevent kernel crashes when detaching an ural0 device. Found with vHCI. To generate a diff of this commit:

CVS commit: src/sys/dev/usb

2019-09-14 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Sep 14 12:41:32 UTC 2019 Modified Files: src/sys/dev/usb: urio.c Log Message: Fix error handling, to prevent kernel crashes when detaching an urio0 device. Found with vHCI. To generate a diff of this commit: cvs rdiff -u

CVS commit: src/sys/dev/usb

2019-09-14 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Sep 14 12:41:32 UTC 2019 Modified Files: src/sys/dev/usb: urio.c Log Message: Fix error handling, to prevent kernel crashes when detaching an urio0 device. Found with vHCI. To generate a diff of this commit: cvs rdiff -u

CVS commit: src/sys/dev/usb

2019-09-14 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Sep 14 12:40:31 UTC 2019 Modified Files: src/sys/dev/usb: if_urtw.c if_urtwreg.h Log Message: Fix error handling, to prevent kernel crashes when detaching an urtw0 device. Also, fail safely if we didn't recognize the RF chip,

CVS commit: src/sys/dev/usb

2019-09-14 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Sep 14 12:40:31 UTC 2019 Modified Files: src/sys/dev/usb: if_urtw.c if_urtwreg.h Log Message: Fix error handling, to prevent kernel crashes when detaching an urtw0 device. Also, fail safely if we didn't recognize the RF chip,

CVS commit: src/sys/dev/usb

2019-09-14 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Sep 14 12:38:40 UTC 2019 Modified Files: src/sys/dev/usb: umcs.c Log Message: Fix error handling, to prevent kernel crashes when detaching an umcs0 device. Found with vHCI. To generate a diff of this commit: cvs rdiff -u

  1   2   3   4   5   6   >