Re: CVS commit: src/sys/dev - lm(4)

2017-07-18 Thread Masanobu SAITOH

Hi.

On 2017/07/16 9:44, Paul Goyette wrote:

Module Name:src
Committed By:   msaitoh
Date:   Tue Jul 11 10:10:51 UTC 2017

Modified Files:
src/sys/dev/ic: nslm7x.c nslm7xvar.h
src/sys/dev/isa: wbsio.c wbsioreg.h

Log Message:
lm(4): Add suport for NCT5174D, NCT6775F, NCT6779D and NCT679[1235]D.
wbsio(4): Add support for NCT6795D.



Are you sure about the various RFACT values?


Tested only on two machines. One is NCT6779D and another is NCT6792D.
And, only 5V, 3.3V(,SB) and VBAT were tested. Nuvoton's voltage I/O is for
+-2.0V, It's required to use appropriate pullup/pulldown registers to
get correct vaules. There is no way to get the register factors by
software. I think we can change the "default" register factors better
than now.




 I'm getting some very
strange voltage readings from this device, as well as some odd fan
speeds.  Interestingly, most of the reported temperature values seem
reasonable, although there may be one entry missing (the BIOS reports
on seven temperatures, but envstat shows only six).

 From dmesg we see:

...
wbsio0 at isa0 port 0x2e-0x2f: Nuvoton LPC Super I/O NCT6791D rev 0x03
...
lm0 at wbsio0 port 0x290-0x297
lm0: Using default temp sensors
lm0: Nuvoton NCT6791D Hardware monitor
...


And here is what envstat reports on my system:

# envstat -d lm0
Current  CritMax  WarnMax  WarnMin  CritMin  Unit
   VCore: 0.888 V
VIN1: 6.653 V
AVCC: 3.328 V
   +3.3V: 3.328 V
VIN0:11.814 V
VIN8:   N/A
VIN4: 0.784 V
 +3.3VSB: 3.456 V
VBAT: 3.392 V
 VTT: 2.096 V
VIN5: 1.440 V
VIN6: 0.624 V
VIN2: 0.592 V
VIN3: 1.602 V
VIN7: 0.744 V
  MB Temperature:35.000  degC
CPU Temperature:43.000  degC
   Aux Temp0:80.000  degC
   Aux Temp1:42.000  degC
   Aux Temp2:82.000  degC
   Aux Temp3:40.000  degC
  System Fan: 14088   RPM
 CPU Fan: 11030   RPM
Aux Fan0:   N/A
Aux Fan1:   N/A
Aux Fan2:   N/A


According to the Motherboard/BIOS monitoring page,

CoreV  =   1.021V
 3.3V  =   3.328V   You got this one right!
   5V  =   5.040V   This might be VIN1?
  12V  =  12.096V   And this might be VIN0?
  DRAMV/AB =   1.199V
  DRAMV/CD =   1.198V

 MoBo Temp =  37C
  CPU Temp =  44C
 PCIE16_1 Temp =  42C   (perhaps these are the Aux Temps?
 PCIE16_2 Temp =  41C   At least two out of three values
 PCIE16_3 Temp =  41C   are reasonable.)
  VRM Temp =  47C
  PCH Temp =  48C

   CPU Fan = 1035 RPM   (1K, not 10K!)


 Before my commit, only NCT6776F was supported. I don't know
that code was correct or not. It would be good to see linux's
drivers/hwmon/nct6775.c. I've not read whole of the code yet...


   CPU Opt Fan = 1363 RPM
 Chassis-1 Fan =  785 RPM

(It's not clear whether envstat's "System Fan" corresponds to the "CPU Opt Fan" or to 
"Chassis-1 Fan"; the BIOS reports three fan values but envstat only has two valid values.)


+--+--++
| Paul Goyette | PGP Key fingerprint: | E-mail addresses:  |
| (Retired)| FA29 0E3B 35AF E8AE 6651 | paul at whooppee dot com   |
| Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at netbsd dot org |
+--+--++



--
---
SAITOH Masanobu (msai...@execsw.org
 msai...@netbsd.org)


Re: CVS commit: src/sys/dev - lm(4)

2017-07-15 Thread Paul Goyette

Module Name:src
Committed By:   msaitoh
Date:   Tue Jul 11 10:10:51 UTC 2017

Modified Files:
src/sys/dev/ic: nslm7x.c nslm7xvar.h
src/sys/dev/isa: wbsio.c wbsioreg.h

Log Message:
lm(4): Add suport for NCT5174D, NCT6775F, NCT6779D and NCT679[1235]D.
wbsio(4): Add support for NCT6795D.



Are you sure about the various RFACT values?  I'm getting some very
strange voltage readings from this device, as well as some odd fan
speeds.  Interestingly, most of the reported temperature values seem
reasonable, although there may be one entry missing (the BIOS reports
on seven temperatures, but envstat shows only six).


From dmesg we see:


...
wbsio0 at isa0 port 0x2e-0x2f: Nuvoton LPC Super I/O NCT6791D rev 0x03
...
lm0 at wbsio0 port 0x290-0x297
lm0: Using default temp sensors
lm0: Nuvoton NCT6791D Hardware monitor
...


And here is what envstat reports on my system:

# envstat -d lm0
   Current  CritMax  WarnMax  WarnMin  CritMin  Unit
  VCore: 0.888 V
   VIN1: 6.653 V
   AVCC: 3.328 V
  +3.3V: 3.328 V
   VIN0:11.814 V
   VIN8:   N/A
   VIN4: 0.784 V
+3.3VSB: 3.456 V
   VBAT: 3.392 V
VTT: 2.096 V
   VIN5: 1.440 V
   VIN6: 0.624 V
   VIN2: 0.592 V
   VIN3: 1.602 V
   VIN7: 0.744 V
 MB Temperature:35.000  degC
CPU Temperature:43.000  degC
  Aux Temp0:80.000  degC
  Aux Temp1:42.000  degC
  Aux Temp2:82.000  degC
  Aux Temp3:40.000  degC
 System Fan: 14088   RPM
CPU Fan: 11030   RPM
   Aux Fan0:   N/A
   Aux Fan1:   N/A
   Aux Fan2:   N/A


According to the Motherboard/BIOS monitoring page,

   CoreV  =   1.021V
3.3V  =   3.328V   You got this one right!
  5V  =   5.040V   This might be VIN1?
 12V  =  12.096V   And this might be VIN0?
 DRAMV/AB =   1.199V
 DRAMV/CD =   1.198V

MoBo Temp =  37C
 CPU Temp =  44C
PCIE16_1 Temp =  42C   (perhaps these are the Aux Temps?
PCIE16_2 Temp =  41C   At least two out of three values
PCIE16_3 Temp =  41C   are reasonable.)
 VRM Temp =  47C
 PCH Temp =  48C

  CPU Fan = 1035 RPM   (1K, not 10K!)
  CPU Opt Fan = 1363 RPM
Chassis-1 Fan =  785 RPM

(It's not clear whether envstat's "System Fan" corresponds to the "CPU 
Opt Fan" or to "Chassis-1 Fan"; the BIOS reports three fan values but 
envstat only has two valid values.)



+--+--++
| Paul Goyette | PGP Key fingerprint: | E-mail addresses:  |
| (Retired)| FA29 0E3B 35AF E8AE 6651 | paul at whooppee dot com   |
| Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at netbsd dot org |
+--+--++