CVS commit: src/sys/fs/msdosfs

2024-09-10 Thread Konrad Schroder
Module Name:src Committed By: perseant Date: Wed Sep 11 00:27:54 UTC 2024 Modified Files: src/sys/fs/msdosfs: msdosfs_vnops.c Log Message: Move the comment intended to introduce msdosfs_fsync back above msdosfs_fsync (it has been above the wrong function since 1996). No fu

CVS commit: src/sys/fs/msdosfs

2024-09-10 Thread Konrad Schroder
Module Name:src Committed By: perseant Date: Wed Sep 11 00:27:54 UTC 2024 Modified Files: src/sys/fs/msdosfs: msdosfs_vnops.c Log Message: Move the comment intended to introduce msdosfs_fsync back above msdosfs_fsync (it has been above the wrong function since 1996). No fu

CVS commit: src/sys/fs/msdosfs

2024-05-03 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Sat May 4 05:49:39 UTC 2024 Modified Files: src/sys/fs/msdosfs: msdosfs_rename.c Log Message: >From genfs_rename.c: * XXX Want a better equality test. `tcnp->cn_cred == cred' * hoses p2k because puffs transmi

CVS commit: src/sys/fs/msdosfs

2024-05-03 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Sat May 4 05:49:39 UTC 2024 Modified Files: src/sys/fs/msdosfs: msdosfs_rename.c Log Message: >From genfs_rename.c: * XXX Want a better equality test. `tcnp->cn_cred == cred' * hoses p2k because puffs transmi

CVS commit: src/sys/fs/msdosfs

2023-08-18 Thread matthew green
Module Name:src Committed By: mrg Date: Fri Aug 18 21:05:44 UTC 2023 Modified Files: src/sys/fs/msdosfs: msdosfs_vnops.c Log Message: fix the previous to not fail to include the extension in lookups. copy deExtension into the final 3 bytes. previously, this was found by

CVS commit: src/sys/fs/msdosfs

2023-08-18 Thread matthew green
Module Name:src Committed By: mrg Date: Fri Aug 18 21:05:44 UTC 2023 Modified Files: src/sys/fs/msdosfs: msdosfs_vnops.c Log Message: fix the previous to not fail to include the extension in lookups. copy deExtension into the final 3 bytes. previously, this was found by

CVS commit: src/sys/fs/msdosfs

2023-08-13 Thread matthew green
Module Name:src Committed By: mrg Date: Mon Aug 14 05:41:09 UTC 2023 Modified Files: src/sys/fs/msdosfs: msdosfs_vnops.c Log Message: when calling a function that needs more bytes than we have, create a stack variable long enough and use that instead. found by GCC 12. T

CVS commit: src/sys/fs/msdosfs

2023-08-13 Thread matthew green
Module Name:src Committed By: mrg Date: Mon Aug 14 05:41:09 UTC 2023 Modified Files: src/sys/fs/msdosfs: msdosfs_vnops.c Log Message: when calling a function that needs more bytes than we have, create a stack variable long enough and use that instead. found by GCC 12. T

CVS commit: src/sys/fs/msdosfs

2023-02-13 Thread Andrius Varanavicius
Module Name:src Committed By: andvar Date: Mon Feb 13 23:14:21 UTC 2023 Modified Files: src/sys/fs/msdosfs: msdosfs_conv.c Log Message: s/chacters/characters/ in comments. To generate a diff of this commit: cvs rdiff -u -r1.18 -r1.19 src/sys/fs/msdosfs/msdosfs_conv.c Pl

CVS commit: src/sys/fs/msdosfs

2023-02-13 Thread Andrius Varanavicius
Module Name:src Committed By: andvar Date: Mon Feb 13 23:14:21 UTC 2023 Modified Files: src/sys/fs/msdosfs: msdosfs_conv.c Log Message: s/chacters/characters/ in comments. To generate a diff of this commit: cvs rdiff -u -r1.18 -r1.19 src/sys/fs/msdosfs/msdosfs_conv.c Pl

CVS commit: src/sys/fs/msdosfs

2022-04-16 Thread Juergen Hannken-Illjes
Module Name:src Committed By: hannken Date: Sat Apr 16 07:58:21 UTC 2022 Modified Files: src/sys/fs/msdosfs: msdosfs_vfsops.c Log Message: Lock vnode for vinvalbuf(). To generate a diff of this commit: cvs rdiff -u -r1.137 -r1.138 src/sys/fs/msdosfs/msdosfs_vfsops.c Ple

CVS commit: src/sys/fs/msdosfs

2022-04-16 Thread Juergen Hannken-Illjes
Module Name:src Committed By: hannken Date: Sat Apr 16 07:58:21 UTC 2022 Modified Files: src/sys/fs/msdosfs: msdosfs_vfsops.c Log Message: Lock vnode for vinvalbuf(). To generate a diff of this commit: cvs rdiff -u -r1.137 -r1.138 src/sys/fs/msdosfs/msdosfs_vfsops.c Ple

CVS commit: src/sys/fs/msdosfs

2021-10-23 Thread Juergen Hannken-Illjes
Module Name:src Committed By: hannken Date: Sat Oct 23 07:45:03 UTC 2021 Modified Files: src/sys/fs/msdosfs: denode.h msdosfs_rename.c Log Message: Convert msdosfs_rename() to use genfs_sane_rename(). Based on work by Taylor R Campbell. To generate a diff of this commit

CVS commit: src/sys/fs/msdosfs

2021-10-23 Thread Juergen Hannken-Illjes
Module Name:src Committed By: hannken Date: Sat Oct 23 07:45:03 UTC 2021 Modified Files: src/sys/fs/msdosfs: denode.h msdosfs_rename.c Log Message: Convert msdosfs_rename() to use genfs_sane_rename(). Based on work by Taylor R Campbell. To generate a diff of this commit

Re: CVS commit: src/sys/fs/msdosfs

2014-08-12 Thread David Laight
On Sun, Jul 13, 2014 at 04:34:59PM +0200, Martin Husemann wrote: > On Sun, Jul 13, 2014 at 04:31:58PM +0200, Martin Husemann wrote: > > Why does lsof define _KERNEL ? > > Let me rephrase: we provide the userland important stuff when either _KERNEL > or MAKEFS is defined - maybe MAKEFS should be re

Re: CVS commit: src/sys/fs/msdosfs

2014-07-14 Thread Martin Husemann
On Mon, Jul 14, 2014 at 10:26:58AM +0200, Joerg Sonnenberger wrote: > > MSDOSFS_MOUNT_USERLAND_DEFS or something. > > lsof inherently want to mess with the kernel details, i.e. to try to > rediscover the original path name used to open a file etc. Yes, but some other parts in that file are really

Re: CVS commit: src/sys/fs/msdosfs

2014-07-14 Thread Joerg Sonnenberger
On Sun, Jul 13, 2014 at 04:34:59PM +0200, Martin Husemann wrote: > On Sun, Jul 13, 2014 at 04:31:58PM +0200, Martin Husemann wrote: > > Why does lsof define _KERNEL ? > > Let me rephrase: we provide the userland important stuff when either _KERNEL > or MAKEFS is defined - maybe MAKEFS should be re

Re: CVS commit: src/sys/fs/msdosfs

2014-07-13 Thread Martin Husemann
On Sun, Jul 13, 2014 at 04:31:58PM +0200, Martin Husemann wrote: > Why does lsof define _KERNEL ? Let me rephrase: we provide the userland important stuff when either _KERNEL or MAKEFS is defined - maybe MAKEFS should be renamed and lsof could use the new define instead of _KERNEL. MSDOSFS_MOUNT_

Re: CVS commit: src/sys/fs/msdosfs

2014-07-13 Thread Martin Husemann
On Sun, Jul 13, 2014 at 04:15:47PM +0200, J. Hannken-Illjes wrote: > Maybe a patch to lsof/dialects/n+obsd/dlsof.h like > > #if defined (NETBSDV) > #define VFS_PROTOS(dummy) /**/ > #endif > > before including msdosfsmount.h? Why does lsof define _KERNEL ? Martin

Re: CVS commit: src/sys/fs/msdosfs

2014-07-13 Thread J. Hannken-Illjes
On 13 Jul 2014, at 15:36, Joerg Sonnenberger wrote: > On Tue, Jul 08, 2014 at 09:21:52AM +, Juergen Hannken-Illjes wrote: >> Module Name: src >> Committed By:hannken >> Date:Tue Jul 8 09:21:52 UTC 2014 >> >> Modified Files: >> src/sys/fs/msdosfs: denode.h msdosf

Re: CVS commit: src/sys/fs/msdosfs

2014-07-13 Thread Joerg Sonnenberger
On Tue, Jul 08, 2014 at 09:21:52AM +, Juergen Hannken-Illjes wrote: > Module Name: src > Committed By: hannken > Date: Tue Jul 8 09:21:52 UTC 2014 > > Modified Files: > src/sys/fs/msdosfs: denode.h msdosfs_denode.c msdosfs_lookup.c > msdosfs_vfsops.c msdosfs_vnops.c m

Re: CVS commit: src/sys/fs/msdosfs

2012-07-06 Thread Christos Zoulas
On Jul 6, 9:54pm, tsut...@ceres.dti.ne.jp (Izumi Tsutsui) wrote: -- Subject: Re: CVS commit: src/sys/fs/msdosfs | getdisksize() returns error from ioctl's directly. | (because it's a kernel function?) | | How about this dumb patch? LGTM, go for it. christos

Re: CVS commit: src/sys/fs/msdosfs

2012-07-06 Thread Izumi Tsutsui
christos@ wrote: > On Jul 5, 3:37am, tsut...@ceres.dti.ne.jp (Izumi Tsutsui) wrote: > -- Subject: Re: CVS commit: src/sys/fs/msdosfs > > | > Well, I am not sure if KASSERT() is the best solution here. But > | > what else can we do? I agree that there should be at

Re: CVS commit: src/sys/fs/msdosfs

2012-07-04 Thread Christos Zoulas
On Jul 5, 3:37am, tsut...@ceres.dti.ne.jp (Izumi Tsutsui) wrote: -- Subject: Re: CVS commit: src/sys/fs/msdosfs | > Well, I am not sure if KASSERT() is the best solution here. But | > what else can we do? I agree that there should be at least a | > warning. | | Check | (secsize != 0 &

Re: CVS commit: src/sys/fs/msdosfs

2012-07-04 Thread Izumi Tsutsui
christos@ wrote: > | Anyway KASSERT() (or sanity check) should also be centralized > | to getdisksize()? > > Well, I am not sure if KASSERT() is the best solution here. But > what else can we do? I agree that there should be at least a > warning. Check (secsize != 0 && secsize <= MAXBSIZE && pow

Re: CVS commit: src/sys/fs/msdosfs

2012-07-04 Thread Christos Zoulas
On Jul 5, 1:34am, tsut...@ceres.dti.ne.jp (Izumi Tsutsui) wrote: -- Subject: Re: CVS commit: src/sys/fs/msdosfs | Hmm, as you say md(4) would have failed in msdosfs_mountfs() | even before getdisksize() was introduced and the only problem | was in disklabel support addition to md(4). That is

Re: CVS commit: src/sys/fs/msdosfs

2012-07-04 Thread Izumi Tsutsui
christos@ wrote: > In article <120704210521.m0104...@mirage.ceres.dti.ne.jp>, > Izumi Tsutsui wrote: > > > >The problem is getdisksize() was introduced after 5.0 > >and it assumed DIOCGPART always returned valid values, > >but no one confirmed if the assumption was correct. > > What do you thin

Re: CVS commit: src/sys/fs/msdosfs

2012-07-04 Thread Christos Zoulas
In article <120704210521.m0104...@mirage.ceres.dti.ne.jp>, Izumi Tsutsui wrote: > >The problem is getdisksize() was introduced after 5.0 >and it assumed DIOCGPART always returned valid values, >but no one confirmed if the assumption was correct. What do you think the drivers called before to get

Re: CVS commit: src/sys/fs/msdosfs

2012-07-04 Thread Izumi Tsutsui
dholland@ wrote: > On Wed, Jul 04, 2012 at 01:45:08AM +0900, Izumi Tsutsui wrote: > > > getdisksize() is not complicated; it tries DIOCGPART and then > > > DIOCGWEDGEINFO and that's about it. > > > > Yes, but it is not implementation issue but design issue. > > > > > I think it's wrong for

Re: CVS commit: src/sys/fs/msdosfs

2012-07-03 Thread David Holland
On Wed, Jul 04, 2012 at 01:45:08AM +0900, Izumi Tsutsui wrote: > > getdisksize() is not complicated; it tries DIOCGPART and then > > DIOCGWEDGEINFO and that's about it. > > Yes, but it is not implementation issue but design issue. > > > I think it's wrong for either of those to be returning

Re: CVS commit: src/sys/fs/msdosfs

2012-07-03 Thread Izumi Tsutsui
dholland@ wrote: > On Tue, Jul 03, 2012 at 08:01:21PM +0900, Izumi Tsutsui wrote: > > > } Add a sanity check if secsize returned from getdisksize() isn't bogus. > > > } This prevent possible panic "panic: buf mem pool index 23" later in > > > } vfs_bio.c:buf_mempoolidx(). > > > } (I'm not sure

Re: CVS commit: src/sys/fs/msdosfs

2012-07-03 Thread David Holland
On Tue, Jul 03, 2012 at 08:01:21PM +0900, Izumi Tsutsui wrote: > > } Add a sanity check if secsize returned from getdisksize() isn't bogus. > > } This prevent possible panic "panic: buf mem pool index 23" later in > > } vfs_bio.c:buf_mempoolidx(). > > } (I'm not sure if it's okay for getdisksiz

Re: CVS commit: src/sys/fs/msdosfs

2012-07-03 Thread Izumi Tsutsui
jnemeth@ wrote: > On Nov 20, 5:37am, "Izumi Tsutsui" wrote: > } > } Module Name:src > } Committed By: tsutsui > } Date: Sat Jun 30 11:01:42 UTC 2012 > } > } Modified Files: > } src/sys/fs/msdosfs: msdosfs_vfsops.c > } > } Log Message: > } Add a sanity check if s

Re: CVS commit: src/sys/fs/msdosfs

2012-07-02 Thread John Nemeth
On Nov 20, 5:37am, "Izumi Tsutsui" wrote: } } Module Name: src } Committed By: tsutsui } Date: Sat Jun 30 11:01:42 UTC 2012 } } Modified Files: } src/sys/fs/msdosfs: msdosfs_vfsops.c } } Log Message: } Add a sanity check if secsize returned from getdisksize() isn't bogus. } This

Re: CVS commit: src/sys/fs/msdosfs

2011-03-03 Thread Matthias Scheler
On Thu, Mar 03, 2011 at 11:12:35AM +0200, Antti Kantee wrote: > > Is he perhaps using "USE_SSP=yes"? > > Isn't that the default? Only for kernels and certain directories e.g. "src/lib/libc". Maybe we should: 1.) Build all tests with "USE_SSP=yes". 2.) Run them with "MALLOC_OPTIONS" set to "AJ".

Re: CVS commit: src/sys/fs/msdosfs

2011-03-03 Thread Antti Kantee
On Thu Mar 03 2011 at 09:00:39 +, Matthias Scheler wrote: > On Thu, Mar 03, 2011 at 08:10:45AM +, Antti Kantee wrote: > > Module Name:src > > Committed By: pooka > > Date: Thu Mar 3 08:10:45 UTC 2011 > > > > Modified Files: > > src/sys/fs/msdosfs: msdosfs_v

Re: CVS commit: src/sys/fs/msdosfs

2011-03-03 Thread Matthias Scheler
On Thu, Mar 03, 2011 at 08:10:45AM +, Antti Kantee wrote: > Module Name: src > Committed By: pooka > Date: Thu Mar 3 08:10:45 UTC 2011 > > Modified Files: > src/sys/fs/msdosfs: msdosfs_vnops.c > > Log Message: > In rename, use char[12]?for new names instead of [11]. At least

Re: CVS commit: src/sys/fs/msdosfs

2010-07-31 Thread Antti Kantee
On Fri Jul 30 2010 at 16:40:43 +, Michael van Elst wrote: > Module Name: src > Committed By: mlelstv > Date: Fri Jul 30 16:40:43 UTC 2010 > > Modified Files: > src/sys/fs/msdosfs: msdosfs_lookup.c > > Log Message: > Return EINVAL for rename and delete operations to the > root d

CVS commit: src/sys/fs/msdosfs

2010-01-31 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Sun Jan 31 10:30:41 UTC 2010 Modified Files: src/sys/fs/msdosfs: msdosfs_vfsops.c Log Message: Replace individual queries for partition information with new helper function. To generate a diff of this commit: cvs rdiff -u -r1.7

CVS commit: src/sys/fs/msdosfs

2010-01-26 Thread Joerg Sonnenberger
Module Name:src Committed By: joerg Date: Tue Jan 26 20:25:52 UTC 2010 Modified Files: src/sys/fs/msdosfs: msdosfs_fat.c Log Message: On broken filesystems the fillinmap inner loop may have never read a block, so don't try to release it if bp==NULL. To generate a diff of

CVS commit: src/sys/fs/msdosfs

2010-01-25 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Mon Jan 25 15:30:44 UTC 2010 Modified Files: src/sys/fs/msdosfs: msdosfs_vfsops.c Log Message: Fetch sector size also from wedges. To generate a diff of this commit: cvs rdiff -u -r1.76 -r1.77 src/sys/fs/msdosfs/msdosfs_vfsops.